RosterIn commented on pull request #9908:
URL: https://github.com/apache/airflow/pull/9908#issuecomment-683241421
@feluelle can you check?
This is an automated message from the Apache Git Service.
To respond to the message,
mik-laj commented on a change in pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#discussion_r479604102
##
File path: airflow/cli/commands/connection_command.py
##
@@ -250,3 +259,77 @@ def connections_delete(args):
msg = '\n\tSuccessfully
mik-laj commented on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-683229729
I haven't finished the review yet because I noticed one problem with
LocalFileBackend. I will come back to this.
https://github.com/apache/airflow/pull/10638/files
mik-laj commented on a change in pull request #10638:
URL: https://github.com/apache/airflow/pull/10638#discussion_r479601274
##
File path: airflow/secrets/local_filesystem.py
##
@@ -235,33 +235,33 @@ def load_variables(file_path: str) -> Dict[str, str]:
return variables
mik-laj opened a new pull request #10638:
URL: https://github.com/apache/airflow/pull/10638
Commented inline
---
**^ Add meaningful description above**
Read the **[Pull Request
luozhaoyu edited a comment on issue #10541:
URL: https://github.com/apache/airflow/issues/10541#issuecomment-683225572
I also encountered the same issue using:
1. manifest generated from helm chart master branch
2. KubernetesPodOperator
3. using both minikube and a real k8s cluster
luozhaoyu commented on issue #10541:
URL: https://github.com/apache/airflow/issues/10541#issuecomment-683225572
I also encountered the same issue using:
1. manifest generated from helm chart master branch
2. KubernetesPodOperator
3. using both minikube and a real k8s cluster
mik-laj commented on a change in pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#discussion_r479597334
##
File path: airflow/cli/commands/variable_command.py
##
@@ -66,44 +68,82 @@ def variables_delete(args):
Variable.delete(args.key)
mik-laj commented on a change in pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#discussion_r479597361
##
File path: airflow/cli/commands/variable_command.py
##
@@ -66,44 +68,82 @@ def variables_delete(args):
Variable.delete(args.key)
mik-laj commented on a change in pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#discussion_r479597151
##
File path: airflow/cli/commands/connection_command.py
##
@@ -25,18 +25,35 @@
import pygments
import yaml
from pygments.lexers.data import YamlLexer
mik-laj commented on a change in pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#discussion_r479596427
##
File path: tests/cli/commands/test_connection_command.py
##
@@ -502,7 +521,7 @@ def tearDownClass(cls):
"--conn-port=9083",
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from 725bf33 (commit)
to e495be9 (commit)
from
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from 725bf33 (commit)
to e495be9 (commit)
from
OmairK commented on a change in pull request #9597:
URL: https://github.com/apache/airflow/pull/9597#discussion_r479585913
##
File path: airflow/api_connexion/endpoints/task_instance_endpoint.py
##
@@ -14,39 +14,234 @@
# KIND, either express or implied. See the License for
[
https://issues.apache.org/jira/browse/AIRFLOW-3381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186863#comment-17186863
]
ASF GitHub Bot commented on AIRFLOW-3381:
-
AnumSheraz commented on pull request #4221:
URL:
AnumSheraz commented on pull request #4221:
URL: https://github.com/apache/airflow/pull/4221#issuecomment-683204025
Why this change never got merged ???
This is an automated message from the Apache Git Service.
To respond
[
https://issues.apache.org/jira/browse/AIRFLOW-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186862#comment-17186862
]
ASF GitHub Bot commented on AIRFLOW-1424:
-
alexbegg edited a comment on pull request #2460:
alexbegg edited a comment on pull request #2460:
URL: https://github.com/apache/airflow/pull/2460#issuecomment-683156113
@ultrabug @ryw FYI, I just made a PR to correct the "Start Date" tooltip to
actually show the real start date (it was showing the execution date in RBAC
UI)
yesemsanthoshkumar commented on a change in pull request #10343:
URL: https://github.com/apache/airflow/pull/10343#discussion_r479562688
##
File path: tests/providers/google/cloud/operators/test_dataproc.py
##
@@ -434,7 +591,10 @@ def test_execute(self, mock_hook):
atsalolikhin-spokeo commented on a change in pull request #10413:
URL: https://github.com/apache/airflow/pull/10413#discussion_r479552845
##
File path: docs/howto/initialize-database.rst
##
@@ -48,11 +48,48 @@ SqlAlchemy backend. We recommend using **MySQL** or
**Postgres**.
[
https://issues.apache.org/jira/browse/AIRFLOW-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186821#comment-17186821
]
ASF GitHub Bot commented on AIRFLOW-1424:
-
ryw commented on pull request #2460:
URL:
ryw commented on pull request #2460:
URL: https://github.com/apache/airflow/pull/2460#issuecomment-683158654
Yes, I think showing two dates in that pop up is better than a new column
for now, and accomplishes the goal that @ultrabug set out to accomplish.
What do you think
[
https://issues.apache.org/jira/browse/AIRFLOW-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186818#comment-17186818
]
ASF GitHub Bot commented on AIRFLOW-1424:
-
alexbegg commented on pull request #2460:
URL:
alexbegg commented on pull request #2460:
URL: https://github.com/apache/airflow/pull/2460#issuecomment-683156113
@ultrabug @ryw FYI, I just made a PR to correct the "Start Date" tooltip to
actually show the real start date (it was showing the execution date in RBAC
UI)
mik-laj commented on a change in pull request #10413:
URL: https://github.com/apache/airflow/pull/10413#discussion_r479543634
##
File path: docs/howto/initialize-database.rst
##
@@ -48,11 +48,46 @@ SqlAlchemy backend. We recommend using **MySQL** or
**Postgres**.
want to
mik-laj commented on pull request #10618:
URL: https://github.com/apache/airflow/pull/10618#issuecomment-683146976
> :x: CI Build / Static checks: no pylint (pull_request) Failing after 6m —
Static checks: no pylint
> :x: CI Build / Spell check docs (pull_request) Failing after 5m —
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-master by this
push:
new cc159ee Updating
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-master by this
push:
new cc159ee Updating
OmairK edited a comment on pull request #280:
URL: https://github.com/apache/airflow-site/pull/280#issuecomment-683133023
> Should we merge @OmairK ? Or do you plan to add more content ?
@potiuk I just remembered something I wanted to add. I will ping you for the
review, sorry for
OmairK commented on pull request #280:
URL: https://github.com/apache/airflow-site/pull/280#issuecomment-683133023
> Should we merge @OmairK ? Or do you plan to add more content ?
> Should we merge @OmairK ? Or do you plan to add more content ?
@potiuk I just
jhtimmins commented on pull request #10409:
URL: https://github.com/apache/airflow/pull/10409#issuecomment-683131565
@mik-laj Yeah, that branch is built on top of this one. I'll close this out.
This is an automated message
jhtimmins closed pull request #10409:
URL: https://github.com/apache/airflow/pull/10409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
potiuk commented on issue #10605:
URL: https://github.com/apache/airflow/issues/10605#issuecomment-683129444
would you like to add this feature @mickaelgervais ? I am happy to review it
This is an automated message from the
potiuk commented on issue #9781:
URL: https://github.com/apache/airflow/issues/9781#issuecomment-683121704
1.10.12 has been released and that was one last blocker - I will take a look
at preparing release of backports tomorrow :)
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 7200835 Improve output of check_environment.sh (#10631)
add e495be9 Update scheduler deployment - dags
potiuk merged pull request #10630:
URL: https://github.com/apache/airflow/pull/10630
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on pull request #280:
URL: https://github.com/apache/airflow-site/pull/280#issuecomment-683119214
Should we merge @OmairK ? Or do you plan to add more content ?
This is an automated message from the Apache
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 7200835 Improve output of
potiuk merged pull request #10631:
URL: https://github.com/apache/airflow/pull/10631
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on a change in pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#discussion_r479503960
##
File path: airflow/models/taskinstance.py
##
@@ -1184,7 +1184,7 @@ def signal_handler(signum, frame): # pylint:
disable=unused-argument
ryw commented on issue #10523:
URL: https://github.com/apache/airflow/issues/10523#issuecomment-683111290
@schnie what do we need to do here? is there an issue that clearly captures
the steps we need to take to reduce community confusion?
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1b533f6 Fix broken master - DLP (#10635)
add 8e0d9f0 Add airflow cheat-sheet command (#10619)
No new
potiuk commented on issue #9669:
URL: https://github.com/apache/airflow/issues/9669#issuecomment-683101526
Assigned you :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1b533f6 Fix broken master - DLP (#10635)
add 8e0d9f0 Add airflow cheat-sheet command (#10619)
No new
potiuk merged pull request #10619:
URL: https://github.com/apache/airflow/pull/10619
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mik-laj commented on pull request #10619:
URL: https://github.com/apache/airflow/pull/10619#issuecomment-683099482
I added one missing dependency - termcolor. It have an MIT license.
This is an automated message from the
anubhav562 commented on issue #9669:
URL: https://github.com/apache/airflow/issues/9669#issuecomment-683096365
Hey @JeffryMAC, I was able to reproduce this issue. I would like to work on
this issue and would love to contribute to the source code. Any idea on how do
we get ourselves
mik-laj commented on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-683087035
Fix has been merged. Can you do a rebase?
This is an automated message from the Apache Git Service.
To respond
alexbegg opened a new pull request #10637:
URL: https://github.com/apache/airflow/pull/10637
Closes: #10350
Replaces PR https://github.com/apache/airflow/pull/10556
It has been reported that the last run's execution date was incorrectly
showing for both the last run's link text
michalmisiewicz opened a new issue #10636:
URL: https://github.com/apache/airflow/issues/10636
**Apache Airflow version**: 1.10.10, 1.10.11, 1.10.12
**Kubernetes version (if you are using kubernetes)** (use `kubectl
version`): 1.15.11, 1.17.7
**Environment**:
-
battlesnake closed issue #10626:
URL: https://github.com/apache/airflow/issues/10626
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
battlesnake commented on issue #10626:
URL: https://github.com/apache/airflow/issues/10626#issuecomment-683025880
:facepalm: Thanks, some how I've not noticed that previously.
This is an automated message from the Apache Git
alexbegg edited a comment on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682991309
> @ryw not sure how they could diverge given they sue the same data value.
Is that from an older Airflow version? The different/shorter formatting of the
the tooltip
alexbegg edited a comment on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682991309
> @ryw not sure how they could diverge given they sue the same data value.
Is that from an older Airflow version? The different/shorter formatting of the
the tooltip
ryanahamilton commented on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682998207
Thanks for the leg-work @alexbegg!
Closing this PR given the discovery that this is a regression that requires
a slightly different fix (that @alexbegg intends on
ryanahamilton closed pull request #10556:
URL: https://github.com/apache/airflow/pull/10556
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dimon222 commented on pull request #9908:
URL: https://github.com/apache/airflow/pull/9908#issuecomment-682993970
This works very well!
This is an automated message from the Apache Git Service.
To respond to the message,
alexbegg edited a comment on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682991309
> @ryw not sure how they could diverge given they sue the same data value.
Is that from an older Airflow version? The different/shorter formatting of the
the tooltip
alexbegg edited a comment on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682991309
> @ryw not sure how they could diverge given they sue the same data value.
Is that from an older Airflow version? The different/shorter formatting of the
the tooltip
chattarajoy commented on a change in pull request #10599:
URL: https://github.com/apache/airflow/pull/10599#discussion_r479453510
##
File path: airflow/providers/qubole/hooks/qubole.py
##
@@ -239,12 +241,12 @@ def create_cmd_args(self, context):
alexbegg commented on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682992342
> I don't think it was intentional, no, but someone would have to git bisect
to work out when the change was made to be sure
@ashb I did the investigation using git
alexbegg commented on pull request #10556:
URL: https://github.com/apache/airflow/pull/10556#issuecomment-682991309
> @ryw not sure how they could diverge given they sue the same data value.
Is that from an older Airflow version? The different/shorter formatting of the
the tooltip date
chattarajoy commented on pull request #10599:
URL: https://github.com/apache/airflow/pull/10599#issuecomment-682991015
Upgrade the version of qds sdk to latest in the requirements.
This is an automated message from the
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 8969b71 Removed bad characters from AWS operator (#10590)
add 1b533f6 Fix broken master - DLP (#10635)
This is an automated email from the ASF dual-hosted git repository.
turbaszek pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 8969b71 Removed bad characters from AWS operator (#10590)
add 1b533f6 Fix broken master - DLP (#10635)
utkarsharma2 commented on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-682966375
> We are working on it. See: #10635
Thanks for the update.
This is an automated message from the
turbaszek merged pull request #10635:
URL: https://github.com/apache/airflow/pull/10635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dimon222 commented on issue #8212:
URL: https://github.com/apache/airflow/issues/8212#issuecomment-682955409
Update - new solution is adding gevent monkey patching to top of
`config_templates/airflow_local_settings.py`. It works.
mik-laj commented on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-682926520
We are working on it. See: https://github.com/apache/airflow/pull/10635
This is an automated message from the
utkarsharma2 commented on pull request #9907:
URL: https://github.com/apache/airflow/pull/9907#issuecomment-682896035
@mik-laj, there are two checks which are failing - CI Build / Static checks:
no pylint and CI Build / Static checks: pylint, but I have not made those
changes in file
millertracy closed pull request #10591:
URL: https://github.com/apache/airflow/pull/10591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
mik-laj opened a new pull request #10635:
URL: https://github.com/apache/airflow/pull/10635
pylint
> airflow/providers/google/cloud/operators/dlp.py:523:16: F821 undefined
name 'InvalidArgument'
> airflow/providers/google/cloud/operators/dlp.py:626:16: F821 undefined
name
mik-laj edited a comment on pull request #10333:
URL: https://github.com/apache/airflow/pull/10333#issuecomment-682752638
Can you squash al commits and do a rebase?
This is an automated message from the Apache Git Service.
flvndh commented on issue #10634:
URL: https://github.com/apache/airflow/issues/10634#issuecomment-682795737
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mik-laj opened a new issue #10634:
URL: https://github.com/apache/airflow/issues/10634
Hello,
It would be helpful to create the [values.schema.json
file](https://helm.sh/docs/topics/charts/#schema-files) file to validate
values.yaml file.
@flvndh Can you please leave a
mik-laj commented on pull request #10254:
URL: https://github.com/apache/airflow/pull/10254#issuecomment-682755517
CI is sad. Can you fix it?
This is an automated message from the Apache Git Service.
To respond to the
mik-laj commented on pull request #10333:
URL: https://github.com/apache/airflow/pull/10333#issuecomment-682752638
Can you quash al commits and do a rebase?
This is an automated message from the Apache Git Service.
To
mik-laj commented on pull request #10409:
URL: https://github.com/apache/airflow/pull/10409#issuecomment-682738625
Duplicate of: https://github.com/apache/airflow/pull/10594?
@houqp Can you look here? https://github.com/apache/airflow/pull/10594
mjpieters opened a new pull request #10633:
URL: https://github.com/apache/airflow/pull/10633
This is my fix for the statsd timers reporting values as milliseconds. This
pull request is essentially a backport of two pull request:
- #6682 (already merged)
- #10632 (my pull request
mik-laj commented on pull request #10482:
URL: https://github.com/apache/airflow/pull/10482#issuecomment-682723417
> :x: CI Build / Build docs (pull_request) Failing after 8m — Build docs
> :x: CI Build / Spell check docs (pull_request) Failing after 5m — Spell
check docs
Can you
boring-cyborg[bot] commented on pull request #10632:
URL: https://github.com/apache/airflow/pull/10632#issuecomment-682716995
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
mjpieters opened a new pull request #10632:
URL: https://github.com/apache/airflow/pull/10632
This is best achieved by passing a `timedelta()` to `Stats.timing()`, and
leave worrying about time units to that method.
This is my fix for #10629, for the master branch. A separate pull
flvndh commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682710498
@mik-laj I'd be glad to help you with this as well
This is an automated message from the Apache Git Service.
mik-laj commented on issue #10626:
URL: https://github.com/apache/airflow/issues/10626#issuecomment-682700428
Here is docs about DAG.doc:
https://airflow.readthedocs.io/en/latest/concepts.html#documentation-notes
This is
mik-laj commented on a change in pull request #10631:
URL: https://github.com/apache/airflow/pull/10631#discussion_r479365546
##
File path: scripts/in_container/check_environment.sh
##
@@ -43,7 +43,7 @@ function check_service {
MAX_CHECK=$((MAX_CHECK-1))
mik-laj opened a new pull request #10631:
URL: https://github.com/apache/airflow/pull/10631
https://user-images.githubusercontent.com/12058428/91582861-b580e400-e950-11ea-8bdf-983c0672d446.png;>
---
**^ Add meaningful description above**
Read the **[Pull Request
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 8969b71 Removed bad characters from AWS
mik-laj merged pull request #10590:
URL: https://github.com/apache/airflow/pull/10590
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/AIRFLOW-6542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17186591#comment-17186591
]
ASF GitHub Bot commented on AIRFLOW-6542:
-
janarthanandev commented on pull request #7163:
URL:
janarthanandev commented on pull request #7163:
URL: https://github.com/apache/airflow/pull/7163#issuecomment-682663370
@roitvt any update on backport package for cncf.kubernetes
This is an automated message from the
mik-laj commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682661264
Good catch! What are your plans for your next contribution? Would you be
interested in creating the [values.schema.json
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 5f403a8 Wrong key in DAGs Persistent
boring-cyborg[bot] commented on pull request #10627:
URL: https://github.com/apache/airflow/pull/10627#issuecomment-682655927
Awesome work, congrats on your first merged pull request!
This is an automated message from
mik-laj merged pull request #10627:
URL: https://github.com/apache/airflow/pull/10627
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gardnerdev opened a new pull request #10630:
URL: https://github.com/apache/airflow/pull/10630
Adding dags volume mount to scheduler definition. Before that, dags were
fetched only to web server and worker
This is an
mik-laj commented on pull request #10618:
URL: https://github.com/apache/airflow/pull/10618#issuecomment-682646678
We have a conflict. Can you do a rebase?
This is an automated message from the Apache Git Service.
To respond
mik-laj commented on issue #9780:
URL: https://github.com/apache/airflow/issues/9780#issuecomment-682643031
@mahadirz If you test it and see that it works can you let us know and close
the ticket, please?
This is an
mik-laj closed issue #10113:
URL: https://github.com/apache/airflow/issues/10113
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mik-laj commented on issue #10113:
URL: https://github.com/apache/airflow/issues/10113#issuecomment-682641246
@kundan1301 We no longer update operators in Airflow 1.10. I recommend
installing backport packages.
https://github.com/apache/airflow#backport-packages
mik-laj commented on issue #9781:
URL: https://github.com/apache/airflow/issues/9781#issuecomment-682635451
It's planned to release soon: See:
https://github.com/apache/airflow/issues/9781
This is an automated message from
1 - 100 of 153 matches
Mail list logo
