[GitHub] [airflow] msumit commented on pull request #10681: Add Stacktrace when DagFileProcessorManager gets killed

2020-09-02 Thread GitBox
msumit commented on pull request #10681: URL: https://github.com/apache/airflow/pull/10681#issuecomment-686250837 @potiuk @XD-DENG can you guys approve it, if looks fine? This is an automated message from the Apache Git

[airflow] tag nightly-master updated (f40ac9b -> 4e09cb5)

2020-09-02 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from f40ac9b (commit) to 4e09cb5 (commit) from

[airflow] branch 1-10-yaml-generator created (now ebe7149)

2020-09-02 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch 1-10-yaml-generator in repository https://gitbox.apache.org/repos/asf/airflow.git. at ebe7149 add generate_yaml to 1.10 This branch includes the following new commits: new

[airflow] 02/02: add generate_yaml to 1.10

2020-09-02 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch 1-10-yaml-generator in repository https://gitbox.apache.org/repos/asf/airflow.git commit ebe71491fc1c8e6489d4417e543ec5de23736943 Author: Daniel Imberman AuthorDate: Wed Sep 2 18:37:59 2020

[airflow] 01/02: YAML Generation function

2020-09-02 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch 1-10-yaml-generator in repository https://gitbox.apache.org/repos/asf/airflow.git commit ca376853360c6fcbed033122e1ca11ad1d19d429 Author: Daniel Imberman AuthorDate: Wed Sep 2 18:07:26 2020

[airflow] branch 1-10-yaml-generator created (now ebe7149)

2020-09-02 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch 1-10-yaml-generator in repository https://gitbox.apache.org/repos/asf/airflow.git. at ebe7149 add generate_yaml to 1.10 This branch includes the following new commits: new

[airflow] 01/02: YAML Generation function

2020-09-02 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch 1-10-yaml-generator in repository https://gitbox.apache.org/repos/asf/airflow.git commit ca376853360c6fcbed033122e1ca11ad1d19d429 Author: Daniel Imberman AuthorDate: Wed Sep 2 18:07:26 2020

[airflow] 02/02: add generate_yaml to 1.10

2020-09-02 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch 1-10-yaml-generator in repository https://gitbox.apache.org/repos/asf/airflow.git commit ebe71491fc1c8e6489d4417e543ec5de23736943 Author: Daniel Imberman AuthorDate: Wed Sep 2 18:37:59 2020

[GitHub] [airflow] jsaradhy opened a new issue #10704: Unable to Stop / Kill the currently running Airflow DAG programmatically.

2020-09-02 Thread GitBox
jsaradhy opened a new issue #10704: URL: https://github.com/apache/airflow/issues/10704 I have an usecase, we are implementing the automation with Gitlab, AWS S3 & Codepipeline, Code & Airflow. In a nutshell when there is a new version of the dag is available in the DAG BAG, i need to

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10704: Unable to Stop / Kill the currently running Airflow DAG programmatically.

2020-09-02 Thread GitBox
boring-cyborg[bot] commented on issue #10704: URL: https://github.com/apache/airflow/issues/10704#issuecomment-686174687 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] atsalolikhin-spokeo commented on issue #523: SQL Alchemy Connection String - How to store password?

2020-09-02 Thread GitBox
atsalolikhin-spokeo commented on issue #523: URL: https://github.com/apache/airflow/issues/523#issuecomment-686163715 I don't see this in the [FAQ](https://airflow.apache.org/docs/stable/faq.html) I am trying to figure out how to store a password in Airflow variable table. I see

[GitHub] [airflow] lopesdiego12 opened a new pull request #10703: Update INTHEWILD.md

2020-09-02 Thread GitBox
lopesdiego12 opened a new pull request #10703: URL: https://github.com/apache/airflow/pull/10703 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482607325 ## File path: tests/cli/commands/test_dag_command.py ## @@ -139,6 +140,19 @@ def test_show_dag_print(self): self.assertIn("graph

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482606828 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482606477 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482606210 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10690: Change the name of Static Check without pylint

2020-09-02 Thread GitBox
kaxil commented on a change in pull request #10690: URL: https://github.com/apache/airflow/pull/10690#discussion_r482602474 ## File path: .github/workflows/ci.yml ## @@ -155,7 +155,7 @@ jobs: static-checks: timeout-minutes: 30 -name: "Static checks: no pylint" +

[GitHub] [airflow] alexbegg edited a comment on issue #10279: Tooltips not show up in Safari

2020-09-02 Thread GitBox
alexbegg edited a comment on issue #10279: URL: https://github.com/apache/airflow/issues/10279#issuecomment-686075093 I was able to reproduce the problem, partially, but only when RBAC UI was not enabled. I noticed that in Safari the only tooltips that is not working is the ones for the

[GitHub] [airflow] paolaperaza commented on issue #7940: DagRuns are marked as failed as soon as one task fails

2020-09-02 Thread GitBox
paolaperaza commented on issue #7940: URL: https://github.com/apache/airflow/issues/7940#issuecomment-686090091 @dimberman FYI looks like this is a duplicate of: https://github.com/apache/airflow/issues/7939 This is an

[GitHub] [airflow] paolaperaza commented on issue #7926: Kill task instances that haven't been able to heartbeat for a while

2020-09-02 Thread GitBox
paolaperaza commented on issue #7926: URL: https://github.com/apache/airflow/issues/7926#issuecomment-686089514 @dimberman FYI Looks like this is a duplicate of: https://github.com/apache/airflow/issues/7925 This is an

[GitHub] [airflow] jhtimmins commented on a change in pull request #10594: WIP: Add permissions for stable API

2020-09-02 Thread GitBox
jhtimmins commented on a change in pull request #10594: URL: https://github.com/apache/airflow/pull/10594#discussion_r482584110 ## File path: airflow/api_connexion/security.py ## @@ -37,3 +37,32 @@ def decorated(*args, **kwargs): return function(*args, **kwargs)

[GitHub] [airflow] alexbegg commented on issue #10279: Tooltips not show up in Safari

2020-09-02 Thread GitBox
alexbegg commented on issue #10279: URL: https://github.com/apache/airflow/issues/10279#issuecomment-686075093 I was able to reproduce the problem, partially, but only when RBAC UI was not enabled. I noticed that in Safari the only tooltips that is not working is the ones for the circles

[GitHub] [airflow] vitaly-krugl opened a new issue #10702: Allow custom remote logger plugins

2020-09-02 Thread GitBox
vitaly-krugl opened a new issue #10702: URL: https://github.com/apache/airflow/issues/10702 **Description** Allow custom remote loggers to be added (e.g., via Airflow's plugin mechanism) **Use case / motivation** Presently, airflow has hard-wired support for archiving

[GitHub] [airflow] alexbegg commented on issue #10279: Tooltips not show up in Safari

2020-09-02 Thread GitBox
alexbegg commented on issue #10279: URL: https://github.com/apache/airflow/issues/10279#issuecomment-686059151 Also, are you using the RBAC UI or not? This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] pcandoalmeida edited a comment on issue #9538: Add config variable for UI page title

2020-09-02 Thread GitBox
pcandoalmeida edited a comment on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-686053566 Hi @joshkadis we could keep `page-title` to the DAG homepage and `site-title` to the various places that "Airflow" appears in a view as suggested by @mik-laj (I could

[GitHub] [airflow] pcandoalmeida commented on issue #9538: Add config variable for UI page title

2020-09-02 Thread GitBox
pcandoalmeida commented on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-686053566 Hi @joshkadis we could keep `page-title` to the DAG homepage and `site-title` to the various places that "Airflow" appears in a view as suggested by @mik-laj (I could be

[GitHub] [airflow] pcandoalmeida edited a comment on issue #9538: Add config variable for UI page title

2020-09-02 Thread GitBox
pcandoalmeida edited a comment on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-685492510 Hi @bhavaniravi I've got the open issue functionality working in the open PR. I am trying to work on getting the changes updated in all possible views. I think

[GitHub] [airflow] alexbegg edited a comment on issue #10279: Tooltips not show up in Safari

2020-09-02 Thread GitBox
alexbegg edited a comment on issue #10279: URL: https://github.com/apache/airflow/issues/10279#issuecomment-686047299 It shows up fine for me in 1.10.11 in Safari (Version 13.1 (15609.1.20.111.8)). I was going to check with 1.10.10 using Breeze but I am having an issue building 1.10.10,

[GitHub] [airflow] alexbegg commented on issue #10279: Tooltips not show up in Safari

2020-09-02 Thread GitBox
alexbegg commented on issue #10279: URL: https://github.com/apache/airflow/issues/10279#issuecomment-686047299 It shows up fine for me in 1.10.11 in Safari. I was going to check with 1.10.10 using Breeze but I am having an issue building 1.10.10, so maybe someone else can try and

[GitHub] [airflow] jonstacks commented on issue #10292: Kubernetes Executor - invalid hostname in the database

2020-09-02 Thread GitBox
jonstacks commented on issue #10292: URL: https://github.com/apache/airflow/issues/10292#issuecomment-686044139 I did some messing around and was able to get get the logs working by adding this: https://github.com/apache/airflow/commit/58eb534f1902a561c151d0bb796692a3df6e241f It

[GitHub] [airflow-site] aijamalnk commented on pull request #268: adding a logo for sift use case

2020-09-02 Thread GitBox
aijamalnk commented on pull request #268: URL: https://github.com/apache/airflow-site/pull/268#issuecomment-685990906 Sorry i missed this! @mik-laj @mschickensoup is there anything else i need to do? Thank you both! This is

[airflow-site] branch aijamalnk-patch-1 updated (c02020a -> b97a5dc)

2020-09-02 Thread aizhamal
This is an automated email from the ASF dual-hosted git repository. aizhamal pushed a change to branch aijamalnk-patch-1 in repository https://gitbox.apache.org/repos/asf/airflow-site.git. from c02020a Adding the md file for sift use case add b97a5dc Update

[GitHub] [airflow] ryw commented on pull request #10678: Add section for official source code

2020-09-02 Thread GitBox
ryw commented on pull request #10678: URL: https://github.com/apache/airflow/pull/10678#issuecomment-685978388 @ashb @mistercrunch @bolkedebruin would one or two of you you have a quick look at this -- basically just stating where to find the official source code for the project. We'll

[airflow] branch master updated (649ce4b -> 4e09cb5)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 649ce4b Implement Google Shell Conventions for breeze script (#10695) add 4e09cb5 Add packages to function

[airflow] branch master updated (649ce4b -> 4e09cb5)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 649ce4b Implement Google Shell Conventions for breeze script (#10695) add 4e09cb5 Add packages to function

[airflow] branch master updated (e5785d4 -> 649ce4b)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e5785d4 Chart: Flower deployment should use Flower image (#10701) add 649ce4b Implement Google Shell

[airflow] branch master updated (649ce4b -> 4e09cb5)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 649ce4b Implement Google Shell Conventions for breeze script (#10695) add 4e09cb5 Add packages to function

[airflow] branch master updated (e5785d4 -> 649ce4b)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e5785d4 Chart: Flower deployment should use Flower image (#10701) add 649ce4b Implement Google Shell

[airflow] branch master updated (e5785d4 -> 649ce4b)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e5785d4 Chart: Flower deployment should use Flower image (#10701) add 649ce4b Implement Google Shell

[GitHub] [airflow] potiuk merged pull request #10696: Add packages to function names in bash

2020-09-02 Thread GitBox
potiuk merged pull request #10696: URL: https://github.com/apache/airflow/pull/10696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk merged pull request #10695: Implement Google Shell Conventions for breeze script

2020-09-02 Thread GitBox
potiuk merged pull request #10695: URL: https://github.com/apache/airflow/pull/10695 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated: Chart: Flower deployment should use Flower image (#10701)

2020-09-02 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new e5785d4 Chart: Flower deployment should

[GitHub] [airflow] kaxil merged pull request #10701: Chart: Flower deployment should use Flower image

2020-09-02 Thread GitBox
kaxil merged pull request #10701: URL: https://github.com/apache/airflow/pull/10701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #10671: Add more type annotations to AWS hooks

2020-09-02 Thread GitBox
potiuk commented on pull request #10671: URL: https://github.com/apache/airflow/pull/10671#issuecomment-685950489 There was an issue with latest release of black (released few days ago) that stopped respecting our configuration when running pre-commits. Please rebase to latest master

[GitHub] [airflow] XD-DENG commented on pull request #10681: Add Stacktrace when DagFileProcessorManager gets killed

2020-09-02 Thread GitBox
XD-DENG commented on pull request #10681: URL: https://github.com/apache/airflow/pull/10681#issuecomment-685949264 > > Given we still officially support Python 3.5, maybe not the best time yet to introduce f-string (which is only supported since 3.6)? > > > > But we are

[GitHub] [airflow] potiuk commented on pull request #10681: Add Stacktrace when DagFileProcessorManager gets killed

2020-09-02 Thread GitBox
potiuk commented on pull request #10681: URL: https://github.com/apache/airflow/pull/10681#issuecomment-685948712 > Given we still officially support Python 3.5, maybe not the best time yet to introduce f-string (which is only supported since 3.6)? But we are already using a lot of

[GitHub] [airflow] houqp commented on a change in pull request #10655: [AIRFLOW-10645] Add AWS Secrets Manager Hook

2020-09-02 Thread GitBox
houqp commented on a change in pull request #10655: URL: https://github.com/apache/airflow/pull/10655#discussion_r482313845 ## File path: airflow/providers/amazon/aws/hooks/secrets_manager.py ## @@ -0,0 +1,54 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] marcusianlevine commented on issue #8421: Hide sensitive data in UI

2020-09-02 Thread GitBox
marcusianlevine commented on issue #8421: URL: https://github.com/apache/airflow/issues/8421#issuecomment-685934343 I should have some time to work on a proposal for this in the next few weeks, but I'm still not sure the best way to approach the design The key question I'm stuck on

[GitHub] [airflow] kaxil opened a new pull request #10701: Chart: Flower deployment should use Flower image

2020-09-02 Thread GitBox
kaxil opened a new pull request #10701: URL: https://github.com/apache/airflow/pull/10701 Flower deployment should use Flower image if provided --- **^ Add meaningful description above** Read the **[Pull Request

[airflow] branch master updated: Fix missing dash in flag for statsd container (#10691)

2020-09-02 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 48ce4bd Fix missing dash in flag for

[GitHub] [airflow] kaxil merged pull request #10691: Fix missing dash in flag for statsd container

2020-09-02 Thread GitBox
kaxil merged pull request #10691: URL: https://github.com/apache/airflow/pull/10691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] agrubb86 opened a new issue #10700: CeleryExecutor + MySQL Airflow DB with 'wait_timeout' + BashOperator that runs longer than 'wait_timeout' = Airflow uses a stale connection

2020-09-02 Thread GitBox
agrubb86 opened a new issue #10700: URL: https://github.com/apache/airflow/issues/10700 **Apache Airflow version**: 1.10.11 **Environment**: Linux aarch64 - **Cloud provider or hardware configuration**: AWS - **OS** (e.g. from /etc/os-release):

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10700: CeleryExecutor + MySQL Airflow DB with 'wait_timeout' + BashOperator that runs longer than 'wait_timeout' = Airflow uses a stale connec

2020-09-02 Thread GitBox
boring-cyborg[bot] commented on issue #10700: URL: https://github.com/apache/airflow/issues/10700#issuecomment-685925727 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] ausiddiqui commented on issue #8421: Hide sensitive data in UI

2020-09-02 Thread GitBox
ausiddiqui commented on issue #8421: URL: https://github.com/apache/airflow/issues/8421#issuecomment-685923962 I have a similar use case, but passing the password from a connection object I created in the UI to the environment variable in the KubernetesPodOperator and it is appearing in

[GitHub] [airflow] sdzharkov edited a comment on issue #7935: scheduler gets stuck without a trace

2020-09-02 Thread GitBox
sdzharkov edited a comment on issue #7935: URL: https://github.com/apache/airflow/issues/7935#issuecomment-685920512 We've experienced this issue twice now, with the CPU spiking to 100% and failing to schedule any tasks after. Our config is `Airflow 1.10.6 - Celery - Postgres` running on

[GitHub] [airflow] sdzharkov commented on issue #7935: scheduler gets stuck without a trace

2020-09-02 Thread GitBox
sdzharkov commented on issue #7935: URL: https://github.com/apache/airflow/issues/7935#issuecomment-685920512 We experienced this issue twice now, with the CPU spiking to 100% and failing to schedule any tasks after. Our config is `Airflow 1.10.6 - Celery - Postgres` running on AWS ECS. I

[airflow] branch master updated (9a10f83 -> 02b853b)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9a10f83 Revert recent breeze changes (#10651 & #10670) (#10694) add 02b853b Fix failing black test (#10697)

[airflow] branch master updated (9a10f83 -> 02b853b)

2020-09-02 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9a10f83 Revert recent breeze changes (#10651 & #10670) (#10694) add 02b853b Fix failing black test (#10697)

[GitHub] [airflow] potiuk merged pull request #10697: Fix failing black test

2020-09-02 Thread GitBox
potiuk merged pull request #10697: URL: https://github.com/apache/airflow/pull/10697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #10699: Latest stable version of black does not use .pyproject.toml

2020-09-02 Thread GitBox
potiuk commented on pull request #10699: URL: https://github.com/apache/airflow/pull/10699#issuecomment-685916891 Implemented in #10697 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk closed pull request #10699: Latest stable version of black does not use .pyproject.toml

2020-09-02 Thread GitBox
potiuk closed pull request #10699: URL: https://github.com/apache/airflow/pull/10699 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk opened a new pull request #10699: Latest stable version of black does not use .pyproject.toml

2020-09-02 Thread GitBox
potiuk opened a new pull request #10699: URL: https://github.com/apache/airflow/pull/10699 We switch to 19.10b0 for now before they fix it. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil closed pull request #10698: Fix failing black test

2020-09-02 Thread GitBox
kaxil closed pull request #10698: URL: https://github.com/apache/airflow/pull/10698 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482270661 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482270661 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] kaxil opened a new pull request #10698: Fix failing black test

2020-09-02 Thread GitBox
kaxil opened a new pull request #10698: URL: https://github.com/apache/airflow/pull/10698 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482270661 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] kaxil opened a new pull request #10697: Fix failing black test

2020-09-02 Thread GitBox
kaxil opened a new pull request #10697: URL: https://github.com/apache/airflow/pull/10697 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] alexbegg commented on pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on pull request #10637: URL: https://github.com/apache/airflow/pull/10637#issuecomment-685905666 > Great! BTW tooltip seems not to work on all browsers #10279 @JeffryMAC thanks for the heads up, I'll try to look into that

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482263524 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482263524 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482263524 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482263524 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] alexbegg commented on a change in pull request #10637: Fix Start Date tooltip on DAGs page not showing actual start_date

2020-09-02 Thread GitBox
alexbegg commented on a change in pull request #10637: URL: https://github.com/apache/airflow/pull/10637#discussion_r482263524 ## File path: airflow/www/templates/airflow/dags.html ## @@ -369,14 +369,15 @@ DAGs function lastDagRunsHandler(error, json) { Review comment:

[GitHub] [airflow] potiuk commented on pull request #10695: Implement Google Shell Conventions for breeze script

2020-09-02 Thread GitBox
potiuk commented on pull request #10695: URL: https://github.com/apache/airflow/pull/10695#issuecomment-685901279 It was an interesting one. I fixed trap handling in this commit so that traps were "added" rather than "replaced". But they were added in a wrong order. Rather than putting

[GitHub] [airflow] kaxil commented on pull request #10695: Implement Google Shell Conventions for breeze script

2020-09-02 Thread GitBox
kaxil commented on pull request #10695: URL: https://github.com/apache/airflow/pull/10695#issuecomment-685897780 Thanks for the PR even though you are on holiday, I will test this out in few mins This is an automated

[GitHub] [airflow] potiuk opened a new pull request #10696: Add packages to function names in bash (#10670)

2020-09-02 Thread GitBox
potiuk opened a new pull request #10696: URL: https://github.com/apache/airflow/pull/10696 [Re-added after reverting it] Inspired by the Google Shell Guide where they mentioned separating package names with :: I realized that this was one of the missing pieces in the bash

[GitHub] [airflow] joshkadis commented on issue #9538: Add config variable for UI page title

2020-09-02 Thread GitBox
joshkadis commented on issue #9538: URL: https://github.com/apache/airflow/issues/9538#issuecomment-685894959 @pcandoalmeida Sorry... Where would `page-title` vs`site-title` be rendered? (thanks!) This is an automated

[GitHub] [airflow] potiuk opened a new pull request #10695: Fix missing output from docker

2020-09-02 Thread GitBox
potiuk opened a new pull request #10695: URL: https://github.com/apache/airflow/pull/10695 [This is re-applied commit from reverted one - the sequence of trap handling scripts were wrong so after add_trap was fixed the folder was deleted before output was printed out] First

[GitHub] [airflow] coopergillan commented on pull request #10671: Add more type annotations to AWS hooks

2020-09-02 Thread GitBox
coopergillan commented on pull request #10671: URL: https://github.com/apache/airflow/pull/10671#issuecomment-685882664 I need some help understanding the "no pylint" failure. It looks like it has to do with `black` formatting: ```bash

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482236372 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +783,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] varundhussa commented on a change in pull request #10673: Dataproc job sensor

2020-09-02 Thread GitBox
varundhussa commented on a change in pull request #10673: URL: https://github.com/apache/airflow/pull/10673#discussion_r482235954 ## File path: airflow/providers/google/cloud/sensors/dataproc.py ## @@ -0,0 +1,83 @@ +# +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482230994 ## File path: tests/cli/commands/test_dag_command.py ## @@ -139,6 +139,12 @@ def test_show_dag_print(self): self.assertIn("graph

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482230802 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482205398 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[airflow] branch master updated (338b412 -> 9a10f83)

2020-09-02 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 338b412 Add on_kill support for the KubernetesPodOperator (#10666) add 9a10f83 Revert recent breeze

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482203423 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +783,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] kaxil merged pull request #10694: Revert recent breeze changes (#10651 & #10670)

2020-09-02 Thread GitBox
kaxil merged pull request #10694: URL: https://github.com/apache/airflow/pull/10694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] turbaszek edited a comment on pull request #10694: Revert recent breeze changes (#10651 & #10670)

2020-09-02 Thread GitBox
turbaszek edited a comment on pull request #10694: URL: https://github.com/apache/airflow/pull/10694#issuecomment-685844024 The first problem can be fixed simply by (thanks to @michalslowikowski00 who figured this out): ``` ./breeze build-image --force-pull-images ``` but in

[GitHub] [airflow] turbaszek commented on pull request #10694: Revert recent breeze changes (#10651 & #10670)

2020-09-02 Thread GitBox
turbaszek commented on pull request #10694: URL: https://github.com/apache/airflow/pull/10694#issuecomment-685844024 The first problem can be fixed simply by: ``` ./breeze build-image --force-pull-images ``` but in case of the pylint/mypy error I don't know how to fix it

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482193145 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +783,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482192545 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482191652 ## File path: tests/cli/commands/test_dag_command.py ## @@ -139,6 +139,12 @@ def test_show_dag_print(self): self.assertIn("graph

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482191227 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482191020 ## File path: tests/cli/commands/test_dag_command.py ## @@ -139,6 +139,12 @@ def test_show_dag_print(self): self.assertIn("graph

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482190501 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482190501 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482189488 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482189219 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-02 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r482189650 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

  1   2   >