[GitHub] [airflow] yuqian90 commented on pull request #10153: [AIP-34] TaskGroup: A UI task grouping concept as an alternative to SubDagOperator

2020-09-03 Thread GitBox
yuqian90 commented on pull request #10153: URL: https://github.com/apache/airflow/pull/10153#issuecomment-686895896 Updated the title and summary to make it clearer the PR is ready for review. This is an automated message

[GitHub] [airflow] aranjanthakur commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow

2020-09-03 Thread GitBox
aranjanthakur commented on a change in pull request #10261: URL: https://github.com/apache/airflow/pull/10261#discussion_r483374775 ## File path: airflow/config_templates/config.yml ## @@ -861,6 +861,13 @@ type: string example: ~ default: "-" +- name:

[GitHub] [airflow] aranjanthakur commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow

2020-09-03 Thread GitBox
aranjanthakur commented on a change in pull request #10261: URL: https://github.com/apache/airflow/pull/10261#discussion_r483374690 ## File path: airflow/config_templates/config.yml ## @@ -861,6 +861,13 @@ type: string example: ~ default: "-" +- name:

[GitHub] [airflow] Shivarp1 opened a new issue #10722: KubernetesPodOperator with XCom enabled errors: 403 forbidden

2020-09-03 Thread GitBox
Shivarp1 opened a new issue #10722: URL: https://github.com/apache/airflow/issues/10722 Apache Airflow version: 1.10.12 kubernetes Version: 10.0.1 OpenAPI spec version: v1.14.5 OS: Linux Red Hat 7.x --- Enabling the do_xcom=True with default configuration parameters for pod

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10722: KubernetesPodOperator with XCom enabled errors: 403 forbidden

2020-09-03 Thread GitBox
boring-cyborg[bot] commented on issue #10722: URL: https://github.com/apache/airflow/issues/10722#issuecomment-686869781 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[airflow] branch v1-10-test updated: Add generate_yaml command to easily test KubernetesExecutor before deploying pods (#10677)

2020-09-03 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new c01c6b7 Add generate_yaml command

[airflow] branch v1-10-test updated: Add generate_yaml command to easily test KubernetesExecutor before deploying pods (#10677)

2020-09-03 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new c01c6b7 Add generate_yaml command

[GitHub] [airflow] dimberman opened a new pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-09-03 Thread GitBox
dimberman opened a new pull request #10393: URL: https://github.com/apache/airflow/pull/10393 As discussed in an earlier email thread, this PR removes much of the configuration elements of the K8sExecutor for a much simpler design. --- **^ Add meaningful description

[GitHub] [airflow] jaketf edited a comment on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf edited a comment on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686848519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] jaketf edited a comment on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf edited a comment on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686848519 @turbaszek I do not think we should unify naming on location as this would not line up with the REST API or the python client lib. the right thing to do here is a

[GitHub] [airflow] jaketf edited a comment on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf edited a comment on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686848519 @turbaszek I do not think we should unify naming on location as this would not line up with the REST API or the python client lib. the right thing to do here is a

[GitHub] [airflow] jaketf edited a comment on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf edited a comment on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686848519 @turbaszek I do not think we should unify naming on location as this would not line up with the REST API or the python client lib. the right thing to do here is a

[GitHub] [airflow] Adil-Ibragimov commented on pull request #10315: Add retry_only_on_pod_launching_failure and log_container_statuses_on…

2020-09-03 Thread GitBox
Adil-Ibragimov commented on pull request #10315: URL: https://github.com/apache/airflow/pull/10315#issuecomment-686852023 @ashb ping! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] dimberman closed pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-09-03 Thread GitBox
dimberman closed pull request #10393: URL: https://github.com/apache/airflow/pull/10393 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] jaketf commented on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf commented on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686850162 I will reach out to dataproc eng for their perspective. This is an automated message from the Apache Git Service.

[GitHub] [airflow] jaketf edited a comment on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf edited a comment on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686848519 @turbaszek I do not think we should unify naming on location as this would not line up with the REST API or the python client lib. the right thing to do here is a

[GitHub] [airflow] jaketf commented on issue #10687: Make region parameter required in Google Dataproc operators and hooks

2020-09-03 Thread GitBox
jaketf commented on issue #10687: URL: https://github.com/apache/airflow/issues/10687#issuecomment-686848519 @turbaszek I do not think we should unify naming on location as this would not line up with the REST API or the python client lib. the right thing to do here is a bit

[airflow] branch master updated (ab5235e -> 828f730)

2020-09-03 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ab5235e Unify command names in CLI (#10720) add 828f730 Add generate_yaml command to easily test

[airflow] branch master updated (ab5235e -> 828f730)

2020-09-03 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ab5235e Unify command names in CLI (#10720) add 828f730 Add generate_yaml command to easily test

[airflow] branch master updated (ab5235e -> 828f730)

2020-09-03 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ab5235e Unify command names in CLI (#10720) add 828f730 Add generate_yaml command to easily test

[GitHub] [airflow] dimberman merged pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman merged pull request #10677: URL: https://github.com/apache/airflow/pull/10677 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] mik-laj commented on pull request #9943: Increase typing coverage for postgres provider

2020-09-03 Thread GitBox
mik-laj commented on pull request #9943: URL: https://github.com/apache/airflow/pull/9943#issuecomment-686826251 @kenjihiraoka Do you need any help? This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] mik-laj commented on pull request #9990: Relax requirement to allow latest version of flask-login

2020-09-03 Thread GitBox
mik-laj commented on pull request #9990: URL: https://github.com/apache/airflow/pull/9990#issuecomment-686825244 @kaxil CI is sad. Can you look at it? I wanted to do a rebase, but I have no access right. ``` ERROR: Permission to astronomer/airflow.git denied to mik-laj. fatal:

[GitHub] [airflow] mik-laj commented on pull request #10192: Deprecate BaseHook.get_connections method (#10135)

2020-09-03 Thread GitBox
mik-laj commented on pull request #10192: URL: https://github.com/apache/airflow/pull/10192#issuecomment-686823492 > Do you think we can totally remove the use of get_connections before Airflow2.0? We should keep backward-compatibility with runtime warning. In Airlfow 2.1, we can

[GitHub] [airflow] mik-laj commented on pull request #10256: fixes http hook using schema field from airflow.models.connection.Con…

2020-09-03 Thread GitBox
mik-laj commented on pull request #10256: URL: https://github.com/apache/airflow/pull/10256#issuecomment-686822977 @kubatyszko Do you need help writing documentation about your findings? I am very happy to help with the review.

[GitHub] [airflow] mik-laj commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10261: URL: https://github.com/apache/airflow/pull/10261#discussion_r483312664 ## File path: airflow/config_templates/config.yml ## @@ -861,6 +861,13 @@ type: string example: ~ default: "-" +- name:

[GitHub] [airflow] mik-laj commented on a change in pull request #10261: 10166 : Add capability to specify gunicorn access log format for airflow

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10261: URL: https://github.com/apache/airflow/pull/10261#discussion_r483312454 ## File path: airflow/config_templates/config.yml ## @@ -861,6 +861,13 @@ type: string example: ~ default: "-" +- name:

[GitHub] [airflow] mik-laj commented on pull request #10303: Add docs for how airflow manages packages and imports

2020-09-03 Thread GitBox
mik-laj commented on pull request #10303: URL: https://github.com/apache/airflow/pull/10303#issuecomment-686821207 Awesome work! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] breser commented on issue #10429: jquery dependency needs to be updated to 3.5.0 or newer

2020-09-03 Thread GitBox
breser commented on issue #10429: URL: https://github.com/apache/airflow/issues/10429#issuecomment-686820980 See this comment on the PR I opened for past attempts to fix this: https://github.com/apache/airflow/pull/10684#issuecomment-686629969

[GitHub] [airflow] breser commented on pull request #10684: Fix #10429 jquery dependency needs to be updated to 3.5.0 or newer

2020-09-03 Thread GitBox
breser commented on pull request #10684: URL: https://github.com/apache/airflow/pull/10684#issuecomment-686820553 I'm closing this then because I have no time/ability to fix these deeper issues. This is an automated message

[GitHub] [airflow] breser closed pull request #10684: Fix #10429 jquery dependency needs to be updated to 3.5.0 or newer

2020-09-03 Thread GitBox
breser closed pull request #10684: URL: https://github.com/apache/airflow/pull/10684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mik-laj commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r483310271 ## File path: tests/kubernetes/test_pod_generator.py ## @@ -241,238 +213,224 @@ def test_gen_pod_extract_xcom(self, mock_uuid): ],

[GitHub] [airflow] mik-laj commented on a change in pull request #10393: Simplify the K8sExecutor and K8sPodOperator

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10393: URL: https://github.com/apache/airflow/pull/10393#discussion_r483310169 ## File path: tests/kubernetes/test_pod_generator.py ## @@ -241,238 +213,224 @@ def test_gen_pod_extract_xcom(self, mock_uuid): ],

[GitHub] [airflow] mik-laj commented on pull request #10413: Add documentation for preparing database for Airflow

2020-09-03 Thread GitBox
mik-laj commented on pull request #10413: URL: https://github.com/apache/airflow/pull/10413#issuecomment-686817728 @atsalolikhin-spokeo CI checks are sad. Can you fix it? Once you do this, I will be very happy to merge this PR.

[GitHub] [airflow] mik-laj commented on pull request #10446: Add kubernetes connection type

2020-09-03 Thread GitBox
mik-laj commented on pull request #10446: URL: https://github.com/apache/airflow/pull/10446#issuecomment-686817157 @turbaszek Be warned that this PR does not run all tests on CI. This is an automated message from the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #10453: Allow to specify path to kubeconfig in KubernetesHook

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10453: URL: https://github.com/apache/airflow/pull/10453#discussion_r483307212 ## File path: airflow/providers/cncf/kubernetes/hooks/kubernetes.py ## @@ -36,32 +36,52 @@ class KubernetesHook(BaseHook): """ Creates

[GitHub] [airflow] mik-laj commented on pull request #10514: Truly clear tis before runing dag test

2020-09-03 Thread GitBox
mik-laj commented on pull request #10514: URL: https://github.com/apache/airflow/pull/10514#issuecomment-686815838 @turbaszek Be warned that this PR does not run all tests on CI. This is an automated message from the Apache

[GitHub] [airflow] mik-laj commented on a change in pull request #10578: Add masterConfig parameter to MLEngineStartTrainingJobOperator

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10578: URL: https://github.com/apache/airflow/pull/10578#discussion_r483305793 ## File path: tests/providers/google/cloud/operators/test_mlengine.py ## @@ -350,6 +350,45 @@ def test_success_create_training_job(self, mock_hook):

[airflow] branch master updated (6f96e81 -> ab5235e)

2020-09-03 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6f96e81 Add Indeed to INTHEWILD.md (#10716) add ab5235e Unify command names in CLI (#10720) No new

[airflow] branch master updated (6f96e81 -> ab5235e)

2020-09-03 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6f96e81 Add Indeed to INTHEWILD.md (#10716) add ab5235e Unify command names in CLI (#10720) No new

[GitHub] [airflow] mik-laj merged pull request #10720: Unify command names in CLI

2020-09-03 Thread GitBox
mik-laj merged pull request #10720: URL: https://github.com/apache/airflow/pull/10720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] prakshalj0512 opened a new issue #10721: DAG Run ID referencing wrong DAG Run when trying to view

2020-09-03 Thread GitBox
prakshalj0512 opened a new issue #10721: URL: https://github.com/apache/airflow/issues/10721 **Apache Airflow version**: 1.10.12 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): N/A **Environment**: - **Cloud provider or hardware

[GitHub] [airflow] mik-laj commented on pull request #10652: add securitySchemes in openapi spec

2020-09-03 Thread GitBox
mik-laj commented on pull request #10652: URL: https://github.com/apache/airflow/pull/10652#issuecomment-686811482 @jhtimmins Can I ask for a review? This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] mik-laj edited a comment on pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj edited a comment on pull request #10677: URL: https://github.com/apache/airflow/pull/10677#issuecomment-686808891 Last thing, can you add more docs? I am thinking of a sentence or two that shows an example use case. Without it, this command will only be available in the reference

[GitHub] [airflow] mik-laj commented on pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on pull request #10677: URL: https://github.com/apache/airflow/pull/10677#issuecomment-686808891 Last thing, can you add more docs? I am thinking of a sentence or two that shows an example use case. Without it, this command will only be available in the reference

[GitHub] [airflow] houqp commented on a change in pull request #10594: WIP: Add permissions for stable API

2020-09-03 Thread GitBox
houqp commented on a change in pull request #10594: URL: https://github.com/apache/airflow/pull/10594#discussion_r483298085 ## File path: airflow/api_connexion/security.py ## @@ -16,25 +16,61 @@ # under the License. from functools import wraps -from typing import Callable,

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483298651 ## File path: airflow/cli/cli_parser.py ## @@ -66,6 +66,17 @@ def _check_value(self, action, value): if value == 'celery' and executor !=

[GitHub] [airflow] houqp commented on pull request #10351: Migrate speccy to spectral in OpenAPI linting.

2020-09-03 Thread GitBox
houqp commented on pull request #10351: URL: https://github.com/apache/airflow/pull/10351#issuecomment-686806300 I think it's worth digging into the sibling issue as follow up. If it's a bug in openapi-generator, we should fix it from there, or maybe we can figure out a better way to mark

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483295092 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483293388 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483291220 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483292539 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj opened a new pull request #10720: Unify command names in CLI

2020-09-03 Thread GitBox
mik-laj opened a new pull request #10720: URL: https://github.com/apache/airflow/pull/10720 Part of: https://github.com/apache/airflow/pull/10669 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483292253 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] Labbs commented on issue #10292: Kubernetes Executor - invalid hostname in the database

2020-09-03 Thread GitBox
Labbs commented on issue #10292: URL: https://github.com/apache/airflow/issues/10292#issuecomment-686801363 @jonstacks I tested your fix. That works well. This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483291762 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483280382 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483291301 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483291301 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483291227 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483291220 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483290900 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483290746 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] kaxil commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
kaxil commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483290456 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483286901 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483286372 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483283773 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483283805 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483282305 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483280382 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] dimberman commented on pull request #10666: Delete the pod launched by KubernetesPodOperator when task is cleared.

2020-09-03 Thread GitBox
dimberman commented on pull request #10666: URL: https://github.com/apache/airflow/pull/10666#issuecomment-686786941 My pleasure @spencerschack :) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] spencerschack commented on pull request #10666: Delete the pod launched by KubernetesPodOperator when task is cleared.

2020-09-03 Thread GitBox
spencerschack commented on pull request #10666: URL: https://github.com/apache/airflow/pull/10666#issuecomment-686786777 Thanks @dimberman! Appreciate your hard work! This is an automated message from the Apache Git Service.

[GitHub] [airflow] dimberman commented on pull request #10666: Delete the pod launched by KubernetesPodOperator when task is cleared.

2020-09-03 Thread GitBox
dimberman commented on pull request #10666: URL: https://github.com/apache/airflow/pull/10666#issuecomment-686786315 @spencerschack oof good catch I'll make a quick PR to make that optional thank you. This is an automated

[GitHub] [airflow] mik-laj commented on pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on pull request #10664: URL: https://github.com/apache/airflow/pull/10664#issuecomment-686785195 It would be fantastic if we could generate documentation for README.md based on this, but we should do it in a separate PR. It has a lot of potential.

[GitHub] [airflow] mik-laj commented on a change in pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10664: URL: https://github.com/apache/airflow/pull/10664#discussion_r483275190 ## File path: chart/values.schema.json ## @@ -0,0 +1,1250 @@ +{ +"$schema": "http://json-schema.org/draft-07/schema;, +"description": "Default

[GitHub] [airflow] mik-laj commented on a change in pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10664: URL: https://github.com/apache/airflow/pull/10664#discussion_r483275331 ## File path: chart/values.schema.json ## @@ -0,0 +1,1250 @@ +{ +"$schema": "http://json-schema.org/draft-07/schema;, +"description": "Default

[GitHub] [airflow] mik-laj commented on a change in pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10664: URL: https://github.com/apache/airflow/pull/10664#discussion_r483274899 ## File path: chart/values.schema.json ## @@ -0,0 +1,1250 @@ +{ +"$schema": "http://json-schema.org/draft-07/schema;, +"description": "Default

[GitHub] [airflow] mik-laj commented on a change in pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10664: URL: https://github.com/apache/airflow/pull/10664#discussion_r483274066 ## File path: chart/values.schema.json ## @@ -0,0 +1,1250 @@ +{ +"$schema": "http://json-schema.org/draft-07/schema;, +"description": "Default

[GitHub] [airflow] jedcunningham opened a new pull request #10719: Include missing RBAC permission for extra links

2020-09-03 Thread GitBox
jedcunningham opened a new pull request #10719: URL: https://github.com/apache/airflow/pull/10719 This change adds 'can extra links on Airflow' to the Viewer role and above. Currently, only Admins can see extra links by default.

[GitHub] [airflow] mik-laj commented on a change in pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10664: URL: https://github.com/apache/airflow/pull/10664#discussion_r483272979 ## File path: chart/values.schema.json ## @@ -0,0 +1,1250 @@ +{ +"$schema": "http://json-schema.org/draft-07/schema;, +"description": "Default

[GitHub] [airflow] mik-laj commented on a change in pull request #10664: Validate values.yaml

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10664: URL: https://github.com/apache/airflow/pull/10664#discussion_r483272219 ## File path: chart/values.schema.json ## @@ -0,0 +1,1250 @@ +{ +"$schema": "http://json-schema.org/draft-07/schema;, +"description": "Default

[jira] [Commented] (AIRFLOW-1424) Make the next execution date of DAGs visible

2020-09-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190397#comment-17190397 ] ASF GitHub Bot commented on AIRFLOW-1424: - alexbegg edited a comment on pull request #2460:

[GitHub] [airflow] alexbegg edited a comment on pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2020-09-03 Thread GitBox
alexbegg edited a comment on pull request #2460: URL: https://github.com/apache/airflow/pull/2460#issuecomment-686774822 @ultrabug I am a bit too busy to look further into this today, but I will try and take a look this weekend. I have a WIP branch if you want to take a look. I am trying

[jira] [Commented] (AIRFLOW-1424) Make the next execution date of DAGs visible

2020-09-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190396#comment-17190396 ] ASF GitHub Bot commented on AIRFLOW-1424: - alexbegg commented on pull request #2460: URL:

[GitHub] [airflow] alexbegg commented on pull request #2460: [AIRFLOW-1424] make the next execution date of DAGs visible

2020-09-03 Thread GitBox
alexbegg commented on pull request #2460: URL: https://github.com/apache/airflow/pull/2460#issuecomment-686774822 @ultrabug I am a bit too busy to look further into this today, but I will try and take a look this weekend. I have a WIP branch if you want to take a look. I am trying to add

[GitHub] [airflow] spencerschack commented on pull request #10666: Delete the pod launched by KubernetesPodOperator when task is cleared.

2020-09-03 Thread GitBox
spencerschack commented on pull request #10666: URL: https://github.com/apache/airflow/pull/10666#issuecomment-686773180 @dimberman Sorry to just jump into the convo, but by passing 0 seconds as the grace period, you're telling k8s to send SIGKILL to the container process instead of

[GitHub] [airflow] mik-laj commented on pull request #10655: [AIRFLOW-10645] Add AWS Secrets Manager Hook

2020-09-03 Thread GitBox
mik-laj commented on pull request #10655: URL: https://github.com/apache/airflow/pull/10655#issuecomment-686772675 @potiuk I know you wrote hooks for GCP Secret Manager and Hashicorp Vault. What do you think about this change?

[GitHub] [airflow] mik-laj commented on pull request #10655: [AIRFLOW-10645] Add AWS Secrets Manager Hook

2020-09-03 Thread GitBox
mik-laj commented on pull request #10655: URL: https://github.com/apache/airflow/pull/10655#issuecomment-686771887 @houqp I don't have experience with AWS. I am focusing on GCP. @feluelle Can I ask for a review? This is an

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483259925 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +380,48 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483259731 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] dimberman commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
dimberman commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483259411 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483258771 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +782,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483255937 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +380,48 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483255401 ## File path: airflow/cli/cli_parser.py ## @@ -142,6 +142,10 @@ def positive_int(value): ("-e", "--end-date"), help="Override end_date

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483253555 ## File path: airflow/cli/commands/dag_command.py ## @@ -378,6 +379,47 @@ def dag_list_dag_runs(args, dag=None): print(table)

[GitHub] [airflow] potiuk commented on pull request #10718: Switches to better BATS asserts

2020-09-03 Thread GitBox
potiuk commented on pull request #10718: URL: https://github.com/apache/airflow/pull/10718#issuecomment-686763258 Others - with this one and few other changes implemented recently (and follow up tests)- our Bash scripts will become almost as good as structured python code :)

[GitHub] [airflow] potiuk edited a comment on pull request #10718: Switches to better BATS asserts

2020-09-03 Thread GitBox
potiuk edited a comment on pull request #10718: URL: https://github.com/apache/airflow/pull/10718#issuecomment-686762644 CC: @OmairK - I am also going to add more and more unit tests for the bash functions of Breeze. This PR makes it super-easy to write and run new tests, so you might

[GitHub] [airflow] potiuk commented on pull request #10718: Switches to better BATS asserts

2020-09-03 Thread GitBox
potiuk commented on pull request #10718: URL: https://github.com/apache/airflow/pull/10718#issuecomment-686762644 CC: @OmairK - I am also going to add more and more unit tests for the bash functions of Breeze. This PR makes it super-easy to write and run new tests, so you might want to

[GitHub] [airflow] mik-laj commented on a change in pull request #10677: Add generate_yaml command to easily test KubernetesExecutor before deploying pods

2020-09-03 Thread GitBox
mik-laj commented on a change in pull request #10677: URL: https://github.com/apache/airflow/pull/10677#discussion_r483251211 ## File path: airflow/cli/cli_parser.py ## @@ -778,6 +783,12 @@ class GroupCommand(NamedTuple):

[GitHub] [airflow] toderesa97 commented on issue #8212: Can't read S3 remote logs using Airflow 1.10.9

2020-09-03 Thread GitBox
toderesa97 commented on issue #8212: URL: https://github.com/apache/airflow/issues/8212#issuecomment-686760829 We are experiencing the same issue here. Airflow does sucessfully write logs to S3, but we are getting: ``` Log file does not exist:

  1   2   3   4   >