[GitHub] [airflow-client-go] houqp edited a comment on pull request #5: add test & doc for authentication

houqp edited a comment on pull request #5: URL: https://github.com/apache/airflow-client-go/pull/5#issuecomment-687704588 @mik-laj I don't have GCP to test google openid auth, but one should be able to set the token using

[GitHub] [airflow-client-go] houqp commented on pull request #5: add test & doc for authentication

houqp commented on pull request #5: URL: https://github.com/apache/airflow-client-go/pull/5#issuecomment-687704588 @mik-laj I don't have GCP to test openid auth, but one should be able to set the token using

[airflow-client-go] branch master updated: add test & doc for authentication (#5)

This is an automated email from the ASF dual-hosted git repository. houqp pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow-client-go.git The following commit(s) were added to refs/heads/master by this push: new e1deffd add test & doc for

[GitHub] [airflow-client-go] houqp merged pull request #5: add test & doc for authentication

houqp merged pull request #5: URL: https://github.com/apache/airflow-client-go/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (AIRFLOW-5841) Tree view has been reversed

[ https://issues.apache.org/jira/browse/AIRFLOW-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191196#comment-17191196 ] Daniel Lamblin commented on AIRFLOW-5841: - Which line of code in the

[GitHub] [airflow] joshi95 opened a new pull request #10762: Fetching databricks host from connection if not supplied in extras.

joshi95 opened a new pull request #10762: URL: https://github.com/apache/airflow/pull/10762 Fix for the issue #10726 . Have supported the previous functionality of fetching the host from extras if specified else it is getting fetched from the databricks connection which makes more sense.

[GitHub] [airflow] joshi95 closed pull request #10749: Fetching databricks host from connection if not supplied in extras.

joshi95 closed pull request #10749: URL: https://github.com/apache/airflow/pull/10749 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] joshi95 commented on pull request #10749: Fetching databricks host from connection if not supplied in extras.

joshi95 commented on pull request #10749: URL: https://github.com/apache/airflow/pull/10749#issuecomment-687697205 I will start a new PR closing this. This is an automated message from the Apache Git Service. To respond to

[airflow] tag nightly-master updated (079d7b5 -> ba36f87)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 079d7b5 (commit) to ba36f87 (commit) from

[airflow] tag nightly-master updated (079d7b5 -> ba36f87)

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 079d7b5 (commit) to ba36f87 (commit) from

[GitHub] [airflow] ryanyuan commented on pull request #10744: Update node installation cmd

ryanyuan commented on pull request #10744: URL: https://github.com/apache/airflow/pull/10744#issuecomment-687685056 Cheers. @potiuk This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] chipmyersjr commented on a change in pull request #10760: Create salesforce to gcs transfer

chipmyersjr commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r484001370 ## File path: airflow/providers/google/cloud/example_dags/example_salesforce_to_gcs.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software

[GitHub] [airflow] chipmyersjr commented on a change in pull request #10760: Create salesforce to gcs transfer

chipmyersjr commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r484001307 ## File path: airflow/providers/google/cloud/transfers/salesforce_to_gcs.py ## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation

[GitHub] [airflow] chipmyersjr commented on a change in pull request #10760: Create salesforce to gcs transfer

chipmyersjr commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r484001334 ## File path: airflow/providers/google/cloud/transfers/salesforce_to_gcs.py ## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687677216 https://twitter.com/xkcdComic/status/1295478837652803584?s=19 A tweet I had re-shared from XKCD on 17 Aug is pretty apt for this situation 

[GitHub] [airflow] kaxil commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687677216 https://twitter.com/xkcdComic/status/1295478837652803584?s=19 A tweet I had shared from XKCD on 17 Aug is pretty apt for this situation 

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687676899 This whole time I am just debating for one thing (https://github.com/apache/airflow/issues/10753#issuecomment-687651980): > If the sources are clearly mentioned where

[GitHub] [airflow] kaxil commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687676899 This whole time I am just debating for one thing (https://github.com/apache/airflow/issues/10753#issuecomment-687651980): > If the sources are clearly mentioned where they

[GitHub] [airflow] potiuk commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687676344 > sources are still public, images are on Dockerhub which is then consumed by the Helm chart As long as we tell the user how to rebuild the image from "official" + sources -

[GitHub] [airflow] potiuk edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687675363 > You say binary in your argument while I am saying "the source is available" although not under ASF. The source being public should allow them to rebuild it, isn't it?

[GitHub] [airflow] potiuk edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687675363 > You say binary in your argument while I am saying "the source is available" although not under ASF. The source being public should allow them to rebuild it, isn't it?

[GitHub] [airflow] potiuk commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687675363 > You say binary in your argument while I am saying "the source is available" although not under ASF. The source being public should allow them to rebuild it, isn't it? That

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687674352 "There are many big organisations (including my customers) that only allow specific version of deps and scan them. " -- You are agreeing with me here, aren't you? I was

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687674352 "There are many big organisations (including my customers) that only allow specific version of deps and scan them. " -- You are agreeing with here, aren't you? I was making

[GitHub] [airflow] kaxil commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687674352 "There are many big organisations (including my customers) that only allow specific version of deps and scan them. " -- You are agreeing with here, aren't you? I was making the

[GitHub] [airflow] potiuk commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687673873 > Do they trust all PyPI packages though? Don't they do scan on every release. A package can add a dependency that might be vulnerable. There are many big organisations

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687673328 >Technically not. But any organisation that I know of that cares for reproducibility of their software installation maintains their own mirrors and archives for those

[GitHub] [airflow] kaxil commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687673328 >Technically not. But any organisation that I know of that cares for reproducibility of their software installation maintains their own mirrors and archives for those "standard"

[GitHub] [airflow] kaxil commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687672994 >I'd really love to hear how you would like to approach the case of the user I explained (if you agree with the statement above) otherwise. Imagine the user that has the Helm chart

[GitHub] [airflow] potiuk commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687672255 > But at least my personal opinion is that having them on PyPI does not guarantee anything. Technically not. But any organisation that I know of that cares for

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687669753 > I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. Is that written somewhere

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687669753 > I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. Is that written somewhere

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687669753 > I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. Is that written somewhere

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687669753 > I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. Is that written somewhere

[GitHub] [airflow] aimran-adroll opened a new issue #10761: Separate nodeSelector logic for scheduler+webserver vs ephemeral resources

aimran-adroll opened a new issue #10761: URL: https://github.com/apache/airflow/issues/10761 **Description** I would like to separate out the current `nodeSelector` logic for critical (imo) pods such as the scheduler+webserver vs worker pods. **Use case / motivation** If

[GitHub] [airflow] kaxil edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687669753 > I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. Is that written somewhere

[GitHub] [airflow] kaxil commented on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687669753 > I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. Is that written somewhere in

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10760: Create salesforce to gcs transfer

ephraimbuddy commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r483993290 ## File path: airflow/providers/google/cloud/example_dags/example_salesforce_to_gcs.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10760: Create salesforce to gcs transfer

ephraimbuddy commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r483993290 ## File path: airflow/providers/google/cloud/example_dags/example_salesforce_to_gcs.py ## @@ -0,0 +1,113 @@ +# Licensed to the Apache Software

[GitHub] [airflow] potiuk edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter image on their own using 'platforms and tools'

potiuk edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687666791 > @potiuk my point is that release of helm chart is entirely independent of what images that chart might use. You cannot release helm chart without the image it

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10760: Create salesforce to gcs transfer

ephraimbuddy commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r483992582 ## File path: airflow/providers/google/cloud/transfers/salesforce_to_gcs.py ## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation

[GitHub] [airflow] potiuk edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter on their own using 'platforms and tools'

potiuk edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687666791 > @potiuk my point is that release of helm chart is entirely independent of what images that chart might use. You cannot release helm chart without the image it

[GitHub] [airflow] potiuk edited a comment on issue #10753: Make sure user can rebuild pgbouncer-exporter on their own using 'platforms and tools'

potiuk edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687666791 > @potiuk my point is that release of helm chart is entirely independent of what images that chart might use. You cannot release helm chart without the image it

[GitHub] [airflow] potiuk commented on issue #10753: Make sure user can rebuild pgbouncer-exporter on their own using 'platforms and tools'

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687666791 > @potiuk my point is that release of helm chart is entirely independent of what images that chart might use. You cannot release helm chart without the image it points to -

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #10760: Create salesforce to gcs transfer

ephraimbuddy commented on a change in pull request #10760: URL: https://github.com/apache/airflow/pull/10760#discussion_r483992388 ## File path: airflow/providers/google/cloud/transfers/salesforce_to_gcs.py ## @@ -0,0 +1,106 @@ +# Licensed to the Apache Software Foundation

[GitHub] [airflow] ashb edited a comment on issue #10753: Make sure sources that we can use to build pgbouncer-exporter are also included when we release helm chart

ashb edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687664760 @potiuk my point is that release of helm chart is entirely independent of what images that chart might use. This ticket (or at least the title) conflates the two, when they

[GitHub] [airflow] ashb commented on issue #10753: Make sure sources that we can use to build pgbouncer-exporter are also included when we release helm chart

ashb commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687664760 @potiuk my point is that release of helm chart is entirely independent of what images that chart might use. This ticket (or at least the title) conflates the two, when they are

[GitHub] [airflow] stale[bot] closed pull request #9788: add alembic recommended constraints naming conventions to models

stale[bot] closed pull request #9788: URL: https://github.com/apache/airflow/pull/9788 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] stale[bot] closed pull request #9769: Update start.rst with small change to quick start installation instructions

stale[bot] closed pull request #9769: URL: https://github.com/apache/airflow/pull/9769 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources that we can use to build pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687661416 > I'll have to read the ASF thread (on mobile on the weekend) but why is releases of the helm chart, which is just a manifest ultimately, have any requirement on shipping the

[GitHub] [airflow] potiuk commented on pull request #10749: Fetching databricks host from connection if not supplied in extras.

potiuk commented on pull request #10749: URL: https://github.com/apache/airflow/pull/10749#issuecomment-687659859 Ah no - you nee to rebase to latest master. The build of yours is based on rather old version of the Docker file that uses removed requirements, so you need rebase and it

[GitHub] [airflow] potiuk commented on a change in pull request #10750: Make static checks Google Shell Guide compatible

potiuk commented on a change in pull request #10750: URL: https://github.com/apache/airflow/pull/10750#discussion_r483985601 ## File path: .pre-commit-config.yaml ## @@ -223,7 +223,7 @@ repos: name: Lint dockerfile language: system entry:

[GitHub] [airflow] potiuk commented on pull request #10754: Fix dockerfile hadolint problems

potiuk commented on pull request #10754: URL: https://github.com/apache/airflow/pull/10754#issuecomment-687659319 I need the #10750 to be meerged first :( This is an automated message from the Apache Git Service. To respond

[airflow] branch master updated (28c21cf -> ba36f87)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 28c21cf clean-logs script for Dockerfile: trim logs before sleep (#10685) add ba36f87 Make

[airflow] branch master updated (28c21cf -> ba36f87)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 28c21cf clean-logs script for Dockerfile: trim logs before sleep (#10685) add ba36f87 Make

[GitHub] [airflow] potiuk merged pull request #10747: Make scripts/ci/openapi Google Shell Guide compatible

potiuk merged pull request #10747: URL: https://github.com/apache/airflow/pull/10747 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687658536 I think everything is clear when we use installing from "official" repositories - pypi, apt, apk - those are officially maintained projects. I think there is this

[GitHub] [airflow] stale[bot] commented on pull request #8296: Make execute and on_kill as abstractmethod in baseoperator

stale[bot] commented on pull request #8296: URL: https://github.com/apache/airflow/pull/8296#issuecomment-687657002 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] stale[bot] commented on pull request #9904: Added Xcom to work with DockerSwarmOperator

stale[bot] commented on pull request #9904: URL: https://github.com/apache/airflow/pull/9904#issuecomment-687656997 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] stale[bot] commented on pull request #9847: Support for set in XCom serialization (fix #8703)

stale[bot] commented on pull request #9847: URL: https://github.com/apache/airflow/pull/9847#issuecomment-687656998 This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitHub] [airflow] kaxil commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687656689 Cool, yea again to just clarify I have nothing against the sources  Just want to clear my understanding. Because I am just confused if we need to then think about the sqlalchmey

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687656608 > For me the confusion stems from saying let's have the source of all available under "apache" roof is like saying we should also have the python dependencies under the same roof.

[GitHub] [airflow] chipmyersjr opened a new pull request #10760: Create salesforce to gcs transfer

chipmyersjr opened a new pull request #10760: URL: https://github.com/apache/airflow/pull/10760 Add Salesforce to GCS transfer operator. Closes issue #8896 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687654567 the PR is here with dowloading the code from jhub's github rather than the source code published. I also forked it myself and (just in case) we have fork at

[GitHub] [airflow] potiuk opened a new pull request #10759: Switch to downloaded pgbouncer_exporter

potiuk opened a new pull request #10759: URL: https://github.com/apache/airflow/pull/10759 Pgbouncer-exporter is now used from official releases by jhub https://github.com/jbub/pgbouncer_exporter/releases/ J. --- **^ Add meaningful description above** Read the

[GitHub] [airflow] kaxil commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687651980 For me the confusion stems from saying let's have the source of all available under "apache" roof is like saying we should also have the python dependencies under the same roof.

[GitHub] [airflow] kaxil commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687649362 Yup definitely agree that whatever we classify as release needs to go through the voting process. I think in one of the mailing list thread I even proposed that whatever we classify

[GitHub] [airflow] ashb commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

ashb commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687648350 (sorry for terse replies on my part - I made the mistake of starting to comment before daughter's bed time, and she is quite insistent that I not look at my phone but instead pay

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687646640 > @potiuk to be clear: my only question is where/when we release sources for pgbouncer-exporter. > > You are proposing we include the source for this support image with every

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687646305 @dimberman i read your comment in the discussion in the asf devlist. - and if your concern is about keeping the sources of pgbouncer, then it was purely about the convenience for

[GitHub] [airflow] ashb commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

ashb commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687646148 @potiuk to be clear: my only question is where/when we release sources for pgbouncer-exporter. You are proposing we include the source for this support image with every

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687645243 @kaxil Indeed - it's not clear, but I think if we name something ' 'release' then it **must** have packaged and signed source code for it. I think that part is crystal clear (fron

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10758: Add ability to create custom trigger rules through plugins

boring-cyborg[bot] commented on issue #10758: URL: https://github.com/apache/airflow/issues/10758#issuecomment-687644671 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] maiorBoltach opened a new issue #10758: Add ability to create custom trigger rules through plugins

maiorBoltach opened a new issue #10758: URL: https://github.com/apache/airflow/issues/10758 **Description** Create API fro creating new types of different trigger_rules like it's done for macros or views. **Use case / motivation** Currently, there are 8 different types

[GitHub] [airflow] kaxil commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

kaxil commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687641080 A thing I definitely need to like clarity from ASF (Just posted on that thread too) is if we treat Helm chart and dockerfile as releases we need "Voting" too. ASF needs to clarify

[GitHub] [airflow] SamWheating opened a new pull request #10757: Tail out all logs when retrieving from pod

SamWheating opened a new pull request #10757: URL: https://github.com/apache/airflow/pull/10757

[GitHub] [airflow] dimberman edited a comment on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

dimberman edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687637460 I think @ashb makes an interesting point. All of these image paths are override-able. If they don't trust the official PGBouncer image then they are welcome to go to

[GitHub] [airflow] dimberman commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

dimberman commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687637460 I think @ashb makes an interesting point. All of these image paths are override-able. If you don't trust the official PGBouncer image you are welcome to go to their source,

[GitHub] [airflow] ashb edited a comment on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

ashb edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687635716 I'll have to read the ASF thread (on mobile on the weekend) but why is releases of the helm chart, which is just a manifest ultimately, have any requirement on shipping the

[GitHub] [airflow] ashb commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

ashb commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687636438 > Should they be forced to make an Agreement with all the 3rd-party providers on delivering them the sources ? What would you answer to those users of Airflow? Do the ask for

[GitHub] [airflow] ashb edited a comment on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

ashb edited a comment on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687635716 I'll have to read the thread (on mobile on the weekend) but why is releases of the helm chart, which is just a manifest ultimately, require shipping the source code of on of

[GitHub] [airflow] ashb commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

ashb commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687635716 I'll have to read the thread (on mobile on the weekend) but why is releases of the helm chart, which is just a manifest ultimately, require shipping the source code of on of the

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687634263 I really cannot agree with that :). The code just sits there. ready to be used whenever we need to use another version of it. No harm. It's just there for our users of they

[GitHub] [airflow] dimberman commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

dimberman commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687630937 I replied on the apache thread, but yeah I'm not a huge fan of apache forcing us to manage our entire ecosystem. It's basically removing a lot of the simplicity that

[GitHub] [airflow] potiuk commented on a change in pull request #10754: Fix dockerfile hadolint problems

potiuk commented on a change in pull request #10754: URL: https://github.com/apache/airflow/pull/10754#discussion_r483963186 ## File path: chart/dockerfiles/pgbouncer/Dockerfile ## @@ -15,19 +15,20 @@ # specific language governing permissions and limitations # under the

[airflow] branch master updated: clean-logs script for Dockerfile: trim logs before sleep (#10685)

This is an automated email from the ASF dual-hosted git repository. xddeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 28c21cf clean-logs script for Dockerfile:

[airflow] branch master updated: clean-logs script for Dockerfile: trim logs before sleep (#10685)

This is an automated email from the ASF dual-hosted git repository. xddeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 28c21cf clean-logs script for Dockerfile:

[GitHub] [airflow] XD-DENG commented on pull request #10685: scripts: should trim logs before going to sleep

XD-DENG commented on pull request #10685: URL: https://github.com/apache/airflow/pull/10685#issuecomment-687627199 Thanks @kushsharma . I further updated the subject a little bit, hope you don't mind. This is an automated

[GitHub] [airflow] XD-DENG merged pull request #10685: scripts: should trim logs before going to sleep

XD-DENG merged pull request #10685: URL: https://github.com/apache/airflow/pull/10685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10685: scripts: should trim logs before going to sleep

boring-cyborg[bot] commented on pull request #10685: URL: https://github.com/apache/airflow/pull/10685#issuecomment-687627165 Awesome work, congrats on your first merged pull request! This is an automated message from

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687626751 This is the discussion in the devlist of Apache https://lists.apache.org/thread.html/rcb608739206d788785081073a0deb417ffa9981634975fc5525dc769%40%3Cdev.community.apache.org%3E

[GitHub] [airflow] potiuk commented on issue #10753: Make sure sources for pgbouncer-exporter are also included when we release helm chart

potiuk commented on issue #10753: URL: https://github.com/apache/airflow/issues/10753#issuecomment-687626530 But I believe we are obliged to do it. I still strongly believe that Helm chart is ASF release and we have to follow this rule stated in the

[GitHub] [airflow] kushsharma commented on pull request #10685: scripts: should trim logs before going to sleep

kushsharma commented on pull request #10685: URL: https://github.com/apache/airflow/pull/10685#issuecomment-687622891 @XD-DENG Hi, I have updated the same as requested. I am not sure if this is more helpful, please let me know if you have anything else in mind.

[GitHub] [airflow] dimberman opened a new pull request #10756: Add podOverride setting for KubernetesExecutor

dimberman opened a new pull request #10756: URL: https://github.com/apache/airflow/pull/10756 Users of the KubernetesExecutor will now have a "podOverride" option in the executor_config. This option will allow users to modify the pod launched by the KubernetesExecutor using a

[GitHub] [airflow] zacharya19 edited a comment on issue #10724: When multiple filters selected in arg_tags_filter, each filter works as 'or' instead of 'and'.

zacharya19 edited a comment on issue #10724: URL: https://github.com/apache/airflow/issues/10724#issuecomment-687609559 @kaxil Yep, it was intentional. What I had in mind is a tag per "team", so it make sense to me it will be "OR". I think we should add a config option to control the

[GitHub] [airflow] zacharya19 commented on issue #10724: When multiple filters selected in arg_tags_filter, each filter works as 'or' instead of 'and'.

zacharya19 commented on issue #10724: URL: https://github.com/apache/airflow/issues/10724#issuecomment-687609559 @kaxil Yep, it was intentional. What I had in mind is tags per "team", so it make sense it will be "OR". I think we should add a config option to control the default

[GitHub] [airflow] kaxil commented on issue #10721: DAG Run ID referencing wrong DAG Run when trying to view

kaxil commented on issue #10721: URL: https://github.com/apache/airflow/issues/10721#issuecomment-687606679 Yeah that is correct, looks like a bug then This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] rootcss commented on issue #9185: Include plugin information in the version page

rootcss commented on issue #9185: URL: https://github.com/apache/airflow/issues/9185#issuecomment-687602447 > @rootcss I assigned you to this ticket. > > Did you know you can work on more than one ticket if you have time? We do not check if someone has more than one assigned ticket.

[airflow] branch master updated: Asynchronous execution of Dataproc jobs with a Sensor (#10673)

This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new ece685b Asynchronous execution of Dataproc

[GitHub] [airflow] mik-laj commented on issue #9185: Include plugin information in the version page

mik-laj commented on issue #9185: URL: https://github.com/apache/airflow/issues/9185#issuecomment-687601949 @rootcss I assigned you to this ticket. Did you know you can work on more than one ticket if you have time? We do not check if someone has more than one assigned ticket.

  1   2   >