mik-laj commented on issue #10776:
URL: https://github.com/apache/airflow/issues/10776#issuecomment-688053642
this server has a very light load. We don't need anything better. This
will consume resources that can be used better.
boring-cyborg[bot] commented on issue #10776:
URL: https://github.com/apache/airflow/issues/10776#issuecomment-688052576
Thanks for opening your first issue here! Be sure to follow the issue
template!
This is an
rootcss opened a new issue #10776:
URL: https://github.com/apache/airflow/issues/10776
In the serve_logs code
[here](https://github.com/apache/airflow/blob/master/airflow/utils/serve_logs.py),
are we intentionally starting the flask server in dev mode
(`flask_app.run()`)? @mik-laj
Shivarp1 edited a comment on issue #10605:
URL: https://github.com/apache/airflow/issues/10605#issuecomment-688014261
A work around would be to add this code block in the
/home/airflow/airflow_local_settings.py
PodDefaults.SIDECAR_CONTAINER = k8s.V1Container(
Shivarp1 commented on issue #10605:
URL: https://github.com/apache/airflow/issues/10605#issuecomment-688014261
A work around would be add this code block in the
/home/airflow/airflow_local_settings.py
PodDefaults.SIDECAR_CONTAINER = k8s.V1Container(
ephraimbuddy commented on a change in pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#discussion_r484162133
##
File path: tests/providers/google/cloud/transfers/test_gcs_to_local_system.py
##
@@ -0,0 +1,51 @@
+#
+# Licensed to the Apache Software
ephraimbuddy commented on pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#issuecomment-687991100
Wow. Thank you!
This is an automated message from the Apache Git Service.
To respond to the message,
tanjinP commented on pull request #10121:
URL: https://github.com/apache/airflow/pull/10121#issuecomment-687983828
> Thank you so much @tanjinP for your input and hard work!
@mschickensoup ready for another look! Implemented the other methods.
I am only missing [the IAM ones
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from ba36f87 (commit)
to ddee0aa (commit)
from
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from ba36f87 (commit)
to ddee0aa (commit)
from
foresightyj opened a new issue #10775:
URL: https://github.com/apache/airflow/issues/10775
I have about 10 airflow dags that needs to be run daily to check nightly
builds of my system. So I scheduled them all with `@daily` intervals. But only
some of them are scheduled as expected while
boring-cyborg[bot] commented on issue #10775:
URL: https://github.com/apache/airflow/issues/10775#issuecomment-687973105
Thanks for opening your first issue here! Be sure to follow the issue
template!
This is an
jmcarp opened a new pull request #10774:
URL: https://github.com/apache/airflow/pull/10774
The `list_prefixes` and `list_keys` methods of the s3 hook return lists if
the result isn't empty, and `None` otherwise. Some operators that use these
methods break when the result is empty, because
mik-laj commented on pull request #10770:
URL: https://github.com/apache/airflow/pull/10770#issuecomment-687962865
The original ticket mentions the following requirements. What do you think
to add them?
```
- source (plugins folder or entry point)
- for plugins folder plugins
mik-laj commented on pull request #10770:
URL: https://github.com/apache/airflow/pull/10770#issuecomment-687954398
@mjpieters Can you look at it? Does it meet your expectations?
This is an automated message from the Apache
mik-laj commented on a change in pull request #10770:
URL: https://github.com/apache/airflow/pull/10770#discussion_r484137296
##
File path: airflow/www/views.py
##
@@ -2408,6 +2408,55 @@ def prefill_form(self, form, pk):
field.data = value
+class
mik-laj commented on pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#issuecomment-687951833
@ephraimbuddy I fixed this tests.
docker-in-docker causes various problems. I personally install gcloud
locally in such a situation.
You can do it in three steps.
mik-laj commented on pull request #9943:
URL: https://github.com/apache/airflow/pull/9943#issuecomment-687938445
@kenjihiraoka Can you do a rebase? that should solve your problem.
This is an automated message from the Apache
chipmyersjr commented on pull request #10760:
URL: https://github.com/apache/airflow/pull/10760#issuecomment-687920285
@eladkal Thanks for the feedback. I think using write_object_to_file
method is a good call out. Will make this simpler and more flexible so I'm
going to try to
MateuszKukiela commented on issue #10672:
URL: https://github.com/apache/airflow/issues/10672#issuecomment-687917639
Create a PR for this issue: https://github.com/apache/airflow/pull/10773
This is an automated message from
MateuszKukiela opened a new pull request #10773:
URL: https://github.com/apache/airflow/pull/10773
Committer: Mateusz Kukieła
---
**^ Add meaningful description above**
Read the **[Pull Request
boring-cyborg[bot] commented on pull request #10773:
URL: https://github.com/apache/airflow/pull/10773#issuecomment-687917045
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
ephraimbuddy commented on pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#issuecomment-687902978
@mik-laj, Can you check if you can run the system test, I'm having error
related to docker at the moment. On PID.
```
INFO
dmitrikuksik commented on issue #10687:
URL: https://github.com/apache/airflow/issues/10687#issuecomment-687899236
I've made my first PR (https://github.com/apache/airflow/pull/10772).
There was `submit` method in dataproc hooks that is going to be deprecated, so
I left it without
dmitrikuksik opened a new pull request #10772:
URL: https://github.com/apache/airflow/pull/10772
Deprecate using global as the default region value in Google Dataproc
operators and hooks.
---
**^ Add meaningful description above**
Read the **[Pull Request
boring-cyborg[bot] commented on pull request #10772:
URL: https://github.com/apache/airflow/pull/10772#issuecomment-687896248
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our
kenjihiraoka commented on pull request #9943:
URL: https://github.com/apache/airflow/pull/9943#issuecomment-687895971
Do I need to do something to unblock this error?
![Screenshot from 2020-09-06
mik-laj opened a new pull request #10771:
URL: https://github.com/apache/airflow/pull/10771
Logging configuration causes a lot of trouble for beginners. I've added a
little command that can help you troubleshoot problems.
---
**^ Add meaningful description above**
houqp edited a comment on pull request #10621:
URL: https://github.com/apache/airflow/pull/10621#issuecomment-687876623
@dstandish on error tooltip update happens after the AJAX call has
completed. That's why it's not affected when you remove the tooltip call,
because it only applies to
houqp commented on pull request #10621:
URL: https://github.com/apache/airflow/pull/10621#issuecomment-687876623
@dstandish on error tooltip update happens after the AJAX call has
completed. the onloading tooltip is shown before the client gets any response
from the API, in that state, it
ashb commented on pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#issuecomment-687872356
Oh yeah, I'm definitely happy with this. It seems like the right thing for
now (and no decision is permanent if we discover something new in the future)
mik-laj merged pull request #10638:
URL: https://github.com/apache/airflow/pull/10638
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new ddee0aa Simplify load connection in
potiuk commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484102738
##
File path: scripts/ci/dockerfiles/apache-rat/Dockerfile
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
potiuk commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484102744
##
File path: scripts/ci/dockerfiles/krb5-kdc-server/supervisord.conf
##
@@ -0,0 +1,61 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
rootcss opened a new pull request #10770:
URL: https://github.com/apache/airflow/pull/10770
This PR adds a link to view details of Plugins loaded into the Airflow.
closes: https://github.com/apache/airflow/issues/9185
potiuk commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484101560
##
File path: scripts/ci/dockerfiles/stress/Dockerfile
##
@@ -0,0 +1,31 @@
+ARG ALPINE_VERSION="3.12"
+
+FROM alpine:${ALPINE_VERSION}
+
+ARG
potiuk commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484101560
##
File path: scripts/ci/dockerfiles/stress/Dockerfile
##
@@ -0,0 +1,31 @@
+ARG ALPINE_VERSION="3.12"
+
+FROM alpine:${ALPINE_VERSION}
+
+ARG
kaxil commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484101447
##
File path: scripts/ci/dockerfiles/stress/Dockerfile
##
@@ -0,0 +1,31 @@
+ARG ALPINE_VERSION="3.12"
+
+FROM alpine:${ALPINE_VERSION}
+
+ARG
potiuk commented on pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#issuecomment-687866252
I have not such strong feelings about the dev images as I have for those
that we share with the users, but yeah - and in this case the "pull" one is I
think important, but If
kaxil commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484101285
##
File path: scripts/ci/dockerfiles/krb5-kdc-server/supervisord.conf
##
@@ -0,0 +1,61 @@
+
+# Licensed to the Apache Software Foundation (ASF) under one
kaxil commented on a change in pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#discussion_r484101189
##
File path: scripts/ci/dockerfiles/apache-rat/Dockerfile
##
@@ -0,0 +1,56 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more
potiuk opened a new pull request #10769:
URL: https://github.com/apache/airflow/pull/10769
The variables were initialized after the readonly status was set
for the constants in the test script.
This was mainly about default values for those consttants (but this
has already been
ashb commented on pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#issuecomment-687861804
With docker's change in policies, "inactive" images run the risk of being
deleted.
(Unlikely as it resets the timer on any pull, but this is a risk for the
"random" images
dstandish commented on pull request #10621:
URL: https://github.com/apache/airflow/pull/10621#issuecomment-687858785
From looking at the code, it seems the tooltip only has content when there
is an error in the API response. Where do you see a "waiting for response"
tooltip?
potiuk commented on pull request #10768:
URL: https://github.com/apache/airflow/pull/10768#issuecomment-687858419
> Given it's test-related, I would tend to be more "picky": one check is
failing
Absolutely @XD-DENG . I am also using this PR to test the behaviour of some
tests
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new ebb0a97 Make ci/scripts/pre-commit Google
potiuk merged pull request #10748:
URL: https://github.com/apache/airflow/pull/10748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 59f9a41 Add permission "extra_links" for Viewer role and above
(#10719)
add fbce92e The verbose functions
potiuk merged pull request #10731:
URL: https://github.com/apache/airflow/pull/10731
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#issuecomment-687855591
> This will be doubly useful
What do you mean @ashb ?
This is an automated message from the Apache Git
ashb commented on pull request #9652:
URL: https://github.com/apache/airflow/pull/9652#issuecomment-687850984
This will be doubly useful cos of
https://www.docker.com/pricing/resource-consumption-updates
This is an
houqp closed pull request #10763:
URL: https://github.com/apache/airflow/pull/10763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
houqp commented on pull request #10763:
URL: https://github.com/apache/airflow/pull/10763#issuecomment-687844128
nice, i am going to close mine then.
This is an automated message from the Apache Git Service.
To respond to
houqp commented on pull request #10621:
URL: https://github.com/apache/airflow/pull/10621#issuecomment-687843618
Sorry I wasn't aware of this PR, but the tooltip was added to show a loading
message when waiting for data from the API. The proper fix for this is to use
only apply the data
houqp commented on pull request #10764:
URL: https://github.com/apache/airflow/pull/10764#issuecomment-687843031
@kaxil the tooltip was there to display `link not yet available` while
loading the link from API.
This is an
houqp edited a comment on pull request #10764:
URL: https://github.com/apache/airflow/pull/10764#issuecomment-687843031
@kaxil the tooltip was added there to display `link not yet available` while
loading the link from API.
XD-DENG merged pull request #10719:
URL: https://github.com/apache/airflow/pull/10719
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
XD-DENG commented on pull request #10719:
URL: https://github.com/apache/airflow/pull/10719#issuecomment-687833991
@jedcunningham I updated the PR title and commit msg a little bit, for
better clarity in later CHANGELOG. Hope you don't mind.
This is an automated email from the ASF dual-hosted git repository.
xddeng pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e3c83da Check all dockerfiles with hadolint (#10754)
add 59f9a41 Add permission "extra_links" for Viewer
boring-cyborg[bot] commented on pull request #10719:
URL: https://github.com/apache/airflow/pull/10719#issuecomment-687833792
Awesome work, congrats on your first merged pull request!
This is an automated message from
ephraimbuddy removed a comment on pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#issuecomment-687812991
> @ephraimbuddy Can you add system tests also? This will ensure that this
example is valid.
I added it but it sees it as invalid. I'll add it again and fix
potiuk merged pull request #10754:
URL: https://github.com/apache/airflow/pull/10754
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 9f5b22f Move role guide to access control (#10755)
add e3c83da Check all dockerfiles with hadolint (#10754)
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 323319c Fix `breeze flags` command. (#10766)
add 9f5b22f Move role guide to access control (#10755)
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 323319c Fix `breeze flags` command. (#10766)
add 9f5b22f Move role guide to access control (#10755)
mik-laj merged pull request #10755:
URL: https://github.com/apache/airflow/pull/10755
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
XD-DENG commented on pull request #10768:
URL: https://github.com/apache/airflow/pull/10768#issuecomment-687827184
Thanks @potiuk !
Given it's test-related, I would tend to be more "picky": one check is
failing
potiuk opened a new pull request #10768:
URL: https://github.com/apache/airflow/pull/10768
We've observed the tests for last couple of weeks and it seems
most of the tests marked with "quarantine" marker are succeeding
in a stable way (https://github.com/apache/airflow/issues/10118)
jedcunningham commented on pull request #10719:
URL: https://github.com/apache/airflow/pull/10719#issuecomment-687819060
Thanks for taking a look @XD-DENG.
Long story short, I just changed all the extra link tests to run with a
Viewer instead of an Admin user.
ephraimbuddy commented on pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#issuecomment-687812991
> @ephraimbuddy Can you add system tests also? This will ensure that this
example is valid.
I added it but it sees it as invalid. I'll add it again and fix the
potiuk commented on pull request #10754:
URL: https://github.com/apache/airflow/pull/10754#issuecomment-687810052
Also added explanation what each ignored rule means and link to the wiki
describing them .
This is an
mik-laj commented on issue #10758:
URL: https://github.com/apache/airflow/issues/10758#issuecomment-687808618
You can use [Cluster
policy](https://airflow.readthedocs.io/en/latest/concepts.html#cluster-policy)
and monkey-patching to change all operators behavior at run-time.
I
potiuk commented on pull request #10754:
URL: https://github.com/apache/airflow/pull/10754#issuecomment-687808194
> Can you please add a PR description, I would love to help the community
understand what the PR actually fixes. As little as "fixes formatting" (just an
example) is helpful
maiorBoltach edited a comment on issue #10758:
URL: https://github.com/apache/airflow/issues/10758#issuecomment-687806632
@mik-laj
so. we have to create new operators (copy existing ones in airflow) for that
and i can't say that this is a proper solution (not good, not bad). I'll
maiorBoltach edited a comment on issue #10758:
URL: https://github.com/apache/airflow/issues/10758#issuecomment-687806632
@mik-laj
so. we have to create new operators (copy existing ones) for that and i
can't say that this is a proper solution (not good, not bad). I'll even say
that
maiorBoltach commented on issue #10758:
URL: https://github.com/apache/airflow/issues/10758#issuecomment-687806632
> @maiorBoltach You can define custom trigger rules. See:
mik-laj commented on pull request #10767:
URL: https://github.com/apache/airflow/pull/10767#issuecomment-687803151
@ephraimbuddy Can you add system tests also? This will ensure that this
example is valid.
This is an
mik-laj commented on issue #10758:
URL: https://github.com/apache/airflow/issues/10758#issuecomment-687802799
@maiorBoltach You can define custom trigger rules. See:
mik-laj closed issue #8453:
URL: https://github.com/apache/airflow/issues/8453
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kaxil commented on pull request #10755:
URL: https://github.com/apache/airflow/pull/10755#issuecomment-687797287
Awesome, thnx
This is an automated message from the Apache Git Service.
To respond to the message, please log
joshi95 commented on issue #10726:
URL: https://github.com/apache/airflow/issues/10726#issuecomment-687796601
Hi, I have added a new PR for this, please review it.
This is an automated message from the Apache Git Service.
To
XD-DENG commented on issue #10693:
URL: https://github.com/apache/airflow/issues/10693#issuecomment-687795283
Cool, thanks @eladkal for sharing this.
@yvadalia , please refer to the link @eladkal shared +
https://github.com/apache/airflow#backport-packages for using the backport,
eladkal commented on a change in pull request #10760:
URL: https://github.com/apache/airflow/pull/10760#discussion_r484061021
##
File path: airflow/providers/google/cloud/transfers/salesforce_to_gcs.py
##
@@ -0,0 +1,107 @@
+# Licensed to the Apache Software Foundation (ASF)
ephraimbuddy opened a new pull request #10767:
URL: https://github.com/apache/airflow/pull/10767
This PR closes one of the issues in #8280
---
**^ Add meaningful description above**
Read the **[Pull Request
eladkal commented on issue #10693:
URL: https://github.com/apache/airflow/issues/10693#issuecomment-687768658
Both PRs are included in the backport release of AWS
https://github.com/apache/airflow/blob/master/airflow/providers/amazon/PROVIDERS_CHANGES_2020.06.24.md
So no need to
This is an automated email from the ASF dual-hosted git repository.
ash pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e3c750e Switch to downloaded pgbouncer_exporter (#10759)
add 323319c Fix `breeze flags` command. (#10766)
No
This is an automated email from the ASF dual-hosted git repository.
ash pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new 323319c Fix `breeze flags` command. (#10766)
ashb merged pull request #10766:
URL: https://github.com/apache/airflow/pull/10766
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ashb opened a new pull request #10766:
URL: https://github.com/apache/airflow/pull/10766
This was missed in #10670
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ephraimbuddy opened a new pull request #10765:
URL: https://github.com/apache/airflow/pull/10765
This PR adds unittest for AzureCosmosDocumentSensor.
With this, there are no missing tests anymore in the `providers` package.
---
**^ Add meaningful description above**
kaxil commented on pull request #10764:
URL: https://github.com/apache/airflow/pull/10764#issuecomment-687745394
Here is another PR: https://github.com/apache/airflow/pull/10621/files
addressing same issue
This is an
kaxil commented on pull request #10754:
URL: https://github.com/apache/airflow/pull/10754#issuecomment-687744187
Can you please add a OR description, I would love to help the community
understand what the PR actually fixes. As little as "fixes formatting" (just an
example) is helpful for
kaxil edited a comment on pull request #10754:
URL: https://github.com/apache/airflow/pull/10754#issuecomment-687744187
Can you please add a PR description, I would love to help the community
understand what the PR actually fixes. As little as "fixes formatting" (just an
example) is
kaxil commented on a change in pull request #10754:
URL: https://github.com/apache/airflow/pull/10754#discussion_r484048889
##
File path: chart/dockerfiles/pgbouncer/Dockerfile
##
@@ -15,19 +15,20 @@
# specific language governing permissions and limitations
# under the
potiuk commented on pull request #10755:
URL: https://github.com/apache/airflow/pull/10755#issuecomment-687735324
Failed checks. Otherwise lgtm
This is an automated message from the Apache Git Service.
To respond to the
kaxil removed a comment on issue #10753:
URL: https://github.com/apache/airflow/issues/10753#issuecomment-687733310
Yeah had replied to that thread y'day. 100% agree on Matt's statement:
**The bits we build on top
of external components becomes the Apache project that is ALv2 and
kaxil commented on issue #10753:
URL: https://github.com/apache/airflow/issues/10753#issuecomment-687733310
Yeah had replied to that thread y'day. 100% agree on Matt's statement:
**The bits we build on top
of external components becomes the Apache project that is ALv2 and is
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from ba36f87 Make scripts/ci/openapi Google Shell Guide compatible (#10747)
add e3c750e Switch to downloaded
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new e3c750e Switch to downloaded
1 - 100 of 117 matches
Mail list logo
