[GitHub] [airflow] francescomucio commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
francescomucio commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487372742 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra

[GitHub] [airflow] abhilash1in opened a new issue #10894: Running 'breeze initialize-local-virtualenv' results in an error

2020-09-11 Thread GitBox
abhilash1in opened a new issue #10894: URL: https://github.com/apache/airflow/issues/10894 CC: @potiuk Running `./breeze initialize-local-virtualenv` from inside a brand new pyenv virtualenv (3.7) is causing errors: ``` Exception ignored in: . at 0x108f35a70>

[airflow] tag nightly-master updated (3a4f517 -> 7dd7be3)

2020-09-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 3a4f517 (commit) to 7dd7be3 (commit) from

[airflow] tag nightly-master updated (3a4f517 -> 7dd7be3)

2020-09-11 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from 3a4f517 (commit) to 7dd7be3 (commit) from

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10893: Add new operator for ClickHouse

2020-09-11 Thread GitBox
boring-cyborg[bot] commented on issue #10893: URL: https://github.com/apache/airflow/issues/10893#issuecomment-691376810 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] bharatnc opened a new issue #10893: Add new operator for ClickHouse

2020-09-11 Thread GitBox
bharatnc opened a new issue #10893: URL: https://github.com/apache/airflow/issues/10893 **Description** Add a new operator for ClickHouse. **Use case / motivation** Use case similar to any other operators like Postgres, MySQL etc. **Related Issues** As far

[GitHub] [airflow] jaketf opened a new pull request #10892: Proposal: remove -serviceaccount suffix from KSA names in helm chart

2020-09-11 Thread GitBox
jaketf opened a new pull request #10892: URL: https://github.com/apache/airflow/pull/10892 It's quite annoying to have `-serviceaccount` in each service account name as this is a useless 15 characters that provides no additional information about the account's purpose. "why do you

[airflow] branch master updated (47e592e -> 7dd7be3)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 47e592e Flag --start-airflow for breeze (#10837) add 7dd7be3 Bump prismjs from 1.20.0 to 1.21.0 in

[airflow] branch master updated (47e592e -> 7dd7be3)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 47e592e Flag --start-airflow for breeze (#10837) add 7dd7be3 Bump prismjs from 1.20.0 to 1.21.0 in

[airflow] branch master updated (47e592e -> 7dd7be3)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 47e592e Flag --start-airflow for breeze (#10837) add 7dd7be3 Bump prismjs from 1.20.0 to 1.21.0 in

[airflow] branch constraints-2-0 created (now 9682084)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch constraints-2-0 in repository https://gitbox.apache.org/repos/asf/airflow.git. at 9682084 Updating constraints. Build id:248490316 No new revisions were added by this update.

[GitHub] [airflow] kaxil merged pull request #10234: Bump prismjs from 1.20.0 to 1.21.0 in /airflow/www

2020-09-11 Thread GitBox
kaxil merged pull request #10234: URL: https://github.com/apache/airflow/pull/10234 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch constraints-2-0 created (now 9682084)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch constraints-2-0 in repository https://gitbox.apache.org/repos/asf/airflow.git. at 9682084 Updating constraints. Build id:248490316 No new revisions were added by this update.

[airflow] branch v2-0-test created (now 47e592e)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-0-test in repository https://gitbox.apache.org/repos/asf/airflow.git. at 47e592e Flag --start-airflow for breeze (#10837) No new revisions were added by this update.

[GitHub] [airflow] kaxil opened a new pull request #10891: Update CI to run tests againt v2-0-test branch

2020-09-11 Thread GitBox
kaxil opened a new pull request #10891: URL: https://github.com/apache/airflow/pull/10891 I have created v2-0-test branch  . This PR adds support for it in our CI --- **^ Add meaningful description above** Read the **[Pull Request

[airflow] branch v2-0-test created (now 47e592e)

2020-09-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-0-test in repository https://gitbox.apache.org/repos/asf/airflow.git. at 47e592e Flag --start-airflow for breeze (#10837) No new revisions were added by this update.

[GitHub] [airflow] SalAlba commented on pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
SalAlba commented on pull request #10864: URL: https://github.com/apache/airflow/pull/10864#issuecomment-691325848 ok git rebase done, time now for skipping ` CI errors ` :fire: This is an automated message from the Apache

[GitHub] [airflow] coopergillan commented on pull request #10888: Add type annotations to ZendeskHook, update unit test

2020-09-11 Thread GitBox
coopergillan commented on pull request #10888: URL: https://github.com/apache/airflow/pull/10888#issuecomment-691324540 Oops, thanks! Will grab that in a little. This is an automated message from the Apache Git Service. To

[GitHub] [airflow] coopergillan commented on pull request #10671: Add more type annotations to AWS hooks

2020-09-11 Thread GitBox
coopergillan commented on pull request #10671: URL: https://github.com/apache/airflow/pull/10671#issuecomment-691324138 Have a great time! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] mik-laj commented on pull request #10671: Add more type annotations to AWS hooks

2020-09-11 Thread GitBox
mik-laj commented on pull request #10671: URL: https://github.com/apache/airflow/pull/10671#issuecomment-691322103 @coopergillan I'm on vacation Friday-Monday. I think we can merge it as is for now, but I'd like to look at it before merging.

[GitHub] [airflow] potiuk commented on pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on pull request #10837: URL: https://github.com/apache/airflow/pull/10837#issuecomment-691320596 Thanks @francescomucio ! This is an automated message from the Apache Git Service. To respond to the message,

[airflow] branch master updated (030582a -> 47e592e)

2020-09-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 030582a Fix `breeze -i` error (#10887) add 47e592e Flag --start-airflow for breeze (#10837) No new

[airflow] branch master updated: Flag --start-airflow for breeze (#10837)

2020-09-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 47e592e Flag --start-airflow for breeze

[airflow] branch master updated (41a6273 -> 030582a)

2020-09-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 41a6273 Add on_kill method to BigQueryInsertJobOperator (#10866) add 030582a Fix `breeze -i` error (#10887)

[GitHub] [airflow] potiuk merged pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk merged pull request #10837: URL: https://github.com/apache/airflow/pull/10837 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (41a6273 -> 030582a)

2020-09-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 41a6273 Add on_kill method to BigQueryInsertJobOperator (#10866) add 030582a Fix `breeze -i` error (#10887)

[GitHub] [airflow] potiuk commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487298218 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] potiuk merged pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
potiuk merged pull request #10887: URL: https://github.com/apache/airflow/pull/10887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
potiuk commented on pull request #10887: URL: https://github.com/apache/airflow/pull/10887#issuecomment-691318858 > I thought I tired this, and it then couldn't find the list of allowed values. True, This is an

[GitHub] [airflow] wyattshapiro commented on pull request #10890: Add s3 key to template fields

2020-09-11 Thread GitBox
wyattshapiro commented on pull request #10890: URL: https://github.com/apache/airflow/pull/10890#issuecomment-691314393 failed tests because "Process completed with exit code 137." possibly similar issue need to investigate: https://github.com/apache/airflow/issues/9104

[GitHub] [airflow] ashb commented on a change in pull request #10881: Mark task as failed when it fails "sending" in Celery

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10881: URL: https://github.com/apache/airflow/pull/10881#discussion_r487291820 ## File path: airflow/executors/celery_executor.py ## @@ -188,14 +189,13 @@ def _process_tasks(self, task_tuples_to_send: List[TaskInstanceInCelery]) ->

[GitHub] [airflow] ashb commented on a change in pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10887: URL: https://github.com/apache/airflow/pull/10887#discussion_r487291199 ## File path: breeze ## @@ -724,14 +724,14 @@ function breeze::parse_arguments() { shift 2 ;; -i | --integration) -

[GitHub] [airflow] ashb commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487287376 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] potiuk commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487286728 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] potiuk commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487284642 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] ashb commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487280927 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] wyattshapiro commented on a change in pull request #10890: Add s3 key to template fields

2020-09-11 Thread GitBox
wyattshapiro commented on a change in pull request #10890: URL: https://github.com/apache/airflow/pull/10890#discussion_r487280877 ## File path: airflow/providers/amazon/aws/transfers/redshift_to_s3.py ## @@ -65,7 +65,7 @@ class RedshiftToS3Operator(BaseOperator): :type

[GitHub] [airflow] potiuk commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487280142 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] potiuk commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487280142 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] ashb commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487280317 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] francescomucio commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
francescomucio commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487279673 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra

[GitHub] [airflow] turbaszek commented on pull request #10470: Move perf_kit to tests.utils

2020-09-11 Thread GitBox
turbaszek commented on pull request #10470: URL: https://github.com/apache/airflow/pull/10470#issuecomment-691301221 > > The point is that `tests.utils` corresponds to `airflow.utils` and probably should have no other stuff. I will open PR > > I see, not too obvious though :( . I

[GitHub] [airflow] francescomucio commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
francescomucio commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487278802 ## File path: scripts/in_container/check_environment.sh ## @@ -99,12 +99,10 @@ function resetdb_if_requested() { function

[GitHub] [airflow] potiuk commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487276706 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] ashb commented on a change in pull request #10837: Flag --start-airflow for breeze

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10837: URL: https://github.com/apache/airflow/pull/10837#discussion_r487269766 ## File path: BREEZE.rst ## @@ -1947,6 +1951,11 @@ This is the current syntax for `./breeze <./breeze>`_: cassandra kerberos mongo

[GitHub] [airflow] gmontanola commented on a change in pull request #10890: Add s3 key to template fields

2020-09-11 Thread GitBox
gmontanola commented on a change in pull request #10890: URL: https://github.com/apache/airflow/pull/10890#discussion_r487268962 ## File path: airflow/providers/amazon/aws/transfers/redshift_to_s3.py ## @@ -65,7 +65,7 @@ class RedshiftToS3Operator(BaseOperator): :type

[GitHub] [airflow] potiuk commented on pull request #10470: Move perf_kit to tests.utils

2020-09-11 Thread GitBox
potiuk commented on pull request #10470: URL: https://github.com/apache/airflow/pull/10470#issuecomment-691289451 > The point is that `tests.utils` corresponds to `airflow.utils` and probably should have no other stuff. I will open PR I see, not too obvious though :( . I was never

[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
potiuk commented on pull request #10887: URL: https://github.com/apache/airflow/pull/10887#issuecomment-691287862 See my suggestion - this was the actual problem -> the "check_and_save_allowed_param" continued checking INTEGRATION variable instead if "integration"

[GitHub] [airflow] potiuk commented on a change in pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
potiuk commented on a change in pull request #10887: URL: https://github.com/apache/airflow/pull/10887#discussion_r487263295 ## File path: breeze ## @@ -724,14 +724,14 @@ function breeze::parse_arguments() { shift 2 ;; -i | --integration) -

[GitHub] [airflow] ashb commented on pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
ashb commented on pull request #10887: URL: https://github.com/apache/airflow/pull/10887#issuecomment-691284605 Changing it definately made it work and behave as expected. `./breeeze -b mysql -i redis -i rabbitmq` was what I was running.

[GitHub] [airflow] XD-DENG commented on a change in pull request #10865: Removes snakebite kerberos dependency

2020-09-11 Thread GitBox
XD-DENG commented on a change in pull request #10865: URL: https://github.com/apache/airflow/pull/10865#discussion_r487256757 ## File path: UPDATING.md ## @@ -1766,6 +1767,14 @@ Now the `dag_id` will not appear repeated in the payload, and the response forma } ``` +##

[GitHub] [airflow] rootcss commented on pull request #10770: Add Plugins View in web UI

2020-09-11 Thread GitBox
rootcss commented on pull request #10770: URL: https://github.com/apache/airflow/pull/10770#issuecomment-691281045 hey @mjpieters: Got that. This is a WIP, we're still discussing some of the changes to do that. This is an

[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
potiuk commented on pull request #10887: URL: https://github.com/apache/airflow/pull/10887#issuecomment-691271881 Hmm . but this is strange. It shoudl work actually, was it 'undefined' because there was no actual integration after -i ?

[GitHub] [airflow] potiuk commented on pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
potiuk commented on pull request #10887: URL: https://github.com/apache/airflow/pull/10887#issuecomment-691271300 one lowercase too much This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk commented on issue #10014: Release a 2nd wave of Backport packages

2020-09-11 Thread GitBox
potiuk commented on issue #10014: URL: https://github.com/apache/airflow/issues/10014#issuecomment-691270266 Sorry - I should have updated it. The second wave is delayed a bit (but coming soon). The resason is two-fold * the `cncf.kubernetes` package has a problem that we are solving

[GitHub] [airflow] wyattshapiro opened a new pull request #10890: Add s3 key to template fields

2020-09-11 Thread GitBox
wyattshapiro opened a new pull request #10890: URL: https://github.com/apache/airflow/pull/10890 Add 's3_key' variable so Jinja templating can be applied. This is an automated message from the Apache Git Service. To

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10890: Add s3 key to template fields

2020-09-11 Thread GitBox
boring-cyborg[bot] commented on pull request #10890: URL: https://github.com/apache/airflow/pull/10890#issuecomment-691269048 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] coopergillan commented on pull request #10888: Add type annotations to ZendeskHook, update unit test

2020-09-11 Thread GitBox
coopergillan commented on pull request #10888: URL: https://github.com/apache/airflow/pull/10888#issuecomment-691267713 Failure looks unrelated. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] coopergillan commented on pull request #10888: Add type annotations to ZendeskHook, update unit test

2020-09-11 Thread GitBox
coopergillan commented on pull request #10888: URL: https://github.com/apache/airflow/pull/10888#issuecomment-691260666 Not sure why the two jobs were cancelled. Just did a fresh rebase to kick them again. This is an

[airflow] branch master updated (56bd9b7 -> 41a6273)

2020-09-11 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 56bd9b7 Modify helm chart to use pod_template_file (#10872) add 41a6273 Add on_kill method to

[airflow] branch master updated (56bd9b7 -> 41a6273)

2020-09-11 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 56bd9b7 Modify helm chart to use pod_template_file (#10872) add 41a6273 Add on_kill method to

[airflow] branch master updated (56bd9b7 -> 41a6273)

2020-09-11 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 56bd9b7 Modify helm chart to use pod_template_file (#10872) add 41a6273 Add on_kill method to

[GitHub] [airflow] turbaszek merged pull request #10866: Add on_kill method to BigQueryInsertJobOperator

2020-09-11 Thread GitBox
turbaszek merged pull request #10866: URL: https://github.com/apache/airflow/pull/10866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] turbaszek closed issue #10382: Add on_kill method to BigQueryInsertJobOperator

2020-09-11 Thread GitBox
turbaszek closed issue #10382: URL: https://github.com/apache/airflow/issues/10382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] turbaszek commented on issue #10382: Add on_kill method to BigQueryInsertJobOperator

2020-09-11 Thread GitBox
turbaszek commented on issue #10382: URL: https://github.com/apache/airflow/issues/10382#issuecomment-691256654 Closed in #10866 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] turbaszek commented on pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
turbaszek commented on pull request #10864: URL: https://github.com/apache/airflow/pull/10864#issuecomment-691254882 > > > The CI errors seem to be similar to #10153 as reported by @yuqian90 > > > > > > Seems to be this issue: #10877 @SalAlba can you rebase please? > >

[GitHub] [airflow] SalAlba commented on pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
SalAlba commented on pull request #10864: URL: https://github.com/apache/airflow/pull/10864#issuecomment-691250121 > > The CI errors seem to be similar to #10153 as reported by @yuqian90 > > Seems to be this issue: #10877 @SalAlba can you rebase please? **For rebase** I made

[GitHub] [airflow] SalAlba commented on a change in pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
SalAlba commented on a change in pull request #10864: URL: https://github.com/apache/airflow/pull/10864#discussion_r487218955 ## File path: .gitignore ## @@ -205,3 +205,22 @@ Chart.lock # Might be generated when you build wheels pip-wheel-metadata + +# tmp ... +Backups/

[GitHub] [airflow] turbaszek commented on a change in pull request #10881: Mark task as failed when it fails "sending" in Celery

2020-09-11 Thread GitBox
turbaszek commented on a change in pull request #10881: URL: https://github.com/apache/airflow/pull/10881#discussion_r487200043 ## File path: airflow/executors/celery_executor.py ## @@ -188,14 +189,13 @@ def _process_tasks(self, task_tuples_to_send:

[GitHub] [airflow] turbaszek commented on pull request #10881: Mark task as failed when it fails "sending" in Celery

2020-09-11 Thread GitBox
turbaszek commented on pull request #10881: URL: https://github.com/apache/airflow/pull/10881#issuecomment-691231895 @olchas this sounds like it may solve the issue you observed when cluster was scaling up This is an

[GitHub] [airflow] turbaszek commented on pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
turbaszek commented on pull request #10864: URL: https://github.com/apache/airflow/pull/10864#issuecomment-691231031 > The CI errors seem to be similar to #10153 as reported by @yuqian90 Seems to be this issue: https://github.com/apache/airflow/pull/10877 @SalAlba can you rebase

[airflow] branch master updated (d93c1fd -> 56bd9b7)

2020-09-11 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from d93c1fd Disables --warn-unused-ignore flag for mypy (#10880) add 56bd9b7 Modify helm chart to use

[airflow] branch master updated (d93c1fd -> 56bd9b7)

2020-09-11 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from d93c1fd Disables --warn-unused-ignore flag for mypy (#10880) add 56bd9b7 Modify helm chart to use

[GitHub] [airflow] dimberman merged pull request #10872: Modify helm chart to use pod_template_file

2020-09-11 Thread GitBox
dimberman merged pull request #10872: URL: https://github.com/apache/airflow/pull/10872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] turbaszek commented on a change in pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
turbaszek commented on a change in pull request #10864: URL: https://github.com/apache/airflow/pull/10864#discussion_r487189853 ## File path: .gitignore ## @@ -205,3 +205,22 @@ Chart.lock # Might be generated when you build wheels pip-wheel-metadata + +# tmp ... +Backups/

[GitHub] [airflow] turbaszek commented on pull request #10864: Increase typing coverage for postgres provider

2020-09-11 Thread GitBox
turbaszek commented on pull request #10864: URL: https://github.com/apache/airflow/pull/10864#issuecomment-691222028 The CI errors seem to be similar to #10153 as reported by @yuqian90 This is an automated message from the

[GitHub] [airflow] turbaszek opened a new pull request #10889: Move test utils from tests.utils to tests.test_utils

2020-09-11 Thread GitBox
turbaszek opened a new pull request #10889: URL: https://github.com/apache/airflow/pull/10889 Reference: https://github.com/apache/airflow/pull/10470#issuecomment-691115150 This PR moves: - `tests.utils.perf` -> `tests.test_utils.perf` as perf kit is not part of `airflow.utils`

[GitHub] [airflow] ashb opened a new pull request #10887: Fix `breeze -i` error

2020-09-11 Thread GitBox
ashb opened a new pull request #10887: URL: https://github.com/apache/airflow/pull/10887 It was erroring with "unbound" variable, expecting INTEGRATION to be a pre-defined variable. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] coopergillan opened a new pull request #10888: Add type annotations to ZendeskHook, update unit test

2020-09-11 Thread GitBox
coopergillan opened a new pull request #10888: URL: https://github.com/apache/airflow/pull/10888 ### What * Add correct type annotations to ZendeskHook and each method * Update one unit test to call an empty dictionary rather than a NoneType since the argument should be a

[GitHub] [airflow] turbaszek commented on pull request #10470: Move perf_kit to tests.utils

2020-09-11 Thread GitBox
turbaszek commented on pull request #10470: URL: https://github.com/apache/airflow/pull/10470#issuecomment-691214596 The point is that `tests.utils` corresponds to `airflow.utils` and probably should have no other stuff. I will open PR

[GitHub] [airflow] coopergillan commented on issue #9708: Increase typing coverage

2020-09-11 Thread GitBox
coopergillan commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-691210939 I'm giving a shot at Zendesk now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] coopergillan commented on pull request #10671: Add more type annotations to AWS hooks

2020-09-11 Thread GitBox
coopergillan commented on pull request #10671: URL: https://github.com/apache/airflow/pull/10671#issuecomment-691195492 @mik-laj - wondering now it would be better to merge this and then open an issue to come back through and add more detail to the `boto3` type annotations. What do you

[GitHub] [airflow] abhilash1in commented on issue #10855: Mask credentials in Rendered Template tab of task instance details page

2020-09-11 Thread GitBox
abhilash1in commented on issue #10855: URL: https://github.com/apache/airflow/issues/10855#issuecomment-691192888 @mik-laj @kaxil thank you, the similar issues linked above covers this in more detail. Closing this issue.

[GitHub] [airflow] abhilash1in closed issue #10855: Mask credentials in Rendered Template tab of task instance details page

2020-09-11 Thread GitBox
abhilash1in closed issue #10855: URL: https://github.com/apache/airflow/issues/10855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] coopergillan commented on pull request #10671: Add more type annotations to AWS hooks

2020-09-11 Thread GitBox
coopergillan commented on pull request #10671: URL: https://github.com/apache/airflow/pull/10671#issuecomment-691186114 @mik-laj - just now getting back to this and seeing the approval. If you guys think this is good enough for now, let's merge it. I am happy to look into that package you

[GitHub] [airflow] kaxil commented on a change in pull request #10872: Modify helm chart to use pod_template_file

2020-09-11 Thread GitBox
kaxil commented on a change in pull request #10872: URL: https://github.com/apache/airflow/pull/10872#discussion_r487136078 ## File path: airflow/kubernetes/pod_generator.py ## @@ -501,15 +501,16 @@ def reconcile_containers(base_containers: List[k8s.V1Container], )

[GitHub] [airflow] kaxil commented on a change in pull request #10872: Modify helm chart to use pod_template_file

2020-09-11 Thread GitBox
kaxil commented on a change in pull request #10872: URL: https://github.com/apache/airflow/pull/10872#discussion_r487136383 ## File path: airflow/kubernetes/pod_generator.py ## @@ -501,15 +501,16 @@ def reconcile_containers(base_containers: List[k8s.V1Container], )

[GitHub] [airflow] kaxil commented on pull request #10881: Mark task as failed when it fails "sending" in Celery

2020-09-11 Thread GitBox
kaxil commented on pull request #10881: URL: https://github.com/apache/airflow/pull/10881#issuecomment-691174561 One test is failing ``` FAILED tests/executors/test_celery_executor.py::TestCeleryExecutor::test_error_sending_task ```

[GitHub] [airflow] ashb commented on pull request #10886: Don't over-queue tasks in the executors

2020-09-11 Thread GitBox
ashb commented on pull request #10886: URL: https://github.com/apache/airflow/pull/10886#issuecomment-691165920 This doesn't do what I thought. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb closed pull request #10886: Don't over-queue tasks in the executors

2020-09-11 Thread GitBox
ashb closed pull request #10886: URL: https://github.com/apache/airflow/pull/10886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ashb opened a new pull request #10886: Don't over-queue tasks in the executors

2020-09-11 Thread GitBox
ashb opened a new pull request #10886: URL: https://github.com/apache/airflow/pull/10886 This is a small change, but a bigger change in behaviour, and used more in future HA PRs. Previously the flow was to set as many tasks as possible to queued, try to enqueue as many as

[GitHub] [airflow] mjpieters commented on pull request #10770: Add Plugins View in web UI

2020-09-11 Thread GitBox
mjpieters commented on pull request #10770: URL: https://github.com/apache/airflow/pull/10770#issuecomment-691155099 The point of my request was to make it visible where the plugin was loaded from, and what version information we have (if any). Our cluster setup is somewhat

[GitHub] [airflow] mjpieters opened a new pull request #10885: StreamLogWriter: Provide (no-op) close method (backport to v1-10)

2020-09-11 Thread GitBox
mjpieters opened a new pull request #10885: URL: https://github.com/apache/airflow/pull/10885 Some contexts try to close their reference to the stderr stream at logging shutdown, this ensures these don't break. related: #10882, #10884

[GitHub] [airflow] mjpieters opened a new pull request #10884: StreamLogWriter: Provide (no-op) close method.

2020-09-11 Thread GitBox
mjpieters opened a new pull request #10884: URL: https://github.com/apache/airflow/pull/10884 Some contexts try to close their reference to the stderr stream at logging shutdown, this ensures these don't break. closes: #10882

[GitHub] [airflow] ashb commented on a change in pull request #10872: Modify helm chart to use pod_template_file

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10872: URL: https://github.com/apache/airflow/pull/10872#discussion_r487100630 ## File path: chart_pod_template_file/tests/pod-template-file_test.yaml ## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] yiannissakk commented on issue #7883: KubernetesPodOperator had an event of type Pending

2020-09-11 Thread GitBox
yiannissakk commented on issue #7883: URL: https://github.com/apache/airflow/issues/7883#issuecomment-691140735 Hello Saad, I am having exactly the same problem. I think we got our example from the same place too. Did you end up solving this? Thanks Yiannis

[GitHub] [airflow] boring-cyborg[bot] commented on issue #10883: Improve ExternalTaskSensor execution date pattern

2020-09-11 Thread GitBox
boring-cyborg[bot] commented on issue #10883: URL: https://github.com/apache/airflow/issues/10883#issuecomment-691140568 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] sahil-b-shah opened a new issue #10883: Improve ExternalTaskSensor execution date pattern

2020-09-11 Thread GitBox
sahil-b-shah opened a new issue #10883: URL: https://github.com/apache/airflow/issues/10883 Currently in the `ExternalTaskSensor` there are two ways two set the execution date of a DAG/task the sensor is waiting on: - Provide the `execution_delta` which simply adds/subtracts a time

[GitHub] [airflow] dimberman commented on a change in pull request #10872: Modify helm chart to use pod_template_file

2020-09-11 Thread GitBox
dimberman commented on a change in pull request #10872: URL: https://github.com/apache/airflow/pull/10872#discussion_r487089514 ## File path: chart_pod_template_file/tests/pod-template-file_test.yaml ## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] ashb commented on a change in pull request #10872: Modify helm chart to use pod_template_file

2020-09-11 Thread GitBox
ashb commented on a change in pull request #10872: URL: https://github.com/apache/airflow/pull/10872#discussion_r487084231 ## File path: chart_pod_template_file/tests/pod-template-file_test.yaml ## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) under one

  1   2   >