[GitHub] [airflow] QuinRiva closed issue #11568: GCSToBigQueryOperator fails: job Id is not unique

2020-10-15 Thread GitBox
QuinRiva closed issue #11568: URL: https://github.com/apache/airflow/issues/11568 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] QuinRiva opened a new issue #11568: GCSToBigQueryOperator fails: job Id is not unique

2020-10-15 Thread GitBox
QuinRiva opened a new issue #11568: URL: https://github.com/apache/airflow/issues/11568 **Apache Airflow version**: 1.10.12 **Environment**: Centos 7 Host - **Cloud provider or hardware configuration**: - **OS** (e.g. from /etc/os-release): Ubuntu 20.04 Docker Container

[GitHub] [airflow] RaviTezu edited a comment on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.

2020-10-15 Thread GitBox
RaviTezu edited a comment on pull request #11528: URL: https://github.com/apache/airflow/pull/11528#issuecomment-708940977 @mik-laj @turbaszek Could you please take a look? Thanks This is an automated message from the Apach

[GitHub] [airflow] gigkokman commented on pull request #11566: Update bash_operator's doc_string

2020-10-15 Thread GitBox
gigkokman commented on pull request #11566: URL: https://github.com/apache/airflow/pull/11566#issuecomment-709774794 @mik-laj would it be convenient for users to add warning about adding space after bash_command template? Th

[GitHub] [airflow] RaviTezu edited a comment on pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.

2020-10-15 Thread GitBox
RaviTezu edited a comment on pull request #11528: URL: https://github.com/apache/airflow/pull/11528#issuecomment-708940977 @mik-laj @turbaszek Could you please take a look now? This is an automated message from the Apache G

[GitHub] [airflow] stevenhurwitt commented on issue #11567: airflow webserver has broken dependencies?

2020-10-15 Thread GitBox
stevenhurwitt commented on issue #11567: URL: https://github.com/apache/airflow/issues/11567#issuecomment-709716750 nevermind, downgrading to werkzeug 0.16.1 brought me to a google-able sqlalchemy error that involved downgrading sqlalchemy as well and it works now. ---

[GitHub] [airflow] stevenhurwitt closed issue #11567: airflow webserver has broken dependencies?

2020-10-15 Thread GitBox
stevenhurwitt closed issue #11567: URL: https://github.com/apache/airflow/issues/11567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] boring-cyborg[bot] commented on issue #11567: airflow webserver has broken dependencies?

2020-10-15 Thread GitBox
boring-cyborg[bot] commented on issue #11567: URL: https://github.com/apache/airflow/issues/11567#issuecomment-709714260 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] stevenhurwitt opened a new issue #11567: airflow webserver has broken dependencies?

2020-10-15 Thread GitBox
stevenhurwitt opened a new issue #11567: URL: https://github.com/apache/airflow/issues/11567 **Apache Airflow version**: 1.10.5 **Environment**: - **Cloud provider or hardware configuration**: local ubuntu - **OS** (e.g. from /etc/os-release): ubuntu 20.04 - **Kernel** (e

[GitHub] [airflow] gigkokman opened a new pull request #11566: Update bash_operator's doc_string

2020-10-15 Thread GitBox
gigkokman opened a new pull request #11566: URL: https://github.com/apache/airflow/pull/11566 Update doc_string warning space after bash_command to explicit inform new users This is an automated message from the Apache Git S

[airflow] branch constraints-master updated: Updating constraints. Build id:309733697

2020-10-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 54e7ae3 Updating

[airflow] branch constraints-master updated: Updating constraints. Build id:309733697

2020-10-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 54e7ae3 Updating

[GitHub] [airflow] jhtimmins commented on pull request #11189: Prepend `DAG:` to dag permissions

2020-10-15 Thread GitBox
jhtimmins commented on pull request #11189: URL: https://github.com/apache/airflow/pull/11189#issuecomment-709648244 Oh dang, thanks @kaxil ! This is an automated message from the Apache Git Service. To respond to the message

[airflow] branch master updated (89d4dd8 -> 7ab6210)

2020-10-15 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 89d4dd8 Auto-refresh default state (#11559) add 7ab6210 Prepend `DAG:` to dag permissions (#11189) No new

[GitHub] [airflow] kaxil commented on issue #11562: Can't change state of a task instance via the task instance list view

2020-10-15 Thread GitBox
kaxil commented on issue #11562: URL: https://github.com/apache/airflow/issues/11562#issuecomment-709643810 Duplicate of https://github.com/apache/airflow/issues/11513 This is an automated message from the Apache Git Service.

[airflow] branch master updated: Prepend `DAG:` to dag permissions (#11189)

2020-10-15 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 7ab6210 Prepend `DAG:` to dag permissions (

[GitHub] [airflow] kaxil merged pull request #11189: Prepend `DAG:` to dag permissions

2020-10-15 Thread GitBox
kaxil merged pull request #11189: URL: https://github.com/apache/airflow/pull/11189 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil commented on pull request #11189: Prepend `DAG:` to dag permissions

2020-10-15 Thread GitBox
kaxil commented on pull request #11189: URL: https://github.com/apache/airflow/pull/11189#issuecomment-709643183 🚀 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] rynmccrmck commented on a change in pull request #11553: add button in tree view + update href on call modal

2020-10-15 Thread GitBox
rynmccrmck commented on a change in pull request #11553: URL: https://github.com/apache/airflow/pull/11553#discussion_r505911350 ## File path: airflow/www/templates/airflow/dag.html ## @@ -322,21 +322,28 @@ - - -

[airflow] branch master updated (f7e01ab -> 89d4dd8)

2020-10-15 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from f7e01ab Create job for airflow migrations (#11533) add 89d4dd8 Auto-refresh default state (#11559) No new

[airflow] branch master updated (f7e01ab -> 89d4dd8)

2020-10-15 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from f7e01ab Create job for airflow migrations (#11533) add 89d4dd8 Auto-refresh default state (#11559) No new

[GitHub] [airflow] kaxil merged pull request #11559: Auto-refresh default state

2020-10-15 Thread GitBox
kaxil merged pull request #11559: URL: https://github.com/apache/airflow/pull/11559 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ryw edited a comment on issue #11565: [Airflow 2 Alpha] Connection not recognized

2020-10-15 Thread GitBox
ryw edited a comment on issue #11565: URL: https://github.com/apache/airflow/issues/11565#issuecomment-709622299 I think it was related to a missing entry in the `extra` json... I would expect the error to be different than saying it's `not defined`. ``` { "account": "X

[GitHub] [airflow] ryw commented on issue #11565: [Airflow 2 Alpha] Connection not recognized

2020-10-15 Thread GitBox
ryw commented on issue #11565: URL: https://github.com/apache/airflow/issues/11565#issuecomment-709622299 I think it was related to a missing entry in the `extra` json... ``` { "account": "XX.XXX", "warehouse": "", "database": "",

[GitHub] [airflow] ryw closed issue #11565: [Airflow 2 Alpha] Connection not recognized

2020-10-15 Thread GitBox
ryw closed issue #11565: URL: https://github.com/apache/airflow/issues/11565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [airflow] mattluudo closed pull request #11270: [AIRFLOW-10186] Move Tips & Tricks for Oracle shops should be moved to Airflow Docs

2020-10-15 Thread GitBox
mattluudo closed pull request #11270: URL: https://github.com/apache/airflow/pull/11270 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] ryanahamilton commented on a change in pull request #11559: Auto-refresh default state

2020-10-15 Thread GitBox
ryanahamilton commented on a change in pull request #11559: URL: https://github.com/apache/airflow/pull/11559#discussion_r505872927 ## File path: airflow/www/views.py ## @@ -1842,7 +1847,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm): nodes=nodes,

[GitHub] [airflow] ryw opened a new issue #11565: [Airflow 2 Alpha] Connection not recognized

2020-10-15 Thread GitBox
ryw opened a new issue #11565: URL: https://github.com/apache/airflow/issues/11565 Possible i'm doing something wrong, but doesn't seem that Airflow is recognizing my connection. ![Screen Recording 2020-10-15 at 5 14 45 PM](https://user-images.githubusercontent.com/4283/96187069-600

[GitHub] [airflow] eladkal commented on issue #11561: Can't view 2nd log

2020-10-15 Thread GitBox
eladkal commented on issue #11561: URL: https://github.com/apache/airflow/issues/11561#issuecomment-709590239 This is something we are also experiencing in 1.10.11 I suspect this happens when the logs are saved on the worker locally, if the worker is down then the log isn't accessible wh

[GitHub] [airflow] ryanahamilton opened a new pull request #11564: Webpack CSS Minification

2020-10-15 Thread GitBox
ryanahamilton opened a new pull request #11564: URL: https://github.com/apache/airflow/pull/11564 Adds/implements the [OptimizeCSSAssetsPlugin](https://github.com/NMFR/optimize-css-assets-webpack-plugin) Webpack plugin to minify CSS files on-compile as is best practice for Production appl

[GitHub] [airflow] github-actions[bot] commented on pull request #11189: Prepend `DAG:` to dag permissions

2020-10-15 Thread GitBox
github-actions[bot] commented on pull request #11189: URL: https://github.com/apache/airflow/pull/11189#issuecomment-709576236 [The Workflow run](https://github.com/apache/airflow/actions/runs/309370587) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505815593 ## File path: airflow/providers/google/cloud/operators/bigquery.py ## @@ -947,9 +947,7 @@ def execute(self, context) -> None: delegate_t

[GitHub] [airflow] irudson commented on a change in pull request #11555: Updated template_fields_rendereds for PostgresOperator and SimpleHttpOperator

2020-10-15 Thread GitBox
irudson commented on a change in pull request #11555: URL: https://github.com/apache/airflow/pull/11555#discussion_r505812032 ## File path: airflow/providers/http/operators/http.py ## @@ -64,6 +64,7 @@ class SimpleHttpOperator(BaseOperator): 'data', 'headers',

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505812440 ## File path: airflow/providers/google/cloud/hooks/gcs.py ## @@ -260,7 +260,9 @@ def rewrite( destination_bucket.name, # type: ignore[attr-

[GitHub] [airflow] irudson commented on a change in pull request #11555: Updated template_fields_rendereds for PostgresOperator and SimpleHttpOperator

2020-10-15 Thread GitBox
irudson commented on a change in pull request #11555: URL: https://github.com/apache/airflow/pull/11555#discussion_r505812032 ## File path: airflow/providers/http/operators/http.py ## @@ -64,6 +64,7 @@ class SimpleHttpOperator(BaseOperator): 'data', 'headers',

[GitHub] [airflow] ryw commented on issue #11563: Strange behavior around the circle

2020-10-15 Thread GitBox
ryw commented on issue #11563: URL: https://github.com/apache/airflow/issues/11563#issuecomment-709565482 thanks @ryanahamilton This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] ryanahamilton commented on issue #11563: Strange behavior around the circle

2020-10-15 Thread GitBox
ryanahamilton commented on issue #11563: URL: https://github.com/apache/airflow/issues/11563#issuecomment-709565096 I can take a look at this! This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505810546 ## File path: airflow/providers/amazon/aws/operators/sagemaker_base.py ## @@ -41,12 +43,11 @@ class SageMakerBaseOperator(BaseOperator): integer_fie

[GitHub] [airflow] ryw opened a new issue #11563: Strange behavior around the circle

2020-10-15 Thread GitBox
ryw opened a new issue #11563: URL: https://github.com/apache/airflow/issues/11563 Edge is flickery + sometimes I can't click the number ![Screen Recording 2020-10-15 at 4 07 46 PM](https://user-images.githubusercontent.com/4283/96180787-f6cd5300-0f00-11eb-8d0f-989e1ea424ae.gif)

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505808993 ## File path: airflow/providers/amazon/aws/operators/glue.py ## @@ -87,7 +88,7 @@ def __init__( self.s3_bucket = s3_bucket self.iam_rol

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505808378 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -342,26 +356,27 @@ def _execute_datasync_task(self): if not result:

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505808181 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -307,18 +317,22 @@ def _create_datasync_task(self): if not self.task_arn:

[GitHub] [airflow] wolfier commented on issue #11560: Allow for specification of cipher in SftpHook

2020-10-15 Thread GitBox
wolfier commented on issue #11560: URL: https://github.com/apache/airflow/issues/11560#issuecomment-709562764 Here's some [unit tests](https://github.com/ryhsiao/pysftp/blob/master/tests/test_ciphers.py) in pysftp using copts and ciphers. -

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505807619 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -307,18 +317,22 @@ def _create_datasync_task(self): if not self.task_arn:

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505805235 ## File path: airflow/providers/amazon/aws/operators/datasync.py ## @@ -165,27 +166,29 @@ def __init__( ) # Others -self.

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505802397 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -278,7 +272,7 @@ def log_stream(self, log_group, stream_name, start_time=0, skip=0):

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505801559 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -309,8 +303,8 @@ def multi_stream_iter(self, log_group, streams, positions=None):

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505800924 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -105,22 +107,14 @@ def secondary_training_status_message(job_description, prev_descr

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505798253 ## File path: airflow/providers/amazon/aws/hooks/sagemaker.py ## @@ -105,22 +107,14 @@ def secondary_training_status_message(job_description, prev_descr

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505797410 ## File path: airflow/providers/amazon/aws/hooks/glue.py ## @@ -97,14 +97,14 @@ def get_iam_execution_role(self) -> Dict: self.log.error("Fa

[GitHub] [airflow] benbenbang commented on issue #9713: Looping issue using Hashicorp Vault

2020-10-15 Thread GitBox
benbenbang commented on issue #9713: URL: https://github.com/apache/airflow/issues/9713#issuecomment-709551410 Alright, I will start to do the dev asap. For ref, this is insane: https://user-images.githubusercontent.com/6682936/96176759-14181680-0f2d-11eb-8625-96c7892720aa.png";>

[GitHub] [airflow] benbenbang removed a comment on issue #9713: Looping issue using Hashicorp Vault

2020-10-15 Thread GitBox
benbenbang removed a comment on issue #9713: URL: https://github.com/apache/airflow/issues/9713#issuecomment-709543288 Alright, I will start to do the dev asap. For ref, this is insane: https://user-images.githubusercontent.com/6682936/96176759-14181680-0f2d-11eb-8625-96c7892720aa

[GitHub] [airflow] benbenbang edited a comment on issue #9713: Looping issue using Hashicorp Vault

2020-10-15 Thread GitBox
benbenbang edited a comment on issue #9713: URL: https://github.com/apache/airflow/issues/9713#issuecomment-709543288 Alright, I will start to do the dev asap. For ref, this is insane: https://user-images.githubusercontent.com/6682936/96176759-14181680-0f2d-11eb-8625-96c7892720aa.

[GitHub] [airflow] ryw opened a new issue #11562: Can't change state of ti via multiselect

2020-10-15 Thread GitBox
ryw opened a new issue #11562: URL: https://github.com/apache/airflow/issues/11562 clicking multiple task instances from /taskinstance/list/ view and choosing any new state, get error screen https://user-images.githubusercontent.com/4283/96177660-3180bc80-0efc-11eb-8056-c9e3303b81a6.

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-15 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r505790657 ## File path: tests/providers/amazon/aws/operators/test_batch.py ## @@ -86,7 +86,7 @@ def test_init(self): self.assertEqual(self.batch.waiters,

[jira] [Comment Edited] (AIRFLOW-1973) Scheduler log dirs permission issue since airflow 1.9.0

2020-10-15 Thread Parhy (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214940#comment-17214940 ] Parhy edited comment on AIRFLOW-1973 at 10/15/20, 7:31 PM: --- W

[jira] [Commented] (AIRFLOW-1973) Scheduler log dirs permission issue since airflow 1.9.0

2020-10-15 Thread Parhy (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-1973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214940#comment-17214940 ] Parhy commented on AIRFLOW-1973: We are running airflow on k8s. We have version 1.10.10

[GitHub] [airflow] ryw opened a new issue #11561: Can't view 2nd log

2020-10-15 Thread GitBox
ryw opened a new issue #11561: URL: https://github.com/apache/airflow/issues/11561 Running Airflow 2 using `astro` cli - I can only access log for first task attempt ![](https://files.slack.com/files-pri/T02J89GPR-F01D2CV636D/image.png) -

[GitHub] [airflow] benbenbang commented on issue #9713: Looping issue using Hashicorp Vault

2020-10-15 Thread GitBox
benbenbang commented on issue #9713: URL: https://github.com/apache/airflow/issues/9713#issuecomment-709543288 Alright, I will start to do the dev asap. For ref, this is insane: https://user-images.githubusercontent.com/6682936/96176744-0a8eae80-0f2d-11eb-8fef-7323fd9da743.png";>

[GitHub] [airflow] wolfier opened a new issue #11560: Allow for specification of cipher in SftpHook

2020-10-15 Thread GitBox
wolfier opened a new issue #11560: URL: https://github.com/apache/airflow/issues/11560 **Description** I want to specify the cipher to use when creating a SftpHook. Currently this is not possible because there is not a way to propagate the value to CnOpts. https://gi

[GitHub] [airflow] kaxil commented on a change in pull request #11559: Auto-refresh default state

2020-10-15 Thread GitBox
kaxil commented on a change in pull request #11559: URL: https://github.com/apache/airflow/pull/11559#discussion_r505772426 ## File path: airflow/www/views.py ## @@ -1842,7 +1847,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm): nodes=nodes, ed

[GitHub] [airflow] kaxil commented on a change in pull request #11559: Auto-refresh default state

2020-10-15 Thread GitBox
kaxil commented on a change in pull request #11559: URL: https://github.com/apache/airflow/pull/11559#discussion_r505772426 ## File path: airflow/www/views.py ## @@ -1842,7 +1847,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm): nodes=nodes, ed

[GitHub] [airflow] potiuk commented on issue #11554: Disable HA Scheduler when sqlite is used

2020-10-15 Thread GitBox
potiuk commented on issue #11554: URL: https://github.com/apache/airflow/issues/11554#issuecomment-709525768 This happened today during the workshops when running start-airflow with breeze by one of the attendees. Not sure exactly how, I will try to reproduce it.

[GitHub] [airflow] potiuk commented on pull request #11558: Guard against kubernetes not being installed

2020-10-15 Thread GitBox
potiuk commented on pull request #11558: URL: https://github.com/apache/airflow/pull/11558#issuecomment-709522387 Would you mind adding a unit test for it? I think it would be possible to mock import https://stackoverflow.com/questions/8658043/how-to-mock-an-import --

[GitHub] [airflow] ryanahamilton opened a new pull request #11559: Auto-refresh default state

2020-10-15 Thread GitBox
ryanahamilton opened a new pull request #11559: URL: https://github.com/apache/airflow/pull/11559 Follow-up to the auto-refresh feature just added in #11534. This defaults the auto-refresh switch to an "off" state if the DAG does not have `RUNNING` DAG runs. ![image](https://user-i

[GitHub] [airflow] mjpieters opened a new pull request #11558: Guard against kubernetes not being installed

2020-10-15 Thread GitBox
mjpieters opened a new pull request #11558: URL: https://github.com/apache/airflow/pull/11558 If the `kubernetes.client` import fails, then `airflow.kubernetes.pod_generator` also can't be imported, and there won't be attributes on `k8s` to use in `isinstance()` calls. Instead of se

[GitHub] [airflow] turbaszek commented on issue #11557: Can't pass --without-mingle and --without-gossip to celery worker

2020-10-15 Thread GitBox
turbaszek commented on issue #11557: URL: https://github.com/apache/airflow/issues/11557#issuecomment-709516108 According to this test: https://github.com/celery/celery/blob/05da357502a109c05b35392391299d75d181ccab/celery/contrib/testing/worker.py#L110-L122 We should be able to pa

[GitHub] [airflow] mjpieters commented on issue #11556: Anything touching airflow.utils.db triggers an import for kubernetes

2020-10-15 Thread GitBox
mjpieters commented on issue #11556: URL: https://github.com/apache/airflow/issues/11556#issuecomment-709510685 Looks like #10831 was meant to address this, but it missed out on the other import as well as the way `k8s` is actually used. --

[GitHub] [airflow] mjpieters commented on pull request #10831: Remove k8s dependency from serialization

2020-10-15 Thread GitBox
mjpieters commented on pull request #10831: URL: https://github.com/apache/airflow/pull/10831#issuecomment-709508771 Unfortunately, this wasn't a complete fix, see #11556 This is an automated message from the Apache Git Serv

[GitHub] [airflow] mjpieters removed a comment on pull request #10831: Remove k8s dependency from serialization

2020-10-15 Thread GitBox
mjpieters removed a comment on pull request #10831: URL: https://github.com/apache/airflow/pull/10831#issuecomment-709508771 Unfortunately, this wasn't a complete fix, see #11556 This is an automated message from the Apache

[GitHub] [airflow] mjpieters commented on issue #11556: Anything touching airflow.utils.db triggers an import for kubernetes

2020-10-15 Thread GitBox
mjpieters commented on issue #11556: URL: https://github.com/apache/airflow/issues/11556#issuecomment-709505389 I fear there are a few more issues in this area. The problems lie primarily in two sections of `airflow/serialization/serialized_objects.py`: https://github.com/apa

[airflow] branch master updated (81a5b03 -> f7e01ab)

2020-10-15 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 81a5b03 Visual tweaking of TI swatches, legend refactoring (#11550) add f7e01ab Create job for airflow mig

[GitHub] [airflow] turbaszek commented on a change in pull request #11555: Updated template_fields_rendereds for PostgresOperator and SimpleHttpOperator

2020-10-15 Thread GitBox
turbaszek commented on a change in pull request #11555: URL: https://github.com/apache/airflow/pull/11555#discussion_r505742367 ## File path: airflow/providers/http/operators/http.py ## @@ -64,6 +64,7 @@ class SimpleHttpOperator(BaseOperator): 'data', 'headers

[GitHub] [airflow] waleedsamy opened a new issue #11557: Can't pass --without-mingle and --without-gossip to celery worker

2020-10-15 Thread GitBox
waleedsamy opened a new issue #11557: URL: https://github.com/apache/airflow/issues/11557 **Apache Airflow version**: ANY **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): **Environment**: - **Cloud provider or hardware con

[airflow] branch master updated (81a5b03 -> f7e01ab)

2020-10-15 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 81a5b03 Visual tweaking of TI swatches, legend refactoring (#11550) add f7e01ab Create job for airflow mig

[GitHub] [airflow] dimberman merged pull request #11533: Create job for airflow migrations

2020-10-15 Thread GitBox
dimberman merged pull request #11533: URL: https://github.com/apache/airflow/pull/11533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] mjpieters opened a new issue #11556: Anything touching airflow.utils.db triggers an import for kubernetes

2020-10-15 Thread GitBox
mjpieters opened a new issue #11556: URL: https://github.com/apache/airflow/issues/11556 **Apache Airflow version**: 2.0.0a1 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): No kubernetes used. **Environment**: - **OS** (e.g. from /etc/os-releas

[GitHub] [airflow] irudson opened a new pull request #11555: my changes

2020-10-15 Thread GitBox
irudson opened a new pull request #11555: URL: https://github.com/apache/airflow/pull/11555 It adds support for `template_fields_renderers` into two sample operators pointed by @turbaszek in issue #11177 . --- **^ Add meaningful description above** Read the **[Pull Re

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11555: my changes

2020-10-15 Thread GitBox
boring-cyborg[bot] commented on pull request #11555: URL: https://github.com/apache/airflow/pull/11555#issuecomment-709497574 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] github-actions[bot] commented on pull request #11332: SnowflakeToS3Operator

2020-10-15 Thread GitBox
github-actions[bot] commented on pull request #11332: URL: https://github.com/apache/airflow/pull/11332#issuecomment-709495719 [The Workflow run](https://github.com/apache/airflow/actions/runs/309103523) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] aaltay commented on a change in pull request #11375: Dataflow - simplify job statuses

2020-10-15 Thread GitBox
aaltay commented on a change in pull request #11375: URL: https://github.com/apache/airflow/pull/11375#discussion_r505734734 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -98,13 +98,13 @@ class DataflowJobStatus: Helper class with Dataflow job status

[GitHub] [airflow] ashb commented on issue #11554: Disable HA Scheduler when sqlite is used

2020-10-15 Thread GitBox
ashb commented on issue #11554: URL: https://github.com/apache/airflow/issues/11554#issuecomment-709493837 Just checking, this is just when more than one scheduler at the same time, not always? This is an automated message f

[jira] [Closed] (AIRFLOW-6798) Add option for service account values for KubernetesPodOperator

2020-10-15 Thread Parhy (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parhy closed AIRFLOW-6798. -- Resolution: Fixed > Add option for service account values for KubernetesPodOperator > ---

[GitHub] [airflow] potiuk commented on issue #11554: Disable HA Scheduler when sqlite is used

2020-10-15 Thread GitBox
potiuk commented on issue #11554: URL: https://github.com/apache/airflow/issues/11554#issuecomment-709489943 cc: @ashb This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [airflow] potiuk opened a new issue #11554: Disable HA Scheduler when sqlite is used

2020-10-15 Thread GitBox
potiuk opened a new issue #11554: URL: https://github.com/apache/airflow/issues/11554 **Description** When HA Scheduler is enabled and sqlite DB is used you get "Database Locked" problem. We should probably disable HA Scheduler always when sqlite is used. This is easily repro

[airflow] branch master updated (eee4e30 -> 81a5b03)

2020-10-15 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from eee4e30 Add better debug logging to K8sexec and K8sPodOp (#11502) add 81a5b03 Visual tweaking of TI swatches, le

[airflow] branch master updated (eee4e30 -> 81a5b03)

2020-10-15 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from eee4e30 Add better debug logging to K8sexec and K8sPodOp (#11502) add 81a5b03 Visual tweaking of TI swatches, le

[GitHub] [airflow] rynmccrmck commented on a change in pull request #11553: add button in tree view + update href on call modal

2020-10-15 Thread GitBox
rynmccrmck commented on a change in pull request #11553: URL: https://github.com/apache/airflow/pull/11553#discussion_r505726954 ## File path: airflow/www/templates/airflow/dag.html ## @@ -322,21 +322,28 @@ - - -

[GitHub] [airflow] ashb merged pull request #11550: Tree View TI swatch and legend visual tweaks

2020-10-15 Thread GitBox
ashb merged pull request #11550: URL: https://github.com/apache/airflow/pull/11550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] github-actions[bot] commented on pull request #11189: Prepend `DAG:` to dag permissions

2020-10-15 Thread GitBox
github-actions[bot] commented on pull request #11189: URL: https://github.com/apache/airflow/pull/11189#issuecomment-709485872 [The Workflow run](https://github.com/apache/airflow/actions/runs/309068140) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] turbaszek commented on a change in pull request #11553: add button in tree view + update href on call modal

2020-10-15 Thread GitBox
turbaszek commented on a change in pull request #11553: URL: https://github.com/apache/airflow/pull/11553#discussion_r505725460 ## File path: airflow/www/templates/airflow/dag.html ## @@ -322,21 +322,28 @@ - - -

[GitHub] [airflow] turbaszek commented on a change in pull request #11553: add button in tree view + update href on call modal

2020-10-15 Thread GitBox
turbaszek commented on a change in pull request #11553: URL: https://github.com/apache/airflow/pull/11553#discussion_r505713071 ## File path: airflow/www/templates/airflow/dag.html ## @@ -531,8 +538,13 @@ function call_modal_dag(dag) { id = dag && dag.id; ex

[GitHub] [airflow] turbaszek commented on a change in pull request #11553: add button in tree view + update href on call modal

2020-10-15 Thread GitBox
turbaszek commented on a change in pull request #11553: URL: https://github.com/apache/airflow/pull/11553#discussion_r505712593 ## File path: airflow/www/templates/airflow/dag.html ## @@ -531,8 +538,13 @@ function call_modal_dag(dag) { id = dag && dag.id; ex

[GitHub] [airflow] rynmccrmck opened a new pull request #11553: add button in tree view + update href on call modal

2020-10-15 Thread GitBox
rynmccrmck opened a new pull request #11553: URL: https://github.com/apache/airflow/pull/11553 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for mor

[GitHub] [airflow] lboudard closed pull request #11552: Features/data 2605/add redis external option

2020-10-15 Thread GitBox
lboudard closed pull request #11552: URL: https://github.com/apache/airflow/pull/11552 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] lboudard opened a new pull request #11552: Features/data 2605/add redis external option

2020-10-15 Thread GitBox
lboudard opened a new pull request #11552: URL: https://github.com/apache/airflow/pull/11552 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11552: Features/data 2605/add redis external option

2020-10-15 Thread GitBox
boring-cyborg[bot] commented on pull request #11552: URL: https://github.com/apache/airflow/pull/11552#issuecomment-709467619 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] ashb edited a comment on issue #11463: Tags rather than names in variable parts of the metrics

2020-10-15 Thread GitBox
ashb edited a comment on issue #11463: URL: https://github.com/apache/airflow/issues/11463#issuecomment-709449171 Plain statsd doesn't support "tags" is the main issue here. At least I _thought_ it didn't. We should also see of the statsd-to-promethues supports this ---

[GitHub] [airflow] akocukcu commented on issue #10992: Transfer table/data from mssql to mssql

2020-10-15 Thread GitBox
akocukcu commented on issue #10992: URL: https://github.com/apache/airflow/issues/10992#issuecomment-709450160 @turbaszek I would like to work on this. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [airflow] JavierLopezT commented on pull request #11332: SnowflakeToS3Operator

2020-10-15 Thread GitBox
JavierLopezT commented on pull request #11332: URL: https://github.com/apache/airflow/pull/11332#issuecomment-709449318 Hello. I get the error ``` Warning, treated as error: /opt/airflow/docs/_api/airflow/providers/amazon/aws/transfers/snowflake_to_s3/index.rst:30:Unexpected inden

  1   2   3   >