[GitHub] [airflow] ephraimbuddy opened a new pull request #11650: Fix incorrect cloudwatch and wasb taskhandler path in config

2020-10-18 Thread GitBox
ephraimbuddy opened a new pull request #11650: URL: https://github.com/apache/airflow/pull/11650 CloudwatchTaskHandler and WasbTaskHandler were moved to their respective provider packages but their references at airflow_local_settings were not updated. This PR updates it --- **^

[GitHub] [airflow] ephraimbuddy closed pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-18 Thread GitBox
ephraimbuddy closed pull request #11261: URL: https://github.com/apache/airflow/pull/11261 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] ephraimbuddy commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-18 Thread GitBox
ephraimbuddy commented on pull request #11261: URL: https://github.com/apache/airflow/pull/11261#issuecomment-711607574 I want to close this and make a new pull request. I have messed up my local branch. This is an

[GitHub] [airflow] ashishraman opened a new issue #11649: SQLAlchemy string is passed to worker pod in plain text as env var

2020-10-18 Thread GitBox
ashishraman opened a new issue #11649: URL: https://github.com/apache/airflow/issues/11649 **Apache Airflow version**: 1.10.12 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.17 **Environment**: - **Cloud provider or hardware

[GitHub] [airflow] boring-cyborg[bot] commented on issue #11649: SQLAlchemy string is passed to worker pod in plain text as env var

2020-10-18 Thread GitBox
boring-cyborg[bot] commented on issue #11649: URL: https://github.com/apache/airflow/issues/11649#issuecomment-711604449 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[jira] [Commented] (AIRFLOW-6585) Timestamp bug in RefreshKubeConfigLoader

2020-10-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/AIRFLOW-6585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17216458#comment-17216458 ] ASF GitHub Bot commented on AIRFLOW-6585: - mcepok commented on pull request #11219: URL:

[GitHub] [airflow] mcepok commented on pull request #11219: [AIRFLOW-6585] Fixed Timestamp bug in RefreshKubeConfigLoader

2020-10-18 Thread GitBox
mcepok commented on pull request #11219: URL: https://github.com/apache/airflow/pull/11219#issuecomment-711599501 @ashb is this ok or do you want a different approach regarding pendulum? This is an automated message from the

[GitHub] [airflow] ephraimbuddy commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-18 Thread GitBox
ephraimbuddy commented on pull request #11261: URL: https://github.com/apache/airflow/pull/11261#issuecomment-711587149 > I pushed some fixes so it should work now. But it was rather strange (see the CC:) I got a merge conflict in a file you didn't edit which might help in

[GitHub] [airflow] jmcarp commented on pull request #11620: Check response status in slack webhook hook.

2020-10-18 Thread GitBox
jmcarp commented on pull request #11620: URL: https://github.com/apache/airflow/pull/11620#issuecomment-711485023 I think of this as a bug fix and not a breaking change. I think users would be surprised to find that an operator that sends an http request doesn't fail when the response is

[airflow] tag nightly-master updated (ee9bdff -> d93b6e5)

2020-10-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from ee9bdff (commit) to d93b6e5 (commit) from

[airflow] tag nightly-master updated (ee9bdff -> d93b6e5)

2020-10-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from ee9bdff (commit) to d93b6e5 (commit) from

[GitHub] [airflow] github-actions[bot] commented on pull request #11644: Use Python 3 Style Super Class

2020-10-18 Thread GitBox
github-actions[bot] commented on pull request #11644: URL: https://github.com/apache/airflow/pull/11644#issuecomment-711457838 [The Workflow run](https://github.com/apache/airflow/actions/runs/314473481) is cancelling this PR. Building images for the PR has failed. Follow the the workflow

[GitHub] [airflow] github-actions[bot] commented on pull request #11643: Use unittest.mock instead of backported mock library

2020-10-18 Thread GitBox
github-actions[bot] commented on pull request #11643: URL: https://github.com/apache/airflow/pull/11643#issuecomment-711457408 [The Workflow run](https://github.com/apache/airflow/actions/runs/314474043) is cancelling this PR. Building images for the PR has failed. Follow the the workflow

[GitHub] [airflow] kaxil commented on pull request #11627: Add D205 pydocstyle check

2020-10-18 Thread GitBox
kaxil commented on pull request #11627: URL: https://github.com/apache/airflow/pull/11627#issuecomment-711457606 Static checks are failing:: ``` airflow/providers/amazon/aws/sensors/step_function_execution.py:28:111: E501 line too long (118 > 110 characters)

[airflow] branch master updated (8ed2229 -> d93b6e5)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8ed2229 Revert "Fixed an error introduced in selective checks (#11640)" (#11647) add d93b6e5 Revert

[airflow] branch master updated (8ed2229 -> d93b6e5)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8ed2229 Revert "Fixed an error introduced in selective checks (#11640)" (#11647) add d93b6e5 Revert

[airflow] branch master updated (c06addf -> 8ed2229)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from c06addf Revert "Fixes selective tests in case of missing merge commits (#11641)" (#11646) add 8ed2229

[airflow] branch master updated (8ed2229 -> d93b6e5)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8ed2229 Revert "Fixed an error introduced in selective checks (#11640)" (#11647) add d93b6e5 Revert

[airflow] branch master updated (c06addf -> 8ed2229)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from c06addf Revert "Fixes selective tests in case of missing merge commits (#11641)" (#11646) add 8ed2229

[airflow] branch master updated (4fcc71c -> c06addf)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4fcc71c Fixes selective tests in case of missing merge commits (#11641) add c06addf Revert "Fixes

[airflow] branch master updated (c06addf -> 8ed2229)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from c06addf Revert "Fixes selective tests in case of missing merge commits (#11641)" (#11646) add 8ed2229

[airflow] branch master updated (4fcc71c -> c06addf)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4fcc71c Fixes selective tests in case of missing merge commits (#11641) add c06addf Revert "Fixes

[GitHub] [airflow] kaxil merged pull request #11648: Revert "Optimizes CI builds heavily with selective checks (#11541)"

2020-10-18 Thread GitBox
kaxil merged pull request #11648: URL: https://github.com/apache/airflow/pull/11648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil merged pull request #11647: Revert "Fixed an error introduced in selective checks (#11640)"

2020-10-18 Thread GitBox
kaxil merged pull request #11647: URL: https://github.com/apache/airflow/pull/11647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil opened a new pull request #11648: Revert 3

2020-10-18 Thread GitBox
kaxil opened a new pull request #11648: URL: https://github.com/apache/airflow/pull/11648 The static checks are failing, even after the 2 PRs that were merged to fix the issue. For now reverting them is the best option Example: #11645 (which is rebased on latest master and contains

[GitHub] [airflow] kaxil merged pull request #11646: Revert "Fixes selective tests in case of missing merge commits (#11641)"

2020-10-18 Thread GitBox
kaxil merged pull request #11646: URL: https://github.com/apache/airflow/pull/11646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil opened a new pull request #11647: Revert "Fixed an error introduced in selective checks (#11640)"

2020-10-18 Thread GitBox
kaxil opened a new pull request #11647: URL: https://github.com/apache/airflow/pull/11647 The static checks are failing, even after the 2 PRs that were merged to fix the issue. For now reverting them is the best option Example: #11645 (which is rebased on latest master and contains

[GitHub] [airflow] kaxil opened a new pull request #11646: Revert Selective test PRs

2020-10-18 Thread GitBox
kaxil opened a new pull request #11646: URL: https://github.com/apache/airflow/pull/11646 The static checks are failing, even after the 2 PRs that were merged to fix the issue. For now reverting them is the best option --- **^ Add meaningful description above**

[GitHub] [airflow] kaxil opened a new pull request #11645: Remove usage of six

2020-10-18 Thread GitBox
kaxil opened a new pull request #11645: URL: https://github.com/apache/airflow/pull/11645 Since we support Py 3.6, there is no need of six library --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil opened a new pull request #11644: Use Python 3 Style Super Class

2020-10-18 Thread GitBox
kaxil opened a new pull request #11644: URL: https://github.com/apache/airflow/pull/11644 Example: `super(CustomOperator, self).__init__(**kwargs)` instead of `super().__init__(**kwargs)` --- **^ Add meaningful description above** Read the **[Pull Request

[airflow] branch master updated (6fbb235 -> 4fcc71c)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6fbb235 Fixed an error introduced in selective checks (#11640) add 4fcc71c Fixes selective tests in case

[airflow] branch master updated: Fixes selective tests in case of missing merge commits (#11641)

2020-10-18 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 4fcc71c Fixes selective tests in case of

[GitHub] [airflow] kaxil merged pull request #11641: Fixes selective tests in case of missing merge commits

2020-10-18 Thread GitBox
kaxil merged pull request #11641: URL: https://github.com/apache/airflow/pull/11641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil commented on pull request #11642: Update tutorial.rst

2020-10-18 Thread GitBox
kaxil commented on pull request #11642: URL: https://github.com/apache/airflow/pull/11642#issuecomment-711444045 Check https://airflow.readthedocs.io/en/stable/ or http://airflow.apache.org/docs/stable/ for docs for latest available STABLE version (1.10.12)

[GitHub] [airflow] kaxil closed pull request #11642: Update tutorial.rst

2020-10-18 Thread GitBox
kaxil closed pull request #11642: URL: https://github.com/apache/airflow/pull/11642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #10437: Fixes MySQLToS3 float to int conversion

2020-10-18 Thread GitBox
github-actions[bot] commented on pull request #10437: URL: https://github.com/apache/airflow/pull/10437#issuecomment-711443480 [The Workflow run](https://github.com/apache/airflow/actions/runs/314405131) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11642: Update tutorial.rst

2020-10-18 Thread GitBox
boring-cyborg[bot] commented on pull request #11642: URL: https://github.com/apache/airflow/pull/11642#issuecomment-711443402 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] github-actions[bot] commented on pull request #10437: Fixes MySQLToS3 float to int conversion

2020-10-18 Thread GitBox
github-actions[bot] commented on pull request #10437: URL: https://github.com/apache/airflow/pull/10437#issuecomment-711443444 [The Workflow run](https://github.com/apache/airflow/actions/runs/314405054) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] varunmuriyanat opened a new pull request #11642: Update tutorial.rst

2020-10-18 Thread GitBox
varunmuriyanat opened a new pull request #11642: URL: https://github.com/apache/airflow/pull/11642 Changed the airflow dags list to airflow list_dags. Same with list_tasks. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil opened a new pull request #11643: Use unittest.mock instead of backported mock library

2020-10-18 Thread GitBox
kaxil opened a new pull request #11643: URL: https://github.com/apache/airflow/pull/11643 mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards. https://docs.python.org/3/library/unittest.mock.html --- **^ Add meaningful

[GitHub] [airflow] gmontanola edited a comment on pull request #10437: Fixes MySQLToS3 float to int conversion

2020-10-18 Thread GitBox
gmontanola edited a comment on pull request #10437: URL: https://github.com/apache/airflow/pull/10437#issuecomment-711440948 @feluelle I added a simple test to check the **integer conversion**. I'm open to _feedback_ or improvements to the code. Really not used to unit

[GitHub] [airflow] gmontanola edited a comment on pull request #10437: Fixes MySQLToS3 float to int conversion

2020-10-18 Thread GitBox
gmontanola edited a comment on pull request #10437: URL: https://github.com/apache/airflow/pull/10437#issuecomment-711440948 @feluelle I added a simple test to check the **integer conversion**. I'm open to _feedback_ or improvements. I'm really not used to unit testing (but I

[GitHub] [airflow] gmontanola commented on pull request #10437: Fixes MySQLToS3 float to int conversion

2020-10-18 Thread GitBox
gmontanola commented on pull request #10437: URL: https://github.com/apache/airflow/pull/10437#issuecomment-711440948 @feluelle I added a simple test to check the **integer conversion**. I'm open to _feedback_ or improvements. I'm really not used to unit testing (but you love to

[GitHub] [airflow] potiuk edited a comment on pull request #11641: Fixes selective tests in case of missing merge commits

2020-10-18 Thread GitBox
potiuk edited a comment on pull request #11641: URL: https://github.com/apache/airflow/pull/11641#issuecomment-711437539 ¯\_(ツ)_/¯ - some of Github inconsistencies. Any of the committers - some PRs might be failing until this one is merged - seems that GH merge commit vs. lack of it is

[GitHub] [airflow] potiuk commented on pull request #11641: Fixes selective tests in case of missing merge commits

2020-10-18 Thread GitBox
potiuk commented on pull request #11641: URL: https://github.com/apache/airflow/pull/11641#issuecomment-711437623 Would love if someone approves/merges this one if I fall asleep in the meantime :) This is an automated

[GitHub] [airflow] potiuk commented on pull request #11641: Fixes selective tests in case of missing merge commits

2020-10-18 Thread GitBox
potiuk commented on pull request #11641: URL: https://github.com/apache/airflow/pull/11641#issuecomment-711437539 ¯\_(ツ)_/¯ - some of Github inconsistencies. Any of the committers - some PRs might be failing until this one is merged https://github.com/apache/airflow/pull/11641 - seems

[GitHub] [airflow] potiuk commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-18 Thread GitBox
potiuk commented on pull request #11261: URL: https://github.com/apache/airflow/pull/11261#issuecomment-711436993 I pushed some fixes so it should work now. But it was rather strange (see the CC:) This is an automated

[GitHub] [airflow] potiuk commented on pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11541: URL: https://github.com/apache/airflow/pull/11541#issuecomment-711436884 If any of you around: https://github.com/apache/airflow/pull/11641 cc: @ephraimbuddy It turned out that using just merge_commit_sha is not enough. The

[GitHub] [airflow] potiuk opened a new pull request #11641: Fixes selective tests in case of missing merge commits

2020-10-18 Thread GitBox
potiuk opened a new pull request #11641: URL: https://github.com/apache/airflow/pull/11641 In case of very simple changes, there might be no merge commits generated by GitHub. In such cases we should take the commit SHA instead as the base of change calculation for selective tests.

[GitHub] [airflow] potiuk commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-18 Thread GitBox
potiuk commented on pull request #11261: URL: https://github.com/apache/airflow/pull/11261#issuecomment-711433395 trying it on my fork and I think I know how to fix it This is an automated message from the Apache Git

[GitHub] [airflow] potiuk commented on pull request #11261: Fix incorrect cloudwatch and wasb taskhandler path in config template

2020-10-18 Thread GitBox
potiuk commented on pull request #11261: URL: https://github.com/apache/airflow/pull/11261#issuecomment-71143 Hey @ephraimbuddy - can you please rebase now? I believe it should work now This is an automated message from

[airflow] branch master updated: Fixed an error introduced in selective checks (#11640)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 6fbb235 Fixed an error introduced in

[GitHub] [airflow] potiuk merged pull request #11640: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk merged pull request #11640: URL: https://github.com/apache/airflow/pull/11640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711431296 REally strange error :( This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] ephraimbuddy commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
ephraimbuddy commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711430808 Ok This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk opened a new pull request #11640: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk opened a new pull request #11640: URL: https://github.com/apache/airflow/pull/11640 A few remnants of earlier version of the script caused occasional errors. Error introduced in #11541 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711430318 Hey @ephraimbuddy -> can you please rebase your PR on master - this is rather strange as my pRs are running fine rebaed on latest master q

[GitHub] [airflow] potiuk closed pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk closed pull request #11639: URL: https://github.com/apache/airflow/pull/11639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (4655409 -> bf79578)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4655409 Improves stability of K8S tests by caching binaries and repeats (#11634) add bf79578 Fix random

[airflow] branch master updated (4655409 -> bf79578)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4655409 Improves stability of K8S tests by caching binaries and repeats (#11634) add bf79578 Fix random

[GitHub] [airflow] potiuk merged pull request #11535: Fix random kills during pre-commit image building

2020-10-18 Thread GitBox
potiuk merged pull request #11535: URL: https://github.com/apache/airflow/pull/11535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711428151 I do not know exactly how PRs from Github behave. sometimes they return "merge_comit_sha" and sometimes (like it was in this case) it was null. I switched to regular.

[GitHub] [airflow] potiuk commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711425169 > Nice!! Not really :(. Somehow my automated refactor missed it :( This is an automated message from

[GitHub] [airflow] ephraimbuddy commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
ephraimbuddy commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711425033 Nice!! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711424882 I noticed a typo (remnant from previous version of the script) causing failure fof @ephraimbuddy PR https://github.com/apache/airflow/pull/11261 . This is the fix. I think it

[GitHub] [airflow] potiuk opened a new pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk opened a new pull request #11639: URL: https://github.com/apache/airflow/pull/11639 A few remnants of earlier version of the script caused occasional errors. Error introduced in #11541 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on pull request #11639: Fixed an error introduced in selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11639: URL: https://github.com/apache/airflow/pull/11639#issuecomment-711424392 cc: @ephraimbuddy This is an automated message from the Apache Git Service. To respond to the message, please

[airflow] branch master updated: Improves stability of K8S tests by caching binaries and repeats (#11634)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 4655409 Improves stability of K8S tests by

[GitHub] [airflow] potiuk merged pull request #11634: Improves stability of K8S tests by caching binaries and repeats

2020-10-18 Thread GitBox
potiuk merged pull request #11634: URL: https://github.com/apache/airflow/pull/11634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] kaxil commented on issue #11633: Don't include upstream_failed in the 'active task instances' test in the scheduler

2020-10-18 Thread GitBox
kaxil commented on issue #11633: URL: https://github.com/apache/airflow/issues/11633#issuecomment-711413086 Yup we will fix this for alpha2. Thanks for reporting This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on pull request #11634: Improves stability of K8S tests by caching binaries and repeats

2020-10-18 Thread GitBox
potiuk commented on pull request #11634: URL: https://github.com/apache/airflow/pull/11634#issuecomment-711412464 All good @kaxil @mik-laj -> another transient test failure that I am going to take a look tomorrow. But the K8S stability is there.

[airflow] branch master updated: Fix minor typos in tests (#11638)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 885db90 Fix minor typos in tests (#11638)

[GitHub] [airflow] potiuk merged pull request #11638: Fix minor typos in tests

2020-10-18 Thread GitBox
potiuk merged pull request #11638: URL: https://github.com/apache/airflow/pull/11638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #11535: Fix random kills during pre-commit image building

2020-10-18 Thread GitBox
potiuk commented on pull request #11535: URL: https://github.com/apache/airflow/pull/11535#issuecomment-711388471 Hey @kaxil - look at my explaination. It is correct and exactly as intended. I do want the SPIN_PID to be evaluated when the trap is DEFINED and not when it is executed.

[GitHub] [airflow] potiuk commented on a change in pull request #11535: Fix random kills during pre-commit image building

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11535: URL: https://github.com/apache/airflow/pull/11535#discussion_r507200556 ## File path: scripts/ci/libraries/_build_images.sh ## @@ -519,8 +519,8 @@ function build_images::build_ci_image() { " >"${DETECTED_TERMINAL}"

[GitHub] [airflow] potiuk commented on a change in pull request #11634: Improves stability of K8S tests by caching binaries and repeats

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11634: URL: https://github.com/apache/airflow/pull/11634#discussion_r507198882 ## File path: scripts/ci/libraries/_repeats.sh ## @@ -0,0 +1,45 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +#

[airflow] branch master updated (f8ff217 -> 9237338)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from f8ff217 Fix incorrect typing and move config args out of extra connection config to operator args (#11635)

[GitHub] [airflow] potiuk commented on a change in pull request #11634: Improves stability of K8S tests by caching binaries and repeats

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11634: URL: https://github.com/apache/airflow/pull/11634#discussion_r507198632 ## File path: scripts/ci/libraries/_kind.sh ## @@ -66,7 +67,8 @@ function kind::make_sure_kubernetes_tools_are_installed() { if [[ ! -f

[airflow] branch master updated (f8ff217 -> 9237338)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from f8ff217 Fix incorrect typing and move config args out of extra connection config to operator args (#11635)

[airflow] branch master updated (76dd8d0 -> f8ff217)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 76dd8d0 Fix typo in BREEZE.rst (#11637) add f8ff217 Fix incorrect typing and move config args out of extra

[GitHub] [airflow] potiuk commented on pull request #11634: Improves stability of K8S tests by caching binaries and repeats

2020-10-18 Thread GitBox
potiuk commented on pull request #11634: URL: https://github.com/apache/airflow/pull/11634#issuecomment-711371180 Hey @kaxil - that one is for stabiility of K8S tests. They fail rather frequently recently due to intermittent download problems - but this fixes it entirely.

[airflow] branch master updated (76dd8d0 -> f8ff217)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 76dd8d0 Fix typo in BREEZE.rst (#11637) add f8ff217 Fix incorrect typing and move config args out of extra

[airflow] branch master updated (63a1633 -> 76dd8d0)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 63a1633 Update order for pre-commits to fail fast (#11636) add 76dd8d0 Fix typo in BREEZE.rst (#11637) No

[GitHub] [airflow] potiuk merged pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk merged pull request #11541: URL: https://github.com/apache/airflow/pull/11541 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk merged pull request #11635: Fix incorrect typing and move config args out of extra connection config to operator args

2020-10-18 Thread GitBox
potiuk merged pull request #11635: URL: https://github.com/apache/airflow/pull/11635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (63a1633 -> 76dd8d0)

2020-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 63a1633 Update order for pre-commits to fail fast (#11636) add 76dd8d0 Fix typo in BREEZE.rst (#11637) No

[GitHub] [airflow] potiuk commented on pull request #11637: Fix typo in BREEZE.rst

2020-10-18 Thread GitBox
potiuk commented on pull request #11637: URL: https://github.com/apache/airflow/pull/11637#issuecomment-711369614 Aaah. You should have waited for the #11541 :). That's perfect example where it would take~ minute to get that one to complete ;).

[GitHub] [airflow] potiuk merged pull request #11637: Fix typo in BREEZE.rst

2020-10-18 Thread GitBox
potiuk merged pull request #11637: URL: https://github.com/apache/airflow/pull/11637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk commented on pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11541: URL: https://github.com/apache/airflow/pull/11541#issuecomment-711348969 I've also added a nice (I think) and (missing) for sure - intro at the beginning of the CI.rst - describing some basic assumption and ideas behind the optimizations

[GitHub] [airflow] github-actions[bot] commented on pull request #11631: Show Celery stats in webui

2020-10-18 Thread GitBox
github-actions[bot] commented on pull request #11631: URL: https://github.com/apache/airflow/pull/11631#issuecomment-711327038 [The Workflow run](https://github.com/apache/airflow/actions/runs/314041553) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] potiuk commented on pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on pull request #11541: URL: https://github.com/apache/airflow/pull/11541#issuecomment-711325775 All fixed :). This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507191360 ## File path: scripts/ci/selective_ci_checks.sh ## @@ -18,12 +18,17 @@ # shellcheck source=scripts/ci/libraries/_script_init.sh .

[GitHub] [airflow] kaxil commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
kaxil commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507191295 ## File path: .github/workflows/build-images-workflow-run.yml ## @@ -204,19 +217,20 @@ jobs: Source Sha: ${{

[GitHub] [airflow] potiuk commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507190819 ## File path: CI.rst ## @@ -629,6 +628,90 @@ delete old artifacts that are > 7 days old. It only runs for the 'apache/airflow We also have a script

[GitHub] [airflow] potiuk commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507190074 ## File path: .github/workflows/ci.yml ## @@ -70,68 +70,97 @@ jobs: GITHUB_CONTEXT: ${{ toJson(github) }} outputs: waitForImage: ${{

[GitHub] [airflow] potiuk commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507190029 ## File path: .github/workflows/ci.yml ## @@ -70,68 +70,97 @@ jobs: GITHUB_CONTEXT: ${{ toJson(github) }} outputs: waitForImage: ${{

[GitHub] [airflow] potiuk commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507189867 ## File path: .github/workflows/build-images-workflow-run.yml ## @@ -204,19 +217,20 @@ jobs: Source Sha: ${{

[GitHub] [airflow] kaxil commented on a change in pull request #11634: Improves stability of K8S tests by caching binaries and repeats

2020-10-18 Thread GitBox
kaxil commented on a change in pull request #11634: URL: https://github.com/apache/airflow/pull/11634#discussion_r507189869 ## File path: scripts/ci/libraries/_repeats.sh ## @@ -0,0 +1,45 @@ +#!/usr/bin/env bash +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] potiuk commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
potiuk commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507189513 ## File path: .github/workflows/ci.yml ## @@ -70,68 +70,97 @@ jobs: GITHUB_CONTEXT: ${{ toJson(github) }} outputs: waitForImage: ${{

[GitHub] [airflow] kaxil commented on a change in pull request #11541: Optimizes CI builds heavily with selective checks

2020-10-18 Thread GitBox
kaxil commented on a change in pull request #11541: URL: https://github.com/apache/airflow/pull/11541#discussion_r507189433 ## File path: scripts/ci/selective_ci_checks.sh ## @@ -18,12 +18,17 @@ # shellcheck source=scripts/ci/libraries/_script_init.sh .

  1   2   3   >