TobKed commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508222533
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -694,29 +710,23 @@ def _build_dataflow_job_name(job_name: str,
append_job_name: bool
TobKed commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508222123
##
File path: airflow/providers/google/cloud/operators/dataflow.py
##
@@ -406,6 +406,88 @@ def on_kill(self) -> None:
TobKed commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508221739
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -496,17 +517,15 @@ def start_java_dataflow(
variables['jobName'] = name
github-actions[bot] commented on pull request #11670:
URL: https://github.com/apache/airflow/pull/11670#issuecomment-712603194
This is an automated message from the Apache Git Service.
To respond to the message, please log on
potiuk commented on pull request #11662:
URL: https://github.com/apache/airflow/pull/11662#issuecomment-712602796
Small improvement - but useful for pre-commit users who modify scripts (also
allows adding more tests)
This
potiuk closed pull request #11670:
URL: https://github.com/apache/airflow/pull/11670
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from dd1c07b Optimizes CI builds heavily with selective checks (#11656)
add 0373089 Brings back fixup to CI
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from dd1c07b Optimizes CI builds heavily with selective checks (#11656)
add 0373089 Brings back fixup to CI
potiuk merged pull request #11671:
URL: https://github.com/apache/airflow/pull/11671
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potix2 commented on issue #10742:
URL: https://github.com/apache/airflow/issues/10742#issuecomment-712598651
@kaxil Can I take D200?
This is an automated message from the Apache Git Service.
To respond to the message, please
potiuk commented on pull request #11671:
URL: https://github.com/apache/airflow/pull/11671#issuecomment-712592765
Speaking about biting @ashb
This is an automated message from the Apache Git Service.
To respond to the
potiuk opened a new pull request #11671:
URL: https://github.com/apache/airflow/pull/11671
The fixup was lost during the rebase. This one restores it
---
**^ Add meaningful description above**
Read the **[Pull Request
potiuk commented on pull request #11655:
URL: https://github.com/apache/airflow/pull/11655#issuecomment-712590164
Really small and will be helpful to keep the strain on the GA down.
This is an automated message from the
potiuk commented on pull request #11670:
URL: https://github.com/apache/airflow/pull/11670#issuecomment-712589459
Found during #11659
This is an automated message from the Apache Git Service.
To respond to the message,
potiuk opened a new pull request #11670:
URL: https://github.com/apache/airflow/pull/11670
The tests for connection export failed when CLI tests are
run in isolation. The problem was with non-deterministic
sequence of returned rows from connection export query.
Rather than
potiuk edited a comment on pull request #11662:
URL: https://github.com/apache/airflow/pull/11662#issuecomment-712314953
Also random failure. Otherwise it is good!
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new dd1c07b Optimizes CI builds heavily with
potiuk edited a comment on pull request #11656:
URL: https://github.com/apache/airflow/pull/11656#issuecomment-712580528
If we don't try - we won't know :)
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/master by this push:
new dd1c07b Optimizes CI builds heavily with
potiuk merged pull request #11656:
URL: https://github.com/apache/airflow/pull/11656
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
potiuk commented on pull request #11656:
URL: https://github.com/apache/airflow/pull/11656#issuecomment-712580528
If we won't try - we won't know :)
This is an automated message from the Apache Git Service.
To respond to the
mik-laj commented on a change in pull request #11501:
URL: https://github.com/apache/airflow/pull/11501#discussion_r508182849
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -331,6 +361,12 @@ def cancel(self) -> None:
)
mik-laj commented on a change in pull request #11375:
URL: https://github.com/apache/airflow/pull/11375#discussion_r508182014
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -98,13 +98,13 @@ class DataflowJobStatus:
Helper class with Dataflow job
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from d93b6e5 (commit)
to 3970bfa (commit)
from
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to tag nightly-master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
*** WARNING: tag nightly-master was modified! ***
from d93b6e5 (commit)
to 3970bfa (commit)
from
mik-laj commented on issue #11146:
URL: https://github.com/apache/airflow/issues/11146#issuecomment-712544436
@kaxil Any progress on this ticket? I can see Helm Chart still using this
script which is not available in the official image.
mik-laj commented on pull request #10584:
URL: https://github.com/apache/airflow/pull/10584#issuecomment-712543186
I don't know if we should adopt a more generic approach to `EnvFrom`.
https://github.com/apache/airflow/pull/11426/files
mik-laj removed a comment on pull request #10584:
URL: https://github.com/apache/airflow/pull/10584#issuecomment-712541060
Hi. We currently want to significantly simplify
KubernetesExecutor/KubernetesPodOperators and delete many configuration
options.
mik-laj commented on pull request #10584:
URL: https://github.com/apache/airflow/pull/10584#issuecomment-712541060
Hi. We currently want to significantly simplify
KubernetesExecutor/KubernetesPodOperators and delete many configuration
options.
mik-laj commented on a change in pull request #11437:
URL: https://github.com/apache/airflow/pull/11437#discussion_r508152759
##
File path: chart/files/pod-template-file.yaml
##
@@ -78,7 +78,7 @@ spec:
persistentVolumeClaim:
claimName: {{ template
mik-laj commented on a change in pull request #11437:
URL: https://github.com/apache/airflow/pull/11437#discussion_r508152759
##
File path: chart/files/pod-template-file.yaml
##
@@ -78,7 +78,7 @@ spec:
persistentVolumeClaim:
claimName: {{ template
mik-laj commented on a change in pull request #11437:
URL: https://github.com/apache/airflow/pull/11437#discussion_r508152759
##
File path: chart/files/pod-template-file.yaml
##
@@ -78,7 +78,7 @@ spec:
persistentVolumeClaim:
claimName: {{ template
mik-laj commented on a change in pull request #11631:
URL: https://github.com/apache/airflow/pull/11631#discussion_r508137239
##
File path: airflow/www/templates/airflow/stats.html
##
@@ -0,0 +1,96 @@
+{#
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more
github-actions[bot] commented on pull request #11669:
URL: https://github.com/apache/airflow/pull/11669#issuecomment-712505113
[The Workflow run](https://github.com/apache/airflow/actions/runs/316557469)
is cancelling this PR. It in earlier duplicate of 1029499 run.
mik-laj opened a new pull request #11669:
URL: https://github.com/apache/airflow/pull/11669
For readability, we try to keep commands belonging to one group in one file.
However, the Kubernetes command was in the wrong file.
---
**^ Add meaningful description above**
mik-laj commented on issue #11667:
URL: https://github.com/apache/airflow/issues/11667#issuecomment-712493379
I heard that you managed to solve the problem, so I'm assigning you to this
issue and I'm waiting for the guide.
alexbegg commented on a change in pull request #10637:
URL: https://github.com/apache/airflow/pull/10637#discussion_r508098603
##
File path: airflow/www/views.py
##
@@ -563,7 +563,9 @@ def last_dagruns(self, session=None):
return wwwutils.json_response({})
alexbegg commented on pull request #11151:
URL: https://github.com/apache/airflow/pull/11151#issuecomment-712476522
> @alexbegg Could you rebase please? That should fix the failing tests
rebased now
This is an
github-actions[bot] commented on pull request #11668:
URL: https://github.com/apache/airflow/pull/11668#issuecomment-712471548
[The Workflow run](https://github.com/apache/airflow/actions/runs/316424570)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
ryanahamilton commented on a change in pull request #11652:
URL: https://github.com/apache/airflow/pull/11652#discussion_r508079706
##
File path: airflow/www/templates/airflow/dags.html
##
@@ -76,9 +76,21 @@ DAGs
info
-DAG
mik-laj opened a new pull request #11668:
URL: https://github.com/apache/airflow/pull/11668
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)**
for more
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 52b4733 Improvements for pod template file with git sync container
(#11511)
add 3970bfa Pod template
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 52b4733 Improvements for pod template file with git sync container
(#11511)
add 3970bfa Pod template
github-actions[bot] commented on pull request #11659:
URL: https://github.com/apache/airflow/pull/11659#issuecomment-712450541
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #11519:
URL: https://github.com/apache/airflow/pull/11519#issuecomment-712450545
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #11516:
URL: https://github.com/apache/airflow/pull/11516#issuecomment-712450664
[The Workflow run](https://github.com/apache/airflow/actions/runs/316343096)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
github-actions[bot] commented on pull request #11516:
URL: https://github.com/apache/airflow/pull/11516#issuecomment-712450550
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #11659:
URL: https://github.com/apache/airflow/pull/11659#issuecomment-712450267
[The Workflow run](https://github.com/apache/airflow/actions/runs/316309594)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
github-actions[bot] commented on pull request #11516:
URL: https://github.com/apache/airflow/pull/11516#issuecomment-712450276
[The Workflow run](https://github.com/apache/airflow/actions/runs/316309594)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
github-actions[bot] commented on pull request #11519:
URL: https://github.com/apache/airflow/pull/11519#issuecomment-712450270
[The Workflow run](https://github.com/apache/airflow/actions/runs/316309594)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
mik-laj merged pull request #11480:
URL: https://github.com/apache/airflow/pull/11480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
boring-cyborg[bot] commented on pull request #11480:
URL: https://github.com/apache/airflow/pull/11480#issuecomment-712449979
Awesome work, congrats on your first merged pull request!
This is an automated message from
mik-laj closed issue #11286:
URL: https://github.com/apache/airflow/issues/11286
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mik-laj merged pull request #11511:
URL: https://github.com/apache/airflow/pull/11511
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from a221ccb Improvement: Populate 'Configuration JSON' form with DAG
default params json in the Trigger-DAG UI
boring-cyborg[bot] commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-712447068
Awesome work, congrats on your first merged pull request!
This is an automated message from
pcandoalmeida commented on issue #11039:
URL: https://github.com/apache/airflow/issues/11039#issuecomment-712446667
Hey @turbaszek is the above work something I could do perhaps? If it's
straightforward, I could perhaps implement it and then try and finish this rule
mik-laj commented on pull request #11511:
URL: https://github.com/apache/airflow/pull/11511#issuecomment-712446046
A very interesting change. I did not know the `GIT_ONE_TIME` option. Thanks
for adding that. In our case, it very makes sense.
I also see that you made sure that this
ibzib commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508064298
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -783,6 +794,77 @@ def cancel_job(
name=job_name,
github-actions[bot] commented on pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#issuecomment-712429002
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mik-laj commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508048041
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -783,6 +794,77 @@ def cancel_job(
name=job_name,
github-actions[bot] commented on pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#issuecomment-712428727
[The Workflow run](https://github.com/apache/airflow/actions/runs/316249228)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
checks$,^Build
github-actions[bot] commented on pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#issuecomment-712428852
[The Workflow run](https://github.com/apache/airflow/actions/runs/316250139)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
checks$,^Build
This is an automated email from the ASF dual-hosted git repository.
ash pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 73f6367 UX improvements of DAG tag filtering (#11661)
add a221ccb Improvement: Populate 'Configuration JSON'
ashb merged pull request #10839:
URL: https://github.com/apache/airflow/pull/10839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
FelixKJose commented on issue #11667:
URL: https://github.com/apache/airflow/issues/11667#issuecomment-712423679
stuck with this issue for two days:(
This is an automated message from the Apache Git Service.
To respond
mik-laj commented on issue #11667:
URL: https://github.com/apache/airflow/issues/11667#issuecomment-712423072
CC: @potiuk
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mik-laj opened a new issue #11667:
URL: https://github.com/apache/airflow/issues/11667
Hello,
Many users report a problem with ldap with the official Docker image. We
should consider what we want to do with it:
a) add missing images to the image.
b) add documentation that will
potiuk commented on pull request #11656:
URL: https://github.com/apache/airflow/pull/11656#issuecomment-712422237
Also the last nitpick addressed
This is an automated message from the Apache Git Service.
To respond to the
This is an automated email from the ASF dual-hosted git repository.
ash pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 5c0ade4 Brings back GKEStartPodOperator to google provider. (#11664)
add 73f6367 UX improvements of DAG tag
This is an automated email from the ASF dual-hosted git repository.
ash pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 5c0ade4 Brings back GKEStartPodOperator to google provider. (#11664)
add 73f6367 UX improvements of DAG tag
ashb merged pull request #11661:
URL: https://github.com/apache/airflow/pull/11661
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ephraimbuddy opened a new issue #11666:
URL: https://github.com/apache/airflow/issues/11666
**Apache Airflow version**: 2.0
**Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
**Environment**: Docker
- **Cloud provider or hardware
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from a4dc11f Change to pass all extra connection paramaters to psycopg2
(#11019)
add 5c0ade4 Brings back
potiuk commented on a change in pull request #11656:
URL: https://github.com/apache/airflow/pull/11656#discussion_r508036142
##
File path: .github/workflows/ci.yml
##
@@ -202,12 +228,58 @@ jobs:
env:
VERBOSE: false
+ # Those checks are run if no image
mik-laj edited a comment on issue #11657:
URL: https://github.com/apache/airflow/issues/11657#issuecomment-712315157
To be precise,
[terratest](https://terratest.gruntwork.io/docs/getting-started/quick-start/)
is just a library that provides a set of functions that make it easier to write
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from a4dc11f Change to pass all extra connection paramaters to psycopg2
(#11019)
add 5c0ade4 Brings back
potiuk merged pull request #11664:
URL: https://github.com/apache/airflow/pull/11664
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ibzib commented on a change in pull request #8553:
URL: https://github.com/apache/airflow/pull/8553#discussion_r508030912
##
File path: airflow/providers/google/cloud/hooks/dataflow.py
##
@@ -783,6 +794,77 @@ def cancel_job(
name=job_name,
ashb commented on a change in pull request #11656:
URL: https://github.com/apache/airflow/pull/11656#discussion_r508027959
##
File path: .github/workflows/ci.yml
##
@@ -202,12 +228,58 @@ jobs:
env:
VERBOSE: false
+ # Those checks are run if no image
github-actions[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-712406278
[The Workflow run](https://github.com/apache/airflow/actions/runs/316218002)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
github-actions[bot] commented on pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#issuecomment-712406207
[The Workflow run](https://github.com/apache/airflow/actions/runs/316217834)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
ryanahamilton opened a new pull request #11665:
URL: https://github.com/apache/airflow/pull/11665
The DAG tags feature accepts an array of varying strings as values, but the
example DAGS currently only use a single string ("example") across all of the
files. This sample data isn't ideal
RaviTezu commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r508012868
##
File path: airflow/upgrade/rules/mesos_executor_removed.py
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
RaviTezu commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r508012868
##
File path: airflow/upgrade/rules/mesos_executor_removed.py
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
turbaszek commented on a change in pull request #11631:
URL: https://github.com/apache/airflow/pull/11631#discussion_r508011760
##
File path: airflow/www/views.py
##
@@ -2331,6 +2336,45 @@ def task_instances(self):
return json.dumps(task_instances)
+class
mik-laj commented on a change in pull request #11391:
URL: https://github.com/apache/airflow/pull/11391#discussion_r508009471
##
File path: airflow/models/skipmixin.py
##
@@ -122,7 +121,8 @@ def skip_all_except(
"""
self.log.info("Following branch %s",
mik-laj commented on a change in pull request #11391:
URL: https://github.com/apache/airflow/pull/11391#discussion_r508009221
##
File path: airflow/models/dagbag.py
##
@@ -423,8 +423,6 @@ def collect_dags(
dag_folder = correct_maybe_zipped(dag_folder)
-
mik-laj commented on a change in pull request #11241:
URL: https://github.com/apache/airflow/pull/11241#discussion_r508008445
##
File path: airflow/upgrade/rules/undefined_jinja_varaibles.py
##
@@ -0,0 +1,121 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
mik-laj edited a comment on pull request #11223:
URL: https://github.com/apache/airflow/pull/11223#issuecomment-712389122
> 53 successful, 40 failing, 2 cancelled, and 5 skipped checks
CI is sad. Can you fix it?
This
mik-laj commented on pull request #11223:
URL: https://github.com/apache/airflow/pull/11223#issuecomment-712389122
> 53 successful, 40 failing, 2 cancelled, and 5 skipped checks
CI is sad. Can you fix it?
This is an
mik-laj commented on a change in pull request #11241:
URL: https://github.com/apache/airflow/pull/11241#discussion_r508004175
##
File path: airflow/upgrade/rules/undefined_jinja_varaibles.py
##
@@ -0,0 +1,121 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
mik-laj commented on a change in pull request #11241:
URL: https://github.com/apache/airflow/pull/11241#discussion_r508003716
##
File path: airflow/upgrade/rules/undefined_jinja_varaibles.py
##
@@ -0,0 +1,121 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+#
mik-laj commented on a change in pull request #11391:
URL: https://github.com/apache/airflow/pull/11391#discussion_r508001453
##
File path: airflow/upgrade/rules/customoperator_uses_metaclass.py
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
turbaszek commented on a change in pull request #11528:
URL: https://github.com/apache/airflow/pull/11528#discussion_r507998470
##
File path: airflow/upgrade/rules/mesos_executor_removed.py
##
@@ -0,0 +1,39 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
potiuk commented on pull request #11664:
URL: https://github.com/apache/airflow/pull/11664#issuecomment-712383931
> Can you also remove the following lines?
>
ryanahamilton commented on a change in pull request #11661:
URL: https://github.com/apache/airflow/pull/11661#discussion_r507995461
##
File path: airflow/www/views.py
##
@@ -418,12 +418,15 @@ def get_int_arg(value, default=0):
if request.args.get('reset_tags') is not
bbenzikry commented on pull request #11199:
URL: https://github.com/apache/airflow/pull/11199#issuecomment-712378915
@ashb updated
This is an automated message from the Apache Git Service.
To respond to the message, please
zacharya19 commented on a change in pull request #11661:
URL: https://github.com/apache/airflow/pull/11661#discussion_r507981342
##
File path: airflow/www/views.py
##
@@ -418,12 +418,15 @@ def get_int_arg(value, default=0):
if request.args.get('reset_tags') is not
mjpieters commented on a change in pull request #10884:
URL: https://github.com/apache/airflow/pull/10884#discussion_r507985191
##
File path: airflow/utils/log/logging_mixin.py
##
@@ -90,6 +90,14 @@ def __init__(self, logger, level):
self.level = level
1 - 100 of 326 matches
Mail list logo
