[GitHub] [airflow] ashb commented on a change in pull request #11592: Correctly redirect to DAG pages after login

2020-10-20 Thread GitBox
ashb commented on a change in pull request #11592: URL: https://github.com/apache/airflow/pull/11592#discussion_r508465859 ## File path: tests/www/test_decorators.py ## @@ -0,0 +1,28 @@ +from airflow.www import app +from airflow.www.decorators import has_dag_access +from flask_

[GitHub] [airflow] dailingling opened a new issue #11711: OSError: [Errno 12] Cannot allocate memory

2020-10-20 Thread GitBox
dailingling opened a new issue #11711: URL: https://github.com/apache/airflow/issues/11711 **Apache Airflow version**: 1.10.12 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): no **Environment**: - **Cloud provider or hardware configu

[GitHub] [airflow] boring-cyborg[bot] commented on issue #11711: OSError: [Errno 12] Cannot allocate memory

2020-10-20 Thread GitBox
boring-cyborg[bot] commented on issue #11711: URL: https://github.com/apache/airflow/issues/11711#issuecomment-713350127 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713330057 [The Workflow run](https://github.com/apache/airflow/actions/runs/319230004) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] RaviTezu commented on a change in pull request #11528: Add upgrade rule to check for mesos executor and flag to change it.

2020-10-20 Thread GitBox
RaviTezu commented on a change in pull request #11528: URL: https://github.com/apache/airflow/pull/11528#discussion_r509012672 ## File path: airflow/upgrade/rules/mesos_executor_removed.py ## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or m

[airflow] branch master updated: Update TIs with a proper lock (#11683)

2020-10-20 Thread msumit
This is an automated email from the ASF dual-hosted git repository. msumit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 3caa539 Update TIs with a proper lock (#11683)

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713323233 [The Workflow run](https://github.com/apache/airflow/actions/runs/319212260) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[airflow] branch master updated: Update TIs with a proper lock (#11683)

2020-10-20 Thread msumit
This is an automated email from the ASF dual-hosted git repository. msumit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 3caa539 Update TIs with a proper lock (#11683)

[GitHub] [airflow] msumit merged pull request #11683: Update TIs with a proper lock

2020-10-20 Thread GitBox
msumit merged pull request #11683: URL: https://github.com/apache/airflow/pull/11683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] Swalloow closed pull request #11612: Add typing to AWS SageMaker

2020-10-20 Thread GitBox
Swalloow closed pull request #11612: URL: https://github.com/apache/airflow/pull/11612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] Swalloow commented on pull request #11612: Add typing to AWS SageMaker

2020-10-20 Thread GitBox
Swalloow commented on pull request #11612: URL: https://github.com/apache/airflow/pull/11612#issuecomment-713287800 Close the PR due to duplicate #11531 This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] kurtqq commented on issue #10781: Setting cookie_samesite to None in airflow.cfg throws an error

2020-10-20 Thread GitBox
kurtqq commented on issue #10781: URL: https://github.com/apache/airflow/issues/10781#issuecomment-713284542 @potiuk i believe this issue is resolved This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] mik-laj commented on pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
mik-laj commented on pull request #11531: URL: https://github.com/apache/airflow/pull/11531#issuecomment-713269655 Can you do a rebase? This is the only thing blocking me from merging this change. This is an automated messag

[GitHub] [airflow] humbledude opened a new issue #11710: JDBC connect string from connection uri parsed wrongly

2020-10-20 Thread GitBox
humbledude opened a new issue #11710: URL: https://github.com/apache/airflow/issues/11710 **Apache Airflow version**: 1.10.12 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.15.11 **Environment**: - **Cloud provider or

[GitHub] [airflow] boring-cyborg[bot] commented on issue #11710: JDBC connect string from connection uri parsed wrongly

2020-10-20 Thread GitBox
boring-cyborg[bot] commented on issue #11710: URL: https://github.com/apache/airflow/issues/11710#issuecomment-713258883 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713257682 [The Workflow run](https://github.com/apache/airflow/actions/runs/318980139) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[airflow] branch master updated: Fix documentation for PythonVirtualenvOperator (#11700)

2020-10-20 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new f468fc5 Fix documentation for PythonVirt

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11700: Fix documentation for PythonVirtualenvOperator

2020-10-20 Thread GitBox
boring-cyborg[bot] commented on pull request #11700: URL: https://github.com/apache/airflow/pull/11700#issuecomment-713257333 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] mik-laj merged pull request #11700: Fix documentation for PythonVirtualenvOperator

2020-10-20 Thread GitBox
mik-laj merged pull request #11700: URL: https://github.com/apache/airflow/pull/11700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713257139 [The Workflow run](https://github.com/apache/airflow/actions/runs/318978177) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] mik-laj opened a new pull request #11709: Enforce strict rules for yamllint

2020-10-20 Thread GitBox
mik-laj opened a new pull request #11709: URL: https://github.com/apache/airflow/pull/11709 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more i

[airflow] branch constraints-master updated: Updating constraints. Build id:318872354

2020-10-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 26f2a7e Updating

[airflow] branch constraints-master updated: Updating constraints. Build id:318872354

2020-10-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 26f2a7e Updating

[GitHub] [airflow] sreev commented on issue #11366: missing logs from the included libraries

2020-10-20 Thread GitBox
sreev commented on issue #11366: URL: https://github.com/apache/airflow/issues/11366#issuecomment-713244902 the logs seems piped into themselves. here is a sample logs lines from running `% airflow scheduler` in my local on mac. ``` [2020-10-20 18:47:29,294] {logging_mixin.logg

[GitHub] [airflow] ashb commented on a change in pull request #11694: Create pytest fixtures for testing Helm chart templates

2020-10-20 Thread GitBox
ashb commented on a change in pull request #11694: URL: https://github.com/apache/airflow/pull/11694#discussion_r508942109 ## File path: chart/tests/conftest.py ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agre

[GitHub] [airflow] mik-laj opened a new issue #11708: Git sync for plugins

2020-10-20 Thread GitBox
mik-laj opened a new issue #11708: URL: https://github.com/apache/airflow/issues/11708 Hello, Helm Chart currently supports DAG sync, but some users have the need to sync plugins in a similar way as well. It would be fantastic if Helm Chart would make it easy to set up sync `

[GitHub] [airflow] mik-laj opened a new issue #11707: Manage connections, variables, pools in Helm Chart

2020-10-20 Thread GitBox
mik-laj opened a new issue #11707: URL: https://github.com/apache/airflow/issues/11707 Hello, Many users need to implement Airlfow and initialize instances with basic resources. It would be helpful if Helm Chart would facilitate this task. For connections and variables, all we

[GitHub] [airflow] mik-laj opened a new issue #11706: Authorization for Flower

2020-10-20 Thread GitBox
mik-laj opened a new issue #11706: URL: https://github.com/apache/airflow/issues/11706 Hello, The documentation for Helm Chart does not describe how to set up Flower authorization with a password. It would be useful if such documentation was added. It is possible that this will requ

[GitHub] [airflow] mik-laj opened a new issue #11705: External Redis database

2020-10-20 Thread GitBox
mik-laj opened a new issue #11705: URL: https://github.com/apache/airflow/issues/11705 Hello Some users do not want to use Redis provided by Helm Chart, but want to use an external database (installed on the same cluster or in a remote service such as [Cloud Memorystore for Redis](

[GitHub] [airflow] mik-laj opened a new issue #11704: Disable DAG sync when DAG serialization is enabled

2020-10-20 Thread GitBox
mik-laj opened a new issue #11704: URL: https://github.com/apache/airflow/issues/11704 Hello, In order to optimize costs and to improve system security, I think it is worth adding the option to disable DAG synchronization in the web container, if the user has enabled DAG synchroniza

[GitHub] [airflow] mpermana commented on pull request #11592: Correctly redirect to DAG pages after login

2020-10-20 Thread GitBox
mpermana commented on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-713233809 @ashb Added test The checks have 10 skipped and 1 neutral, are they ok? This is an automated mess

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713232463 [The Workflow run](https://github.com/apache/airflow/actions/runs/318883050) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713230222 [The Workflow run](https://github.com/apache/airflow/actions/runs/318872381) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713224503 [The Workflow run](https://github.com/apache/airflow/actions/runs/318845166) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #11702: Better file extension for Helm template

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #11702: URL: https://github.com/apache/airflow/pull/11702#issuecomment-713224507 [The Workflow run](https://github.com/apache/airflow/actions/runs/318845166) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] mik-laj opened a new pull request #11703: Remove unused value in Helm Chart - podMutation

2020-10-20 Thread GitBox
mik-laj opened a new pull request #11703: URL: https://github.com/apache/airflow/pull/11703 This value is only defined in values.yaml, but not used in templates. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apach

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713223096 [The Workflow run](https://github.com/apache/airflow/actions/runs/318839594) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] mik-laj opened a new pull request #11702: Better file extension for Helm template

2020-10-20 Thread GitBox
mik-laj opened a new pull request #11702: URL: https://github.com/apache/airflow/pull/11702 This extension is recognized by Jetbrains and provides a working syntax highlight. After: https://user-images.githubusercontent.com/12058428/96659803-3accb780-1348-11eb-9bc6-5b8a613e05db.png";>

[GitHub] [airflow] mik-laj commented on issue #10553: Exception logging success function instead of failure

2020-10-20 Thread GitBox
mik-laj commented on issue #10553: URL: https://github.com/apache/airflow/issues/10553#issuecomment-713221069 I assigned you to this ticket. 🐈 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [airflow] faihegberg commented on issue #10553: Exception logging success function instead of failure

2020-10-20 Thread GitBox
faihegberg commented on issue #10553: URL: https://github.com/apache/airflow/issues/10553#issuecomment-713220420 @mik-laj @turbaszek If this issue is not taken yet, I'd be interested to take this on :) This is an automated m

[GitHub] [airflow] faihegberg edited a comment on issue #10553: Exception logging success function instead of failure

2020-10-20 Thread GitBox
faihegberg edited a comment on issue #10553: URL: https://github.com/apache/airflow/issues/10553#issuecomment-713220420 @mik-laj @turbaszek If this issue is not taken yet, I'd be interested in taking this on :) This is an au

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713213203 [The Workflow run](https://github.com/apache/airflow/actions/runs/318795591) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713210187 [The Workflow run](https://github.com/apache/airflow/actions/runs/318782789) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] mik-laj opened a new pull request #11701: Consistent use images in Helm Chart

2020-10-20 Thread GitBox
mik-laj opened a new pull request #11701: URL: https://github.com/apache/airflow/pull/11701 - ImagePullPolicy attribute was always set for containers. Previously, the option was in the values.yaml file, but was not used. (`pgbouncerExporter`) - Image setup for git sync was not in the "im

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713207893 [The Workflow run](https://github.com/apache/airflow/actions/runs/318772674) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713196836 [The Workflow run](https://github.com/apache/airflow/actions/runs/318737865) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713195279 [The Workflow run](https://github.com/apache/airflow/actions/runs/318731586) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713194865 [The Workflow run](https://github.com/apache/airflow/actions/runs/318729886) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r508883308 ## File path: airflow/providers/amazon/aws/operators/sagemaker_base.py ## @@ -97,3 +97,8 @@ def preprocess_config(self): def execute(self, context

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r508883308 ## File path: airflow/providers/amazon/aws/operators/sagemaker_base.py ## @@ -97,3 +97,8 @@ def preprocess_config(self): def execute(self, context

[GitHub] [airflow] potix2 commented on a change in pull request #11531: Add type hints to aws provider

2020-10-20 Thread GitBox
potix2 commented on a change in pull request #11531: URL: https://github.com/apache/airflow/pull/11531#discussion_r508881355 ## File path: airflow/providers/amazon/aws/sensors/cloud_formation.py ## @@ -86,8 +95,10 @@ def poke(self, context): return False r

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713177999 [The Workflow run](https://github.com/apache/airflow/actions/runs/318665882) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #10587: Add @dag decorator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #10587: URL: https://github.com/apache/airflow/pull/10587#issuecomment-713178004 [The Workflow run](https://github.com/apache/airflow/actions/runs/318665882) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11700: Fix documentation for PythonVirtualenvOperator

2020-10-20 Thread GitBox
boring-cyborg[bot] commented on pull request #11700: URL: https://github.com/apache/airflow/pull/11700#issuecomment-713177641 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] nheer opened a new pull request #11700: Fix documentation for PythonVirtualenvOperator

2020-10-20 Thread GitBox
nheer opened a new pull request #11700: URL: https://github.com/apache/airflow/pull/11700 Fixed the op_args type description. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713172612 [The Workflow run](https://github.com/apache/airflow/actions/runs/318643419) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #11699: URL: https://github.com/apache/airflow/pull/11699#issuecomment-713165356 [The Workflow run](https://github.com/apache/airflow/actions/runs/318606200) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713165349 [The Workflow run](https://github.com/apache/airflow/actions/runs/318606200) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] turbaszek commented on a change in pull request #10587: Add @dag decorator

2020-10-20 Thread GitBox
turbaszek commented on a change in pull request #10587: URL: https://github.com/apache/airflow/pull/10587#discussion_r508861073 ## File path: docs/concepts.rst ## @@ -162,6 +162,31 @@ Example DAG with decorated style html_content=email_info['body'] ) +DAG decora

[GitHub] [airflow] turbaszek commented on a change in pull request #10587: Add @dag decorator

2020-10-20 Thread GitBox
turbaszek commented on a change in pull request #10587: URL: https://github.com/apache/airflow/pull/10587#discussion_r508861073 ## File path: docs/concepts.rst ## @@ -162,6 +162,31 @@ Example DAG with decorated style html_content=email_info['body'] ) +DAG decora

[GitHub] [airflow] mik-laj commented on a change in pull request #11694: Create pytest fixtures for testing Helm chart templates

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11694: URL: https://github.com/apache/airflow/pull/11694#discussion_r508859361 ## File path: chart/tests/conftest.py ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [airflow] mik-laj commented on a change in pull request #11694: Create pytest fixtures for testing Helm chart templates

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11694: URL: https://github.com/apache/airflow/pull/11694#discussion_r508859361 ## File path: chart/tests/conftest.py ## @@ -0,0 +1,97 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [airflow] turbaszek commented on issue #11039: Create UsingSQLFromBaseHookRule to ease upgrade to Airflow 2.0

2020-10-20 Thread GitBox
turbaszek commented on issue #11039: URL: https://github.com/apache/airflow/issues/11039#issuecomment-713156534 @pcandoalmeida feel free to give it a shot 🚀 This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] ryanahamilton commented on pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
ryanahamilton commented on pull request #11699: URL: https://github.com/apache/airflow/pull/11699#issuecomment-713154903 @mik-laj yes this is running the same configuration as `yarn run lint`, it just has a narrower scope (doesn't run against HTML files yet). -

[airflow] branch master updated (3391c90 -> 3a45f1f)

2020-10-20 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3391c90 fix pod launcher rolebinding in helm chart (#11675) add 3a45f1f Extract Kubernetes command to sepa

[airflow] branch master updated (3391c90 -> 3a45f1f)

2020-10-20 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3391c90 fix pod launcher rolebinding in helm chart (#11675) add 3a45f1f Extract Kubernetes command to sepa

[GitHub] [airflow] mik-laj commented on a change in pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11699: URL: https://github.com/apache/airflow/pull/11699#discussion_r508854034 ## File path: airflow/www/static/js/base.js ## @@ -47,57 +48,56 @@ function changDisplayedTimezone(tz) { }); } -var el = document.createElement('s

[airflow] branch master updated (3391c90 -> 3a45f1f)

2020-10-20 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3391c90 fix pod launcher rolebinding in helm chart (#11675) add 3a45f1f Extract Kubernetes command to sepa

[GitHub] [airflow] mik-laj commented on a change in pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11699: URL: https://github.com/apache/airflow/pull/11699#discussion_r508854034 ## File path: airflow/www/static/js/base.js ## @@ -47,57 +48,56 @@ function changDisplayedTimezone(tz) { }); } -var el = document.createElement('s

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713152992 [The Workflow run](https://github.com/apache/airflow/actions/runs/318580734) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713152792 [The Workflow run](https://github.com/apache/airflow/actions/runs/318579598) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] mik-laj commented on pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
mik-laj commented on pull request #11699: URL: https://github.com/apache/airflow/pull/11699#issuecomment-713152550 Does this eslint configuration meet the project style guide? https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#follow-javascript-style-guide -

[airflow] branch master updated (5df2842 -> 3391c90)

2020-10-20 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5df2842 Improve legibility with greater contrast ratio in footer and pagination (#11690) add 3391c90 fix

[GitHub] [airflow] dimberman merged pull request #11669: Extract Kubernetes command to separate file

2020-10-20 Thread GitBox
dimberman merged pull request #11669: URL: https://github.com/apache/airflow/pull/11669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[airflow] branch master updated (5df2842 -> 3391c90)

2020-10-20 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5df2842 Improve legibility with greater contrast ratio in footer and pagination (#11690) add 3391c90 fix

[GitHub] [airflow] dimberman merged pull request #11675: fix pod launcher rolebinding in helm chart

2020-10-20 Thread GitBox
dimberman merged pull request #11675: URL: https://github.com/apache/airflow/pull/11675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dimberman closed pull request #10190: Chart rbac modifications

2020-10-20 Thread GitBox
dimberman closed pull request #10190: URL: https://github.com/apache/airflow/pull/10190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11675: fix pod launcher rolebinding in helm chart

2020-10-20 Thread GitBox
boring-cyborg[bot] commented on pull request #11675: URL: https://github.com/apache/airflow/pull/11675#issuecomment-713151793 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] mik-laj commented on a change in pull request #11693: add python helm testing framework

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11693: URL: https://github.com/apache/airflow/pull/11693#discussion_r508852272 ## File path: tests/helm/test_git_sync_scheduler.py ## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

[GitHub] [airflow] mik-laj commented on a change in pull request #11693: add python helm testing framework

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11693: URL: https://github.com/apache/airflow/pull/11693#discussion_r508851415 ## File path: tests/helm/test_git_sync_scheduler.py ## @@ -0,0 +1,136 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contri

[GitHub] [airflow] mik-laj commented on a change in pull request #11693: add python helm testing framework

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11693: URL: https://github.com/apache/airflow/pull/11693#discussion_r508850541 ## File path: tests/helm/__init__.py ## @@ -0,0 +1,16 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment: I think t

[GitHub] [airflow] ryanahamilton commented on a change in pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
ryanahamilton commented on a change in pull request #11699: URL: https://github.com/apache/airflow/pull/11699#discussion_r508846727 ## File path: airflow/www/templates/airflow/dags.html ## @@ -75,7 +75,7 @@ DAGs - info +

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713146180 [The Workflow run](https://github.com/apache/airflow/actions/runs/318556155) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] ryanahamilton opened a new pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-20 Thread GitBox
ryanahamilton opened a new pull request #11699: URL: https://github.com/apache/airflow/pull/11699 The codebase has existing ESLint JavaScript linting rules configured, but they are not enforced (until now). - I've added the `eslint` check to the pre-commit hooks. - Refactored all

[GitHub] [airflow] mik-laj commented on a change in pull request #11693: add python helm testing framework

2020-10-20 Thread GitBox
mik-laj commented on a change in pull request #11693: URL: https://github.com/apache/airflow/pull/11693#discussion_r508845350 ## File path: airflow/utils/helm_template_generator.py ## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one Review comment

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713138721 [The Workflow run](https://github.com/apache/airflow/actions/runs/318531276) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[GitHub] [airflow] turbaszek opened a new pull request #11698: Revert "Refactor celery worker command (#11336)"

2020-10-20 Thread GitBox
turbaszek opened a new pull request #11698: URL: https://github.com/apache/airflow/pull/11698 This reverts commit 02ce45cafec22a0a80257b2144d99ec8bb41c961. That refactored Celery worker to be compatible with 5.0. However this introduced some incompatibilities. Closes: #11622

[GitHub] [airflow] turbaszek edited a comment on issue #11697: Celery worker hostname no longer supports %h, %n & %d patterns

2020-10-20 Thread GitBox
turbaszek edited a comment on issue #11697: URL: https://github.com/apache/airflow/issues/11697#issuecomment-713136307 To be honest, I think we will need to revert #11336 due to #11622 , it's more feasible than upgrading to 5.0 as suggested in the latter issue

[GitHub] [airflow] turbaszek commented on issue #11697: Celery worker hostname no longer supports %h, %n & %d patterns

2020-10-20 Thread GitBox
turbaszek commented on issue #11697: URL: https://github.com/apache/airflow/issues/11697#issuecomment-713136307 To be honest, I think we will need to revert #11336 due to #1162, it's more feasible than upgrading to 5.0 as suggested in the latter issue -

[airflow] branch master updated (349b081 -> 5df2842)

2020-10-20 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 349b081 Add D200 pydocstyle check (#11688) add 5df2842 Improve legibility with greater contrast ratio i

[GitHub] [airflow] mik-laj commented on pull request #11627: Add D205 pydocstyle check

2020-10-20 Thread GitBox
mik-laj commented on pull request #11627: URL: https://github.com/apache/airflow/pull/11627#issuecomment-713133192 Static checks are sad. ``` airflow/kubernetes/kube_client.py:69 in private function `_enable_tcp_keepalive`: D205: 1 blank line required between summary line a

[GitHub] [airflow] github-actions[bot] commented on pull request #9879: Implement Compute Engine SSH hook and operator

2020-10-20 Thread GitBox
github-actions[bot] commented on pull request #9879: URL: https://github.com/apache/airflow/pull/9879#issuecomment-713132542 [The Workflow run](https://github.com/apache/airflow/actions/runs/318510560) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build

[airflow] branch master updated (349b081 -> 5df2842)

2020-10-20 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 349b081 Add D200 pydocstyle check (#11688) add 5df2842 Improve legibility with greater contrast ratio i

[GitHub] [airflow] mik-laj commented on issue #11696: WebUI does not have access to pod logs

2020-10-20 Thread GitBox
mik-laj commented on issue #11696: URL: https://github.com/apache/airflow/issues/11696#issuecomment-713132237 @FloChehab Can you look at it also? This is an automated message from the Apache Git Service. To respond to the mes

[airflow] branch master updated (349b081 -> 5df2842)

2020-10-20 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 349b081 Add D200 pydocstyle check (#11688) add 5df2842 Improve legibility with greater contrast ratio i

[GitHub] [airflow] mik-laj merged pull request #11690: Improve legibility with increased contrast ratio in footer and pagination

2020-10-20 Thread GitBox
mik-laj merged pull request #11690: URL: https://github.com/apache/airflow/pull/11690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] mik-laj commented on pull request #11688: Add D200 pydocstyle check

2020-10-20 Thread GitBox
mik-laj commented on pull request #11688: URL: https://github.com/apache/airflow/pull/11688#issuecomment-713130765 Thanks for the effort. I know that making changes to many files at the same time is not easy and causes various problems.

[GitHub] [airflow] mik-laj commented on issue #11697: Celery worker hostname no longer supports %h, %n & %d patterns

2020-10-20 Thread GitBox
mik-laj commented on issue #11697: URL: https://github.com/apache/airflow/issues/11697#issuecomment-713128948 CC: @turbaszek @auvipy This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] mik-laj edited a comment on issue #11697: Celery worker hostname no longer supports %h, %n & %d patterns

2020-10-20 Thread GitBox
mik-laj edited a comment on issue #11697: URL: https://github.com/apache/airflow/issues/11697#issuecomment-713128948 CC: @turbaszek @auvipy Can you look at it? This is an automated message from the Apache Git Service. To resp

[airflow] branch master updated (cb7c67d -> 349b081)

2020-10-20 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from cb7c67d Fix example DAGs in pip packages (#11687) add 349b081 Add D200 pydocstyle check (#11688) No ne

  1   2   3   >