[GitHub] [airflow] jhtimmins commented on pull request #11362: Use resource permissions for Airflow view access

2020-10-21 Thread GitBox
jhtimmins commented on pull request #11362: URL: https://github.com/apache/airflow/pull/11362#issuecomment-714273877 @ashb ok I added the docs for the website. Lemme know what you think of this format. https://github.com/apache/airflow/pull/11362/files#diff-5821e749f4956a14f3d0aa939985a542

[GitHub] [airflow] mpermana commented on pull request #11592: Correctly redirect to DAG pages after login

2020-10-21 Thread GitBox
mpermana commented on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-714269597 @ashb Looks like now only 1 failing check and thats not due to my change: Run pydocstyle

[GitHub] [airflow] github-actions[bot] commented on pull request #11738: Fixes ROVIDERS -> PROVIDERS typo in Dockerfile

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11738: URL: https://github.com/apache/airflow/pull/11738#issuecomment-714268553 [The Workflow run](https://github.com/apache/airflow/actions/runs/321459509) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #11659: Enables splitting tests into smaller chunks

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11659: URL: https://github.com/apache/airflow/pull/11659#issuecomment-714268561 [The Workflow run](https://github.com/apache/airflow/actions/runs/321459509) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #11592: Correctly redirect to DAG pages after login

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-714268548 [The Workflow run](https://github.com/apache/airflow/actions/runs/321459509) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] potiuk commented on pull request #11719: Add airflow upgrade

2020-10-21 Thread GitBox
potiuk commented on pull request #11719: URL: https://github.com/apache/airflow/pull/11719#issuecomment-714258732 After Tomek's experience with telling people to make PRs to 1-10-test I added the mising explanation on v1-10-test/v1-10-stable branches in https://github.com/apache/airflow/bl

[GitHub] [airflow] potiuk edited a comment on pull request #11719: Add airflow upgrade

2020-10-21 Thread GitBox
potiuk edited a comment on pull request #11719: URL: https://github.com/apache/airflow/pull/11719#issuecomment-714257579 Fine for me :). I think maybe it would be great to document the process we have on that, this way we would not have to make any personal assumptions. For sure - as learn

[GitHub] [airflow] potiuk commented on pull request #11719: Add airflow upgrade

2020-10-21 Thread GitBox
potiuk commented on pull request #11719: URL: https://github.com/apache/airflow/pull/11719#issuecomment-714257579 Fine for me :). I think maybe it would be great to document the process we have on that, this way we would not have to make any personal assumptions. For sure - as learning we

[airflow] branch master updated (9150330 -> 1da8379)

2020-10-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9150330 Add Google Cloud Memorystore Memcached Operators (#10121) add 1da8379 Fix static checks after merging

[airflow] branch master updated (9150330 -> 1da8379)

2020-10-21 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9150330 Add Google Cloud Memorystore Memcached Operators (#10121) add 1da8379 Fix static checks after merging

[GitHub] [airflow] potiuk merged pull request #11737: Fix static checks after merging #10121

2020-10-21 Thread GitBox
potiuk merged pull request #11737: URL: https://github.com/apache/airflow/pull/11737 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #11738: Fixes ROVIDERS -> PROVIDERS typo in Dockerfile

2020-10-21 Thread GitBox
potiuk commented on pull request #11738: URL: https://github.com/apache/airflow/pull/11738#issuecomment-714249970 cc: @bbossy This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk opened a new pull request #11738: Fixes ROVIDERS -> PROVIDERS typo in Dockerfile

2020-10-21 Thread GitBox
potiuk opened a new pull request #11738: URL: https://github.com/apache/airflow/pull/11738 There was a typo in the original file when review was made in the #11529 but apparently this typo was still left in one place and as the result, providers have not been installed in the master

[GitHub] [airflow] potiuk commented on issue #11695: Master production docker image does not yet have providers installed.

2020-10-21 Thread GitBox
potiuk commented on issue #11695: URL: https://github.com/apache/airflow/issues/11695#issuecomment-714248166 RGH. I thought I fixed it but apparently onle the ENV! THANKS A LOT ! This is a total bummer ! -

[GitHub] [airflow] potiuk edited a comment on issue #11695: Master production docker image does not yet have providers installed.

2020-10-21 Thread GitBox
potiuk edited a comment on issue #11695: URL: https://github.com/apache/airflow/issues/11695#issuecomment-714248166 RGH. I thought I fixed it but apparently only the ENV! THANKS A LOT ! This is a total bummer ! --

[GitHub] [airflow] shivanshs9 commented on a change in pull request #10987: Fix: add support for no-menu plugin views (#10788)

2020-10-21 Thread GitBox
shivanshs9 commented on a change in pull request #10987: URL: https://github.com/apache/airflow/pull/10987#discussion_r509895817 ## File path: airflow/www/extensions/init_views.py ## @@ -73,8 +73,12 @@ def init_plugins(app): appbuilder = app.appbuilder for view in p

[GitHub] [airflow] bbossy commented on issue #11695: Master production docker image does not yet have providers installed.

2020-10-21 Thread GitBox
bbossy commented on issue #11695: URL: https://github.com/apache/airflow/issues/11695#issuecomment-714236354 @potiuk I tracked this down to a typo in the [Dockerfile](https://github.com/apache/airflow/blob/172820db4d2009dd26fa8aef4a864fb8a3d7e78d/Dockerfile#L212): **ROVIDERS** instea

[GitHub] [airflow] ayush-san commented on issue #8467: ImportError: cannot import name 'bytes_type' from 'oauthlib.common'

2020-10-21 Thread GitBox
ayush-san commented on issue #8467: URL: https://github.com/apache/airflow/issues/8467#issuecomment-714227433 @joshzana They have made the required changes for Airflow 2.0 https://github.com/apache/airflow/blob/master/UPDATING.md#breaking-change-in-oauth. ---

[GitHub] [airflow] github-actions[bot] commented on pull request #10254: Warning about unsafe migrations

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #10254: URL: https://github.com/apache/airflow/pull/10254#issuecomment-714205645 [The Workflow run](https://github.com/apache/airflow/actions/runs/321244722) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] mik-laj commented on a change in pull request #11736: Vault with optional Variables

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #11736: URL: https://github.com/apache/airflow/pull/11736#discussion_r509853949 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -112,7 +112,7 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin): def __init_

[GitHub] [airflow] mik-laj commented on pull request #10254: Warning about unsafe migrations

2020-10-21 Thread GitBox
mik-laj commented on pull request #10254: URL: https://github.com/apache/airflow/pull/10254#issuecomment-714199119 I rebased this chaange to latest master. When it's green, I'll merge the change. This is an automated message

[GitHub] [airflow] mik-laj commented on issue #9708: Increase typing coverage

2020-10-21 Thread GitBox
mik-laj commented on issue #9708: URL: https://github.com/apache/airflow/issues/9708#issuecomment-714197157 The assumptions from the first post have been met - each provider has coverage of at least 75%. Therefore, I consider the ticket **completed**. We can do more type annotations, but

[GitHub] [airflow] mik-laj closed issue #9708: Increase typing coverage

2020-10-21 Thread GitBox
mik-laj closed issue #9708: URL: https://github.com/apache/airflow/issues/9708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] mik-laj commented on a change in pull request #11736: Vault with optional Variables

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #11736: URL: https://github.com/apache/airflow/pull/11736#discussion_r509853949 ## File path: airflow/providers/hashicorp/secrets/vault.py ## @@ -112,7 +112,7 @@ class VaultBackend(BaseSecretsBackend, LoggingMixin): def __init_

[GitHub] [airflow] mik-laj opened a new pull request #11737: Fix static checks after merging #10121

2020-10-21 Thread GitBox
mik-laj opened a new pull request #11737: URL: https://github.com/apache/airflow/pull/11737 This one didn't have the latest rules for static checks. https://github.com/apache/airflow/pull/10121 --- **^ Add meaningful description above** Read the **[Pull Request G

[GitHub] [airflow] fhoda opened a new pull request #11736: Vault with optional Variables

2020-10-21 Thread GitBox
fhoda opened a new pull request #11736: URL: https://github.com/apache/airflow/pull/11736 In some cases organizations may not want to use Vault for Airflow Variable, but instead for Airflow Connections only. The proposed PR makes Variables optional in Vault when using Vault as the Alternat

[GitHub] [airflow] github-actions[bot] commented on pull request #11735: Improve Cloud Memorystore for Redis example

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11735: URL: https://github.com/apache/airflow/pull/11735#issuecomment-714185463 [The Workflow run](https://github.com/apache/airflow/actions/runs/321164733) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #11592: Correctly redirect to DAG pages after login

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-714185471 [The Workflow run](https://github.com/apache/airflow/actions/runs/321164733) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[airflow] branch constraints-master updated: Updating constraints. Build id:321058385

2020-10-21 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new f2931c2 Updating

[GitHub] [airflow] mpermana removed a comment on pull request #11592: Correctly redirect to DAG pages after login

2020-10-21 Thread GitBox
mpermana removed a comment on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-714173747 @ashb any idea why files that i dont change failed test: airflow/providers/sftp/hooks/sftp.py This i

[GitHub] [airflow] mpermana commented on pull request #11592: Correctly redirect to DAG pages after login

2020-10-21 Thread GitBox
mpermana commented on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-714173747 @ashb any idea why files that i dont change failed test: airflow/providers/sftp/hooks/sftp.py This is an aut

[airflow] branch master updated (b9d677c -> 9150330)

2020-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from b9d677c Add type hints to aws provider (#11531) add 9150330 Add Google Cloud Memorystore Memcached Ope

[GitHub] [airflow] mik-laj commented on pull request #11735: Improve Cloud Memorystore for Redis example

2020-10-21 Thread GitBox
mik-laj commented on pull request #11735: URL: https://github.com/apache/airflow/pull/11735#issuecomment-714173277 CC: @tanjinP This is an automated message from the Apache Git Service. To respond to the message, please log

[airflow] branch master updated: Add Google Cloud Memorystore Memcached Operators (#10121)

2020-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 9150330 Add Google Cloud Memorystore Mem

[GitHub] [airflow] mik-laj opened a new pull request #11735: Improve Cloud Memorystore for Redis example

2020-10-21 Thread GitBox
mik-laj opened a new pull request #11735: URL: https://github.com/apache/airflow/pull/11735 Some tasks cannot be performed simultaneously, resulting in instability. Sometimes this DAG was successful but sometimes unsuccessful. Before: ![before-redis](https://user-images.githubuse

[GitHub] [airflow] mik-laj closed issue #8286: Cloud Memorystore for Memcached operators

2020-10-21 Thread GitBox
mik-laj closed issue #8286: URL: https://github.com/apache/airflow/issues/8286 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] mik-laj merged pull request #10121: Google Cloud Memorystore Memcached Operators

2020-10-21 Thread GitBox
mik-laj merged pull request #10121: URL: https://github.com/apache/airflow/pull/10121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] mik-laj commented on pull request #10121: Google Cloud Memorystore Memcached Operators

2020-10-21 Thread GitBox
mik-laj commented on pull request #10121: URL: https://github.com/apache/airflow/pull/10121#issuecomment-714170148 Only one small problem. Besides, everything is beautiful and works. https://user-images.githubusercontent.com/12058428/96808717-a599f380-1419-11eb-86af-b39628e670c6.png";>

[GitHub] [airflow] mik-laj commented on a change in pull request #10121: Google Cloud Memorystore Memcached Operators

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #10121: URL: https://github.com/apache/airflow/pull/10121#discussion_r509831495 ## File path: airflow/providers/google/cloud/example_dags/example_cloud_memorystore.py ## @@ -229,3 +251,80 @@ failover_instance >> delete_instanc

[GitHub] [airflow] mik-laj commented on a change in pull request #10121: Google Cloud Memorystore Memcached Operators

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #10121: URL: https://github.com/apache/airflow/pull/10121#discussion_r509831495 ## File path: airflow/providers/google/cloud/example_dags/example_cloud_memorystore.py ## @@ -229,3 +251,80 @@ failover_instance >> delete_instanc

[GitHub] [airflow] mik-laj commented on issue #11297: More type hints for Amazon provider

2020-10-21 Thread GitBox
mik-laj commented on issue #11297: URL: https://github.com/apache/airflow/issues/11297#issuecomment-714086523 @potix2 @mlgruby @scrambldchannel I assigned you to this ticket 🐱 This is an automated message from the Apache Git

[airflow] branch master updated (ae791e1 -> b9d677c)

2020-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from ae791e1 Fix formatting errors introduced in #11720 (#11733) add b9d677c Add type hints to aws provider

[airflow] branch master updated: Add type hints to aws provider (#11531)

2020-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new b9d677c Add type hints to aws provider

[GitHub] [airflow] mik-laj merged pull request #11531: Add type hints to aws provider

2020-10-21 Thread GitBox
mik-laj merged pull request #11531: URL: https://github.com/apache/airflow/pull/11531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] yuqian90 commented on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
yuqian90 commented on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-714033588 Hi @KulykDmytro, the original issue reported in #10686 and #10725 has been fixed in #10751 and will be released in the release of airflow. I assume `latest_only` is a `Lates

[GitHub] [airflow] potix2 commented on pull request #11531: Add type hints to aws provider

2020-10-21 Thread GitBox
potix2 commented on pull request #11531: URL: https://github.com/apache/airflow/pull/11531#issuecomment-714015305 @mik-laj It's ready for merging. I overlooked that static checking was successful because `CI Build / Static checks: basic checks only` was skipped. -

[GitHub] [airflow] mik-laj opened a new pull request #11734: Improve web server stopping

2020-10-21 Thread GitBox
mik-laj opened a new pull request #11734: URL: https://github.com/apache/airflow/pull/11734 If we send signal SIGTERM - 15 several times to airflow webserver, then gunicorn can become [defunct process](https://askubuntu.com/questions/201303/what-is-a-defunct-process-and-why-doesnt-it-get

[airflow] branch master updated (6c3f435 -> ae791e1)

2020-10-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6c3f435 Refactor "loading" state of DAGs view to remove visual jank (#11725) add ae791e1 Fix formatting e

[airflow] branch master updated (6c3f435 -> ae791e1)

2020-10-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6c3f435 Refactor "loading" state of DAGs view to remove visual jank (#11725) add ae791e1 Fix formatting e

[GitHub] [airflow] github-actions[bot] commented on pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11730: URL: https://github.com/apache/airflow/pull/11730#issuecomment-713922544 [The Workflow run](https://github.com/apache/airflow/actions/runs/320872220) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] kaxil merged pull request #11733: Fix formatting errors introduced in #11720

2020-10-21 Thread GitBox
kaxil merged pull request #11733: URL: https://github.com/apache/airflow/pull/11733 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] joshzana commented on issue #8467: ImportError: cannot import name 'bytes_type' from 'oauthlib.common'

2020-10-21 Thread GitBox
joshzana commented on issue #8467: URL: https://github.com/apache/airflow/issues/8467#issuecomment-713901916 Any update on this bug? It appears to only affect usage of airflow within the official docker image, as the unofficial puckel/docker image does not hit the bug with version 1.10.10

[GitHub] [airflow] github-actions[bot] commented on pull request #11732: Ensure that manually creating a DAG run doesn't "block" the scheduler

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11732: URL: https://github.com/apache/airflow/pull/11732#issuecomment-713899295 [The Workflow run](https://github.com/apache/airflow/actions/runs/320797006) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11730: URL: https://github.com/apache/airflow/pull/11730#issuecomment-713899288 [The Workflow run](https://github.com/apache/airflow/actions/runs/320797006) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #11699: Enforce ESLint (JavaScript linting) with pre-commit hooks

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11699: URL: https://github.com/apache/airflow/pull/11699#issuecomment-713899285 [The Workflow run](https://github.com/apache/airflow/actions/runs/320797006) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] ashb commented on pull request #10632: Log task_instance execution duration as milliseconds

2020-10-21 Thread GitBox
ashb commented on pull request #10632: URL: https://github.com/apache/airflow/pull/10632#issuecomment-713897242 Hmmm all the K8s tests failing is a worrying sign. Could you rebase and see if that fixes it? This is an automat

[GitHub] [airflow] ashb commented on issue #9976: In one DAG one task to next task took a lot of time

2020-10-21 Thread GitBox
ashb commented on issue #9976: URL: https://github.com/apache/airflow/issues/9976#issuecomment-713895994 Likely improved massive in Airflow 2.0.0 alpha by the AIP-15 work This is an automated message from the Apache Git Serv

[GitHub] [airflow] ashb commented on pull request #11733: Fix formatting errors introduced in #11720

2020-10-21 Thread GitBox
ashb commented on pull request #11733: URL: https://github.com/apache/airflow/pull/11733#issuecomment-713892758 Merging now to unblock other PRs. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] ashb opened a new pull request #11733: Fix formatting errors introduced in #11720

2020-10-21 Thread GitBox
ashb opened a new pull request #11733: URL: https://github.com/apache/airflow/pull/11733 I think we merged this when GH Actions hadn't created the jobs yet. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow

[GitHub] [airflow] github-actions[bot] commented on pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11730: URL: https://github.com/apache/airflow/pull/11730#issuecomment-713890339 [The Workflow run](https://github.com/apache/airflow/actions/runs/320768388) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] ashb opened a new pull request #11732: Ensure that manually creating a DAG run doesn't "block" the scheduler

2020-10-21 Thread GitBox
ashb opened a new pull request #11732: URL: https://github.com/apache/airflow/pull/11732 It was possible to "block" the scheduler such that it would not schedule or queue tasks for a dag if you triggered a DAG run when the DAG was already at the max active runs. This approach works

[airflow] branch master updated (1fb3c28 -> 6c3f435)

2020-10-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1fb3c28 Add support for setting ciphers for SFTPHook (#11720) add 6c3f435 Refactor "loading" state of DAGs

[airflow] branch master updated (1fb3c28 -> 6c3f435)

2020-10-21 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1fb3c28 Add support for setting ciphers for SFTPHook (#11720) add 6c3f435 Refactor "loading" state of DAGs

[GitHub] [airflow] ashb commented on pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb commented on pull request #11730: URL: https://github.com/apache/airflow/pull/11730#issuecomment-713883409 @mik-laj I changed it just after you reviewed, so wanted to see if you're still happy. Instead of creating a new `State.terminal` set, I adjusted the existing `State.finis

[GitHub] [airflow] kaxil merged pull request #11725: Refactor "loading" state of DAGs view to remove visual jank

2020-10-21 Thread GitBox
kaxil merged pull request #11725: URL: https://github.com/apache/airflow/pull/11725 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] mik-laj commented on issue #11073: Test that the xcom API endpoint handles joins properly

2020-10-21 Thread GitBox
mik-laj commented on issue #11073: URL: https://github.com/apache/airflow/issues/11073#issuecomment-713883150 I think we need to add unit tests to prevent regression. This is an automated message from the Apache Git Service.

[GitHub] [airflow] github-actions[bot] commented on pull request #11693: add python helm testing framework

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11693: URL: https://github.com/apache/airflow/pull/11693#issuecomment-713882972 [The Workflow run](https://github.com/apache/airflow/actions/runs/320741472) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] github-actions[bot] commented on pull request #11592: Correctly redirect to DAG pages after login

2020-10-21 Thread GitBox
github-actions[bot] commented on pull request #11592: URL: https://github.com/apache/airflow/pull/11592#issuecomment-713882978 [The Workflow run](https://github.com/apache/airflow/actions/runs/320741472) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Buil

[GitHub] [airflow] ashb commented on a change in pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb commented on a change in pull request #11730: URL: https://github.com/apache/airflow/pull/11730#discussion_r509700963 ## File path: airflow/utils/state.py ## @@ -114,6 +114,16 @@ def color_fg(cls, state): have been interrupted; in any case, it is no longer running.

[GitHub] [airflow] mik-laj commented on issue #11366: missing logs from the included libraries

2020-10-21 Thread GitBox
mik-laj commented on issue #11366: URL: https://github.com/apache/airflow/issues/11366#issuecomment-713878165 Can you update your first post to match the template? In particular, I am interested in the Airflow version. https://raw.githubusercontent.com/apache/airflow/master/.github/ISSU

[GitHub] [airflow] kaxil opened a new issue #11731: Using affinity and labels in pod_mutation_hook is not backwards-compatible in 1.10.12

2020-10-21 Thread GitBox
kaxil opened a new issue #11731: URL: https://github.com/apache/airflow/issues/11731 **Apache Airflow version**: 1.10.12 **What happened**: Using the following `pod_mutation_hook` failed in 1.10.12 (it should have been backwards-compatible with 1.10

[GitHub] [airflow] OmairK commented on issue #11073: Test that the xcom API endpoint handles joins properly

2020-10-21 Thread GitBox
OmairK commented on issue #11073: URL: https://github.com/apache/airflow/issues/11073#issuecomment-713872651 @jhtimmins is this issue still relevant after this [change](https://github.com/apache/airflow/pull/10594/commits/bbd08a3c529f7af40842b80c42793b775071743e)?

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713869568 Anyhow behavior not corresponds with [documentation ](https://airflow.apache.org/docs/stable/concepts.html?highlight=branch#latest-run-only) Even using a code snippet

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713869568 Anyhow behavior not corresponds with [documentation ](https://airflow.apache.org/docs/stable/concepts.html?highlight=branch#latest-run-only) Even using a code snippet

[GitHub] [airflow] KulykDmytro commented on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro commented on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713869568 Anyhow behavior not corresponds with [documentation ](https://airflow.apache.org/docs/stable/concepts.html?highlight=branch#latest-run-only) Even using a code snippet mention

[GitHub] [airflow] ashb commented on a change in pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb commented on a change in pull request #11730: URL: https://github.com/apache/airflow/pull/11730#discussion_r509684070 ## File path: airflow/utils/state.py ## @@ -114,6 +114,16 @@ def color_fg(cls, state): have been interrupted; in any case, it is no longer running.

[GitHub] [airflow] ashb commented on a change in pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb commented on a change in pull request #11730: URL: https://github.com/apache/airflow/pull/11730#discussion_r509682544 ## File path: airflow/models/dagrun.py ## @@ -387,7 +387,7 @@ def update_state( ti.task = dag.get_task(ti.task_id) unfinished_tasks

[GitHub] [airflow] ashb commented on a change in pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb commented on a change in pull request #11730: URL: https://github.com/apache/airflow/pull/11730#discussion_r509682312 ## File path: airflow/jobs/scheduler_job.py ## @@ -1473,7 +1473,7 @@ def _do_scheduling(self, session) -> int: func.count(TI.execution_dat

[GitHub] [airflow] ashb opened a new pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb opened a new pull request #11730: URL: https://github.com/apache/airflow/pull/11730 This was messing up the "max_active_runs" calculation, and this fix is a "hack" until we add a better approach of adding a queued state to DagRuns -- at which point we don't even have to do this ca

[GitHub] [airflow] ashb commented on pull request #11730: Stop scheduler from thinking that upstream_failed tasks are running

2020-10-21 Thread GitBox
ashb commented on pull request #11730: URL: https://github.com/apache/airflow/pull/11730#issuecomment-713867721 /cc @mjpieters This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713855548 Another one example on 1.10.12 shows same behavior (join task skipping) for downstream tasks despite of any `trigger_rule` set (`all_done`, `none_failed`, `none_failed_o

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713855548 Another one example on 1.10.12 shows same behavior (join task skipping) for downstream tasks despite of any `trigger_rule` set (`all_done`, `none_failed`, `none_failed_o

[GitHub] [airflow] mik-laj commented on a change in pull request #10987: Fix: add support for no-menu plugin views (#10788)

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #10987: URL: https://github.com/apache/airflow/pull/10987#discussion_r509670185 ## File path: airflow/www/extensions/init_views.py ## @@ -73,8 +73,12 @@ def init_plugins(app): appbuilder = app.appbuilder for view in plug

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713855548 Another one example on 1.10.12 shows same behavior (join task skipping) for downstream tasks despite of any `trigger_rule` set (`all_success`, `all_done`, `none_failed`,

[GitHub] [airflow] KulykDmytro edited a comment on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro edited a comment on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713855548 Another one example on 1.10.12 shows same behavior for downstream tasks despite of any `trigger_rule` set (`all_success`, `all_done`, `none_failed`, `none_failed_or_skip

[GitHub] [airflow] KulykDmytro commented on issue #10686: Common tasks in downstream of multiple branches always set to skipped due to 'Not Previously Skipped' dependency

2020-10-21 Thread GitBox
KulykDmytro commented on issue #10686: URL: https://github.com/apache/airflow/issues/10686#issuecomment-713855548 Another one example on 1.10.12 shows same behavior for downstream task ``` import datetime as dt from airflow.models import DAG from airflow.operators.dummy_oper

[GitHub] [airflow] mik-laj commented on pull request #8818: Add support for Microsoft Azure Blob Storage in Google Cloud Storage Transfer Service operators

2020-10-21 Thread GitBox
mik-laj commented on pull request #8818: URL: https://github.com/apache/airflow/pull/8818#issuecomment-713853591 @khyurri Do you need help? I will gladly do it for you. This is an automated message from the Apache Git Servic

[GitHub] [airflow] ashb commented on issue #11633: Don't include upstream_failed in the 'active task instances' test in the scheduler

2020-10-21 Thread GitBox
ashb commented on issue #11633: URL: https://github.com/apache/airflow/issues/11633#issuecomment-713853131 I'm re-working that query in question a bit as part of fixing #11582, I'll encorporate this fix in there and add a test case for it --

[GitHub] [airflow] mik-laj commented on a change in pull request #11726: Add DataflowJobStatusSensor

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #11726: URL: https://github.com/apache/airflow/pull/11726#discussion_r509663487 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -268,9 +271,8 @@ def _check_dataflow_job_state(self, job) -> bool: rai

[GitHub] [airflow] mik-laj commented on a change in pull request #11726: Add DataflowJobStatusSensor

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #11726: URL: https://github.com/apache/airflow/pull/11726#discussion_r509662589 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -268,9 +271,8 @@ def _check_dataflow_job_state(self, job) -> bool: rai

[GitHub] [airflow] mik-laj commented on a change in pull request #11726: Add DataflowJobStatusSensor

2020-10-21 Thread GitBox
mik-laj commented on a change in pull request #11726: URL: https://github.com/apache/airflow/pull/11726#discussion_r509662589 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -268,9 +271,8 @@ def _check_dataflow_job_state(self, job) -> bool: rai

[GitHub] [airflow] ashb commented on pull request #11719: Add airflow upgrade

2020-10-21 Thread GitBox
ashb commented on pull request #11719: URL: https://github.com/apache/airflow/pull/11719#issuecomment-713850732 Personally I've been treating v1-10-stable like we treat master -- i.e. don't rebase without a very good reason.

[GitHub] [airflow] sreev edited a comment on issue #11366: missing logs from the included libraries

2020-10-21 Thread GitBox
sreev edited a comment on issue #11366: URL: https://github.com/apache/airflow/issues/11366#issuecomment-713244902 the logs seems piped into themselves. here is a sample logs lines from running `% airflow scheduler` in my local on mac. ``` [2020-10-20 18:47:29,294] {logging_mix

[airflow] branch master updated (950c16d -> 1fb3c28)

2020-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 950c16d Retry requests in case of error in Google ML Engine Hook (#11712) add 1fb3c28 Add support for

[airflow] branch master updated (950c16d -> 1fb3c28)

2020-10-21 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 950c16d Retry requests in case of error in Google ML Engine Hook (#11712) add 1fb3c28 Add support for

[GitHub] [airflow] sreev edited a comment on issue #11366: missing logs from the included libraries

2020-10-21 Thread GitBox
sreev edited a comment on issue #11366: URL: https://github.com/apache/airflow/issues/11366#issuecomment-713244902 the logs seems piped into themselves. here is a sample logs lines from running `% airflow scheduler` in my local on mac. ``` [2020-10-20 18:47:29,294] {logging_mix

[GitHub] [airflow] sreev edited a comment on issue #11366: missing logs from the included libraries

2020-10-21 Thread GitBox
sreev edited a comment on issue #11366: URL: https://github.com/apache/airflow/issues/11366#issuecomment-713244902 the logs seems piped into themselves. here is a sample logs lines from running `% airflow scheduler` in my local on mac. ``` [2020-10-20 18:47:29,294] {logging_mix

[GitHub] [airflow] ashb commented on a change in pull request #11693: add python helm testing framework

2020-10-21 Thread GitBox
ashb commented on a change in pull request #11693: URL: https://github.com/apache/airflow/pull/11693#discussion_r509624100 ## File path: chart_tests/test_templates/git_sync_scheduler/git-sync-existing-claim.yaml ## @@ -0,0 +1,21 @@ +# Licensed to the Apache Software Foundation

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11720: Add support for setting ciphers for SFTPHook

2020-10-21 Thread GitBox
boring-cyborg[bot] commented on pull request #11720: URL: https://github.com/apache/airflow/pull/11720#issuecomment-713847099 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] mik-laj merged pull request #11720: Add support for setting ciphers for SFTPHook

2020-10-21 Thread GitBox
mik-laj merged pull request #11720: URL: https://github.com/apache/airflow/pull/11720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

  1   2   3   4   >