[GitHub] [airflow] github-actions[bot] commented on pull request #12304: Docs installation improvements

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #12304: URL: https://github.com/apache/airflow/pull/12304#issuecomment-725893098 [The Workflow run](https://github.com/apache/airflow/actions/runs/359202172) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static

[GitHub] [airflow] Zedmor opened a new pull request #12305: JSON as response for 404 not found

2020-11-11 Thread GitBox
Zedmor opened a new pull request #12305: URL: https://github.com/apache/airflow/pull/12305 In case of existing issue, reference it using one of the following: closes: https://github.com/apache/airflow/issues/12131 ### JSON is not returned for API requests with incorrect

[GitHub] [airflow] Acehaidrey commented on pull request #9544: Add metric for scheduling delay between first run task & expected start time

2020-11-11 Thread GitBox
Acehaidrey commented on pull request #9544: URL: https://github.com/apache/airflow/pull/9544#issuecomment-725882481 Hey all sorry for all the delays. Working on it currently and will have the fixes in by tomorrow. Thanks for bearing with me! Seeing that we can use the

[GitHub] [airflow] zjffdu commented on issue #11305: Authorization with Identity Aware Proxy

2020-11-11 Thread GitBox
zjffdu commented on issue #11305: URL: https://github.com/apache/airflow/issues/11305#issuecomment-725867226 > @zjffdu How is the identity from Apache Knox passed to other applications? Have you ever tried integrating other applications with Apache Knox? It looks like there's

[GitHub] [airflow] mik-laj commented on issue #12282: Rewrite Breeze in Python

2020-11-11 Thread GitBox
mik-laj commented on issue #12282: URL: https://github.com/apache/airflow/issues/12282#issuecomment-725844781 I'm interested too. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-11-11 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-725839722 @kaxil Please review. I'll fix the two conflicting files, looks like it gets changed in master frequently enough.

[GitHub] [airflow] mik-laj commented on a change in pull request #12249: Add DataflowJobMessagesSensor and DataflowAutoscalingEventsSensor (Depends on: #11726)

2020-11-11 Thread GitBox
mik-laj commented on a change in pull request #12249: URL: https://github.com/apache/airflow/pull/12249#discussion_r521835730 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -225,6 +243,67 @@ def _fetch_job_by_id(self, job_id: str) -> dict:

[GitHub] [airflow] mik-laj commented on a change in pull request #11726: Add DataflowJobStatusSensor and support non-blocking execution of jobs

2020-11-11 Thread GitBox
mik-laj commented on a change in pull request #11726: URL: https://github.com/apache/airflow/pull/11726#discussion_r521835489 ## File path: airflow/providers/google/cloud/sensors/dataflow.py ## @@ -0,0 +1,115 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] mik-laj opened a new pull request #12304: Docs installation improvements

2020-11-11 Thread GitBox
mik-laj opened a new pull request #12304: URL: https://github.com/apache/airflow/pull/12304 I've improved the documentation a bit by separating the reference documentation from the concept documentation. I also added reference documentation for providers along with Python API reference

[GitHub] [airflow] yangrong688 commented on issue #12282: Rewrite Breeze in Python

2020-11-11 Thread GitBox
yangrong688 commented on issue #12282: URL: https://github.com/apache/airflow/issues/12282#issuecomment-725776357 I would like to contribute. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] caddac commented on issue #12282: Rewrite Breeze in Python

2020-11-11 Thread GitBox
caddac commented on issue #12282: URL: https://github.com/apache/airflow/issues/12282#issuecomment-725774821 I'm interested. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] kukigai commented on pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on pull request #12126: URL: https://github.com/apache/airflow/pull/12126#issuecomment-725772492 @turbaszek please see the updated code. This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] github-actions[bot] commented on pull request #12303: K8s yaml templates not rendered by k8sexecutor

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #12303: URL: https://github.com/apache/airflow/pull/12303#issuecomment-725768741 [The Workflow run](https://github.com/apache/airflow/actions/runs/358816685) is cancelling this PR. Building images for the PR has failed. Follow the the workflow

[GitHub] [airflow] AndersonReyes commented on a change in pull request #10349: infer multiple_output from return type annotation

2020-11-11 Thread GitBox
AndersonReyes commented on a change in pull request #10349: URL: https://github.com/apache/airflow/pull/10349#discussion_r521711097 ## File path: docs/tutorial_taskflow_api.rst ## @@ -144,6 +144,22 @@ the dependencies as shown below. :end-before: [END main_flow]

[GitHub] [airflow] dimberman opened a new pull request #12303: K8s yaml templates not rendered by k8sexecutor

2020-11-11 Thread GitBox
dimberman opened a new pull request #12303: URL: https://github.com/apache/airflow/pull/12303 There is a bug in the yaml template rendering caused by the logic that yaml templates are only generated when the current executor is the k8sexecutor. This is a problem as the templates are

[GitHub] [airflow] jhtimmins opened a new issue #12302: Web views don't consider DAG-level permissions

2020-11-11 Thread GitBox
jhtimmins opened a new issue #12302: URL: https://github.com/apache/airflow/issues/12302 Dag-level permissions aren’t considered on web views. The built-in permissions are using a the default `has_access()` method, rather than the custom method.

[GitHub] [airflow] jhtimmins opened a new issue #12301: DAG action views should only show DAGs a user can edit

2020-11-11 Thread GitBox
jhtimmins opened a new issue #12301: URL: https://github.com/apache/airflow/issues/12301 The DAG view only shows DAGs that a user has view access to. The action views should only show DAGs the user can edit, even though they're all showing up right now.

[GitHub] [airflow] jhtimmins opened a new issue #12300: Permissions appear to reload repeatedly

2020-11-11 Thread GitBox
jhtimmins opened a new issue #12300: URL: https://github.com/apache/airflow/issues/12300 This results in slow UI load time and too many permissions records Please assign to @jhtimmins This is an automated message from

[GitHub] [airflow] Zedmor commented on issue #12282: Rewrite Breeze in Python

2020-11-11 Thread GitBox
Zedmor commented on issue #12282: URL: https://github.com/apache/airflow/issues/12282#issuecomment-725751853 I would like that! sign me up This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil edited a comment on issue #12272: Package vulnerability scan failing on lodash CVE

2020-11-11 Thread GitBox
kaxil edited a comment on issue #12272: URL: https://github.com/apache/airflow/issues/12272#issuecomment-725749306 Yes we had fixed it in https://github.com/apache/airflow/pull/9921 and even bumped it to 4.17.20 in https://github.com/apache/airflow/pull/11095

[GitHub] [airflow] kaxil edited a comment on issue #12272: Package vulnerability scan failing on lodash CVE

2020-11-11 Thread GitBox
kaxil edited a comment on issue #12272: URL: https://github.com/apache/airflow/issues/12272#issuecomment-725749306 Yes we had even bumped it to 4.17.20 in https://github.com/apache/airflow/pull/11095 This is an automated

[GitHub] [airflow] kaxil commented on issue #12272: Package vulnerability scan failing on lodash CVE

2020-11-11 Thread GitBox
kaxil commented on issue #12272: URL: https://github.com/apache/airflow/issues/12272#issuecomment-725749306 Yes we had fixed it in https://github.com/apache/airflow/pull/11095 This is an automated message from the Apache Git

[GitHub] [airflow] kaxil closed issue #12272: Package vulnerability scan failing on lodash CVE

2020-11-11 Thread GitBox
kaxil closed issue #12272: URL: https://github.com/apache/airflow/issues/12272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] branch master updated: Replace remaining decorated DAGs reference (#12299)

2020-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new ee544b4 Replace remaining decorated DAGs

[GitHub] [airflow] kaxil merged pull request #12299: Replace remaining decorated DAGs reference

2020-11-11 Thread GitBox
kaxil merged pull request #12299: URL: https://github.com/apache/airflow/pull/12299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated (9276607 -> fa2b033)

2020-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9276607 Add session_parameters option to snowflake_hook (#12071) add fa2b033 Add reference for

[GitHub] [airflow] kaxil merged pull request #12297: Add reference for SubDagOperator in docs

2020-11-11 Thread GitBox
kaxil merged pull request #12297: URL: https://github.com/apache/airflow/pull/12297 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #12299: Replace remaining decorated DAGs reference

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #12299: URL: https://github.com/apache/airflow/pull/12299#issuecomment-725744770 The PR is ready to be merged. No tests are needed! This is an automated message from the Apache

[airflow] branch master updated (4f5e0ed -> 9276607)

2020-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4f5e0ed Update INTHEWILD.md (#12293) add 9276607 Add session_parameters option to snowflake_hook (#12071)

[airflow] branch master updated (4f5e0ed -> 9276607)

2020-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4f5e0ed Update INTHEWILD.md (#12293) add 9276607 Add session_parameters option to snowflake_hook (#12071)

[GitHub] [airflow] kaxil commented on issue #11731: Using affinity and labels in pod_mutation_hook is not backwards-compatible in 1.10.12

2020-11-11 Thread GitBox
kaxil commented on issue #11731: URL: https://github.com/apache/airflow/issues/11731#issuecomment-725744220 @dimberman Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] kaxil commented on issue #12290: Got a sqlite3.OperationalError while runing airflow scheduler

2020-11-11 Thread GitBox
kaxil commented on issue #12290: URL: https://github.com/apache/airflow/issues/12290#issuecomment-725743794 Please add more information like Airflow Version used and how to reproduce the issue. This is an automated message

[airflow] branch master updated (4f5e0ed -> 9276607)

2020-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4f5e0ed Update INTHEWILD.md (#12293) add 9276607 Add session_parameters option to snowflake_hook (#12071)

[airflow] branch master updated (4f5e0ed -> 9276607)

2020-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4f5e0ed Update INTHEWILD.md (#12293) add 9276607 Add session_parameters option to snowflake_hook (#12071)

[GitHub] [airflow] kaxil merged pull request #12071: Add session_parameters option to snowflake_hook

2020-11-11 Thread GitBox
kaxil merged pull request #12071: URL: https://github.com/apache/airflow/pull/12071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil opened a new pull request #12299: Replace remaining decorated DAGs reference

2020-11-11 Thread GitBox
kaxil opened a new pull request #12299: URL: https://github.com/apache/airflow/pull/12299 `decorated DAGs` -> `DAGs with Task Flow API` --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] kaxil opened a new issue #12298: Add docs around when to use TaskGroup vs SubDag and potentially listing PROs and CONS.

2020-11-11 Thread GitBox
kaxil opened a new issue #12298: URL: https://github.com/apache/airflow/issues/12298 It would be great for users to know when they should use TaskGroup vs SubDag. What are the PROs and CONs of each **TaskGroup**:

[GitHub] [airflow] kaxil commented on issue #8112: Authorization and Permissions

2020-11-11 Thread GitBox
kaxil commented on issue #8112: URL: https://github.com/apache/airflow/issues/8112#issuecomment-725729492 Can this be closed @jhtimmins / @mik-laj ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] AndersonReyes commented on a change in pull request #10349: infer multiple_output from return type annotation

2020-11-11 Thread GitBox
AndersonReyes commented on a change in pull request #10349: URL: https://github.com/apache/airflow/pull/10349#discussion_r521711017 ## File path: airflow/operators/python.py ## @@ -255,6 +255,16 @@ def task( :type multiple_outputs: bool """ +# try to infer from

[GitHub] [airflow] kaxil opened a new pull request #12297: Add reference for SubDagOperator

2020-11-11 Thread GitBox
kaxil opened a new pull request #12297: URL: https://github.com/apache/airflow/pull/12297 It would be better for users to have a link when they see SubDagOperator where they can read about it instead of just Class names --- **^ Add meaningful description above**

[GitHub] [airflow] kaxil opened a new pull request #12296: Remove deprecated Elasticsearch Configs

2020-11-11 Thread GitBox
kaxil opened a new pull request #12296: URL: https://github.com/apache/airflow/pull/12296 Since Airflow 1.10.4 we have removed `elasticsearch_` prefix from all config items under `[elasticsearch]` section. It is time we remove them from 2.0. --- **^ Add meaningful

[airflow] branch master updated (289c9b5 -> 4f5e0ed)

2020-11-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 289c9b5 Use default view in TriggerDagRunLink (#11778) add 4f5e0ed Update INTHEWILD.md (#12293) No new

[airflow] branch master updated (289c9b5 -> 4f5e0ed)

2020-11-11 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 289c9b5 Use default view in TriggerDagRunLink (#11778) add 4f5e0ed Update INTHEWILD.md (#12293) No new

[GitHub] [airflow] kaxil opened a new pull request #12295: Remove deprecated BashTaskRunner

2020-11-11 Thread GitBox
kaxil opened a new pull request #12295: URL: https://github.com/apache/airflow/pull/12295 This commit: - Remove support for BashTaskRunner, this task_runner was deprecated from Airflow 1.10.3

[GitHub] [airflow] github-actions[bot] commented on pull request #12293: Update INTHEWILD.md

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #12293: URL: https://github.com/apache/airflow/pull/12293#issuecomment-725721147 The PR is ready to be merged. No tests are needed! This is an automated message from the Apache

[GitHub] [airflow] potiuk merged pull request #12293: Update INTHEWILD.md

2020-11-11 Thread GitBox
potiuk merged pull request #12293: URL: https://github.com/apache/airflow/pull/12293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12293: Update INTHEWILD.md

2020-11-11 Thread GitBox
boring-cyborg[bot] commented on pull request #12293: URL: https://github.com/apache/airflow/pull/12293#issuecomment-725721210 Awesome work, congrats on your first merged pull request! This is an automated message from

[GitHub] [airflow] kukigai commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521699808 ## File path: airflow/operators/dagrun_operator.py ## @@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator): When reset_dag_run=False

[GitHub] [airflow] kukigai commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521699461 ## File path: airflow/operators/dagrun_operator.py ## @@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator): When reset_dag_run=False

[GitHub] [airflow] kukigai commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521698535 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] kaxil opened a new issue #12294: Option to auto-replace deprecated configs with new options for 2.0

2020-11-11 Thread GitBox
kaxil opened a new issue #12294: URL: https://github.com/apache/airflow/issues/12294 This issue is part of #8765 It would be good to have a rule or command in upgrade-check utility tool to replace the deprecated configs with new options. Following are the deprecated options:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12293: Update INTHEWILD.md

2020-11-11 Thread GitBox
boring-cyborg[bot] commented on pull request #12293: URL: https://github.com/apache/airflow/pull/12293#issuecomment-725714541 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our

[GitHub] [airflow] Zedmor opened a new pull request #12293: Update INTHEWILD.md

2020-11-11 Thread GitBox
Zedmor opened a new pull request #12293: URL: https://github.com/apache/airflow/pull/12293 Update in the wild with our org. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] kaxil opened a new issue #12292: Deprecate SubDags in Favor of TaskGroups

2020-11-11 Thread GitBox
kaxil opened a new issue #12292: URL: https://github.com/apache/airflow/issues/12292 Once TaskGroups (https://airflow.readthedocs.io/en/latest/concepts.html#taskgroup) that would be released in Airflow 2.0 reach feature parity with SubDags and we have wide adoption and feedback from

[GitHub] [airflow] kukigai commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521694146 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] kukigai commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521693421 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] kaxil commented on issue #8605: Add Production-ready docker compose for the production image

2020-11-11 Thread GitBox
kaxil commented on issue #8605: URL: https://github.com/apache/airflow/issues/8605#issuecomment-725712013 Also, I don't think docker-compose files need to be production-ready. It should just be meant for local-development or to quickly start / work on Airflow locally with different

[GitHub] [airflow] kaxil commented on issue #8605: Add Production-ready docker compose for the production image

2020-11-11 Thread GitBox
kaxil commented on issue #8605: URL: https://github.com/apache/airflow/issues/8605#issuecomment-725711363 I think we should get this one in sooner before 2.0.0rc1, is someone willing to work on this one?? This is an

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521684303 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521682843 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521678717 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521677189 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] vitaly-krugl opened a new issue #12291: Trigger Dag from Airflow Web GUI sets origin with wrong HTTP scheme

2020-11-11 Thread GitBox
vitaly-krugl opened a new issue #12291: URL: https://github.com/apache/airflow/issues/12291 **Apache Airflow version**: 1.10.11 **Environment**: - **OS** (e.g. from /etc/os-release): - **Kernel** (e.g. `uname -a`): Linux **What happened**: After manually

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521675792 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #10349: infer multiple_output from return type annotation

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #10349: URL: https://github.com/apache/airflow/pull/10349#discussion_r521675375 ## File path: airflow/operators/python.py ## @@ -255,6 +255,16 @@ def task( :type multiple_outputs: bool """ +# try to infer from

[GitHub] [airflow] turbaszek commented on a change in pull request #10349: infer multiple_output from return type annotation

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #10349: URL: https://github.com/apache/airflow/pull/10349#discussion_r521674847 ## File path: airflow/operators/python.py ## @@ -255,6 +255,16 @@ def task( :type multiple_outputs: bool """ +# try to infer from

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521674296 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #10349: infer multiple_output from return type annotation

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #10349: URL: https://github.com/apache/airflow/pull/10349#discussion_r521674105 ## File path: docs/tutorial_taskflow_api.rst ## @@ -144,6 +144,22 @@ the dependencies as shown below. :end-before: [END main_flow] +Multiple

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521673165 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521673165 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521670483 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521672872 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521671664 ## File path: airflow/operators/dagrun_operator.py ## @@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator): When reset_dag_run=False

[GitHub] [airflow] turbaszek commented on issue #12090: task_command.task_run log handling is either broken or redundant

2020-11-11 Thread GitBox
turbaszek commented on issue #12090: URL: https://github.com/apache/airflow/issues/12090#issuecomment-725691765 > Or were you thinking of something else? I was confused by custom code I was fixing on fork  You are right, if we have separate handlers (different streams/files)

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521670483 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[airflow] branch master updated: Use default view in TriggerDagRunLink (#11778)

2020-11-11 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 289c9b5 Use default view in

[airflow] branch master updated: Use default view in TriggerDagRunLink (#11778)

2020-11-11 Thread turbaszek
This is an automated email from the ASF dual-hosted git repository. turbaszek pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 289c9b5 Use default view in

[GitHub] [airflow] turbaszek merged pull request #11778: Use default view in dr op link

2020-11-11 Thread GitBox
turbaszek merged pull request #11778: URL: https://github.com/apache/airflow/pull/11778 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521668345 ## File path: airflow/operators/dagrun_operator.py ## @@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator): When reset_dag_run=False

[GitHub] [airflow] turbaszek commented on a change in pull request #12198: [WIP] Show DeprecationWarnings when listing DAGs

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12198: URL: https://github.com/apache/airflow/pull/12198#discussion_r521668051 ## File path: airflow/contrib/hooks/aws_athena_hook.py ## @@ -26,5 +26,4 @@ warnings.warn( "This module is deprecated. Please use

[GitHub] [airflow] XD-DENG commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
XD-DENG commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521666703 ## File path: airflow/operators/dagrun_operator.py ## @@ -55,6 +57,14 @@ class TriggerDagRunOperator(BaseOperator): When reset_dag_run=False

[GitHub] [airflow] turbaszek commented on issue #12284: BigQueryGetDataOperator doesn't return data correctly

2020-11-11 Thread GitBox
turbaszek commented on issue #12284: URL: https://github.com/apache/airflow/issues/12284#issuecomment-725685572 Awesome! Thank you @nathadfield ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] nathadfield commented on issue #12284: BigQueryGetDataOperator doesn't return data correctly

2020-11-11 Thread GitBox
nathadfield commented on issue #12284: URL: https://github.com/apache/airflow/issues/12284#issuecomment-725685081 @turbaszek Yep. I'll be submitting tomorrow. This is an automated message from the Apache Git Service. To

[GitHub] [airflow] turbaszek commented on issue #12284: BigQueryGetDataOperator doesn't return data correctly

2020-11-11 Thread GitBox
turbaszek commented on issue #12284: URL: https://github.com/apache/airflow/issues/12284#issuecomment-725684703 @nathadfield would you like to submit a fix?  This is an automated message from the Apache Git Service. To

[GitHub] [airflow] turbaszek commented on pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on pull request #12126: URL: https://github.com/apache/airflow/pull/12126#issuecomment-725683832 @kaxil @XD-DENG would you like to take a look? This is an automated message from the Apache Git Service. To

[GitHub] [airflow] github-actions[bot] commented on pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
github-actions[bot] commented on pull request #12126: URL: https://github.com/apache/airflow/pull/12126#issuecomment-725683769 The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521662517 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521662136 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] turbaszek commented on a change in pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
turbaszek commented on a change in pull request #12126: URL: https://github.com/apache/airflow/pull/12126#discussion_r521661723 ## File path: airflow/operators/dagrun_operator.py ## @@ -126,3 +144,22 @@ def execute(self, context: Dict):

[GitHub] [airflow] wentaowanguc opened a new issue #12290: Got a sqlite3.OperationalError while runing airflow scheduler

2020-11-11 Thread GitBox
wentaowanguc opened a new issue #12290: URL: https://github.com/apache/airflow/issues/12290 Hi Team: We got an error when we running airflow scheduler `2020-11-11_20:09:26.59088 Process DagFileProcessor34125-Process: 2020-11-11_20:09:26.59091 Traceback (most recent call last):

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12290: Got a sqlite3.OperationalError while runing airflow scheduler

2020-11-11 Thread GitBox
boring-cyborg[bot] commented on issue #12290: URL: https://github.com/apache/airflow/issues/12290#issuecomment-725681803 Thanks for opening your first issue here! Be sure to follow the issue template! This is an

[GitHub] [airflow] aaltay commented on a change in pull request #11726: Add DataflowJobStatusSensor and support non-blocking execution of jobs

2020-11-11 Thread GitBox
aaltay commented on a change in pull request #11726: URL: https://github.com/apache/airflow/pull/11726#discussion_r521613015 ## File path: airflow/providers/google/cloud/hooks/dataflow.py ## @@ -278,18 +296,20 @@ def _check_dataflow_job_state(self, job) -> bool:

[GitHub] [airflow] kukigai commented on pull request #12126: Wait option for dagrun operator

2020-11-11 Thread GitBox
kukigai commented on pull request #12126: URL: https://github.com/apache/airflow/pull/12126#issuecomment-725639995 @mik-laj if @turbaszek is busy, please review. This is an automated message from the Apache

[GitHub] [airflow] potiuk commented on issue #12281: Add list of providers available in the docs

2020-11-11 Thread GitBox
potiuk commented on issue #12281: URL: https://github.com/apache/airflow/issues/12281#issuecomment-725623882 Feel free! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] mik-laj commented on issue #12281: Add list of providers available in the docs

2020-11-11 Thread GitBox
mik-laj commented on issue #12281: URL: https://github.com/apache/airflow/issues/12281#issuecomment-725623346 Are you working on it? I will be happy to do it, because I will also need it to build the final documentation.

[GitHub] [airflow] tomasfarias commented on a change in pull request #11964: Add new datetime branch operator

2020-11-11 Thread GitBox
tomasfarias commented on a change in pull request #11964: URL: https://github.com/apache/airflow/pull/11964#discussion_r521589482 ## File path: airflow/operators/datetime_branch_operator.py ## @@ -0,0 +1,80 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] mik-laj commented on issue #12281: Add list of providers available in the docs

2020-11-11 Thread GitBox
mik-laj commented on issue #12281: URL: https://github.com/apache/airflow/issues/12281#issuecomment-725614206 SGTM This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk edited a comment on issue #11965: Airflow fails to initdb with cattrs 1.1.0

2020-11-11 Thread GitBox
potiuk edited a comment on issue #11965: URL: https://github.com/apache/airflow/issues/11965#issuecomment-725613679 > Didn't work for me :( What do you mean by 'didn't work"? Can you please provide some specifics on what you tried and how it did not work @gaj995 ?

[GitHub] [airflow] potiuk commented on issue #11965: Airflow fails to initdb with cattrs 1.1.0

2020-11-11 Thread GitBox
potiuk commented on issue #11965: URL: https://github.com/apache/airflow/issues/11965#issuecomment-725613679 > Didn't work for me :( What do you mean by 'didn't work"? Can you please provide some specifics on what you tried and how it did not work?

[GitHub] [airflow] potiuk commented on issue #12281: Add list of providers available in the docs

2020-11-11 Thread GitBox
potiuk commented on issue #12281: URL: https://github.com/apache/airflow/issues/12281#issuecomment-725612544 > I think it shouldn't be in the documentation, but on our website. This way we will be able to update it independently of the rest of the documentation. For example: we will be

  1   2   3   >