michalslowikowski00 commented on pull request #11850:
URL: https://github.com/apache/airflow/pull/11850#issuecomment-733540924
@rootcss kudos for the tests. 💪
This is an automated message from the Apache Git Service.
To resp
potiuk commented on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733542467
> Isn't the constraints-push CI job exactly do that, constraints are eagerly
updated and only if they pass the tests are the constraints pushed to
constraints-master?
No
rtjarvis edited a comment on issue #7960:
URL: https://github.com/apache/airflow/issues/7960#issuecomment-719394033
I need this too - max_active_runs doesn't work. Any progress?
This is an automated message from the Apach
potiuk edited a comment on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733542467
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733550559
Looking now. at the best way to fix the MySQL 8 problem
This is an automated message from the Apache Git Servi
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch airflow-2-0-docs
in repository https://gitbox.apache.org/repos/asf/airflow-site.git.
at b451270 Update _index.md (#312)
No new revisions were added by this update.
github-actions[bot] commented on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733558321
[The Workflow run](https://github.com/apache/airflow/actions/runs/382814601)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
checks,^Build
mik-laj opened a new issue #314:
URL: https://github.com/apache/airflow-site/issues/314
Hello,
We have to prepare a website for Airflow 2.0, so I created a new branch -
[`airflow-2-0-docs`](https://github.com/apache/airflow-site/tree/airflow-2-0-docs)
My focus is on documentat
TobKed commented on a change in pull request #12249:
URL: https://github.com/apache/airflow/pull/12249#discussion_r530204779
##
File path: airflow/providers/google/cloud/sensors/dataflow.py
##
@@ -187,4 +192,196 @@ def poke(self, context: dict) -> bool:
location=se
dinigo opened a new issue #12611:
URL: https://github.com/apache/airflow/issues/12611
**Description**
Replace the "email" API with a "notification" API that would let us
integrate better with our workflow without adding extra code to the DAGs.
1. Change "[email]" to "[notifica
turbaszek commented on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733574911
> if they pass the tests
Passing test is not the same as passing `pip check`. Tests works but we have
"broken" dependencies. Once we have this we will be able to run `
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733575256
@kaxil @ashb -> the simplest way of fixing the migration is indeed simply
changing the field to Text. I am adding a fix for that and fixing two failing
errors on mysql8 I see.
turbaszek commented on issue #12611:
URL: https://github.com/apache/airflow/issues/12611#issuecomment-733579010
I think this is a good suggestion. Apart from that:
- instead of custom code in every DAG you can use cluster policy
- in case of slack - you can send emails to channels (sla
turbaszek edited a comment on issue #12611:
URL: https://github.com/apache/airflow/issues/12611#issuecomment-733579010
I think this is a good suggestion. Apart from that:
- instead of custom code in every DAG you can use cluster policy
- in case of slack/pagerduty - you can send emails
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733579519
This change should address the migration @ashb and @kaxil - I made it in
the way that the previous migration actually creates a Text field not string in
case of mysql and the
turbaszek commented on a change in pull request #12605:
URL: https://github.com/apache/airflow/pull/12605#discussion_r530221863
##
File path: UPDATING.md
##
@@ -52,6 +52,14 @@ assists users migrating to a new version.
## Master
+### `[scheduler] max_threads` config has bee
github-actions[bot] commented on pull request #12608:
URL: https://github.com/apache/airflow/pull/12608#issuecomment-733582712
The PR needs to run all tests because it modifies core of Airflow! Please
rebase it to latest master or ask committer to re-run it!
--
kaxil merged pull request #12605:
URL: https://github.com/apache/airflow/pull/12605
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kaxil commented on a change in pull request #12605:
URL: https://github.com/apache/airflow/pull/12605#discussion_r530228444
##
File path: UPDATING.md
##
@@ -52,6 +52,14 @@ assists users migrating to a new version.
## Master
+### `[scheduler] max_threads` config has been re
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from c457c97 Use AIRFLOW_CONSTRAINTS_LOCATION when passed during docker
build (#12604)
add 4861344 Rename `[sc
kaxil commented on pull request #12603:
URL: https://github.com/apache/airflow/pull/12603#issuecomment-733588796
Sqlite test is failing in an unrelated test
This is an automated message from the Apache Git Service.
To respond
kaxil closed pull request #12606:
URL: https://github.com/apache/airflow/pull/12606
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kaxil merged pull request #12607:
URL: https://github.com/apache/airflow/pull/12607
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk commented on issue #12588:
URL: https://github.com/apache/airflow/issues/12588#issuecomment-733590357
Working on a fix in #12596
This is an automated message from the Apache Git Service.
To respond to the message, plea
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 4861344 Rename `[scheduler] max_threads` to `[scheduler]
parsing_processes` (#12605)
add 950d80b Revert "
mik-laj commented on issue #12611:
URL: https://github.com/apache/airflow/issues/12611#issuecomment-733594397
I would be most interested in integrating with PubSub. This would allow data
synchronization with Airflow in the Push model, and not only fetch it via API
(Pull model)
I saw
mik-laj merged pull request #313:
URL: https://github.com/apache/airflow-site/pull/313
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
JavierLopezT opened a new issue #12612:
URL: https://github.com/apache/airflow/issues/12612
Let's say that you have a DAG with 8 retries and email_on_failure=True.
The first 6 times it fails due to a server conn error, and on the 7th it
works. I really don't care why it failed the f
mik-laj opened a new issue #12613:
URL: https://github.com/apache/airflow/issues/12613
Hello friends.
Today I am coming to you with another ticket. This time, while working on
the website, I discovered that we have some information that is slightly
outdated.
[`landing-pages/
saikatharryc commented on issue #12331:
URL: https://github.com/apache/airflow/issues/12331#issuecomment-733604194
I believe you are not running with the side car? which is the vault agent
injector?
> Hi Thank you for the reply.
> I tried it but always get `'/vault/secrets': N
ashb commented on issue #12555:
URL: https://github.com/apache/airflow/issues/12555#issuecomment-733606331
S3 has an https url:
https://apache-airflow-docs.s3-eu-central-1.amazonaws.com/index.html (The
"problem" with it is that it doesn't redirect from
https://apache-airflow-docs.s3-eu-c
mik-laj commented on issue #12555:
URL: https://github.com/apache/airflow/issues/12555#issuecomment-733608579
Yes. website don't support SSL:
https://docs.aws.amazon.com/AmazonS3/latest/dev/WebsiteEndpoints.html#WebsiteRestEndpointDiff
> Amazon S3 does not support HTTPS access to the
ashb commented on issue #12555:
URL: https://github.com/apache/airflow/issues/12555#issuecomment-733609112
Yes, but it's only a problem for people who try to hit `/` -- all links
actually work fine
This is an automated messa
ashb commented on issue #12555:
URL: https://github.com/apache/airflow/issues/12555#issuecomment-733609377
I'd like to avoid CloudFront - I've always found it massively slow to update
when pushing new changes.
This is an aut
turbaszek commented on issue #12612:
URL: https://github.com/apache/airflow/issues/12612#issuecomment-733610623
Won't that be handled by `on_failure_callback`?
This is an automated message from the Apache Git Service.
To res
ashb commented on pull request #12603:
URL: https://github.com/apache/airflow/pull/12603#issuecomment-733610882
Have we worked out _why_ this actually makes a difference yet?
This is an automated message from the Apache Git S
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733613110
I believe this have a chance of passing @ashb and @kaxil . Happy if you take
a look.
This is an automated mess
ashb commented on a change in pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#discussion_r530268958
##
File path: tests/operators/test_generic_transfer.py
##
@@ -55,12 +55,12 @@ def tearDown(self):
)
def test_mysql_to_mysql(self, client):
eshaingle commented on issue #12331:
URL: https://github.com/apache/airflow/issues/12331#issuecomment-733623987
> I believe you are not running with the side car? which is the vault agent
injector?
>
> > Hi Thank you for the reply.
> > I tried it but always get `'/vault/secrets':
ashb commented on a change in pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#discussion_r530276554
##
File path: scripts/ci/libraries/_initialization.sh
##
@@ -102,10 +102,10 @@ function initialization::initialize_base_variables() {
export CURRENT_M
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch v1-10-test
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/v1-10-test by this push:
new 876790b Actually run against the versi
github-actions[bot] commented on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733627843
[The Workflow run](https://github.com/apache/airflow/actions/runs/383011719)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
checks,^Build
ashb commented on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733627892
@matthieu-foucault Yes please, a PR would be ace!
This is an automated message from the Apache Git Service.
To respond
potiuk commented on a change in pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#discussion_r530277648
##
File path: scripts/ci/libraries/_initialization.sh
##
@@ -102,10 +102,10 @@ function initialization::initialize_base_variables() {
export CURRENT
ashb commented on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733628966
Please also (somewhere) document what Airflow requires of the image being
run.
Because there are at least three "common" images that people might run
(airflow, puckel, astrono
ashb edited a comment on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733628966
Please also (somewhere) document what Airflow requires of the image being
run.
Because there are at least three "common" images that people might run
(airflow, puckel,
ashb edited a comment on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733628966
Please also (somewhere) document what Airflow requires of the image being
run.
Because there are at least three "common" images that people might run
(airflow, puckel,
ashb edited a comment on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733628966
Please also (somewhere) document what Airflow requires of the image being
run.
Because there are at least three "common" images that people might run
(airflow, puckel,
ashb edited a comment on issue #12602:
URL: https://github.com/apache/airflow/issues/12602#issuecomment-733628966
Please also (somewhere) document what Airflow requires of the image being
run.
Because there are at least four "common" images that people might run
(airflow's own, puck
ashb commented on a change in pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#discussion_r530284550
##
File path: scripts/ci/libraries/_initialization.sh
##
@@ -102,10 +102,10 @@ function initialization::initialize_base_variables() {
export CURRENT_M
JavierLopezT commented on issue #12612:
URL: https://github.com/apache/airflow/issues/12612#issuecomment-733637414
> Won't that be handled by `on_failure_callback`?
Since you say so, I guess it will be possible, but after a quick research on
Google I can't figure it out. My idea is h
potiuk commented on a change in pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#discussion_r530287460
##
File path: tests/operators/test_generic_transfer.py
##
@@ -55,12 +55,12 @@ def tearDown(self):
)
def test_mysql_to_mysql(self, client):
JavierLopezT edited a comment on issue #12612:
URL: https://github.com/apache/airflow/issues/12612#issuecomment-733637414
> Won't that be handled by `on_failure_callback`?
Since you say so, I guess it will be possible, but after a quick research on
Google I can't figure it out. My id
potiuk commented on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733643729
OK @turbaszek -> this PR has now all the constraints updated and pip check
should not fail, however we have some failures resulting from the azure storage
Blob missing. I think
saikatharryc commented on issue #12331:
URL: https://github.com/apache/airflow/issues/12331#issuecomment-733649588
@eshaingle
okay, now I know you are using k8s and vault injector & airflow in k8s.
__
I have tried this generic way, where I have installed vault agent injecto
ashb commented on a change in pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#discussion_r530304715
##
File path: tests/operators/test_generic_transfer.py
##
@@ -55,12 +55,12 @@ def tearDown(self):
)
def test_mysql_to_mysql(self, client):
ashb commented on a change in pull request #12605:
URL: https://github.com/apache/airflow/pull/12605#discussion_r530305557
##
File path: UPDATING.md
##
@@ -52,6 +52,14 @@ assists users migrating to a new version.
## Master
+### `[scheduler] max_threads` config has been ren
turbaszek commented on issue #12612:
URL: https://github.com/apache/airflow/issues/12612#issuecomment-733656454
> you would have to have the callback function on every dag that you want to
use it, right? So it will be a lot of duplicated cod
Use cluster policy. As per the emails, I w
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733665874
OK @ashb -> everything works for MySQL8 now.
This is an automated message from the Apache Git Service.
To resp
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733666041
I will slit out the the change and we can merge one after the other
This is an automated message from the A
eladkal commented on issue #12611:
URL: https://github.com/apache/airflow/issues/12611#issuecomment-73379
It has some similarities with https://github.com/apache/airflow/issues/8686
This is an automated message from the A
potiuk commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733668746
Split out now.
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on pull request #12601:
URL: https://github.com/apache/airflow/pull/12601#issuecomment-733668806
[The Workflow run](https://github.com/apache/airflow/actions/runs/383142165)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
checks,^Build
potiuk edited a comment on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733666041
I will split out the the change and we can merge one after the other
This is an automated message fr
github-actions[bot] commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733671339
The PR needs to run all tests because it modifies core of Airflow! Please
rebase it to latest master or ask committer to re-run it!
--
potiuk opened a new pull request #12614:
URL: https://github.com/apache/airflow/pull/12614
Client encding behaviour works differently in MySQL 5.7 and 8.
This is described in detail in
https://dev.mysql.com/doc/refman/8.0/en/charset-connection.html
But it seems that when
marclamberti commented on issue #12587:
URL: https://github.com/apache/airflow/issues/12587#issuecomment-733677192
@ashb Here it is:
```
*** Reading local file:
/usr/local/airflow/logs/master_dag/trigger_dag/2020-11-24T00:00:00+00:00/2.log
[2020-11-25 12:27:03,944] {taskinstanc
ashb commented on pull request #12594:
URL: https://github.com/apache/airflow/pull/12594#issuecomment-733679366
This was unrelated, right?
This is an automated message from the Apache Git Service.
To respond to the message, p
marclamberti commented on issue #12587:
URL: https://github.com/apache/airflow/issues/12587#issuecomment-733682227
If you want to reproduce the issue:
https://gist.github.com/marclamberti/92cb097d71d03988895861574365abeb
1. 1. Schedule triggered_dag
2. 2. Schedule master_dag
potiuk commented on pull request #12591:
URL: https://github.com/apache/airflow/pull/12591#issuecomment-733687725
I did a thorough check - and I run a few tests and It is actually a bit
better than that. The "fallback" behavior is still there.
Bututf8mb4 should continue to work as long
potiuk opened a new pull request #12615:
URL: https://github.com/apache/airflow/pull/12615
In MySQL8 you cannot create table LIKE an INFORMATION_SCHEMA
table because they are not "real" tables and generic_transfer
tests failed on MySQL8 because of that.
This PR changes the test
potiuk commented on pull request #12615:
URL: https://github.com/apache/airflow/pull/12615#issuecomment-733691547
Hey @ashb this will have to be merged before #12591 gets merged.
This is an automated message from the Apache G
github-actions[bot] commented on pull request #12353:
URL: https://github.com/apache/airflow/pull/12353#issuecomment-733691429
[The Workflow run](https://github.com/apache/airflow/actions/runs/383221944)
is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static
checks,^Build
ephraimbuddy opened a new issue #12616:
URL: https://github.com/apache/airflow/issues/12616
Triggering a dagrun with an invalid execution date causes a ParserError in
the REST API
**Apache Airflow version**: 2.0
**What happened**:
When you trigger a dagrun with an invalid e
Dr-Denzy opened a new pull request #12617:
URL: https://github.com/apache/airflow/pull/12617
Moved the main content of Contributors' guide to CONTRIBUTING.rst file.
This is to eliminate duplication and unify Airflow's contributions
guidelines in CONTRIBUTING.rst file. The aim is to
ashb commented on pull request #12596:
URL: https://github.com/apache/airflow/pull/12596#issuecomment-733699564
Good to merge now right?
This is an automated message from the Apache Git Service.
To respond to the message, ple
ashb commented on pull request #12591:
URL: https://github.com/apache/airflow/pull/12591#issuecomment-733701403
@potiuk Order to merge PRs is #12596, #12614 then #12615 right?
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #12615:
URL: https://github.com/apache/airflow/pull/12615#issuecomment-733702692
The PR needs to run all tests because it modifies core of Airflow! Please
rebase it to latest master or ask committer to re-run it!
--
github-actions[bot] commented on pull request #12614:
URL: https://github.com/apache/airflow/pull/12614#issuecomment-733703445
The PR needs to run all tests because it modifies core of Airflow! Please
rebase it to latest master or ask committer to re-run it!
--
kaxil commented on pull request #12594:
URL: https://github.com/apache/airflow/pull/12594#issuecomment-733707270
> This was unrelated, right?
Yup
This is an automated message from the Apache Git Service.
To respond to
potiuk merged pull request #12596:
URL: https://github.com/apache/airflow/pull/12596
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
potiuk closed issue #12588:
URL: https://github.com/apache/airflow/issues/12588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 950d80b Revert "Hide ToC from the Apache Airflow doc main page
(#12589)" (#12607)
add cdaaff1 Fix Connection
kaxil commented on pull request #12603:
URL: https://github.com/apache/airflow/pull/12603#issuecomment-733710524
> Have we worked out _why_ this actually makes a difference yet?
No -- at least not with 100% confidence but passing values to foreign_key
enforces foreign key constraint
potiuk commented on pull request #12614:
URL: https://github.com/apache/airflow/pull/12614#issuecomment-733711257
Initialization and most tests work. Merging.
This is an automated message from the Apache Git Service.
To respo
potiuk merged pull request #12614:
URL: https://github.com/apache/airflow/pull/12614
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from cdaaff1 Fix Connection.description migration for MySQL8 (#12596)
add 6d6ca14 Fixes inconsistent behaviour of
Author: kaxilnaik
Date: Wed Nov 25 13:41:50 2020
New Revision: 44681
Log:
Release Airflow 1.10.13 from 1.10.13rc1
Added:
release/airflow/1.10.13/
release/airflow/1.10.13/apache-airflow-1.10.13-bin.tar.gz
- copied unchanged from r44607,
dev/airflow/1.10.13rc1/apache-airflow-1.10.13r
Author: kaxilnaik
Date: Wed Nov 25 13:42:26 2020
New Revision: 44682
Log:
Remove old release: 1.10.12
Removed:
release/airflow/1.10.12/
potiuk commented on pull request #12591:
URL: https://github.com/apache/airflow/pull/12591#issuecomment-733714089
> @potiuk Order to merge PRs is #12596, #12614 then #12615 right?
Correct.
This is an automated message
potiuk edited a comment on pull request #12591:
URL: https://github.com/apache/airflow/pull/12591#issuecomment-733687725
I did a thorough check - and I run a few tests and It is actually a bit
better than that. The "fallback" behavior is still there.
But utf8mb4 should continue to work
ephraimbuddy opened a new pull request #12618:
URL: https://github.com/apache/airflow/pull/12618
Closes: #12616
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guide
potiuk commented on pull request #12615:
URL: https://github.com/apache/airflow/pull/12615#issuecomment-733726192
Alll mysql tests passed. Merging
This is an automated message from the Apache Git Service.
To respond to the me
potiuk merged pull request #12615:
URL: https://github.com/apache/airflow/pull/12615
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to tag 1.10.13
in repository https://gitbox.apache.org/repos/asf/airflow.git.
at 5b61c21 (commit)
No new revisions were added by this update.
potiuk commented on pull request #12591:
URL: https://github.com/apache/airflow/pull/12591#issuecomment-733726748
@ashb -> you can rebase this one now.
This is an automated message from the Apache Git Service.
To respond to t
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 6d6ca14 Fixes inconsistent behaviour of utf8mb4 encoding on Mysql
5.7/8 (#12614)
add 333c871 Fixes tests tha
RosterIn commented on pull request #11220:
URL: https://github.com/apache/airflow/pull/11220#issuecomment-733735834
You have some styling error but other than that looks OK
This is an automated message from the Apache Git Ser
RosterIn commented on a change in pull request #12617:
URL: https://github.com/apache/airflow/pull/12617#discussion_r530409277
##
File path: CONTRIBUTING.rst
##
@@ -20,9 +20,59 @@
Contributions
=
-Contributions are welcome and are greatly appreciated! Every litt
Dr-Denzy commented on a change in pull request #12617:
URL: https://github.com/apache/airflow/pull/12617#discussion_r530410718
##
File path: CONTRIBUTING.rst
##
@@ -20,9 +20,59 @@
Contributions
=
-Contributions are welcome and are greatly appreciated! Every litt
1 - 100 of 234 matches
Mail list logo
