[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739137357 Thanks @mik-laj That helped. This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [airflow] mik-laj commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
mik-laj commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739136360 /docs/apache-airlfow-providers-telegram/operators.rst Similar to Databricks https://github.com/apache/airflow/blob/master/docs/apache-airflow-providers-databricks/operators.

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739135668 @mik-laj Where do we place this file? It is `howto` for the telegram operator. https://github.com/apache/airflow/blob/1e7568de54a56d43ec3d47d248932fbd11ffd10b/docs/howto/op

[GitHub] [airflow] mik-laj commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
mik-laj commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739134797 /docs/apache-airlfow-providers/operators.rst Index is generated automatically based on provider.yaml http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com

[GitHub] [airflow] rootcss commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
rootcss commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739134322 @mik-laj what's the new location for howto docs for providers? This is an automated message from the Apache Gi

[airflow] branch master updated: Configuration.getsection copes with sections that only exist in user config (#12816)

2020-12-04 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 252b047 Configuration.getsection copes with se

[GitHub] [airflow] XD-DENG merged pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
XD-DENG merged pull request #12816: URL: https://github.com/apache/airflow/pull/12816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[airflow] branch master updated: Cleanup & improvements around scheduling (#12815)

2020-12-04 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new fbb8a4a Cleanup & improvements around scheduli

[GitHub] [airflow] XD-DENG merged pull request #12815: Cleanup & improvements around scheduling

2020-12-04 Thread GitBox
XD-DENG merged pull request #12815: URL: https://github.com/apache/airflow/pull/12815 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[airflow] branch master updated: Updating documentation to specify sensitive config options (#12820)

2020-12-04 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new c85f494 Updating documentation to specif

[GitHub] [airflow] mik-laj merged pull request #12820: Updating documentation to specify sensitive config options

2020-12-04 Thread GitBox
mik-laj merged pull request #12820: URL: https://github.com/apache/airflow/pull/12820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] mik-laj commented on issue #12827: Missing docs about webserver_config.py

2020-12-04 Thread GitBox
mik-laj commented on issue #12827: URL: https://github.com/apache/airflow/issues/12827#issuecomment-739130952 @zh0uquan Can you help with it? This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [airflow] mik-laj opened a new issue #12827: Missing docs about webserver_config.py

2020-12-04 Thread GitBox
mik-laj opened a new issue #12827: URL: https://github.com/apache/airflow/issues/12827 Hello, We are missing documentation on the `webserver_config.py` file. I think it is worth answering the following questions in this guide: * What is this file? * What is this file for? *

[GitHub] [airflow] mik-laj opened a new pull request #12826: Move task handlers guides to provider docs

2020-12-04 Thread GitBox
mik-laj opened a new pull request #12826: URL: https://github.com/apache/airflow/pull/12826 Part of: https://github.com/apache/airflow/issues/11423 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/mas

[airflow] branch master updated: Dagrun object doesn't exist in the TriggerDagRunOperator (#12819)

2020-12-04 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new e82cf0d Dagrun object doesn't exist in the

[GitHub] [airflow] dimberman merged pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
dimberman merged pull request #12819: URL: https://github.com/apache/airflow/pull/12819 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] dimberman closed issue #12587: dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
dimberman closed issue #12587: URL: https://github.com/apache/airflow/issues/12587 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] htgeis opened a new pull request #12825: Enable to expand the key file path in ssh hooks

2020-12-04 Thread GitBox
htgeis opened a new pull request #12825: URL: https://github.com/apache/airflow/pull/12825 Sometimes, the key_file path users defined in the ssh connection is not a absolute path but a path combined with shell variable e.g. `${AIRFLOW_HOME}/**/**.rsa` or `${SECRET_FOLDER}/**/**.rsa.`

[GitHub] [airflow] htgeis commented on issue #12777: It won't take effect when updating the start_date in the default_args

2020-12-04 Thread GitBox
htgeis commented on issue #12777: URL: https://github.com/apache/airflow/issues/12777#issuecomment-739113114 > > the next dag it would schedule is "2020/05/02" instead of "2020/10/01", which means it would not take effect. > > Am I right in thinking that it would schedule those dags,

[GitHub] [airflow] htgeis removed a comment on issue #12777: It won't take effect when updating the start_date in the default_args

2020-12-04 Thread GitBox
htgeis removed a comment on issue #12777: URL: https://github.com/apache/airflow/issues/12777#issuecomment-739113065 yeah, but it doesn't make much sense to create these dag runs with no tasks runnable. We have many users defined the start_date in the default_args and they have some requir

[GitHub] [airflow] htgeis commented on issue #12777: It won't take effect when updating the start_date in the default_args

2020-12-04 Thread GitBox
htgeis commented on issue #12777: URL: https://github.com/apache/airflow/issues/12777#issuecomment-739113065 yeah, but it doesn't make much sense to create these dag runs with no tasks runnable. We have many users defined the start_date in the default_args and they have some requirements t

[airflow] tag nightly-master updated (dee304b -> c1cd504)

2020-12-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from dee304b (commit) to c1cd504 (commit) from de

[airflow] branch master updated: Add 'headers' to template_fields in HttpSensor (#12809)

2020-12-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new c1cd504 Add 'headers' to template_fields in

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12809: Add 'headers' to template_fields in HttpSensor

2020-12-04 Thread GitBox
boring-cyborg[bot] commented on pull request #12809: URL: https://github.com/apache/airflow/pull/12809#issuecomment-739096196 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] kaxil closed issue #12796: Make headers templated in HttpSensor

2020-12-04 Thread GitBox
kaxil closed issue #12796: URL: https://github.com/apache/airflow/issues/12796 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] kaxil merged pull request #12809: Add 'headers' to template_fields in HttpSensor

2020-12-04 Thread GitBox
kaxil merged pull request #12809: URL: https://github.com/apache/airflow/pull/12809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] kaxil edited a comment on issue #10427: DAGs remain in the UI after they are deleted

2020-12-04 Thread GitBox
kaxil edited a comment on issue #10427: URL: https://github.com/apache/airflow/issues/10427#issuecomment-739093126 I am not able to reproduce this on Airflow 2.0.0beta3 (maybe the issue was fixed in newer 1.10.x versions or 2.0betas), once I deleted the DAG file the DAG disappeared from th

[GitHub] [airflow] kaxil closed issue #10427: DAGs remain in the UI after they are deleted

2020-12-04 Thread GitBox
kaxil closed issue #10427: URL: https://github.com/apache/airflow/issues/10427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] kaxil commented on issue #10427: DAGs remain in the UI after they are deleted

2020-12-04 Thread GitBox
kaxil commented on issue #10427: URL: https://github.com/apache/airflow/issues/10427#issuecomment-739093126 I am not able to reproduce this on Airflow 2.0.0beta3, once I deleted the DAG file the DAG disappeared from the UI in sometime. @marcjimz Can you please try with out with 2.0.0

[GitHub] [airflow] kaxil edited a comment on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil edited a comment on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739089385 @yuqian90 / @houqp If you have some time can you help looking into this issue, it looks like it has something to do with the TaskGroup change in graph.html after some debuggi

[GitHub] [airflow] kaxil edited a comment on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil edited a comment on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739089385 @yuqian90 / @houqp If you have some time can you help looking into this issue, it looks like it has something to do with the TaskGroup change in graph.html after some debuggi

[GitHub] [airflow] kaxil commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739089385 @yuqian90 / @houqp If you have some time can you help looking into this issue, it looks like it has something to do with the TaskGroup change in graph.html after some debugging.

[GitHub] [airflow] dimberman commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
dimberman commented on a change in pull request #12819: URL: https://github.com/apache/airflow/pull/12819#discussion_r536442389 ## File path: airflow/operators/dagrun_operator.py ## @@ -144,6 +144,9 @@ def execute(self, context: Dict): dag = dag_bag.get_dag(sel

[GitHub] [airflow] kaxil removed a comment on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil removed a comment on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739071256 I am not able to reproduce this with the DAG you had provided: ![image](https://user-images.githubusercontent.com/8811558/101224401-6270a880-3686-11eb-9e5c-23e5465f2a65

[GitHub] [airflow] turbaszek commented on a change in pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r536440661 ## File path: airflow/providers/apache/beam/operators/beam.py ## @@ -0,0 +1,407 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] turbaszek commented on a change in pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r536440661 ## File path: airflow/providers/apache/beam/operators/beam.py ## @@ -0,0 +1,407 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] kaxil edited a comment on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil edited a comment on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739071256 I am not able to reproduce this with the DAG you had provided: ![image](https://user-images.githubusercontent.com/8811558/101224401-6270a880-3686-11eb-9e5c-23e5465f2a65.

[GitHub] [airflow] kaxil commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739071256 I am not able to reproduce this: ![image](https://user-images.githubusercontent.com/8811558/101224401-6270a880-3686-11eb-9e5c-23e5465f2a65.png) --

[GitHub] [airflow] turbaszek commented on a change in pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r536438411 ## File path: airflow/providers/apache/beam/provider.yaml ## @@ -0,0 +1,40 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] kaxil removed a comment on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil removed a comment on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739068523 I am unable to replicate this: ![image](https://user-images.githubusercontent.com/8811558/101223895-08bbae80-3685-11eb-8aea-2653e713497c.png)

[GitHub] [airflow] turbaszek commented on a change in pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r536431621 ## File path: airflow/providers/apache/beam/hooks/beam.py ## @@ -0,0 +1,234 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] turbaszek commented on a change in pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r536431621 ## File path: airflow/providers/apache/beam/hooks/beam.py ## @@ -0,0 +1,234 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] kaxil commented on issue #12757: Graph View is empty when Operator has multiline string in args (v2.0)

2020-12-04 Thread GitBox
kaxil commented on issue #12757: URL: https://github.com/apache/airflow/issues/12757#issuecomment-739068523 I am unable to replicate this: ![image](https://user-images.githubusercontent.com/8811558/101223895-08bbae80-3685-11eb-8aea-2653e713497c.png)

[GitHub] [airflow] turbaszek commented on a change in pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12814: URL: https://github.com/apache/airflow/pull/12814#discussion_r536431621 ## File path: airflow/providers/apache/beam/hooks/beam.py ## @@ -0,0 +1,234 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12819: URL: https://github.com/apache/airflow/pull/12819#discussion_r536429794 ## File path: airflow/operators/dagrun_operator.py ## @@ -144,6 +144,8 @@ def execute(self, context: Dict): dag = dag_bag.get_dag(sel

[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12819: URL: https://github.com/apache/airflow/pull/12819#discussion_r536429718 ## File path: airflow/operators/dagrun_operator.py ## @@ -144,6 +144,8 @@ def execute(self, context: Dict): dag = dag_bag.get_dag(sel

[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12819: URL: https://github.com/apache/airflow/pull/12819#discussion_r536429605 ## File path: airflow/operators/dagrun_operator.py ## @@ -144,6 +144,9 @@ def execute(self, context: Dict): dag = dag_bag.get_dag(sel

[GitHub] [airflow] boring-cyborg[bot] commented on issue #12824: Pip install breaks on S3 due to package mismatch error

2020-12-04 Thread GitBox
boring-cyborg[bot] commented on issue #12824: URL: https://github.com/apache/airflow/issues/12824#issuecomment-739060084 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] spence95 opened a new issue #12824: Pip install breaks on S3 due to package mismatch error

2020-12-04 Thread GitBox
spence95 opened a new issue #12824: URL: https://github.com/apache/airflow/issues/12824 Since the beginning of this week, everytime I try to pip install airflow with the following command: `pip install git+https://github.com/apache/incubator-airflow.git@${AIRFLOW_VERSION}#egg=apache-air

[GitHub] [airflow] github-actions[bot] commented on pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12819: URL: https://github.com/apache/airflow/pull/12819#issuecomment-739048769 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] github-actions[bot] commented on pull request #12821: Remove old option - git_password from sensitive_config_values

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12821: URL: https://github.com/apache/airflow/pull/12821#issuecomment-739045055 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] github-actions[bot] commented on pull request #12820: Updating documentation to specify sensitive config options

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12820: URL: https://github.com/apache/airflow/pull/12820#issuecomment-739044254 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] ashb commented on pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
ashb commented on pull request #12816: URL: https://github.com/apache/airflow/pull/12816#issuecomment-739034498 It's there on desktop when you go through to check details too ![image](https://user-images.githubusercontent.com/34150/101217233-e91e8900-3678-11eb-92cf-e045188252c2.png)

[GitHub] [airflow] github-actions[bot] commented on pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12816: URL: https://github.com/apache/airflow/pull/12816#issuecomment-739033951 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] vxtals opened a new issue #12823: DAG callback handling not working properly on simultaneous executions

2020-12-04 Thread GitBox
vxtals opened a new issue #12823: URL: https://github.com/apache/airflow/issues/12823 **Apache Airflow version**: apache-airflow 2.0.0b3 **Environment**: Any environment **What happened**: I have dags triggered at same time for several other

[GitHub] [airflow] github-actions[bot] commented on pull request #12693: Installing packages in our CI uses constraints

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12693: URL: https://github.com/apache/airflow/pull/12693#issuecomment-739032725 [The Workflow run](https://github.com/apache/airflow/actions/runs/401366864) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] SamWheating closed pull request #10757: Tail out all logs when retrieving from pod

2020-12-04 Thread GitBox
SamWheating closed pull request #10757: URL: https://github.com/apache/airflow/pull/10757 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] SamWheating commented on pull request #10757: Tail out all logs when retrieving from pod

2020-12-04 Thread GitBox
SamWheating commented on pull request #10757: URL: https://github.com/apache/airflow/pull/10757#issuecomment-739031584 Fixed in https://github.com/apache/airflow/pull/11325 This is an automated message from the Apache Git Ser

[GitHub] [airflow] AleksaC closed pull request #12536: Add pre-commit hook for JSON schema validation

2020-12-04 Thread GitBox
AleksaC closed pull request #12536: URL: https://github.com/apache/airflow/pull/12536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] AleksaC commented on pull request #12536: Add pre-commit hook for JSON schema validation

2020-12-04 Thread GitBox
AleksaC commented on pull request #12536: URL: https://github.com/apache/airflow/pull/12536#issuecomment-739027869 It's fine, I'll close the PR. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] XD-DENG edited a comment on pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
XD-DENG edited a comment on pull request #12816: URL: https://github.com/apache/airflow/pull/12816#issuecomment-739023107 A "side" observation: either something is wrong with GitHub iOS app, or something is wrong with our CI pipeline setting. ### When I check the "checks" of this PR

[GitHub] [airflow] SamWheating commented on a change in pull request #12811: Collapse the importErrors pane by default

2020-12-04 Thread GitBox
SamWheating commented on a change in pull request #12811: URL: https://github.com/apache/airflow/pull/12811#discussion_r536382706 ## File path: airflow/www/templates/appbuilder/flash.html ## @@ -53,13 +53,13 @@ - +

[GitHub] [airflow] XD-DENG commented on pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
XD-DENG commented on pull request #12816: URL: https://github.com/apache/airflow/pull/12816#issuecomment-739023107 A "side" observation: either something is wrong with GitHub iOS app, or something is wrong with our CI pipeline setting. ### When I check the "checks" of this PR on phon

[GitHub] [airflow] SamWheating opened a new pull request #12822: Removing redundant calls to session.commit()

2020-12-04 Thread GitBox
SamWheating opened a new pull request #12822: URL: https://github.com/apache/airflow/pull/12822 Re: https://github.com/apache/airflow/issues/12818 Removing redundant calls to `session.commit()` in places where the commit / rollback is already handled by a wrapping function or

[airflow] branch master updated (70b1cc2 -> 37afe55)

2020-12-04 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 70b1cc2 Move secret backends guides to provider docs (#12798) add 37afe55 Fix paths to images in README

[GitHub] [airflow] ryanahamilton commented on pull request #12365: Make import errors dropdown configurable for default value

2020-12-04 Thread GitBox
ryanahamilton commented on pull request #12365: URL: https://github.com/apache/airflow/pull/12365#issuecomment-739021146 Hey @Acehaidrey I'm going to go ahead and close this PR in favor of #12811 that delivers the same desired outcome. Thank you! --

[GitHub] [airflow] mik-laj merged pull request #12756: Fix paths to images in README.md

2020-12-04 Thread GitBox
mik-laj merged pull request #12756: URL: https://github.com/apache/airflow/pull/12756 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] ryanahamilton closed pull request #12365: Make import errors dropdown configurable for default value

2020-12-04 Thread GitBox
ryanahamilton closed pull request #12365: URL: https://github.com/apache/airflow/pull/12365 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] mik-laj edited a comment on issue #12357: JSON schema validation for airflow/config_templates/config.yml

2020-12-04 Thread GitBox
mik-laj edited a comment on issue #12357: URL: https://github.com/apache/airflow/issues/12357#issuecomment-739020214 @SamWheating This is not an urgent task, but we've been making some more changes lately. and I don't want to see bugs in this file, and w I assigned you to this ticket. 🐈‍⬛

[GitHub] [airflow] mik-laj commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

2020-12-04 Thread GitBox
mik-laj commented on issue #12357: URL: https://github.com/apache/airflow/issues/12357#issuecomment-739020214 @SamWheating This is not an urgent task, but I don't want to see bugs in this file, and we've been making some more changes lately. I assigned you to this ticket. 🐈‍⬛🐈 -

[GitHub] [airflow] SamWheating commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

2020-12-04 Thread GitBox
SamWheating commented on issue #12357: URL: https://github.com/apache/airflow/issues/12357#issuecomment-739019278 I can take this, but it may take me a week or two to get around to it. If that timeline is acceptable, then feel free to assign to me. ---

[GitHub] [airflow] ashb commented on a change in pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
ashb commented on a change in pull request #12816: URL: https://github.com/apache/airflow/pull/12816#discussion_r536377462 ## File path: tests/core/test_configuration.py ## @@ -375,6 +377,11 @@ def test_getsection(self): test_conf.getsection('testsection'),

[GitHub] [airflow] ashb commented on a change in pull request #12816: Configuration.getsection now copes with sections that only exist in user config

2020-12-04 Thread GitBox
ashb commented on a change in pull request #12816: URL: https://github.com/apache/airflow/pull/12816#discussion_r536377388 ## File path: tests/core/test_configuration.py ## @@ -375,6 +377,11 @@ def test_getsection(self): test_conf.getsection('testsection'),

[airflow] branch master updated (71d8745 -> 70b1cc2)

2020-12-04 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 71d8745 Add expandable groups in the docs build log (#12799) add 70b1cc2 Move secret backends guides to

[GitHub] [airflow] mik-laj merged pull request #12798: Move secret backends guides to provider docs

2020-12-04 Thread GitBox
mik-laj merged pull request #12798: URL: https://github.com/apache/airflow/pull/12798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] mik-laj commented on pull request #12536: Add pre-commit hook for JSON schema validation

2020-12-04 Thread GitBox
mik-laj commented on pull request #12536: URL: https://github.com/apache/airflow/pull/12536#issuecomment-739015942 Sorry. I miss this PR and I implemented these checks also. https://github.com/apache/airflow/blob/71d874515a96369bce9a0c3d6e112929abd89f92/.pre-commit-config.yaml#L497-L543

[GitHub] [airflow] mik-laj commented on issue #12358: Pre-commit for JSON schema validation

2020-12-04 Thread GitBox
mik-laj commented on issue #12358: URL: https://github.com/apache/airflow/issues/12358#issuecomment-739015417 We have pre-commit checks: https://github.com/apache/airflow/blob/71d874515a96369bce9a0c3d6e112929abd89f92/.pre-commit-config.yaml#L497-L543 --

[GitHub] [airflow] mik-laj closed issue #12358: Pre-commit for JSON schema validation

2020-12-04 Thread GitBox
mik-laj closed issue #12358: URL: https://github.com/apache/airflow/issues/12358 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj commented on issue #12357: JSON schema validation for airflow/config_templates/config.yml

2020-12-04 Thread GitBox
mik-laj commented on issue #12357: URL: https://github.com/apache/airflow/issues/12357#issuecomment-739015113 @SamWheating Is it something interesting for you? This is an automated message from the Apache Git Service. To res

[airflow] branch master updated (2936c13 -> 71d8745)

2020-12-04 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2936c13 Get airflow version from importlib.metadata rather than hard-coding (#12786) add 71d8745 Add e

[GitHub] [airflow] mik-laj merged pull request #12799: Add expandable groups in the docs build log

2020-12-04 Thread GitBox
mik-laj merged pull request #12799: URL: https://github.com/apache/airflow/pull/12799 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] ryanahamilton commented on a change in pull request #12811: Collapse the importErrors pane by default

2020-12-04 Thread GitBox
ryanahamilton commented on a change in pull request #12811: URL: https://github.com/apache/airflow/pull/12811#discussion_r536365656 ## File path: airflow/www/templates/appbuilder/flash.html ## @@ -53,13 +53,13 @@ - +

[GitHub] [airflow] mik-laj opened a new pull request #12821: Remove old option - git_password from sensitive_config_values

2020-12-04 Thread GitBox
mik-laj opened a new pull request #12821: URL: https://github.com/apache/airflow/pull/12821 This option has been removed https://github.com/apache/airflow/pull/10393/files CC: @SamWheating --- **^ Add meaningful description above** Read the **[Pull Request G

[GitHub] [airflow] mik-laj commented on issue #12553: New Documentation link to the "directory" from generated documentation

2020-12-04 Thread GitBox
mik-laj commented on issue #12553: URL: https://github.com/apache/airflow/issues/12553#issuecomment-739009697 Here is PR with index page for airflow-site: https://github.com/apache/airflow-site/pull/318/files This is an auto

[GitHub] [airflow] mik-laj commented on issue #12553: New Documentation link to the "directory" from generated documentation

2020-12-04 Thread GitBox
mik-laj commented on issue #12553: URL: https://github.com/apache/airflow/issues/12553#issuecomment-739009260 Now we have "Documentation" link in the navbar. http://apache-airflow-docs.s3-website.eu-central-1.amazonaws.com/index.html -

[GitHub] [airflow] mik-laj closed issue #12553: New Documentation link to the "directory" from generated documentation

2020-12-04 Thread GitBox
mik-laj closed issue #12553: URL: https://github.com/apache/airflow/issues/12553 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] kaxil commented on pull request #11850: Add Telegram hook and operator

2020-12-04 Thread GitBox
kaxil commented on pull request #11850: URL: https://github.com/apache/airflow/pull/11850#issuecomment-739007848 > Thanks for asking @mik-laj no issues, I couldn't get time to rebase and push. Just did, let's see how it goes. It works locally. Thanks for your patience while dealing w

[GitHub] [airflow] dimberman commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
dimberman commented on a change in pull request #12819: URL: https://github.com/apache/airflow/pull/12819#discussion_r536366356 ## File path: airflow/operators/dagrun_operator.py ## @@ -144,6 +144,9 @@ def execute(self, context: Dict): dag = dag_bag.get_dag(sel

[GitHub] [airflow] github-actions[bot] commented on pull request #12814: Add Apache Beam operators

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12814: URL: https://github.com/apache/airflow/pull/12814#issuecomment-739001072 [The Workflow run](https://github.com/apache/airflow/actions/runs/401324946) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] ashb commented on a change in pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-04 Thread GitBox
ashb commented on a change in pull request #12766: URL: https://github.com/apache/airflow/pull/12766#discussion_r536354882 ## File path: airflow/executors/kubernetes_executor.py ## @@ -297,7 +297,7 @@ def run_next(self, next_job: KubernetesJobType) -> None: kube_im

[GitHub] [airflow] turbaszek commented on a change in pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
turbaszek commented on a change in pull request #12819: URL: https://github.com/apache/airflow/pull/12819#discussion_r536354578 ## File path: airflow/operators/dagrun_operator.py ## @@ -144,6 +144,9 @@ def execute(self, context: Dict): dag = dag_bag.get_dag(sel

[GitHub] [airflow] brunoffaustino edited a comment on issue #8609: DAG's parameter access_control is not refreshing in the UI

2020-12-04 Thread GitBox
brunoffaustino edited a comment on issue #8609: URL: https://github.com/apache/airflow/issues/8609#issuecomment-738978922 Hi @kaxil and @ashb, Me and @Cabeda just made the test under version 2.0.0beta3 and it still exists. Here is how to we replicated it: 1. Install version 2.0.0be

[GitHub] [airflow] XD-DENG commented on issue #12818: Don't have session.commit() when @provide_session decorator is used

2020-12-04 Thread GitBox
XD-DENG commented on issue #12818: URL: https://github.com/apache/airflow/issues/12818#issuecomment-738988589 Cool. Assigned to you @SamWheating This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] dimberman commented on a change in pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-04 Thread GitBox
dimberman commented on a change in pull request #12766: URL: https://github.com/apache/airflow/pull/12766#discussion_r536346427 ## File path: airflow/executors/kubernetes_executor.py ## @@ -297,7 +297,7 @@ def run_next(self, next_job: KubernetesJobType) -> None: ku

[GitHub] [airflow] SamWheating commented on issue #12818: Don't have session.commit() when @provide_session decorator is used

2020-12-04 Thread GitBox
SamWheating commented on issue #12818: URL: https://github.com/apache/airflow/issues/12818#issuecomment-738988030 I'd be interested in taking this one on, feel free to assign me. This is an automated message from the Apache

[GitHub] [airflow] XD-DENG commented on a change in pull request #12816: Configuration.getsection now copes with sections that are exist in user config

2020-12-04 Thread GitBox
XD-DENG commented on a change in pull request #12816: URL: https://github.com/apache/airflow/pull/12816#discussion_r536345615 ## File path: tests/core/test_configuration.py ## @@ -375,6 +377,11 @@ def test_getsection(self): test_conf.getsection('testsection'),

[GitHub] [airflow] github-actions[bot] commented on pull request #12472: Allow registering extra links for providers

2020-12-04 Thread GitBox
github-actions[bot] commented on pull request #12472: URL: https://github.com/apache/airflow/pull/12472#issuecomment-738986102 [The Workflow run](https://github.com/apache/airflow/actions/runs/401290825) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] ashb commented on a change in pull request #12816: Configuration.getsection now copes with sections that are exist in user config

2020-12-04 Thread GitBox
ashb commented on a change in pull request #12816: URL: https://github.com/apache/airflow/pull/12816#discussion_r536343240 ## File path: tests/core/test_configuration.py ## @@ -375,6 +377,11 @@ def test_getsection(self): test_conf.getsection('testsection'),

[GitHub] [airflow] dimberman opened a new pull request #12819: Dagrun object doesn't exist in the TriggerDagRunOperator

2020-12-04 Thread GitBox
dimberman opened a new pull request #12819: URL: https://github.com/apache/airflow/pull/12819 fixes https://github.com/apache/airflow/issues/12587 Fixes issue where dag_run object is not populated if the dag_run already exists and is reset --- **^ Add meaningful

[GitHub] [airflow] SamWheating opened a new pull request #12820: Updating documentation to specify sensitive config options

2020-12-04 Thread GitBox
SamWheating opened a new pull request #12820: URL: https://github.com/apache/airflow/pull/12820 Adding a `sensitive` field to config.yml, based on this section of `configuration.py`: https://github.com/apache/airflow/blob/8f48f12128e0d985c6de2603902524859fecbca8/airflow/conf

  1   2   3   >