[GitHub] [airflow] natejenkins21 commented on issue #9975: max_active_runs = 1 can still create multiple active execution runs

2020-12-05 Thread GitBox
natejenkins21 commented on issue #9975: URL: https://github.com/apache/airflow/issues/9975#issuecomment-739468040 Same issue here. Causing a lot of issues for my backfills... This is an automated message from the Apache Git S

[GitHub] [airflow] github-actions[bot] commented on pull request #12847: Updated based on new releases

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12847: URL: https://github.com/apache/airflow/pull/12847#issuecomment-739453629 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] htgeis commented on pull request #12825: Enable to expand the key file path in ssh hooks

2020-12-05 Thread GitBox
htgeis commented on pull request #12825: URL: https://github.com/apache/airflow/pull/12825#issuecomment-739450965 > > These variables maybe change in the future and it's better not to do hard code in the connection. > > This doesn't convince me: anything can change, including the non

[GitHub] [airflow] vikramkoka opened a new pull request #12847: Updated based on new releases

2020-12-05 Thread GitBox
vikramkoka opened a new pull request #12847: URL: https://github.com/apache/airflow/pull/12847 Updated to reference 1.10.14 instead of 1.10.13. Also added an additional step to install the upgrade check scripts, instead of expecting them to be part of the Airflow bridge release.

[airflow] tag nightly-master updated (c1cd504 -> 1257b5c)

2020-12-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to tag nightly-master in repository https://gitbox.apache.org/repos/asf/airflow.git. *** WARNING: tag nightly-master was modified! *** from c1cd504 (commit) to 1257b5c (commit) from c1

[GitHub] [airflow] jhtimmins opened a new pull request #12846: Fix login error warning

2020-12-05 Thread GitBox
jhtimmins opened a new pull request #12846: URL: https://github.com/apache/airflow/pull/12846 Currently, when a user is logged out, the `DAGs` link shows in the menu and the `Not Logged In` warning shows if the user has been directed to `/login` from any other page. ![image (4)](ht

[GitHub] [airflow] aladinoss commented on issue #9840: Custom operator name field dont accept special characters

2020-12-05 Thread GitBox
aladinoss commented on issue #9840: URL: https://github.com/apache/airflow/issues/9840#issuecomment-739441942 Thanks, i'll check next week, provide you more details. This is an automated message from the Apache Git Service

[GitHub] [airflow] noelmcloughlin commented on issue #12832: Source hash apache-airflow-1.10.13-bin.tar.gz.sha512 format is invalid

2020-12-05 Thread GitBox
noelmcloughlin commented on issue #12832: URL: https://github.com/apache/airflow/issues/12832#issuecomment-739441830 The only workaround to install Airflow tarball with Salt is setting `skip_verify: true` to bypass the file format issue. I'm not sure what PyPI library they use in Salt, bu

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536929436 ## File path: airflow/providers/ssh/hooks/ssh.py ## @@ -57,9 +57,14 @@ class SSHHook(BaseHook): :type keepalive_interval: int """ +conn_na

[GitHub] [airflow] noelmcloughlin commented on issue #11965: Airflow fails to initdb with cattrs 1.1.0

2020-12-05 Thread GitBox
noelmcloughlin commented on issue #11965: URL: https://github.com/apache/airflow/issues/11965#issuecomment-739440890 > when i use pip3 install cattrs==1.0.0. Beware of cattrs 1.n.n hell with Python 3.9 (i.e. archlinux). - https://github.com/Tinche/cattrs/issues/100 - htt

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536928903 ## File path: airflow/providers/google/cloud/hooks/bigquery.py ## @@ -70,6 +70,7 @@ class BigQueryHook(GoogleBaseHook, DbApiHook): conn_name_attr = '

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536928785 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -55,9 +55,15 @@ class FacebookAdsReportingHook(BaseHook): """ +conn_name_attr

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536928736 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -55,9 +55,15 @@ class FacebookAdsReportingHook(BaseHook): """ +conn_name_attr

[GitHub] [airflow] kaxil commented on pull request #12800: Fix Commands for Publishing constraints

2020-12-05 Thread GitBox
kaxil commented on pull request #12800: URL: https://github.com/apache/airflow/pull/12800#issuecomment-739440244 ping @ashb @XD-DENG @potiuk @turbaszek This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536928191 ## File path: airflow/providers/apache/sqoop/hooks/sqoop.py ## @@ -52,6 +52,11 @@ class SqoopHook(BaseHook): :type properties: dict """ +c

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536927987 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -103,6 +103,9 @@ class S3Hook(AwsBaseHook): :class:`~airflow.providers.amazon.aws.ho

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536927837 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -103,6 +103,9 @@ class S3Hook(AwsBaseHook): :class:`~airflow.providers.amazon.aws.ho

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536927719 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -103,6 +103,9 @@ class S3Hook(AwsBaseHook): :class:`~airflow.providers.amazon.aws.ho

[GitHub] [airflow] github-actions[bot] commented on pull request #11964: Add new datetime branch operator

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #11964: URL: https://github.com/apache/airflow/pull/11964#issuecomment-739439758 [The Workflow run](https://github.com/apache/airflow/actions/runs/403294483) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536927484 ## File path: airflow/models/connection.py ## @@ -266,11 +266,19 @@ def rotate_fernet_key(self): def get_hook(self): """Return hook based

[GitHub] [airflow] kaxil commented on a change in pull request #12558: Add connection form support to provider discovery

2020-12-05 Thread GitBox
kaxil commented on a change in pull request #12558: URL: https://github.com/apache/airflow/pull/12558#discussion_r536927195 ## File path: UPDATING.md ## @@ -52,6 +52,11 @@ assists users migrating to a new version. ## Master +### SparkJDBCHook default connection + +For Spar

[GitHub] [airflow] noelmcloughlin edited a comment on issue #11965: Airflow fails to initdb with cattrs 1.1.0

2020-12-05 Thread GitBox
noelmcloughlin edited a comment on issue #11965: URL: https://github.com/apache/airflow/issues/11965#issuecomment-739439092 > The new version of PIP has MANY problems and broke a lot of other projects. I never use PyPi pip because OS distributions provide stable `python-pip, python2-

[GitHub] [airflow] noelmcloughlin edited a comment on issue #11965: Airflow fails to initdb with cattrs 1.1.0

2020-12-05 Thread GitBox
noelmcloughlin edited a comment on issue #11965: URL: https://github.com/apache/airflow/issues/11965#issuecomment-739439092 > The new version of PIP has MANY problems and broke a lot of other projects. I never use PyPi pip because OS distributions provide stable `python-pip, python2-

[GitHub] [airflow] kaxil commented on issue #12832: Source hash apache-airflow-1.10.13-bin.tar.gz.sha512 format is invalid

2020-12-05 Thread GitBox
kaxil commented on issue #12832: URL: https://github.com/apache/airflow/issues/12832#issuecomment-739439100 Maybe you can use Hash from PyPI: https://pypi.org/project/apache-airflow/1.10.13/#copy-hash-modal-7de14478-7b22-42f1-b870-f0aa8bf1b3ce ``` bb637f95a2aef7b2f7d622ecd

[GitHub] [airflow] noelmcloughlin commented on issue #11965: Airflow fails to initdb with cattrs 1.1.0

2020-12-05 Thread GitBox
noelmcloughlin commented on issue #11965: URL: https://github.com/apache/airflow/issues/11965#issuecomment-739439092 > The new version of PIP has MANY problems and broke a lot of other projects. I never use PyPi pip because OS distributions provide stable `python-pip, python2-pip, py

[GitHub] [airflow] kaxil commented on pull request #11260: Add DAG permissions based on DAG tags

2020-12-05 Thread GitBox
kaxil commented on pull request #11260: URL: https://github.com/apache/airflow/pull/11260#issuecomment-739438605 @jhtimmins Can you take a look at this please? This is an automated message from the Apache Git Service. To resp

[GitHub] [airflow] kaxil commented on pull request #12733: WIP: RedisXCom backend

2020-12-05 Thread GitBox
kaxil commented on pull request #12733: URL: https://github.com/apache/airflow/pull/12733#issuecomment-739438331 Just catching up here, good work @msumit . I was thinking we could add this kind of backends as example_redis_xcom_backend similar to our example_dags which we can use for the d

[airflow] branch master updated (4a02e0a -> 1257b5c)

2020-12-05 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4a02e0a Don't emit first_task_scheduling_delay metric for only-once dags (#12835) add 1257b5c Fix doc pre

[GitHub] [airflow] kaxil merged pull request #10962: Fix doc preview error in editor for google operators doc

2020-12-05 Thread GitBox
kaxil merged pull request #10962: URL: https://github.com/apache/airflow/pull/10962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] turbaszek commented on a change in pull request #11223: Airflow 11045 create stat name handler not supported rule

2020-12-05 Thread GitBox
turbaszek commented on a change in pull request #11223: URL: https://github.com/apache/airflow/pull/11223#discussion_r536919803 ## File path: airflow/upgrade/rules/stat_name_handler_not_supported.py ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [airflow] ashb commented on issue #12783: Sensors in reschedule mode are not rescheduled

2020-12-05 Thread GitBox
ashb commented on issue #12783: URL: https://github.com/apache/airflow/issues/12783#issuecomment-739434493 I've worked out the problem -- it's caused by the switch to Serialized DAGs only in HA scheduler. I have a hacky-one line fix. and am working on a better fix now.

[airflow] branch constraints-master updated: Updating constraints. Build id:403095934

2020-12-05 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new fbd525a Updating

[GitHub] [airflow] brighton1101 commented on a change in pull request #12467: Added support for DSS, ECDSA, and Ed25519 private keys in SSHHook

2020-12-05 Thread GitBox
brighton1101 commented on a change in pull request #12467: URL: https://github.com/apache/airflow/pull/12467#discussion_r536909117 ## File path: airflow/config_templates/config.yml ## @@ -2053,3 +2053,13 @@ type: string example: ~ default: "NamedHivePartiti

[GitHub] [airflow] vikramkoka commented on issue #12838: ❗ PIP 20.3 breaks Airflow installation❗

2020-12-05 Thread GitBox
vikramkoka commented on issue #12838: URL: https://github.com/apache/airflow/issues/12838#issuecomment-739425513 Thanks @potiuk I am really glad you added this to the installation instructions too! This is an automated mess

[GitHub] [airflow] ashb edited a comment on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb edited a comment on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739419341 Hmmm 60 vs 61 now. 61 looks like the "right" value too ```ipython console In [2]: len(setup.PROVIDERS_REQUIREMENTS)

[airflow] branch master updated (37b2679 -> 4a02e0a)

2020-12-05 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 37b2679 Make `airflow --help` run five times quicker (#12836) add 4a02e0a Don't emit first_task_scheduling_delay

[airflow] branch master updated (df9493c -> 37b2679)

2020-12-05 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from df9493c Add sensors section to describe different modes of sensors (#12803) add 37b2679 Make `airflow --help` r

[GitHub] [airflow] ashb merged pull request #12835: Don't emit first_task_scheduling_delay metric for only-once dags

2020-12-05 Thread GitBox
ashb merged pull request #12835: URL: https://github.com/apache/airflow/pull/12835 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] ashb merged pull request #12836: Make `airflow --help` run five times quicker

2020-12-05 Thread GitBox
ashb merged pull request #12836: URL: https://github.com/apache/airflow/pull/12836 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739419341 Hmmm 60 vs 61 now. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [airflow] XD-DENG edited a comment on pull request #12825: Enable to expand the key file path in ssh hooks

2020-12-05 Thread GitBox
XD-DENG edited a comment on pull request #12825: URL: https://github.com/apache/airflow/pull/12825#issuecomment-739408758 It's good to have flexibility only to certain extent. Being too flexible may lead to unexpected confusion eventually. I look forward to opinions from other commit

[GitHub] [airflow] XD-DENG opened a new pull request #12845: Only trigger action 'Label when reviewed' for specific event type

2020-12-05 Thread GitBox
XD-DENG opened a new pull request #12845: URL: https://github.com/apache/airflow/pull/12845 We notice sometimes the Action job `"Label PRs when reviewed"` is triggered for multiple times, even if there is only one approval https://github.com/apache/airflow/pull/12816#issuecomment-739023107

[GitHub] [airflow] XD-DENG commented on pull request #12825: Enable to expand the key file path in ssh hooks

2020-12-05 Thread GitBox
XD-DENG commented on pull request #12825: URL: https://github.com/apache/airflow/pull/12825#issuecomment-739408758 It's good to have flexibility only to certain extend. Being too flexible may lead to unexpected confusion eventually. I look forward to opinions from other committers as

[GitHub] [airflow] XD-DENG commented on pull request #12825: Enable to expand the key file path in ssh hooks

2020-12-05 Thread GitBox
XD-DENG commented on pull request #12825: URL: https://github.com/apache/airflow/pull/12825#issuecomment-739407314 > These variables maybe change in the future and it's better not to do hard code in the connection. This doesn't convince me: anything can change, including the non-envv

[airflow] branch master updated (e9b2ff5 -> df9493c)

2020-12-05 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e9b2ff5 Add notes about PIP 20.3 breaking Airflow installation (#12840) add df9493c Add sensors section t

[GitHub] [airflow] kaxil closed issue #10816: Docs around different execution modes for Sensor

2020-12-05 Thread GitBox
kaxil closed issue #10816: URL: https://github.com/apache/airflow/issues/10816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] kaxil merged pull request #12803: Add sensors section to describe different modes of sensors

2020-12-05 Thread GitBox
kaxil merged pull request #12803: URL: https://github.com/apache/airflow/pull/12803 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] rootcss commented on issue #12081: PapermillOperator does not take user defined macros

2020-12-05 Thread GitBox
rootcss commented on issue #12081: URL: https://github.com/apache/airflow/issues/12081#issuecomment-739389387 Hi @humbledude. This seems to be working fine for me. Could you please share a snippet of DAG object and your PapermillOperator. --

[GitHub] [airflow] github-actions[bot] commented on pull request #12803: Add sensors section to describe different modes of sensors

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12803: URL: https://github.com/apache/airflow/pull/12803#issuecomment-739389309 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] github-actions[bot] commented on pull request #11223: Airflow 11045 create stat name handler not supported rule

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #11223: URL: https://github.com/apache/airflow/pull/11223#issuecomment-739364858 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] kenluck2001 commented on a change in pull request #11223: Airflow 11045 create stat name handler not supported rule

2020-12-05 Thread GitBox
kenluck2001 commented on a change in pull request #11223: URL: https://github.com/apache/airflow/pull/11223#discussion_r536880288 ## File path: airflow/upgrade/rules/stat_name_handler_not_supported.py ## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [airflow] github-actions[bot] commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739364221 [The Workflow run](https://github.com/apache/airflow/actions/runs/402967051) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] ashb commented on pull request #12836: Make `airflow --help` run five times quicker

2020-12-05 Thread GitBox
ashb commented on pull request #12836: URL: https://github.com/apache/airflow/pull/12836#issuecomment-739345505 > I'd prefer to solve it differently, but pragmatically, this is easiest way now. I would also like that importing modules had less "side-effects", but... I think we

[GitHub] [airflow] potiuk commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
potiuk commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739336225 Ah I see - that's why there was a "providers list" first and "backportable" later :). i see now that you got the same command for both 0-> my proposal was just replacing the se

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739336021 K, so the issue was previously, the "list of providers" was always got from "normal", which we then checked against files on disk. We then always reset the list to backport.

[GitHub] [airflow] potiuk commented on a change in pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
potiuk commented on a change in pull request #12842: URL: https://github.com/apache/airflow/pull/12842#discussion_r536869364 ## File path: scripts/in_container/run_prepare_provider_packages.sh ## @@ -24,7 +24,7 @@ LIST_OF_DIRS_FILE=$(mktemp) cd "${AIRFLOW_SOURCES}/airflow/pr

[GitHub] [airflow] turbaszek commented on issue #12577: Use only single execution date in ExternalTaskSensor

2020-12-05 Thread GitBox
turbaszek commented on issue #12577: URL: https://github.com/apache/airflow/issues/12577#issuecomment-739335720 @ManiBharataraju I would say that you can do `python_operator >> external_sensor` and pass to the sensor whatever execution date you want. In my opinion this serves 100% of cases

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739335693 (I ran non-backport locally, the sed works fine.) This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] potiuk edited a comment on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
potiuk edited a comment on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739335427 > I think that's now failing _exactly because_ papermill is not backportable. Nope. I thin this is the changed sed. It did not even hit the changed it yet. The few

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739335605 > > I think that's now failing _exactly because_ papermill is not backportable. > > Nope. I thin this is the changed sed. ``` ERROR! Some folders from providers p

[GitHub] [airflow] potiuk commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
potiuk commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739335427 > I think that's now failing _exactly because_ papermill is not backportable. Nope. I thin this is the changed sed. -

[GitHub] [airflow] potiuk commented on pull request #12836: Make `airflow --help` run five times quicker

2020-12-05 Thread GitBox
potiuk commented on pull request #12836: URL: https://github.com/apache/airflow/pull/12836#issuecomment-739334640 I'd prefer to solve it differently, but pragmatically, this is easiest way now. This is an automated message f

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739334563 Oh lol. > ERROR! Some folders from providers package are not defined > Please add them to dev/provider_packages/prepare_provider_packages.py: I thin

[airflow] branch master updated (12c1fe2 -> e9b2ff5)

2020-12-05 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 12c1fe2 Increments number of providers detected and stop failing (#12841) add e9b2ff5 Add notes about PIP 20

[GitHub] [airflow] github-actions[bot] commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739334395 [The Workflow run](https://github.com/apache/airflow/actions/runs/402917006) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] potiuk merged pull request #12840: Add notes about PIP 20.3 breaking Airflow installation

2020-12-05 Thread GitBox
potiuk merged pull request #12840: URL: https://github.com/apache/airflow/pull/12840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #12840: Add notes about PIP 20.3 breaking Airflow installation

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12840: URL: https://github.com/apache/airflow/pull/12840#issuecomment-739334179 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] ashb commented on pull request #12844: Add CAP_SYS_NICE to prevent confusing non-error error in Mysql logs

2020-12-05 Thread GitBox
ashb commented on pull request #12844: URL: https://github.com/apache/airflow/pull/12844#issuecomment-739333474 https://github.com/apache/airflow/runs/1504028479?check_suite_focus=true of an example This is an automa

[GitHub] [airflow] ashb opened a new pull request #12844: Add CAP_SYS_NICE to prevent confusing non-error error in Mysql logs

2020-12-05 Thread GitBox
ashb opened a new pull request #12844: URL: https://github.com/apache/airflow/pull/12844 If a MySQL 8 test fails it will dump the logs, and we will see a lot of errors like this: ``` mbind: Operation not permitted mbind: Operation not permitted mbind: Operation not permitt

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739332826 > Yours is nicer. I kill mine :) Thanks, it took me rather longer though! (been poking at this for an hour) ---

[GitHub] [airflow] github-actions[bot] commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739332721 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] potiuk closed pull request #12843: Fix instability of number of packages produced.

2020-12-05 Thread GitBox
potiuk closed pull request #12843: URL: https://github.com/apache/airflow/pull/12843 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk opened a new pull request #12843: Fix instability of number of packages produced.

2020-12-05 Thread GitBox
potiuk opened a new pull request #12843: URL: https://github.com/apache/airflow/pull/12843 Backportable packages were overwriting list of packages with the backportable packages. Not yet restoring the check until we see a few successes. --- **^ Add meaningful desc

[GitHub] [airflow] ashb commented on pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on pull request #12842: URL: https://github.com/apache/airflow/pull/12842#issuecomment-739332453 Lets see if this passes the provider test This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ashb commented on a change in pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on a change in pull request #12842: URL: https://github.com/apache/airflow/pull/12842#discussion_r536849964 ## File path: scripts/in_container/run_prepare_provider_packages.sh ## @@ -24,7 +24,7 @@ LIST_OF_DIRS_FILE=$(mktemp) cd "${AIRFLOW_SOURCES}/airflow/prov

[GitHub] [airflow] ashb commented on a change in pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on a change in pull request #12842: URL: https://github.com/apache/airflow/pull/12842#discussion_r536849510 ## File path: scripts/in_container/run_prepare_provider_packages.sh ## @@ -34,12 +34,21 @@ REFACTOR_PROVIDER_PACKAGES_PY="${AIRFLOW_SOURCES}/dev/provider_

[GitHub] [airflow] ashb commented on a change in pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb commented on a change in pull request #12842: URL: https://github.com/apache/airflow/pull/12842#discussion_r536849366 ## File path: scripts/in_container/run_prepare_provider_packages.sh ## @@ -63,7 +72,6 @@ if [[ -z "$*" ]]; then echo exit 1 fi -

[GitHub] [airflow] ashb opened a new pull request #12842: Build normal/backport providers based on correct list

2020-12-05 Thread GitBox
ashb opened a new pull request #12842: URL: https://github.com/apache/airflow/pull/12842 This was using the backport list when trying to build the normal list, leading to papermill package not getting built. I have re-introduced the exit removed in #12841, and also done a little

[GitHub] [airflow] ashb commented on pull request #12841: Increments number of providers detected and stop failing

2020-12-05 Thread GitBox
ashb commented on pull request #12841: URL: https://github.com/apache/airflow/pull/12841#issuecomment-739331370 Spotted the problem. Fix coming. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] github-actions[bot] commented on pull request #12840: Add notes about PIP 20.3 breaking Airflow installation

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12840: URL: https://github.com/apache/airflow/pull/12840#issuecomment-739331242 [The Workflow run](https://github.com/apache/airflow/actions/runs/402888329) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #12836: Make `airflow --help` run five times quicker

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12836: URL: https://github.com/apache/airflow/pull/12836#issuecomment-739329946 [The Workflow run](https://github.com/apache/airflow/actions/runs/402707859) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[airflow] branch master updated (1f4152b -> 12c1fe2)

2020-12-05 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1f4152b Fix docstring for models.Variable.get() (#12828) add 12c1fe2 Increments number of providers detected

[GitHub] [airflow] potiuk merged pull request #12841: Increments number of providers detected and stop failing

2020-12-05 Thread GitBox
potiuk merged pull request #12841: URL: https://github.com/apache/airflow/pull/12841 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #12841: Increments number of providers detected and stop failing

2020-12-05 Thread GitBox
potiuk commented on pull request #12841: URL: https://github.com/apache/airflow/pull/12841#issuecomment-739329170 I'll merge it for now to unblock the master. and will fix it as the next step. This is an automated message fr

[GitHub] [airflow] ashb commented on pull request #12841: Increments number of providers detected and stop failing

2020-12-05 Thread GitBox
ashb commented on pull request #12841: URL: https://github.com/apache/airflow/pull/12841#issuecomment-739328927 It's something to do with papermill missing -- at least in the example I saw. This is an automated message from t

[GitHub] [airflow] github-actions[bot] commented on pull request #12841: Increments number of providers detected and stop failing

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12841: URL: https://github.com/apache/airflow/pull/12841#issuecomment-739328891 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] potiuk opened a new pull request #12841: Increments number of providers detected and stop failing

2020-12-05 Thread GitBox
potiuk opened a new pull request #12841: URL: https://github.com/apache/airflow/pull/12841 There seem to be a flaky number of providers returned by integration test. For now exit will be disabled but we will observe the flakiness. --- **^ Add meaningful descriptio

[GitHub] [airflow] potiuk opened a new pull request #12840: Add notes about PIP 20.3 breaking Airflow installation

2020-12-05 Thread GitBox
potiuk opened a new pull request #12840: URL: https://github.com/apache/airflow/pull/12840 Part of #12838 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guid

[GitHub] [airflow] github-actions[bot] commented on pull request #12837: Customizable javascript configuration in connnection form

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12837: URL: https://github.com/apache/airflow/pull/12837#issuecomment-739325769 [The Workflow run](https://github.com/apache/airflow/actions/runs/402844832) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #12836: Make `airflow --help` run five times quicker

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12836: URL: https://github.com/apache/airflow/pull/12836#issuecomment-739325772 [The Workflow run](https://github.com/apache/airflow/actions/runs/402844832) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] potiuk opened a new pull request #12839: Adds warning about ongoing problems wit PIP 20.3 to bug template

2020-12-05 Thread GitBox
potiuk opened a new pull request #12839: URL: https://github.com/apache/airflow/pull/12839 Part of #12838 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guid

[GitHub] [airflow] potiuk opened a new issue #12838: PIP 20.3 breaks Airflow installation!

2020-12-05 Thread GitBox
potiuk opened a new issue #12838: URL: https://github.com/apache/airflow/issues/12838 I am adding this issue to keep track of the on-going problems with new PIP 20.3 released 30th of November. There are multiple issues with the new PIP that makes it breaks with Airflow's dependency

[GitHub] [airflow] potiuk edited a comment on issue #12824: Pip install breaks on S3 due to package mismatch error

2020-12-05 Thread GitBox
potiuk edited a comment on issue #12824: URL: https://github.com/apache/airflow/issues/12824#issuecomment-739321527 Why no, not really @ashb :). @spence95 Can you please downgrade PIP to 20.2.4 ? Tjhis most likely the issue with new PIP 20.3 rolled out on Nov 30th. There ar

[GitHub] [airflow] potiuk closed issue #12824: Pip install breaks on S3 due to package mismatch error

2020-12-05 Thread GitBox
potiuk closed issue #12824: URL: https://github.com/apache/airflow/issues/12824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on issue #12824: Pip install breaks on S3 due to package mismatch error

2020-12-05 Thread GitBox
potiuk commented on issue #12824: URL: https://github.com/apache/airflow/issues/12824#issuecomment-739321527 Why no, not really @ashb . Can you please downgrade PIP to 20.2.4 ? Tjhis most likely the issue with new PIP 20.3 rolled out on Nov 30th. There are many issues (at least for

[GitHub] [airflow] potiuk commented on pull request #12837: Customizable javascript configuration in connnection form

2020-12-05 Thread GitBox
potiuk commented on pull request #12837: URL: https://github.com/apache/airflow/pull/12837#issuecomment-739315616 I've found rather simple and nice way of passing the discovered "hidden/renamed fields" to the javascript form. I do it via Hidden Field in FAB. This Is really simple and strai

[airflow] branch master updated (1dcd3e1 -> 1f4152b)

2020-12-05 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1dcd3e1 Add support for extra links coming from the providers (#12472) add 1f4152b Fix docstring for models.V

[GitHub] [airflow] XD-DENG merged pull request #12828: Fix docstring for models.Variable.get()

2020-12-05 Thread GitBox
XD-DENG merged pull request #12828: URL: https://github.com/apache/airflow/pull/12828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] github-actions[bot] commented on pull request #12836: Make `airflow --help` run five times quicker

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12836: URL: https://github.com/apache/airflow/pull/12836#issuecomment-739314544 [The Workflow run](https://github.com/apache/airflow/actions/runs/402737123) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #12766: Kubernetes worker pod doesn't use docker container entrypoint

2020-12-05 Thread GitBox
github-actions[bot] commented on pull request #12766: URL: https://github.com/apache/airflow/pull/12766#issuecomment-739314539 [The Workflow run](https://github.com/apache/airflow/actions/runs/402737123) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

  1   2   >