[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14280: Add plugins endpoint to the REST API

2021-02-23 Thread GitBox
ephraimbuddy commented on a change in pull request #14280: URL: https://github.com/apache/airflow/pull/14280#discussion_r581723816 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -1380,7 +1381,96 @@ paths: application/json: schema:

[GitHub] [airflow] DreamyWen opened a new issue #14413: support chinese character in xcom output

2021-02-23 Thread GitBox
DreamyWen opened a new issue #14413: URL: https://github.com/apache/airflow/issues/14413 **Description** Apache Airflow version: 1.10.14 Kubernetes version (if you are using kubernetes) (use kubectl version): Environment: System Version: macOS 11.1 (20C

[airflow] branch constraints-master updated: Updating constraints. Build id:595064956

2021-02-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new abf53ce Updating

[GitHub] [airflow] ayushri05 commented on issue #14382: what is registry_conn_id and from where I can get it in case of Azure container Registry.

2021-02-23 Thread GitBox
ayushri05 commented on issue #14382: URL: https://github.com/apache/airflow/issues/14382#issuecomment-784851446 I got the Azure container registry Id with below cmd- > az acr show -n --query id and put that in 'registry_conn_id' but it is giving below error and DAG failed -

[GitHub] [airflow] prithvisathiya opened a new issue #14412: STORE_DAG_CODE not displaying correct code for zipped dag files

2021-02-23 Thread GitBox
prithvisathiya opened a new issue #14412: URL: https://github.com/apache/airflow/issues/14412 **Apache Airflow version**: 1.10.14 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.19.4 **Environment**: - **Cloud provide

[GitHub] [airflow] boring-cyborg[bot] commented on issue #14412: STORE_DAG_CODE not displaying correct code for zipped dag files

2021-02-23 Thread GitBox
boring-cyborg[bot] commented on issue #14412: URL: https://github.com/apache/airflow/issues/14412#issuecomment-784849082 Thanks for opening your first issue here! Be sure to follow the issue template! This is an automate

[GitHub] [airflow] kaxil merged pull request #14403: Sort Committers via their names instead of usernames

2021-02-23 Thread GitBox
kaxil merged pull request #14403: URL: https://github.com/apache/airflow/pull/14403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch master updated: Sort Committers via their names instead of usernames (#14403)

2021-02-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 3dc762c Sort Committers via their names ins

[airflow] branch master updated: Add Cross reference for Accessing Task Context in TaskFlow API (#14405)

2021-02-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new f70257f Add Cross reference for Accessing T

[GitHub] [airflow] kaxil merged pull request #14405: Add Cross reference for Accessing Task Context in TaskFlow API

2021-02-23 Thread GitBox
kaxil merged pull request #14405: URL: https://github.com/apache/airflow/pull/14405 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] chrisrfu commented on issue #14365: docker-compose up airflow-init produces airflow command error

2021-02-23 Thread GitBox
chrisrfu commented on issue #14365: URL: https://github.com/apache/airflow/issues/14365#issuecomment-784794697 I am not on an M1 chip MacBook Pro (16-inch, 2019) 2.3 GHz 8-Core Intel Core i9 This is an automated mes

[GitHub] [airflow] sakaia opened a new issue #14409: "dag_id could not be found" when running airflow on KubernetesExecutor on Airflow 1.10.14

2021-02-23 Thread GitBox
sakaia opened a new issue #14409: URL: https://github.com/apache/airflow/issues/14409 **Apache Airflow version**: 1.10.14 with helm **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): 1.18.5 **Environment**: - **Cloud provider or hardware

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14408: Correct email-config.rst file path

2021-02-23 Thread GitBox
boring-cyborg[bot] commented on pull request #14408: URL: https://github.com/apache/airflow/pull/14408#issuecomment-784720089 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] marcosmarxm opened a new pull request #14408: Correct email-config.rst file path

2021-02-23 Thread GitBox
marcosmarxm opened a new pull request #14408: URL: https://github.com/apache/airflow/pull/14408 I'm reading the documentation (`CONTRIBUTING.rst`) to start some contributions and I ended up finding this broken link. Just create this PR to fix this. --- **^ Add meaningful

[GitHub] [airflow] stoiandl edited a comment on issue #14261: Airflow Scheduler liveness probe crashing (version 2.0)

2021-02-23 Thread GitBox
stoiandl edited a comment on issue #14261: URL: https://github.com/apache/airflow/issues/14261#issuecomment-784619202 I managed to fix my restart by setting up the following configs: ``` [kubernetes] ... delete_option_kwargs = {"grace_period_seconds": 10} enable_tcp_keepalive

[airflow] branch constraints-master updated: Updating constraints. Build id:594442927

2021-02-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 13bc0e7 Updating

[GitHub] [airflow] mik-laj edited a comment on issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
mik-laj edited a comment on issue #14385: URL: https://github.com/apache/airflow/issues/14385#issuecomment-784698495 this health check is part of the webserver and if the webserver returns an incorrect value, the error code will be different than 200. For other components it doesn't

[GitHub] [airflow] mik-laj commented on issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
mik-laj commented on issue #14385: URL: https://github.com/apache/airflow/issues/14385#issuecomment-784699055 Duplicate: https://github.com/apache/airflow/issues/11161 This is an automated message from the Apache Git Service.

[GitHub] [airflow] mik-laj closed issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
mik-laj closed issue #14385: URL: https://github.com/apache/airflow/issues/14385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] mik-laj commented on issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
mik-laj commented on issue #14385: URL: https://github.com/apache/airflow/issues/14385#issuecomment-784698495 this health check is part of the webserver and if the webserver returns an incorrect value, the error code will be different than 200. For other components it doesn't work a

[GitHub] [airflow] github-actions[bot] commented on pull request #14407: Fix health spelled incorrectly

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14407: URL: https://github.com/apache/airflow/pull/14407#issuecomment-784695819 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] github-actions[bot] commented on pull request #14407: Fix health spelled incorrectly

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14407: URL: https://github.com/apache/airflow/pull/14407#issuecomment-784695069 [The Workflow run](https://github.com/apache/airflow/actions/runs/594539825) is cancelling this PR. Building images for the PR has failed. Follow the the workflow

[GitHub] [airflow] jhtimmins commented on issue #14373: delete_dag in json_client, the end_point is wrong

2021-02-23 Thread GitBox
jhtimmins commented on issue #14373: URL: https://github.com/apache/airflow/issues/14373#issuecomment-784691415 Looks like this is a valid error (and still exists on master). @kaxil how far back are we backporting bug fixes like this? --

[GitHub] [airflow] ephraimbuddy commented on issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
ephraimbuddy commented on issue #14385: URL: https://github.com/apache/airflow/issues/14385#issuecomment-784679179 > Confirmed that this is the behavior, as any failure is caught and then a standard response is returned. > https://github.com/apache/airflow/blob/master/airflow/api_connex

[GitHub] [airflow] jhtimmins edited a comment on issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
jhtimmins edited a comment on issue #14385: URL: https://github.com/apache/airflow/issues/14385#issuecomment-784675174 Confirmed that this is the behavior, as any failure is caught and then a standard response is returned. https://github.com/apache/airflow/blob/master/airflow/api_connex

[GitHub] [airflow] jhtimmins opened a new pull request #14407: Fix health spelled incorrectly

2021-02-23 Thread GitBox
jhtimmins opened a new pull request #14407: URL: https://github.com/apache/airflow/pull/14407 In the healthcheck endpoint, several occurrences of "health" are spelled as "heath". This corrects the misspelling. This is an aut

[GitHub] [airflow] jhtimmins commented on issue #14385: change the status code which healthcheck API returns

2021-02-23 Thread GitBox
jhtimmins commented on issue #14385: URL: https://github.com/apache/airflow/issues/14385#issuecomment-784675174 Confirmed that this is the behavior, as any failure is caught and then a standard response is returned. https://github.com/apache/airflow/blob/master/airflow/api_connexion/end

[GitHub] [airflow] jhtimmins commented on issue #14394: Add link to not deprecated modules docs

2021-02-23 Thread GitBox
jhtimmins commented on issue #14394: URL: https://github.com/apache/airflow/issues/14394#issuecomment-784672905 This is a good idea and can be assigned to me This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] github-actions[bot] commented on pull request #14405: Add Cross reference for Accessing Task Context in TaskFlow API

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14405: URL: https://github.com/apache/airflow/pull/14405#issuecomment-784670019 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] jhtimmins commented on issue #14365: docker-compose up airflow-init produces airflow command error

2021-02-23 Thread GitBox
jhtimmins commented on issue #14365: URL: https://github.com/apache/airflow/issues/14365#issuecomment-784667888 @chrisrfu Are you on an M1 chip as well? @kaxil did you recently address an issue where this came up? This

[GitHub] [airflow] github-actions[bot] commented on pull request #14403: Sort Committers via their names instead of usernames

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14403: URL: https://github.com/apache/airflow/pull/14403#issuecomment-784668031 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] jhtimmins commented on pull request #14388: Pass region name to superclass of AWSGlueJobHook

2021-02-23 Thread GitBox
jhtimmins commented on pull request #14388: URL: https://github.com/apache/airflow/pull/14388#issuecomment-784664708 This fix works, but now you're setting `self.region_name` in both the child and the parent. Probably best to remove `self.region_name = region_name` from the child. C

[GitHub] [airflow] stoiandl edited a comment on issue #14261: Airflow Scheduler liveness probe crashing (version 2.0)

2021-02-23 Thread GitBox
stoiandl edited a comment on issue #14261: URL: https://github.com/apache/airflow/issues/14261#issuecomment-784619202 I managed to fix my restart by setting up the following configs: ``` [kubernetes] ... kube_client_request_args = { "_request_timeout": 60 } delete_option_kwarg

[GitHub] [airflow] jhtimmins commented on a change in pull request #14219: Provide login endpoint for the REST API with JWT authentication method

2021-02-23 Thread GitBox
jhtimmins commented on a change in pull request #14219: URL: https://github.com/apache/airflow/pull/14219#discussion_r581525397 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -1381,11 +1381,198 @@ paths: schema: $ref: '#/components/sch

[GitHub] [airflow] r-richmond commented on issue #14396: Make context less nebulous

2021-02-23 Thread GitBox
r-richmond commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-784646194 >Dataclass is not pythonic at all As a counter point [Dacite](https://github.com/konradhalas/dacite) is a python library that shows how dataclasses can be used for somethi

[airflow] branch constraints-master updated: Updating constraints. Build id:594201069

2021-02-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new e48b4c5 Updating

[GitHub] [airflow] milton0825 edited a comment on issue #7935: scheduler gets stuck without a trace

2021-02-23 Thread GitBox
milton0825 edited a comment on issue #7935: URL: https://github.com/apache/airflow/issues/7935#issuecomment-784638031 Have a theory of why the Airflow scheduler may stuck at [CeleryExecutor._send_tasks_to_celery](https://github.com/apache/airflow/blob/master/airflow/executors/celery_executo

[GitHub] [airflow] milton0825 commented on issue #7935: scheduler gets stuck without a trace

2021-02-23 Thread GitBox
milton0825 commented on issue #7935: URL: https://github.com/apache/airflow/issues/7935#issuecomment-784638031 Have a theory of why the Airflow scheduler may stuck at [CeleryExecutor._send_tasks_to_celery](https://github.com/apache/airflow/blob/master/airflow/executors/celery_executor.py#L3

[GitHub] [airflow] kaxil commented on issue #13799: Scheduler crashes when unpausing some dags with: TypeError: '>' not supported between instances of 'NoneType' and 'int'

2021-02-23 Thread GitBox
kaxil commented on issue #13799: URL: https://github.com/apache/airflow/issues/13799#issuecomment-784632092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] kaxil opened a new pull request #14406: Make TaskInstance.pool_slots not nullable with a default of 1

2021-02-23 Thread GitBox
kaxil opened a new pull request #14406: URL: https://github.com/apache/airflow/pull/14406 closes https://github.com/apache/airflow/issues/13799 Without it the migration from 1.10.14 to 2.0.0 can fail with following error for old TIs: ``` Traceback (most recent call last):

[GitHub] [airflow] stoiandl commented on issue #14261: Airflow Scheduler liveness probe crashing (version 2.0)

2021-02-23 Thread GitBox
stoiandl commented on issue #14261: URL: https://github.com/apache/airflow/issues/14261#issuecomment-784619202 I managed to fix my restart by setting up the following configs: ``` [kubernetes] ... kube_client_request_args = { "_request_timeout": 60 } delete_option_kwargs = {"g

[GitHub] [airflow] kaxil commented on issue #14379: Running Airflow in Docker - Tutorial dags backfill tutorial example fails with TypeError: cannot serialize '_io.TextIOWrapper' object

2021-02-23 Thread GitBox
kaxil commented on issue #14379: URL: https://github.com/apache/airflow/issues/14379#issuecomment-784614840 Awesome, glad that it worked :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] kaxil closed issue #14379: Running Airflow in Docker - Tutorial dags backfill tutorial example fails with TypeError: cannot serialize '_io.TextIOWrapper' object

2021-02-23 Thread GitBox
kaxil closed issue #14379: URL: https://github.com/apache/airflow/issues/14379 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] DougForrest commented on issue #14379: Running Airflow in Docker - Tutorial dags backfill tutorial example fails with TypeError: cannot serialize '_io.TextIOWrapper' object

2021-02-23 Thread GitBox
DougForrest commented on issue #14379: URL: https://github.com/apache/airflow/issues/14379#issuecomment-784609036 Thanks for the response I wasn't aware there was a large difference. I can confirm that the image `apache/airflow:2.0.1-python3.8` also works in my local environment. --

[GitHub] [airflow] careduz edited a comment on issue #14261: Airflow Scheduler liveness probe crashing (version 2.0)

2021-02-23 Thread GitBox
careduz edited a comment on issue #14261: URL: https://github.com/apache/airflow/issues/14261#issuecomment-784574696 We are facing the same issue (scheduler liveness probe always failing and restarting the scheduler). Details: **Airflow: Version 1.10.14 & 1.10.13** **Kubernetes: V

[airflow] branch master updated (277f7c9 -> 809b4f9)

2021-02-23 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 277f7c9 Add Ephraim as a Code Owner for the Stable REST API (#14401) add 809b4f9 Unique pod name (#14186)

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14186: Unique pod name

2021-02-23 Thread GitBox
boring-cyborg[bot] commented on pull request #14186: URL: https://github.com/apache/airflow/pull/14186#issuecomment-784586101 Awesome work, congrats on your first merged pull request! This is an automated message from the

[GitHub] [airflow] dimberman merged pull request #14186: Unique pod name

2021-02-23 Thread GitBox
dimberman merged pull request #14186: URL: https://github.com/apache/airflow/pull/14186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] ferruzzi edited a comment on pull request #14402: Implemented S3 Bucket Tagging

2021-02-23 Thread GitBox
ferruzzi edited a comment on pull request #14402: URL: https://github.com/apache/airflow/pull/14402#issuecomment-784582611 I see it is failing `Validate providers.yaml files` on your side. It says 'skipped' on my side for that one when I run the pre-commit. If I do make any changes to th

[GitHub] [airflow] ferruzzi commented on pull request #14402: Implemented S3 Bucket Tagging

2021-02-23 Thread GitBox
ferruzzi commented on pull request #14402: URL: https://github.com/apache/airflow/pull/14402#issuecomment-784582611 I see it is failing `Validate providers.yaml files` on your side. It says 'skipped' on my side for that one when I run the pre-commit.

[GitHub] [airflow] kaxil commented on issue #14379: Running Airflow in Docker - Tutorial dags backfill tutorial example fails with TypeError: cannot serialize '_io.TextIOWrapper' object

2021-02-23 Thread GitBox
kaxil commented on issue #14379: URL: https://github.com/apache/airflow/issues/14379#issuecomment-784579603 Master and v2-0-stable are fair bit different in terms of the actual code. And users shouldn't be using images from Master in their Prod clusters ---

[GitHub] [airflow] kaxil closed pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME

2021-02-23 Thread GitBox
kaxil closed pull request #14404: URL: https://github.com/apache/airflow/pull/14404 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #14402: Implemented S3 Bucket Tagging

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14402: URL: https://github.com/apache/airflow/pull/14402#issuecomment-784578447 [The Workflow run](https://github.com/apache/airflow/actions/runs/594171188) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] kaxil opened a new pull request #14405: Add Cross reference for Accessing Task Context in TaskFlow API

2021-02-23 Thread GitBox
kaxil opened a new pull request #14405: URL: https://github.com/apache/airflow/pull/14405 Lot of users have been asking this on Slack, SO etc on how to do that. While we have it in our doc, it isn't cross-referenced in TaskFlow API which causes that feature to be hidden.

[GitHub] [airflow] DougForrest commented on issue #14379: Running Airflow in Docker - Tutorial dags backfill tutorial example fails with TypeError: cannot serialize '_io.TextIOWrapper' object

2021-02-23 Thread GitBox
DougForrest commented on issue #14379: URL: https://github.com/apache/airflow/issues/14379#issuecomment-784576282 I updated the docker-compose.yaml default airflow image which fixed the problem. ```yaml - image: ${AIRFLOW_IMAGE_NAME:-apache/airflow:2.0.1} + image: ${AIRFLOW_IMA

[GitHub] [airflow] careduz commented on issue #14261: Airflow Scheduler liveness probe crashing (version 2.0)

2021-02-23 Thread GitBox
careduz commented on issue #14261: URL: https://github.com/apache/airflow/issues/14261#issuecomment-784574696 We are facing the same issue (scheduler liveness probe always failing and restarting the scheduler). Details: **Airflow: Version 1.10.14** **Kubernetes: Version 1.20.2** (

[GitHub] [airflow] marcbizal commented on issue #14365: docker-compose up airflow-init produces airflow command error

2021-02-23 Thread GitBox
marcbizal commented on issue #14365: URL: https://github.com/apache/airflow/issues/14365#issuecomment-784572647 I have an identical issue. **Environment:** - OS: macOS 11.2.1 - Kernel: Darwin Kernel Version 20.3.0 It's worth noting that this is on an M1 chip for me.

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME

2021-02-23 Thread GitBox
boring-cyborg[bot] commented on pull request #14404: URL: https://github.com/apache/airflow/pull/14404#issuecomment-784571313 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] DougForrest opened a new pull request #14404: Update docker-compose.yaml default AIRFLOW_IMAGE_NAME

2021-02-23 Thread GitBox
DougForrest opened a new pull request #14404: URL: https://github.com/apache/airflow/pull/14404 Updates default docker image name used in the docker compose file for v2-0-stable to run Airflow in the Running Airflow in Docker documentation. This change is consistent with current master bra

[GitHub] [airflow] ephraimbuddy commented on pull request #14313: Fix wasb task handler py

2021-02-23 Thread GitBox
ephraimbuddy commented on pull request #14313: URL: https://github.com/apache/airflow/pull/14313#issuecomment-784570714 @heeroyuy925 I have confirmed that we should use `context_as_text` method instead of `readall()` can you update the PR with it? Your solution is Ok but I'm thinking this

[GitHub] [airflow] kaxil opened a new pull request #14403: Sort Committers via their names instead of usernames

2021-02-23 Thread GitBox
kaxil opened a new pull request #14403: URL: https://github.com/apache/airflow/pull/14403 Previously: GithubUsername (Name) Now: Name (GithubUsername) --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #14402: Implemented S3 Bucket Tagging

2021-02-23 Thread GitBox
boring-cyborg[bot] commented on pull request #14402: URL: https://github.com/apache/airflow/pull/14402#issuecomment-784567985 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] ferruzzi opened a new pull request #14402: Implemented S3 Bucket Tagging

2021-02-23 Thread GitBox
ferruzzi opened a new pull request #14402: URL: https://github.com/apache/airflow/pull/14402 closes: #14279 CHANGES: - Added Put/Get/Delete operators for AWS S3 bucket tagging. TESTING: - Unit testing included - Sample DAG included - Passes pre-commit ---

[GitHub] [airflow] zachliu edited a comment on issue #13799: Scheduler crashes when unpausing some dags with: TypeError: '>' not supported between instances of 'NoneType' and 'int'

2021-02-23 Thread GitBox
zachliu edited a comment on issue #13799: URL: https://github.com/apache/airflow/issues/13799#issuecomment-784565641 same situation with the `operator` column in `task_instance` table i had to do ```SQL UPDATE task_instance SET operator = 'NoOperator' WHERE operator IS NULL; ```

[GitHub] [airflow] aviau commented on pull request #14186: Unique pod name

2021-02-23 Thread GitBox
aviau commented on pull request #14186: URL: https://github.com/apache/airflow/pull/14186#issuecomment-784567087 For me I can confirm that setting the pod name works when applying this patch. This is an automated message fro

[GitHub] [airflow] aviau commented on issue #13918: KubernetesPodOperator with pod_template_file = No Metadata & Wrong Pod Name

2021-02-23 Thread GitBox
aviau commented on issue #13918: URL: https://github.com/apache/airflow/issues/13918#issuecomment-784566801 I deployed https://github.com/apache/airflow/pull/14186 and it fixes the issue for the pod name. This is an automate

[GitHub] [airflow] zachliu commented on issue #13799: Scheduler crashes when unpausing some dags with: TypeError: '>' not supported between instances of 'NoneType' and 'int'

2021-02-23 Thread GitBox
zachliu commented on issue #13799: URL: https://github.com/apache/airflow/issues/13799#issuecomment-784565641 same situation with the `operator` column in `task_instance` table i had to do ```SQL UPDATE task_instance SET operator = 'NoOperator' WHERE operator IS NULL; ``` sho

[GitHub] [airflow] RikHeijdens edited a comment on issue #14384: Scheduler ocassionally crashes with a TypeError when updating DagRun state

2021-02-23 Thread GitBox
RikHeijdens edited a comment on issue #14384: URL: https://github.com/apache/airflow/issues/14384#issuecomment-784559397 I got a little bit further with finding the root cause of why `start_date` may be null: when one transitions the state of the DagRun from `failed` to `running` using the

[GitHub] [airflow] RikHeijdens commented on issue #14384: Scheduler ocassionally crashes with a TypeError when updating DagRun state

2021-02-23 Thread GitBox
RikHeijdens commented on issue #14384: URL: https://github.com/apache/airflow/issues/14384#issuecomment-784559397 I got a little bit further with finding the root cause of why `start_date` may be null: when one transitions the state of the DagRun from `failed` to `running` using the form t

[GitHub] [airflow] potiuk commented on pull request #11950: Add Python 3.9 to supported versions

2021-02-23 Thread GitBox
potiuk commented on pull request #11950: URL: https://github.com/apache/airflow/pull/11950#issuecomment-784542480 Yep. I think the same. If we cannot make snowflake and beam py3.9 compliant, we should exclude them from community managed providers. I hope it will not happen and this thread

[GitHub] [airflow] ashb commented on pull request #11950: Add Python 3.9 to supported versions

2021-02-23 Thread GitBox
ashb commented on pull request #11950: URL: https://github.com/apache/airflow/pull/11950#issuecomment-784540464 > > i.e. it seems sub optimal to require that every provider support the new python version before airflow can be updated as that could lead to less popular providers blocking th

[GitHub] [airflow] potiuk commented on issue #13226: Use of SQLAInterface in custom models in Plugins

2021-02-23 Thread GitBox
potiuk commented on issue #13226: URL: https://github.com/apache/airflow/issues/13226#issuecomment-784537783 Simply import ogf the old SQLAInterface should tirgger a warning This is an automated message from the Apache Git S

[airflow] branch v1-10-stable updated: Fix permission error on non-POSIX filesystem (#13121) (#14383)

2021-02-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v1-10-stable in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-stable by this push: new e8008f5 Fix permission error on no

[GitHub] [airflow] potiuk merged pull request #14383: Fix permission error on non-POSIX filesystem (#13121)

2021-02-23 Thread GitBox
potiuk merged pull request #14383: URL: https://github.com/apache/airflow/pull/14383 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on issue #14396: Make context less nebulous

2021-02-23 Thread GitBox
potiuk commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-784529351 I think context as a ductionary is pretty sound. Dataclass is not pythonic at all and makes it difficult to evolve. I think it's very pythonic to have dictionaries in Python and it

[GitHub] [airflow] potiuk commented on pull request #11950: Add Python 3.9 to supported versions

2021-02-23 Thread GitBox
potiuk commented on pull request #11950: URL: https://github.com/apache/airflow/pull/11950#issuecomment-784527287 > i.e. it seems sub optimal to require that every provider support the new python version before airflow can be updated as that could lead to less popular providers blocking th

[GitHub] [airflow] potiuk commented on pull request #14397: Add Ephraim to Committers List

2021-02-23 Thread GitBox
potiuk commented on pull request #14397: URL: https://github.com/apache/airflow/pull/14397#issuecomment-784519255 Wohoo! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [airflow] github-actions[bot] commented on pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14400: URL: https://github.com/apache/airflow/pull/14400#issuecomment-784519087 [The Workflow run](https://github.com/apache/airflow/actions/runs/593913873) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[airflow] branch master updated (4c35955 -> 277f7c9)

2021-02-23 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4c35955 Add Ephraim to Committers List (#14397) add 277f7c9 Add Ephraim as a Code Owner for the Stable REST A

[GitHub] [airflow] potiuk merged pull request #14401: Add Ephraim as a Code Owner for the Stable REST API

2021-02-23 Thread GitBox
potiuk merged pull request #14401: URL: https://github.com/apache/airflow/pull/14401 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] zachliu commented on issue #13799: Scheduler crashes when unpausing some dags with: TypeError: '>' not supported between instances of 'NoneType' and 'int'

2021-02-23 Thread GitBox
zachliu commented on issue #13799: URL: https://github.com/apache/airflow/issues/13799#issuecomment-784517097 i'm glad i found this before opening another issue :joy: **Apache Airflow version**: 2.0.1 **What happened**: ```python >>> import requests >>> from reque

[GitHub] [airflow] github-actions[bot] commented on pull request #14401: Add Ephraim as a Code Owner for the Stable REST API

2021-02-23 Thread GitBox
github-actions[bot] commented on pull request #14401: URL: https://github.com/apache/airflow/pull/14401#issuecomment-784512459 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] kaxil opened a new pull request #14401: Add Ephraim as a Code Owner for the Stable REST API

2021-02-23 Thread GitBox
kaxil opened a new pull request #14401: URL: https://github.com/apache/airflow/pull/14401 Ephraim already does most of the API reviews so would be good to add him to it --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.c

[airflow] branch master updated (c281979 -> 4c35955)

2021-02-23 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from c281979 Documentation and example dag for CloudDLPDeidentifyContentOperator, GCSObjectExistenceSensor, GCSObje

[GitHub] [airflow] kaxil merged pull request #14397: Add Ephraim to Committers List

2021-02-23 Thread GitBox
kaxil merged pull request #14397: URL: https://github.com/apache/airflow/pull/14397 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ephraimbuddy commented on pull request #14313: Fix wasb task handler py

2021-02-23 Thread GitBox
ephraimbuddy commented on pull request #14313: URL: https://github.com/apache/airflow/pull/14313#issuecomment-784496125 @kurtqq Thanks for the mention. I think what we should change is replace `readall` in hook.read_file with `content_as_text(max_concurrency=1, encoding='UTF-8')`. ht

[GitHub] [airflow] digitalsimboja commented on a change in pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
digitalsimboja commented on a change in pull request #14400: URL: https://github.com/apache/airflow/pull/14400#discussion_r581369316 ## File path: airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py ## @@ -0,0 +1,29 @@ + +from airflow.upgrade.rules.base_rule import Ba

[GitHub] [airflow] turbaszek commented on a change in pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
turbaszek commented on a change in pull request #14400: URL: https://github.com/apache/airflow/pull/14400#discussion_r581362910 ## File path: airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py ## @@ -0,0 +1,29 @@ + +from airflow.upgrade.rules.base_rule import BaseRul

[GitHub] [airflow] turbaszek commented on a change in pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
turbaszek commented on a change in pull request #14400: URL: https://github.com/apache/airflow/pull/14400#discussion_r581362910 ## File path: airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py ## @@ -0,0 +1,29 @@ + +from airflow.upgrade.rules.base_rule import BaseRul

[GitHub] [airflow] turbaszek commented on a change in pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
turbaszek commented on a change in pull request #14400: URL: https://github.com/apache/airflow/pull/14400#discussion_r581362079 ## File path: airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py ## @@ -0,0 +1,29 @@ + +from airflow.upgrade.rules.base_rule import BaseRul

[GitHub] [airflow] turbaszek commented on a change in pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
turbaszek commented on a change in pull request #14400: URL: https://github.com/apache/airflow/pull/14400#discussion_r581361267 ## File path: airflow/upgrade/rules/fix_conf_not_importable_from_airflow.py ## @@ -0,0 +1,29 @@ + +from airflow.upgrade.rules.base_rule import BaseRul

[GitHub] [airflow] digitalsimboja opened a new pull request #14400: Fix conf import from airflow #13945

2021-02-23 Thread GitBox
digitalsimboja opened a new pull request #14400: URL: https://github.com/apache/airflow/pull/14400 This rule checks to ensure user properly imports "conf" to be compatible with Airflow 2.0 --- **^ Add meaningful description above** Read the **[Pull Request Guid

[GitHub] [airflow] FloChehab commented on issue #13643: Improve annotations customization in the chart

2021-02-23 Thread GitBox
FloChehab commented on issue #13643: URL: https://github.com/apache/airflow/issues/13643#issuecomment-784482952 Hello, just wanted to let you now that I should have time to work on this issue in couple of weeks. This is an a

[GitHub] [airflow] FloChehab commented on issue #11707: Manage pools in Helm Chart

2021-02-23 Thread GitBox
FloChehab commented on issue #11707: URL: https://github.com/apache/airflow/issues/11707#issuecomment-784482916 Hello, just wanted to let you now that I should have time to work on this issue in couple of weeks. This is an a

[GitHub] [airflow] XD-DENG commented on pull request #14391: flower 0.9.5 does not require rewrite on nginx

2021-02-23 Thread GitBox
XD-DENG commented on pull request #14391: URL: https://github.com/apache/airflow/pull/14391#issuecomment-784478522 hi @brunokloss , may you please provide the link the corresponding changelog of flower relating to this change? This would be helpful for the review -

[GitHub] [airflow] ecerulm commented on pull request #14399: Avoid using threads in S3 remote logging

2021-02-23 Thread GitBox
ecerulm commented on pull request #14399: URL: https://github.com/apache/airflow/pull/14399#issuecomment-784474383 I've tested this by creating a new docker image with the changes: ``` FROM apache/airflow:2.0.1 COPY airflow /home/airflow/.local/lib/python3.6/site-packages/airflow

[GitHub] [airflow] sarahamilton commented on a change in pull request #14074: Fixes Issue #14073 - GoogleDisplayVideo360CreateSDFDownloadTaskOperator does not push necessary xcom

2021-02-23 Thread GitBox
sarahamilton commented on a change in pull request #14074: URL: https://github.com/apache/airflow/pull/14074#discussion_r581332634 ## File path: airflow/providers/google/marketing_platform/hooks/display_video.py ## @@ -228,7 +228,7 @@ def get_sdf_download_operation(self, operat

[airflow] branch constraints-master updated: Updating constraints. Build id:593456406

2021-02-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-master by this push: new 23a3a6a Updating

[GitHub] [airflow] kurtqq commented on pull request #14313: Fix wasb task handler py

2021-02-23 Thread GitBox
kurtqq commented on pull request #14313: URL: https://github.com/apache/airflow/pull/14313#issuecomment-784442824 probably a good idea to tag the creator of the PR that cause it @ephraimbuddy This is an automated message

[GitHub] [airflow] ecerulm opened a new pull request #14399: Avoid using threads in S3 remote logging

2021-02-23 Thread GitBox
ecerulm opened a new pull request #14399: URL: https://github.com/apache/airflow/pull/14399 This prevents `RuntimeError: cannot schedule new futures after interpreter shutdown` as described in #14089. Closes: #14089 --- **^ Add meaningful description above**

  1   2   3   >