[GitHub] [airflow] iremonur commented on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur commented on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813231876 Thank you, it would be great ! Could you share the link related to the issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [airflow] iremonur commented on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur commented on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried schedule to another tasks to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutorial_v2.

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] alexInhert commented on issue #15198: "cannot import make_kwargs_callable" occurs when using airflow.providers.http.operators.http in 1.10.14.

2021-04-05 Thread GitBox
alexInhert commented on issue #15198: URL: https://github.com/apache/airflow/issues/15198#issuecomment-813259788 This is an issue for me too. It's a blocker for migration to Airflow 2. The backport HTTP provider is not working because of this. `make_kwargs_callable` should be added

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] iremonur opened a new issue #15202: SCHEDULER SKIPS SOME SCHEDULED TASKS

2021-04-05 Thread GitBox
iremonur opened a new issue #15202: URL: https://github.com/apache/airflow/issues/15202 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutorial_v2.py), I set: -> start_

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 19:50. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 20.00. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] iremonur edited a comment on issue #15192: SCHEDULED TASKS ARE STUCK IN THE STATE OF "RUNNING"

2021-04-05 Thread GitBox
iremonur edited a comment on issue #15192: URL: https://github.com/apache/airflow/issues/15192#issuecomment-813236049 Actually, I tried to schedule another task to be 10 minutes between each other, I want the first task to start at 20.00. In the dag code (located in ~/airflow/dags/tutori

[GitHub] [airflow] XD-DENG merged pull request #15200: Fix string concatenation using `f-strings`

2021-04-05 Thread GitBox
XD-DENG merged pull request #15200: URL: https://github.com/apache/airflow/pull/15200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[airflow] branch master updated (e86f5ca -> 266384a)

2021-04-05 Thread xddeng
This is an automated email from the ASF dual-hosted git repository. xddeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from e86f5ca Bugfix: Task docs are not shown in the Task Instance Detail View (#15191) add 266384a Fix string con

[GitHub] [airflow] XD-DENG commented on issue #15193: CLI `kubernetes cleanup-pods` should allow "only clean up Pods created by Airflow"

2021-04-05 Thread GitBox
XD-DENG commented on issue #15193: URL: https://github.com/apache/airflow/issues/15193#issuecomment-813297611 CC @kaxil @ashb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [airflow] ephraimbuddy closed issue #14830: Add Create/Update/Delete API endpoints for Roles

2021-04-05 Thread GitBox
ephraimbuddy closed issue #14830: URL: https://github.com/apache/airflow/issues/14830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [airflow] ephraimbuddy merged pull request #14840: Add CUD REST API endpoints for Roles

2021-04-05 Thread GitBox
ephraimbuddy merged pull request #14840: URL: https://github.com/apache/airflow/pull/14840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[airflow] branch master updated: Add CUD REST API endpoints for Roles (#14840)

2021-04-05 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 6706b67 Add CUD REST API endpoints fo

[GitHub] [airflow] bintocher commented on issue #15066: try to open admin->xcom and get error message

2021-04-05 Thread GitBox
bintocher commented on issue #15066: URL: https://github.com/apache/airflow/issues/15066#issuecomment-813303623 ![image](https://user-images.githubusercontent.com/8188055/113560180-ed1de000-9645-11eb-964a-d9da45f8ca43.png) ![image](https://user-images.githubusercontent.com/8188055/11356

[GitHub] [airflow] XD-DENG commented on a change in pull request #15197: Bugfix: Fix overriding `pod_template_file` in KubernetesExecutor

2021-04-05 Thread GitBox
XD-DENG commented on a change in pull request #15197: URL: https://github.com/apache/airflow/pull/15197#discussion_r607011484 ## File path: tests/executors/test_kubernetes_executor.py ## @@ -215,6 +217,79 @@ def test_invalid_executor_config(self, mock_get_kube_client, mock_kub

[GitHub] [airflow] RosterIn commented on a change in pull request #14521: Add Asana Provider

2021-04-05 Thread GitBox
RosterIn commented on a change in pull request #14521: URL: https://github.com/apache/airflow/pull/14521#discussion_r607022810 ## File path: airflow/providers/asana/operators/asana_tasks.py ## @@ -0,0 +1,188 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813330384 @mik-laj - I need your help here. I can't understand why the docs-build fail with missing `trino_to_gcs` :(. It looks like I have everything right ... but it fails ... -- T

[GitHub] [airflow] mik-laj commented on issue #15193: CLI `kubernetes cleanup-pods` should allow "only clean up Pods created by Airflow"

2021-04-05 Thread GitBox
mik-laj commented on issue #15193: URL: https://github.com/apache/airflow/issues/15193#issuecomment-813330915 in my opinion this is a bug and by default we should only manage pods created by Airflow i.e. we don't need extra option. -- This is an automated message from the Apache Git Ser

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] XD-DENG commented on issue #15193: CLI `kubernetes cleanup-pods` should allow "only clean up Pods created by Airflow"

2021-04-05 Thread GitBox
XD-DENG commented on issue #15193: URL: https://github.com/apache/airflow/issues/15193#issuecomment-81133 That's my first thought as well, but I would like to hear the original author's opinion, like if there is any specific reason or not This feature was added in https://github

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] potiuk commented on a change in pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on a change in pull request #15187: URL: https://github.com/apache/airflow/pull/15187#discussion_r607024725 ## File path: scripts/ci/docker-compose/integration-trino.yml ## @@ -17,10 +17,10 @@ --- version: "2.2" services: - presto: -image: apache/airflo

[GitHub] [airflow] mik-laj commented on a change in pull request #11802: Add Kubernetes cleanup-pods CLI command for Helm Chart

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #11802: URL: https://github.com/apache/airflow/pull/11802#discussion_r607034452 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -61,3 +64,66 @@ def generate_pod_yaml(args): sanitized_pod = api_client.sani

[GitHub] [airflow] kaxil merged pull request #15199: Bugfix: resources in `executor_config` breaks Graph View in UI

2021-04-05 Thread GitBox
kaxil merged pull request #15199: URL: https://github.com/apache/airflow/pull/15199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] kaxil closed issue #14327: Kubernetes Objects are not serializable and break Graph View in UI

2021-04-05 Thread GitBox
kaxil closed issue #14327: URL: https://github.com/apache/airflow/issues/14327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[airflow] branch master updated: Bugfix: resources in `executor_config` breaks Graph View in UI (#15199)

2021-04-05 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 7b577c3 Bugfix: resources in `executor_conf

[airflow] branch master updated: Update import path and fix typo in `dag-run.rst` (#15201)

2021-04-05 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 4099108 Update import path and fix typo in

[GitHub] [airflow] kaxil merged pull request #15201: update import path and fix typo in `dag-run.rst`

2021-04-05 Thread GitBox
kaxil merged pull request #15201: URL: https://github.com/apache/airflow/pull/15201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] github-actions[bot] commented on pull request #15201: update import path and fix typo in `dag-run.rst`

2021-04-05 Thread GitBox
github-actions[bot] commented on pull request #15201: URL: https://github.com/apache/airflow/pull/15201#issuecomment-813354819 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk commented on issue #15193: CLI `kubernetes cleanup-pods` should allow "only clean up Pods created by Airflow"

2021-04-05 Thread GitBox
potiuk commented on issue #15193: URL: https://github.com/apache/airflow/issues/15193#issuecomment-813363371 > in my opinion this is a bug and by default we should only manage pods created by Airflow i.e. we don't need extra option. My thoughts exactly! -- This is an automated mes

[GitHub] [airflow] kaxil commented on a change in pull request #15197: Bugfix: Fix overriding `pod_template_file` in KubernetesExecutor

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15197: URL: https://github.com/apache/airflow/pull/15197#discussion_r607065015 ## File path: airflow/kubernetes_executor_templates/basic_template.yaml ## @@ -69,8 +69,8 @@ spec: defaultMode: 420 restartPolicy: Never te

[GitHub] [airflow] kaxil commented on a change in pull request #15197: Bugfix: Fix overriding `pod_template_file` in KubernetesExecutor

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15197: URL: https://github.com/apache/airflow/pull/15197#discussion_r607065015 ## File path: airflow/kubernetes_executor_templates/basic_template.yaml ## @@ -69,8 +69,8 @@ spec: defaultMode: 420 restartPolicy: Never te

[GitHub] [airflow] potiuk closed pull request #15089: Added azure postgres connection url format

2021-04-05 Thread GitBox
potiuk closed pull request #15089: URL: https://github.com/apache/airflow/pull/15089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [airflow] potiuk commented on pull request #15089: Added azure postgres connection url format

2021-04-05 Thread GitBox
potiuk commented on pull request #15089: URL: https://github.com/apache/airflow/pull/15089#issuecomment-813371373 I looked at it again, and this PR proposal is actually wrong. The URI you are trying to use is wrong. We actually even have a detailed description about this in http://

[GitHub] [airflow] potiuk edited a comment on pull request #15089: Added azure postgres connection url format

2021-04-05 Thread GitBox
potiuk edited a comment on pull request #15089: URL: https://github.com/apache/airflow/pull/15089#issuecomment-813371373 I looked at it again, and this PR proposal is actually wrong. The URI you are trying to use is wrong. We actually even have a detailed description about this in

[GitHub] [airflow] kaxil commented on issue #15193: CLI `kubernetes cleanup-pods` should allow "only clean up Pods created by Airflow"

2021-04-05 Thread GitBox
kaxil commented on issue #15193: URL: https://github.com/apache/airflow/issues/15193#issuecomment-813371827 Hey, thanks for this issue @XD-DENG . I added this feature and we use it in Astronomer too -- to cleanup any hanging PODs and their sidecars. So yeah we can just restrict it to pod l

[GitHub] [airflow] potiuk edited a comment on pull request #15089: Added azure postgres connection url format

2021-04-05 Thread GitBox
potiuk edited a comment on pull request #15089: URL: https://github.com/apache/airflow/pull/15089#issuecomment-813371373 I looked at it again, and this PR proposal is actually wrong. The URI you are trying to use is wrong. We actually even have a detailed description about this in

[GitHub] [airflow] kaxil commented on a change in pull request #11802: Add Kubernetes cleanup-pods CLI command for Helm Chart

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #11802: URL: https://github.com/apache/airflow/pull/11802#discussion_r607066267 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -61,3 +64,66 @@ def generate_pod_yaml(args): sanitized_pod = api_client.saniti

[GitHub] [airflow] potiuk edited a comment on pull request #15089: Added azure postgres connection url format

2021-04-05 Thread GitBox
potiuk edited a comment on pull request #15089: URL: https://github.com/apache/airflow/pull/15089#issuecomment-813371373 I looked at it again, and this PR proposal is actually wrong. The URI you are trying to use is wrong. We actually even have a detailed description about this in

[GitHub] [airflow] potiuk edited a comment on pull request #15089: Added azure postgres connection url format

2021-04-05 Thread GitBox
potiuk edited a comment on pull request #15089: URL: https://github.com/apache/airflow/pull/15089#issuecomment-813371373 I looked at it again, and this PR proposal is actually wrong. The URI you are trying to use is not correct according to URI specfication. We actually even have a

[GitHub] [airflow] XD-DENG commented on issue #15193: CLI `kubernetes cleanup-pods` should allow "only clean up Pods created by Airflow"

2021-04-05 Thread GitBox
XD-DENG commented on issue #15193: URL: https://github.com/apache/airflow/issues/15193#issuecomment-813372813 Thanks everyone. I think we have come to a consensus. So I will change `kind: feature` to `kind: bug` and work on this later. -- This is an automated message from the Apac

[GitHub] [airflow] potiuk commented on pull request #15153: Merges quarantined tests into single job

2021-04-05 Thread GitBox
potiuk commented on pull request #15153: URL: https://github.com/apache/airflow/pull/15153#issuecomment-813376259 That's even nicer. The quarantined tests worked when combined on my "Public Runners" and they run in ~ 15 - 25 minutes (some quarantined tests hangs for longer sometimes). htt

[GitHub] [airflow] kaxil commented on a change in pull request #15197: Bugfix: Fix overriding `pod_template_file` in KubernetesExecutor

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15197: URL: https://github.com/apache/airflow/pull/15197#discussion_r607088711 ## File path: tests/executors/test_kubernetes_executor.py ## @@ -215,6 +217,79 @@ def test_invalid_executor_config(self, mock_get_kube_client, mock_kuber

[GitHub] [airflow] bperson opened a new pull request #15203: Task Instance model: allow pool names >50 chars

2021-04-05 Thread GitBox
bperson opened a new pull request #15203: URL: https://github.com/apache/airflow/pull/15203 Found while working on #14476: `slot_pool` was migrated to support 256 chars long pool names in #7658, but not the `task_instance` model, which means we can create those pools but not really use the

[GitHub] [airflow] eladkal commented on pull request #13405: KubernetesPodOperator Guide

2021-04-05 Thread GitBox
eladkal commented on pull request #13405: URL: https://github.com/apache/airflow/pull/13405#issuecomment-813406151 @VBhojawala can you take a look at the failing doc build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] XD-DENG opened a new pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
XD-DENG opened a new pull request #15204: URL: https://github.com/apache/airflow/pull/15204 closes: #15193 Currently condition `if the pod is created by Airflow` is not considered. This commit fixes this. We decide if the Pod is created by Airflow via checking if it has all th

[GitHub] [airflow] mik-laj commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607111232 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -91,9 +91,24 @@ def cleanup_pods(args): kube_client = get_kube_client() print(f

[GitHub] [airflow] mik-laj commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607111232 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -91,9 +91,24 @@ def cleanup_pods(args): kube_client = get_kube_client() print(f

[GitHub] [airflow] codenamestif commented on pull request #15173: read timestamp from Cloudwatch events

2021-04-05 Thread GitBox
codenamestif commented on pull request #15173: URL: https://github.com/apache/airflow/pull/15173#issuecomment-813424002 I've checked the default formatting of the timestamp in logs. Basically timestamp is formatted based on UTC regardless what timezones are specified in the config. So I de

[GitHub] [airflow] ByPort opened a new issue #15205: Add setting up using VS Code to CONTRIBUTORS_QUICK_START.rst

2021-04-05 Thread GitBox
ByPort opened a new issue #15205: URL: https://github.com/apache/airflow/issues/15205 **Description** In the CONTRIBUTORS_QUICK_START.rst (and not only there) I can see some parts that are tied to PyCharm. There is nothing complicated and specific to PyCharm, but I can understand th

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15205: Add setting up using VS Code to CONTRIBUTORS_QUICK_START.rst

2021-04-05 Thread GitBox
boring-cyborg[bot] commented on issue #15205: URL: https://github.com/apache/airflow/issues/15205#issuecomment-813427696 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] SamWheating commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
SamWheating commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607127192 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific la

[GitHub] [airflow] XD-DENG commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
XD-DENG commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607127273 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -91,9 +91,24 @@ def cleanup_pods(args): kube_client = get_kube_client() print(f

[GitHub] [airflow] SamWheating commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
SamWheating commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607128196 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific la

[GitHub] [airflow] mik-laj opened a new pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
mik-laj opened a new pull request #15206: URL: https://github.com/apache/airflow/pull/15206 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more i

[GitHub] [airflow] mik-laj commented on a change in pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15206: URL: https://github.com/apache/airflow/pull/15206#discussion_r607132519 ## File path: airflow/cli/commands/info_command.py ## @@ -27,11 +27,11 @@ import requests import tenacity +from typing_extensions import Protocol

[GitHub] [airflow] mik-laj commented on a change in pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15206: URL: https://github.com/apache/airflow/pull/15206#discussion_r607132747 ## File path: airflow/providers/google/cloud/utils/credentials_provider.py ## @@ -36,10 +35,13 @@ from airflow.utils.log.logging_mixin import LoggingMi

[GitHub] [airflow] mik-laj commented on a change in pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15206: URL: https://github.com/apache/airflow/pull/15206#discussion_r607133504 ## File path: airflow/providers/qubole/hooks/qubole.py ## @@ -103,6 +103,8 @@ def build_command_args() -> Tuple[Dict[str, list], list]: return comm

[GitHub] [airflow] mik-laj commented on a change in pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15206: URL: https://github.com/apache/airflow/pull/15206#discussion_r607133875 ## File path: airflow/sensors/base.py ## @@ -322,9 +321,3 @@ def mode_setter(_, value): return cls_type return decorate(cls) - - -if 'BU

[GitHub] [airflow] mik-laj commented on a change in pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15206: URL: https://github.com/apache/airflow/pull/15206#discussion_r607135114 ## File path: docs/exts/docs_build/run_patched_sphinx.py ## @@ -0,0 +1,220 @@ +#!/usr/bin/env python +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [airflow] github-actions[bot] commented on pull request #15206: [WIP] Bump sphinx-autoapi from 1.0.0 to 1.7.5

2021-04-05 Thread GitBox
github-actions[bot] commented on pull request #15206: URL: https://github.com/apache/airflow/pull/15206#issuecomment-813438922 [The Workflow run](https://github.com/apache/airflow/actions/runs/719514094) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] andrewgodwin commented on a change in pull request #15142: Add support for labelling DAG edges (WIP)

2021-04-05 Thread GitBox
andrewgodwin commented on a change in pull request #15142: URL: https://github.com/apache/airflow/pull/15142#discussion_r607138030 ## File path: airflow/models/edgemodifier.py ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [airflow] mik-laj commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607138403 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -90,7 +90,25 @@ def cleanup_pods(args): print('Loading Kubernetes configuration')

[GitHub] [airflow] mik-laj commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
mik-laj commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607138403 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -90,7 +90,25 @@ def cleanup_pods(args): print('Loading Kubernetes configuration')

[GitHub] [airflow] dimberman closed issue #13006: Setting in_cluster to True is failing with invalid kube config

2021-04-05 Thread GitBox
dimberman closed issue #13006: URL: https://github.com/apache/airflow/issues/13006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] dimberman commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
dimberman commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607142879 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific lang

[GitHub] [airflow] andrewgodwin commented on a change in pull request #15142: Add support for labelling DAG edges (WIP)

2021-04-05 Thread GitBox
andrewgodwin commented on a change in pull request #15142: URL: https://github.com/apache/airflow/pull/15142#discussion_r607143797 ## File path: airflow/serialization/schema.json ## @@ -102,7 +102,8 @@ "_task_group": {"anyOf": [ { "type": "null" },

[GitHub] [airflow] github-actions[bot] commented on pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
github-actions[bot] commented on pull request #15204: URL: https://github.com/apache/airflow/pull/15204#issuecomment-813446902 [The Workflow run](https://github.com/apache/airflow/actions/runs/719570810) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] dimberman commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
dimberman commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607147803 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific lang

[GitHub] [airflow] potiuk commented on issue #15205: Add setting up using VS Code to CONTRIBUTORS_QUICK_START.rst

2021-04-05 Thread GitBox
potiuk commented on issue #15205: URL: https://github.com/apache/airflow/issues/15205#issuecomment-813456449 @ByPort absolutely - feel free to submit a PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [airflow] mik-laj commented on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
mik-laj commented on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813457835 > It looks like I have everything right ... but it fails ... It is true. You have the correct code, but the cache contains outdated information. To prevent such problem

[GitHub] [airflow] mik-laj edited a comment on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
mik-laj edited a comment on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813457835 > It looks like I have everything right ... but it fails ... It is true. You have the correct code, but the cache contains outdated information. To prevent such

[GitHub] [airflow] mik-laj edited a comment on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
mik-laj edited a comment on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813457835 > It looks like I have everything right ... but it fails ... It is true. You have the correct code, but the cache contains outdated information. To prevent such

[GitHub] [airflow] XD-DENG commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
XD-DENG commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607159566 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -90,7 +90,25 @@ def cleanup_pods(args): print('Loading Kubernetes configuration')

[GitHub] [airflow] github-actions[bot] commented on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
github-actions[bot] commented on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813466426 [The Workflow run](https://github.com/apache/airflow/actions/runs/719636407) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] kaxil merged pull request #15197: Bugfix: Fix overriding `pod_template_file` in KubernetesExecutor

2021-04-05 Thread GitBox
kaxil merged pull request #15197: URL: https://github.com/apache/airflow/pull/15197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] kaxil closed pull request #14199: Updates example/docs related to overriding the pod_template_file to m…

2021-04-05 Thread GitBox
kaxil closed pull request #14199: URL: https://github.com/apache/airflow/pull/14199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[airflow] branch master updated (4099108 -> 5606137)

2021-04-05 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4099108 Update import path and fix typo in `dag-run.rst` (#15201) add 5606137 Bugfix: Fix overriding `pod_

[GitHub] [airflow] potiuk commented on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk commented on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813473087 > It is true. You have the correct code, but the cache contains outdated information. To prevent such problems, we build documentation twice in some situations (see: [#12527 (

[GitHub] [airflow] potiuk edited a comment on pull request #15187: Adds 'Trino' provider (with lower memory footprint for tests)

2021-04-05 Thread GitBox
potiuk edited a comment on pull request #15187: URL: https://github.com/apache/airflow/pull/15187#issuecomment-813473087 > It is true. You have the correct code, but the cache contains outdated information. To prevent such problems, we build documentation twice in some situations (see: [#1

[GitHub] [airflow] kaxil commented on a change in pull request #15204: BugFix: CLI 'kubernetes cleanup-pods' should only clean up Airflow-created Pods

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15204: URL: https://github.com/apache/airflow/pull/15204#discussion_r607172542 ## File path: airflow/cli/commands/kubernetes_command.py ## @@ -90,7 +90,23 @@ def cleanup_pods(args): print('Loading Kubernetes configuration')

[GitHub] [airflow] kaxil commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607177156 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific language

[GitHub] [airflow] kaxil commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607177156 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific language

[GitHub] [airflow] kaxil commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607178652 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific language

[GitHub] [airflow] kaxil commented on a change in pull request #15165: Separate pod_launcher from core airflow

2021-04-05 Thread GitBox
kaxil commented on a change in pull request #15165: URL: https://github.com/apache/airflow/pull/15165#discussion_r607178652 ## File path: airflow/kubernetes/pod_launcher.py ## @@ -14,283 +15,15 @@ # KIND, either express or implied. See the License for the # specific language

[GitHub] [airflow] andrewgodwin opened a new pull request #15207: Fixed #14270: Add error message in OOM situations

2021-04-05 Thread GitBox
andrewgodwin opened a new pull request #15207: URL: https://github.com/apache/airflow/pull/15207 In the case where a child process is reaped early (before we get to it) the presumption in the code is that it is due to an OOM error and we set the return code -9. This adds an error message a

[GitHub] [airflow] jedcunningham opened a new pull request #15208: Fix missing on_load trigger for folder-based plugins

2021-04-05 Thread GitBox
jedcunningham opened a new pull request #15208: URL: https://github.com/apache/airflow/pull/15208 This is resurrecting #10878 by @maiorBoltach, slightly simplified and with more comprehensive test coverage. Method 'on_load' should run on plugins initialization, that are located in p

[GitHub] [airflow] jedcunningham commented on a change in pull request #15208: Fix missing on_load trigger for folder-based plugins

2021-04-05 Thread GitBox
jedcunningham commented on a change in pull request #15208: URL: https://github.com/apache/airflow/pull/15208#discussion_r607185961 ## File path: airflow/plugins_manager.py ## @@ -184,13 +184,23 @@ def is_valid_plugin(plugin_obj): return False +def register_plugin(plug

  1   2   3   >