[GitHub] [airflow] yuqian90 commented on issue #14205: Scheduler "deadlocks" itself when max_active_runs_per_dag is reached by up_for_retry tasks

2021-05-04 Thread GitBox
yuqian90 commented on issue #14205: URL: https://github.com/apache/airflow/issues/14205#issuecomment-832457091 The symptom I'm seeing is that whenever any single DAG hits the `max_active_runs_per_dag` limit, the scheduler log will be full of lines like this. At this point, the scheduler ba

[GitHub] [airflow] feluelle commented on a change in pull request #15609: Remove the `not-allow-trailing-slash` rule on S3_hook

2021-05-04 Thread GitBox
feluelle commented on a change in pull request #15609: URL: https://github.com/apache/airflow/pull/15609#discussion_r626270614 ## File path: airflow/providers/amazon/aws/hooks/s3.py ## @@ -143,9 +143,9 @@ def parse_s3_url(s3url: str) -> Tuple[str, str]: raise Airfl

[GitHub] [airflow] github-actions[bot] commented on pull request #15665: relax python-telegram-bot

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15665: URL: https://github.com/apache/airflow/pull/15665#issuecomment-832434992 [The Workflow run](https://github.com/apache/airflow/actions/runs/812373761) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] YiiTing removed a comment on issue #14352: Airflow2.0 cannot read remote log from GCP GCS

2021-05-04 Thread GitBox
YiiTing removed a comment on issue #14352: URL: https://github.com/apache/airflow/issues/14352#issuecomment-831062244 Hi all, i have some problems here is my UI log `*** Reading remote log from gs://airflow-log/inspect_apii/main.inspect_p/2021-05-03T06:40:00+00:00/1.log. b'*

[GitHub] [airflow] github-actions[bot] commented on pull request #15624: Allows overriding versioned dirs when publishing documentation

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15624: URL: https://github.com/apache/airflow/pull/15624#issuecomment-832424970 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] RosterIn opened a new pull request #15665: relax python-telegram-bot

2021-05-04 Thread GitBox
RosterIn opened a new pull request #15665: URL: https://github.com/apache/airflow/pull/15665 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] potiuk commented on pull request #15624: Allows overriding versioned dirs when publishing documentation

2021-05-04 Thread GitBox
potiuk commented on pull request #15624: URL: https://github.com/apache/airflow/pull/15624#issuecomment-832422489 @mik-laj ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[airflow] branch master updated: More verbose logs when running `airflow check_migrations` (#15662)

2021-05-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 86ad628 More verbose logs when running `airflo

[GitHub] [airflow] potiuk merged pull request #15662: More verbose logs when running `airflow check_migrations`

2021-05-04 Thread GitBox
potiuk merged pull request #15662: URL: https://github.com/apache/airflow/pull/15662 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [airflow] potiuk closed issue #15650: Docs: check_migrations more verbose documentation

2021-05-04 Thread GitBox
potiuk closed issue #15650: URL: https://github.com/apache/airflow/issues/15650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please con

[GitHub] [airflow] potiuk merged pull request #15661: Add --executor option to breeze kind-cluster deploy command

2021-05-04 Thread GitBox
potiuk merged pull request #15661: URL: https://github.com/apache/airflow/pull/15661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[airflow] branch master updated: Add --executor option to breeze kind-cluster deploy command (#15661)

2021-05-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new e47f7e4 Add --executor option to breeze kind-c

[GitHub] [airflow] potiuk merged pull request #15663: Fix building assets on ``breeze start-airflow``

2021-05-04 Thread GitBox
potiuk merged pull request #15663: URL: https://github.com/apache/airflow/pull/15663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[airflow] branch master updated: Fix building assets on ``breeze start-airflow`` (#15663)

2021-05-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 60a3da6 Fix building assets on ``breeze start-

[GitHub] [airflow] jhtimmins commented on pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
jhtimmins commented on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-832389073 @ashb This looks good to go. Are you still waiting on a review from anyone? -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] Isaacwhyuenac opened a new issue #15664: Airflow Implicit rule on removing S3 path trailing slash

2021-05-04 Thread GitBox
Isaacwhyuenac opened a new issue #15664: URL: https://github.com/apache/airflow/issues/15664 Hi, I found the behaviour that removes [the trailing slash on S3 path](https://github.com/apache/airflow/blob/a0eb747b8d73f71dcf471917e013669a660cd4dd/airflow/providers/amazon/aws/hooks/s3.py#L146)

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15664: Airflow Implicit rule on removing S3 path trailing slash

2021-05-04 Thread GitBox
boring-cyborg[bot] commented on issue #15664: URL: https://github.com/apache/airflow/issues/15664#issuecomment-832383376 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] github-actions[bot] commented on pull request #14603: Support jinja2 native Python types

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #14603: URL: https://github.com/apache/airflow/pull/14603#issuecomment-832375379 [The Workflow run](https://github.com/apache/airflow/actions/runs/812030168) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] kaxil opened a new pull request #15663: Fix building assets on ``breeze start-airflow``

2021-05-04 Thread GitBox
kaxil opened a new pull request #15663: URL: https://github.com/apache/airflow/pull/15663 Error because `webpack` is not install because `yarn install --frozen-lockfile` is not run: ``` root@f5fc5cfc9a43:/opt/airflow# cd /opt/airflow/airflow/www/; yarn dev yarn run v1.22.5 $

[GitHub] [airflow] kaxil commented on pull request #14603: Support jinja2 native Python types

2021-05-04 Thread GitBox
kaxil commented on pull request #14603: URL: https://github.com/apache/airflow/pull/14603#issuecomment-832365079 > Sure, I guess this will work and it's unlikely people will want to mix them in one dag? Not sure. > > Docs now please! Done in https://github.com/apache/airflow/

[GitHub] [airflow] aquam8 edited a comment on issue #11979: Support helm install --wait for the chart

2021-05-04 Thread GitBox
aquam8 edited a comment on issue #11979: URL: https://github.com/apache/airflow/issues/11979#issuecomment-831663761 Hi, First of all, let me thank you for this project and your involvement in this awesome project. Now onto this issue.. I have come to realise that this is also

[airflow] branch master updated (d723ba5 -> a0eb747)

2021-05-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from d723ba5 Fix log persistence with KubernetesExecutor (#15659) add a0eb747 Fix dags table overflow (#15660)

[GitHub] [airflow] kaxil merged pull request #15660: Fix dags table overflow

2021-05-04 Thread GitBox
kaxil merged pull request #15660: URL: https://github.com/apache/airflow/pull/15660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] kaxil closed issue #15656: Scrolling issue with new fast trigger with single DAG

2021-05-04 Thread GitBox
kaxil closed issue #15656: URL: https://github.com/apache/airflow/issues/15656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [airflow] kaxil opened a new pull request #15662: More verbose logs when running `airflow check_migrations`

2021-05-04 Thread GitBox
kaxil opened a new pull request #15662: URL: https://github.com/apache/airflow/pull/15662 Currently it just shows "TimeoutError: There are still unapplied migrations after 60 seconds. " which is not that helpful. This commit adds more info to show the difference in migrations in DB a

[GitHub] [airflow] cdibble commented on pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
cdibble commented on pull request #15659: URL: https://github.com/apache/airflow/pull/15659#issuecomment-832333980 Thanks @jedcunningham - good catch. After copying over all of the recent commits to my version, I can run the upgrade successfully. I can't actually get the PVC to work, but t

[GitHub] [airflow] github-actions[bot] closed pull request #11196: Use priority queue algorithm to handle priority in executors

2021-05-04 Thread GitBox
github-actions[bot] closed pull request #11196: URL: https://github.com/apache/airflow/pull/11196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [airflow] github-actions[bot] closed pull request #11462: Fix issue with stale dags not being marked inactive by Scheduler

2021-05-04 Thread GitBox
github-actions[bot] closed pull request #11462: URL: https://github.com/apache/airflow/pull/11462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [airflow] github-actions[bot] closed pull request #11960: Log more types of errors when loading a DAG file to DB (POC)

2021-05-04 Thread GitBox
github-actions[bot] closed pull request #11960: URL: https://github.com/apache/airflow/pull/11960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [airflow] github-actions[bot] closed pull request #11223: Create stat name handler not supported rule

2021-05-04 Thread GitBox
github-actions[bot] closed pull request #11223: URL: https://github.com/apache/airflow/pull/11223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [airflow] github-actions[bot] closed pull request #12087: Modified ajax call

2021-05-04 Thread GitBox
github-actions[bot] closed pull request #12087: URL: https://github.com/apache/airflow/pull/12087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this s

[GitHub] [airflow] kaxil commented on a change in pull request #15627: Chart: Update Webserver update strategy based on Airflow Version

2021-05-04 Thread GitBox
kaxil commented on a change in pull request #15627: URL: https://github.com/apache/airflow/pull/15627#discussion_r626183744 ## File path: chart/templates/flower/flower-deployment.yaml ## @@ -73,7 +73,11 @@ spec: - name: flower image: {{ template "flower_imag

[GitHub] [airflow] zorzigio commented on issue #15572: import error

2021-05-04 Thread GitBox
zorzigio commented on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-832313455 @JavierLopezT, not a clean (or desirable) solution, however for me ```python sys.path.insert(0, '/opt/airflow/dags') ``` at the top of the file removes the error

[GitHub] [airflow] jedcunningham commented on pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
jedcunningham commented on pull request #15659: URL: https://github.com/apache/airflow/pull/15659#issuecomment-832313035 @cdibble, looks related to #14152. Can you confirm you are running the whole chart from latest master (e.g. not a patch applied to an older version)? If that doesn't do

[GitHub] [airflow] bbovenzi commented on pull request #13199: Create dag dependencies view

2021-05-04 Thread GitBox
bbovenzi commented on pull request #13199: URL: https://github.com/apache/airflow/pull/13199#issuecomment-832313043 I would recommend backend filtering. Some users have 10,000+ dags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] cdibble commented on pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
cdibble commented on pull request #15659: URL: https://github.com/apache/airflow/pull/15659#issuecomment-832305777 I tried to apply this with `helm upgrade` to my k8s deployment on EKS (AWS) and it failed to upgrade with the following output, which looks to be mostly just a dump of the `po

[GitHub] [airflow] jcpalmer108 edited a comment on issue #15658: Can't refresh DAGs when more than one Airflow UI is open

2021-05-04 Thread GitBox
jcpalmer108 edited a comment on issue #15658: URL: https://github.com/apache/airflow/issues/15658#issuecomment-832299986 @jedcunningham ditto what shabarish said! He's on my team and we're working on the same product. We need this fixed in the FAB UI, not RBAC. Can you help us get this iss

[GitHub] [airflow] jcpalmer108 commented on issue #15658: Can't refresh DAGs when more than one Airflow UI is open

2021-05-04 Thread GitBox
jcpalmer108 commented on issue #15658: URL: https://github.com/apache/airflow/issues/15658#issuecomment-832299986 @jedcunningham ditto what shabarish said! He's on my team and we're working on the same product. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [airflow] ephraimbuddy opened a new pull request #15661: Add --executor option to breeze kind-cluster deploy command

2021-05-04 Thread GitBox
ephraimbuddy opened a new pull request #15661: URL: https://github.com/apache/airflow/pull/15661 This change will enable us easily deploy airflow to kubernetes cluster and test it using different executors. Example usage: ./breeze kind-cluster --executor CeleryExecutor deploy

[GitHub] [airflow] iameugenejo edited a comment on issue #15036: Scheduler is skipping a day sometimes

2021-05-04 Thread GitBox
iameugenejo edited a comment on issue #15036: URL: https://github.com/apache/airflow/issues/15036#issuecomment-832294937 this hasn't happened for the past month or so. The following is the dag with some values redacted. ```from datetime import timedelta from airflow.models i

[GitHub] [airflow] iameugenejo commented on issue #15036: Scheduler is skipping a day sometimes

2021-05-04 Thread GitBox
iameugenejo commented on issue #15036: URL: https://github.com/apache/airflow/issues/15036#issuecomment-832294937 this hasn't happened for the past month or so. The following is the dag with some values redacted. ```from datetime import timedelta from airflow.models import D

[GitHub] [airflow] ms32035 commented on pull request #13199: Create dag dependencies view

2021-05-04 Thread GitBox
ms32035 commented on pull request #13199: URL: https://github.com/apache/airflow/pull/13199#issuecomment-832293530 @ashb made the changes requested @eladkal I have a few enhancements in mind for Airflow 2.2. Another possible filter would be enabled/disabled dags. Not sure yet though if f

[GitHub] [airflow] jedcunningham commented on issue #15623: Testing status of the Providers released 2021.05.01

2021-05-04 Thread GitBox
jedcunningham commented on issue #15623: URL: https://github.com/apache/airflow/issues/15623#issuecomment-832292038 Tested the `cncf.kubernetes` changes (except #15388) and had no issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[airflow] branch master updated (dd56875 -> d723ba5)

2021-05-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from dd56875 Improve Test Coverage for Kubernetes Executor (#15617) add d723ba5 Fix log persistence with Kubern

[GitHub] [airflow] kaxil merged pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
kaxil merged pull request #15659: URL: https://github.com/apache/airflow/pull/15659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] bbovenzi opened a new pull request #15660: Fix dags table overflow

2021-05-04 Thread GitBox
bbovenzi opened a new pull request #15660: URL: https://github.com/apache/airflow/pull/15660 Adds a false bottom to the table element so we can have overlap on the final row. Fixes #15656 https://user-images.githubusercontent.com/4600967/117076206-a6321180-acfb-11eb-8201-2b90

[GitHub] [airflow] ashb commented on a change in pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
ashb commented on a change in pull request #15599: URL: https://github.com/apache/airflow/pull/15599#discussion_r626131248 ## File path: docs/apache-airflow/security/secrets/index.rst ## @@ -30,6 +30,69 @@ The following are particularly protected: .. toctree:: :maxdepth:

[GitHub] [airflow] github-actions[bot] commented on pull request #15389: AIP-40 prototype: Deferrable Tasks

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15389: URL: https://github.com/apache/airflow/pull/15389#issuecomment-832266592 [The Workflow run](https://github.com/apache/airflow/actions/runs/811462101) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] github-actions[bot] commented on pull request #15389: AIP-40 prototype: Deferrable Tasks

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15389: URL: https://github.com/apache/airflow/pull/15389#issuecomment-832266318 [The Workflow run](https://github.com/apache/airflow/actions/runs/811425926) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[GitHub] [airflow] jedcunningham commented on pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
jedcunningham commented on pull request #15659: URL: https://github.com/apache/airflow/pull/15659#issuecomment-832261358 Wasn't able to reproduce the failure locally so letting CI run it again. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] jedcunningham closed pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
jedcunningham closed pull request #15659: URL: https://github.com/apache/airflow/pull/15659 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service

[airflow] branch master updated: Improve Test Coverage for Kubernetes Executor (#15617)

2021-05-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new dd56875 Improve Test Coverage for Kubernete

[GitHub] [airflow] kaxil merged pull request #15617: Improve Test Coverage for Kubernetes Executor

2021-05-04 Thread GitBox
kaxil merged pull request #15617: URL: https://github.com/apache/airflow/pull/15617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] SamWheating edited a comment on issue #15559: airflow dag success , but tasks not yet started,not scheduled.

2021-05-04 Thread GitBox
SamWheating edited a comment on issue #15559: URL: https://github.com/apache/airflow/issues/15559#issuecomment-831450306 We've been experiencing the same issues (Airflow 2.0.2, 2x schedulers, MySQL 8). Furthermore, when a task has `depends_on_past=True` this will cause the DAG to c

[GitHub] [airflow] jedcunningham commented on issue #11789: KubernetesExecutor git-sync example

2021-05-04 Thread GitBox
jedcunningham commented on issue #11789: URL: https://github.com/apache/airflow/issues/11789#issuecomment-832248025 @bpleines, can you try with the latest chart in master? I believe it is now functional with KubernetesExecutor. @scheung38, you might try posting on slack if you are st

[airflow] branch v2-1-test created (now cf583b9)

2021-05-04 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. at cf583b9 Rename old "Experimental" API to deprecated in the docs. (#15653) No new revisions were added by th

[GitHub] [airflow] vshabarish commented on issue #15658: Can't refresh DAGs when more than one Airflow UI is open

2021-05-04 Thread GitBox
vshabarish commented on issue #15658: URL: https://github.com/apache/airflow/issues/15658#issuecomment-832241108 hey, @jedcunningham we want it fixed in FAB UI, not on RBAC UI. Due to some internal concerns, we are not opting for the rbac ui within our team. we are preparing the 2.0.1 in

[GitHub] [airflow] kaxil commented on pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
kaxil commented on pull request #15659: URL: https://github.com/apache/airflow/pull/15659#issuecomment-832239139 Looks like K8s test is failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] vikramkoka commented on issue #13618: SendGrid - Support secrets backend

2021-05-04 Thread GitBox
vikramkoka commented on issue #13618: URL: https://github.com/apache/airflow/issues/13618#issuecomment-832238513 @eugenemiretsky Can you please confirm that the above referenced PR closes this? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] vikramkoka commented on issue #13701: Allow dags to be scheduled by solar events

2021-05-04 Thread GitBox
vikramkoka commented on issue #13701: URL: https://github.com/apache/airflow/issues/13701#issuecomment-832236777 @Lyalpha Please take a look at AIP-39 which is intended to introduce support for varied Scheduling timetables including your use case described above. https://cwiki.apache.o

[GitHub] [airflow] github-actions[bot] commented on pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15659: URL: https://github.com/apache/airflow/pull/15659#issuecomment-832232862 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] jedcunningham commented on issue #15658: Can't refresh DAGs when more than one Airflow UI is open

2021-05-04 Thread GitBox
jedcunningham commented on issue #15658: URL: https://github.com/apache/airflow/issues/15658#issuecomment-832220462 Related to #15539, which also has a way to resolve it with the RBAC UI: https://github.com/apache/airflow/issues/15539#issuecomment-827489265 -- This is an automated messag

[GitHub] [airflow] jedcunningham opened a new pull request #15659: Fix log persistence with KubernetesExecutor

2021-05-04 Thread GitBox
jedcunningham opened a new pull request #15659: URL: https://github.com/apache/airflow/pull/15659 KubernetesExecutor workers also need the log volume mounted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] jedcunningham commented on a change in pull request #15627: Chart: Update Webserver update strategy based on Airflow Version

2021-05-04 Thread GitBox
jedcunningham commented on a change in pull request #15627: URL: https://github.com/apache/airflow/pull/15627#discussion_r626076478 ## File path: chart/templates/flower/flower-deployment.yaml ## @@ -73,7 +73,11 @@ spec: - name: flower image: {{ template "flo

[GitHub] [airflow] ShakaibKhan commented on pull request #15385: [WIP] Added table to view providers in airflow ui under admin tab

2021-05-04 Thread GitBox
ShakaibKhan commented on pull request #15385: URL: https://github.com/apache/airflow/pull/15385#issuecomment-832207378 Made readability changes and rebased but am uncertain how to check for permissions in the views_test.py -- This is an automated message from the Apache Git Service. To r

[GitHub] [airflow] github-actions[bot] commented on pull request #15638: Fix issue with parsing error logs in the KPO

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15638: URL: https://github.com/apache/airflow/pull/15638#issuecomment-832206685 [The Workflow run](https://github.com/apache/airflow/actions/runs/811137319) is cancelling this PR. Building images for the PR has failed. Follow the workflow link

[GitHub] [airflow] boring-cyborg[bot] commented on issue #15658: Can't refresh DAGs when more than one Airflow UI is open

2021-05-04 Thread GitBox
boring-cyborg[bot] commented on issue #15658: URL: https://github.com/apache/airflow/issues/15658#issuecomment-832196526 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] jcpalmer108 opened a new issue #15658: Can't refresh DAGs when more than one Airflow UI is open

2021-05-04 Thread GitBox
jcpalmer108 opened a new issue #15658: URL: https://github.com/apache/airflow/issues/15658 **Apache Airflow version**: Apache Airflow Version 1.10.10 **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): Client Version: v1.20.4 Server Version: v1.15.12

[GitHub] [airflow] Dr-Denzy edited a comment on pull request #15617: Improve Test Coverage for Kubernetes Executor

2021-05-04 Thread GitBox
Dr-Denzy edited a comment on pull request #15617: URL: https://github.com/apache/airflow/pull/15617#issuecomment-832183238 > @Dr-Denzy static check is failing, can you take a look plz The failure was coming from a black static check. I have fixed it - and the test passed on my local

[GitHub] [airflow] Dr-Denzy commented on issue #15014: enable generate_pod_template in airflow 2.0.1

2021-05-04 Thread GitBox
Dr-Denzy commented on issue #15014: URL: https://github.com/apache/airflow/issues/15014#issuecomment-832184580 Assign to me @ashb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] Dr-Denzy commented on pull request #15617: Improve Test Coverage for Kubernetes Executor

2021-05-04 Thread GitBox
Dr-Denzy commented on pull request #15617: URL: https://github.com/apache/airflow/pull/15617#issuecomment-832183238 > @Dr-Denzy static check is failing, can you take a look plz The failure was coming from a black static check. I have fixed it - and the test passed on my local machine

[airflow] branch master updated (367d64b -> cf583b9)

2021-05-04 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 367d64b Fix chart DAG ``git-sync`` and persistence with ``KubernetesExecutor ``(#15657) add cf583b9 Rename old

[GitHub] [airflow] ashb merged pull request #15653: Rename to old "Experimental" API to deprecated in the docs.

2021-05-04 Thread GitBox
ashb merged pull request #15653: URL: https://github.com/apache/airflow/pull/15653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] github-actions[bot] commented on pull request #15389: AIP-40 prototype: Deferrable Tasks

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15389: URL: https://github.com/apache/airflow/pull/15389#issuecomment-832161520 [The Workflow run](https://github.com/apache/airflow/actions/runs/811048277) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build

[airflow] branch master updated (b1bd594 -> 367d64b)

2021-05-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from b1bd594 Add delimiter argument to WasbHook delete_file method (#15637) add 367d64b Fix chart DAG ``git-syn

[GitHub] [airflow] kaxil merged pull request #15657: Fix chart DAG gitsync and persistence with KubernetesExecutor

2021-05-04 Thread GitBox
kaxil merged pull request #15657: URL: https://github.com/apache/airflow/pull/15657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] kaxil closed issue #10646: Kubernetes config dags_volume_subpath breaks PVC in helm chart

2021-05-04 Thread GitBox
kaxil closed issue #10646: URL: https://github.com/apache/airflow/issues/10646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please cont

[GitHub] [airflow] zhzhang commented on issue #15623: Testing status of the Providers released 2021.05.01

2021-05-04 Thread GitBox
zhzhang commented on issue #15623: URL: https://github.com/apache/airflow/issues/15623#issuecomment-832139318 Tested postgres changes against a Redshift cluster, looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [airflow] github-actions[bot] commented on pull request #15657: Fix chart DAG gitsync and persistence with KubernetesExecutor

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15657: URL: https://github.com/apache/airflow/pull/15657#issuecomment-832134599 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] natanweinberger commented on a change in pull request #15425: Fix CLI connections import

2021-05-04 Thread GitBox
natanweinberger commented on a change in pull request #15425: URL: https://github.com/apache/airflow/pull/15425#discussion_r625985175 ## File path: airflow/models/connection.py ## @@ -364,3 +364,14 @@ def get_connection_from_secrets(cls, conn_id: str) -> 'Connection':

[GitHub] [airflow] jedcunningham commented on issue #10646: Kubernetes config dags_volume_subpath breaks PVC in helm chart

2021-05-04 Thread GitBox
jedcunningham commented on issue #10646: URL: https://github.com/apache/airflow/issues/10646#issuecomment-832123518 The original issue has already been fixed, but in the case where we have DAG persistence, gitsync, and KubernetesExecutor all at the same time we can be a little more efficie

[GitHub] [airflow] jedcunningham opened a new pull request #15657: Fix chart DAG gitsync and persistence with KubernetesExecutor

2021-05-04 Thread GitBox
jedcunningham opened a new pull request #15657: URL: https://github.com/apache/airflow/pull/15657 This prevents a gitsync contianer from being created in the KubernetesExecutor worker if DAG persistence is enabled as the DAG will already be on the volume. This also only mounts the DAGs

[GitHub] [airflow] vikramkoka commented on issue #14392: Refer Best Practices of using Variables in the Concepts/Variables section

2021-05-04 Thread GitBox
vikramkoka commented on issue #14392: URL: https://github.com/apache/airflow/issues/14392#issuecomment-832120930 Please suggest something or even articulate the questions you would like answered in the documentation. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] github-actions[bot] commented on pull request #9973: Improve compatibility with mssql

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #9973: URL: https://github.com/apache/airflow/pull/9973#issuecomment-832118150 [The Workflow run](https://github.com/apache/airflow/actions/runs/810856984) is cancelling this PR. Building images for the PR has failed. Follow the workflow link t

[GitHub] [airflow] ashb commented on a change in pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
ashb commented on a change in pull request #15599: URL: https://github.com/apache/airflow/pull/15599#discussion_r625974768 ## File path: airflow/utils/log/secrets_masker.py ## @@ -0,0 +1,221 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] ashb commented on a change in pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
ashb commented on a change in pull request #15599: URL: https://github.com/apache/airflow/pull/15599#discussion_r625973810 ## File path: airflow/utils/log/secrets_masker.py ## @@ -0,0 +1,221 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] ashb commented on a change in pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
ashb commented on a change in pull request #15599: URL: https://github.com/apache/airflow/pull/15599#discussion_r625973472 ## File path: airflow/utils/log/secrets_masker.py ## @@ -0,0 +1,221 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[airflow] branch master updated (91bb877 -> b1bd594)

2021-05-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git. from 91bb877 Use the Stable REST API for Kubernetes executor integration tests (#15644) add b1bd594 Add

[GitHub] [airflow] ephraimbuddy commented on pull request #15637: Fix WasbHook.delete_file broken when using prefix

2021-05-04 Thread GitBox
ephraimbuddy commented on pull request #15637: URL: https://github.com/apache/airflow/pull/15637#issuecomment-832112456 Congrats @monti-python :rocket: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] ephraimbuddy merged pull request #15637: Fix WasbHook.delete_file broken when using prefix

2021-05-04 Thread GitBox
ephraimbuddy merged pull request #15637: URL: https://github.com/apache/airflow/pull/15637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #15637: Fix WasbHook.delete_file broken when using prefix

2021-05-04 Thread GitBox
boring-cyborg[bot] commented on pull request #15637: URL: https://github.com/apache/airflow/pull/15637#issuecomment-832111531 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] ephraimbuddy closed issue #15636: WasbHook does not delete blobs with slash characters in prefix mode

2021-05-04 Thread GitBox
ephraimbuddy closed issue #15636: URL: https://github.com/apache/airflow/issues/15636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
ephraimbuddy commented on a change in pull request #15599: URL: https://github.com/apache/airflow/pull/15599#discussion_r625958627 ## File path: airflow/utils/log/secrets_masker.py ## @@ -0,0 +1,221 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
ephraimbuddy commented on a change in pull request #15599: URL: https://github.com/apache/airflow/pull/15599#discussion_r625958627 ## File path: airflow/utils/log/secrets_masker.py ## @@ -0,0 +1,221 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more con

[GitHub] [airflow] kaxil commented on pull request #15617: Improve Test Coverage for Kubernetes Executor

2021-05-04 Thread GitBox
kaxil commented on pull request #15617: URL: https://github.com/apache/airflow/pull/15617#issuecomment-832098405 @Dr-Denzy static check is failing, can you take a look plz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[airflow] branch master updated: Use the Stable REST API for Kubernetes executor integration tests (#15644)

2021-05-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/master by this push: new 91bb877 Use the Stable REST API for Kuberne

[GitHub] [airflow] kaxil merged pull request #15644: Use the Stable REST API for Kubernetes executor integration tests

2021-05-04 Thread GitBox
kaxil merged pull request #15644: URL: https://github.com/apache/airflow/pull/15644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow-ci-infra] xinbinhuang commented on a change in pull request #20: Sync committers daily

2021-05-04 Thread GitBox
xinbinhuang commented on a change in pull request #20: URL: https://github.com/apache/airflow-ci-infra/pull/20#discussion_r625952645 ## File path: lambdas/scale_out_runner/.chalice/prod/sync_committers.json ## @@ -0,0 +1,24 @@ +{ + "Version": "2012-10-17", + "Statement": [ +

[airflow-ci-infra] branch sync-commiters updated (80c9707 -> 3eee0cb)

2021-05-04 Thread binh
This is an automated email from the ASF dual-hosted git repository. binh pushed a change to branch sync-commiters in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git. from 80c9707 Update lambdas/scale_out_runner/app.py add c538312 Parse committers as list before dum

[GitHub] [airflow] github-actions[bot] commented on pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-05-04 Thread GitBox
github-actions[bot] commented on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-832091992 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

  1   2   3   >