[GitHub] [airflow-client-go] houqp commented on pull request #10: upgrade go client to latest api spec using openapi-generator 5.x

2021-06-14 Thread GitBox
houqp commented on pull request #10: URL: https://github.com/apache/airflow-client-go/pull/10#issuecomment-861194461 from master, I will regen it with `2.1.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] casra-developers commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
casra-developers commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r651467469 ## File path: airflow/task/task_runner/base_task_runner.py ## @@ -141,7 +143,7 @@ def run_command(self, run_with=None):

[GitHub] [airflow] zhbdesign opened a new issue #16447: The scheduler component can add time zone control, which will be more friendly for scheduling

2021-06-14 Thread GitBox
zhbdesign opened a new issue #16447: URL: https://github.com/apache/airflow/issues/16447 The scheduler component can add time zone control, which will be more friendly for scheduling -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] casra-developers commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
casra-developers commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r651460996 ## File path: airflow/utils/timeout.py ## @@ -22,12 +22,43 @@ from airflow.utils.platform import IS_WINDOWS from airflow.exceptions import

[GitHub] [airflow] casra-developers commented on a change in pull request #16110: Added windows extensions

2021-06-14 Thread GitBox
casra-developers commented on a change in pull request #16110: URL: https://github.com/apache/airflow/pull/16110#discussion_r651460996 ## File path: airflow/utils/timeout.py ## @@ -22,12 +22,43 @@ from airflow.utils.platform import IS_WINDOWS from airflow.exceptions import

[GitHub] [airflow-client-go] msumit commented on pull request #10: upgrade go client to latest api spec using openapi-generator 5.x

2021-06-14 Thread GitBox
msumit commented on pull request #10: URL: https://github.com/apache/airflow-client-go/pull/10#issuecomment-861159943 @houqp did u generate this code from Airflow's 2.1.0 tag or from master? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] jhtimmins opened a new pull request #16446: Use resource and action names in test_security.py.

2021-06-14 Thread GitBox
jhtimmins opened a new pull request #16446: URL: https://github.com/apache/airflow/pull/16446 Part of the Resource/Action FAB Name epic. Updates the following test files to use the new naming scheme. Should not change any behaviors, as it just updates variable names and method call

[GitHub] [airflow] sawaca96 edited a comment on issue #15572: import error

2021-06-14 Thread GitBox
sawaca96 edited a comment on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-861061924 @zorzigio >@sawaca96, I expected it to work, however when trying to install the Helm chart, it raises the following error I want to get more information. then I

[GitHub] [airflow] ryanahamilton merged pull request #16440: Resolve all npm vulnerabilities

2021-06-14 Thread GitBox
ryanahamilton merged pull request #16440: URL: https://github.com/apache/airflow/pull/16440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [airflow] ryanahamilton closed issue #10429: jquery dependency needs to be updated to 3.5.0 or newer

2021-06-14 Thread GitBox
ryanahamilton closed issue #10429: URL: https://github.com/apache/airflow/issues/10429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] mik-laj commented on a change in pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
mik-laj commented on a change in pull request #16420: URL: https://github.com/apache/airflow/pull/16420#discussion_r651367704 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -179,6 +179,7 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]:

[GitHub] [airflow] mik-laj commented on a change in pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
mik-laj commented on a change in pull request #16420: URL: https://github.com/apache/airflow/pull/16420#discussion_r651367704 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -179,6 +179,7 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]:

[GitHub] [airflow] ldacey commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
ldacey commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-861083311 > I dont know if it is the same issue, but my large dags are showing up in tree view, but unusably: > I get this same weird (ugly) UI on tree view if I expand the number

[GitHub] [airflow] ziliangpeng commented on pull request #15492: Fix labels on the pod created by ``KubernetesPodOperator``

2021-06-14 Thread GitBox
ziliangpeng commented on pull request #15492: URL: https://github.com/apache/airflow/pull/15492#issuecomment-861079866 Has this change been released in a public airflow version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-861078110 That does make sense. I like that. On Mon, Jun 14, 2021 at 5:18 PM Kaxil Naik ***@***.***> wrote: > ***@***. commented on this pull request. >

[GitHub] [airflow] github-actions[bot] commented on issue #15268: Airflow UI display error

2021-06-14 Thread GitBox
github-actions[bot] commented on issue #15268: URL: https://github.com/apache/airflow/issues/15268#issuecomment-861069855 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed issue #15268: Airflow UI display error

2021-06-14 Thread GitBox
github-actions[bot] closed issue #15268: URL: https://github.com/apache/airflow/issues/15268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[airflow] branch main updated (9526a24 -> 3f84d3d)

2021-06-14 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9526a24 Adding `only_active` parameter to /dags endpoint (#14306) add 3f84d3d Fix spellcheck failure

[GitHub] [airflow] jhtimmins merged pull request #16445: Fix spellcheck failure

2021-06-14 Thread GitBox
jhtimmins merged pull request #16445: URL: https://github.com/apache/airflow/pull/16445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] jedcunningham commented on pull request #16445: Fix spellcheck failure

2021-06-14 Thread GitBox
jedcunningham commented on pull request #16445: URL: https://github.com/apache/airflow/pull/16445#issuecomment-861062795 Nope, still fails. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] sawaca96 edited a comment on issue #15572: import error

2021-06-14 Thread GitBox
sawaca96 edited a comment on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-861061924 @zorzigio >@sawaca96, I expected it to work, however when trying to install the Helm chart, it raises the following error I want to get more information. then I

[GitHub] [airflow] sawaca96 edited a comment on issue #15572: import error

2021-06-14 Thread GitBox
sawaca96 edited a comment on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-861061924 @zorzigio >@sawaca96, I expected it to work, however when trying to install the Helm chart, it raises the following error I want to get more information. then I

[GitHub] [airflow] sawaca96 commented on issue #15572: import error

2021-06-14 Thread GitBox
sawaca96 commented on issue #15572: URL: https://github.com/apache/airflow/issues/15572#issuecomment-861061924 @zorzigio >@sawaca96, I expected it to work, however when trying to install the Helm chart, it raises the following error I want to get more information. then I can try

[GitHub] [airflow] jedcunningham commented on pull request #16445: Fix spellcheck failure

2021-06-14 Thread GitBox
jedcunningham commented on pull request #16445: URL: https://github.com/apache/airflow/pull/16445#issuecomment-861060432 Oh, let me try it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] jhtimmins commented on pull request #16445: Fix spellcheck failure

2021-06-14 Thread GitBox
jhtimmins commented on pull request #16445: URL: https://github.com/apache/airflow/pull/16445#issuecomment-861059440 @jedcunningham would it make more sense to just do `DB`? I assume it handles pluralization properly? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] jedcunningham opened a new pull request #16445: Fix spellcheck failure

2021-06-14 Thread GitBox
jedcunningham opened a new pull request #16445: URL: https://github.com/apache/airflow/pull/16445 Locally, building the `apache-airflow` docs results in a spellcheck failure: ``` migrations-ref.rst:151: (DBs) Increase text size for MySQL (not relevant for

[GitHub] [airflow] jedcunningham commented on a change in pull request #16425: Allow configuration of pod resources in helm chart

2021-06-14 Thread GitBox
jedcunningham commented on a change in pull request #16425: URL: https://github.com/apache/airflow/pull/16425#discussion_r651331183 ## File path: chart/files/pod-template-file.kubernetes-helm-yaml ## @@ -54,6 +54,8 @@ spec: imagePullPolicy: {{

[GitHub] [airflow] github-actions[bot] commented on pull request #16441: Release Airflow Upgrade Check 1.4.0

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16441: URL: https://github.com/apache/airflow/pull/16441#issuecomment-861048725 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #16443: Disable Pylint member check for ``tests/decorators/test_python.py``

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16443: URL: https://github.com/apache/airflow/pull/16443#issuecomment-861048341 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] github-actions[bot] commented on pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16436: URL: https://github.com/apache/airflow/pull/16436#issuecomment-861047934 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] yashbaldawa-okta commented on issue #16444: Airflow Local Webserver Rendering Bug

2021-06-14 Thread GitBox
yashbaldawa-okta commented on issue #16444: URL: https://github.com/apache/airflow/issues/16444#issuecomment-861043769 closed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] yashbaldawa-okta closed issue #16444: Airflow Local Webserver Rendering Bug

2021-06-14 Thread GitBox
yashbaldawa-okta closed issue #16444: URL: https://github.com/apache/airflow/issues/16444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] yashbaldawa-okta opened a new issue #16444: Airflow Local Webserver Rendering Bug

2021-06-14 Thread GitBox
yashbaldawa-okta opened a new issue #16444: URL: https://github.com/apache/airflow/issues/16444 **Apache Airflow version**: **Kubernetes version (if you are using kubernetes)** (use `kubectl version`): **Environment**: - **Cloud provider or hardware

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16444: Airflow Local Webserver Rendering Bug

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #16444: URL: https://github.com/apache/airflow/issues/16444#issuecomment-861043542 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] kaxil commented on a change in pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16436: URL: https://github.com/apache/airflow/pull/16436#discussion_r651323745 ## File path: airflow/providers/elasticsearch/hooks/elasticsearch.py ## @@ -30,7 +30,8 @@ class ElasticsearchHook(DbApiHook): This hook uses the

[GitHub] [airflow] kaxil commented on a change in pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16436: URL: https://github.com/apache/airflow/pull/16436#discussion_r651323643 ## File path: docs/apache-airflow-providers-elasticsearch/connections/elasticsearch.rst ## @@ -0,0 +1,74 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] kaxil commented on a change in pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16436: URL: https://github.com/apache/airflow/pull/16436#discussion_r651323523 ## File path: docs/apache-airflow-providers-elasticsearch/connections/elasticsearch.rst ## @@ -0,0 +1,74 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] kaxil commented on a change in pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16436: URL: https://github.com/apache/airflow/pull/16436#discussion_r651323405 ## File path: docs/apache-airflow-providers-elasticsearch/connections/elasticsearch.rst ## @@ -0,0 +1,74 @@ + .. Licensed to the Apache Software

[GitHub] [airflow] kaxil commented on pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
kaxil commented on pull request #16436: URL: https://github.com/apache/airflow/pull/16436#issuecomment-861039107 Pre-commit checks are failing, can you install and re-run pre-commit checks on your machine please:

[GitHub] [airflow] github-actions[bot] commented on pull request #16442: Fix templated default/example values in config ref docs

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16442: URL: https://github.com/apache/airflow/pull/16442#issuecomment-861037921 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] kaxil opened a new pull request #16443: Disable Pylint member check for ``tests/decorators/test_python.py``

2021-06-14 Thread GitBox
kaxil opened a new pull request #16443: URL: https://github.com/apache/airflow/pull/16443 Some PRs are failing this check: https://github.com/apache/airflow/pull/16408/checks?check_run_id=2823934948#step:9:54

[GitHub] [airflow] jedcunningham opened a new pull request #16442: Fix templated default/example values in config ref docs

2021-06-14 Thread GitBox
jedcunningham opened a new pull request #16442: URL: https://github.com/apache/airflow/pull/16442 We should show the actual default/example value in the configuration reference docs, not the templated values. e.g. `{dag_id}` like you get in a generated airflow.cfg, not `{{dag_id}}

[GitHub] [airflow] kaxil opened a new pull request #16441: Release Airflow Upgrade Check 1.4.0

2021-06-14 Thread GitBox
kaxil opened a new pull request #16441: URL: https://github.com/apache/airflow/pull/16441 Don't need to merge this PR, just needs approval. This will be the last release of Airflow Upgrade Check as discussed on Slack:

[GitHub] [airflow] kaxil commented on pull request #16440: yarn audit

2021-06-14 Thread GitBox
kaxil commented on pull request #16440: URL: https://github.com/apache/airflow/pull/16440#issuecomment-861032343 Needs a more descriptive PR title though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] kaxil commented on a change in pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16420: URL: https://github.com/apache/airflow/pull/16420#discussion_r651315105 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -179,6 +179,7 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]:

[GitHub] [airflow] kaxil commented on a change in pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
kaxil commented on a change in pull request #16420: URL: https://github.com/apache/airflow/pull/16420#discussion_r651315105 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -179,6 +179,7 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]:

[GitHub] [airflow] johngtam commented on issue #12334: kubernetes executor pod not removed

2021-06-14 Thread GitBox
johngtam commented on issue #12334: URL: https://github.com/apache/airflow/issues/12334#issuecomment-861031445 @marclamberti, did you ever get this resolved (by the way, really love your class, I took it and it helped me a lot!)? I'm running into the same thing on Airflow 2.0.2, but

[GitHub] [airflow] github-actions[bot] commented on pull request #16440: yarn audit

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16440: URL: https://github.com/apache/airflow/pull/16440#issuecomment-861030231 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[airflow] branch v1-10-test updated: Release upgrade_check 1.4.0

2021-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v1-10-test by this push: new 15c30e1 Release upgrade_check

[airflow] 01/03: Pin SQLAlchemy to <1.4 due to breakage of sqlalchemy-utils (#14812)

2021-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit c21c55b882469f29e74ebe04f8045e86696a99d7 Author: Jarek Potiuk AuthorDate: Mon Mar 15 21:28:06 2021 +0100

[airflow] 02/03: Add `flask_oauth` to to `devel_all`

2021-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 8025f86c69234f30e2349b0e2842c3d7e38345f5 Author: Kaxil Naik AuthorDate: Sun Apr 4 23:09:27 2021 +0100 Add

[airflow] branch v1-10-test updated (69da579 -> 1cabbf6)

2021-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git. omit 69da579 Add `flask_oauth` to to `devel_all` omit 594f5de Pin SQLAlchemy to <1.4 due to breakage of

[airflow] 03/03: fixup! Add conf not importable from airflow rule (#14400)

2021-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v1-10-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 1cabbf6adf718eaf6b59d5812d1a97d34bb4895a Author: Kaxil Naik AuthorDate: Mon Jun 14 23:08:49 2021 +0100

[GitHub] [airflow] bbovenzi opened a new pull request #16440: yarn audit

2021-06-14 Thread GitBox
bbovenzi opened a new pull request #16440: URL: https://github.com/apache/airflow/pull/16440 Bump a lot of npm modules in packages.json to resolve all severe and moderate vulnerabilities found when using `yarn audit` Closes #10429 --- **^ Add meaningful description

[GitHub] [airflow] kaxil commented on issue #16439: Restart Airflow scheduler and retain historical data

2021-06-14 Thread GitBox
kaxil commented on issue #16439: URL: https://github.com/apache/airflow/issues/16439#issuecomment-861025342 Restarting Airflow scheduler does not remove the old Metadata. That metadata about historical DagRuns and Task instances is stored in Airflow Metadata DB (Postgres, MySQL etc) as

[GitHub] [airflow] kaxil commented on pull request #16393: Handle missing/null serialized DAG dependencies

2021-06-14 Thread GitBox
kaxil commented on pull request #16393: URL: https://github.com/apache/airflow/pull/16393#issuecomment-861020075 @uranusjr Pylint failure: ``` * Module tests.decorators.test_python tests/decorators/test_python.py:458:62: E1101: Instance of 'str' has no 'task_id'

[airflow] branch main updated: Adding `only_active` parameter to /dags endpoint (#14306)

2021-06-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9526a24 Adding `only_active` parameter to

[GitHub] [airflow] kaxil merged pull request #14306: Adding `only_active` parameter to /dags endpoint

2021-06-14 Thread GitBox
kaxil merged pull request #14306: URL: https://github.com/apache/airflow/pull/14306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] jedcunningham commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
jedcunningham commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651284179 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -545,17 +544,17 @@ def monitor_launched_pod(self, launcher,

[GitHub] [airflow] boring-cyborg[bot] commented on issue #16439: Restart Airflow scheduler and retain historical data

2021-06-14 Thread GitBox
boring-cyborg[bot] commented on issue #16439: URL: https://github.com/apache/airflow/issues/16439#issuecomment-860993665 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] bencaine-integral opened a new issue #16439: Restart Airflow scheduler and retain historical data

2021-06-14 Thread GitBox
bencaine-integral opened a new issue #16439: URL: https://github.com/apache/airflow/issues/16439 Some administrative actions, like changing a value in my `airflow.cfg` file, require a restart of the scheduler for changes to take effect. However, if I were to do that, all the historical

[GitHub] [airflow] MatthewRBruce commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
MatthewRBruce commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651273773 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -545,17 +544,17 @@ def monitor_launched_pod(self, launcher,

[GitHub] [airflow] jedcunningham commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
jedcunningham commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651265183 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -545,17 +544,17 @@ def monitor_launched_pod(self, launcher,

[GitHub] [airflow-client-go] houqp commented on a change in pull request #10: upgrade go client to latest api spec using openapi-generator 5.x

2021-06-14 Thread GitBox
houqp commented on a change in pull request #10: URL: https://github.com/apache/airflow-client-go/pull/10#discussion_r651249803 ## File path: README.md ## @@ -36,19 +36,18 @@ import ( ) func main() { - cli := airflow.NewAPIClient({ - Scheme: "http", -

[airflow] branch main updated: generate go client with latest openapi generator template (#16411)

2021-06-14 Thread houqp
This is an automated email from the ASF dual-hosted git repository. houqp pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c6e043f generate go client with latest openapi

[GitHub] [airflow] houqp merged pull request #16411: generate go client with latest openapi generator template

2021-06-14 Thread GitBox
houqp merged pull request #16411: URL: https://github.com/apache/airflow/pull/16411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] MatthewRBruce commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
MatthewRBruce commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651247330 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -545,17 +544,17 @@ def monitor_launched_pod(self, launcher,

[GitHub] [airflow-client-go] houqp opened a new pull request #10: upgrade go client to latest api spec using openapi-generator 5.x

2021-06-14 Thread GitBox
houqp opened a new pull request #10: URL: https://github.com/apache/airflow-client-go/pull/10 Depends on https://github.com/apache/airflow/pull/16411. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[airflow] branch main updated (5c86e3d -> 6087a09)

2021-06-14 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 5c86e3d Make SparkSqlHook use Connection (#15794) add 6087a09 add num_runs query param for tree refresh (#16437)

[GitHub] [airflow] ashb merged pull request #16437: Add num_runs query param for tree refresh

2021-06-14 Thread GitBox
ashb merged pull request #16437: URL: https://github.com/apache/airflow/pull/16437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] ashb closed issue #16367: Tree view shown incorrect dag runs

2021-06-14 Thread GitBox
ashb closed issue #16367: URL: https://github.com/apache/airflow/issues/16367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] jedcunningham commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
jedcunningham commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651232756 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -358,15 +358,14 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] MatthewRBruce commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
MatthewRBruce commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651229465 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -358,15 +358,14 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] MatthewRBruce commented on a change in pull request #15490: Fix unsuccessful KubernetesPod final_state call when `is_delete_operator_pod=True`

2021-06-14 Thread GitBox
MatthewRBruce commented on a change in pull request #15490: URL: https://github.com/apache/airflow/pull/15490#discussion_r651229343 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -358,15 +358,14 @@ def execute(self, context) -> Optional[str]:

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860946154 Code updated to just pass the application parameter statically in the conn_config object On Mon, Jun 14, 2021 at 1:19 PM Jarek Potiuk ***@***.***> wrote:

[airflow] branch main updated (943292b -> 5c86e3d)

2021-06-14 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 943292b Queue tasks with higher priority and earlier execution_date first. (#15210) add 5c86e3d Make

[GitHub] [airflow] potiuk merged pull request #15794: Make SparkSqlHook use Connection

2021-06-14 Thread GitBox
potiuk merged pull request #15794: URL: https://github.com/apache/airflow/pull/15794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [airflow] potiuk closed issue #8713: Spark SQL Hook not using connections

2021-06-14 Thread GitBox
potiuk closed issue #8713: URL: https://github.com/apache/airflow/issues/8713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [airflow] bbovenzi removed a comment on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi removed a comment on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860929449 Noted. Still looking into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] bbovenzi commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860929449 Noted. Still looking into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] syedshameersarwar commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
syedshameersarwar commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860927892 > @fjmacagno @syedshameersarwar Does this happen when the auto-refresh is on, or whenever? Yeah, it's always the same for me, auto-refresh on or off -- This is

[GitHub] [airflow] bbovenzi edited a comment on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi edited a comment on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860835673 @jdahlbaek We don't support mobile screen sizes. But let me look into the rest of these concerns and see what's going on. -- This is an automated message from the Apache

[GitHub] [airflow] bbovenzi opened a new pull request #16437: Add num_runs query param for tree refresh

2021-06-14 Thread GitBox
bbovenzi opened a new pull request #16437: URL: https://github.com/apache/airflow/pull/16437 Add `num_runs` as a meta field to add to the tree refresh request Closes #16367 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
potiuk commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860893008 Can you change it please then @sfc-gh-madkins ? because the default is now in the Operator. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] fjmacagno commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
fjmacagno commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860882166 > @fjmacagno @syedshameersarwar Does this happen when the auto-refresh is on, or whenever? Whenever -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] bbovenzi commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860880493 @fjmacagno @syedshameersarwar Does this happen when the auto-refresh is on, or whenever? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] bbovenzi commented on issue #16367: Tree view shown incorrect dag runs

2021-06-14 Thread GitBox
bbovenzi commented on issue #16367: URL: https://github.com/apache/airflow/issues/16367#issuecomment-860879602 Just replicated this one. It is an issue with the auto-refresh. Working on a fix now. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860868813 Yes -- The hook is where it should happen where the param is unchangeable by the consumer. For managed providers, they can then override it when they go to push

[GitHub] [airflow] bryce-lewis opened a new pull request #16436: Add ElasticSearch Connection Doc

2021-06-14 Thread GitBox
bryce-lewis opened a new pull request #16436: URL: https://github.com/apache/airflow/pull/16436 Added a connection doc for the ElasticSearch connection. Added links inside the ElasticSearch module doc strings for user to have access to the ElasticSearch connection doc. -- This is

[GitHub] [airflow] github-actions[bot] commented on pull request #16410: Use resource and action names.

2021-06-14 Thread GitBox
github-actions[bot] commented on pull request #16410: URL: https://github.com/apache/airflow/pull/16410#issuecomment-860853160 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
potiuk commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860841495 > I think, it should be connection parameter, environment parameter or fixed constant (preferred by me). Now we require changes to the DAG file, so very few people will be

[GitHub] [airflow] bbovenzi commented on issue #16249: Fully functional DAG Dependencies Graph view

2021-06-14 Thread GitBox
bbovenzi commented on issue #16249: URL: https://github.com/apache/airflow/issues/16249#issuecomment-860837020 @ManiBharataraju That looks great! I am more than happy to help you out with javascript. Feel free to message me on the airflow slack channel to figure out how to get this

[GitHub] [airflow] bbovenzi commented on issue #16238: Airflow Tree View for larger dags

2021-06-14 Thread GitBox
bbovenzi commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-860835673 @jdahlbaek We support mobile screen sizes. But let me look into the rest of these concerns and see what's going on. -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] kaxil edited a comment on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
kaxil edited a comment on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860793840 > Are we sure we want it to be an operator parameter? I think it should be a connection configuration parameter or fixed constant. Now we force user to make changes in

[GitHub] [airflow] kaxil commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
kaxil commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860793840 > Are we sure we want it to be an operator parameter? I think it should be a connection configuration parameter or fixed constant. Now we force user to make changes in Python

[GitHub] [airflow] mik-laj commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
mik-laj commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860791658 Are we sure we want it to be an operator parameter? I think it should be a connection configuration parameter or fixed constant. Now we force user to make changes in Python

[GitHub] [airflow] potiuk commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
potiuk commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860789423 Fine for me. Happy to merge it as is before I start releasing providers today :) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] jedcunningham commented on issue #16313: cryptography.fernet.InvalidToken when attempting to access connections

2021-06-14 Thread GitBox
jedcunningham commented on issue #16313: URL: https://github.com/apache/airflow/issues/16313#issuecomment-860788656 Cool, glad you found it! @lewismc, that was why I asked about a new release name actually, as with the default values the chart keeps the postgres PVC around and can

[GitHub] [airflow] mik-laj commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
mik-laj commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860788473 > If we want to remove the user-defined part of it. It should just be one line of code. SGTM -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] sfc-gh-madkins commented on pull request #16420: Added ability for Snowflake to attribute usage to Airflow by adding an application parameter

2021-06-14 Thread GitBox
sfc-gh-madkins commented on pull request #16420: URL: https://github.com/apache/airflow/pull/16420#issuecomment-860784508 We will want to keep the Airflow tag standardized, so I would not want to include the version. Ultimately, this is what we need the code to look like when we

  1   2   3   4   5   6   >