[GitHub] [airflow] potiuk commented on issue #17422: AttributeError: 'PostgresHook' object has no attribute 'schema'

2021-08-05 Thread GitBox
potiuk commented on issue #17422: URL: https://github.com/apache/airflow/issues/17422#issuecomment-892923494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] github-actions[bot] commented on pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17425: URL: https://github.com/apache/airflow/pull/17425#issuecomment-893358618 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] potiuk edited a comment on issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk edited a comment on issue #17437: URL: https://github.com/apache/airflow/issues/17437#issuecomment-893348355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [airflow] github-actions[bot] commented on pull request #17432: Fixes some static check errors

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17432: URL: https://github.com/apache/airflow/pull/17432#issuecomment-893207042 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr commented on pull request #17431: Add back missing permissions to UserModelView controls.

2021-08-05 Thread GitBox
uranusjr commented on pull request #17431: URL: https://github.com/apache/airflow/pull/17431#issuecomment-893304150 Should we switch the new tests to use pytest instead? That would make them slightly faster to run. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [airflow] ashb commented on a change in pull request #17100: WIP: Advanced Params using json-schema

2021-08-05 Thread GitBox
ashb commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r682515041 ## File path: airflow/cli/commands/dag_command.py ## @@ -104,21 +104,24 @@ def dag_backfill(args, dag=None): dag_run_state=State.NONE,

[GitHub] [airflow] potiuk merged pull request #17410: Improve diagnostics message when users have secret_key misconfigured

2021-08-05 Thread GitBox
potiuk merged pull request #17410: URL: https://github.com/apache/airflow/pull/17410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17408: Fix issue #17371

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on pull request #17408: URL: https://github.com/apache/airflow/pull/17408#issuecomment-892549274 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] flolas commented on pull request #17329: Split sql statements in DbApi run

2021-08-05 Thread GitBox
flolas commented on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-893071375 > sqlparse is not a core dependency -- it needs adding. Hi @ashb, what do you mean with "it needs adding"? I added sqlparse to setup.cfg. We need to do anything else?

[GitHub] [airflow] ashb merged pull request #16860: Support DAGS folder being in different location on scheduler and runners

2021-08-05 Thread GitBox
ashb merged pull request #16860: URL: https://github.com/apache/airflow/pull/16860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] uranusjr commented on a change in pull request #17329: Split sql statements in DbApi run

2021-08-05 Thread GitBox
uranusjr commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r682680957 ## File path: airflow/hooks/dbapi.py ## @@ -176,18 +178,29 @@ def run(self, sql, autocommit=False, parameters=None, handler=None): :param han

[GitHub] [airflow] github-actions[bot] commented on pull request #17426: Allow using default celery commands for custom Celery executors subclassed from existing

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17426: URL: https://github.com/apache/airflow/pull/17426#issuecomment-893219756 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] potiuk commented on a change in pull request #17426: Allow using default celery commands for custom Celery executors subclassed from existing

2021-08-05 Thread GitBox
potiuk commented on a change in pull request #17426: URL: https://github.com/apache/airflow/pull/17426#discussion_r683182521 ## File path: airflow/cli/cli_parser.py ## @@ -60,10 +62,15 @@ def _check_value(self, action, value): if action.dest == 'subcommand' and value =

[GitHub] [airflow] josh-fell commented on pull request #17421: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-08-05 Thread GitBox
josh-fell commented on pull request #17421: URL: https://github.com/apache/airflow/pull/17421#issuecomment-892684861 @eladkal If you have some time, I'd love to get your feedback on the logic in this PR! -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [airflow] potiuk merged pull request #17418: Optimizes structure of the Dockerfiles and use latest tools

2021-08-05 Thread GitBox
potiuk merged pull request #17418: URL: https://github.com/apache/airflow/pull/17418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] wojsamjan closed pull request #17285: Add info log how to fix: More than one pod running with labels

2021-08-05 Thread GitBox
wojsamjan closed pull request #17285: URL: https://github.com/apache/airflow/pull/17285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] jedcunningham commented on a change in pull request #17409: Improve image building documentation for new users

2021-08-05 Thread GitBox
jedcunningham commented on a change in pull request #17409: URL: https://github.com/apache/airflow/pull/17409#discussion_r682855059 ## File path: docs/apache-airflow/start/docker.rst ## @@ -81,6 +81,18 @@ If you need install a new Python library or system library, you can :doc

[GitHub] [airflow] github-actions[bot] commented on pull request #17417: Increases timeout for helm chart builds

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17417: URL: https://github.com/apache/airflow/pull/17417#issuecomment-892897159 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] yevsh commented on issue #17395: DAG is executed twice on submit

2021-08-05 Thread GitBox
yevsh commented on issue #17395: URL: https://github.com/apache/airflow/issues/17395#issuecomment-893270823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] cpdean commented on pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-08-05 Thread GitBox
cpdean commented on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-892692829 I don't think that I have, but I'm not sure. Here's the `logging` stanza from my `airflow.cfg`. It was generated by whatever airflow does by default when you first run it.

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17427: Updating INTHEWILD.md

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on pull request #17427: URL: https://github.com/apache/airflow/pull/17427#issuecomment-893138245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk merged pull request #17409: Improve image building documentation for new users

2021-08-05 Thread GitBox
potiuk merged pull request #17409: URL: https://github.com/apache/airflow/pull/17409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17436: Support fnmatch pattern in SFTP Hook and Sensor

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on pull request #17436: URL: https://github.com/apache/airflow/pull/17436#issuecomment-893276480 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] ashb commented on a change in pull request #17265: Use `dag_maker` fixture in test_scheduler_job.py

2021-08-05 Thread GitBox
ashb commented on a change in pull request #17265: URL: https://github.com/apache/airflow/pull/17265#discussion_r683294385 ## File path: tests/jobs/test_scheduler_job.py ## @@ -495,45 +439,24 @@ def test_find_executable_task_instances_pool(self): assert tis[3].key in r

[GitHub] [airflow] jedcunningham commented on a change in pull request #17423: Make schema in DBApiHook private

2021-08-05 Thread GitBox
jedcunningham commented on a change in pull request #17423: URL: https://github.com/apache/airflow/pull/17423#discussion_r682957637 ## File path: airflow/providers/postgres/hooks/postgres.py ## @@ -70,6 +70,7 @@ def __init__(self, *args, **kwargs) -> None: super().__in

[GitHub] [airflow] github-actions[bot] commented on pull request #17409: Improve image building documentation for new users

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17409: URL: https://github.com/apache/airflow/pull/17409#issuecomment-892942516 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk commented on pull request #17416: Remove CONTINUE_ON_PIP_CHECK_FAILURE parameter

2021-08-05 Thread GitBox
potiuk commented on pull request #17416: URL: https://github.com/apache/airflow/pull/17416#issuecomment-893001146 Already merged in #17418 (but it logically belongs there too). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] github-actions[bot] closed pull request #15233: Allow SQSSensor to filter messages by their attribute names

2021-08-05 Thread GitBox
github-actions[bot] closed pull request #15233: URL: https://github.com/apache/airflow/pull/15233 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #16421: Add api_connexion Endpoint for Updating State of DAG run (#16412)

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #16421: URL: https://github.com/apache/airflow/pull/16421#issuecomment-893056814 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank y

[GitHub] [airflow] ashb edited a comment on pull request #17341: Add ExecStop to systemd service files.

2021-08-05 Thread GitBox
ashb edited a comment on pull request #17341: URL: https://github.com/apache/airflow/pull/17341#issuecomment-892574013 > To add to this, would it be a good idea to demonstrate use of multiple worker on same machine? Can you explain where doing this would be useful? You can have one w

[GitHub] [airflow] potiuk commented on a change in pull request #17410: Improve diagnostics message when users have secret_key misconfigured

2021-08-05 Thread GitBox
potiuk commented on a change in pull request #17410: URL: https://github.com/apache/airflow/pull/17410#discussion_r682528405 ## File path: airflow/utils/log/file_task_handler.py ## @@ -190,6 +191,15 @@ def _read(self, ti, try_number, metadata=None): response.ra

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17265: Use `dag_maker` fixture in test_scheduler_job.py

2021-08-05 Thread GitBox
ephraimbuddy commented on a change in pull request #17265: URL: https://github.com/apache/airflow/pull/17265#discussion_r682638806 ## File path: tests/jobs/test_scheduler_job.py ## @@ -119,10 +119,18 @@ def clean_db(): # DO NOT try to run clear_db_serialized_dags() her

[GitHub] [airflow] ricardogaspar2 edited a comment on issue #16618: Access specific values within an `XCom` value using Taskflow API

2021-08-05 Thread GitBox
ricardogaspar2 edited a comment on issue #16618: URL: https://github.com/apache/airflow/issues/16618#issuecomment-892728928 > > It would also be great if there was a way of NOT creating the dependencies between tasks automatically. > > For cluster or job IDs (EMR, Databricks, etc) is ver

[GitHub] [airflow] potiuk commented on issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk commented on issue #17437: URL: https://github.com/apache/airflow/issues/17437#issuecomment-893348355 I think, before you start requesting new features, it is great to check if the existing features are not working well for you: 1) Did you try to configure multiple schedulers?

[GitHub] [airflow] ashb closed issue #8061: Support DAGS folder being in different location on scheduler and worker.

2021-08-05 Thread GitBox
ashb closed issue #8061: URL: https://github.com/apache/airflow/issues/8061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] santosh-d3vpl3x commented on pull request #17341: Add ExecStop to systemd service files.

2021-08-05 Thread GitBox
santosh-d3vpl3x commented on pull request #17341: URL: https://github.com/apache/airflow/pull/17341#issuecomment-893011330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [airflow] ashb commented on pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-08-05 Thread GitBox
ashb commented on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-892574595 @cpdean Have you customized the Airflow logging at all? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] cpdean edited a comment on pull request #15599: Mask passwords and sensitive info in task logs and UI

2021-08-05 Thread GitBox
cpdean edited a comment on pull request #15599: URL: https://github.com/apache/airflow/pull/15599#issuecomment-892692829 I don't think that I have, but I'm not sure. Here's the `logging` stanza from my `airflow.cfg`. It was generated by whatever airflow does by default when you first run i

[GitHub] [airflow] github-actions[bot] commented on pull request #17410: Improve diagnostics message when users have secret_key misconfigured

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17410: URL: https://github.com/apache/airflow/pull/17410#issuecomment-892588632 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr edited a comment on pull request #17436: Support fnmatch pattern in SFTP Hook and Sensor

2021-08-05 Thread GitBox
uranusjr edited a comment on pull request #17436: URL: https://github.com/apache/airflow/pull/17436#issuecomment-893312844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17426: Allow using default celery commands for custom Celery executors subclassed from existing

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on pull request #17426: URL: https://github.com/apache/airflow/pull/17426#issuecomment-893120800 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] github-actions[bot] commented on pull request #17415: Optimize context sent for docker build

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17415: URL: https://github.com/apache/airflow/pull/17415#issuecomment-892665317 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] sighingnow commented on pull request #17405: Put the XCom.clear logic into XCom class to allow it hookable in custom XCom backend

2021-08-05 Thread GitBox
sighingnow commented on pull request #17405: URL: https://github.com/apache/airflow/pull/17405#issuecomment-892576058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [airflow] potiuk commented on a change in pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
potiuk commented on a change in pull request #17356: URL: https://github.com/apache/airflow/pull/17356#discussion_r682549353 ## File path: .dockerignore ## @@ -40,9 +40,6 @@ !scripts/in_container !scripts/docker -# Add provider packages to the context -!provider_packages R

[GitHub] [airflow] ephraimbuddy closed pull request #17265: Use `dag_maker` fixture in test_scheduler_job.py

2021-08-05 Thread GitBox
ephraimbuddy closed pull request #17265: URL: https://github.com/apache/airflow/pull/17265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [airflow] github-actions[bot] commented on pull request #17424: Fix failing static checks in main

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17424: URL: https://github.com/apache/airflow/pull/17424#issuecomment-892977748 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] mongakshay removed a comment on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2021-08-05 Thread GitBox
mongakshay removed a comment on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-892630614 I am also noticing this issue with my Airflow v2.1.2 instance, where the task is forever in queued state, and in the scheduler log I see ``` airflow-scheduler1_1

[GitHub] [airflow] github-actions[bot] commented on pull request #17418: Optimizes structure of the Dockerfiles and use latest tools

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17418: URL: https://github.com/apache/airflow/pull/17418#issuecomment-892950913 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] bbovenzi commented on issue #17413: Clicking the "Update" button in the "Tree View" of the DAG deletes the DAG runs from UI

2021-08-05 Thread GitBox
bbovenzi commented on issue #17413: URL: https://github.com/apache/airflow/issues/17413#issuecomment-892646712 @mongakshay Could you provide more details? - What version of Airflow are you using? - Which button are you pressing? The refresh button in the graph below or the one that si

[GitHub] [airflow] potiuk commented on pull request #16915: New generic tableau operator: TableauOperator

2021-08-05 Thread GitBox
potiuk commented on pull request #16915: URL: https://github.com/apache/airflow/pull/16915#issuecomment-892522589 Static checks and docs are still failing I am afraid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] lewis-anderson53 commented on issue #13750: Support Standard SQL in BigQuery Sensor

2021-08-05 Thread GitBox
lewis-anderson53 commented on issue #13750: URL: https://github.com/apache/airflow/issues/13750#issuecomment-892585708 I too quite like the hook_kwargs option, as it would solve other db hook default issues too, not just BigQuery one. -- This is an automated message from the Apache Git S

[GitHub] [airflow] potiuk commented on a change in pull request #17400: Example dag slackfile

2021-08-05 Thread GitBox
potiuk commented on a change in pull request #17400: URL: https://github.com/apache/airflow/pull/17400#discussion_r683187682 ## File path: airflow/utils/log/file_task_handler.py ## @@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None): response.e

[GitHub] [airflow] github-actions[bot] commented on pull request #17399: Adding JWT, IP filtering, and direct session login support for SalesforceHook

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17399: URL: https://github.com/apache/airflow/pull/17399#issuecomment-892589165 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] fatmumuhomer commented on pull request #17236: [Airflow 16364] Add conn_timeout and cmd_timeout params to SSHOperator; add conn_timeout param to SSHHook

2021-08-05 Thread GitBox
fatmumuhomer commented on pull request #17236: URL: https://github.com/apache/airflow/pull/17236#issuecomment-893106346 FYI - I added conn_timeout to ssh.rst alongside timeout. I considered using the deprecated directive, but it requires a version which hasn't been set yet. It wouldn't be

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17429: Scan the DAGs directory for new files througth restfull API

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on issue #17429: URL: https://github.com/apache/airflow/issues/17429#issuecomment-893159340 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] potiuk merged pull request #17432: Fixes some static check errors

2021-08-05 Thread GitBox
potiuk merged pull request #17432: URL: https://github.com/apache/airflow/pull/17432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] msumit commented on a change in pull request #17100: WIP: Advanced Params using json-schema

2021-08-05 Thread GitBox
msumit commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r682534162 ## File path: airflow/models/dag.py ## @@ -2312,6 +2327,19 @@ def set_edge_info(self, upstream_task_id: str, downstream_task_id: str, info: Ed

[GitHub] [airflow] ashb commented on issue #8907: Airflow web UI is slow

2021-08-05 Thread GitBox
ashb commented on issue #8907: URL: https://github.com/apache/airflow/issues/8907#issuecomment-892586860 It's _always_ DNS. Even when you think it's not DNS and you check for DNS problems, it's always DNS problems. -- This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] BasPH commented on pull request #17427: Updating INTHEWILD.md

2021-08-05 Thread GitBox
BasPH commented on pull request #17427: URL: https://github.com/apache/airflow/pull/17427#issuecomment-893264022 Welcome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [airflow] jedcunningham commented on a change in pull request #17424: Fix failing static checks in main

2021-08-05 Thread GitBox
jedcunningham commented on a change in pull request #17424: URL: https://github.com/apache/airflow/pull/17424#discussion_r682964300 ## File path: airflow/utils/log/file_task_handler.py ## @@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None): res

[GitHub] [airflow] BasPH merged pull request #17427: Updating INTHEWILD.md

2021-08-05 Thread GitBox
BasPH merged pull request #17427: URL: https://github.com/apache/airflow/pull/17427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] potiuk closed issue #17401: users/list error

2021-08-05 Thread GitBox
potiuk closed issue #17401: URL: https://github.com/apache/airflow/issues/17401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] ashb commented on a change in pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
ashb commented on a change in pull request #17356: URL: https://github.com/apache/airflow/pull/17356#discussion_r682522181 ## File path: .dockerignore ## @@ -40,9 +40,6 @@ !scripts/in_container !scripts/docker -# Add provider packages to the context -!provider_packages Rev

[GitHub] [airflow-site] potiuk edited a comment on pull request #462: Add Seniorlink to Use Cases

2021-08-05 Thread GitBox
potiuk edited a comment on pull request #462: URL: https://github.com/apache/airflow-site/pull/462#issuecomment-893311916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17413: Clicking the "Update" button in the "Tree View" of the DAG deletes the DAG runs from UI

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on issue #17413: URL: https://github.com/apache/airflow/issues/17413#issuecomment-892629143 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] potiuk commented on issue #16238: Airflow Tree View for larger dags

2021-08-05 Thread GitBox
potiuk commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-893203966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] github-actions[bot] commented on pull request #17431: Add back missing permissions to UserModelView controls.

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17431: URL: https://github.com/apache/airflow/pull/17431#issuecomment-893295662 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] raajpackt commented on issue #16238: Airflow Tree View for larger dags

2021-08-05 Thread GitBox
raajpackt commented on issue #16238: URL: https://github.com/apache/airflow/issues/16238#issuecomment-893193797 Should this bug still exist in `airflow:2.1.0` ? Because i am using that version and it exists. Will this be resolved in future versions? -- This is an automated message fr

[GitHub] [airflow] github-actions[bot] commented on pull request #17420: Update emr.rst

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17420: URL: https://github.com/apache/airflow/pull/17420#issuecomment-893004207 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow-site] christopherpetrino commented on pull request #462: Add Seniorlink to Use Cases

2021-08-05 Thread GitBox
christopherpetrino commented on pull request #462: URL: https://github.com/apache/airflow-site/pull/462#issuecomment-892704152 Thanks, Jarek -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] github-actions[bot] commented on pull request #17412: Add timeout when asking whether to rebuild image

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17412: URL: https://github.com/apache/airflow/pull/17412#issuecomment-892613775 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] github-actions[bot] commented on pull request #17405: Put the XCom.clear logic into XCom class to allow it hookable in custom XCom backend

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17405: URL: https://github.com/apache/airflow/pull/17405#issuecomment-892568323 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] github-actions[bot] closed pull request #16003: Fixed Discord Webhook endpoint

2021-08-05 Thread GitBox
github-actions[bot] closed pull request #16003: URL: https://github.com/apache/airflow/pull/16003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17428: Fix elasticsearch-secret template port default function

2021-08-05 Thread GitBox
boring-cyborg[bot] commented on pull request #17428: URL: https://github.com/apache/airflow/pull/17428#issuecomment-893149835 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] ashb commented on a change in pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

2021-08-05 Thread GitBox
ashb commented on a change in pull request #17425: URL: https://github.com/apache/airflow/pull/17425#discussion_r683338533 ## File path: tests/models/test_taskinstance.py ## @@ -437,75 +442,51 @@ def create_task_instance(): create_task_instance() @provide_se

[GitHub] [airflow] wanderijames commented on a change in pull request #17178: Amazon EMR on Amazon EKS

2021-08-05 Thread GitBox
wanderijames commented on a change in pull request #17178: URL: https://github.com/apache/airflow/pull/17178#discussion_r682838986 ## File path: airflow/providers/amazon/aws/operators/emr_containers_start_job.py ## @@ -0,0 +1,95 @@ +# +# Licensed to the Apache Software Foundati

[GitHub] [airflow] potiuk commented on pull request #17356: Switches to "/" convention in ghcr.io images

2021-08-05 Thread GitBox
potiuk commented on pull request #17356: URL: https://github.com/apache/airflow/pull/17356#issuecomment-892604803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [airflow] potiuk commented on pull request #17423: Make schema in DBApiHook private

2021-08-05 Thread GitBox
potiuk commented on pull request #17423: URL: https://github.com/apache/airflow/pull/17423#issuecomment-893288824 Fixed all the problems - looking for other's opinion of what will be the best solution to DBApiHook modifications vs. Providers. -- This is an automated message from the Ap

[GitHub] [airflow] mongakshay commented on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2021-08-05 Thread GitBox
mongakshay commented on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-892630614 I am also noticing this issue with my Airflow v2.1.2 instance, where the task is forever in queued state, and in the scheduler log I see ``` airflow-scheduler1_1 | [2021-

[GitHub] [airflow] uranusjr commented on a change in pull request #17408: Fix the issue #17371 to load the file contents

2021-08-05 Thread GitBox
uranusjr commented on a change in pull request #17408: URL: https://github.com/apache/airflow/pull/17408#discussion_r682504788 ## File path: airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py ## @@ -71,7 +71,7 @@ def execute(self, context): group=self.

[GitHub] [airflow] sighingnow closed pull request #17430: Respect the AIRFLOW__CORE__MP_START_METHOD config in CeleryExecutor.

2021-08-05 Thread GitBox
sighingnow closed pull request #17430: URL: https://github.com/apache/airflow/pull/17430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [airflow] flolas edited a comment on pull request #17329: Split sql statements in DbApi run

2021-08-05 Thread GitBox
flolas edited a comment on pull request #17329: URL: https://github.com/apache/airflow/pull/17329#issuecomment-893071375 > sqlparse is not a core dependency -- it needs adding. Hi @ashb, what do you mean with "it needs adding"? I added sqlparse to setup.cfg. We need to do anything el

[GitHub] [airflow] fmv1992 commented on issue #13637: Scheduler takes 100% of CPU without task execution

2021-08-05 Thread GitBox
fmv1992 commented on issue #13637: URL: https://github.com/apache/airflow/issues/13637#issuecomment-892768703 Setting the following helped immensely: ``` [core] min_serialized_dag_update_interval = 600 min_serialized_dag_fetch_interval = 300 [scheduler] min_file_process

[GitHub] [airflow] txicos commented on issue #17120: [Scheduler error] psycopg2.OperationalError: SSL SYSCALL error: Socket operation on non-socket

2021-08-05 Thread GitBox
txicos commented on issue #17120: URL: https://github.com/apache/airflow/issues/17120#issuecomment-893024484 Hi, Hi I also applied suggested correction and raised an Exception just after entering method `create_scheduler_job`, which indeed occurred when executing `airflow schedule

[GitHub] [airflow] github-actions[bot] commented on issue #16344: Tried to upgrade to Airflow 2.1.0

2021-08-05 Thread GitBox
github-actions[bot] commented on issue #16344: URL: https://github.com/apache/airflow/issues/16344#issuecomment-893056827 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] ephraimbuddy commented on issue #17395: DAG is executed twice on submit

2021-08-05 Thread GitBox
ephraimbuddy commented on issue #17395: URL: https://github.com/apache/airflow/issues/17395#issuecomment-893233185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [airflow] github-actions[bot] commented on pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

2021-08-05 Thread GitBox
github-actions[bot] commented on pull request #17425: URL: https://github.com/apache/airflow/pull/17425#issuecomment-893358618 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] ashb commented on a change in pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

2021-08-05 Thread GitBox
ashb commented on a change in pull request #17425: URL: https://github.com/apache/airflow/pull/17425#discussion_r683341086 ## File path: tests/models/test_taskinstance.py ## @@ -437,75 +442,51 @@ def create_task_instance(): create_task_instance() @provide_se

[GitHub] [airflow] ashb commented on a change in pull request #17425: Use `dag_maker` fixture in models/test_taskinstance.py

2021-08-05 Thread GitBox
ashb commented on a change in pull request #17425: URL: https://github.com/apache/airflow/pull/17425#discussion_r683338533 ## File path: tests/models/test_taskinstance.py ## @@ -437,75 +442,51 @@ def create_task_instance(): create_task_instance() @provide_se

[GitHub] [airflow] ephraimbuddy opened a new pull request #17441: Quarantine TestLocalTaskJob.test_process_sigterm_works_with_retries

2021-08-05 Thread GitBox
ephraimbuddy opened a new pull request #17441: URL: https://github.com/apache/airflow/pull/17441 This test is flaky and fails sometime See : https://github.com/apache/airflow/issues/17439 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](htt

[GitHub] [airflow] potiuk edited a comment on issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk edited a comment on issue #17437: URL: https://github.com/apache/airflow/issues/17437#issuecomment-893348355 I think, before you start requesting new features, it is great to check if the existing features are not working well for you: 1) Did you try to configure multiple sche

[GitHub] [airflow] wojsamjan opened a new pull request #17440: Fix Google Cloud Operators docs

2021-08-05 Thread GitBox
wojsamjan opened a new pull request #17440: URL: https://github.com/apache/airflow/pull/17440 This PR fixes Google Cloud Operators docs at: https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/index.html Right now, we are listing operations (from Cre

[GitHub] [airflow] ephraimbuddy opened a new issue #17439: Quarantine TestLocalTaskJob.test_process_sigterm_works_with_retries

2021-08-05 Thread GitBox
ephraimbuddy opened a new issue #17439: URL: https://github.com/apache/airflow/issues/17439 This test fails sometimes: ``` ___ TestLocalTaskJob.test_process_sigterm_works_with_retries ___ self = dag_maker = .DagFactory object at 0x7f3d38917760>

[GitHub] [airflow] potiuk edited a comment on issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk edited a comment on issue #17437: URL: https://github.com/apache/airflow/issues/17437#issuecomment-893348355 I think, before you start requesting new features, it is great to check if the existing features are not working well for you: 1) Did you try to configure multiple sche

[GitHub] [airflow] potiuk edited a comment on issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk edited a comment on issue #17437: URL: https://github.com/apache/airflow/issues/17437#issuecomment-893348355 I think, before you start requesting new features, it is great to check if the existing features are not working well for you: 1) Did you try to configure multiple sche

[GitHub] [airflow] yevsh edited a comment on issue #17395: DAG is executed twice on submit

2021-08-05 Thread GitBox
yevsh edited a comment on issue #17395: URL: https://github.com/apache/airflow/issues/17395#issuecomment-893348259 very simple python that I just created. And placed it in dags folder. ``` from airflow import DAG from datetime import timedelta from airflow.utils.dates

[GitHub] [airflow] potiuk commented on issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk commented on issue #17437: URL: https://github.com/apache/airflow/issues/17437#issuecomment-893348355 I think, before you start requesting new features, it is great to check if the existing features are not working well for you: 1) Did you try to configure multiple schedulers?

[GitHub] [airflow] potiuk closed issue #17437: It's too slow to recognize new dag file when there is a log of dags files

2021-08-05 Thread GitBox
potiuk closed issue #17437: URL: https://github.com/apache/airflow/issues/17437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] yevsh commented on issue #17395: DAG is executed twice on submit

2021-08-05 Thread GitBox
yevsh commented on issue #17395: URL: https://github.com/apache/airflow/issues/17395#issuecomment-893348259 very simple python that I just created. And placed it in dags folder. ``` from airflow import DAG from datetime import timedelta from airflow.utils.dates import

[GitHub] [airflow] georborodin edited a comment on pull request #17426: Allow using default celery commands for custom Celery executors subclassed from existing

2021-08-05 Thread GitBox
georborodin edited a comment on pull request #17426: URL: https://github.com/apache/airflow/pull/17426#issuecomment-893309025 @potiuk @ephraimbuddy I tried to merge your suggestions into one, please see ~~1921b98~~ 54ce5ff (used plain string in first commit, would've returned mro for str t

<    1   2   3   4   >