[GitHub] [airflow] uranusjr commented on a change in pull request #16666: Replace execution_date with run_id in airflow tasks run command

2021-08-19 Thread GitBox
uranusjr commented on a change in pull request #1: URL: https://github.com/apache/airflow/pull/1#discussion_r691842893 ## File path: airflow/models/taskinstance.py ## @@ -465,6 +466,22 @@ def next_try_number(self): """Setting Next Try Number""" return

[GitHub] [airflow] msumit commented on a change in pull request #17100: WIP: Advanced Params using json-schema

2021-08-19 Thread GitBox
msumit commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r691859343 ## File path: airflow/models/dag.py ## @@ -2312,6 +2327,19 @@ def set_edge_info(self, upstream_task_id: str, downstream_task_id: str, info: Ed

[GitHub] [airflow] ashb commented on pull request #16571: Implemented Basic EKS Integration

2021-08-19 Thread GitBox
ashb commented on pull request #16571: URL: https://github.com/apache/airflow/pull/16571#issuecomment-901726053 Yup, image looks good now. Previously it was a 98B file, now it's 11KiB :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] github-actions[bot] commented on pull request #16571: Implemented Basic EKS Integration

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #16571: URL: https://github.com/apache/airflow/pull/16571#issuecomment-901726240 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] ashb merged pull request #16571: Implemented Basic EKS Integration

2021-08-19 Thread GitBox
ashb merged pull request #16571: URL: https://github.com/apache/airflow/pull/16571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] ashb closed issue #8544: Create EKS operators

2021-08-19 Thread GitBox
ashb closed issue #8544: URL: https://github.com/apache/airflow/issues/8544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[airflow] branch main updated (3b41bb4 -> bee48f3)

2021-08-19 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 3b41bb4 Doc: Replace deprecated param from docstrings (#17709) add bee48f3 Implemented Basic EKS Integration (#165

[GitHub] [airflow] ashb merged pull request #17700: Add error check for config_file parameter in GKEStartPodOperator

2021-08-19 Thread GitBox
ashb merged pull request #17700: URL: https://github.com/apache/airflow/pull/17700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[airflow] branch main updated (bee48f3 -> b68d193)

2021-08-19 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from bee48f3 Implemented Basic EKS Integration (#16571) add b68d193 Add error check for config_file parameter in GKESt

[airflow] branch main updated (b68d193 -> 95b2685)

2021-08-19 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from b68d193 Add error check for config_file parameter in GKEStartPodOperator (#17700) add 95b2685 Use `dag_maker` fix

[GitHub] [airflow] ashb merged pull request #17556: Use `dag_maker` fixture in some test files under tests/models

2021-08-19 Thread GitBox
ashb merged pull request #17556: URL: https://github.com/apache/airflow/pull/17556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] uranusjr commented on a change in pull request #17122: AIP-39: Add logical_date to OpenAPI DAGRun schema

2021-08-19 Thread GitBox
uranusjr commented on a change in pull request #17122: URL: https://github.com/apache/airflow/pull/17122#discussion_r691921974 ## File path: airflow/models/dag.py ## @@ -2097,19 +2097,25 @@ def create_dagrun( :param data_interval: Data interval of the DagRun :

[GitHub] [airflow] uranusjr commented on a change in pull request #17122: AIP-39: Add logical_date to OpenAPI DAGRun schema

2021-08-19 Thread GitBox
uranusjr commented on a change in pull request #17122: URL: https://github.com/apache/airflow/pull/17122#discussion_r691921974 ## File path: airflow/models/dag.py ## @@ -2097,19 +2097,25 @@ def create_dagrun( :param data_interval: Data interval of the DagRun :

[airflow] branch main updated (95b2685 -> 8cdda20)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 95b2685 Use `dag_maker` fixture in some test files under tests/models (#17556) add 8cdda20 Doc: Fix replaci

[GitHub] [airflow] kaxil merged pull request #17711: Doc: Fix replacing Airflow version for Docker stack

2021-08-19 Thread GitBox
kaxil merged pull request #17711: URL: https://github.com/apache/airflow/pull/17711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] kaxil merged pull request #17710: Doc: Update Upgrade to 2 docs with Airflow 1.10.x EOL dates

2021-08-19 Thread GitBox
kaxil merged pull request #17710: URL: https://github.com/apache/airflow/pull/17710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[airflow] branch main updated (8cdda20 -> 6ba538f)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8cdda20 Doc: Fix replacing Airflow version for Docker stack (#17711) add 6ba538f Doc: Update Upgrade to 2 do

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
ephraimbuddy commented on a change in pull request #17207: URL: https://github.com/apache/airflow/pull/17207#discussion_r691914862 ## File path: airflow/cli/commands/task_command.py ## @@ -174,6 +175,14 @@ def _run_raw_task(args, ti: TaskInstance) -> None: ) +def _extr

[GitHub] [airflow] spniemansburg commented on issue #16717: Airflow 2.1.0: Snowflake connection not enabling snowflake "role"

2021-08-19 Thread GitBox
spniemansburg commented on issue #16717: URL: https://github.com/apache/airflow/issues/16717#issuecomment-901748260 Issue is closed, but wanted to note that the same issue is happening when trying to add a private key file (using "private_key_file" parameter) in the Extra field. I am using

[GitHub] [airflow] raphaelauv commented on a change in pull request #17683: rename none_failed_or_skipped by none_failed_and_at_least_one_succeed

2021-08-19 Thread GitBox
raphaelauv commented on a change in pull request #17683: URL: https://github.com/apache/airflow/pull/17683#discussion_r691954797 ## File path: airflow/utils/trigger_rule.py ## @@ -32,6 +32,7 @@ class TriggerRule: NONE_SKIPPED = 'none_skipped' DUMMY = 'dummy' ALWA

[GitHub] [airflow] raphaelauv commented on pull request #17683: rename none_failed_or_skipped by none_failed_and_at_least_one_succeed

2021-08-19 Thread GitBox
raphaelauv commented on pull request #17683: URL: https://github.com/apache/airflow/pull/17683#issuecomment-901768678 thanks for the review @kaxil , I updated the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[airflow] branch constraints-main updated: Updating constraints. Build id:1146329950

2021-08-19 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 71c0d8f Updating const

[GitHub] [airflow] vikramcse opened a new issue #17715: `conf` is None in the get_current_context()

2021-08-19 Thread GitBox
vikramcse opened a new issue #17715: URL: https://github.com/apache/airflow/issues/17715 **Apache Airflow version**: Airflow 2.1.2 Database: MySQL 8.0 **OS**: NAME="Ubuntu" VERSION="18.04.4 LTS (Bionic Beaver)" **Deployment**: Docker-compose **What h

[GitHub] [airflow] potiuk commented on pull request #17682: Import Hooks lazily individually in providers manager

2021-08-19 Thread GitBox
potiuk commented on pull request #17682: URL: https://github.com/apache/airflow/pull/17682#issuecomment-901789858 Yeah. I want to do separate doc change where i will extract all those into separate pages in the documentation of providers a s do interlinking with the main docs. -- This

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901794731 You could try Fri. The main branch of airflow. We are following a release process where we vote and put version etc. But you can install the 'main' version too (with some potential

[GitHub] [airflow] potiuk edited a comment on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk edited a comment on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901794731 You could try the main branch of airflow. We are following a release process where we vote and put version etc. But you can install the 'main' version too (with some potentia

[GitHub] [airflow] yevsh commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
yevsh commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901811918 now pod is not restarting. from within the container (bash), running command 'airflow' as root user still yields No module named 'airflow' is that normal? --

[GitHub] [airflow] potiuk opened a new pull request #17716: Fix instructions of release to get proper path in shasum file

2021-08-19 Thread GitBox
potiuk opened a new pull request #17716: URL: https://github.com/apache/airflow/pull/17716 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more info

[GitHub] [airflow] hkarakaki opened a new issue #17717: Task names get covered by the tree view

2021-08-19 Thread GitBox
hkarakaki opened a new issue #17717: URL: https://github.com/apache/airflow/issues/17717 **Apache Airflow version**: 2.1.2 **OS**: Ubuntu 18.04.5 **Apache Airflow Provider versions**: apache-airflow-providers-amazon==2.1.0 apache-airflow-providers-celery==2.0.0 apache

[GitHub] [airflow] ashb merged pull request #17474: Add support for configs, secrets, networks and replicas for DockerSwarmOperator

2021-08-19 Thread GitBox
ashb merged pull request #17474: URL: https://github.com/apache/airflow/pull/17474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #17474: Add support for configs, secrets, networks and replicas for DockerSwarmOperator

2021-08-19 Thread GitBox
boring-cyborg[bot] commented on pull request #17474: URL: https://github.com/apache/airflow/pull/17474#issuecomment-901818119 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] nathadfield commented on pull request #17321: Enable specifying dictionary paths in `template_fields_renderers`

2021-08-19 Thread GitBox
nathadfield commented on pull request #17321: URL: https://github.com/apache/airflow/pull/17321#issuecomment-901818140 @potiuk Might we expect the core Airflow aspect of this to appear in 2.2? I guess there would also need to be a Google provider version release afterwards too. -- This

[airflow] branch main updated: Add support for configs, secrets, networks and replicas for DockerSwarmOperator (#17474)

2021-08-19 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4da4c18 Add support for configs, secrets, networks an

[GitHub] [airflow] potiuk commented on issue #17045: "Failed to load task run error" occur in "on_failure_callback" after upgrading from 2.0.0 to 2.1.2

2021-08-19 Thread GitBox
potiuk commented on issue #17045: URL: https://github.com/apache/airflow/issues/17045#issuecomment-901822269 I suggest you to switch to Airflow's official Helm rather than running your own deployment. It is proven and works and it's the easiest way to get Airflow Up-and-running on Kuberne

[GitHub] [airflow] potiuk closed issue #17714: dag import error when using sys.path.append(str(Path('.').absolute().parent))

2021-08-19 Thread GitBox
potiuk closed issue #17714: URL: https://github.com/apache/airflow/issues/17714 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] Jorricks commented on a change in pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks commented on a change in pull request #17207: URL: https://github.com/apache/airflow/pull/17207#discussion_r692015638 ## File path: airflow/cli/commands/task_command.py ## @@ -174,6 +175,14 @@ def _run_raw_task(args, ti: TaskInstance) -> None: ) +def _extract_

[GitHub] [airflow] Jorricks commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-901830794 > I feel we should not make this change but dig more to reliably reproduce the linked issue. > On my first try, I was able to see `Scheduler marked as failed` but on sever

[GitHub] [airflow] Jorricks commented on a change in pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks commented on a change in pull request #17207: URL: https://github.com/apache/airflow/pull/17207#discussion_r692015638 ## File path: airflow/cli/commands/task_command.py ## @@ -174,6 +175,14 @@ def _run_raw_task(args, ti: TaskInstance) -> None: ) +def _extract_

[GitHub] [airflow] Jorricks edited a comment on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks edited a comment on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-901830794 > I feel we should not make this change but dig more to reliably reproduce the linked issue. > On my first try, I was able to see `Scheduler marked as failed` but on

[GitHub] [airflow] Jorricks edited a comment on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks edited a comment on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-901830794 > I feel we should not make this change but dig more to reliably reproduce the linked issue. > On my first try, I was able to see `Scheduler marked as failed` but on

[GitHub] [airflow] Jorricks edited a comment on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
Jorricks edited a comment on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-901830794 > I feel we should not make this change but dig more to reliably reproduce the linked issue. > On my first try, I was able to see `Scheduler marked as failed` but on

[GitHub] [airflow] ashb opened a new pull request #17719: Change TaskInstance and TaskReschedule from execution_date to run_id

2021-08-19 Thread GitBox
ashb opened a new pull request #17719: URL: https://github.com/apache/airflow/pull/17719 Since TaskReschedule had an existing FK to TaskInstance we had to move change both of these at the same time. This puts an explicit FK constraint between TaskInstance and DagRun, meaning tha

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17720: airflow.dates.days_ago doesn't respect configured timezone

2021-08-19 Thread GitBox
boring-cyborg[bot] commented on issue #17720: URL: https://github.com/apache/airflow/issues/17720#issuecomment-901837603 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] Xilorole opened a new issue #17720: airflow.dates.days_ago doesn't respect configured timezone

2021-08-19 Thread GitBox
Xilorole opened a new issue #17720: URL: https://github.com/apache/airflow/issues/17720 **Apache Airflow version**: 2.1.1 **OS**:Chromium OS 11.0 ( on google cloud composer) **Apache Airflow Provider versions**: **Deployment**: None

[GitHub] [airflow] potiuk opened a new pull request #17721: Improve description of Python compatibility approach

2021-08-19 Thread GitBox
potiuk opened a new pull request #17721: URL: https://github.com/apache/airflow/pull/17721 The entry was terribly out-dated. We did not have many problems with different python versions backwards compatibilty for a looong time. Seems that the new SenVer approach and release control

[GitHub] [airflow] github-actions[bot] commented on pull request #17721: Improve description of Python compatibility approach

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17721: URL: https://github.com/apache/airflow/pull/17721#issuecomment-901841608 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk commented on issue #17715: `conf` is None in the get_current_context()

2021-08-19 Thread GitBox
potiuk commented on issue #17715: URL: https://github.com/apache/airflow/issues/17715#issuecomment-901843186 That's quite strange - but just to clarify - it's not `conf`missing, it's `dag_context['"dag_run"]` returning None. I think we will not be able to help unless you provide ful

[GitHub] [airflow] potiuk closed issue #17715: `conf` is None in the get_current_context()

2021-08-19 Thread GitBox
potiuk closed issue #17715: URL: https://github.com/apache/airflow/issues/17715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] eladkal commented on issue #17429: Scan the DAGs directory for new files througth restfull API

2021-08-19 Thread GitBox
eladkal commented on issue #17429: URL: https://github.com/apache/airflow/issues/17429#issuecomment-901845779 Closing for the moment. If needed we can reopen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] eladkal closed issue #17429: Scan the DAGs directory for new files througth restfull API

2021-08-19 Thread GitBox
eladkal closed issue #17429: URL: https://github.com/apache/airflow/issues/17429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901850070 > If you enter the container via "/bin/bash" you will indeed get this error. But you should only enter the bash image via Airflow's image /entrypoint not via /bin/bash. This is the

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901850402 Are you sure you get the latest merged `main` code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] gakhrejah opened a new issue #17723: Airflow Pipelines are not scheduling after upgrading to 1.10.13

2021-08-19 Thread GitBox
gakhrejah opened a new issue #17723: URL: https://github.com/apache/airflow/issues/17723 Hi All, We have observed that some of our pipelines are not getting schedule after upgrading our Airflow from 1.10.9 to 1.10.13 version. It seems like those dags are not schedule by the schedu

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901850873 BTW. You can test if the root user works by running `/entrypoint bash` when you `exec` into the container. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] potiuk merged pull request #17721: Improve description of Python compatibility approach

2021-08-19 Thread GitBox
potiuk merged pull request #17721: URL: https://github.com/apache/airflow/pull/17721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[airflow] branch main updated (4da4c18 -> b5e6661)

2021-08-19 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 4da4c18 Add support for configs, secrets, networks and replicas for DockerSwarmOperator (#17474) add b5e6661 I

[GitHub] [airflow] ashb commented on pull request #17719: Change TaskInstance and TaskReschedule from execution_date to run_id

2021-08-19 Thread GitBox
ashb commented on pull request #17719: URL: https://github.com/apache/airflow/pull/17719#issuecomment-901853325 > I'm wondering if https://github.com/apache/airflow/blob/4da4c186ecdcdae308fe8b4a7994c21faf42bc96/airflow/www/views.py#L1485-L1486 need a change too? Yes it should. It'll

[GitHub] [airflow] uranusjr commented on a change in pull request #17122: AIP-39: Add logical_date to OpenAPI DAGRun schema

2021-08-19 Thread GitBox
uranusjr commented on a change in pull request #17122: URL: https://github.com/apache/airflow/pull/17122#discussion_r691921974 ## File path: airflow/models/dag.py ## @@ -2097,19 +2097,25 @@ def create_dagrun( :param data_interval: Data interval of the DagRun :

[GitHub] [airflow] potiuk closed issue #17723: Airflow Pipelines are not scheduling after upgrading to 1.10.13

2021-08-19 Thread GitBox
potiuk closed issue #17723: URL: https://github.com/apache/airflow/issues/17723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] yevsh commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
yevsh commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901871648 I just added - /entrypoint to scheduler-deployment.yaml and pod is not restarting . /entrypoint bash when you exec into the container. also works -- This is an

[GitHub] [airflow] yevsh edited a comment on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
yevsh edited a comment on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901871648 I just added - /entrypoint to scheduler-deployment.yaml and pod is not restarting . /entrypoint bash when you exec into the container, airflow command also wo

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901872500 What error do you see? "Pod not restarting" is really vague description that is difficult to reason about :) -- This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] potiuk edited a comment on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk edited a comment on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901872500 What errors do you see? "Pod not restarting" is really vague description that is difficult to reason about :) -- This is an automated message from the Apache Git Service. T

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901873463 Side comment. I really, really love the non-empathetic "it does not work" description of the bug when you want to get some help. It's never helpful and a bit frustrating. -- Th

[GitHub] [airflow] potiuk edited a comment on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk edited a comment on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901873463 Side comment. I really, really `love` the non-empathetic "it does not work" description of the bug when you want to get some help. It's never helpful and a bit frustrating.

[GitHub] [airflow] yevsh commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
yevsh commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901875613 no erros -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] yevsh edited a comment on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
yevsh edited a comment on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901875613 no erros = pod not restarting = good :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] dinigo commented on a change in pull request #17592: Support for passing arguments to SqlSensor underlying hooks

2021-08-19 Thread GitBox
dinigo commented on a change in pull request #17592: URL: https://github.com/apache/airflow/pull/17592#discussion_r692068934 ## File path: airflow/sensors/sql.py ## @@ -90,7 +105,7 @@ def _get_hook(self): f"Connection type ({conn.conn_type}) is not supported by

[GitHub] [airflow] dinigo commented on a change in pull request #17592: Support for passing arguments to SqlSensor underlying hooks

2021-08-19 Thread GitBox
dinigo commented on a change in pull request #17592: URL: https://github.com/apache/airflow/pull/17592#discussion_r692071092 ## File path: tests/sensors/test_sql_sensor.py ## @@ -242,6 +242,22 @@ def test_sql_sensor_postgres_poke_invalid_success(self, mock_hook):

[GitHub] [airflow] nikiit007 opened a new issue #17725: Airflow 2.0.2 Github Enterprise OAuth giving 404 error

2021-08-19 Thread GitBox
nikiit007 opened a new issue #17725: URL: https://github.com/apache/airflow/issues/17725 **Apache Airflow version:** _2.0.2_ **OS:** _PRETTY_NAME="Debian GNU/Linux 10 (buster)" NAME="Debian GNU/Linux" VERSION_ID="10" VERSION="10 (buster)" VERSION_CODENAME=buster

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17725: Airflow 2.0.2 Github Enterprise OAuth giving 404 error

2021-08-19 Thread GitBox
boring-cyborg[bot] commented on issue #17725: URL: https://github.com/apache/airflow/issues/17725#issuecomment-901886266 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] github-actions[bot] commented on pull request #17682: Import Hooks lazily individually in providers manager

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17682: URL: https://github.com/apache/airflow/pull/17682#issuecomment-901889092 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] kaxil merged pull request #17716: Fix instructions of release to get proper path in shasum file

2021-08-19 Thread GitBox
kaxil merged pull request #17716: URL: https://github.com/apache/airflow/pull/17716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[airflow] branch main updated (b5e6661 -> 02fbe44)

2021-08-19 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from b5e6661 Improve description of Python compatibility approach (#17721) add 02fbe44 Fix instructions of releas

[GitHub] [airflow] uranusjr opened a new issue #17726: Make the DAG's upcoming scheduled run visible in UI

2021-08-19 Thread GitBox
uranusjr opened a new issue #17726: URL: https://github.com/apache/airflow/issues/17726 Now we’ve got most of the AIP-39 foundation down, we can tackle what https://github.com/apache/airflow/pull/2460 wanted to achieve. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [airflow] mnojek opened a new issue #17727: Duplicated general notifications in Airflow UI above DAGs list

2021-08-19 Thread GitBox
mnojek opened a new issue #17727: URL: https://github.com/apache/airflow/issues/17727 **Apache Airflow version**: 2.2.0.dev0 (possible older versions too) **OS**: Linux Debian 11 (BTW Here we have a typo in comment inside bug report template in `.github/ISSUE_TEMPLATE/bu

[GitHub] [airflow] boring-cyborg[bot] commented on issue #17727: Duplicated general notifications in Airflow UI above DAGs list

2021-08-19 Thread GitBox
boring-cyborg[bot] commented on issue #17727: URL: https://github.com/apache/airflow/issues/17727#issuecomment-901894584 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] kaxil commented on a change in pull request #17683: rename none_failed_or_skipped by none_failed_min_one_success

2021-08-19 Thread GitBox
kaxil commented on a change in pull request #17683: URL: https://github.com/apache/airflow/pull/17683#discussion_r692086228 ## File path: UPDATING.md ## @@ -89,6 +89,11 @@ installing Airflow, example for Python 3.8 and Airflow 2.1.2: pip install -U "apache-airflow[pandas]==2.1

[GitHub] [airflow] kaxil commented on a change in pull request #17683: rename none_failed_or_skipped by none_failed_min_one_success

2021-08-19 Thread GitBox
kaxil commented on a change in pull request #17683: URL: https://github.com/apache/airflow/pull/17683#discussion_r692087187 ## File path: airflow/models/baseoperator.py ## @@ -551,6 +551,15 @@ def __init__( ) trigger_rule = TriggerRule.ALWAYS +

[GitHub] [airflow] github-actions[bot] commented on pull request #17683: rename none_failed_or_skipped by none_failed_min_one_success

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17683: URL: https://github.com/apache/airflow/pull/17683#issuecomment-901895571 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr opened a new pull request #17728: Do not let create_dagrun overwrite explicit run_id

2021-08-19 Thread GitBox
uranusjr opened a new pull request #17728: URL: https://github.com/apache/airflow/pull/17728 Previous `DAG.create_dagrun()` has an weird behavior that when *all* of `run_id`, `execution_date`, and `run_type` are provided, the function would ignore the `run_id` argument and overwrite it by

[GitHub] [airflow] kaxil commented on a change in pull request #17708: Rename ``task_concurrency`` to ``max_active_tis_per_dag``

2021-08-19 Thread GitBox
kaxil commented on a change in pull request #17708: URL: https://github.com/apache/airflow/pull/17708#discussion_r692091900 ## File path: tests/serialization/test_dag_serialization.py ## @@ -887,6 +887,7 @@ def test_no_new_fields_added_to_base_operator(self): 'exec

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901904149 :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901904491 Cool ! Sorry, misunderstood it ❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901904926 Glad it helped ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] potiuk commented on issue #17679: Airflow not running as root when deployed to k8s via helm

2021-08-19 Thread GitBox
potiuk commented on issue #17679: URL: https://github.com/apache/airflow/issues/17679#issuecomment-901905550 Thanks @jedcunningham ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] microhuang commented on issue #15687: celery worker can't read dags from db

2021-08-19 Thread GitBox
microhuang commented on issue #15687: URL: https://github.com/apache/airflow/issues/15687#issuecomment-901906001 me too, +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] microhuang edited a comment on issue #15687: celery worker can't read dags from db

2021-08-19 Thread GitBox
microhuang edited a comment on issue #15687: URL: https://github.com/apache/airflow/issues/15687#issuecomment-901906001 me too, +1. airflow==2.1.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] uranusjr commented on pull request #17122: AIP-39: Add logical_date to OpenAPI DAGRun schema

2021-08-19 Thread GitBox
uranusjr commented on pull request #17122: URL: https://github.com/apache/airflow/pull/17122#issuecomment-901921836 Tests are failing due to #17728. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk opened a new pull request #17729: Automatically use utf8mb3_general_ci collation for mysql

2021-08-19 Thread GitBox
potiuk opened a new pull request #17729: URL: https://github.com/apache/airflow/pull/17729 The index size is too big in case utf8mb4 is used as encoding for MySQL database. We already had `sql_engine_collation_for_ids` configuration to allow the id fields to use different collation,

[GitHub] [airflow] github-actions[bot] commented on pull request #17728: Do not let create_dagrun overwrite explicit run_id

2021-08-19 Thread GitBox
github-actions[bot] commented on pull request #17728: URL: https://github.com/apache/airflow/pull/17728#issuecomment-901924318 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-19 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901925105 OK. I think I addressed it it in #17729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] potiuk commented on pull request #17603: Fix MySQL database character set instruction

2021-08-19 Thread GitBox
potiuk commented on pull request #17603: URL: https://github.com/apache/airflow/pull/17603#issuecomment-901925573 No SQLAlchemy internals needed ;). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] ephraimbuddy commented on pull request #17207: WIP: Fix external_executor_id not being set for manually run jobs.

2021-08-19 Thread GitBox
ephraimbuddy commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-901928314 > > I feel we should not make this change but dig more to reliably reproduce the linked issue. > > On my first try, I was able to see `Scheduler marked as failed` but o

[GitHub] [airflow] kaxil commented on a change in pull request #15385: Added table to view providers in airflow ui under admin tab

2021-08-19 Thread GitBox
kaxil commented on a change in pull request #15385: URL: https://github.com/apache/airflow/pull/15385#discussion_r692126612 ## File path: tests/www/views/test_views.py ## @@ -93,6 +93,24 @@ def test_plugin_endpoint_should_not_be_unauthenticated(app): check_content_in_respo

[GitHub] [airflow] kaxil commented on a change in pull request #16647: Move FABs base Security Manager into Airflow.

2021-08-19 Thread GitBox
kaxil commented on a change in pull request #16647: URL: https://github.com/apache/airflow/pull/16647#discussion_r692128122 ## File path: NOTICE ## @@ -12,3 +12,11 @@ This product contains a modified portion of 'Hue' developed by Cloudera, Inc. (https://github.com/cloudera/hu

[GitHub] [airflow] madhusudhan0542 commented on issue #17573: importing Operators directly from DAGS folder in airflow

2021-08-19 Thread GitBox
madhusudhan0542 commented on issue #17573: URL: https://github.com/apache/airflow/issues/17573#issuecomment-901939710 Yes, we can import a file to the dag files by just importing them as if we do in python, ex: "from operators.MsSqlOperator import ms_sql" . I can make this happen in my lo

[GitHub] [airflow] potiuk opened a new pull request #17731: Make sure "podcution-readiness` of docker-compose is well explained

2021-08-19 Thread GitBox
potiuk opened a new pull request #17731: URL: https://github.com/apache/airflow/pull/17731 Many Airflow users are using the docker-compose `quick-start` as production-ready solution despite notes in the compose file. This PR adds better warning and a link that we can give thsoe

[GitHub] [airflow] bbovenzi opened a new pull request #17732: Add Next Run to UI

2021-08-19 Thread GitBox
bbovenzi opened a new pull request #17732: URL: https://github.com/apache/airflow/pull/17732 Adds info on the next run from `next_dagrun` in the hoem page list of all dags and on the individual dag pages. #17726 Unfortunately, `next_dagrun` only existed on `DagModel` and not `

[GitHub] [airflow] potiuk commented on pull request #17731: Make sure "podcution-readiness` of docker-compose is well explained

2021-08-19 Thread GitBox
potiuk commented on pull request #17731: URL: https://github.com/apache/airflow/pull/17731#issuecomment-901953576 @kaxil @jhtimmins - I think we might want to cherry-pick that one when preparing documentation push for Airflow 2.1.3. We have more and more users who 'expect' the quick-start

  1   2   3   >