[GitHub] [airflow] pembo13 edited a comment on issue #13322: Backfill crashes with "KeyError: TaskInstanceKey" when task has retries

2021-09-03 Thread GitBox
pembo13 edited a comment on issue #13322: URL: https://github.com/apache/airflow/issues/13322#issuecomment-912878593 I seem to be getting the same error with `apache-airflow==2.0.0`? Should I create a new issue? In my case, I successfully ran `airflow dags backfill` and now can't run

[GitHub] [airflow] pembo13 commented on issue #13322: Backfill crashes with "KeyError: TaskInstanceKey" when task has retries

2021-09-03 Thread GitBox
pembo13 commented on issue #13322: URL: https://github.com/apache/airflow/issues/13322#issuecomment-912878593 I seem to be getting the same error with `apache-airflow==2.0.0`? Should I create a new issue? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] github-actions[bot] commented on issue #9780: DataProcOperator: TypeError: upload() got an unexpected keyword argument 'bucket_name'

2021-09-03 Thread GitBox
github-actions[bot] commented on issue #9780: URL: https://github.com/apache/airflow/issues/9780#issuecomment-912870547 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further ac

[GitHub] [airflow] github-actions[bot] commented on issue #10210: SQSSensor Dag is not triggering whenever there is new message.

2021-09-03 Thread GitBox
github-actions[bot] commented on issue #10210: URL: https://github.com/apache/airflow/issues/10210#issuecomment-912870540 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] closed pull request #16960: [Airflow 16934] fix delete task_instance also deleted dag_run too when sla

2021-09-03 Thread GitBox
github-actions[bot] closed pull request #16960: URL: https://github.com/apache/airflow/pull/16960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] flolas commented on a change in pull request #17329: Split sql statements in DbApi run

2021-09-03 Thread GitBox
flolas commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r702201377 ## File path: airflow/hooks/dbapi.py ## @@ -176,18 +177,28 @@ def run(self, sql, autocommit=False, parameters=None, handler=None): :param handl

[GitHub] [airflow] ephraimbuddy commented on issue #18023: Many queued Dagruns created for DagRuns with a start_date in the past

2021-09-03 Thread GitBox
ephraimbuddy commented on issue #18023: URL: https://github.com/apache/airflow/issues/18023#issuecomment-912862400 It won't be a bad idea to add a limit to queued dagruns creation anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk commented on issue #18028: Status of testing Providers that were prepared on September 04, 2021

2021-09-03 Thread GitBox
potiuk commented on issue #18028: URL: https://github.com/apache/airflow/issues/18028#issuecomment-912841631 @nathadfield - I'd appreciate if you tested the Vailt #17935 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] potiuk opened a new issue #18028: Status of testing Providers that were prepared on September 04, 2021

2021-09-03 Thread GitBox
potiuk opened a new issue #18028: URL: https://github.com/apache/airflow/issues/18028 ### Body I have a kind request for all the contributors to the latest provider packages release. Could you help us to test the RC versions of the providers and let us know in the comment, if

[airflow-site] 01/01: Addd new providers to index

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch add-new-providers-to-index in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 58008568f07f33a86347ab8bfc039dedd307 Author: Jarek Potiuk AuthorDate: Sat Sep 4 00:04:54 2

[airflow-site] branch add-new-providers-to-index created (now 5800856)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-new-providers-to-index in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 5800856 Addd new providers to index This branch includes the following new commits:

[airflow-site] branch add-documentation-2021-09-03 created (now 35d993c)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-documentation-2021-09-03 in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 35d993c Add documentation for packages - 2021-09-03 This branch includes the following

[airflow] tag providers-hashicorp/2.1.0rc2 created (now fd5d657)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to tag providers-hashicorp/2.1.0rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git. at fd5d657 (commit) No new revisions were added by this update.

[airflow] tag providers-celery/2.1.0rc2 created (now fd5d657)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to tag providers-celery/2.1.0rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git. at fd5d657 (commit) No new revisions were added by this update.

[airflow] tag providers-microsoft-psrp/1.0.1rc2 created (now fd5d657)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to tag providers-microsoft-psrp/1.0.1rc2 in repository https://gitbox.apache.org/repos/asf/airflow.git. at fd5d657 (commit) No new revisions were added by this update.

[GitHub] [airflow] ephraimbuddy edited a comment on issue #18023: Many queued Dagruns created for DagRuns with a start_date in the past

2021-09-03 Thread GitBox
ephraimbuddy edited a comment on issue #18023: URL: https://github.com/apache/airflow/issues/18023#issuecomment-912822201 > This can potentially impact the time to move a DagRun from queued to running, as the _start_queued_dagruns function has to iterate through the entire set of queued Da

svn commit: r49743 - /dev/airflow/providers/

2021-09-03 Thread potiuk
Author: potiuk Date: Fri Sep 3 21:46:10 2021 New Revision: 49743 Log: Add artifacts for Airflow Providers 2021-09-03 Added: dev/airflow/providers/apache-airflow-providers-celery-2.1.0.tar.gz (with props) dev/airflow/providers/apache-airflow-providers-celery-2.1.0.tar.gz.asc dev/ai

[GitHub] [airflow] potiuk commented on pull request #18019: Adding missing init file in Alibaba example_dags directory

2021-09-03 Thread GitBox
potiuk commented on pull request #18019: URL: https://github.com/apache/airflow/pull/18019#issuecomment-912825048 No problem. It's a minor problem and indeed missed by our tests - adding a CI test to verify that sounds like a cool idea. We already have a check that `providers/__init_.py` s

[GitHub] [airflow] mariotaddeucci opened a new pull request #18027: Added upsert method on S3ToRedshift operator

2021-09-03 Thread GitBox
mariotaddeucci opened a new pull request #18027: URL: https://github.com/apache/airflow/pull/18027 Added upsert method on S3ToRedshift operator --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTI

[GitHub] [airflow] ephraimbuddy commented on issue #18023: Many queued Dagruns created for DagRuns with a start_date in the past

2021-09-03 Thread GitBox
ephraimbuddy commented on issue #18023: URL: https://github.com/apache/airflow/issues/18023#issuecomment-912822201 > This can potentially impact the time to move a DagRun from queued to running, as the _start_queued_dagruns function has to iterate through the entire set of queued DagRuns (

[GitHub] [airflow] potiuk edited a comment on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk edited a comment on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912820115 For now - yeah. The problem is that DAG_ID and TASK_ID are also used as descriptions in the UI. And I perfectly understand why someone would like to use the national characte

[GitHub] [airflow] potiuk edited a comment on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk edited a comment on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912820115 For now - yeah. The problem is that DAG_ID and TASK_ID are also used as descriptions in the UI. And I perfectly understand why someone would like to use the national characte

[GitHub] [airflow] potiuk edited a comment on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk edited a comment on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912820115 For now - yeah. The problem is that DAG_ID and TASK_ID are also used as descriptions in the UI. And I perfectly understand why someone would like to use the national characte

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912820115 For now - yeah. The problem is that DAG_ID and TASK_ID are also used as descriptions in the UI. And I perfectly understand why someone would like to use the national characters for

[GitHub] [airflow] ephraimbuddy commented on issue #18024: Dag start date is cleared when an automatic task retry is triggered

2021-09-03 Thread GitBox
ephraimbuddy commented on issue #18024: URL: https://github.com/apache/airflow/issues/18024#issuecomment-912819359 I was not able to reproduce this in 2.1.3(using Sequential Executor) Also tested in main using LocalExecutor. -- This is an automated message from the Apache Git Ser

[GitHub] [airflow] mik-laj opened a new pull request #18026: Optimize the providers tests when running subsets of them

2021-09-03 Thread GitBox
mik-laj opened a new pull request #18026: URL: https://github.com/apache/airflow/pull/18026 Some tests take an excessively long time to run when you run a subset of the tests locally. This is because they use BaseOperator.run () which loads a lot of classes. In many cases, we can call the

[GitHub] [airflow] eladkal edited a comment on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
eladkal edited a comment on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912808261 >Agree it's likely something we should address. I am just wondering why it did not fail at trying to insert DAG to the DB - the DAG_ID there should only allow ASCII.

[GitHub] [airflow] potiuk commented on a change in pull request #18020: Adds capability of Warnings for incompatible community providers

2021-09-03 Thread GitBox
potiuk commented on a change in pull request #18020: URL: https://github.com/apache/airflow/pull/18020#discussion_r702160378 ## File path: airflow/providers_manager.py ## @@ -204,6 +205,11 @@ def wrapped_function(*args, **kwargs): return provider_info_cache_decorator +

[GitHub] [airflow] denimalpaca commented on a change in pull request #17741: Add Snowflake DQ Operators

2021-09-03 Thread GitBox
denimalpaca commented on a change in pull request #17741: URL: https://github.com/apache/airflow/pull/17741#discussion_r702159406 ## File path: airflow/providers/snowflake/operators/snowflake.py ## @@ -125,3 +126,285 @@ def execute(self, context: Any) -> None: if sel

[GitHub] [airflow] eladkal commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
eladkal commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912808261 I was able to create both dag_id and task_id with non ascii char: ``` from airflow import DAG from datetime import datetime from airflow.operators.bash import BashOperato

[GitHub] [airflow] github-actions[bot] commented on pull request #18020: Adds capability of Warnings for incompatible community providers

2021-09-03 Thread GitBox
github-actions[bot] commented on pull request #18020: URL: https://github.com/apache/airflow/pull/18020#issuecomment-912807759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] jedcunningham commented on a change in pull request #18020: Adds capability of Warnings for incompatible community providers

2021-09-03 Thread GitBox
jedcunningham commented on a change in pull request #18020: URL: https://github.com/apache/airflow/pull/18020#discussion_r702158295 ## File path: airflow/providers_manager.py ## @@ -204,6 +205,11 @@ def wrapped_function(*args, **kwargs): return provider_info_cache_decorato

[GitHub] [airflow] stephenonethree commented on issue #17992: way to make an "all_done" task impervious to "Mark Failed" with "Downstream" selected

2021-09-03 Thread GitBox
stephenonethree commented on issue #17992: URL: https://github.com/apache/airflow/issues/17992#issuecomment-912807059 Yeah, that's correct. My concern though is that I think marking things as downstream failed may be one of the most common ways to clear things: In practice our DAGs often h

[GitHub] [airflow] potiuk merged pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
potiuk merged pull request #18018: URL: https://github.com/apache/airflow/pull/18018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[airflow] branch main updated: Update release notes for 3 extra providers released (#18018)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fd5d657 Update release notes for 3 extra providers

[GitHub] [airflow] potiuk commented on a change in pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
potiuk commented on a change in pull request #18018: URL: https://github.com/apache/airflow/pull/18018#discussion_r702156672 ## File path: airflow/providers/celery/provider.yaml ## @@ -22,12 +22,13 @@ description: | `Celery `__ versions: +

[GitHub] [airflow] collinmcnulty commented on issue #17992: way to make an "all_done" task impervious to "Mark Failed" with "Downstream" selected

2021-09-03 Thread GitBox
collinmcnulty commented on issue #17992: URL: https://github.com/apache/airflow/issues/17992#issuecomment-912798098 You allude to this at the end; wouldn't you get the exact behavior you want from just marking the single task failed? Then all the tasks that aren't `all_done` will get marke

[GitHub] [airflow] ZackingIt opened a new issue #18025: KubernetesPodOperator uses filepath's *contents* rather than generated filepath for config_file parameter

2021-09-03 Thread GitBox
ZackingIt opened a new issue #18025: URL: https://github.com/apache/airflow/issues/18025 ### Apache Airflow version 2.1.3 (latest released) ### Operating System Ubuntu VERSION="16.04.6 LTS (Xenial Xerus)" ### Versions of Apache Airflow Providers 2.1.3

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18025: KubernetesPodOperator uses filepath's *contents* rather than generated filepath for config_file parameter

2021-09-03 Thread GitBox
boring-cyborg[bot] commented on issue #18025: URL: https://github.com/apache/airflow/issues/18025#issuecomment-912795944 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[airflow] branch main updated: fix(CloudSqlProxyRunner): don't query connections from Airflow DB (#18006)

2021-09-03 Thread kamilbregula
This is an automated email from the ASF dual-hosted git repository. kamilbregula pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 21348c1 fix(CloudSqlProxyRunner): don't quer

[GitHub] [airflow] mik-laj merged pull request #18006: fix(CloudSqlProxyRunner): don't query connections from Airflow DB

2021-09-03 Thread GitBox
mik-laj merged pull request #18006: URL: https://github.com/apache/airflow/pull/18006 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [airflow] mik-laj closed issue #18003: CloudSqlProxyRunner doesn't support connections from secrets backends

2021-09-03 Thread GitBox
mik-laj closed issue #18003: URL: https://github.com/apache/airflow/issues/18003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [airflow] mik-laj commented on a change in pull request #18007: fix Neo4jHook to get the query response

2021-09-03 Thread GitBox
mik-laj commented on a change in pull request #18007: URL: https://github.com/apache/airflow/pull/18007#discussion_r702141953 ## File path: tests/providers/neo4j/hooks/test_neo4j.py ## @@ -15,51 +15,94 @@ # specific language governing permissions and limitations # under the L

[GitHub] [airflow] mik-laj commented on a change in pull request #18007: fix Neo4jHook to get the query response

2021-09-03 Thread GitBox
mik-laj commented on a change in pull request #18007: URL: https://github.com/apache/airflow/pull/18007#discussion_r702141517 ## File path: tests/providers/neo4j/hooks/test_neo4j.py ## @@ -15,51 +15,94 @@ # specific language governing permissions and limitations # under the L

[GitHub] [airflow] mik-laj commented on a change in pull request #18007: fix Neo4jHook to get the query response

2021-09-03 Thread GitBox
mik-laj commented on a change in pull request #18007: URL: https://github.com/apache/airflow/pull/18007#discussion_r702140880 ## File path: tests/providers/neo4j/operators/test_neo4j.py ## @@ -46,16 +28,13 @@ class TestNeo4jOperator(unittest.TestCase): -def setUp(self)

[GitHub] [airflow] mik-laj commented on a change in pull request #18007: fix Neo4jHook to get the query response

2021-09-03 Thread GitBox
mik-laj commented on a change in pull request #18007: URL: https://github.com/apache/airflow/pull/18007#discussion_r702140880 ## File path: tests/providers/neo4j/operators/test_neo4j.py ## @@ -46,16 +28,13 @@ class TestNeo4jOperator(unittest.TestCase): -def setUp(self)

[GitHub] [airflow] mik-laj commented on pull request #18007: fix Neo4jHook to get the query response

2021-09-03 Thread GitBox
mik-laj commented on pull request #18007: URL: https://github.com/apache/airflow/pull/18007#issuecomment-912785861 @minu7 I pushed ttests. Can you look at it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] potiuk commented on a change in pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
potiuk commented on a change in pull request #18018: URL: https://github.com/apache/airflow/pull/18018#discussion_r702138717 ## File path: airflow/providers/celery/provider.yaml ## @@ -22,12 +22,13 @@ description: | `Celery `__ versions: +

[GitHub] [airflow] jedcunningham commented on a change in pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
jedcunningham commented on a change in pull request #18018: URL: https://github.com/apache/airflow/pull/18018#discussion_r702138705 ## File path: airflow/providers/celery/provider.yaml ## @@ -22,12 +22,13 @@ description: | `Celery `__ vers

[GitHub] [airflow] jedcunningham commented on a change in pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
jedcunningham commented on a change in pull request #18018: URL: https://github.com/apache/airflow/pull/18018#discussion_r702136544 ## File path: airflow/providers/celery/provider.yaml ## @@ -22,12 +22,13 @@ description: | `Celery `__ vers

[GitHub] [airflow] collinmcnulty commented on issue #18023: Many queued Dagruns created for DagRuns with a start_date in the past

2021-09-03 Thread GitBox
collinmcnulty commented on issue #18023: URL: https://github.com/apache/airflow/issues/18023#issuecomment-912780134 `max_active_dagruns` is checked when moving a dagrun from `queued` to `active`. My understanding is that centralizing the logic in `_start_queued_dagruns` was intentional to

[GitHub] [airflow] jmorgannht opened a new issue #18024: Dag start date is cleared when an automatic task retry is triggered

2021-09-03 Thread GitBox
jmorgannht opened a new issue #18024: URL: https://github.com/apache/airflow/issues/18024 ### Apache Airflow version 2.1.3 (latest released) ### Operating System Ubuntu 18.04.5 LTS ### Versions of Apache Airflow Providers apache-airflow-providers-celery==1!

[airflow] branch main updated: AwsBaseHook make `client_type` & `resource_type` optional params for `get_client_type` & `get_resource_type` (#17987)

2021-09-03 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 867e930 AwsBaseHook make `client_type` & `resourc

[GitHub] [airflow] eladkal merged pull request #17987: AwsBaseHook make `client_type` & `resource_type` optional params for `get_client_type` & `get_resource_type`

2021-09-03 Thread GitBox
eladkal merged pull request #17987: URL: https://github.com/apache/airflow/pull/17987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [airflow] SamWheating opened a new issue #18023: Many queued Dagruns created for DagRuns with a start_date in the past

2021-09-03 Thread GitBox
SamWheating opened a new issue #18023: URL: https://github.com/apache/airflow/issues/18023 ### Apache Airflow version 2.1.3 (latest released) ### Operating System Debian GNU/Linux 10 (buster) ### Versions of Apache Airflow Providers _No response_ ###

[GitHub] [airflow] potiuk commented on a change in pull request #17100: Advanced Params using json-schema

2021-09-03 Thread GitBox
potiuk commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r702109422 ## File path: airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py ## @@ -100,15 +99,16 @@ def __init__( self.facebook_conn_id = face

[GitHub] [airflow] ashb commented on a change in pull request #17100: Advanced Params using json-schema

2021-09-03 Thread GitBox
ashb commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r702108848 ## File path: airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py ## @@ -100,15 +99,16 @@ def __init__( self.facebook_conn_id = facebo

[GitHub] [airflow-site] potiuk commented on pull request #474: Add documentation for provider packages - 2021-08-30

2021-09-03 Thread GitBox
potiuk commented on pull request #474: URL: https://github.com/apache/airflow-site/pull/474#issuecomment-912734178 Need to merge for released providers :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on pull request #18022: Fix spealling error added in multiple cors PR

2021-09-03 Thread GitBox
potiuk commented on pull request #18022: URL: https://github.com/apache/airflow/pull/18022#issuecomment-912732773 fixed in the meantime -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] potiuk closed pull request #18022: Fix spealling error added in multiple cors PR

2021-09-03 Thread GitBox
potiuk closed pull request #18022: URL: https://github.com/apache/airflow/pull/18022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk opened a new pull request #18022: Fix spealling error added in multiple cors PR

2021-09-03 Thread GitBox
potiuk opened a new pull request #18022: URL: https://github.com/apache/airflow/pull/18022 The error was added in #17941 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull

[airflow] branch main updated: Fix spelling error causing tests to fail on main (#18021)

2021-09-03 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new decaaeb Fix spelling error causing tests to fail on m

[GitHub] [airflow] ashb merged pull request #18021: Fix spelling error causing tests to fail on main

2021-09-03 Thread GitBox
ashb merged pull request #18021: URL: https://github.com/apache/airflow/pull/18021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] ashb commented on pull request #18021: Fix spelling error causing tests to fail on main

2021-09-03 Thread GitBox
ashb commented on pull request #18021: URL: https://github.com/apache/airflow/pull/18021#issuecomment-912731450 Tested locally, merging now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] github-actions[bot] commented on pull request #18021: Fix spelling error causing tests to fail on main

2021-09-03 Thread GitBox
github-actions[bot] commented on pull request #18021: URL: https://github.com/apache/airflow/pull/18021#issuecomment-912730752 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] ashb opened a new pull request #18021: Fix spelling error causing tests to fail on main

2021-09-03 Thread GitBox
ashb opened a new pull request #18021: URL: https://github.com/apache/airflow/pull/18021 I merged the PR that added this too eagerly (https://github.com/apache/airflow/pull/17941) --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https

[GitHub] [airflow] msumit commented on a change in pull request #17100: Advanced Params using json-schema

2021-09-03 Thread GitBox
msumit commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r702090552 ## File path: airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py ## @@ -100,15 +99,16 @@ def __init__( self.facebook_conn_id = face

[GitHub] [airflow] github-actions[bot] commented on pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
github-actions[bot] commented on pull request #18018: URL: https://github.com/apache/airflow/pull/18018#issuecomment-912725526 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] potiuk commented on pull request #18020: Adds capability of Warnings for incompatible community providers

2021-09-03 Thread GitBox
potiuk commented on pull request #18020: URL: https://github.com/apache/airflow/pull/18020#issuecomment-912723258 This one will fail until we merge #18018 is merged (it bumps celery to 2.1.0) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] potiuk opened a new pull request #18020: Adds capability of Warnings for incompatible community providers

2021-09-03 Thread GitBox
potiuk opened a new pull request #18020: URL: https://github.com/apache/airflow/pull/18020 When we release providers, we do not know if some future version of Airflow will be incompatible with them, so we cannot add hard limits there. We have constraints that contain the "latest" pr

[GitHub] [airflow] josh-fell edited a comment on pull request #18019: Adding missing init file in Alibaba example_dags directory

2021-09-03 Thread GitBox
josh-fell edited a comment on pull request #18019: URL: https://github.com/apache/airflow/pull/18019#issuecomment-912704002 Sorry @potiuk I should have checked that during the RC testing since it happened with Apache Drill last release. I can work on setting up a CI check for providers if

[GitHub] [airflow] josh-fell commented on pull request #18019: Adding missing init file in Alibaba example_dags directory

2021-09-03 Thread GitBox
josh-fell commented on pull request #18019: URL: https://github.com/apache/airflow/pull/18019#issuecomment-912704002 Sorry @potiuk I should have checked that during the RC testing since it happened with Apache Drill last release. I can work setting up a CI check when checking providers if

[airflow] branch main updated (9c64419 -> 0fe0b06)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9c64419 Fix unexpected bug in exiting hook context manager (#18014) add 0fe0b06 Adding missing init file in exa

[airflow-ci-infra] branch main updated: New runner version

2021-09-03 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-ci-infra.git The following commit(s) were added to refs/heads/main by this push: new 5c853ef New runner version 5c853ef is descri

[GitHub] [airflow] potiuk merged pull request #18019: Adding missing init file in Alibaba example_dags directory

2021-09-03 Thread GitBox
potiuk merged pull request #18019: URL: https://github.com/apache/airflow/pull/18019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on issue #18010: Airflow scheduler with statsd enabled crashes when dag_id contains unexpected characters

2021-09-03 Thread GitBox
potiuk commented on issue #18010: URL: https://github.com/apache/airflow/issues/18010#issuecomment-912702349 Agree it's likely something we should address. I am just wondering why it did not fail at trying to insert DAG to the DB - the DAG_ID there should only allow ASCII. -- This is an

[GitHub] [airflow] josh-fell opened a new pull request #18019: Adding missing init file in Alibaba example_dags directory

2021-09-03 Thread GitBox
josh-fell opened a new pull request #18019: URL: https://github.com/apache/airflow/pull/18019 The example_dags directory in the Alibaba provider is missing an `__init__.py` file. This PR simply adds the missing file. --- **^ Add meaningful description above** Read the **[Pu

[GitHub] [airflow] ephraimbuddy commented on issue #18011: Task stuck in upstream_failed

2021-09-03 Thread GitBox
ephraimbuddy commented on issue #18011: URL: https://github.com/apache/airflow/issues/18011#issuecomment-912695481 Related: https://github.com/apache/airflow/issues/16625 PR trying to address this: https://github.com/apache/airflow/pull/17819 -- This is an automated message from the Ap

[GitHub] [airflow] potiuk opened a new pull request #18018: Update release notes for 3 extra providers released

2021-09-03 Thread GitBox
potiuk opened a new pull request #18018: URL: https://github.com/apache/airflow/pull/18018 We are releasing out-of-bands providers now: * Hashicorp - due to bug found in previous version * Celery - due to change in Celery dependency * Microsoft PSRP - due to bug found and fixed

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-03 Thread GitBox
ephraimbuddy commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r702052830 ## File path: airflow/jobs/scheduler_job.py ## @@ -596,13 +597,26 @@ def _process_executor_events(self, session: Session = None) -> int:

[GitHub] [airflow-site] potiuk commented on pull request #474: Add documentation for provider packages - 2021-08-30

2021-09-03 Thread GitBox
potiuk commented on pull request #474: URL: https://github.com/apache/airflow-site/pull/474#issuecomment-912678968 BTW. Should we maybe stop protecting the main branch on docs :) . It seems very little use - there is no way anyone can review such changes :D -- This is an automated messag

[GitHub] [airflow] potiuk commented on issue #17922: Status of testing Providers that were prepared on August 30, 2021

2021-09-03 Thread GitBox
potiuk commented on issue #17922: URL: https://github.com/apache/airflow/issues/17922#issuecomment-912678053 Thanks everyone for testing! You rock! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk closed issue #17922: Status of testing Providers that were prepared on August 30, 2021

2021-09-03 Thread GitBox
potiuk closed issue #17922: URL: https://github.com/apache/airflow/issues/17922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow-site] potiuk commented on pull request #474: Add documentation for provider packages - 2021-08-30

2021-09-03 Thread GitBox
potiuk commented on pull request #474: URL: https://github.com/apache/airflow-site/pull/474#issuecomment-912662294 C'mon - just +2.8M lines of code, Easy to review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[airflow-site] branch add-documentation-2021-08-30 updated (c1ccc73 -> 32a9d23)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-documentation-2021-08-30 in repository https://gitbox.apache.org/repos/asf/airflow-site.git. discard c1ccc73 Add documentation for packages - 2021-08-30 add 32a9d23 Add documentation

[GitHub] [airflow] Narendra-Neerukonda commented on issue #17993: Allow the default encoding to be set in airflow config to read/write task logs

2021-09-03 Thread GitBox
Narendra-Neerukonda commented on issue #17993: URL: https://github.com/apache/airflow/issues/17993#issuecomment-912659161 I'll be back with a PR for implementation review in few days (with all the above suggestions). Thank you. -- This is an automated message from the Apache Git Servi

[GitHub] [airflow] potiuk commented on pull request #18014: Fix unexpected bug in exiting PSRPHook.client context manager

2021-09-03 Thread GitBox
potiuk commented on pull request #18014: URL: https://github.com/apache/airflow/pull/18014#issuecomment-912655052 Great. I will release a new psrp provider version today then - together with hashicorp and celery I have to release. Then I will yank the 1.0.0 version of psrp (makes no sense

[airflow] branch main updated (a88115e -> 9c64419)

2021-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a88115e Allow specifying multiple URLs via the CORS config option (#17941) add 9c64419 Fix unexpected bug in e

[GitHub] [airflow] potiuk merged pull request #18014: Fix unexpected bug in exiting PSRPHook.client context manager

2021-09-03 Thread GitBox
potiuk merged pull request #18014: URL: https://github.com/apache/airflow/pull/18014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] jedcunningham commented on a change in pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-09-03 Thread GitBox
jedcunningham commented on a change in pull request #17649: URL: https://github.com/apache/airflow/pull/17649#discussion_r702005781 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -143,12 +143,22 @@ def monitor_pod(self, pod: V1Pod, get_logs: bool) -

[GitHub] [airflow] rodrigo-morais edited a comment on issue #16881: Re-deploy scheduler tasks failing with SIGTERM on K8s executor

2021-09-03 Thread GitBox
rodrigo-morais edited a comment on issue #16881: URL: https://github.com/apache/airflow/issues/16881#issuecomment-876388007 Pods before to deploy a new scheduler ``` NAME READY STATUSRESTARTS AGE airflow-scheduler-

[GitHub] [airflow] ephraimbuddy closed pull request #17819: Promptly handle task callback from _process_executor_events

2021-09-03 Thread GitBox
ephraimbuddy closed pull request #17819: URL: https://github.com/apache/airflow/pull/17819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits

[GitHub] [airflow] eladkal edited a comment on pull request #17987: AwsBaseHook make `client_type` & `resource_type` optional params for `get_client_type` & `get_resource_type`

2021-09-03 Thread GitBox
eladkal edited a comment on pull request #17987: URL: https://github.com/apache/airflow/pull/17987#issuecomment-912618613 As suggested I added deprecation for `client_type`/`resource_type` in the function. Current implementation may leads to a very confusing cases like: `emr_clien

[GitHub] [airflow] eladkal edited a comment on pull request #17987: AwsBaseHook make `client_type` & `resource_type` optional params for `get_client_type` & `get_resource_type`

2021-09-03 Thread GitBox
eladkal edited a comment on pull request #17987: URL: https://github.com/apache/airflow/pull/17987#issuecomment-912618613 As suggested I added deprecation for `client_type`/`resource_type` in the function. This may leads to a very confusing cases like: `emr_client = AwsBaseHook(se

[GitHub] [airflow] eladkal commented on pull request #17987: AwsBaseHook make `client_type` & `resource_type` optional params for `get_client_type` & `get_resource_type`

2021-09-03 Thread GitBox
eladkal commented on pull request #17987: URL: https://github.com/apache/airflow/pull/17987#issuecomment-912618613 As suggested I added deprecation for setting `client_type`/`resource_type` in the function. This may leads to a very confusing cases like: `emr_client = AwsBaseHook(s

[GitHub] [airflow] subkanthi commented on issue #17922: Status of testing Providers that were prepared on August 30, 2021

2021-09-03 Thread GitBox
subkanthi commented on issue #17922: URL: https://github.com/apache/airflow/issues/17922#issuecomment-912605356 @potiuk tested both Example dag slackfile (#17400): Fixed SlackAPIFileOperator to upload file and file content (#17247): it works, thanks -- This is an automate

[GitHub] [airflow] dberzano commented on issue #16881: Re-deploy scheduler tasks failing with SIGTERM on K8s executor

2021-09-03 Thread GitBox
dberzano commented on issue #16881: URL: https://github.com/apache/airflow/issues/16881#issuecomment-912603049 OK, let me retract - our problem was, seemingly, different. The `serviceaccount` provided to the scheduler was not bound to roles containing the verb `patch` for the `pod` kind...

[GitHub] [airflow] josh-fell commented on a change in pull request #17885: Creating ADF pipeline run operator, sensor + ADF custom conn fields

2021-09-03 Thread GitBox
josh-fell commented on a change in pull request #17885: URL: https://github.com/apache/airflow/pull/17885#discussion_r701953958 ## File path: airflow/providers/microsoft/azure/operators/data_factory.py ## @@ -0,0 +1,149 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] [airflow] josh-fell commented on a change in pull request #17885: Creating ADF pipeline run operator, sensor + ADF custom conn fields

2021-09-03 Thread GitBox
josh-fell commented on a change in pull request #17885: URL: https://github.com/apache/airflow/pull/17885#discussion_r701952693 ## File path: airflow/providers/microsoft/azure/hooks/data_factory.py ## @@ -15,6 +15,7 @@ # specific language governing permissions and limitations

[GitHub] [airflow] josh-fell commented on a change in pull request #17885: Creating ADF pipeline run operator, sensor + ADF custom conn fields

2021-09-03 Thread GitBox
josh-fell commented on a change in pull request #17885: URL: https://github.com/apache/airflow/pull/17885#discussion_r701946651 ## File path: airflow/providers/microsoft/azure/hooks/data_factory.py ## @@ -583,6 +584,77 @@ def get_pipeline_run( """ return self.

  1   2   3   4   >