[GitHub] [airflow] uranusjr commented on a change in pull request #17329: Split sql statements in DbApi run

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r703180280 ## File path: tests/hooks/test_dbapi.py ## @@ -232,3 +233,74 @@ def handler(cur): assert called == 2 assert self.conn.commit.called

[GitHub] [airflow] github-actions[bot] commented on pull request #17030: Check for missing DagRun rows for "downstream" tables before migrating DB

2021-09-06 Thread GitBox
github-actions[bot] commented on pull request #17030: URL: https://github.com/apache/airflow/pull/17030#issuecomment-913990962 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on a change in pull request #17030: Check for missing DagRun rows for "downstream" tables before migrating DB

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #17030: URL: https://github.com/apache/airflow/pull/17030#discussion_r703175221 ## File path: airflow/utils/db.py ## @@ -674,30 +673,73 @@ def check_conn_type_null(session=None) -> str: pass if n_nulls: -

[GitHub] [airflow] r-richmond opened a new issue #18051: Airflow scheduling only 1 dag at a time leaving other dags in a queued state

2021-09-06 Thread GitBox
r-richmond opened a new issue #18051: URL: https://github.com/apache/airflow/issues/18051 ### Apache Airflow version 2.1.3 (latest released) ### Operating System Linux ### Versions of Apache Airflow Providers I don't think it is relevant but can provide

[GitHub] [airflow] Nimesh-K-Makwana commented on issue #18041: Tasks intermittently gets terminated with SIGTERM on kubernetes executor

2021-09-06 Thread GitBox
Nimesh-K-Makwana commented on issue #18041: URL: https://github.com/apache/airflow/issues/18041#issuecomment-913982642 DAG is in ON state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] easontm commented on issue #18041: Tasks intermittently gets terminated with SIGTERM on kubernetes executor

2021-09-06 Thread GitBox
easontm commented on issue #18041: URL: https://github.com/apache/airflow/issues/18041#issuecomment-913963931 Is your DAG paused? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] ShakaibKhan commented on issue #17962: Warn if robots.txt is accessed

2021-09-06 Thread GitBox
ShakaibKhan commented on issue #17962: URL: https://github.com/apache/airflow/issues/17962#issuecomment-913937348 This feature sounds interesting and I would like to try implementing it if no one minds :) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ShakaibKhan commented on issue #17476: Sensitive variables don't get masked when rendered with airflow tasks test

2021-09-06 Thread GitBox
ShakaibKhan commented on issue #17476: URL: https://github.com/apache/airflow/issues/17476#issuecomment-913932601 So from [1]: "The automatic masking is triggered by Connection or Variable access. This means that if you pass a sensitive value via XCom or any other side-channel it will not

[GitHub] [airflow] edwardwang888 closed pull request #18033: Always draw borders if task instance state is null or undefined

2021-09-06 Thread GitBox
edwardwang888 closed pull request #18033: URL: https://github.com/apache/airflow/pull/18033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #9048: ERROR - Can't compile non template nodes when I am using Papermill Operator

2021-09-06 Thread GitBox
github-actions[bot] commented on issue #9048: URL: https://github.com/apache/airflow/issues/9048#issuecomment-913905133 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] ashb commented on a change in pull request #17030: Check for missing DagRun rows for "downstream" tables before migrating DB

2021-09-06 Thread GitBox
ashb commented on a change in pull request #17030: URL: https://github.com/apache/airflow/pull/17030#discussion_r703075530 ## File path: airflow/utils/db.py ## @@ -706,17 +748,22 @@ def upgradedb(session=None): # alembic adds significant import time, so we import it

[GitHub] [airflow] bmbejcek commented on pull request #17998: Fix error when create external table

2021-09-06 Thread GitBox
bmbejcek commented on pull request #17998: URL: https://github.com/apache/airflow/pull/17998#issuecomment-913854290 I am also currently facing this issue. If we don't have a `destination_project_dataset_table` variable, it says that it is missing even when passing in this information

[GitHub] [airflow] bmbejcek commented on issue #15604: BigQueryCreateExternalTableOperator table_resource parameter is impossible to use

2021-09-06 Thread GitBox
bmbejcek commented on issue #15604: URL: https://github.com/apache/airflow/issues/15604#issuecomment-913850788 Any updates on this? Currently facing this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] ashb commented on a change in pull request #17819: Properly handle ti state difference between executor and scheduler

2021-09-06 Thread GitBox
ashb commented on a change in pull request #17819: URL: https://github.com/apache/airflow/pull/17819#discussion_r703064312 ## File path: airflow/jobs/scheduler_job.py ## @@ -596,13 +597,24 @@ def _process_executor_events(self, session: Session = None) -> int:

[GitHub] [airflow] bbovenzi commented on issue #16877: Cleared task instances in manual runs should have borders

2021-09-06 Thread GitBox
bbovenzi commented on issue #16877: URL: https://github.com/apache/airflow/issues/16877#issuecomment-913827379 Yeah, you shouldn't have to worry about tests for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ashb commented on issue #18049: `context` parameter is unused on method `execute` on class `TriggerDagRunOperator`

2021-09-06 Thread GitBox
ashb commented on issue #18049: URL: https://github.com/apache/airflow/issues/18049#issuecomment-913817187 By having the code you show at the top level of your file _every_ time Airflow parses the file (which is about once every 30s by default on new installs) it will call your

[GitHub] [airflow] ashb closed issue #18049: `context` parameter is unused on method `execute` on class `TriggerDagRunOperator`

2021-09-06 Thread GitBox
ashb closed issue #18049: URL: https://github.com/apache/airflow/issues/18049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mik-laj commented on issue #18049: `context` parameter is unused on method `execute` on class `TriggerDagRunOperator`

2021-09-06 Thread GitBox
mik-laj commented on issue #18049: URL: https://github.com/apache/airflow/issues/18049#issuecomment-913814947 This parameter is required by BaseOperator, so we cannot change the signature of the method in a subclass. Why do you want to invoke this method? -- This is an automated

[GitHub] [airflow] github-actions[bot] commented on pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
github-actions[bot] commented on pull request #18042: URL: https://github.com/apache/airflow/pull/18042#issuecomment-913809365 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r703040821 ## File path: airflow/providers/amazon/aws/utils/emailer.py ## @@ -16,13 +16,15 @@ # specific language governing permissions and limitations # under

[airflow] branch main updated: Fix building documentation broken by upgrade of dnspython (#18046)

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 022b4e0 Fix building documentation broken by

[GitHub] [airflow] potiuk merged pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk merged pull request #18046: URL: https://github.com/apache/airflow/pull/18046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
github-actions[bot] commented on pull request #18046: URL: https://github.com/apache/airflow/pull/18046#issuecomment-913806569 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] BShraman commented on pull request #18048: Declared readonly variable and added double quote in variables containing strings

2021-09-06 Thread GitBox
BShraman commented on pull request #18048: URL: https://github.com/apache/airflow/pull/18048#issuecomment-913805526 > I think you need to rebase :( Done and pushed :) (airflow-env) shraman@shramans-mbp airflow % git rebase main Current branch main is up to date.

[GitHub] [airflow] potiuk edited a comment on pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk edited a comment on pull request #18046: URL: https://github.com/apache/airflow/pull/18046#issuecomment-913804574 All Green! We can have green `main` too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk commented on pull request #18046: URL: https://github.com/apache/airflow/pull/18046#issuecomment-913804574 All Green! We can have green master too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on issue #17912: add yaml/omegaconf vizualization in UI in "run w/ config".

2021-09-06 Thread GitBox
potiuk commented on issue #17912: URL: https://github.com/apache/airflow/issues/17912#issuecomment-913803288 absolutely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on issue #18050: Duplicating the same connection twice gives "Integrity error, probably unique constraint"

2021-09-06 Thread GitBox
potiuk commented on issue #18050: URL: https://github.com/apache/airflow/issues/18050#issuecomment-913802588 Airflow is build by the community - so anyone can make such fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk commented on issue #18050: Duplicating the same connection twice gives "Integrity error, probably unique constraint"

2021-09-06 Thread GitBox
potiuk commented on issue #18050: URL: https://github.com/apache/airflow/issues/18050#issuecomment-913802405 Is it possible that you make a PR fixing it? Seems like simple issue to fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] potiuk commented on pull request #18048: Declared readonly variable and added double quote in variables containing strings

2021-09-06 Thread GitBox
potiuk commented on pull request #18048: URL: https://github.com/apache/airflow/pull/18048#issuecomment-913790428 I think you need to rebase :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] jyotsa09 opened a new issue #18050: Duplicating the same connection twice gives **Integrity error, probably unique constraint**

2021-09-06 Thread GitBox
jyotsa09 opened a new issue #18050: URL: https://github.com/apache/airflow/issues/18050 ### Apache Airflow version 2.1.3 (latest released) ### Operating System debian buster ### Versions of Apache Airflow Providers _No response_ ### Deployment

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18050: Duplicating the same connection twice gives **Integrity error, probably unique constraint**

2021-09-06 Thread GitBox
boring-cyborg[bot] commented on issue #18050: URL: https://github.com/apache/airflow/issues/18050#issuecomment-913789106 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk commented on pull request #18046: URL: https://github.com/apache/airflow/pull/18046#issuecomment-913787414 Reopened to rebuild. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk closed pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk closed pull request #18046: URL: https://github.com/apache/airflow/pull/18046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk commented on pull request #18046: URL: https://github.com/apache/airflow/pull/18046#issuecomment-913787324 I think it is ready and it should fix failing main when merged - then we will be able to generate new constraints and refresh images and prepare 2.1.4 release. -- This is

[GitHub] [airflow] ignaski commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
ignaski commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r703023059 ## File path: airflow/providers/amazon/aws/utils/emailer.py ## @@ -16,13 +16,15 @@ # specific language governing permissions and limitations # under

[GitHub] [airflow] ldacey commented on issue #12199: New dag run / task state: disposed

2021-09-06 Thread GitBox
ldacey commented on issue #12199: URL: https://github.com/apache/airflow/issues/12199#issuecomment-913773871 This would be perfect for tasks where failure is acceptable or predicted. Ideally this would be another state so it would not look red on the main Airflow page (I have been sharing

[GitHub] [airflow] boring-cyborg[bot] commented on issue #18049: `context` parameter is unused on method `execute` on class `TriggerDagRunOperator`

2021-09-06 Thread GitBox
boring-cyborg[bot] commented on issue #18049: URL: https://github.com/apache/airflow/issues/18049#issuecomment-913763770 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ryanlow-tw opened a new issue #18049: `context` parameter is unused on method `execute` on class `TriggerDagRunOperator`

2021-09-06 Thread GitBox
ryanlow-tw opened a new issue #18049: URL: https://github.com/apache/airflow/issues/18049 ### Apache Airflow version 2.1.3 (latest released) ### Operating System macOS Catalina 10.15.7 ### Versions of Apache Airflow Providers _No response_ ###

[GitHub] [airflow] BShraman opened a new pull request #18048: Declared readonly variable and added double quote in variables containing strings

2021-09-06 Thread GitBox
BShraman opened a new pull request #18048: URL: https://github.com/apache/airflow/pull/18048 Declared readonly variable Added double quote in variables containing strings --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r702984017 ## File path: airflow/providers/amazon/aws/utils/emailer.py ## @@ -16,13 +16,15 @@ # specific language governing permissions and limitations # under

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r702983479 ## File path: airflow/utils/email.py ## @@ -49,10 +49,17 @@ def send_email( """Send email using backend specified in EMAIL_BACKEND."""

[GitHub] [airflow] SimonOsipov commented on pull request #16636: Added dashes to pod naming

2021-09-06 Thread GitBox
SimonOsipov commented on pull request #16636: URL: https://github.com/apache/airflow/pull/16636#issuecomment-913727880 I terribly apologize, I a bit felt out of the issue I created. Is this issue still valid? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ignaski commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
ignaski commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r702954597 ## File path: airflow/utils/email.py ## @@ -49,10 +49,17 @@ def send_email( """Send email using backend specified in EMAIL_BACKEND."""

[GitHub] [airflow] msumit commented on issue #17912: add yaml/omegaconf vizualization in UI in "run w/ config".

2021-09-06 Thread GitBox
msumit commented on issue #17912: URL: https://github.com/apache/airflow/issues/17912#issuecomment-913700081 @potiuk yeah we can include the yaml support as well, but maybe in the next diff, cause the current diff is already become pretty big and hanging for a long time. -- This is an

[GitHub] [airflow] CodingJonas edited a comment on issue #9310: Delay until Docker Swarm recognizes finished service

2021-09-06 Thread GitBox
CodingJonas edited a comment on issue #9310: URL: https://github.com/apache/airflow/issues/9310#issuecomment-913696551 Sorry for not following up on my workaround, we moved to Kubernetes, so we did not finish polishing the workaround properly. I can still add the main code parts we used

[GitHub] [airflow] CodingJonas commented on issue #9310: Delay until Docker Swarm recognizes finished service

2021-09-06 Thread GitBox
CodingJonas commented on issue #9310: URL: https://github.com/apache/airflow/issues/9310#issuecomment-913696551 Sorry for not following up on my workaround, we moved to Kubernetes, so we did not finish polishing the workaround properly. I can still add the main code parts we used to try

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r702940430 ## File path: airflow/utils/email.py ## @@ -49,10 +49,17 @@ def send_email( """Send email using backend specified in EMAIL_BACKEND."""

[GitHub] [airflow] ignaski edited a comment on pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
ignaski edited a comment on pull request #18042: URL: https://github.com/apache/airflow/pull/18042#issuecomment-913676227 I did some refactoring to bring the repeated code into a single piece of code. The logic is now that by default `send_email` will take the sender email and name

[GitHub] [airflow] potiuk commented on issue #14924: Scheduler Memory Leak in Airflow 2.0.1

2021-09-06 Thread GitBox
potiuk commented on issue #14924: URL: https://github.com/apache/airflow/issues/14924#issuecomment-913683637 爛 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ignaski edited a comment on pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
ignaski edited a comment on pull request #18042: URL: https://github.com/apache/airflow/pull/18042#issuecomment-913676227 I did some refactoring to bring the repeated code into a single piece of code. The logic is now that by default `send_email` will take the sender email and name

[GitHub] [airflow] ignaski commented on pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
ignaski commented on pull request #18042: URL: https://github.com/apache/airflow/pull/18042#issuecomment-913676227 I did some refactoring to bring the repeated code into a single piece of code. The logic is now that by default `send_email` will take the sender email and name from

[airflow] branch main updated: Revert "Opmitise LoggingMixin.log (#17280)" (#18047)

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0c2f71e Revert "Opmitise LoggingMixin.log

[GitHub] [airflow] potiuk merged pull request #18047: Revert "Opmitise LoggingMixin.log (#17280)"

2021-09-06 Thread GitBox
potiuk merged pull request #18047: URL: https://github.com/apache/airflow/pull/18047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18047: Revert "Opmitise LoggingMixin.log (#17280)"

2021-09-06 Thread GitBox
potiuk commented on pull request #18047: URL: https://github.com/apache/airflow/pull/18047#issuecomment-913669316 Absolutely! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] github-actions[bot] commented on pull request #18047: Revert "Opmitise LoggingMixin.log (#17280)"

2021-09-06 Thread GitBox
github-actions[bot] commented on pull request #18047: URL: https://github.com/apache/airflow/pull/18047#issuecomment-913669115 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #18047: Revert "Opmitise LoggingMixin.log (#17280)"

2021-09-06 Thread GitBox
potiuk commented on pull request #18047: URL: https://github.com/apache/airflow/pull/18047#issuecomment-913668215 Fix broken main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk opened a new pull request #18047: Revert "Opmitise LoggingMixin.log (#17280)"

2021-09-06 Thread GitBox
potiuk opened a new pull request #18047: URL: https://github.com/apache/airflow/pull/18047 This reverts commit fe7efcaeb22f9053aa1cfdec01a50dc943583a8e. --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] flolas commented on a change in pull request #17329: Split sql statements in DbApi run

2021-09-06 Thread GitBox
flolas commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r702888607 ## File path: tests/hooks/test_dbapi.py ## @@ -232,3 +233,74 @@ def handler(cur): assert called == 2 assert self.conn.commit.called

[GitHub] [airflow] flolas commented on a change in pull request #17329: Split sql statements in DbApi run

2021-09-06 Thread GitBox
flolas commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r702888607 ## File path: tests/hooks/test_dbapi.py ## @@ -232,3 +233,74 @@ def handler(cur): assert called == 2 assert self.conn.commit.called

[GitHub] [airflow] flolas commented on a change in pull request #17329: Split sql statements in DbApi run

2021-09-06 Thread GitBox
flolas commented on a change in pull request #17329: URL: https://github.com/apache/airflow/pull/17329#discussion_r702888607 ## File path: tests/hooks/test_dbapi.py ## @@ -232,3 +233,74 @@ def handler(cur): assert called == 2 assert self.conn.commit.called

[GitHub] [airflow] suhanovv commented on issue #14924: Scheduler Memory Leak in Airflow 2.0.1

2021-09-06 Thread GitBox
suhanovv commented on issue #14924: URL: https://github.com/apache/airflow/issues/14924#issuecomment-913632721 @potiuk We have deployed today and while we are watching, tomorrow I will return with the results -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] baryluk commented on a change in pull request #17649: Do not fail KubernetesPodOperator tasks if log following fails

2021-09-06 Thread GitBox
baryluk commented on a change in pull request #17649: URL: https://github.com/apache/airflow/pull/17649#discussion_r702881637 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -143,12 +143,22 @@ def monitor_pod(self, pod: V1Pod, get_logs: bool) ->

[GitHub] [airflow] potiuk commented on pull request #18045: Switch CI builds to use Python 3.7 by default

2021-09-06 Thread GitBox
potiuk commented on pull request #18045: URL: https://github.com/apache/airflow/pull/18045#issuecomment-913619897 Closing this one. Turned out that it's dnspython issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk closed pull request #18045: Switch CI builds to use Python 3.7 by default

2021-09-06 Thread GitBox
potiuk closed pull request #18045: URL: https://github.com/apache/airflow/pull/18045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk commented on pull request #18046: URL: https://github.com/apache/airflow/pull/18046#issuecomment-913616409 It's DNS @ashb . It's always DNS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk opened a new pull request #18046: Fix building documentation broken by upgrade of dnspython

2021-09-06 Thread GitBox
potiuk opened a new pull request #18046: URL: https://github.com/apache/airflow/pull/18046 The automated upgrade of dependencies in main broken building of Airflow documentation in main build. After a lot of experimentation, It has been narrowed down to upgrade of dnspython

[GitHub] [airflow] uranusjr commented on a change in pull request #17719: Change TaskInstance and TaskReschedule PK from execution_date to run_id

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #17719: URL: https://github.com/apache/airflow/pull/17719#discussion_r702845592 ## File path: airflow/jobs/backfill_job.py ## @@ -434,15 +433,15 @@ def _process_backfill_task_instances( # determined deadlocked while

[airflow] branch constraints-2-1 updated: Updating constraints. Build id:1205528084

2021-09-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-1 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-1 by this push: new 706ef46 Updating

[GitHub] [airflow] uranusjr commented on issue #17943: _change_state_for_tis_without_dagrun query triggers mysql full scan

2021-09-06 Thread GitBox
uranusjr commented on issue #17943: URL: https://github.com/apache/airflow/issues/17943#issuecomment-913574386 I think we need indexes on `DagRun.state` and `TaskInstance.state`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] uranusjr commented on pull request #17776: Change function named cluster_policy to task_policy

2021-09-06 Thread GitBox
uranusjr commented on pull request #17776: URL: https://github.com/apache/airflow/pull/17776#issuecomment-913572520 Tests are failing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] huozhanfeng edited a comment on pull request #17305: [Bug] Backfill job fails to run when there are tasks run into rescheduling state.

2021-09-06 Thread GitBox
huozhanfeng edited a comment on pull request #17305: URL: https://github.com/apache/airflow/pull/17305#issuecomment-913570741 > Hi, > we have tested this fix and it does not seems to solve issue. Maybe there are other cases to cause the issue... You can print the content of

[GitHub] [airflow] huozhanfeng commented on pull request #17305: [Bug] Backfill job fails to run when there are tasks run into rescheduling state.

2021-09-06 Thread GitBox
huozhanfeng commented on pull request #17305: URL: https://github.com/apache/airflow/pull/17305#issuecomment-913570741 > Hi, > we have tested this fix and it does not seems to solve issue. Maybe there are other cases to cause the issue... You can print the content of ti.key and

[GitHub] [airflow] huozhanfeng removed a comment on pull request #17305: [Bug] Backfill job fails to run when there are tasks run into rescheduling state.

2021-09-06 Thread GitBox
huozhanfeng removed a comment on pull request #17305: URL: https://github.com/apache/airflow/pull/17305#issuecomment-913570454 > Hi, > we have tested this fix and it does not seems to solve issue. Maybe there are other cases to cause the issue... You can print the content of `ti.key`

[GitHub] [airflow] huozhanfeng commented on pull request #17305: [Bug] Backfill job fails to run when there are tasks run into rescheduling state.

2021-09-06 Thread GitBox
huozhanfeng commented on pull request #17305: URL: https://github.com/apache/airflow/pull/17305#issuecomment-913570454 > Hi, > we have tested this fix and it does not seems to solve issue. Maybe there are other cases to cause the issue... You can print the content of `ti.key` and

[GitHub] [airflow] potiuk commented on issue #14924: Scheduler Memory Leak in Airflow 2.0.1

2021-09-06 Thread GitBox
potiuk commented on issue #14924: URL: https://github.com/apache/airflow/issues/14924#issuecomment-913550223 Hey @suhanovv - any results of the tests ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] Nimesh-K-Makwana commented on issue #18041: Tasks intermittently gets terminated with SIGTERM on kubernetes executor

2021-09-06 Thread GitBox
Nimesh-K-Makwana commented on issue #18041: URL: https://github.com/apache/airflow/issues/18041#issuecomment-913532193 True, when a pod gets deleted they are getting SIGTERM. I have tried to get the cause of pods getting deleted, but could not find any reason for it yet. It happens just

[GitHub] [airflow] potiuk commented on issue #8568: Rewrite Google Cloud Build integration to use the native library.

2021-09-06 Thread GitBox
potiuk commented on issue #8568: URL: https://github.com/apache/airflow/issues/8568#issuecomment-913532084  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated (bfad233 -> 952fa57)

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from bfad233 Fix providers tests in main branch with eager upgrades (#18040) add 952fa57 Suppress stat stderr

[GitHub] [airflow] potiuk merged pull request #18044: Suppress stat stderr output when we have fallback

2021-09-06 Thread GitBox
potiuk merged pull request #18044: URL: https://github.com/apache/airflow/pull/18044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18044: Suppress stat stderr output when we have fallback

2021-09-06 Thread GitBox
github-actions[bot] commented on pull request #18044: URL: https://github.com/apache/airflow/pull/18044#issuecomment-913531585 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #18044: Suppress stat stderr output when we have fallback

2021-09-06 Thread GitBox
potiuk commented on pull request #18044: URL: https://github.com/apache/airflow/pull/18044#issuecomment-913531509 intermittent errors. merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on issue #18028: Status of testing Providers that were prepared on September 04, 2021

2021-09-06 Thread GitBox
potiuk commented on issue #18028: URL: https://github.com/apache/airflow/issues/18028#issuecomment-913530513 @malthe @davlum -> I'd appreciate quick tests there and we should be able to release those tomorrow I think :) -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on issue #18028: Status of testing Providers that were prepared on September 04, 2021

2021-09-06 Thread GitBox
potiuk commented on issue #18028: URL: https://github.com/apache/airflow/issues/18028#issuecomment-913529685 Cool! Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] ashb commented on a change in pull request #17100: Advanced Params using json-schema

2021-09-06 Thread GitBox
ashb commented on a change in pull request #17100: URL: https://github.com/apache/airflow/pull/17100#discussion_r702780224 ## File path: airflow/providers/google/cloud/transfers/facebook_ads_to_gcs.py ## @@ -100,15 +99,16 @@ def __init__( self.facebook_conn_id =

[GitHub] [airflow] potiuk commented on pull request #18045: Switch CI builds to use Python 3.7 by default

2021-09-06 Thread GitBox
potiuk commented on pull request #18045: URL: https://github.com/apache/airflow/pull/18045#issuecomment-913517572 This one - unfortunately needs to be checked as "main" build because the "main" ci build workflow builds 3.6 image currently. Running it here:

[airflow] 01/01: Improve the description of how to handle dynamic task generation (#17963)

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 2690c79a5d141e869437e51ea98249812837a963 Author: Jarek Potiuk AuthorDate: Mon Sep 6 10:40:17 2021 +0200

[airflow] branch v2-1-test updated (d14d0b0 -> 2690c79)

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch v2-1-test in repository https://gitbox.apache.org/repos/asf/airflow.git. discard d14d0b0 Improve the description of how to handle dynamic task generation (#17963) new 2690c79 Improve

[airflow] branch constraints-2-1 updated: Bump sphinxcontrib-spelling to 7.2.1

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch constraints-2-1 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-1 by this push: new 406712a Bump

[GitHub] [airflow] uranusjr commented on a change in pull request #17974: WIP: Implement before stm and after stm in DBApiHooks

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #17974: URL: https://github.com/apache/airflow/pull/17974#discussion_r702757017 ## File path: airflow/hooks/dbapi.py ## @@ -286,11 +300,19 @@ def _generate_insert_sql(table, values, target_fields, replace, **kwargs):

[GitHub] [airflow] uranusjr commented on a change in pull request #17974: WIP: Implement before stm and after stm in DBApiHooks

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #17974: URL: https://github.com/apache/airflow/pull/17974#discussion_r702756827 ## File path: airflow/hooks/dbapi.py ## @@ -286,11 +300,19 @@ def _generate_insert_sql(table, values, target_fields, replace, **kwargs):

[GitHub] [airflow] ephraimbuddy commented on issue #18041: Tasks intermittently gets terminated with SIGTERM on kubernetes executor

2021-09-06 Thread GitBox
ephraimbuddy commented on issue #18041: URL: https://github.com/apache/airflow/issues/18041#issuecomment-913500788 For the task to receive sigterm means something is killing your pods. Task runner receives SIGTERM when Pod is deleted. Can you check if something else is deleting your pods?

[GitHub] [airflow] uranusjr commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
uranusjr commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r702753430 ## File path: airflow/utils/email.py ## @@ -85,7 +85,18 @@ def send_email_smtp( >>> send_email('t...@example.com', 'foo', 'Foo bar',

[GitHub] [airflow] Nimesh-K-Makwana edited a comment on issue #18041: Tasks intermittently gets terminated with SIGTERM on kubernetes executor

2021-09-06 Thread GitBox
Nimesh-K-Makwana edited a comment on issue #18041: URL: https://github.com/apache/airflow/issues/18041#issuecomment-913426604 Seems to be failing while waiting or when they are time-consuming (long-running). Providing the latest logs for a failed task due to sigterm : **Task

[GitHub] [airflow] github-actions[bot] commented on pull request #17986: Fix spelling

2021-09-06 Thread GitBox
github-actions[bot] commented on pull request #17986: URL: https://github.com/apache/airflow/pull/17986#issuecomment-913491657 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] potiuk commented on pull request #18045: Switch CI builds to use Python 3.7 by default

2021-09-06 Thread GitBox
potiuk commented on pull request #18045: URL: https://github.com/apache/airflow/pull/18045#issuecomment-913487867 Trying out if the `eager upgrade with python 3.7` is able to build the docs properly. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] potiuk opened a new pull request #18045: Switch CI builds to use Python 3.7 by default

2021-09-06 Thread GitBox
potiuk opened a new pull request #18045: URL: https://github.com/apache/airflow/pull/18045 Recent 3.6 image had a problem with building documentation with eager upgrade and updating to the latest python images. TypeError("unsupported operand type(s) for +: 'SSL_VERIFY_PEER' and

[GitHub] [airflow] ignaski commented on a change in pull request #18042: Fixing ses email backend

2021-09-06 Thread GitBox
ignaski commented on a change in pull request #18042: URL: https://github.com/apache/airflow/pull/18042#discussion_r702739485 ## File path: airflow/utils/email.py ## @@ -85,7 +85,18 @@ def send_email_smtp( >>> send_email('t...@example.com', 'foo', 'Foo bar',

[airflow] branch main updated (1be3ef6 -> bfad233)

2021-09-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1be3ef6 Improve the description of how to handle dynamic task generation (#17963) add bfad233 Fix providers

[GitHub] [airflow] potiuk commented on pull request #18040: Fix providers tests in main branch with eager upgrades

2021-09-06 Thread GitBox
potiuk commented on pull request #18040: URL: https://github.com/apache/airflow/pull/18040#issuecomment-913477853 The static checks fail due to .docker.json corruption (another race condition). Merging to test it in `main` -- This is an automated message from the Apache Git Service. To

  1   2   >