[GitHub] [airflow] uranusjr commented on pull request #18042: Fixing ses email backend

2021-09-14 Thread GitBox
uranusjr commented on pull request #18042: URL: https://github.com/apache/airflow/pull/18042#issuecomment-919721743 Also see #18200. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on pull request #18200: Add from_{address,name} configuration parameters

2021-09-14 Thread GitBox
uranusjr commented on pull request #18200: URL: https://github.com/apache/airflow/pull/18200#issuecomment-919721653 This conficts with #18042. We should figure out a conhesive plan on what exactly to do here. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] edwardwang888 commented on pull request #18033: Always draw borders if task instance state is null or undefined

2021-09-14 Thread GitBox
edwardwang888 commented on pull request #18033: URL: https://github.com/apache/airflow/pull/18033#issuecomment-919709962 @bbovenzi Added the screenshots above! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] uranusjr edited a comment on pull request #18243: Fix deleting of zipped Dags in Serialized Dag Table

2021-09-14 Thread GitBox
uranusjr edited a comment on pull request #18243: URL: https://github.com/apache/airflow/pull/18243#issuecomment-919699445 I think this needs a rebase. Not sure if the `max_retries` failures are related; don’t feel like it, but I don’t see anything in main modifying that recently either.

[GitHub] [airflow] jedcunningham closed issue #18246: Spurious message complaining of no heartbeat from Triggerer

2021-09-14 Thread GitBox
jedcunningham closed issue #18246: URL: https://github.com/apache/airflow/issues/18246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on issue #18246: Spurious message complaining of no heartbeat from Triggerer

2021-09-14 Thread GitBox
jedcunningham commented on issue #18246: URL: https://github.com/apache/airflow/issues/18246#issuecomment-919699571 This should be fixed by #18129 already (it didn't make it in before b1). -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] uranusjr commented on pull request #18243: Fix deleting of zipped Dags in Serialized Dag Table

2021-09-14 Thread GitBox
uranusjr commented on pull request #18243: URL: https://github.com/apache/airflow/pull/18243#issuecomment-919699445 I think this needs a rebase. Not sure if the `max_retries` failures are related; don’t feel like it, but I don’t see anything in main modifying that recently either. --

[GitHub] [airflow] uranusjr commented on pull request #18228: Fix provider test acessing importlib-resources

2021-09-14 Thread GitBox
uranusjr commented on pull request #18228: URL: https://github.com/apache/airflow/pull/18228#issuecomment-919698087 WTH this seems to break `mock_kinesis` somehow? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] jedcunningham commented on a change in pull request #18257: Ability to access http k8s via multiple hostnames

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18257: URL: https://github.com/apache/airflow/pull/18257#discussion_r708834400 ## File path: chart/values.schema.json ## @@ -126,10 +126,15 @@ "default": "" },

[GitHub] [airflow] uranusjr commented on a change in pull request #18258: Improve coverage for airflow.security.kerberos module

2021-09-14 Thread GitBox
uranusjr commented on a change in pull request #18258: URL: https://github.com/apache/airflow/pull/18258#discussion_r708834881 ## File path: tests/security/test_kerberos.py ## @@ -104,3 +105,255 @@ def test_args_from_cli(self): ) assert

[GitHub] [airflow] jedcunningham commented on a change in pull request #18249: Add support for securityContext per deployment

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18249: URL: https://github.com/apache/airflow/pull/18249#discussion_r708827609 ## File path: chart/values.schema.json ## @@ -70,6 +70,332 @@ "default": "2.1.3", "x-docsSection": "Common" },

[GitHub] [airflow] jedcunningham commented on a change in pull request #18147: Allow airflow standard images to run in openshift utilising the official helm chart #18136

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18147: URL: https://github.com/apache/airflow/pull/18147#discussion_r708819222 ## File path: docs/helm-chart/production-guide.rst ## @@ -200,3 +200,24 @@ By default, the chart will deploy Redis. However, you can use any

[GitHub] [airflow] uranusjr closed pull request #18228: Fix provider test acessing importlib-resources

2021-09-14 Thread GitBox
uranusjr closed pull request #18228: URL: https://github.com/apache/airflow/pull/18228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil edited a comment on pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
kaxil edited a comment on pull request #17552: URL: https://github.com/apache/airflow/pull/17552#issuecomment-919587937 cc @jwitz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
uranusjr commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708791466 ## File path: docs/apache-airflow/best-practices.rst ## @@ -43,21 +43,26 @@ Please follow our guide on :ref:`custom Operators `. Creating a task

[airflow] branch aip-39-docs updated (201b375 -> 28bc998)

2021-09-14 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch aip-39-docs in repository https://gitbox.apache.org/repos/asf/airflow.git. discard 201b375 Typos and wording/styling tweaks add 28bc998 Typos and wording/styling tweaks This update

[airflow] branch aip-39-docs updated (be38888 -> 201b375)

2021-09-14 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch aip-39-docs in repository https://gitbox.apache.org/repos/asf/airflow.git. from be3 Inline the example custom timetable DAG add 201b375 Typos and wording/styling tweaks No new

[GitHub] [airflow] uranusjr commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
uranusjr commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708789842 ## File path: docs/apache-airflow/faq.rst ## @@ -216,20 +216,35 @@ actually start. If this were not the case, the backfill just would not start.

[GitHub] [airflow] uranusjr commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
uranusjr commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708788427 ## File path: docs/apache-airflow/howto/timetable.rst ## @@ -0,0 +1,298 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or

[airflow] branch constraints-main updated: Updating constraints. Build id:1235775074

2021-09-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 1e48096 Updating

[GitHub] [airflow] satyarthn edited a comment on issue #9486: ECSOperator failed to display logs from Cloudwatch after providing log configurations

2021-09-14 Thread GitBox
satyarthn edited a comment on issue #9486: URL: https://github.com/apache/airflow/issues/9486#issuecomment-919635087 Another take on trying to figure out what is happening. My ECS console shows task_id as this

[GitHub] [airflow] satyarthn commented on issue #9486: ECSOperator failed to display logs from Cloudwatch after providing log configurations

2021-09-14 Thread GitBox
satyarthn commented on issue #9486: URL: https://github.com/apache/airflow/issues/9486#issuecomment-919635087 Another take on trying to figure out what is happening. My ECS console shows task_id as this

[GitHub] [airflow] subkanthi commented on a change in pull request #17068: Influxdb Hook

2021-09-14 Thread GitBox
subkanthi commented on a change in pull request #17068: URL: https://github.com/apache/airflow/pull/17068#discussion_r708776531 ## File path: tests/providers/influxdb/hooks/test_influxDbHook.py ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] subkanthi commented on a change in pull request #17068: Influxdb Hook

2021-09-14 Thread GitBox
subkanthi commented on a change in pull request #17068: URL: https://github.com/apache/airflow/pull/17068#discussion_r708776531 ## File path: tests/providers/influxdb/hooks/test_influxDbHook.py ## @@ -0,0 +1,56 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [airflow] satyarthn edited a comment on issue #9486: ECSOperator failed to display logs from Cloudwatch after providing log configurations

2021-09-14 Thread GitBox
satyarthn edited a comment on issue #9486: URL: https://github.com/apache/airflow/issues/9486#issuecomment-919600135 Per the Documentation `If you don't specify a prefix with this option, then the log stream is named after the container ID that is assigned by the Docker daemon on

[GitHub] [airflow] uranusjr edited a comment on pull request #18228: Fix provider test acessing importlib-resources

2021-09-14 Thread GitBox
uranusjr edited a comment on pull request #18228: URL: https://github.com/apache/airflow/pull/18228#issuecomment-919623649 I’ve applied the importlib-resources version bump. My change is different from #18209 in several ways: 1. I bumped to 5.2 instead of 5.0. This is because the

[GitHub] [airflow] uranusjr commented on pull request #18228: Fix provider test acessing importlib-resources

2021-09-14 Thread GitBox
uranusjr commented on pull request #18228: URL: https://github.com/apache/airflow/pull/18228#issuecomment-919623649 I’ve applied the importlib-resources version bump. My change is different from #18209 in several ways: 1. I bumped to 5.2 instead of 5.0. This is because the mock

[GitHub] [airflow] kaxil commented on pull request #18226: Add start date to trigger_dagrun operator

2021-09-14 Thread GitBox
kaxil commented on pull request #18226: URL: https://github.com/apache/airflow/pull/18226#issuecomment-919621292 ``` === short test summary info FAILED tests/models/test_cleartasks.py::TestClearTasks::test_clear_task_instances

[GitHub] [airflow] kaxil opened a new pull request #18259: Add ``triggerer`` to ``./breeze start-airflow`` command

2021-09-14 Thread GitBox
kaxil opened a new pull request #18259: URL: https://github.com/apache/airflow/pull/18259 This adds ``airflow triggerer`` command to ``./breeze start-airflow`` ![image](https://user-images.githubusercontent.com/8811558/133353878-cef8c048-bc5b-4576-a2d3-78aa9887d88e.png)

[GitHub] [airflow] kaxil commented on pull request #18228: Fix provider test acessing importlib-resources

2021-09-14 Thread GitBox
kaxil commented on pull request #18228: URL: https://github.com/apache/airflow/pull/18228#issuecomment-919617368 I have reverted the `importlib-resources` changes - https://github.com/apache/airflow/pull/18250. Can you add those changes in this PR again so we test it with the change. --

[airflow] branch main updated: Make sure create_user arguments are keyword-ed (#18248)

2021-09-14 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 292751c Make sure create_user arguments are

[GitHub] [airflow] uranusjr merged pull request #18248: Make sure create_user arguments are keyword-ed

2021-09-14 Thread GitBox
uranusjr merged pull request #18248: URL: https://github.com/apache/airflow/pull/18248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18251: Improves installing from sources pages for all components

2021-09-14 Thread GitBox
github-actions[bot] commented on pull request #18251: URL: https://github.com/apache/airflow/pull/18251#issuecomment-919605754 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] satyarthn edited a comment on issue #9486: ECSOperator failed to display logs from Cloudwatch after providing log configurations

2021-09-14 Thread GitBox
satyarthn edited a comment on issue #9486: URL: https://github.com/apache/airflow/issues/9486#issuecomment-919600135 Per the Documentation `If you don't specify a prefix with this option, then the log stream is named after the container ID that is assigned by the Docker daemon on

[GitHub] [airflow] satyarthn commented on issue #9486: ECSOperator failed to display logs from Cloudwatch after providing log configurations

2021-09-14 Thread GitBox
satyarthn commented on issue #9486: URL: https://github.com/apache/airflow/issues/9486#issuecomment-919600135 Ok. I believe the problem I am seeing is not with the ECSOperator, but with the AWS's ECS Task Definition UI. When I check the `Auto-configure CloudWatch Logs` , it does not

[GitHub] [airflow] kaxil commented on a change in pull request #17121: Deactivating DAGs which have been removed from files

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #17121: URL: https://github.com/apache/airflow/pull/17121#discussion_r708745692 ## File path: airflow/dag_processing/processor.py ## @@ -645,3 +648,12 @@ def process_file( self.log.exception("Error logging import

[GitHub] [airflow] kaxil commented on a change in pull request #17121: Deactivating DAGs which have been removed from files

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #17121: URL: https://github.com/apache/airflow/pull/17121#discussion_r708745286 ## File path: airflow/models/dag.py ## @@ -2656,11 +2655,6 @@ def deactivate_deleted_dags(cls, alive_dag_filelocs: List[str], session=None):

[GitHub] [airflow] mik-laj commented on a change in pull request #18257: Ability to access http k8s via multiple hostnames

2021-09-14 Thread GitBox
mik-laj commented on a change in pull request #18257: URL: https://github.com/apache/airflow/pull/18257#discussion_r708744374 ## File path: chart/values.schema.json ## @@ -126,10 +126,15 @@ "default": "" },

[GitHub] [airflow] satyarthn commented on issue #9486: ECSOperator failed to display logs from Cloudwatch after providing log configurations

2021-09-14 Thread GitBox
satyarthn commented on issue #9486: URL: https://github.com/apache/airflow/issues/9486#issuecomment-919597341 Folks, I went through this entire thread, but not able to troubleshoot the issue. I am having the same issue. So I can see CloudWatch has my logs ```

[GitHub] [airflow] SamWheating commented on a change in pull request #17121: Deactivating DAGs which have been removed from files

2021-09-14 Thread GitBox
SamWheating commented on a change in pull request #17121: URL: https://github.com/apache/airflow/pull/17121#discussion_r708743677 ## File path: airflow/models/dag.py ## @@ -2656,11 +2655,6 @@ def deactivate_deleted_dags(cls, alive_dag_filelocs: List[str], session=None):

[GitHub] [airflow] SamWheating commented on a change in pull request #17121: Deactivating DAGs which have been removed from files

2021-09-14 Thread GitBox
SamWheating commented on a change in pull request #17121: URL: https://github.com/apache/airflow/pull/17121#discussion_r708743677 ## File path: airflow/models/dag.py ## @@ -2656,11 +2655,6 @@ def deactivate_deleted_dags(cls, alive_dag_filelocs: List[str], session=None):

[GitHub] [airflow] github-actions[bot] commented on pull request #15277: Remove support for FAB `APP_THEME`

2021-09-14 Thread GitBox
github-actions[bot] commented on pull request #15277: URL: https://github.com/apache/airflow/pull/15277#issuecomment-919595241 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on pull request #8082: [AIRFLOW-4355] removed task should not lead to dagrun success

2021-09-14 Thread GitBox
github-actions[bot] commented on pull request #8082: URL: https://github.com/apache/airflow/pull/8082#issuecomment-919595353 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] closed issue #13925: Duplicate entry with MySQL backend (AriFlow 2.0.0)

2021-09-14 Thread GitBox
github-actions[bot] closed issue #13925: URL: https://github.com/apache/airflow/issues/13925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #13925: Duplicate entry with MySQL backend (AriFlow 2.0.0)

2021-09-14 Thread GitBox
github-actions[bot] commented on issue #13925: URL: https://github.com/apache/airflow/issues/13925#issuecomment-919595272 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] rab170 commented on pull request #18117: Update wasb.rst

2021-09-14 Thread GitBox
rab170 commented on pull request #18117: URL: https://github.com/apache/airflow/pull/18117#issuecomment-919592896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] kaxil commented on a change in pull request #17121: Deactivating DAGs which have been removed from files

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #17121: URL: https://github.com/apache/airflow/pull/17121#discussion_r708739971 ## File path: airflow/models/dag.py ## @@ -2656,11 +2655,6 @@ def deactivate_deleted_dags(cls, alive_dag_filelocs: List[str], session=None):

[GitHub] [airflow] rab170 edited a comment on pull request #18117: Update wasb.rst

2021-09-14 Thread GitBox
rab170 edited a comment on pull request #18117: URL: https://github.com/apache/airflow/pull/18117#issuecomment-919591212 thanks :) certainly a small contribution! haha next one is guaranteed to be be strictly greater than or equal in size :D -- This is an automated

[GitHub] [airflow] rab170 commented on pull request #18117: Update wasb.rst

2021-09-14 Thread GitBox
rab170 commented on pull request #18117: URL: https://github.com/apache/airflow/pull/18117#issuecomment-919591212 thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] kaxil commented on pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
kaxil commented on pull request #17552: URL: https://github.com/apache/airflow/pull/17552#issuecomment-919587937 cc @ jwitz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] kaxil commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708734047 ## File path: docs/apache-airflow/faq.rst ## @@ -216,20 +216,35 @@ actually start. If this were not the case, the backfill just would not start. What

[GitHub] [airflow] kaxil commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708733553 ## File path: docs/apache-airflow/dag-run.rst ## @@ -54,17 +54,36 @@ Cron Presets Your DAG will be instantiated for each schedule along with a

[GitHub] [airflow] tikikun edited a comment on issue #15635: ARM64 support in docker images

2021-09-14 Thread GitBox
tikikun edited a comment on issue #15635: URL: https://github.com/apache/airflow/issues/15635#issuecomment-919575669 Hi everyone, is Airflow supporting ARM64 now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] tikikun commented on issue #15635: ARM64 support in docker images

2021-09-14 Thread GitBox
tikikun commented on issue #15635: URL: https://github.com/apache/airflow/issues/15635#issuecomment-919575669 Hi everyone, is Docker supporting ARM64 now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] mik-laj opened a new pull request #18258: Improve coverage for airflow.security.kerberos module

2021-09-14 Thread GitBox
mik-laj opened a new pull request #18258: URL: https://github.com/apache/airflow/pull/18258 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[GitHub] [airflow] github-actions[bot] commented on pull request #18243: Fix deleting of zipped Dags in Serialized Dag Table

2021-09-14 Thread GitBox
github-actions[bot] commented on pull request #18243: URL: https://github.com/apache/airflow/pull/18243#issuecomment-919505236 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] jedcunningham commented on a change in pull request #18243: Fix deleting of zipped Dags in Serialized Dag Table

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18243: URL: https://github.com/apache/airflow/pull/18243#discussion_r708623755 ## File path: airflow/dag_processing/manager.py ## @@ -660,13 +661,29 @@ def _refresh_dag_dir(self):

[GitHub] [airflow] fredthomsen opened a new pull request #18257: Ability to access http k8s via multiple hostnames

2021-09-14 Thread GitBox
fredthomsen opened a new pull request #18257: URL: https://github.com/apache/airflow/pull/18257 Template the airflow ui and flower ingress in the helm chart to enable them to be accessed via multiple hostnames. Also quote hostnames so that wildcard hostnames can be used. The

[GitHub] [airflow] eladkal commented on issue #15951: Mark tasks as critical

2021-09-14 Thread GitBox
eladkal commented on issue #15951: URL: https://github.com/apache/airflow/issues/15951#issuecomment-919478949 Not ideal but you can solve it by placing PythonOperator after the terminate task. The operator can look for the main task status and set to fail/success accordingly. --

[GitHub] [airflow] eladkal commented on issue #8703: Support for set in XCom serialization

2021-09-14 Thread GitBox
eladkal commented on issue #8703: URL: https://github.com/apache/airflow/issues/8703#issuecomment-919473918 @kaxil https://github.com/apache/airflow/pull/16395 was on hold for a fix here. Should we also close the linked issue https://github.com/apache/airflow/issues/16386 ? -- This

[GitHub] [airflow] jaketf closed pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf closed pull request #18222: URL: https://github.com/apache/airflow/pull/18222 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal closed issue #17072: MSSQL on CI has been consistently failing

2021-09-14 Thread GitBox
eladkal closed issue #17072: URL: https://github.com/apache/airflow/issues/17072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on issue #17072: MSSQL on CI has been consistently failing

2021-09-14 Thread GitBox
eladkal commented on issue #17072: URL: https://github.com/apache/airflow/issues/17072#issuecomment-919470650 solved by https://github.com/apache/airflow/pull/17078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] andrewgodwin opened a new pull request #18254: Add metrics docs for triggerer metrics

2021-09-14 Thread GitBox
andrewgodwin opened a new pull request #18254: URL: https://github.com/apache/airflow/pull/18254 Follow-on from https://github.com/apache/airflow/pull/18214 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] jedcunningham commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708574349 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] Jorricks commented on pull request #17207: Fix external_executor_id not being set for manually run jobs.

2021-09-14 Thread GitBox
Jorricks commented on pull request #17207: URL: https://github.com/apache/airflow/pull/17207#issuecomment-919455634 Rebased on latest main again to see if that makes it better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] Jorricks edited a comment on pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-09-14 Thread GitBox
Jorricks edited a comment on pull request #16634: URL: https://github.com/apache/airflow/pull/16634#issuecomment-919453822 The `create_task_instance_of_operator` decorator in `conftest.py` made my life a lot easier :v: Tests should be fixed now :) -- This is an automated message from

[GitHub] [airflow] Jorricks commented on pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-09-14 Thread GitBox
Jorricks commented on pull request #16634: URL: https://github.com/apache/airflow/pull/16634#issuecomment-919453822 The `create_task_instance_of_operator` made my life a lot easier :v: Tests should be fixed now :) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] alexInhert opened a new issue #18253: Allow to write to task log from task policy

2021-09-14 Thread GitBox
alexInhert opened a new issue #18253: URL: https://github.com/apache/airflow/issues/18253 ### Description Airflow offers Task policies. The problem is that while task policy alter the task and replace parameters there is no way to indicate to the user that parameters were

[GitHub] [airflow] potiuk commented on issue #18113: callback functions not called when a dag run is marked success or failure

2021-09-14 Thread GitBox
potiuk commented on issue #18113: URL: https://github.com/apache/airflow/issues/18113#issuecomment-919450649 > One thing I do want to look at soon, however, is extending the Executor interface to allow executors to run more than just Tasks - in essence, opening up the ability to submit

[GitHub] [airflow] potiuk commented on pull request #18251: Improves installing from sources pages for all components

2021-09-14 Thread GitBox
potiuk commented on pull request #18251: URL: https://github.com/apache/airflow/pull/18251#issuecomment-919442578 ![Screenshot 2021-09-14 21 14 33](https://user-images.githubusercontent.com/595491/133319873-6fe3b27e-ab12-4ff9-8d16-666f7edcb229.png) ![Screenshot 2021-09-14 21 09

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #18243: Fix deleting of zipped Dags in Serialized Dag Table

2021-09-14 Thread GitBox
ephraimbuddy commented on a change in pull request #18243: URL: https://github.com/apache/airflow/pull/18243#discussion_r708558352 ## File path: airflow/models/dag.py ## @@ -2814,10 +2815,24 @@ def deactivate_deleted_dags(cls, alive_dag_filelocs: List[str], session=None):

[GitHub] [airflow] jaketf commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708557702 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] andrewgodwin commented on issue #18113: callback functions not called when a dag run is marked success or failure

2021-09-14 Thread GitBox
andrewgodwin commented on issue #18113: URL: https://github.com/apache/airflow/issues/18113#issuecomment-919439356 Unfortunately the triggerer mechanism doesn't solve this - triggers can run separately, but even to raise a task failure, deferred tasks have to be sent back to a worker to

[GitHub] [airflow] potiuk opened a new pull request #18251: Improves installing from sources pages for all components

2021-09-14 Thread GitBox
potiuk opened a new pull request #18251: URL: https://github.com/apache/airflow/pull/18251 * Shorter menu sections for installation page * Added "installing from sources" for Helm Chart * Added Providers summary page for all provider packages * Added scripts to verify PyPI packages

[GitHub] [airflow] kaxil commented on a change in pull request #18226: Add start date to trigger_dagrun operator

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #18226: URL: https://github.com/apache/airflow/pull/18226#discussion_r708553715 ## File path: tests/operators/test_trigger_dagrun.py ## @@ -255,3 +255,33 @@ def test_trigger_dagrun_with_wait_for_completion_true_fail(self):

[GitHub] [airflow] kaxil commented on a change in pull request #18226: Add start date to trigger_dagrun operator

2021-09-14 Thread GitBox
kaxil commented on a change in pull request #18226: URL: https://github.com/apache/airflow/pull/18226#discussion_r708553250 ## File path: tests/operators/test_trigger_dagrun.py ## @@ -255,3 +255,33 @@ def test_trigger_dagrun_with_wait_for_completion_true_fail(self):

[airflow] branch main updated (778be79 -> c73004d)

2021-09-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 778be79 Fix example dag of PostgresOperator (#18236) add c73004d Revert Changes to ``importlib-resources``

[airflow] branch constraints-main updated: Revert "Bump importlib-resources"

2021-09-14 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new cdd43c5 Revert "Bump

[GitHub] [airflow] kaxil merged pull request #18250: Revert Changes to ``importlib-resources``

2021-09-14 Thread GitBox
kaxil merged pull request #18250: URL: https://github.com/apache/airflow/pull/18250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #18250: Revert Changes to ``importlib-resources``

2021-09-14 Thread GitBox
github-actions[bot] commented on pull request #18250: URL: https://github.com/apache/airflow/pull/18250#issuecomment-919428303 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] jedcunningham commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708543688 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] kaxil opened a new pull request #18250: Revert Changes to ``importlib-resources``

2021-09-14 Thread GitBox
kaxil opened a new pull request #18250: URL: https://github.com/apache/airflow/pull/18250 Revert changes in #18209 and #18215 as it is causing issues --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] jedcunningham commented on pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jedcunningham commented on pull request #18222: URL: https://github.com/apache/airflow/pull/18222#issuecomment-919408132 > it feels misleading for that 403 page to say "user has no roles and/**or** permissions" if we really are only checking roles. It's actually checking both given

[GitHub] [airflow] john-jac commented on pull request #18211: Support all Unix wildcards in S3KeySensor

2021-09-14 Thread GitBox
john-jac commented on pull request #18211: URL: https://github.com/apache/airflow/pull/18211#issuecomment-919400424 > Can you add tests to avoid regression? Added tests for both changes. Should have thought of that myself. Thanks Kamil! -- This is an automated message from the

[GitHub] [airflow] jhtimmins commented on pull request #16634: Require can_edit on DAG privileges to modify TaskInstances and DagRuns

2021-09-14 Thread GitBox
jhtimmins commented on pull request #16634: URL: https://github.com/apache/airflow/pull/16634#issuecomment-919399312 @Jorricks sorry this got lost in the inbox. I'll take a look today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jaketf commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708483857 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] jaketf commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708488295 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] yzhanggithub commented on issue #15978: DAG getting stuck in "running" state indefinitely

2021-09-14 Thread GitBox
yzhanggithub commented on issue #15978: URL: https://github.com/apache/airflow/issues/15978#issuecomment-919389023 I had a similar issue, in my case, it worked fine after I fixed this error (from airflow.log). airflow command error: argument GROUP_OR_COMMAND: `airflow worker` command,

[GitHub] [airflow] blcksrx commented on pull request #17974: WIP: Implement before stm and after stm in DBApiHooks

2021-09-14 Thread GitBox
blcksrx commented on pull request #17974: URL: https://github.com/apache/airflow/pull/17974#issuecomment-919387845 @uranusjr I implemented some methods on MySQLHook about what you said. can you verify that its the one that you described and after that I can continue it to other hooks.

[GitHub] [airflow] jaketf edited a comment on pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf edited a comment on pull request #18222: URL: https://github.com/apache/airflow/pull/18222#issuecomment-919365903 > I mean, both Airflow and FAB overall assume permissions come from roles. hmm, that's good to know. it feels misleading for that 403 page to say "user has no

[GitHub] [airflow] jaketf commented on pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf commented on pull request #18222: URL: https://github.com/apache/airflow/pull/18222#issuecomment-919365903 > I mean, both Airflow and FAB overall assume permissions come from roles. hmm, that's good to know. it feels misleading for that 403 page to say "user has no roles

[GitHub] [airflow] jaketf commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708488295 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] jaketf commented on a change in pull request #18222: make current_user_has_permissions backwards compatible

2021-09-14 Thread GitBox
jaketf commented on a change in pull request #18222: URL: https://github.com/apache/airflow/pull/18222#discussion_r708483857 ## File path: airflow/www/security.py ## @@ -346,10 +346,7 @@ def get_current_user_permissions(self): return perms def

[GitHub] [airflow] bmckallagat-os commented on pull request #18215: Solve CI issues

2021-09-14 Thread GitBox
bmckallagat-os commented on pull request #18215: URL: https://github.com/apache/airflow/pull/18215#issuecomment-919345094 @kaxil No worries! Thanks for the approval -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] jedcunningham commented on a change in pull request #18243: Fix deleting of zipped Dags in Serialized Dag Table

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #18243: URL: https://github.com/apache/airflow/pull/18243#discussion_r708463072 ## File path: airflow/models/dag.py ## @@ -2814,10 +2815,24 @@ def deactivate_deleted_dags(cls, alive_dag_filelocs: List[str], session=None):

[GitHub] [airflow] jedcunningham commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
jedcunningham commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708453197 ## File path: docs/apache-airflow/howto/timetable.rst ## @@ -0,0 +1,298 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [airflow] alex-astronomer commented on issue #18217: Audit Logging for Variables, Connections, Pools

2021-09-14 Thread GitBox
alex-astronomer commented on issue #18217: URL: https://github.com/apache/airflow/issues/18217#issuecomment-919323312 Love that idea. I was starting to look in the Variables (`variables.py`) and found a `set(...)` function that looks like the root for where variables are set. That was

[GitHub] [airflow] ashb commented on a change in pull request #17552: AIP 39: Documentation

2021-09-14 Thread GitBox
ashb commented on a change in pull request #17552: URL: https://github.com/apache/airflow/pull/17552#discussion_r708451254 ## File path: docs/apache-airflow/howto/timetable.rst ## @@ -0,0 +1,298 @@ + .. Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] [airflow] dimberman closed pull request #17270: Make decorators pluggable

2021-09-14 Thread GitBox
dimberman closed pull request #17270: URL: https://github.com/apache/airflow/pull/17270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >