github-actions[bot] commented on pull request #18783:
URL: https://github.com/apache/airflow/pull/18783#issuecomment-936938273
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and tak
github-actions[bot] commented on pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#issuecomment-936932850
The PR is likely ready to be merged. No tests are needed as no important
environment files, nor python files were modified by it. However, committers
might decide
kaxil opened a new pull request #18783:
URL: https://github.com/apache/airflow/pull/18783
`WARN` is deprecated in favor of `WARNING`
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUT
github-actions[bot] commented on pull request #18782:
URL: https://github.com/apache/airflow/pull/18782#issuecomment-936902413
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and tak
kaxil opened a new pull request #18782:
URL: https://github.com/apache/airflow/pull/18782
```
https://github.com/asottile/pyupgrade : v2.25.1 -> v2.29.0.
https://github.com/psf/black: 21.8b0 -> 21.9b0.
```
---
**^ Add meaningful description above**
Read the
eladkal commented on pull request #18781:
URL: https://github.com/apache/airflow/pull/18781#issuecomment-936894506
Maybe also they could improve our website
https://github.com/apache/airflow-site/issues ?
--
This is an automated message from the Apache Git Service.
To respond to the mess
jedcunningham commented on a change in pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#discussion_r723581946
##
File path: CHANGELOG.txt
##
@@ -121,8 +127,14 @@ Improvements
Bug Fixes
"
+- Make REST API patch user endpoint work the same way as
potiuk commented on pull request #18781:
URL: https://github.com/apache/airflow/pull/18781#issuecomment-936879605
> Do we want too given the experience of last time?
I think it's worth trying.
They changed the rules - for example two `spam` from maintainers might
disqualify you c
kaxil commented on a change in pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#discussion_r723579429
##
File path: CHANGELOG.txt
##
@@ -121,8 +127,14 @@ Improvements
Bug Fixes
"
+- Make REST API patch user endpoint work the same way as the UI
eladkal commented on issue #16740:
URL: https://github.com/apache/airflow/issues/16740#issuecomment-936872437
@dvd9604 are you still working on this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jedcunningham commented on a change in pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#discussion_r723577063
##
File path: CHANGELOG.txt
##
@@ -6,15 +6,16 @@ New Features
- AIP-39: Add (customizable) Timetable class to Airflow for richer scheduling
be
eladkal commented on issue #16807:
URL: https://github.com/apache/airflow/issues/16807#issuecomment-936870180
Can you show an example of your log today in compare to how you want it to
be?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kaxil commented on a change in pull request #17927:
URL: https://github.com/apache/airflow/pull/17927#discussion_r723576729
##
File path: docs/apache-airflow/concepts/tasks.rst
##
@@ -36,16 +36,30 @@ Relationships
The key part of using Tasks is defining how they relate to ea
github-actions[bot] commented on pull request #18781:
URL: https://github.com/apache/airflow/pull/18781#issuecomment-936861781
The PR is likely ready to be merged. No tests are needed as no important
environment files, nor python files were modified by it. However, committers
might decide
eladkal commented on issue #17148:
URL: https://github.com/apache/airflow/issues/17148#issuecomment-936861828
@bbovenzi is this fixed in the new tree view
https://github.com/apache/airflow/pull/18675 ?
--
This is an automated message from the Apache Git Service.
To respond to the message
jedcunningham commented on a change in pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#discussion_r723573308
##
File path: CHANGELOG.txt
##
@@ -202,6 +215,7 @@ Bug Fixes
Doc only changes
+- Remove ``AIRFLOW_GID`` from Docker images (#
kaxil commented on a change in pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#discussion_r723572473
##
File path: CHANGELOG.txt
##
@@ -6,15 +6,16 @@ New Features
- AIP-39: Add (customizable) Timetable class to Airflow for richer scheduling
behaviour
matsavage commented on a change in pull request #18773:
URL: https://github.com/apache/airflow/pull/18773#discussion_r723571752
##
File path: airflow/providers/google/cloud/operators/datafusion.py
##
@@ -826,10 +826,8 @@ def __init__(
if success_states:
potiuk opened a new pull request #18781:
URL: https://github.com/apache/airflow/pull/18781
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more info
mik-laj commented on a change in pull request #18780:
URL: https://github.com/apache/airflow/pull/18780#discussion_r723569199
##
File path: CHANGELOG.txt
##
@@ -202,6 +215,7 @@ Bug Fixes
Doc only changes
+- Remove ``AIRFLOW_GID`` from Docker images (#18747)
eladkal commented on a change in pull request #17927:
URL: https://github.com/apache/airflow/pull/17927#discussion_r723567582
##
File path: docs/apache-airflow/concepts/tasks.rst
##
@@ -36,16 +36,30 @@ Relationships
The key part of using Tasks is defining how they relate to
eladkal commented on pull request #17776:
URL: https://github.com/apache/airflow/pull/17776#issuecomment-936836003
> @uranusjr I merged main and tests pass now
static checks are failing:
```
Run
flake8.
eladkal commented on a change in pull request #18441:
URL: https://github.com/apache/airflow/pull/18441#discussion_r723561631
##
File path: airflow/www/views.py
##
@@ -1552,9 +1553,16 @@ def run(self):
valid_kubernetes_config = isinstance(executor, KubernetesExecut
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 43f334f Move docker decorator example dag to do
kaxil merged pull request #18739:
URL: https://github.com/apache/airflow/pull/18739
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
kaxil commented on a change in pull request #18772:
URL: https://github.com/apache/airflow/pull/18772#discussion_r72349
##
File path: airflow/task/task_runner/base_task_runner.py
##
@@ -66,7 +66,7 @@ def __init__(self, local_task_job):
# want to have to specify
github-actions[bot] commented on pull request #18772:
URL: https://github.com/apache/airflow/pull/18772#issuecomment-936815745
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and tak
eladkal commented on pull request #18414:
URL: https://github.com/apache/airflow/pull/18414#issuecomment-936803897
Rebase should fix the failing tests:
```
tests/always/test_example_dags.py::TestExampleDags::test_should_be_importable:
failed on setup with "Failed: Timeout >20.0s"
eladkal commented on pull request #17349:
URL: https://github.com/apache/airflow/pull/17349#issuecomment-936797911
@rounakdatta can you please rebase?
The test failure
`tests/www/views/test_views_dagrun.py::test_delete_dagrun: AssertionError:
assert 1 == 0`
seems to be related to
boring-cyborg[bot] commented on issue #18779:
URL: https://github.com/apache/airflow/issues/18779#issuecomment-936758647
Thanks for opening your first issue here! Be sure to follow the issue
template!
--
This is an automated message from the Apache Git Service.
To respond to the mess
marchinho11 opened a new issue #18779:
URL: https://github.com/apache/airflow/issues/18779
### Apache Airflow version
2.1.4 (latest released)
### Operating System
Ubuntu 20.04.3 LTS (Focal Fossa)
### Versions of Apache Airflow Providers
apache-airflow-provi
ephraimbuddy commented on a change in pull request #18773:
URL: https://github.com/apache/airflow/pull/18773#discussion_r723525968
##
File path: airflow/providers/google/cloud/operators/datafusion.py
##
@@ -826,10 +826,8 @@ def __init__(
if success_states:
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 72e49ad Amazon SQS Example (#18760)
add cdb34a4 Quarantine iest_no_orphan_process_will_be_left (#18778)
No new
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from a36e7ba Make REST API patch user endpoint work the same way as the UI
(#18757)
add 72e49ad Amazon SQS Example
potiuk merged pull request #18778:
URL: https://github.com/apache/airflow/pull/18778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk merged pull request #18760:
URL: https://github.com/apache/airflow/pull/18760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
ashb commented on pull request #18745:
URL: https://github.com/apache/airflow/pull/18745#issuecomment-936705370
I'll see if I can _still_ reproduce it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
potiuk commented on pull request #18745:
URL: https://github.com/apache/airflow/pull/18745#issuecomment-936673517
Hey @ashb - I have an idea and need your help - if you can reproduce it
locally.
Can you please try:
```
./breeze --github-image-id 2057b5bacee40841f7c7255e45
alex-astronomer commented on pull request #18615:
URL: https://github.com/apache/airflow/pull/18615#issuecomment-936668630
Passing a `List[k8s.V1EnvVar]` through XCOM will not work for the same
reason, I can confirm @RickRen7575's point there. Here's some more color
around that:
Ev
mik-laj commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-936621680
Can you add docs about this option to
[docs/helm-chart](https://github.com/apache/airflow/tree/main/docs/helm-chart)?
--
This is an automated message from the Apache Git Ser
eladkal commented on a change in pull request #18755:
URL: https://github.com/apache/airflow/pull/18755#discussion_r723454625
##
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##
@@ -92,15 +117,34 @@ def __init__(
self.aws_conn_id = aws_conn_id
github-actions[bot] commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936604189
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and tak
github-actions[bot] commented on pull request #18760:
URL: https://github.com/apache/airflow/pull/18760#issuecomment-936601035
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not m
potiuk commented on pull request #18752:
URL: https://github.com/apache/airflow/pull/18752#issuecomment-936586052
REopened to rebuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
potiuk closed pull request #18752:
URL: https://github.com/apache/airflow/pull/18752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk edited a comment on pull request #18752:
URL: https://github.com/apache/airflow/pull/18752#issuecomment-936485659
> > Would it be possible to add a test for this?
>
> I struggled to think of a test that can add any value here while mocking
all interactions with the underlying
github-actions[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-936581354
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not m
potiuk opened a new pull request #18778:
URL: https://github.com/apache/airflow/pull/18778
This test fails too often. Quarantining it for now.
This is captured in #18777
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://g
potiuk opened a new issue #18777:
URL: https://github.com/apache/airflow/issues/18777
### Body
The `test_no_orphan_process_will_be_left` in `TestSchedulerJob` is really
flaky.
Before we know how to fix it, I will quarantine it:
https://github.com/apache/airflow/pull/186
Mrngilles opened a new pull request #18776:
URL: https://github.com/apache/airflow/pull/18776
Following #17447, I added a way to disable the Helm hooks so that the jobs
are properly created in ArgoCD.
This does not change the default behavior of the helm chart, but makes it
more
boring-cyborg[bot] commented on pull request #18776:
URL: https://github.com/apache/airflow/pull/18776#issuecomment-936557165
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Con
faycal-merouane commented on issue #17507:
URL: https://github.com/apache/airflow/issues/17507#issuecomment-936555469
hello , I'm facing the same issue : running `airflow version 2.1.4 ` with
`python version 3.8.10`
`[2021-10-06 15:44:35,118] {local_task_job.py:203} WARNING - Recorded pi
john-jac commented on a change in pull request #18760:
URL: https://github.com/apache/airflow/pull/18760#discussion_r723417222
##
File path: airflow/providers/amazon/aws/example_dags/example_sqs.py
##
@@ -0,0 +1,83 @@
+# Licensed to the Apache Software Foundation (ASF) under on
guotongfei commented on a change in pull request #18755:
URL: https://github.com/apache/airflow/pull/18755#discussion_r723416681
##
File path: airflow/providers/amazon/aws/transfers/mysql_to_s3.py
##
@@ -92,15 +108,27 @@ def __init__(
self.aws_conn_id = aws_conn_id
khalidmammadov commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936515618
Yes, I want to keep this one, the other can stay closed I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
khalidmammadov commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936508103
I accidentally closed it still getting used to GitHub UI (I've been
mainly using Azure DevOps). Not sure why close button always there! I will push
something to be
ephraimbuddy commented on pull request #18739:
URL: https://github.com/apache/airflow/pull/18739#issuecomment-936503802
> > Hi @potiuk , this failure seems related to DockerDecorator not usable in
airflow versions less than 2.2. It is failing at `import_all_provider_classes`
on airflow 2.1
potiuk commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936502025
It was pushed to different branch. Was it intended :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
potiuk commented on pull request #18752:
URL: https://github.com/apache/airflow/pull/18752#issuecomment-936485659
> > Would it be possible to add a test for this?
>
> I struggled to think of a test that can add any value here while mocking
all interactions with the underlying `smbpro
khalidmammadov closed pull request #18690:
URL: https://github.com/apache/airflow/pull/18690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
This is an automated email from the ASF dual-hosted git repository.
ephraimanierobi pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from cf27419 Fix Pendulum 1.x references in documentation (#18766)
add a36e7ba Make REST API patch user end
ephraimbuddy merged pull request #18757:
URL: https://github.com/apache/airflow/pull/18757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
ephraimbuddy closed issue #18702:
URL: https://github.com/apache/airflow/issues/18702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
ephraimbuddy closed issue #18703:
URL: https://github.com/apache/airflow/issues/18703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
potiuk commented on issue #18717:
URL: https://github.com/apache/airflow/issues/18717#issuecomment-936466524
Agree with @BasPH . It's pretty "normal" for the page to get refreshed with
refresh button when pretty much all content is refreshed. There is a very
(unless it's autor-refresh whic
fredthomsen commented on pull request #18752:
URL: https://github.com/apache/airflow/pull/18752#issuecomment-936464880
>
>
> Would it be possible to add a test for this?
I struggled to think of a test that can add any value here while mocking all
interactions with the underly
rubbengimenez commented on issue #13322:
URL: https://github.com/apache/airflow/issues/13322#issuecomment-936457291
Hi guys!
Just for those who are facing this issue when debugging a DAG with
DebugExecutor.
If you change your start_date and use the function days_ago instead of
khalidmammadov commented on pull request #18723:
URL: https://github.com/apache/airflow/pull/18723#issuecomment-936453292
Closing this as @ashb solved the actual issue with the call and hence not
duplicate anymore. #18772
--
This is an automated message from the Apache Git Service.
To re
khalidmammadov closed pull request #18723:
URL: https://github.com/apache/airflow/pull/18723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commi
khalidmammadov commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936441899
@potiuk thanks for that, wasn't sure what was going on...
Thanks for triggering it and providing clarification, I will do as you said
next time!
--
This is an aut
danarwix commented on issue #18770:
URL: https://github.com/apache/airflow/issues/18770#issuecomment-936417847
Hey :-)
Working on the fix
most of the changes are implemented and will be uploaded tomorrow :-)
--
This is an automated message from the Apache Git Service.
To respond
potiuk commented on issue #12103:
URL: https://github.com/apache/airflow/issues/12103#issuecomment-936413347
> > This issue is reported against old version of Airflow that reached end
of life. If the issue is reproducible on latest Airflow version please let us
know
>
> @eladkal yes
potiuk closed issue #12103:
URL: https://github.com/apache/airflow/issues/12103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr..
ashb commented on pull request #18772:
URL: https://github.com/apache/airflow/pull/18772#issuecomment-936405112
> Need to update the docstring for those new arguments.
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
potiuk commented on issue #18771:
URL: https://github.com/apache/airflow/issues/18771#issuecomment-936399227
Feel free! Assigned it to you @GuidoTournois
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
potiuk commented on pull request #18745:
URL: https://github.com/apache/airflow/pull/18745#issuecomment-936371801
> The same problem people are reporting in that thread is happening in this
CI build now, and also for me locally
OOOH. Nice! REPRODUCIBILITY!
I will take a look
potiuk edited a comment on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936329934
@khalidmammadov -> next time when some general failure like that happens,
simply rebase the PR to latest `main` - this wil trigger rebuild. Generally
speaking if for (wh
potiuk edited a comment on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936329934
@khalidmammadov -> next time when some general failure like that happens,
simply rebase the PR to latest `main` - this wil trigger rebuild. Generally
speaking if for (wh
potiuk commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936329934
@khalidmammadov -> next time when some general failure like that happens,
simply rebase the PR to latest `main` - this wil trigger rebuild. Generally
speaking if for (whatever
potiuk commented on pull request #18690:
URL: https://github.com/apache/airflow/pull/18690#issuecomment-936325314
Close/reopen to rebuild
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
potiuk closed pull request #18690:
URL: https://github.com/apache/airflow/pull/18690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk edited a comment on pull request #18739:
URL: https://github.com/apache/airflow/pull/18739#issuecomment-936318477
> Hi @potiuk , this failure seems related to DockerDecorator not usable in
airflow versions less than 2.2. It is failing at `import_all_provider_classes`
on airflow 2.1
potiuk commented on pull request #18739:
URL: https://github.com/apache/airflow/pull/18739#issuecomment-936318477
> Hi @potiuk , this failure seems related to DockerDecorator not usable in
airflow versions less than 2.2. It is failing at `import_all_provider_classes`
on airflow 2.1 for ins
BasPH commented on issue #18717:
URL: https://github.com/apache/airflow/issues/18717#issuecomment-936278792
I'd rather get the main page to also autorefresh. Adding yet another button
without reducing the number of clicks required to refresh doesn't feel like a
valuable addition IMO.
--
uranusjr commented on a change in pull request #18757:
URL: https://github.com/apache/airflow/pull/18757#discussion_r723293904
##
File path: airflow/api_connexion/endpoints/user_endpoint.py
##
@@ -124,9 +124,21 @@ def patch_user(username, update_mask=None):
if user is None
uranusjr commented on a change in pull request #18757:
URL: https://github.com/apache/airflow/pull/18757#discussion_r723293904
##
File path: airflow/api_connexion/endpoints/user_endpoint.py
##
@@ -124,9 +124,21 @@ def patch_user(username, update_mask=None):
if user is None
ephraimbuddy commented on a change in pull request #18757:
URL: https://github.com/apache/airflow/pull/18757#discussion_r723284713
##
File path: airflow/api_connexion/endpoints/user_endpoint.py
##
@@ -124,9 +124,21 @@ def patch_user(username, update_mask=None):
if user is
matsavage commented on pull request #18773:
URL: https://github.com/apache/airflow/pull/18773#issuecomment-936244123
@uranusjr I have just updated my description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
uranusjr commented on pull request #18773:
URL: https://github.com/apache/airflow/pull/18773#issuecomment-936243067
Please elaborate on the rationale behind this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
matsavage opened a new pull request #18773:
URL: https://github.com/apache/airflow/pull/18773
stops pipeline_timeout being overwritten in
CloudDataFusionStartPipelineOperator when success_states are specified
---
**^ Add meaningful description above**
Read the **[Pu
boring-cyborg[bot] commented on pull request #18773:
URL: https://github.com/apache/airflow/pull/18773#issuecomment-936234073
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Con
uranusjr commented on pull request #18772:
URL: https://github.com/apache/airflow/pull/18772#issuecomment-936225999
Need to update the docstring for those new arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723248430
##
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##
@@ -134,12 +138,17 @@ def client(self):
return session.client(s
JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723248430
##
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##
@@ -134,12 +138,17 @@ def client(self):
return session.client(s
kondla commented on issue #17507:
URL: https://github.com/apache/airflow/issues/17507#issuecomment-936206890
Thank you for this thread! I got the same problem running
`composer-1.17.1-airflow-2.1.2` on GCP:
```
[2021-10-06 13:05:57,236] {local_task_job.py:194} WARNING - Recorded p
JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723234732
##
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##
@@ -134,12 +138,17 @@ def client(self):
return session.client(s
JavierLopezT commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723234732
##
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##
@@ -134,12 +138,17 @@ def client(self):
return session.client(s
ashb commented on issue #18721:
URL: https://github.com/apache/airflow/issues/18721#issuecomment-936184811
> Might be related to #18746
Shouldn't be, since `default_args` are "merged" in by the metaclass before
`__init__()` is called, so it'll see them directly.
--
This is an auto
kaxil commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723220384
##
File path: airflow/providers/amazon/aws/secrets/secrets_manager.py
##
@@ -74,22 +74,26 @@ class SecretsManagerBackend(BaseSecretsBackend,
LoggingMixin
ashb commented on a change in pull request #18764:
URL: https://github.com/apache/airflow/pull/18764#discussion_r723218705
##
File path: tests/providers/amazon/aws/secrets/test_secrets_manager.py
##
@@ -93,7 +93,7 @@ def
test_get_conn_uri_broken_field_mode_extra_words_added(se
101 - 200 of 295 matches
Mail list logo