prabhjyotsingh commented on pull request #19025:
URL: https://github.com/apache/airflow/pull/19025#issuecomment-945062984
CI failed for "Quarantined tests" looks unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
zigius commented on a change in pull request #19030:
URL: https://github.com/apache/airflow/pull/19030#discussion_r730368762
##
File path: airflow/providers/amazon/aws/operators/ecs.py
##
@@ -120,9 +120,10 @@ def run(self) -> None:
logs_to_skip += 1
uranusjr commented on a change in pull request #19030:
URL: https://github.com/apache/airflow/pull/19030#discussion_r730392544
##
File path: airflow/providers/amazon/aws/operators/ecs.py
##
@@ -120,9 +120,10 @@ def run(self) -> None:
logs_to_skip += 1
PApostol opened a new pull request #19033:
URL: https://github.com/apache/airflow/pull/19033
Various typo fixes in `docs/apache-airflow-providers-*/commits.rst` files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jedcunningham commented on pull request #19003:
URL: https://github.com/apache/airflow/pull/19003#issuecomment-945130417
It's pretty similar (and semi-related) to an issue for workers I opened a
while back: #17191
I think having an endpoint makes sense, and we toggle whether the log
jedcunningham commented on issue #18894:
URL: https://github.com/apache/airflow/issues/18894#issuecomment-945131692
@ldacey, yep, deleting dagruns via the UI turns out to be a common way to
hit this (it's been a bug for a while it seems: #15986).
--
This is an automated message from the
jedcunningham opened a new pull request #19034:
URL: https://github.com/apache/airflow/pull/19034
This is partially done, I'm simply soliciting feedback.
Allow Param to support a default value of ``None``.
Also refactors Param to not store the resolved value into it's ``default
github-actions[bot] commented on pull request #18968:
URL: https://github.com/apache/airflow/pull/18968#issuecomment-945137772
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and tak
jedcunningham commented on a change in pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#discussion_r730426761
##
File path: airflow/models/param.py
##
@@ -24,6 +24,16 @@
from airflow.exceptions import AirflowException
+class NoValueSentinel:
Review c
uranusjr commented on pull request #18968:
URL: https://github.com/apache/airflow/pull/18968#issuecomment-945139090
As a side note, we are moving toward decoupling DAG runs against
`execution_date` and removing the unique constraint eventually, and when that
happens this code will become (
mik-laj closed pull request #19033:
URL: https://github.com/apache/airflow/pull/19033
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
mik-laj commented on pull request #19033:
URL: https://github.com/apache/airflow/pull/19033#issuecomment-945153636
I think it is counter-productive to correct spelling fixes in the lists of
commits that is generated automatically. They will be overridden next time we
release providers anyw
mik-laj edited a comment on pull request #19033:
URL: https://github.com/apache/airflow/pull/19033#issuecomment-945153636
I think it is counter-productive to correct spelling fixes in the lists of
commits that is generated automatically. They will be overridden next time we
release provide
meysam81 opened a new pull request #19035:
URL: https://github.com/apache/airflow/pull/19035
related #18950
This PR adds the missing imports in the [tutorials
page](https://airflow.apache.org/docs/apache-airflow/stable/tutorial.html#testing)
so that a snippet is runnable withou
boring-cyborg[bot] commented on pull request #19035:
URL: https://github.com/apache/airflow/pull/19035#issuecomment-945153764
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Con
meysam81 commented on pull request #19035:
URL: https://github.com/apache/airflow/pull/19035#issuecomment-945153906
cc @potiuk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
mik-laj commented on issue #19011:
URL: https://github.com/apache/airflow/issues/19011#issuecomment-945154430
Duplicate: https://github.com/apache/airflow/issues/16790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
mik-laj closed issue #19011:
URL: https://github.com/apache/airflow/issues/19011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr.
mik-laj merged pull request #18992:
URL: https://github.com/apache/airflow/pull/18992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
This is an automated email from the ASF dual-hosted git repository.
kamilbregula pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 80b5e65 Remove unnecessary string concatenations in AirflowException
in s3_to_hive.py (#19026)
add a418fd
mik-laj merged pull request #18855:
URL: https://github.com/apache/airflow/pull/18855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
kd2718 opened a new pull request #19036:
URL: https://github.com/apache/airflow/pull/19036
closes: #16611
related: #16980
Having a period in the name could cause issues with the hostname. Reverting
to hyphen will should fix the issues. I also included changes talked about in
boring-cyborg[bot] commented on pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#issuecomment-945165442
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Con
nikie commented on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945172125
A fast and persistent user is able to unblock the runs as follows:
5. Mark dagrun 2 as failed.
6. Once dagrun 1 starts executing - clear Task B in dagrun 2 so that dagrun
2 is s
nikie edited a comment on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945172125
The user is able to unblock the runs as follows:
5. Clear Task B in dagrun 2. This moves dagrun 2 into queued state. It
appears that clearing a task in "no_status" state dea
nikie edited a comment on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945172125
The user is able to unblock the runs as follows:
5. Clear Task B in dagrun 2. This moves dagrun 2 into queued state. It
appears that clearing a task in "no_status" state (wh
nikie edited a comment on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945172125
The user is able to unblock the runs as follows:
5. Clear Task B in dagrun 2. This moves dagrun 2 into queued state. It
appears that clearing a task in "no_status" state (wh
nikie edited a comment on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945172125
The user is able to unblock the runs as follows:
5. Clear Task B in dagrun 2. This moves dagrun 2 into queued state. It
appears that clearing a task in "no_status" state (wh
blcksrx commented on pull request #17974:
URL: https://github.com/apache/airflow/pull/17974#issuecomment-945174168
> We need to split that change into two independent ones and add pre-commit
protection to make sure that no provider will use the new before/aftter
statements without bumping
nikie edited a comment on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945172125
The user is able to unblock the runs as follows:
5. Clear Task B in dagrun 2. This moves dagrun 2 into queued state. It
appears that clearing a task in "no_status" state (wh
nikie commented on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945179427
This issue is similar to #17375 and might be related to #14205.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
nikie commented on issue #17375:
URL: https://github.com/apache/airflow/issues/17375#issuecomment-945179813
This issues is similar to #18304. I was able to workaround this as per
https://github.com/apache/airflow/issues/18304#issuecomment-945172125
--
This is an automated message from th
This is an automated email from the ASF dual-hosted git repository.
binh pushed a change to branch xinbinhuang-patch-1
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 7cd5ca7 Remove literal_eval
add c324c11 !fixup Remove ast import
No new revisions were added by t
andrenerd opened a new issue #19037:
URL: https://github.com/apache/airflow/issues/19037
### Description
Let's set the "replace_microseconds" default param to False:
https://github.com/apache/airflow/blob/5dd690b57a20ca944deb8d96e89ec6ae6161afeb/airflow/api/common/experimental
boring-cyborg[bot] commented on issue #19037:
URL: https://github.com/apache/airflow/issues/19037#issuecomment-945181897
Thanks for opening your first issue here! Be sure to follow the issue
template!
--
This is an automated message from the Apache Git Service.
To respond to the mess
github-actions[bot] commented on issue #11003:
URL: https://github.com/apache/airflow/issues/11003#issuecomment-945222824
This issue has been automatically marked as stale because it has been open
for 30 days with no response from the author. It will be closed in next 7 days
if no further
github-actions[bot] commented on issue #11007:
URL: https://github.com/apache/airflow/issues/11007#issuecomment-945222820
This issue has been automatically marked as stale because it has been open
for 30 days with no response from the author. It will be closed in next 7 days
if no further
uranusjr commented on a change in pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#discussion_r730514702
##
File path: airflow/models/param.py
##
@@ -24,6 +24,16 @@
from airflow.exceptions import AirflowException
+class NoValueSentinel:
Review commen
uranusjr commented on a change in pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#discussion_r730514702
##
File path: airflow/models/param.py
##
@@ -24,6 +24,16 @@
from airflow.exceptions import AirflowException
+class NoValueSentinel:
Review commen
uranusjr commented on a change in pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#discussion_r730514702
##
File path: airflow/models/param.py
##
@@ -24,6 +24,16 @@
from airflow.exceptions import AirflowException
+class NoValueSentinel:
Review commen
timgriffiths opened a new issue #19038:
URL: https://github.com/apache/airflow/issues/19038
### Apache Airflow version
2.2.0 (latest released)
### Operating System
Debian GNU/Linux 10 (buster)
### Versions of Apache Airflow Providers
apache-airflow-provider
uranusjr commented on a change in pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#discussion_r730516842
##
File path: tests/models/test_dag.py
##
@@ -34,6 +34,7 @@
import jinja2
import pendulum
import pytest
+from _pytest.mark import param
Review comm
uranusjr commented on issue #19038:
URL: https://github.com/apache/airflow/issues/19038#issuecomment-945274873
cc @andrewgodwin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
uranusjr commented on issue #19037:
URL: https://github.com/apache/airflow/issues/19037#issuecomment-945276261
The experiemental API is being deprecated, and we are probably not going to
change its behaviour. If it does not suit your need, we should make the REST
API available for your use
uranusjr commented on issue #19037:
URL: https://github.com/apache/airflow/issues/19037#issuecomment-945278364
BTW, the `trigger_dag` function, despite what the module it's in is named,
is actually also used by the CLI (`airflow dag trigger`) and
`TriggerDagRunOperator`, so changing the de
LionelZhao28 closed pull request #17502:
URL: https://github.com/apache/airflow/pull/17502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits
LionelZhao28 commented on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-945308470
give up.
closing this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
LionelZhao28 commented on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-945313036
rebase to the latest main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
LionelZhao28 removed a comment on pull request #17502:
URL: https://github.com/apache/airflow/pull/17502#issuecomment-945308470
give up.
closing this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
LionelZhao28 opened a new pull request #19039:
URL: https://github.com/apache/airflow/pull/19039
recreate the PR (origin: https://github.com/apache/airflow/pull/17502)
Why I commit this change:
When checking the airflow features, I found that the dag run_id is generated
using the
uranusjr commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730539747
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -304,21 +304,24 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable:
andrewgodwin commented on issue #19038:
URL: https://github.com/apache/airflow/issues/19038#issuecomment-945325670
Hm, yes, this is probably a lot more likely after my commit but would also
have been present before (since that function would still run on boot).
I'm curious why it que
uranusjr commented on pull request #19039:
URL: https://github.com/apache/airflow/pull/19039#issuecomment-945333562
We'll need to check all the places that look up `DagRun` (including
`DagRun.find()` and direct SQLAlchemy calls) to make sure they are passing in
`execution_date` correctly.
uranusjr commented on pull request #19039:
URL: https://github.com/apache/airflow/pull/19039#issuecomment-945333782
Converting this to draft for now since there are still many things to fix
before this PR can be mergable (even without the aforementioned DagRun lookup
issue).
--
This is
LionelZhao28 commented on pull request #19039:
URL: https://github.com/apache/airflow/pull/19039#issuecomment-945335050
> #18968
Sure. But I am busy with my works these days. And I may not continue to
check it until early November. I'll do it as soon as I can
--
This is an a
uranusjr commented on pull request #18968:
URL: https://github.com/apache/airflow/pull/18968#issuecomment-945336188
Actually, DagRun has a unique constraint on _both_ `execution_date` and
`run_id`. So while this fixes the duplicated `execution_date` issue, it'd
introduce a new issue of dup
uranusjr commented on pull request #19039:
URL: https://github.com/apache/airflow/pull/19039#issuecomment-945337000
No problem, there is totally no hurry, take your time. Open source
contribution is all about doing what you can when you can, please don't feel
pressured to do anything, we u
msumit commented on pull request #19034:
URL: https://github.com/apache/airflow/pull/19034#issuecomment-945355416
> On higher level it makes sense but would defer to @msumit
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
uranusjr commented on issue #18304:
URL: https://github.com/apache/airflow/issues/18304#issuecomment-945362143
> A possible fix could be to detect the deadlock situation and automatically
move dagrun 2 into queued state, clearing path for the dagrun 1. Not sure if
this is feasible from tec
uranusjr commented on a change in pull request #19036:
URL: https://github.com/apache/airflow/pull/19036#discussion_r730569637
##
File path: airflow/kubernetes/pod_generator.py
##
@@ -460,9 +460,9 @@ def make_unique_pod_id(pod_id: str) -> str:
safe_uuid = uuid.uuid4(
uranusjr commented on a change in pull request #17329:
URL: https://github.com/apache/airflow/pull/17329#discussion_r730570544
##
File path: airflow/hooks/dbapi.py
##
@@ -190,18 +191,24 @@ def run(self, sql, autocommit=False, parameters=None,
handler=None):
:param han
uranusjr commented on a change in pull request #18590:
URL: https://github.com/apache/airflow/pull/18590#discussion_r730571040
##
File path: airflow/cli/commands/user_command.py
##
@@ -174,12 +175,23 @@ def users_import(args):
print("Updated the following
users:\n\t{}
uranusjr commented on pull request #18590:
URL: https://github.com/apache/airflow/pull/18590#issuecomment-945366853
Since Marshmallow is already a hard dependency, I feel we should just use it
for validation instead of hand-rolling logic.
--
This is an automated message from the Apache G
uranusjr commented on issue #19024:
URL: https://github.com/apache/airflow/issues/19024#issuecomment-945367070
Can you elaborate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
casra-developers commented on pull request #16110:
URL: https://github.com/apache/airflow/pull/16110#issuecomment-945373000
@mik-laj thank you very much for your instructions. I will try to go for the
second option as the branch I was trying to rebase is now pretty much trashed
beyond repa
dstandish commented on pull request #19029:
URL: https://github.com/apache/airflow/pull/19029#issuecomment-945374180
> When worse is actually better 🙂
exactly :)
> This function being used under too many contexts is in itself a problem
though; without thinking this too hard,
uranusjr commented on pull request #19020:
URL: https://github.com/apache/airflow/pull/19020#issuecomment-945376338
Could you add the `int` type annotation to the corresponding line in
`BaseJob`?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
uranusjr commented on pull request #16931:
URL: https://github.com/apache/airflow/pull/16931#issuecomment-945378085
I don't think we support the 7th segment. The 6th has always been a problem
since croniter handles it incorrectly (as mentioned above), so we just leave it
undefined for the
hyungryuk commented on issue #13542:
URL: https://github.com/apache/airflow/issues/13542#issuecomment-945379278
i got same issue here. in my case, after i resizing airflow worker pod
resouece size. (smaller than before.) it happend!.
i'm not sure but it might related with your worker pod
uranusjr commented on a change in pull request #18961:
URL: https://github.com/apache/airflow/pull/18961#discussion_r730584282
##
File path: tests/www/test_security.py
##
@@ -78,629 +77,745 @@ def some_action(self):
return "action!"
-class TestSecurity(unittest.Tes
Jorricks commented on issue #13542:
URL: https://github.com/apache/airflow/issues/13542#issuecomment-945386663
> i got same issue here. in my case, after i resizing airflow worker pod
resouece size. (smaller than before.) it happend!. i'm not sure but it might
related with your worker pod
casra-developers commented on pull request #16110:
URL: https://github.com/apache/airflow/pull/16110#issuecomment-945395012
Good news :)
I've actually went along and just did a hard reset on the master branch of
the forked repository to be in sync with the main branch of the airlfow
rep
asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730596500
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -304,21 +304,24 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: b
asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730596676
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -304,21 +304,24 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: b
asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730597633
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: boo
asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730597633
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: boo
asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730598411
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: boo
asaf400 commented on a change in pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#discussion_r730598411
##
File path: airflow/providers/docker/operators/docker.py
##
@@ -328,7 +331,7 @@ def _run_image_with_mounts(self, target_mounts,
add_tmp_variable: boo
asaf400 commented on pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#issuecomment-945404914
Tests are failing with:
```python
tests/providers/docker/operators/test_docker.py::TestDockerOperator::test_execute_xcom_behavior:
TypeError: 'Mock' object does not supp
asaf400 edited a comment on pull request #19027:
URL: https://github.com/apache/airflow/pull/19027#issuecomment-945404914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lwyszomi closed pull request #18879:
URL: https://github.com/apache/airflow/pull/18879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
github-actions[bot] commented on pull request #19020:
URL: https://github.com/apache/airflow/pull/19020#issuecomment-945417477
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and tak
ephraimbuddy commented on a change in pull request #19019:
URL: https://github.com/apache/airflow/pull/19019#discussion_r730617597
##
File path: airflow/providers/jenkins/operators/jenkins_job_trigger.py
##
@@ -130,15 +130,6 @@ def build_job(self, jenkins_server: Jenkins, param
83 matches
Mail list logo
