[GitHub] [airflow] potiuk closed issue #19515: Status of testing of Apache Airflow 2.2.2rc1

2021-11-11 Thread GitBox
potiuk closed issue #19515: URL: https://github.com/apache/airflow/issues/19515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on issue #19515: Status of testing of Apache Airflow 2.2.2rc1

2021-11-11 Thread GitBox
potiuk commented on issue #19515: URL: https://github.com/apache/airflow/issues/19515#issuecomment-966072067 Closing as we will have rc2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [airflow] potiuk commented on pull request #19471: Add cli command for 'airflow dags reserialize`

2021-11-11 Thread GitBox
potiuk commented on pull request #19471: URL: https://github.com/apache/airflow/pull/19471#issuecomment-966081839 > #19367 / #18120 (WIP) will hopefully fix the underlying issue > > But a CLI command to show serialized representation, actually serialize from a dag file or clear -- al

[GitHub] [airflow] dobixu opened a new issue #19534: s

2021-11-11 Thread GitBox
dobixu opened a new issue #19534: URL: https://github.com/apache/airflow/issues/19534 ### Apache Airflow version 2.2.1 (latest released) ### Operating System Centos8.3.2011 ### Versions of Apache Airflow Providers apache-airflow-providers-celery==2.1.0 a

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19534: s

2021-11-11 Thread GitBox
boring-cyborg[bot] commented on issue #19534: URL: https://github.com/apache/airflow/issues/19534#issuecomment-966083438 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] uranusjr commented on issue #19534: s

2021-11-11 Thread GitBox
uranusjr commented on issue #19534: URL: https://github.com/apache/airflow/issues/19534#issuecomment-966085286 I don’t understand. The tasks are marked as queued, and why is this a problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] potiuk commented on issue #14396: Make context less nebulous

2021-11-11 Thread GitBox
potiuk commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-966088200 > @potiuk Extracting a Context class out into a new module was my initial thought, but it looked like you were arguing pretty hard _for_ the TypedDict solution. A new `airflow.model

[GitHub] [airflow] dobixu commented on issue #19534: s

2021-11-11 Thread GitBox
dobixu commented on issue #19534: URL: https://github.com/apache/airflow/issues/19534#issuecomment-966092129 > I don’t understand. The tasks are marked as queued, and why is this a problem? Thanks for reply. I don't want it marked as queued 。 after these tasks queued , They will

[GitHub] [airflow] dobixu commented on issue #19534: s

2021-11-11 Thread GitBox
dobixu commented on issue #19534: URL: https://github.com/apache/airflow/issues/19534#issuecomment-966093881 > > I don’t understand. The tasks are marked as queued, and why is this a problem? > > Thanks for reply. > > I don't want it marked as queued 。 after these tasks queued , T

[GitHub] [airflow] potiuk commented on issue #18932: Conflicts with airflow constraints for airflow 2.2.0 python 3.7

2021-11-11 Thread GitBox
potiuk commented on issue #18932: URL: https://github.com/apache/airflow/issues/18932#issuecomment-966094792 Hmm. indeed, something wrong is there. I will take look more closely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [airflow] uranusjr commented on a change in pull request #19487: Fix task instance api cannot list task instances with None state

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19487: URL: https://github.com/apache/airflow/pull/19487#discussion_r747311902 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -73,9 +74,22 @@ def get_task_instance(dag_id: str, dag_run_id: str, task_

[GitHub] [airflow] uranusjr commented on a change in pull request #19487: Fix task instance api cannot list task instances with None state

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19487: URL: https://github.com/apache/airflow/pull/19487#discussion_r747313873 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -73,9 +74,22 @@ def get_task_instance(dag_id: str, dag_run_id: str, task_

[GitHub] [airflow] uranusjr commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747317824 ## File path: airflow/example_dags/example_kubernetes_executor.py ## @@ -16,88 +16,214 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] uranusjr commented on a change in pull request #19353: Introduce DagRun action to change state to queued.

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19353: URL: https://github.com/apache/airflow/pull/19353#discussion_r747320869 ## File path: airflow/www/views.py ## @@ -3977,26 +3978,36 @@ class DagRunModelView(AirflowPrivilegeVerifierModelView): @action('muldelete', "D

[GitHub] [airflow] uranusjr closed issue #16740: Custom headers not passible to send_email

2021-11-11 Thread GitBox
uranusjr closed issue #16740: URL: https://github.com/apache/airflow/issues/16740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19009: Pass custom_headers to send_email and send_email_smtp

2021-11-11 Thread GitBox
boring-cyborg[bot] commented on pull request #19009: URL: https://github.com/apache/airflow/pull/19009#issuecomment-966114698 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] uranusjr merged pull request #19009: Pass custom_headers to send_email and send_email_smtp

2021-11-11 Thread GitBox
uranusjr merged pull request #19009: URL: https://github.com/apache/airflow/pull/19009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[airflow] branch main updated (deaa9a3 -> c95205e)

2021-11-11 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from deaa9a3 Fix DAG docstrings (#19531) add c95205e Pass custom_headers to send_email and send_email_smtp (#19009

[GitHub] [airflow] uranusjr commented on pull request #19482: [19458] Added column duration to DAG runs view

2021-11-11 Thread GitBox
uranusjr commented on pull request #19482: URL: https://github.com/apache/airflow/pull/19482#issuecomment-966120485 LGTM, I just wonder if it’s worthwhile to display the time this precisely. A couple of decimal points is more than enough IMO. (Same applies to the task instance table.) --

[GitHub] [airflow] uranusjr commented on issue #19489: PostgresSqlHook needs to override DbApiHook.get_uri to pull in extra for client_encoding=utf-8 during create_engine

2021-11-11 Thread GitBox
uranusjr commented on issue #19489: URL: https://github.com/apache/airflow/issues/19489#issuecomment-966125059 Honestly just copying the code does not feel that big an issue to me. They are not really _logically_ duplicates but more like “we need to do it for two different things and it ju

[GitHub] [airflow] uranusjr edited a comment on issue #19489: PostgresSqlHook needs to override DbApiHook.get_uri to pull in extra for client_encoding=utf-8 during create_engine

2021-11-11 Thread GitBox
uranusjr edited a comment on issue #19489: URL: https://github.com/apache/airflow/issues/19489#issuecomment-966125059 Honestly just copying the code does not feel that big an issue to me. They are not really _logically_ duplicates but more like “we need to do it for two different things an

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
ephraimbuddy commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747330179 ## File path: airflow/example_dags/example_kubernetes_executor.py ## @@ -16,88 +16,214 @@ # specific language governing permissions and limitation

[GitHub] [airflow] uranusjr commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747331069 ## File path: airflow/example_dags/example_kubernetes_executor.py ## @@ -16,88 +16,214 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] uranusjr commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747331069 ## File path: airflow/example_dags/example_kubernetes_executor.py ## @@ -16,88 +16,214 @@ # specific language governing permissions and limitations #

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
ephraimbuddy commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747331358 ## File path: airflow/example_dags/example_kubernetes_executor.py ## @@ -16,88 +16,214 @@ # specific language governing permissions and limitation

[GitHub] [airflow] KennethanCeyer commented on a change in pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-11 Thread GitBox
KennethanCeyer commented on a change in pull request #19378: URL: https://github.com/apache/airflow/pull/19378#discussion_r747331574 ## File path: airflow/operators/python.py ## @@ -171,7 +178,8 @@ def execute(self, context: Dict): self.op_kwargs = determine_kwargs(sel

[GitHub] [airflow] uranusjr commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747332136 ## File path: docs/apache-airflow/example_dags/example_pod_template_file.py ## @@ -0,0 +1,54 @@ +# Licensed to the Apache Software Foundation (ASF) und

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
ephraimbuddy commented on a change in pull request #19355: URL: https://github.com/apache/airflow/pull/19355#discussion_r747333742 ## File path: airflow/example_dags/example_kubernetes_executor.py ## @@ -16,88 +16,214 @@ # specific language governing permissions and limitation

[GitHub] [airflow] uranusjr commented on a change in pull request #19294: Simplify fab has access lookup

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19294: URL: https://github.com/apache/airflow/pull/19294#discussion_r747335977 ## File path: airflow/www/auth.py ## @@ -35,7 +35,7 @@ def decorated(*args, **kwargs): __tracebackhide__ = True # Hide from pytest traceb

[GitHub] [airflow] uranusjr merged pull request #19155: Resurrect python openapi client generator

2021-11-11 Thread GitBox
uranusjr merged pull request #19155: URL: https://github.com/apache/airflow/pull/19155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19155: Resurrect python openapi client generator

2021-11-11 Thread GitBox
boring-cyborg[bot] commented on pull request #19155: URL: https://github.com/apache/airflow/pull/19155#issuecomment-966145848 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[airflow] branch main updated (c95205e -> 8d63bdf)

2021-11-11 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from c95205e Pass custom_headers to send_email and send_email_smtp (#19009) add 8d63bdf Resurrect python openapi c

[GitHub] [airflow] github-actions[bot] commented on pull request #19322: Copy AppBuilder Base class verbatim from FAB to Airflow (with attribution)

2021-11-11 Thread GitBox
github-actions[bot] commented on pull request #19322: URL: https://github.com/apache/airflow/pull/19322#issuecomment-966147639 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] kaxil closed issue #19461: Missing DagRuns when catchup=True

2021-11-11 Thread GitBox
kaxil closed issue #19461: URL: https://github.com/apache/airflow/issues/19461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

[GitHub] [airflow] github-actions[bot] commented on pull request #19449: fix bug of SparkSql Operator log going to infinite loop.

2021-11-11 Thread GitBox
github-actions[bot] commented on pull request #19449: URL: https://github.com/apache/airflow/pull/19449#issuecomment-966155860 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] kaxil merged pull request #19528: Fix missing dagruns when catchup=True

2021-11-11 Thread GitBox
kaxil merged pull request #19528: URL: https://github.com/apache/airflow/pull/19528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[airflow] branch main updated (8d63bdf -> 2bd4b55)

2021-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 8d63bdf Resurrect python openapi client generator (#19155) add 2bd4b55 Fix missing dagruns when ``catchup=Tr

[GitHub] [airflow] uranusjr commented on a change in pull request #19377: Providers facebook hook multiple account

2021-11-11 Thread GitBox
uranusjr commented on a change in pull request #19377: URL: https://github.com/apache/airflow/pull/19377#discussion_r74735 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -118,11 +122,32 @@ def bulk_facebook_report( :param sleep_time: Time to sleep

[GitHub] [airflow] ashb commented on a change in pull request #19367: Do not send DAGs with null DagModel.max_active_runs to the scheduler

2021-11-11 Thread GitBox
ashb commented on a change in pull request #19367: URL: https://github.com/apache/airflow/pull/19367#discussion_r747353957 ## File path: airflow/models/dag.py ## @@ -2880,11 +2884,14 @@ def dags_needing_dagruns(cls, session: Session): # TODO[HA]: Bake this query, it is

[GitHub] [airflow] ashb commented on a change in pull request #19367: Do not send DAGs with null DagModel.max_active_runs to the scheduler

2021-11-11 Thread GitBox
ashb commented on a change in pull request #19367: URL: https://github.com/apache/airflow/pull/19367#discussion_r747354277 ## File path: docs/apache-airflow/migrations-ref.rst ## @@ -23,7 +23,9 @@ Here's the list of all the Database Migrations that are executed via when you ru

[GitHub] [airflow] ashb merged pull request #19408: Define datetime and StringID column types centrally in migrations

2021-11-11 Thread GitBox
ashb merged pull request #19408: URL: https://github.com/apache/airflow/pull/19408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[airflow] branch main updated (2bd4b55 -> 7622f5e)

2021-11-11 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2bd4b55 Fix missing dagruns when ``catchup=True`` (#19528) add 7622f5e Define datetime and StringID column types c

[GitHub] [airflow] OyinOlamide commented on pull request #19406: Shell edits

2021-11-11 Thread GitBox
OyinOlamide commented on pull request #19406: URL: https://github.com/apache/airflow/pull/19406#issuecomment-966187505 Thank you @ephraimbuddy I'll do that today and get back to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19367: Do not send DAGs with null DagModel.max_active_runs to the scheduler

2021-11-11 Thread GitBox
ephraimbuddy commented on a change in pull request #19367: URL: https://github.com/apache/airflow/pull/19367#discussion_r747386557 ## File path: airflow/models/dag.py ## @@ -2880,11 +2884,14 @@ def dags_needing_dagruns(cls, session: Session): # TODO[HA]: Bake this quer

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19367: Do not send DAGs with null DagModel.max_active_runs to the scheduler

2021-11-11 Thread GitBox
ephraimbuddy commented on a change in pull request #19367: URL: https://github.com/apache/airflow/pull/19367#discussion_r747392653 ## File path: tests/models/test_dag.py ## @@ -1848,9 +1888,6 @@ def test_dags_needing_dagruns_not_too_early(self): dag_models = DagModel.d

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19535: Airflow tasks hang in 'Running' state

2021-11-11 Thread GitBox
boring-cyborg[bot] commented on issue #19535: URL: https://github.com/apache/airflow/issues/19535#issuecomment-966218430 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] racingjellyfish opened a new issue #19535: Airflow tasks hang in 'Running' state

2021-11-11 Thread GitBox
racingjellyfish opened a new issue #19535: URL: https://github.com/apache/airflow/issues/19535 ### Apache Airflow version 2.2.1 (latest released) ### Operating System Amazon Linux 2 ### Versions of Apache Airflow Providers apache_airflow-2.2.1.dist-info

[GitHub] [airflow] ephraimbuddy commented on pull request #19367: Do not create dagruns for DAGs with import errors

2021-11-11 Thread GitBox
ephraimbuddy commented on pull request #19367: URL: https://github.com/apache/airflow/pull/19367#issuecomment-966246554 > Happy to discuss about if we still need the max_active_runs condition or not too. I agree we no longer need it. I restricted the creation of dagruns on the

[GitHub] [airflow] bolkedebruin commented on issue #17984: Add possibility to LineageBackend to be notified of task instance execution start and failure

2021-11-11 Thread GitBox
bolkedebruin commented on issue #17984: URL: https://github.com/apache/airflow/issues/17984#issuecomment-966276136 I see `on_state_change` as part of the operator so `BashOperator.on_state_change` that inherits everthing the tasks knows about itself including the standard context (ontext c

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #19487: Fix task instance api cannot list task instances with None state

2021-11-11 Thread GitBox
ephraimbuddy commented on a change in pull request #19487: URL: https://github.com/apache/airflow/pull/19487#discussion_r747480397 ## File path: airflow/api_connexion/endpoints/task_instance_endpoint.py ## @@ -73,9 +74,22 @@ def get_task_instance(dag_id: str, dag_run_id: str, t

[GitHub] [airflow] PApostol removed a comment on issue #17507: Task processes killed with WARNING - Recorded pid does not match the current pid

2021-11-11 Thread GitBox
PApostol removed a comment on issue #17507: URL: https://github.com/apache/airflow/issues/17507#issuecomment-960612281 I'm seeing the same issue on Airflow 2.1.4 with 2 schedulers and Python 3.7.10, even after patching with #18975. See scheduler logs below - note the ~8 minute gap between

[GitHub] [airflow] ashb commented on issue #17984: Add possibility to LineageBackend to be notified of task instance execution start and failure

2021-11-11 Thread GitBox
ashb commented on issue #17984: URL: https://github.com/apache/airflow/issues/17984#issuecomment-966336050 This might be a good time to bring in a formal plugin system via https://pypi.org/project/pluggy/ -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] omoussa1 commented on issue #15601: Access is denied alert after successful login using OIDC

2021-11-11 Thread GitBox
omoussa1 commented on issue #15601: URL: https://github.com/apache/airflow/issues/15601#issuecomment-966347465 Hey, has a solution been reached for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] josh-fell commented on a change in pull request #19356: Add influxdb operator

2021-11-11 Thread GitBox
josh-fell commented on a change in pull request #19356: URL: https://github.com/apache/airflow/pull/19356#discussion_r747559493 ## File path: airflow/providers/influxdb/operators/influxdb.py ## @@ -0,0 +1,60 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] khalidmammadov commented on a change in pull request #18961: Convert www.security test suite to pytest and remove residuals

2021-11-11 Thread GitBox
khalidmammadov commented on a change in pull request #18961: URL: https://github.com/apache/airflow/pull/18961#discussion_r747564817 ## File path: tests/test_utils/api_connexion_utils.py ## @@ -80,15 +81,29 @@ def create_role(app, name, permissions=None): return role +

svn commit: r50880 - in /dev/airflow: 2.2.1rc1/ 2.2.1rc2/

2021-11-11 Thread ash
Author: ash Date: Thu Nov 11 14:57:15 2021 New Revision: 50880 Log: Remove old RCs Removed: dev/airflow/2.2.1rc1/ dev/airflow/2.2.1rc2/

svn commit: r50881 - in /release/airflow: clients/python/2.0.0/ helm-chart/1.1.0/ helm-chart/1.2.0/

2021-11-11 Thread ash
Author: ash Date: Thu Nov 11 15:00:22 2021 New Revision: 50881 Log: Remove old relese dists Removed: release/airflow/clients/python/2.0.0/ release/airflow/helm-chart/1.1.0/ release/airflow/helm-chart/1.2.0/

svn commit: r50882 - /release/airflow/backport-providers/

2021-11-11 Thread ash
Author: ash Date: Thu Nov 11 15:00:43 2021 New Revision: 50882 Log: Remove backport-providers now that we don't actively release them anymore Removed: release/airflow/backport-providers/

[GitHub] [airflow] ashb commented on pull request #19367: Do not create dagruns for DAGs with import errors

2021-11-11 Thread GitBox
ashb commented on pull request #19367: URL: https://github.com/apache/airflow/pull/19367#issuecomment-966375995 > > Happy to discuss about if we still need the max_active_runs condition or not too. > > I agree we no longer need it. > > I restricted the creation of dagruns on t

[GitHub] [airflow] ashb commented on pull request #19410: Remove inaccurate execution date from triggered dag extra link

2021-11-11 Thread GitBox
ashb commented on pull request #19410: URL: https://github.com/apache/airflow/pull/19410#issuecomment-966380955 From that issue: > So the webserver does not have access to the results of those computations when it's building the link Store the triggered execution date in XCom

[GitHub] [airflow] ephraimbuddy commented on pull request #19355: Ensure the example DAGs are all working

2021-11-11 Thread GitBox
ephraimbuddy commented on pull request #19355: URL: https://github.com/apache/airflow/pull/19355#issuecomment-966391100 Hi @kaxil, please take a look at this doc error, I haven't been able to figure it out -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] ephraimbuddy commented on pull request #19367: Do not create dagruns for DAGs with import errors

2021-11-11 Thread GitBox
ephraimbuddy commented on pull request #19367: URL: https://github.com/apache/airflow/pull/19367#issuecomment-966412214 > > > Happy to discuss about if we still need the max_active_runs condition or not too. > > > > > > I agree we no longer need it. > > I restricted the creati

[GitHub] [airflow] bugraoz93 commented on a change in pull request #19377: Providers facebook hook multiple account

2021-11-11 Thread GitBox
bugraoz93 commented on a change in pull request #19377: URL: https://github.com/apache/airflow/pull/19377#discussion_r747624569 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -118,11 +122,32 @@ def bulk_facebook_report( :param sleep_time: Time to sleep

[GitHub] [airflow] bugraoz93 commented on a change in pull request #19377: Providers facebook hook multiple account

2021-11-11 Thread GitBox
bugraoz93 commented on a change in pull request #19377: URL: https://github.com/apache/airflow/pull/19377#discussion_r747624569 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -118,11 +122,32 @@ def bulk_facebook_report( :param sleep_time: Time to sleep

[GitHub] [airflow] bugraoz93 commented on a change in pull request #19377: Providers facebook hook multiple account

2021-11-11 Thread GitBox
bugraoz93 commented on a change in pull request #19377: URL: https://github.com/apache/airflow/pull/19377#discussion_r747630615 ## File path: airflow/providers/facebook/ads/hooks/ads.py ## @@ -98,14 +99,17 @@ def facebook_ads_config(self) -> Dict: if missing_keys:

[GitHub] [airflow] josh-fell commented on a change in pull request #19527: Clean-up of google cloud example dags - batch 2

2021-11-11 Thread GitBox
josh-fell commented on a change in pull request #19527: URL: https://github.com/apache/airflow/pull/19527#discussion_r747632094 ## File path: airflow/providers/google/cloud/example_dags/example_facebook_ads_to_gcs.py ## @@ -87,7 +89,6 @@ # [START howto_operator_facebook_a

[GitHub] [airflow] josh-fell commented on pull request #19527: Clean-up of google cloud example dags - batch 2

2021-11-11 Thread GitBox
josh-fell commented on pull request #19527: URL: https://github.com/apache/airflow/pull/19527#issuecomment-966429340 👏 Great work again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] kwkwc opened a new pull request #19536: Fix dynamic queue loss

2021-11-11 Thread GitBox
kwkwc opened a new pull request #19536: URL: https://github.com/apache/airflow/pull/19536 I use ``task_instance_mutation_hook`` in Airflow ``2.2.1`` to dynamically assign ``queue``: ```python def task_instance_mutation_hook(task_instance: TaskInstance): from airflow.set

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19536: Fix dynamic queue loss

2021-11-11 Thread GitBox
boring-cyborg[bot] commented on pull request #19536: URL: https://github.com/apache/airflow/pull/19536#issuecomment-966434546 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Con

[GitHub] [airflow] josh-fell opened a new issue #19538: TaskFlow API `multiple_outputs` inference not handling all flavors of dict typing

2021-11-11 Thread GitBox
josh-fell opened a new issue #19538: URL: https://github.com/apache/airflow/issues/19538 ### Apache Airflow version 2.2.0 ### Operating System Debian GNU/Linux 11 (bullseye) ### Versions of Apache Airflow Providers ```shell apache-airflow-providers-amazo

[GitHub] [airflow] kd2718 commented on a change in pull request #19036: replaced '.' with '-' and adjusted trimmed_pod_id per ticket comments

2021-11-11 Thread GitBox
kd2718 commented on a change in pull request #19036: URL: https://github.com/apache/airflow/pull/19036#discussion_r747674223 ## File path: tests/kubernetes/test_pod_generator.py ## @@ -684,7 +684,7 @@ def test_pod_name_is_valid(self, pod_id, expected_starts_with):

[GitHub] [airflow] alexbegg commented on a change in pull request #19530: Do not require all extras for SalesforceHook

2021-11-11 Thread GitBox
alexbegg commented on a change in pull request #19530: URL: https://github.com/apache/airflow/pull/19530#discussion_r747691336 ## File path: airflow/providers/salesforce/hooks/salesforce.py ## @@ -27,6 +27,11 @@ import time from typing import Any, Dict, Iterable, List, Option

[GitHub] [airflow] alexbegg commented on a change in pull request #19530: Do not require all extras for SalesforceHook

2021-11-11 Thread GitBox
alexbegg commented on a change in pull request #19530: URL: https://github.com/apache/airflow/pull/19530#discussion_r747691336 ## File path: airflow/providers/salesforce/hooks/salesforce.py ## @@ -27,6 +27,11 @@ import time from typing import Any, Dict, Iterable, List, Option

[GitHub] [airflow] fredthomsen commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-11 Thread GitBox
fredthomsen commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-966492874 I have rebased. I am sure someone somewhere out there wants that use case; however, the deprecation is going to be ugly no matter how or when you do it since this a

[GitHub] [airflow] mobuchowski commented on issue #17984: Add possibility to LineageBackend to be notified of task instance execution start and failure

2021-11-11 Thread GitBox
mobuchowski commented on issue #17984: URL: https://github.com/apache/airflow/issues/17984#issuecomment-966505971 I think that having something global rather than per operator makes more sense in our case. Conceptually, it's easier to inject - Airflow user specifies in config that they

[GitHub] [airflow] mobuchowski edited a comment on issue #17984: Add possibility to LineageBackend to be notified of task instance execution start and failure

2021-11-11 Thread GitBox
mobuchowski edited a comment on issue #17984: URL: https://github.com/apache/airflow/issues/17984#issuecomment-966505971 I think that having something "global" rather than per operator makes more sense in our case. Conceptually, it's easier to inject - Airflow user specifies in config th

[GitHub] [airflow] Aakcht opened a new pull request #19540: hdfs provider docs: add hdfs PIP requirement

2021-11-11 Thread GitBox
Aakcht opened a new pull request #19540: URL: https://github.com/apache/airflow/pull/19540 Webhdfs hook requires hdfs package, see https://github.com/apache/airflow/blob/main/airflow/providers/apache/hdfs/hooks/webhdfs.py#L24 --- **^ Add meaningful description above**

[GitHub] [airflow] tanvn commented on issue #18080: Wrong try_number after rescheduling makes remote logging store all the logs with wrong log_id

2021-11-11 Thread GitBox
tanvn commented on issue #18080: URL: https://github.com/apache/airflow/issues/18080#issuecomment-966508600 I got the same issue today with version 2.2.1 (the latest) because the `try_number` is not changed when the task is marked as `UP_FOR_SCHEDULE`, my ExternalTaskSensor with a `re

[GitHub] [airflow] dstandish commented on a change in pull request #19539: Minor touch up for async docs

2021-11-11 Thread GitBox
dstandish commented on a change in pull request #19539: URL: https://github.com/apache/airflow/pull/19539#discussion_r747711588 ## File path: docs/apache-airflow/concepts/deferring.rst ## @@ -55,7 +55,7 @@ Writing Deferrable Operators Writing a deferrable operator takes a bi

[GitHub] [airflow] dstandish commented on a change in pull request #19539: Minor touch up for async docs

2021-11-11 Thread GitBox
dstandish commented on a change in pull request #19539: URL: https://github.com/apache/airflow/pull/19539#discussion_r747711588 ## File path: docs/apache-airflow/concepts/deferring.rst ## @@ -55,7 +55,7 @@ Writing Deferrable Operators Writing a deferrable operator takes a bi

[GitHub] [airflow] dstandish commented on a change in pull request #19539: Minor touch up for async docs

2021-11-11 Thread GitBox
dstandish commented on a change in pull request #19539: URL: https://github.com/apache/airflow/pull/19539#discussion_r747713125 ## File path: docs/apache-airflow/concepts/deferring.rst ## @@ -67,13 +67,13 @@ Triggering Deferral If you want to trigger deferral, at any place in

[GitHub] [airflow] dstandish commented on a change in pull request #19539: Minor touch up for async docs

2021-11-11 Thread GitBox
dstandish commented on a change in pull request #19539: URL: https://github.com/apache/airflow/pull/19539#discussion_r747714386 ## File path: docs/apache-airflow/concepts/deferring.rst ## @@ -67,13 +67,13 @@ Triggering Deferral If you want to trigger deferral, at any place in

[GitHub] [airflow] dstandish commented on a change in pull request #19539: Minor touch up for async docs

2021-11-11 Thread GitBox
dstandish commented on a change in pull request #19539: URL: https://github.com/apache/airflow/pull/19539#discussion_r747715483 ## File path: docs/apache-airflow/concepts/deferring.rst ## @@ -140,8 +145,6 @@ Triggers can be as complex or as simple as you like provided you keep

[GitHub] [airflow] christophergrant edited a comment on pull request #19412: Update Databricks API from 2.0 to 2.1

2021-11-11 Thread GitBox
christophergrant edited a comment on pull request #19412: URL: https://github.com/apache/airflow/pull/19412#issuecomment-966533359 Any APIs that are not under the `api/2.x/jobs` prefix do not have version 2.1 at this time i.e the clusters APIs and libraries APIs will need to be reverted to

[GitHub] [airflow] christophergrant commented on pull request #19412: Update Databricks API from 2.0 to 2.1

2021-11-11 Thread GitBox
christophergrant commented on pull request #19412: URL: https://github.com/apache/airflow/pull/19412#issuecomment-966533359 Nit: any APIs that are not under the `api/2.x/jobs` prefix do not have version 2.1 at this time i.e the clusters APIs and libraries APIs will need to be reverted to 2

[GitHub] [airflow] dstandish commented on pull request #18542: Allow ingress multiple hostnames w/diff secrets

2021-11-11 Thread GitBox
dstandish commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-966544379 > I have rebased. I am sure someone somewhere out there wants that use case; however, the deprecation is going to be ugly no matter how or when you do it since this attribut

[GitHub] [airflow] a-pertsev commented on issue #19477: 'NoneType' object has no attribute 'refresh_from_task' Error when manually running task instance

2021-11-11 Thread GitBox
a-pertsev commented on issue #19477: URL: https://github.com/apache/airflow/issues/19477#issuecomment-966550152 @potiuk as i can see, attempt of running newly created task will cause redirect with error message. In previous versions airflow was creating and running new task instance - i

[GitHub] [airflow] a-pertsev edited a comment on issue #19477: 'NoneType' object has no attribute 'refresh_from_task' Error when manually running task instance

2021-11-11 Thread GitBox
a-pertsev edited a comment on issue #19477: URL: https://github.com/apache/airflow/issues/19477#issuecomment-966550152 @potiuk as i can see in https://github.com/apache/airflow/pull/19478, attempt of running newly created task will cause redirect with error message. In previous versions

[GitHub] [airflow] dstandish commented on a change in pull request #19530: Do not require all extras for SalesforceHook

2021-11-11 Thread GitBox
dstandish commented on a change in pull request #19530: URL: https://github.com/apache/airflow/pull/19530#discussion_r747749942 ## File path: airflow/providers/salesforce/hooks/salesforce.py ## @@ -27,6 +27,11 @@ import time from typing import Any, Dict, Iterable, List, Optio

[GitHub] [airflow] github-actions[bot] commented on pull request #19530: Do not require all extras for SalesforceHook

2021-11-11 Thread GitBox
github-actions[bot] commented on pull request #19530: URL: https://github.com/apache/airflow/pull/19530#issuecomment-966554279 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] denimalpaca commented on pull request #18718: Add hook_params in BaseSqlOperator

2021-11-11 Thread GitBox
denimalpaca commented on pull request #18718: URL: https://github.com/apache/airflow/pull/18718#issuecomment-966557604 pinging @potiuk and @jedcunningham again for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] dstandish opened a new pull request #19541: Remove remaining `pylint: disable` comments

2021-11-11 Thread GitBox
dstandish opened a new pull request #19541: URL: https://github.com/apache/airflow/pull/19541 There's a few straggling pylint comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] github-actions[bot] commented on pull request #19541: Remove remaining `pylint: disable` comments

2021-11-11 Thread GitBox
github-actions[bot] commented on pull request #19541: URL: https://github.com/apache/airflow/pull/19541#issuecomment-966560305 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[airflow] branch v2-2-test updated (eaead7d -> 9ac7428)

2021-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git. from eaead7d Fix 2.2.2 release date in changelog (#19498) new 2aed7c1 Fix missing dagruns when ``catchup=Tru

[airflow] 02/03: Improve message and documentation around moved data (#19453)

2021-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit d8bb3cbde4ca7b3f56e578a10a9c7476464c25b4 Author: Jarek Potiuk AuthorDate: Wed Nov 10 22:08:15 2021 +0100 Imp

[airflow] 01/03: Fix missing dagruns when ``catchup=True`` (#19528)

2021-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 2aed7c1e994f0efed75f7c52d00d0c3a0946246d Author: Ephraim Anierobi AuthorDate: Thu Nov 11 10:44:11 2021 +0100

[airflow] 03/03: Add Changelog for 2.2.2rc2

2021-11-11 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 9ac742885ffb83c15f7e3dc910b0cf9df073407a Author: Kaxil Naik AuthorDate: Thu Nov 11 19:24:51 2021 + Add C

[GitHub] [airflow] kaxil opened a new pull request #19542: Sync ``v2-2-stable`` with ``v2-2-test`` to release 2.2.2

2021-11-11 Thread GitBox
kaxil opened a new pull request #19542: URL: https://github.com/apache/airflow/pull/19542 Just need approval, so that I can push to v2-2-stable which is a protected branch --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https

[GitHub] [airflow] bbovenzi commented on a change in pull request #18675: New Tree View

2021-11-11 Thread GitBox
bbovenzi commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r747762208 ## File path: airflow/www/package.json ## @@ -56,19 +60,29 @@ "webpack-manifest-plugin": "^2.2.0" }, "dependencies": { +"@chakra-ui/reac

[GitHub] [airflow] ZackingIt commented on issue #10605: Use private docker repository with K8S operator and XCOM sidecar container

2021-11-11 Thread GitBox
ZackingIt commented on issue #10605: URL: https://github.com/apache/airflow/issues/10605#issuecomment-966571742 @dzungdev I created an actual file, I did *not* overwrite a variable in the `values.yaml` i.e., part of my Docker build involves: `cp /airflow-config/config/airflow_local_

  1   2   >