[GitHub] [airflow] potiuk commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
potiuk commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748385017 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnresolvedVar

[GitHub] [airflow] potiuk commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
potiuk commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748385017 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnresolvedVar

[GitHub] [airflow] potiuk commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
potiuk commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748385017 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnresolvedVar

[GitHub] [airflow] potiuk commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
potiuk commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748384988 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnresolvedVar

[GitHub] [airflow] robinhur commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
robinhur commented on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967205196 @potiuk Great Information!! @ChrisWeinrich wait for it!! will let you have this feature soon :) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] potiuk edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
potiuk edited a comment on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967203906 Start here: https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst , detailed contributor's guide is at https://github.com/apache/airflow/blob/main/CONTRIB

[GitHub] [airflow] potiuk commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
potiuk commented on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967203906 Start here: https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst , detailed contributor's guide is at https://github.com/apache/airflow/blob/main/CONTRIBUTING.r

[GitHub] [airflow] bbovenzi commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
bbovenzi commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748373404 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnresolvedV

[GitHub] [airflow] robinhur commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
robinhur commented on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967201666 @potiuk yes please will take a look and create PR for this when i have a chance Thanks -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [airflow] potiuk edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
potiuk edited a comment on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967200633 @robinhur @ChrisWeinrich - the easiest and most certain way to get this implement is to submit a PR with a fix. Airflow is developed by > 1800 contributors, and there is no

[GitHub] [airflow] potiuk edited a comment on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
potiuk edited a comment on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967200633 @robinhur @ChrisWeinrich - the easiest and most certain way to get this implement is to submit a PR with a fix. Airflow is developed by > 1800 contributors, and there is no

[GitHub] [airflow] potiuk commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
potiuk commented on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967200633 @robinhur @ChrisWeinrich - the easiest and most certain way to get this implement is to submit a PR with a fix. Airflow is developed by > 1800 contributors, and there is no magical

[GitHub] [airflow] bbovenzi commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
bbovenzi commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748373404 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnresolvedV

[GitHub] [airflow] sweco commented on issue #19329: Kubernetes Executor: non-existent upstream failed

2021-11-12 Thread GitBox
sweco commented on issue #19329: URL: https://github.com/apache/airflow/issues/19329#issuecomment-967199405 # Steps to reproduce 1. Prepare a relatively small cluster, e.g. 1 node with 8 GB of RAM. 2. Deploy Airflow using Kubernetes executor there. 3. Prepare a DAG according to

[GitHub] [airflow] potiuk opened a new issue #19558: Status of testing of Apache Airflow 2.2.2rc2

2021-11-12 Thread GitBox
potiuk opened a new issue #19558: URL: https://github.com/apache/airflow/issues/19558 ### Body We have a kind request for all the contributors to the latest [Apache Airflow RC 2.2.2rc2](https://pypi.org/project/apache-airflow/2.2.2rc2/). Could you please help us to test the RC

[GitHub] [airflow] ryanahamilton commented on a change in pull request #18675: New Tree View

2021-11-12 Thread GitBox
ryanahamilton commented on a change in pull request #18675: URL: https://github.com/apache/airflow/pull/18675#discussion_r748362627 ## File path: airflow/www/webpack.config.js ## @@ -35,6 +36,22 @@ const JS_DIR = path.resolve(__dirname, './static/js'); // noinspection JSUnreso

[GitHub] [airflow] robinhur commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
robinhur commented on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967187984 @ChrisWeinrich it's been almost an yr for me to raise this issue and i've resolved it by creating my own operator that overrides existing codes and added to skip the echo pa

[GitHub] [airflow] bbovenzi commented on issue #19556: Checking roles and users list in Web UI, give me an error

2021-11-12 Thread GitBox
bbovenzi commented on issue #19556: URL: https://github.com/apache/airflow/issues/19556#issuecomment-967160871 Can you please include the error message or screenshots? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] ESUBLXX commented on issue #19552: Tasks not getting Completed with KubernetesPodOperator

2021-11-12 Thread GitBox
ESUBLXX commented on issue #19552: URL: https://github.com/apache/airflow/issues/19552#issuecomment-967153439 > KubernetesPodOperator stay in `RUNNING` state until pod finish execution Even the Spark Driver moves to Completed, the airflow task is in RUNNING state. How to Move the air

[GitHub] [airflow] ChrisWeinrich commented on issue #11618: Support to turn off the sql echo at logging in dbapi_hook

2021-11-12 Thread GitBox
ChrisWeinrich commented on issue #11618: URL: https://github.com/apache/airflow/issues/11618#issuecomment-967132070 Is therey any work going on here or someone knows a workarround ? We have ~10k * 500 Insert Lines and this spams the logging very badly :( -- This is an automated message f

[GitHub] [airflow] raphaelauv opened a new pull request #19557: add kubernetes 1.21 support

2021-11-12 Thread GitBox
raphaelauv opened a new pull request #19557: URL: https://github.com/apache/airflow/pull/19557 #19555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19556: Checking roles and users list in Web UI, give me an error

2021-11-12 Thread GitBox
boring-cyborg[bot] commented on issue #19556: URL: https://github.com/apache/airflow/issues/19556#issuecomment-967101662 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] nediGit opened a new issue #19556: Checking roles and users list in Web UI, give me an error

2021-11-12 Thread GitBox
nediGit opened a new issue #19556: URL: https://github.com/apache/airflow/issues/19556 ### Apache Airflow version 2.1.2 ### Operating System Centos 7 ### Versions of Apache Airflow Providers apache-airflow-providers-ftp==2.0.0 apache-airflow-providers-ht

[airflow] branch main updated (a24066b -> 4f1e66d)

2021-11-12 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from a24066b Do not require all extras for SalesforceHook (#19530) add 4f1e66d Upload KinD logs on cancell too (#19554)

[GitHub] [airflow] ashb merged pull request #19554: Upload KinD logs on cancell too

2021-11-12 Thread GitBox
ashb merged pull request #19554: URL: https://github.com/apache/airflow/pull/19554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] KennethanCeyer commented on pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-12 Thread GitBox
KennethanCeyer commented on pull request #19378: URL: https://github.com/apache/airflow/pull/19378#issuecomment-967086764 @uranusjr I see. For that work, I will proceed by making another PR in the future. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [airflow] github-actions[bot] commented on pull request #19553: Fix IntegrityError in `DagFileProcessor.manage_slas`

2021-11-12 Thread GitBox
github-actions[bot] commented on pull request #19553: URL: https://github.com/apache/airflow/pull/19553#issuecomment-967081656 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] uranusjr commented on issue #17010: Add support for custom Trigger Rule logic

2021-11-12 Thread GitBox
uranusjr commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-967079804 I like the boolean combination idea. This will likely be a big undertaking though with a lot of tests needed since there’s much existing code that uses `==` and `in` that’d silent

[GitHub] [airflow] raphaelauv commented on issue #19552: Tasks not getting Completed with KubernetesPodOperator

2021-11-12 Thread GitBox
raphaelauv commented on issue #19552: URL: https://github.com/apache/airflow/issues/19552#issuecomment-967074977 KubernetesPodOperator stay in `RUNNING` state until pod finish execution -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [airflow] uranusjr commented on a change in pull request #19553: Fix IntegrityError in `DagFileProcessor.manage_slas`

2021-11-12 Thread GitBox
uranusjr commented on a change in pull request #19553: URL: https://github.com/apache/airflow/pull/19553#discussion_r748241982 ## File path: airflow/dag_processing/processor.py ## @@ -389,6 +389,12 @@ def manage_slas(self, dag: DAG, session: Session = None) -> None:

[GitHub] [airflow] raphaelauv opened a new issue #19555: Kubernetes 1.21 official support

2021-11-12 Thread GitBox
raphaelauv opened a new issue #19555: URL: https://github.com/apache/airflow/issues/19555 ### Description I've been using airflow 2.1.X with kubernetes 1.21.X for more than 2 month, I didn't encounter any problem what would be necessary to considerate this kubernetes version h

[GitHub] [airflow] github-actions[bot] commented on pull request #19554: Upload KinD logs on cancell too

2021-11-12 Thread GitBox
github-actions[bot] commented on pull request #19554: URL: https://github.com/apache/airflow/pull/19554#issuecomment-967071120 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] ashb opened a new pull request #19554: Upload KinD logs on cancell too

2021-11-12 Thread GitBox
ashb opened a new pull request #19554: URL: https://github.com/apache/airflow/pull/19554 If the job times out, it is "cancelled", rather than failed, which means that the logs were not uploaded. This will likely also catch a few cases where the job is cancelled cos of another pu

[GitHub] [airflow] ephraimbuddy opened a new pull request #19553: Fix IntegrityError in `DagFileProcessor.manage_slas`

2021-11-12 Thread GitBox
ephraimbuddy opened a new pull request #19553: URL: https://github.com/apache/airflow/pull/19553 The DagFileProcessor.manage_slas does not consider if an SlaMiss already exists in DB while inserting slas. If an SLA for a task is missed and recorded, on checking SLA again, this tas

[GitHub] [airflow] uranusjr edited a comment on pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-12 Thread GitBox
uranusjr edited a comment on pull request #19378: URL: https://github.com/apache/airflow/pull/19378#issuecomment-967047503 Yes we should do something for this but separately. Maybe something like (just a random idea) ```python @task(..., log_return_value="DEBUG") def my_task():

[GitHub] [airflow] uranusjr commented on pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-12 Thread GitBox
uranusjr commented on pull request #19378: URL: https://github.com/apache/airflow/pull/19378#issuecomment-967047503 Yes we should do something for this but separately. Maybe something like (just a random idea) ```python @task(..., log_return_value=False) def my_task(): .

[GitHub] [airflow] uranusjr commented on a change in pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers

2021-11-12 Thread GitBox
uranusjr commented on a change in pull request #18797: URL: https://github.com/apache/airflow/pull/18797#discussion_r748212235 ## File path: tests/kubernetes/test_client.py ## @@ -63,5 +63,9 @@ def test_disable_verify_ssl(self): _disable_verify_ssl() -confi

[GitHub] [airflow] uranusjr commented on a change in pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers

2021-11-12 Thread GitBox
uranusjr commented on a change in pull request #18797: URL: https://github.com/apache/airflow/pull/18797#discussion_r748212235 ## File path: tests/kubernetes/test_client.py ## @@ -63,5 +63,9 @@ def test_disable_verify_ssl(self): _disable_verify_ssl() -confi

[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers

2021-11-12 Thread GitBox
ashb commented on pull request #18797: URL: https://github.com/apache/airflow/pull/18797#issuecomment-967041122 Oh wait, the helm tests were cancelled. Those one's probably are important to run. 👀 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] ashb commented on pull request #18797: Update Kubernetes library version and backport pickle-fix for Loggers

2021-11-12 Thread GitBox
ashb commented on pull request #18797: URL: https://github.com/apache/airflow/pull/18797#issuecomment-967040879 Green enough. Merging to mainline for 2.3 -- we shouldn't pull this in to 2.2 series. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] Aakcht commented on pull request #19540: hdfs provider docs: add hdfs PIP requirement

2021-11-12 Thread GitBox
Aakcht commented on pull request #19540: URL: https://github.com/apache/airflow/pull/19540#issuecomment-967040924 @potiuk updated. Sorry about my initial commit, I got deceived by `Suggest a change on this page` at https://airflow.apache.org/docs/apache-airflow-providers-apache-hdfs/stable

[GitHub] [airflow] potiuk commented on issue #18932: Conflicts with airflow constraints for airflow 2.2.0 python 3.7

2021-11-12 Thread GitBox
potiuk commented on issue #18932: URL: https://github.com/apache/airflow/issues/18932#issuecomment-967032388 > a) The documentation does imply, that the [all] and [all_dbs] bundle extras are indeed for production use, since the [all] bundle is described as "all user facing features. Togeth

[GitHub] [airflow] bensta edited a comment on issue #18932: Conflicts with airflow constraints for airflow 2.2.0 python 3.7

2021-11-12 Thread GitBox
bensta edited a comment on issue #18932: URL: https://github.com/apache/airflow/issues/18932#issuecomment-966992155 Yep, your explanation does make sense. And indeed, if I use the extras individually as you suggested, the install does indeed work. Thanks for the clarification! I hav

[GitHub] [airflow] bensta commented on issue #18932: Conflicts with airflow constraints for airflow 2.2.0 python 3.7

2021-11-12 Thread GitBox
bensta commented on issue #18932: URL: https://github.com/apache/airflow/issues/18932#issuecomment-966992155 Yep, your explanation does make sense. I have two thoughts from a user perspective: a) The documentation does imply, that the [all] and [all_dbs] bundle extras are indeed

[GitHub] [airflow] github-actions[bot] commented on pull request #18675: New Tree View

2021-11-12 Thread GitBox
github-actions[bot] commented on pull request #18675: URL: https://github.com/apache/airflow/pull/18675#issuecomment-966962082 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] malthe edited a comment on issue #17010: Add support for custom Trigger Rule logic

2021-11-12 Thread GitBox
malthe edited a comment on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-966888936 I think something like `TriggerRule.WAIT_ALL & TriggerRule.ONE_SUCCESS` is easier to understand than the existing `TriggerRule.NONE_FAILED_OR_SKIPPED` rule. Following

[GitHub] [airflow] ESUBLXX opened a new issue #19552: Tasks not getting Completed with KubernetesPodOperator

2021-11-12 Thread GitBox
ESUBLXX opened a new issue #19552: URL: https://github.com/apache/airflow/issues/19552 ### Apache Airflow version 2.0.2 ### Operating System Linux ### Versions of Apache Airflow Providers Linux ### Deployment Official Apache Airflow Helm Chart

[GitHub] [airflow] boring-cyborg[bot] commented on issue #19552: Tasks not getting Completed with KubernetesPodOperator

2021-11-12 Thread GitBox
boring-cyborg[bot] commented on issue #19552: URL: https://github.com/apache/airflow/issues/19552#issuecomment-966901517 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] KennethanCeyer edited a comment on pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-12 Thread GitBox
KennethanCeyer edited a comment on pull request #19378: URL: https://github.com/apache/airflow/pull/19378#issuecomment-966898703 One quick question! If the user uses `DecoratedOperator` as shown below through [TaskFlow API](https://airflow.apache.org/docs/apache-airflow/stable/tutorial_t

[GitHub] [airflow] KennethanCeyer edited a comment on pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-12 Thread GitBox
KennethanCeyer edited a comment on pull request #19378: URL: https://github.com/apache/airflow/pull/19378#issuecomment-966898703 One quick question! If the user uses `DecoratedOperator` as shown below through TaskFlow API, there seems to be no way to block XCom return value logs.

[GitHub] [airflow] KennethanCeyer edited a comment on pull request #19378: Change logLevel as debug for XCOM returned value message

2021-11-12 Thread GitBox
KennethanCeyer edited a comment on pull request #19378: URL: https://github.com/apache/airflow/pull/19378#issuecomment-966898703 One quick question! If the user uses `DecoratedOperator` as shown below through Task Flow API, there seems to be no way to block XCom return value logs.

<    1   2