[GitHub] [airflow] eskarimov opened a new pull request #20062: Use original task's `start_date` if a task continues after deferral

2021-12-06 Thread GitBox
eskarimov opened a new pull request #20062: URL: https://github.com/apache/airflow/pull/20062 The PR intends to close the issue #19382, using task's original `start_date` when it continues after deferral. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] uranusjr commented on pull request #20011: Type-annotate SkipMixin and BaseXCom

2021-12-06 Thread GitBox
uranusjr commented on pull request #20011: URL: https://github.com/apache/airflow/pull/20011#issuecomment-986552930 Wow autoapi 1.0 is so fucking ancient even my workaround does not work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] malthe commented on issue #9298: To put a task ON HOLD

2021-12-06 Thread GitBox
malthe commented on issue #9298: URL: https://github.com/apache/airflow/issues/9298#issuecomment-986562766 And perhaps add optional operator option `email_on_hold` to be able to send an e-mail when a task is put on-hold. -- This is an automated message from the Apache Git Service. To res

[GitHub] [airflow] Bowrna commented on issue #19967: Breeze: Setup Autocomplete for Breeze

2021-12-06 Thread GitBox
Bowrna commented on issue #19967: URL: https://github.com/apache/airflow/issues/19967#issuecomment-986567570 @potiuk I am planning to start this with one actual command and adding autocomplete for that one command and create help docs with that. Am i going in right direction? -- This is

[GitHub] [airflow] eladkal commented on issue #9298: To put a task ON HOLD

2021-12-06 Thread GitBox
eladkal commented on issue #9298: URL: https://github.com/apache/airflow/issues/9298#issuecomment-986569295 To my understanding a possible solution is to change the `On`/`Off` from DAG level to Task level. So a DAG would be considered ON if at least one of it’s task is ON. Even assuming

[GitHub] [airflow] boring-cyborg[bot] commented on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-06 Thread GitBox
boring-cyborg[bot] commented on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-986570583 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] davidavdav opened a new issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-06 Thread GitBox
davidavdav opened a new issue #20063: URL: https://github.com/apache/airflow/issues/20063 ### Apache Airflow version 2.1.4 ### Operating System linux ### Versions of Apache Airflow Providers apache-airflow-providers-amazon==2.2.0 apache-airflow-providers

[GitHub] [airflow] malthe commented on issue #9298: To put a task ON HOLD

2021-12-06 Thread GitBox
malthe commented on issue #9298: URL: https://github.com/apache/airflow/issues/9298#issuecomment-986574890 I think that's probably the best you can do yes. After each DAG run, use the `on_failure_callback` and `on_success_callback` methods to disable the DAG model (i.e., put it into "off"

[GitHub] [airflow] malthe edited a comment on issue #9298: To put a task ON HOLD

2021-12-06 Thread GitBox
malthe edited a comment on issue #9298: URL: https://github.com/apache/airflow/issues/9298#issuecomment-986574890 I think that's probably the best you can do yes. After each DAG run, use the `on_failure_callback` and `on_success_callback` methods to disable the DAG model (i.e., put it into

[GitHub] [airflow] malthe edited a comment on issue #9298: To put a task ON HOLD

2021-12-06 Thread GitBox
malthe edited a comment on issue #9298: URL: https://github.com/apache/airflow/issues/9298#issuecomment-986574890 I think that's probably the best you can do yes. After each DAG run, use the `on_failure_callback` and `on_success_callback` methods to disable the DAG model (i.e., put it into

[GitHub] [airflow] Aakcht opened a new pull request #20064: Chart: rename kerberos-keytab secret file

2021-12-06 Thread GitBox
Aakcht opened a new pull request #20064: URL: https://github.com/apache/airflow/pull/20064 A minor inconsistency I noticed in #19054 - all the filenames in https://github.com/apache/airflow/tree/main/chart/templates/secrets end with `-secrets` except for the keytab secret I added #19054 .

[GitHub] [airflow] stablum commented on issue #19957: AIrflow crashes with a psycopg2.errors.DeadlockDetected exception

2021-12-06 Thread GitBox
stablum commented on issue #19957: URL: https://github.com/apache/airflow/issues/19957#issuecomment-986608097 Hmm, it's difficult to retrieve this bit of information. I don't think there were multiple instances of the scheduler running, but I will keep in mind this eventuality, so thank yo

[GitHub] [airflow] stablum edited a comment on issue #19957: AIrflow crashes with a psycopg2.errors.DeadlockDetected exception

2021-12-06 Thread GitBox
stablum edited a comment on issue #19957: URL: https://github.com/apache/airflow/issues/19957#issuecomment-986608097 Hmm, it's difficult to retrieve this bit of information. I don't think there were multiple instances of the scheduler running, but I will keep in mind this eventuality, so t

[GitHub] [airflow] casra-developers commented on pull request #16110: Added windows extensions

2021-12-06 Thread GitBox
casra-developers commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-986620429 @uranusjr sorry for the late reply. I was away for three weeks and had no access to my business mail. I will pull the latest changes from the main branch and try to

[GitHub] [airflow] kazanzhy commented on pull request #20044: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-12-06 Thread GitBox
kazanzhy commented on pull request #20044: URL: https://github.com/apache/airflow/pull/20044#issuecomment-986629622 Yep, I've already read all that conversation. I want to say that this PR adds a lot of flexibility and that's cool. I just wonder how confusing might be to see in UI runn

[GitHub] [airflow] kazanzhy edited a comment on pull request #20044: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-12-06 Thread GitBox
kazanzhy edited a comment on pull request #20044: URL: https://github.com/apache/airflow/pull/20044#issuecomment-986629622 Yep, I've already read all that conversation. I want to say that this PR adds a lot of flexibility and that's cool. I just wonder how confusing might be to see in

[GitHub] [airflow] uranusjr commented on pull request #20011: Type-annotate SkipMixin and BaseXCom

2021-12-06 Thread GitBox
uranusjr commented on pull request #20011: URL: https://github.com/apache/airflow/pull/20011#issuecomment-986653528 I added a hack to allow manually telling AutoAPI to ignore any code construct if the docstring contains `:sphinx-autoapi-skip:`. This is probably the best thing we can do, sh

[GitHub] [airflow] Bowrna opened a new pull request #20066: Rewrite Breeze setup autocomplete

2021-12-06 Thread GitBox
Bowrna opened a new pull request #20066: URL: https://github.com/apache/airflow/pull/20066 closes: https://github.com/apache/airflow/issues/19967#issuecomment-986567570 Breeze rewrite in Python - Sample autocomplete option for breeze commands --- **^ Add meaningful descripti

[GitHub] [airflow] ephraimbuddy opened a new pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
ephraimbuddy opened a new pull request #20069: URL: https://github.com/apache/airflow/pull/20069 The `airflow db check-migrations` command is missing a migration wait timeout value in the helm chart resulting in unexpected failures at times. This PR adds a default timeout to the co

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
ephraimbuddy commented on a change in pull request #20069: URL: https://github.com/apache/airflow/pull/20069#discussion_r762930605 ## File path: chart/tests/conftest.py ## @@ -22,7 +22,7 @@ from filelock import FileLock -@pytest.fixture(autouse=True, scope="session") +@pyt

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
ephraimbuddy commented on a change in pull request #20069: URL: https://github.com/apache/airflow/pull/20069#discussion_r762930605 ## File path: chart/tests/conftest.py ## @@ -22,7 +22,7 @@ from filelock import FileLock -@pytest.fixture(autouse=True, scope="session") +@pyt

[GitHub] [airflow] potiuk commented on pull request #19992: Use `python -m pip` to run pip in the new Breeze2

2021-12-06 Thread GitBox
potiuk commented on pull request #19992: URL: https://github.com/apache/airflow/pull/19992#issuecomment-986698026 > Did you move Breeze2.exe to another place to run it? @edithturn - yep. I moved it to main folder of Airflow. This is where it shoudl be eventually if someone wants to

[GitHub] [airflow] uranusjr commented on a change in pull request #20062: Use original task's `start_date` if a task continues after deferral

2021-12-06 Thread GitBox
uranusjr commented on a change in pull request #20062: URL: https://github.com/apache/airflow/pull/20062#discussion_r762953978 ## File path: airflow/models/taskinstance.py ## @@ -1200,7 +1200,8 @@ def check_and_change_state_before_execution( # Attempt 0 for the fir

[GitHub] [airflow] kazanzhy commented on a change in pull request #20044: Add ShortCircuitOperator configurability for respecting downstream trigger rules

2021-12-06 Thread GitBox
kazanzhy commented on a change in pull request #20044: URL: https://github.com/apache/airflow/pull/20044#discussion_r762954844 ## File path: tests/operators/test_python.py ## @@ -580,128 +582,164 @@ def test_raise_exception_on_invalid_task_id(self): class TestShortCircuitOpera

[GitHub] [airflow] eladkal commented on issue #18918: Manual execution of future dated dag succeeds, but none of the tasks actually run

2021-12-06 Thread GitBox
eladkal commented on issue #18918: URL: https://github.com/apache/airflow/issues/18918#issuecomment-986724879 Your code indeed not working but this code do work: ``` with DAG( dag_id='future_dag2', start_date=datetime(2021, 1, 1), schedule_interval=timedelta(we

[GitHub] [airflow] eladkal closed issue #18918: Manual execution of future dated dag succeeds, but none of the tasks actually run

2021-12-06 Thread GitBox
eladkal closed issue #18918: URL: https://github.com/apache/airflow/issues/18918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [airflow] kazanzhy commented on pull request #20058: Draft: Add Qubole how to documentation

2021-12-06 Thread GitBox
kazanzhy commented on pull request #20058: URL: https://github.com/apache/airflow/pull/20058#issuecomment-986725374 Just fixed some issues with doc build. Now local doc building works well -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [airflow] eladkal edited a comment on issue #18918: Manual execution of future dated dag succeeds, but none of the tasks actually run

2021-12-06 Thread GitBox
eladkal edited a comment on issue #18918: URL: https://github.com/apache/airflow/issues/18918#issuecomment-986724879 Your code indeed doesn't start the task but following code will work: ``` with DAG( dag_id='future_dag2', start_date=datetime(2021, 1, 1), sched

[GitHub] [airflow] uranusjr commented on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-06 Thread GitBox
uranusjr commented on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-986728173 Hmm, this is tricky. We can’t just allow slash in `dag_run_id` either because there are endpoints like `/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances` that would cause ambigui

[GitHub] [airflow] kaxil commented on issue #20055: DAG serialization broken because of pendulum

2021-12-06 Thread GitBox
kaxil commented on issue #20055: URL: https://github.com/apache/airflow/issues/20055#issuecomment-986731911 Airflow has a utility for it that you can use to make sure you don't need to use anything else. ```python from airflow.utils import timezone now = timezone.utcnow()

[GitHub] [airflow] uranusjr commented on pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
uranusjr commented on pull request #19953: URL: https://github.com/apache/airflow/pull/19953#issuecomment-986733565 Weird, I just checked out this locally and can’t reproduce. Let me merge main and see if it’s just something wrong in the CI workers. -- This is an automated message from t

[GitHub] [airflow] kaxil commented on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
kaxil commented on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986736514 ### How to downgrade? Apply this diff and then run `alembic downgrade ccde3e26fe78` from airflow migrations directory: ``` cd $(python -c "import airflow; import os;

[GitHub] [airflow] potiuk commented on issue #20055: DAG serialization broken because of pendulum

2021-12-06 Thread GitBox
potiuk commented on issue #20055: URL: https://github.com/apache/airflow/issues/20055#issuecomment-986736774 Yeah. Concur with @kaxil - maybe there are some ways we can make it clearer. I will convert this into discussion now - but maybe we can contine discussing what can be done to impr

[GitHub] [airflow] potiuk commented on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-06 Thread GitBox
potiuk commented on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-986738954 Agreee. The %2F is the only "good" way to go. And if it does not work - I think we should probably fix it. This might become handdy when we add multi-tenancy. "/" seems to be for ex

[GitHub] [airflow] potiuk edited a comment on issue #20063: Forward slash in `dag_run_id` gives rise to trouble accessing things through the REST API

2021-12-06 Thread GitBox
potiuk edited a comment on issue #20063: URL: https://github.com/apache/airflow/issues/20063#issuecomment-986738954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [airflow] kazanzhy opened a new pull request #20071: Draft: ShortCircuitOperator pushs XCom

2021-12-06 Thread GitBox
kazanzhy opened a new pull request #20071: URL: https://github.com/apache/airflow/pull/20071 closes: #19922 related: #20044 Add return condition for `ShortCircuinOperator`. If `python_callable` returns the object that casts as `True` then that object will be available as XCom w

[GitHub] [airflow] potiuk commented on pull request #20058: Draft: Add Qubole how to documentation

2021-12-06 Thread GitBox
potiuk commented on pull request #20058: URL: https://github.com/apache/airflow/pull/20058#issuecomment-986741155 some provider.yaml inconsistency :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] potiuk commented on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
potiuk commented on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986744395 Question - what woudl be the cases where timing out on migration is "wrong" ? Woudl not that leave the DB in a state that is not expected ? However I think that one is fine to

[GitHub] [airflow] potiuk commented on pull request #18439: Check and run migration in commands if necessary

2021-12-06 Thread GitBox
potiuk commented on pull request #18439: URL: https://github.com/apache/airflow/pull/18439#issuecomment-986744856 Hey @kaxil - have your worries been addressed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk edited a comment on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
potiuk edited a comment on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986744395 Question - what woudl be the cases where timing out on migration is "wrong" ? Wouls not that leave the DB in a state that is not expected ? However I think that one is

[GitHub] [airflow] potiuk commented on pull request #20058: Draft: Add Qubole how to documentation

2021-12-06 Thread GitBox
potiuk commented on pull request #20058: URL: https://github.com/apache/airflow/pull/20058#issuecomment-986753099 BTW @kazanzhy. I STRONGLY recommend `pip install pre-commit`. It saves a TON of time on iterations like that :). See https://github.com/apache/airflow/blob/main/STATIC_CODE_C

[GitHub] [airflow] ephraimbuddy commented on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
ephraimbuddy commented on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986752938 > Question - what woudl be the cases where timing out on migration is "wrong" ? Wouls not that leave the DB in a state that is not expected ? However I think that one is

[GitHub] [airflow] ephraimbuddy edited a comment on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
ephraimbuddy edited a comment on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986752938 > Question - what woudl be the cases where timing out on migration is "wrong" ? Wouls not that leave the DB in a state that is not expected ? However I think that

[GitHub] [airflow] potiuk edited a comment on pull request #20058: Draft: Add Qubole how to documentation

2021-12-06 Thread GitBox
potiuk edited a comment on pull request #20058: URL: https://github.com/apache/airflow/pull/20058#issuecomment-986753099 BTW @kazanzhy. I STRONGLY recommend `pip install pre-commit` followed by 'pre-commit install'. It saves a TON of time on iterations like that :). See https://github.co

[GitHub] [airflow] potiuk edited a comment on pull request #20058: Draft: Add Qubole how to documentation

2021-12-06 Thread GitBox
potiuk edited a comment on pull request #20058: URL: https://github.com/apache/airflow/pull/20058#issuecomment-986753099 BTW @kazanzhy. I STRONGLY recommend `pip install pre-commit` followed by `pre-commit install`. It saves a TON of time on iterations like that :). See https://github.co

[GitHub] [airflow] edithturn commented on pull request #19992: Use `python -m pip` to run pip in the new Breeze2

2021-12-06 Thread GitBox
edithturn commented on pull request #19992: URL: https://github.com/apache/airflow/pull/19992#issuecomment-986755223 `@edithturn - yep. I moved it to main folder of Airflow. This is where it shoudl be eventually if someone wants to run it - because "dist" is a temporary folder that gets ov

[GitHub] [airflow] potiuk commented on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
potiuk commented on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986756000 Ah I see. But I hopw #18439 could be also merged, that would help A LOT in a meaningful message to the user if the timeout actually happens. Or is timeout equivalent with "erro

[GitHub] [airflow] potiuk edited a comment on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
potiuk edited a comment on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986756000 Ah I see. But I hope #18439 could be also merged, that would help A LOT in a meaningful message to the user if the timeout actually happens. Or is timeout equivalent wit

[GitHub] [airflow] potiuk commented on a change in pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #19993: URL: https://github.com/apache/airflow/pull/19993#discussion_r762991737 ## File path: docs/apache-airflow/installation/upgrading.rst ## @@ -79,6 +79,20 @@ table or rename it or move it to another database using those tools.

[GitHub] [airflow] potiuk commented on a change in pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #19993: URL: https://github.com/apache/airflow/pull/19993#discussion_r762991737 ## File path: docs/apache-airflow/installation/upgrading.rst ## @@ -79,6 +79,20 @@ table or rename it or move it to another database using those tools.

[GitHub] [airflow] eladkal commented on a change in pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-06 Thread GitBox
eladkal commented on a change in pull request #19993: URL: https://github.com/apache/airflow/pull/19993#discussion_r762992430 ## File path: docs/apache-airflow/installation/upgrading.rst ## @@ -79,6 +79,20 @@ table or rename it or move it to another database using those tools.

[GitHub] [airflow] Aakcht commented on pull request #20064: Chart: rename kerberos-keytab secret file

2021-12-06 Thread GitBox
Aakcht commented on pull request #20064: URL: https://github.com/apache/airflow/pull/20064#issuecomment-986761790 Looks like the not successful check is not related to this PR, I can retrigger it if needed. -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [airflow] Melodie97 commented on issue #19972: POC on configuring and running Airflow with basic OT integration (selected metrics)

2021-12-06 Thread GitBox
Melodie97 commented on issue #19972: URL: https://github.com/apache/airflow/issues/19972#issuecomment-986763145 Currently looking at how to go about this, will keep everyone updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [airflow] uranusjr commented on pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
uranusjr commented on pull request #19953: URL: https://github.com/apache/airflow/pull/19953#issuecomment-986764654 Oh never mind I got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] ephraimbuddy commented on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
ephraimbuddy commented on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986767778 > Ah I see. But I hope #18439 could be also merged, that would help A LOT in a meaningful message to the user if the timeout actually happens. Or is timeout equivalent wi

[GitHub] [airflow] ashb commented on a change in pull request #20011: Type-annotate SkipMixin and BaseXCom

2021-12-06 Thread GitBox
ashb commented on a change in pull request #20011: URL: https://github.com/apache/airflow/pull/20011#discussion_r763000313 ## File path: airflow/models/skipmixin.py ## @@ -66,9 +67,10 @@ def _set_state_to_skipped(self, dag_run: "DagRun", tasks: "Iterable[BaseOperator def

[GitHub] [airflow] ashb commented on a change in pull request #20011: Type-annotate SkipMixin and BaseXCom

2021-12-06 Thread GitBox
ashb commented on a change in pull request #20011: URL: https://github.com/apache/airflow/pull/20011#discussion_r763000669 ## File path: airflow/models/xcom.py ## @@ -79,144 +80,247 @@ def init_on_load(self): def __repr__(self): return f'' +@overload @c

[GitHub] [airflow] BasPH commented on pull request #19990: Order bug report fields by importance

2021-12-06 Thread GitBox
BasPH commented on pull request #19990: URL: https://github.com/apache/airflow/pull/19990#issuecomment-986789436 Moved the version dropdown to the top: ![image](https://user-images.githubusercontent.com/6249654/144856545-0a2cc343-69b5-4b75-ae35-8cabb0827e37.png) -- This is an auto

[GitHub] [airflow] uranusjr commented on pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
uranusjr commented on pull request #19953: URL: https://github.com/apache/airflow/pull/19953#issuecomment-986790016 I pushed a change to fix that test failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [airflow] ashb commented on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
ashb commented on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986793360 Could it be cos of Airflow still running while trying to upgrade? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on a change in pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #19953: URL: https://github.com/apache/airflow/pull/19953#discussion_r763037847 ## File path: tests/www/views/test_views_rendered.py ## @@ -154,13 +154,17 @@ def test_user_defined_filter_and_macros_raise_error(admin_client, create_d

[GitHub] [airflow] github-actions[bot] commented on pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #19953: URL: https://github.com/apache/airflow/pull/19953#issuecomment-986809689 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[GitHub] [airflow] casra-developers commented on pull request #16110: Added windows extensions

2021-12-06 Thread GitBox
casra-developers commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-986812778 @uranusjr I have completed the manual merge of the main branch. Everything seems to work in the test environment, the only thing I have noticed that there seems to be

[GitHub] [airflow] potiuk commented on pull request #16110: Added windows extensions

2021-12-06 Thread GitBox
potiuk commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-986815237 Ah. Cool we are also working on Breeze rewrite in Python, that would make it more "open" to Windows (no WSL2) users. https://github.com/apache/airflow/pull/19992 so this is ha

[GitHub] [airflow] potiuk commented on pull request #19990: Order bug report fields by importance

2021-12-06 Thread GitBox
potiuk commented on pull request #19990: URL: https://github.com/apache/airflow/pull/19990#issuecomment-986816738 Looks Great to me :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] potiuk commented on pull request #19990: Order bug report fields by importance

2021-12-06 Thread GitBox
potiuk commented on pull request #19990: URL: https://github.com/apache/airflow/pull/19990#issuecomment-986817536 @jedcunningham and others - any comments :), or shall we merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [airflow] jens-scheffler-bosch commented on issue #19848: Add configurable options to adjust branding (logo/title)

2021-12-06 Thread GitBox
jens-scheffler-bosch commented on issue #19848: URL: https://github.com/apache/airflow/issues/19848#issuecomment-986822792 Thanks for the feedback, the intent was not to run into legal constraints nor to get into any conflict with trademarks - of course the Apache rules like "powered by" w

[GitHub] [airflow] jens-scheffler-bosch closed issue #19848: Add configurable options to adjust branding (logo/title)

2021-12-06 Thread GitBox
jens-scheffler-bosch closed issue #19848: URL: https://github.com/apache/airflow/issues/19848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [airflow] potiuk commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763049790 ## File path: airflow/models/baseoperator.py ## @@ -1325,7 +1335,7 @@ def run( execution_date=info.logical_date,

[GitHub] [airflow] github-actions[bot] commented on pull request #20069: Add migration-wait-timeout to the helm chart

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #20069: URL: https://github.com/apache/airflow/pull/20069#issuecomment-986825665 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] uranusjr closed issue #19761: removing upper bound for markupsafe

2021-12-06 Thread GitBox
uranusjr closed issue #19761: URL: https://github.com/apache/airflow/issues/19761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
boring-cyborg[bot] commented on pull request #19953: URL: https://github.com/apache/airflow/pull/19953#issuecomment-986827547 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] uranusjr merged pull request #19953: update upper bound for MarkupSafe

2021-12-06 Thread GitBox
uranusjr merged pull request #19953: URL: https://github.com/apache/airflow/pull/19953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[airflow] branch main updated (6e15e3a -> ba6b7c7)

2021-12-06 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 6e15e3a Bug fix in AWS glue operator when specifying the WorkerType & NumberOfWorkers (#19787) add ba6b7c7 u

[GitHub] [airflow] neptune19821220 commented on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
neptune19821220 commented on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986828774 Hi All, For further test, I use mysqldump to dump the airflow database from staging Aurora serverless. 1. I restore the data to a new AWS RDS mysql 5.7 instance w

[GitHub] [airflow] potiuk edited a comment on issue #19972: POC on configuring and running Airflow with basic OT integration (selected metrics)

2021-12-06 Thread GitBox
potiuk edited a comment on issue #19972: URL: https://github.com/apache/airflow/issues/19972#issuecomment-986830720 Also @Melodie97 - see thee #20053 - it turned out that the idea of @subkanthi was about adding a provider to expose PushGateway API via provider, so it is indeed different fr

[GitHub] [airflow] potiuk commented on issue #19972: POC on configuring and running Airflow with basic OT integration (selected metrics)

2021-12-06 Thread GitBox
potiuk commented on issue #19972: URL: https://github.com/apache/airflow/issues/19972#issuecomment-986830720 Also @Melodie97 - see thee #20053 - it turned out that the idea of @subkanthi was about adding a provider to expose PushGateway API via provider, so it is indeed different from our

[GitHub] [airflow] thomashutcheson-msm commented on issue #12061: Add example dag showing usage of `impersonation_chain` argument of Google operators

2021-12-06 Thread GitBox
thomashutcheson-msm commented on issue #12061: URL: https://github.com/apache/airflow/issues/12061#issuecomment-986836974 Did the example dag get created, I would find this really useful right now ? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] ashb commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
ashb commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763067505 ## File path: airflow/models/baseoperator.py ## @@ -1301,8 +1305,13 @@ def run( from airflow.models import DagRun from airflow.utils.type

[GitHub] [airflow] potiuk edited a comment on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
potiuk edited a comment on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986838313 Is this possible that you send more logs of what happens including possibly server side logs from around the upgrade? I have a feeling that this might be similar class

[GitHub] [airflow] potiuk commented on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
potiuk commented on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986838313 Is this possible that you send more logs of what happens including possibly server side logs from around the upgrade. I have a feeling that this might be similar class of error like

[GitHub] [airflow] malthe opened a new pull request #20072: Add method 'call_stored_proc' on Oracle hook

2021-12-06 Thread GitBox
malthe opened a new pull request #20072: URL: https://github.com/apache/airflow/pull/20072 This adds a new method: ```python OracleHook.callproc(identifier: str, parameters: Optional[Union[Dict, List]] = None) ``` (In the actual code, the `parameters` argument ar

[GitHub] [airflow] ashb commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
ashb commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763068672 ## File path: airflow/models/dag.py ## @@ -403,11 +403,12 @@ def __init__( # set timezone from start_date tz = None if start_dat

[GitHub] [airflow] ashb commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
ashb commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763070493 ## File path: airflow/models/baseoperator.py ## @@ -1325,7 +1335,7 @@ def run( execution_date=info.logical_date,

[GitHub] [airflow] neptune19821220 edited a comment on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
neptune19821220 edited a comment on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986828774 Hi All, For further test, I use mysqldump to dump the airflow database from staging Aurora serverless. 1. I restore the data to a new AWS RDS mysql 5.7 ins

[GitHub] [airflow] potiuk commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763071994 ## File path: airflow/models/dag.py ## @@ -403,11 +403,12 @@ def __init__( # set timezone from start_date tz = None if start_d

[GitHub] [airflow] neptune19821220 commented on issue #20016: Upgrading Apache Airflow from version 2.1.3 to 2.2.2

2021-12-06 Thread GitBox
neptune19821220 commented on issue #20016: URL: https://github.com/apache/airflow/issues/20016#issuecomment-986844030 @potiuk @ashb Thank you for your reply. Though I didn't stop airflow service during the upgrade, there is no any running task during the upgrade. I choose a fr

[GitHub] [airflow] subkanthi commented on issue #19972: POC on configuring and running Airflow with basic OT integration (selected metrics)

2021-12-06 Thread GitBox
subkanthi commented on issue #19972: URL: https://github.com/apache/airflow/issues/19972#issuecomment-986844568 > Also @Melodie97 - see thee #20053 - it turned out that the idea of @subkanthi was about adding a provider to expose PushGateway API via provider, so it is indeed different from

[GitHub] [airflow] github-actions[bot] commented on pull request #20064: Chart: rename kerberos-keytab secret file

2021-12-06 Thread GitBox
github-actions[bot] commented on pull request #20064: URL: https://github.com/apache/airflow/pull/20064#issuecomment-986845998 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] potiuk commented on pull request #20064: Chart: rename kerberos-keytab secret file

2021-12-06 Thread GitBox
potiuk commented on pull request #20064: URL: https://github.com/apache/airflow/pull/20064#issuecomment-986846054 I think even if it "was" released, we could change it still. That's the beauty of helm chart that it packages things nicely and thins like file names are really implementation

[GitHub] [airflow] potiuk merged pull request #20064: Chart: rename kerberos-keytab secret file

2021-12-06 Thread GitBox
potiuk merged pull request #20064: URL: https://github.com/apache/airflow/pull/20064 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] ashb commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
ashb commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763076763 ## File path: airflow/models/baseoperator.py ## @@ -1301,8 +1305,13 @@ def run( from airflow.models import DagRun from airflow.utils.type

[airflow] branch main updated (ba6b7c7 -> cc3f038)

2021-12-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from ba6b7c7 update upper bound for MarkupSafe (#19953) add cc3f038 Chart: Rename kerberos-keytab secret file (#2006

[GitHub] [airflow] casra-developers commented on pull request #16110: Added windows extensions

2021-12-06 Thread GitBox
casra-developers commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-986846900 Agreed. Especially for weird setups like ours where Linux and Windows systems have to work together, this can potentially be very useful. I have noticed that there

[GitHub] [airflow] potiuk commented on a change in pull request #19993: Update upgrading.rst with detailed code example of how to resolve post-upgrade warning

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #19993: URL: https://github.com/apache/airflow/pull/19993#discussion_r763077077 ## File path: docs/apache-airflow/installation/upgrading.rst ## @@ -79,6 +79,20 @@ table or rename it or move it to another database using those tools.

[GitHub] [airflow] potiuk commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763083688 ## File path: airflow/models/baseoperator.py ## @@ -1301,8 +1305,13 @@ def run( from airflow.models import DagRun from airflow.utils.ty

[GitHub] [airflow] potiuk commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763083954 ## File path: airflow/models/baseoperator.py ## @@ -1301,8 +1305,13 @@ def run( from airflow.models import DagRun from airflow.utils.ty

[GitHub] [airflow] potiuk commented on a change in pull request #20000: Fix many of the mypy typing issues in airflow.models

2021-12-06 Thread GitBox
potiuk commented on a change in pull request #2: URL: https://github.com/apache/airflow/pull/2#discussion_r763084583 ## File path: airflow/models/baseoperator.py ## @@ -1301,8 +1305,13 @@ def run( from airflow.models import DagRun from airflow.utils.ty

[GitHub] [airflow] potiuk commented on pull request #16110: Added windows extensions

2021-12-06 Thread GitBox
potiuk commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-986859488 > I have noticed that there are four tests of type www which are failing. I'm assuming that this is something that has nothing todo with our changes, right? I also see i

[GitHub] [airflow] potiuk commented on pull request #16110: Added windows extensions

2021-12-06 Thread GitBox
potiuk commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-986859848 https://github.com/apache/airflow/runs/4430426331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

  1   2   3   4   >