[GitHub] [airflow] dstandish commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
dstandish commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771785541 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -320,20 +332,3 @@ def _exec_pod_command(self, resp, command: str) -> None:

[GitHub] [airflow] dstandish commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
dstandish commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771784994 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +339,133 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] dstandish commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
dstandish commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771784838 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +339,133 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] dstandish commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
dstandish commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771784751 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +339,133 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] jedcunningham commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
jedcunningham commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771784745 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -320,20 +332,3 @@ def _exec_pod_command(self, resp, command: str) -> N

[GitHub] [airflow] dstandish commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
dstandish commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771784355 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -320,20 +332,3 @@ def _exec_pod_command(self, resp, command: str) -> None:

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20391: Fix task instance concurrency limit in a DAG affecting other DAGs

2021-12-17 Thread GitBox
ephraimbuddy commented on a change in pull request #20391: URL: https://github.com/apache/airflow/pull/20391#discussion_r771782173 ## File path: airflow/logs/scheduler/latest ## @@ -0,0 +1 @@ +./logs/scheduler/2021-12-17 Review comment: Yeah! -- This is an automate

[GitHub] [airflow] david30907d edited a comment on issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-17 Thread GitBox
david30907d edited a comment on issue #19507: URL: https://github.com/apache/airflow/issues/19507#issuecomment-997139792 @kazanzhy sorry for the late reply~ very thx for these inputs~ I'll give it a shot and hope I can finish this PR before 2022 😂 btw, you're available, maybe you

[GitHub] [airflow] david30907d commented on issue #19507: Make BigQueryHook compatible with sqlalchemy

2021-12-17 Thread GitBox
david30907d commented on issue #19507: URL: https://github.com/apache/airflow/issues/19507#issuecomment-997139792 @kazanzhy sorry for the late reply~ very thx for these inputs~ I'll give it a shot and hope I can finish this PR before 2022 😂 -- This is an automated message from the Ap

[GitHub] [airflow] jedcunningham commented on a change in pull request #20391: Fix task instance concurrency limit in a DAG affecting other DAGs

2021-12-17 Thread GitBox
jedcunningham commented on a change in pull request #20391: URL: https://github.com/apache/airflow/pull/20391#discussion_r771779335 ## File path: airflow/jobs/scheduler_job.py ## @@ -581,6 +593,13 @@ def _process_executor_events(self, session: Session = None) -> int:

[GitHub] [airflow] boring-cyborg[bot] commented on issue #20394: Airflow 2.2.2 - Celery worker ContentDisallowed('Refusing to deserialize untrusted content of type pickle (application/x-python-seriali

2021-12-17 Thread GitBox
boring-cyborg[bot] commented on issue #20394: URL: https://github.com/apache/airflow/issues/20394#issuecomment-997138100 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] nicnguyen3103 opened a new issue #20394: Airflow 2.2.2 - Celery worker ContentDisallowed('Refusing to deserialize untrusted content of type pickle (application/x-python-serialize)')

2021-12-17 Thread GitBox
nicnguyen3103 opened a new issue #20394: URL: https://github.com/apache/airflow/issues/20394 ### Apache Airflow version 2.2.2 (latest released) ### What happened I tried to upgrade to Airflow 2.2.2 and the celery worker dies immediately upon startup with the command air

[GitHub] [airflow] jedcunningham commented on a change in pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
jedcunningham commented on a change in pull request #19572: URL: https://github.com/apache/airflow/pull/19572#discussion_r771776507 ## File path: airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py ## @@ -328,101 +339,133 @@ def create_labels_for_pod(context) -> dict:

[GitHub] [airflow] Acehaidrey edited a comment on issue #16790: Support manual task annotation.

2021-12-17 Thread GitBox
Acehaidrey edited a comment on issue #16790: URL: https://github.com/apache/airflow/issues/16790#issuecomment-997109040 @sharingan-no-kakashi can you let me know are you planning to get this PR in? that would be great for us. Sorry I see it was not implemented in. It was closed. Any

[GitHub] [airflow] Acehaidrey edited a comment on issue #16790: Support manual task annotation.

2021-12-17 Thread GitBox
Acehaidrey edited a comment on issue #16790: URL: https://github.com/apache/airflow/issues/16790#issuecomment-997109040 @sharingan-no-kakashi can you let me know are you planning to get this PR in? that would be great for us. Sorry I see the PR get in: https://github.com/apache/airfl

[GitHub] [airflow] kazanzhy edited a comment on issue #19891: Re-enable MyPy

2021-12-17 Thread GitBox
kazanzhy edited a comment on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-991367061 Fix mypy in * airflow/providers/alibaba - #20393 * airflow/providers/apache/beam - #20301 * airflow/providers/apache/drill - #20268 * airflow/providers/apache

[GitHub] [airflow] kazanzhy edited a comment on issue #19891: Re-enable MyPy

2021-12-17 Thread GitBox
kazanzhy edited a comment on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-991367061 Fix mypy in * airflow/providers/alibaba - #20393 * airflow/providers/apache/beam - #20301 * airflow/providers/apache/drill - #20268 * airflow/providers/apache

[GitHub] [airflow] kazanzhy opened a new pull request #20393: Fix MyPy Errors for Alibaba provider.

2021-12-17 Thread GitBox
kazanzhy opened a new pull request #20393: URL: https://github.com/apache/airflow/pull/20393 Fix MyPy Errors for Alibaba provider. related: #19891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] Acehaidrey commented on issue #16790: Support manual task annotation.

2021-12-17 Thread GitBox
Acehaidrey commented on issue #16790: URL: https://github.com/apache/airflow/issues/16790#issuecomment-997109040 @sharingan-no-kakashi can you let me know are you planning to get this PR in? that would be great for us -- This is an automated message from the Apache Git Service. To respon

[GitHub] [airflow] github-actions[bot] commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
github-actions[bot] commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-997102082 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not m

[GitHub] [airflow] jedcunningham commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
jedcunningham commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-997101087 Looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] github-actions[bot] closed pull request #19018: S3 hooks filter options

2021-12-17 Thread GitBox
github-actions[bot] closed pull request #19018: URL: https://github.com/apache/airflow/pull/19018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #19030: Align EcsOperator with DockerOperator capabilities

2021-12-17 Thread GitBox
github-actions[bot] closed pull request #19030: URL: https://github.com/apache/airflow/pull/19030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] closed pull request #19027: Fix for DockerOperator Xcoms functionality

2021-12-17 Thread GitBox
github-actions[bot] closed pull request #19027: URL: https://github.com/apache/airflow/pull/19027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on issue #16351: After upgrade from 2.0.1 to 2.1.0 the MsSQLToS3Operator has stopped working when uploading a multipart to S3

2021-12-17 Thread GitBox
github-actions[bot] commented on issue #16351: URL: https://github.com/apache/airflow/issues/16351#issuecomment-997100796 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] kaxil commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
kaxil commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-997098689 > Add generic all read and all edit function What do you think about - https://github.com/apache/airflow/pull/20346/commits/66a70332ee9d2ad5d4189b3d774aae0f25062de0? --

[GitHub] [airflow] rustikk opened a new issue #20392: Airflow's PythonVirtualenvOperator isn't installing different python versions unless its the version airflow is ran with.

2021-12-17 Thread GitBox
rustikk opened a new issue #20392: URL: https://github.com/apache/airflow/issues/20392 ### Apache Airflow version 2.2.2 (latest released) ### What happened When specifying the version in the PythonVirtualenvOperator it fails to find the version 2.7 and as a result cause

[GitHub] [airflow] dstandish commented on pull request #17934: Add dags.gitSync.sshKeyCustomFile parameter to allow other SSH key sources

2021-12-17 Thread GitBox
dstandish commented on pull request #17934: URL: https://github.com/apache/airflow/pull/17934#issuecomment-997079775 > I'm still leaning toward not setting `GIT_SSH_KEY_FILE` at all, since we just set it to the default anyways, which would allow users to use `gitSync.env` to set both it an

[airflow] branch constraints-main updated: Updating constraints. Build id:1594191280

2021-12-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 5ccdf71 Updating const

[GitHub] [airflow] dstandish commented on a change in pull request #17934: Add dags.gitSync.sshKeyCustomFile parameter to allow other SSH key sources

2021-12-17 Thread GitBox
dstandish commented on a change in pull request #17934: URL: https://github.com/apache/airflow/pull/17934#discussion_r771731034 ## File path: chart/values.yaml ## @@ -1308,6 +1308,7 @@ dags: extraVolumeMounts: [] env: [] resources: {} +sshKeyCustomFile: Revi

[GitHub] [airflow] jedcunningham commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
jedcunningham commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-997073751 I'm just saying that, regardless of what security manager is in use, global `can_edit` should be expected to give edit on all DAGs. We shouldn't assume all things will u

[GitHub] [airflow] ashb commented on pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on pull request #19965: URL: https://github.com/apache/airflow/pull/19965#issuecomment-997069084 FYI/For future reference I've started another branch that starts the work on Serialization support for mapped Ops/TGs. https://github.com/astronomer/airflow/compare/operator-mapp

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771724522 ## File path: airflow/decorators/base.py ## @@ -176,11 +178,110 @@ def _hook_apply_defaults(self, *args, **kwargs): T = TypeVar("T", bound=Callable) +

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771724522 ## File path: airflow/decorators/base.py ## @@ -176,11 +178,110 @@ def _hook_apply_defaults(self, *args, **kwargs): T = TypeVar("T", bound=Callable) +

[GitHub] [airflow] kaxil commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
kaxil commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-997060038 > Fwiw, this isn't how permissions are documented: https://airflow.apache.org/docs/apache-airflow/stable/security/access-control.html#dag-level-permissions > > Have we tri

[GitHub] [airflow] jedcunningham commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
jedcunningham commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-997055109 Fwiw, this isn't how permissions are documented: https://airflow.apache.org/docs/apache-airflow/stable/security/access-control.html#dag-level-permissions Have w

[GitHub] [airflow] ephraimbuddy commented on pull request #20391: Fix task instance concurrency limit in a DAG affecting other DAGs

2021-12-17 Thread GitBox
ephraimbuddy commented on pull request #20391: URL: https://github.com/apache/airflow/pull/20391#issuecomment-997055104 Will add more tests later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] ephraimbuddy opened a new pull request #20391: Fix task instance concurrency limit in a DAG affecting other DAGs

2021-12-17 Thread GitBox
ephraimbuddy opened a new pull request #20391: URL: https://github.com/apache/airflow/pull/20391 Currently, if a DAG with large tasks reaches a concurrency limit, task instances in other dags will get stuck in scheduled state. The reason is that at each scheduler loop, task instances

[GitHub] [airflow] kaxil commented on pull request #19572: Simplify ``KubernetesPodOperator``

2021-12-17 Thread GitBox
kaxil commented on pull request #19572: URL: https://github.com/apache/airflow/pull/19572#issuecomment-997054024 @dstandish :( Conficts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] potiuk commented on a change in pull request #20358: Fix remaining MyPy errors in Google Provider

2021-12-17 Thread GitBox
potiuk commented on a change in pull request #20358: URL: https://github.com/apache/airflow/pull/20358#discussion_r771712921 ## File path: airflow/providers/google/cloud/hooks/os_login.py ## @@ -53,7 +54,13 @@ def get_conn(self) -> OsLoginServiceClient: @GoogleBaseHook.f

[GitHub] [airflow] kaxil commented on pull request #19747: Fix Tasks getting stuck in scheduled state

2021-12-17 Thread GitBox
kaxil commented on pull request #19747: URL: https://github.com/apache/airflow/pull/19747#issuecomment-997050389 Tests are failing, can you take a look plz @tanelk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] potiuk commented on a change in pull request #20358: Fix remaining MyPy errors in Google Provider

2021-12-17 Thread GitBox
potiuk commented on a change in pull request #20358: URL: https://github.com/apache/airflow/pull/20358#discussion_r771710200 ## File path: airflow/providers/google/cloud/hooks/compute.py ## @@ -405,10 +405,11 @@ def get_instance_address( instance_info = self.get_instan

[GitHub] [airflow] github-actions[bot] commented on pull request #20390: Fix MyPy errors in airflow/api and airflow/api_connexion

2021-12-17 Thread GitBox
github-actions[bot] commented on pull request #20390: URL: https://github.com/apache/airflow/pull/20390#issuecomment-997047546 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and tak

[airflow] branch main updated (790bc78 -> 78e4d16)

2021-12-17 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 790bc78 Remove unnecssary logging in experimental API (#20356) add 78e4d16 Change default python version in doc

[GitHub] [airflow] josh-fell edited a comment on issue #19891: Re-enable MyPy

2021-12-17 Thread GitBox
josh-fell edited a comment on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-997046499 Just started going down from the top (ish), skipping `airflow` for now. #20390 should take care of `airflow/api/common/*` and `airflow/api_connexion/*`. -- This is an

[GitHub] [airflow] potiuk merged pull request #20389: Change default python version in docker image docs

2021-12-17 Thread GitBox
potiuk merged pull request #20389: URL: https://github.com/apache/airflow/pull/20389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] josh-fell commented on issue #19891: Re-enable MyPy

2021-12-17 Thread GitBox
josh-fell commented on issue #19891: URL: https://github.com/apache/airflow/issues/19891#issuecomment-997046499 Just started going down from the top (ish), skipping `airflow` for now. #20390 should take care of `airflow/api/common/*` and `airflow/api_connexion/*`. -- This is an automat

[GitHub] [airflow] josh-fell opened a new pull request #20390: Fix MyPy errors in airflow/api and airflow/api_connexion

2021-12-17 Thread GitBox
josh-fell opened a new pull request #20390: URL: https://github.com/apache/airflow/pull/20390 Related: #19891 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline

[GitHub] [airflow] potiuk commented on pull request #16110: Added windows extensions

2021-12-17 Thread GitBox
potiuk commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-997043446 Seems like the pwname not used is the last problem @casra-developers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] potiuk commented on issue #20382: Streamline task action and trigger dag UX

2021-12-17 Thread GitBox
potiuk commented on issue #20382: URL: https://github.com/apache/airflow/issues/20382#issuecomment-997039965 Should be great to improve that. User eXperience matters! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [airflow] Aakcht opened a new pull request #20389: Change default python version in docker image docs

2021-12-17 Thread GitBox
Aakcht opened a new pull request #20389: URL: https://github.com/apache/airflow/pull/20389 Added information that you get a 3.7 python version when using apache/airflow:latest or apache/airflow:2.2.2 images --- **^ Add meaningful description above** Read the **[Pull

[GitHub] [airflow] potiuk commented on pull request #20031: Add missed deprecations for cncf

2021-12-17 Thread GitBox
potiuk commented on pull request #20031: URL: https://github.com/apache/airflow/pull/20031#issuecomment-997028626 The problem is that currently if user import the deprecate import now, they will see a wrong "origin" place of the import, so this is a "real" issue. -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #20031: Add missed deprecations for cncf

2021-12-17 Thread GitBox
potiuk commented on pull request #20031: URL: https://github.com/apache/airflow/pull/20031#issuecomment-997028004 Apparently the common "import" is using different stack levels in different import paths. This probably means that you need to make sure the warning is either generated with th

[airflow] branch main updated: Remove unnecssary logging in experimental API (#20356)

2021-12-17 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 790bc78 Remove unnecssary logging in experimental

[GitHub] [airflow] potiuk merged pull request #20356: Remove unnecssary logging in experimental API

2021-12-17 Thread GitBox
potiuk merged pull request #20356: URL: https://github.com/apache/airflow/pull/20356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] kaxil commented on pull request #19747: Fix Tasks getting stuck in scheduled state

2021-12-17 Thread GitBox
kaxil commented on pull request #19747: URL: https://github.com/apache/airflow/pull/19747#issuecomment-997018489 Just rebased on latest main branch to fix merge conflicts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771669229 ## File path: airflow/models/taskmixin.py ## @@ -88,3 +99,167 @@ def __init_subclass__(cls) -> None: stacklevel=2, ) return

[GitHub] [airflow] pingzh removed a comment on pull request #20361: Add context var hook to inject more env vars

2021-12-17 Thread GitBox
pingzh removed a comment on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-997000340 hmm, very strange about this check flake8 check. it passed in my local ![image](https://user-images.githubusercontent.com/8662365/146601353-24161af6-21fd-4a6f-89e

[GitHub] [airflow] pingzh commented on pull request #20361: Add context var hook to inject more env vars

2021-12-17 Thread GitBox
pingzh commented on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-997000340 hmm, very strange about this check flake8 check. it passed in my local ![image](https://user-images.githubusercontent.com/8662365/146601353-24161af6-21fd-4a6f-89e0-71857e

[GitHub] [airflow] ashb commented on pull request #20378: Reduce deprecation warnings from www

2021-12-17 Thread GitBox
ashb commented on pull request #20378: URL: https://github.com/apache/airflow/pull/20378#issuecomment-997000131 > ``` > 'airflow.models.dag.DagModel object' has no attribute 'get_is_paused' > ``` > > Uh. DAG vs DagModel maybe? -- This is an automated message from the A

[GitHub] [airflow] bbovenzi commented on pull request #20346: Fix inconsitencies in checking edit permissions for a DAG

2021-12-17 Thread GitBox
bbovenzi commented on pull request #20346: URL: https://github.com/apache/airflow/pull/20346#issuecomment-996997559 This looks right to me but I had issues with my local setup to test nor is python my strong suit. -- This is an automated message from the Apache Git Service. To respond to

[airflow] branch constraints-main updated: Updating constraints. Build id:1593631350

2021-12-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e03bd76 Updating const

[GitHub] [airflow] josh-fell commented on a change in pull request #20034: Fix MyPy errors for Airflow decorators

2021-12-17 Thread GitBox
josh-fell commented on a change in pull request #20034: URL: https://github.com/apache/airflow/pull/20034#discussion_r771650276 ## File path: airflow/providers/docker/decorators/docker.py ## @@ -79,7 +79,7 @@ def __init__( command=command, retrieve_output=True, re

[GitHub] [airflow] josh-fell commented on a change in pull request #20034: Fix MyPy errors for Airflow decorators

2021-12-17 Thread GitBox
josh-fell commented on a change in pull request #20034: URL: https://github.com/apache/airflow/pull/20034#discussion_r771650276 ## File path: airflow/providers/docker/decorators/docker.py ## @@ -79,7 +79,7 @@ def __init__( command=command, retrieve_output=True, re

[GitHub] [airflow] josh-fell commented on a change in pull request #20034: Fix MyPy errors for Airflow decorators

2021-12-17 Thread GitBox
josh-fell commented on a change in pull request #20034: URL: https://github.com/apache/airflow/pull/20034#discussion_r771650276 ## File path: airflow/providers/docker/decorators/docker.py ## @@ -79,7 +79,7 @@ def __init__( command=command, retrieve_output=True, re

[GitHub] [airflow] eladkal commented on a change in pull request #20370: 20139 sagemaker

2021-12-17 Thread GitBox
eladkal commented on a change in pull request #20370: URL: https://github.com/apache/airflow/pull/20370#discussion_r771640752 ## File path: airflow/providers/amazon/aws/operators/sagemaker.py ## @@ -0,0 +1,643 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] eladkal commented on a change in pull request #20370: 20139 sagemaker

2021-12-17 Thread GitBox
eladkal commented on a change in pull request #20370: URL: https://github.com/apache/airflow/pull/20370#discussion_r771640752 ## File path: airflow/providers/amazon/aws/operators/sagemaker.py ## @@ -0,0 +1,643 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] ferruzzi commented on a change in pull request #20370: 20139 sagemaker

2021-12-17 Thread GitBox
ferruzzi commented on a change in pull request #20370: URL: https://github.com/apache/airflow/pull/20370#discussion_r771599403 ## File path: airflow/providers/amazon/aws/operators/sagemaker.py ## @@ -0,0 +1,643 @@ +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [airflow] jedcunningham commented on pull request #19689: Chart: Allow overriding redis's ``runAsUser`` option (#19681)

2021-12-17 Thread GitBox
jedcunningham commented on pull request #19689: URL: https://github.com/apache/airflow/pull/19689#issuecomment-996944936 @tomasgatial, #18249 has been merged. Can you refactor this to support both `uid` and a complete `securityContext`? -- This is an automated message from the Apache Git

[GitHub] [airflow] jedcunningham commented on pull request #18249: Add support for securityContext per deployment

2021-12-17 Thread GitBox
jedcunningham commented on pull request #18249: URL: https://github.com/apache/airflow/pull/18249#issuecomment-996941520 Thanks for the contribution @nwalens 🎉! (also thanks for being patient) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[airflow] branch main updated: Chart: Add support for securityContext (#18249)

2021-12-17 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e936e0f Chart: Add support for securityCont

[GitHub] [airflow] jedcunningham closed issue #17744: Problems with how SecurityContext is handled in the helm chart

2021-12-17 Thread GitBox
jedcunningham closed issue #17744: URL: https://github.com/apache/airflow/issues/17744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [airflow] jedcunningham merged pull request #18249: Add support for securityContext per deployment

2021-12-17 Thread GitBox
jedcunningham merged pull request #18249: URL: https://github.com/apache/airflow/pull/18249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] e-compagno commented on issue #11134: Not able to delete the DAG from UI -

2021-12-17 Thread GitBox
e-compagno commented on issue #11134: URL: https://github.com/apache/airflow/issues/11134#issuecomment-996930194 with airflow 2.1.3 I get the error ``` Traceback (most recent call last): File "/home/airflow/.local/lib/python3.8/site-packages/sqlalchemy/engine/base.py", line

[GitHub] [airflow] ashb commented on a change in pull request #20378: Reduce deprecation warnings from www

2021-12-17 Thread GitBox
ashb commented on a change in pull request #20378: URL: https://github.com/apache/airflow/pull/20378#discussion_r771599221 ## File path: tests/www/test_app.py ## @@ -240,7 +240,8 @@ def test_should_set_permanent_session_timeout(self): @conf_vars({('webserver', 'cookie_same

[GitHub] [airflow] ashb commented on a change in pull request #20034: Fix MyPy errors for Airflow decorators

2021-12-17 Thread GitBox
ashb commented on a change in pull request #20034: URL: https://github.com/apache/airflow/pull/20034#discussion_r771596266 ## File path: airflow/providers/docker/decorators/docker.py ## @@ -79,7 +79,7 @@ def __init__( command=command, retrieve_output=True, retriev

[GitHub] [airflow] pierrejeambrun commented on pull request #20386: Add support for BeamGoPipelineOperator

2021-12-17 Thread GitBox
pierrejeambrun commented on pull request #20386: URL: https://github.com/apache/airflow/pull/20386#issuecomment-996922608 Just amended for fix static checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [airflow] potiuk commented on pull request #20338: Breeze2 build ci image

2021-12-17 Thread GitBox
potiuk commented on pull request #20338: URL: https://github.com/apache/airflow/pull/20338#issuecomment-996910053 > I am trying to implement running this command via python with build_args in this code as BuildParams(dataclass). Am i going in right direction? Oh yeah. That's the beas

[GitHub] [airflow] potiuk edited a comment on pull request #16110: Added windows extensions

2021-12-17 Thread GitBox
potiuk edited a comment on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-996909103 > Did another rebase +1 I told you it gets the easier, the more often you do it ;) -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771580567 ## File path: airflow/models/baseoperator.py ## @@ -792,6 +854,8 @@ def __setattr__(self, key, value): if self._lock_for_execution: #

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771580567 ## File path: airflow/models/baseoperator.py ## @@ -792,6 +854,8 @@ def __setattr__(self, key, value): if self._lock_for_execution: #

[GitHub] [airflow] potiuk commented on pull request #16110: Added windows extensions

2021-12-17 Thread GitBox
potiuk commented on pull request #16110: URL: https://github.com/apache/airflow/pull/16110#issuecomment-996909103 > Did another rebase +1 I tld you it gets the easier, the more you do it ;) -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771580120 ## File path: airflow/models/baseoperator.py ## @@ -196,16 +216,37 @@ def apply_defaults(self, *args: Any, **kwargs: Any) -> Any: self._BaseO

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771579755 ## File path: airflow/models/baseoperator.py ## @@ -196,16 +216,37 @@ def apply_defaults(self, *args: Any, **kwargs: Any) -> Any: self._BaseO

[GitHub] [airflow] potiuk commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
potiuk commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771564179 ## File path: airflow/models/baseoperator.py ## @@ -110,12 +126,13 @@ def _apply_defaults(cls, func: T) -> T: # per decoration, i.e. each functi

[GitHub] [airflow] ashb commented on a change in pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2021-12-17 Thread GitBox
ashb commented on a change in pull request #19965: URL: https://github.com/apache/airflow/pull/19965#discussion_r771576601 ## File path: airflow/utils/task_group.py ## @@ -348,10 +382,35 @@ def build_map(task_group): build_map(self) return task_group_map -

[GitHub] [airflow] dstandish closed pull request #20385: Rename AwsRedshiftClusterSensor to RedshiftClusterSensor

2021-12-17 Thread GitBox
dstandish closed pull request #20385: URL: https://github.com/apache/airflow/pull/20385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] pierrejeambrun opened a new pull request #20386: Add support for BeamGoPipelineOperator

2021-12-17 Thread GitBox
pierrejeambrun opened a new pull request #20386: URL: https://github.com/apache/airflow/pull/20386 closes: https://github.com/apache/airflow/issues/20283 In this PR: - [x] Upgrade the minimum package requirement to 2.33.0 for apache-beam (first stable for beam go sdk) - [x] R

[GitHub] [airflow] eladkal commented on pull request #20385: Rename AwsRedshiftClusterSensor to RedshiftClusterSensor

2021-12-17 Thread GitBox
eladkal commented on pull request #20385: URL: https://github.com/apache/airflow/pull/20385#issuecomment-996885649 already handled in https://github.com/apache/airflow/pull/20374 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [airflow] subkanthi commented on a change in pull request #20381: Fix kubernetes type hints

2021-12-17 Thread GitBox
subkanthi commented on a change in pull request #20381: URL: https://github.com/apache/airflow/pull/20381#discussion_r771544019 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -321,19 +322,24 @@ def _exec_pod_command(self, resp, command: str) -> None

[GitHub] [airflow] dstandish commented on pull request #20385: Rename AwsRedshiftClusterSensor to RedshiftClusterSensor

2021-12-17 Thread GitBox
dstandish commented on pull request #20385: URL: https://github.com/apache/airflow/pull/20385#issuecomment-996872632 Never done a rename before. Not sure if we need to update anything else such as provider docs or updating.md. There were no references to this class that I could find in th

[GitHub] [airflow] dstandish opened a new pull request #20385: Rename AwsRedshiftClusterSensor to RedshiftClusterSensor

2021-12-17 Thread GitBox
dstandish opened a new pull request #20385: URL: https://github.com/apache/airflow/pull/20385 See issue https://github.com/apache/airflow/issues/20296 for more details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] subkanthi commented on a change in pull request #20381: Fix kubernetes type hints

2021-12-17 Thread GitBox
subkanthi commented on a change in pull request #20381: URL: https://github.com/apache/airflow/pull/20381#discussion_r771544019 ## File path: airflow/providers/cncf/kubernetes/utils/pod_launcher.py ## @@ -321,19 +322,24 @@ def _exec_pod_command(self, resp, command: str) -> None

[GitHub] [airflow] PApostol opened a new issue #20384: DagRun for with run_id or execution_date of 'manual__XXXXX' not found

2021-12-17 Thread GitBox
PApostol opened a new issue #20384: URL: https://github.com/apache/airflow/issues/20384 ### Apache Airflow version 2.2.2 (latest released) ### What happened After upgrading from Airflow 2.1.4 to 2.2.2, every DAG gives this error upon execution: > [2021-12-17, 15:

[GitHub] [airflow] josh-fell commented on issue #19409: container_client.create_container() fails when using Container level SAS token (but fine with Storage level SAS token)

2021-12-17 Thread GitBox
josh-fell commented on issue #19409: URL: https://github.com/apache/airflow/issues/19409#issuecomment-996865414 @eladkal Can you assign this to me? I'm going to whip something up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [airflow] alex-astronomer commented on issue #20383: Azure Key Vault Backend Typo

2021-12-17 Thread GitBox
alex-astronomer commented on issue #20383: URL: https://github.com/apache/airflow/issues/20383#issuecomment-996864383 Scratch that, I was using a deprecated module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] alex-astronomer closed issue #20383: Azure Key Vault Backend Typo

2021-12-17 Thread GitBox
alex-astronomer closed issue #20383: URL: https://github.com/apache/airflow/issues/20383 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [airflow] eladkal commented on a change in pull request #20374: Standardize AWS Redshift naming

2021-12-17 Thread GitBox
eladkal commented on a change in pull request #20374: URL: https://github.com/apache/airflow/pull/20374#discussion_r771535786 ## File path: airflow/providers/amazon/aws/sensors/redshift_cluster.py ## @@ -58,3 +58,19 @@ def get_hook(self) -> RedshiftHook: self.hook =

[GitHub] [airflow] eladkal commented on a change in pull request #20374: Standardize AWS Redshift naming

2021-12-17 Thread GitBox
eladkal commented on a change in pull request #20374: URL: https://github.com/apache/airflow/pull/20374#discussion_r771535786 ## File path: airflow/providers/amazon/aws/sensors/redshift_cluster.py ## @@ -58,3 +58,19 @@ def get_hook(self) -> RedshiftHook: self.hook =

[GitHub] [airflow] kazanzhy edited a comment on pull request #20355: Set default logger in logging Mixin

2021-12-17 Thread GitBox
kazanzhy edited a comment on pull request #20355: URL: https://github.com/apache/airflow/pull/20355#issuecomment-996860306 I just added one more check and seems ok This check ok with my future purposes and work almost as `try ... except AttributeError` -- This is an automated message

  1   2   3   >