[GitHub] [airflow] uranusjr commented on pull request #20664: Switch to buildx to build airflow images

2022-01-04 Thread GitBox
uranusjr commented on pull request #20664: URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005457445 I’m not too familiar with buildx in the first palce and will dismiss my request for review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #20338: URL: https://github.com/apache/airflow/pull/20338#issuecomment-1005457194 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r778608790 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,12 +93,103 @@ def shell(verbose: bool): @option_verbose -@main.command() -def

[GitHub] [airflow] uranusjr opened a new pull request #20669: Fix ECSProtocol compat shim inheritance

2022-01-04 Thread GitBox
uranusjr opened a new pull request #20669: URL: https://github.com/apache/airflow/pull/20669 Tests are failing: ``` TypeError: Protocols can only inherit from other protocols, got ``` This is due to the compatibility shim for `ECSProtocol` is incorrectly

[airflow] branch main updated (b83084b -> 64c0bd5)

2022-01-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from b83084b Add filter by state in DagRun REST API (List Dag Runs) (#20485) add 64c0bd5 bugfix: deferred

[GitHub] [airflow] ephraimbuddy closed issue #20580: Triggers are not terminated when DAG is mark failed

2022-01-04 Thread GitBox
ephraimbuddy closed issue #20580: URL: https://github.com/apache/airflow/issues/20580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ephraimbuddy merged pull request #20649: bugfix: deferred tasks does not cancel when DAG is marked fail

2022-01-04 Thread GitBox
ephraimbuddy merged pull request #20649: URL: https://github.com/apache/airflow/pull/20649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on a change in pull request #20360: Standardize DynamoDB naming

2022-01-04 Thread GitBox
eladkal commented on a change in pull request #20360: URL: https://github.com/apache/airflow/pull/20360#discussion_r778603523 ## File path: airflow/providers/amazon/aws/hooks/dynamodb.py ## @@ -18,13 +18,14 @@ """This module contains the AWS DynamoDB hook""" +import

[GitHub] [airflow] eladkal commented on a change in pull request #20369: Standardize AWS Batch naming

2022-01-04 Thread GitBox
eladkal commented on a change in pull request #20369: URL: https://github.com/apache/airflow/pull/20369#discussion_r778602745 ## File path: airflow/providers/amazon/aws/operators/batch.py ## @@ -26,17 +26,18 @@ -

[GitHub] [airflow] pingzh commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778598911 ## File path: tests/utils/test_operator_helpers.py ## @@ -71,6 +71,29 @@ def test_context_to_airflow_vars_all_context(self):

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r778596878 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,12 +93,103 @@ def shell(verbose: bool): @option_verbose -@main.command() -def

[GitHub] [airflow] uranusjr commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
uranusjr commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778592427 ## File path: tests/utils/test_operator_helpers.py ## @@ -71,6 +71,29 @@ def test_context_to_airflow_vars_all_context(self):

[GitHub] [airflow] potiuk commented on pull request #20664: Switch to buildx to build airflow images

2022-01-04 Thread GitBox
potiuk commented on pull request #20664: URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005438706 cc: @Bowrna @edithturn - > that will make your job much easier, it simplifies a lot of the "caching" complexity - that's why I did not want you to start looking at it before

[GitHub] [airflow] uranusjr commented on pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
uranusjr commented on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-1005438826 Oh, the last one is from your change though; you’re using `with pytest.raises(TypeError) as error` incorrectly. -- This is an automated message from the Apache Git

[GitHub] [airflow] uranusjr commented on pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
uranusjr commented on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-1005437824 Looks unrelated, probably someone merged some bad code to main. I’ll investigate separately. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk closed pull request #20238: Optimize dockerfiles for local rebuilds

2022-01-04 Thread GitBox
potiuk closed pull request #20238: URL: https://github.com/apache/airflow/pull/20238 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #20664: Switch to buildx to build airflow images

2022-01-04 Thread GitBox
potiuk commented on pull request #20664: URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005437311 This is a VAST simplification of our docker build caching (using modern BuildKit plugin). I have to do some more testing with it, but on top of removing several hundreds of

[GitHub] [airflow] uranusjr commented on a change in pull request #20651: Fix mypy in providers/grpc and providers/imap

2022-01-04 Thread GitBox
uranusjr commented on a change in pull request #20651: URL: https://github.com/apache/airflow/pull/20651#discussion_r778589556 ## File path: airflow/providers/imap/hooks/imap.py ## @@ -71,7 +71,7 @@ def get_conn(self) -> 'ImapHook': """ if not

[GitHub] [airflow] Greetlist commented on issue #20308: Multi Schedulers don't synchronize task instance state when using Triggerer

2022-01-04 Thread GitBox
Greetlist commented on issue #20308: URL: https://github.com/apache/airflow/issues/20308#issuecomment-1005435631 At this moment, I solve this problem by this: ![image](https://user-images.githubusercontent.com/18439743/148174419-5f27d495-ef6c-4a08-b262-c41ada4725ad.png) Pass

[airflow] branch main updated (9c0ba1b -> b83084b)

2022-01-04 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 9c0ba1b Standardize AWS ECS naming (#20332) add b83084b Add filter by state in DagRun REST API (List Dag

[GitHub] [airflow] potiuk opened a new pull request #20664: Switch to buildx to build airflow images

2022-01-04 Thread GitBox
potiuk opened a new pull request #20664: URL: https://github.com/apache/airflow/pull/20664 The "buildkit" is much more modern docker build mechanism and supports multiarchitecture builds which makes it suitable for our future ARM support, it also has nicer UI and much more

[GitHub] [airflow] pingzh edited a comment on pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh edited a comment on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-1005433855 @potiuk @uranusjr any ideas about this error? https://github.com/apache/airflow/runs/4711391810?check_suite_focus=true#step:8:8255

[GitHub] [airflow] pingzh edited a comment on pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh edited a comment on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-1005433855 @potiuk @uranusjr any ideas about this error? https://github.com/apache/airflow/runs/4711391810?check_suite_focus=true#step:8:8255

[GitHub] [airflow] pingzh commented on pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh commented on pull request #20361: URL: https://github.com/apache/airflow/pull/20361#issuecomment-1005433855 @potiuk @uranusjr any ideas about this error? ![image](https://user-images.githubusercontent.com/8662365/148174829-d9be104f-773e-44df-8243-3a24f36f72a3.png) I

[GitHub] [airflow] uranusjr merged pull request #20485: Add filter by state in DagRun REST API (List Dag Runs)

2022-01-04 Thread GitBox
uranusjr merged pull request #20485: URL: https://github.com/apache/airflow/pull/20485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20485: Add filter by state in DagRun REST API (List Dag Runs)

2022-01-04 Thread GitBox
boring-cyborg[bot] commented on pull request #20485: URL: https://github.com/apache/airflow/pull/20485#issuecomment-1005429527 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] pingzh commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778558416 ## File path: airflow/utils/operator_helpers.py ## @@ -77,6 +87,21 @@ def context_to_airflow_vars(context: Mapping[str, Any], in_env_var_format: bool

[GitHub] [airflow] github-actions[bot] commented on pull request #20656: Update base sensor operator to support XCOM return value

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #20656: URL: https://github.com/apache/airflow/pull/20656#issuecomment-1005398080 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] uranusjr commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
uranusjr commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778554258 ## File path: airflow/utils/operator_helpers.py ## @@ -77,6 +87,21 @@ def context_to_airflow_vars(context: Mapping[str, Any], in_env_var_format: bool

[GitHub] [airflow] github-actions[bot] commented on pull request #20657: Clarify variable names and use cleaner set diff syntax

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #20657: URL: https://github.com/apache/airflow/pull/20657#issuecomment-1005392592 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] jedcunningham closed pull request #20661: Chart: 1.4.0 changelog

2022-01-04 Thread GitBox
jedcunningham closed pull request #20661: URL: https://github.com/apache/airflow/pull/20661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on issue #20320: Airflow API throwing 500 when user does not have last name

2022-01-04 Thread GitBox
uranusjr commented on issue #20320: URL: https://github.com/apache/airflow/issues/20320#issuecomment-1005381988 Go ahead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] github-actions[bot] commented on pull request #20663: Allow Viewing DagRuns and TIs if a user has DAG "read" perms

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #20663: URL: https://github.com/apache/airflow/pull/20663#issuecomment-1005381486 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] arsalanfardi commented on issue #20320: Airflow API throwing 500 when user does not have last name

2022-01-04 Thread GitBox
arsalanfardi commented on issue #20320: URL: https://github.com/apache/airflow/issues/20320#issuecomment-1005381384 Can I take this up as my first issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] uranusjr commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
uranusjr commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778544900 ## File path: airflow/decorators/sensor.py ## @@ -0,0 +1,89 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] kaxil commented on pull request #20663: Allow Viewing DagRuns and TIs if a user has DAG "read" perms

2022-01-04 Thread GitBox
kaxil commented on pull request #20663: URL: https://github.com/apache/airflow/pull/20663#issuecomment-1005377013 @Jorricks Can you take a look at it please? This PR still respects the table you had in the PR description for https://github.com/apache/airflow/pull/16634 but allow viewing

[GitHub] [airflow] kaxil opened a new pull request #20663: Allow Viewing DagRuns and TIs if a user has DAG "read" perms

2022-01-04 Thread GitBox
kaxil opened a new pull request #20663: URL: https://github.com/apache/airflow/pull/20663 This was updated in Airflow 2.2.0 via https://github.com/apache/airflow/pull/16634 which restricts a user to even views the DagRuns and TI records if they don't have "edit" permissions on DAG even

[GitHub] [airflow] pingzh commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778523450 ## File path: airflow/utils/operator_helpers.py ## @@ -75,6 +86,19 @@ def context_to_airflow_vars(context: Mapping[str, Any], in_env_var_format: bool

[GitHub] [airflow] uranusjr commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
uranusjr commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778521753 ## File path: airflow/utils/operator_helpers.py ## @@ -75,6 +86,16 @@ def context_to_airflow_vars(context: Mapping[str, Any], in_env_var_format: bool

[GitHub] [airflow] uranusjr commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
uranusjr commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778521582 ## File path: airflow/utils/operator_helpers.py ## @@ -75,6 +86,19 @@ def context_to_airflow_vars(context: Mapping[str, Any], in_env_var_format: bool

[GitHub] [airflow] github-actions[bot] commented on pull request #20659: Disabled edit button in task instances list view page

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #20659: URL: https://github.com/apache/airflow/pull/20659#issuecomment-1005347651 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] github-actions[bot] commented on pull request #19965: Map and Partial DAG authoring interface for Dynamic Task Mapping

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #19965: URL: https://github.com/apache/airflow/pull/19965#issuecomment-1005326870 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and

[GitHub] [airflow] pingzh commented on a change in pull request #20361: Add context var hook to inject more env vars

2022-01-04 Thread GitBox
pingzh commented on a change in pull request #20361: URL: https://github.com/apache/airflow/pull/20361#discussion_r778486378 ## File path: airflow/utils/operator_helpers.py ## @@ -75,6 +86,16 @@ def context_to_airflow_vars(context: Mapping[str, Any], in_env_var_format: bool

[GitHub] [airflow] Bowrna commented on a change in pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
Bowrna commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r778483376 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] jedcunningham opened a new pull request #20661: Chart: 1.4.0 changelog

2022-01-04 Thread GitBox
jedcunningham opened a new pull request #20661: URL: https://github.com/apache/airflow/pull/20661 Add changelog for chart version 1.4.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] kazanzhy commented on a change in pull request #20642: Added Hook for Amazon RDS

2022-01-04 Thread GitBox
kazanzhy commented on a change in pull request #20642: URL: https://github.com/apache/airflow/pull/20642#discussion_r778472926 ## File path: airflow/providers/amazon/aws/hooks/rds.py ## @@ -0,0 +1,165 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] kazanzhy removed a comment on pull request #20642: Added Hook for Amazon RDS

2022-01-04 Thread GitBox
kazanzhy removed a comment on pull request #20642: URL: https://github.com/apache/airflow/pull/20642#issuecomment-1005276831 A lot of thanks that clarifying the way to implementation @dstandish The solutions below don't work and it's expected ``` from typing import Type

[GitHub] [airflow] kazanzhy commented on a change in pull request #20642: Added Hook for Amazon RDS

2022-01-04 Thread GitBox
kazanzhy commented on a change in pull request #20642: URL: https://github.com/apache/airflow/pull/20642#discussion_r778472926 ## File path: airflow/providers/amazon/aws/hooks/rds.py ## @@ -0,0 +1,165 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] kazanzhy commented on pull request #20642: Added Hook for Amazon RDS

2022-01-04 Thread GitBox
kazanzhy commented on pull request #20642: URL: https://github.com/apache/airflow/pull/20642#issuecomment-1005276831 A lot of thanks that clarifying the way to implementation @dstandish The solutions below don't work and it's expected ``` from typing import Type from

[GitHub] [airflow] ferruzzi closed pull request #20369: Standardize AWS Batch naming

2022-01-04 Thread GitBox
ferruzzi closed pull request #20369: URL: https://github.com/apache/airflow/pull/20369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ferruzzi commented on pull request #20374: Standardize AWS Redshift naming

2022-01-04 Thread GitBox
ferruzzi commented on pull request #20374: URL: https://github.com/apache/airflow/pull/20374#issuecomment-1005268141 This one is throwing the Protocol inheritance error that I mentioned in the other PR: https://github.com/apache/airflow/runs/4708697673?check_suite_focus=true#step:8:8489

[GitHub] [airflow] ferruzzi edited a comment on pull request #20374: Standardize AWS Redshift naming

2022-01-04 Thread GitBox
ferruzzi edited a comment on pull request #20374: URL: https://github.com/apache/airflow/pull/20374#issuecomment-1005258276 rebased and I think I covered https://github.com/apache/airflow/pull/20374#discussion_r771918489 -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] ferruzzi commented on pull request #20374: Standardize AWS Redshift naming

2022-01-04 Thread GitBox
ferruzzi commented on pull request #20374: URL: https://github.com/apache/airflow/pull/20374#issuecomment-1005258276 rebased and I think I covered https://github.com/apache/airflow/pull/20374#discussion_r771535786 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] ferruzzi commented on a change in pull request #20360: Standardize DynamoDB naming

2022-01-04 Thread GitBox
ferruzzi commented on a change in pull request #20360: URL: https://github.com/apache/airflow/pull/20360#discussion_r778457959 ## File path: airflow/providers/amazon/aws/hooks/dynamodb.py ## @@ -18,13 +18,14 @@ """This module contains the AWS DynamoDB hook""" +import

[GitHub] [airflow] williamfmr commented on issue #20320: Airflow API throwing 500 when user does not have last name

2022-01-04 Thread GitBox
williamfmr commented on issue #20320: URL: https://github.com/apache/airflow/issues/20320#issuecomment-1005250016 @potiuk, unfortunately my employer does not allow for contributing code to external projects. I have removed myself from this ticket. Very sorry :( -- This is an automated

[GitHub] [airflow] yehoshuadimarsky opened a new issue #20660: Exception unfairly raised in SQL Operator when using Application Default Credentials with Workload Identity for Cloud SQL Auth proxy

2022-01-04 Thread GitBox
yehoshuadimarsky opened a new issue #20660: URL: https://github.com/apache/airflow/issues/20660 ### Apache Airflow Provider(s) google ### Versions of Apache Airflow Providers ``` apache-airflow-providers-amazon==2.3.0 apache-airflow-providers-celery==2.1.0

[GitHub] [airflow] dimon222 commented on issue #20615: Status of testing Providers that were prepared on December 31, 2021

2022-01-04 Thread GitBox
dimon222 commented on issue #20615: URL: https://github.com/apache/airflow/issues/20615#issuecomment-1005238859 #19726 briefly tested, seems to work as intended and not raising any problems. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] tikikun commented on issue #15635: ARM64 support in docker images

2022-01-04 Thread GitBox
tikikun commented on issue #15635: URL: https://github.com/apache/airflow/issues/15635#issuecomment-1005236541 Has anyone done this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] subkanthi opened a new pull request #20659: Disabled edit button in task instances list view page

2022-01-04 Thread GitBox
subkanthi opened a new pull request #20659: URL: https://github.com/apache/airflow/pull/20659 closes: #20655 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] subkanthi commented on issue #20655: Edit Task Instance Page does not save updates.

2022-01-04 Thread GitBox
subkanthi commented on issue #20655: URL: https://github.com/apache/airflow/issues/20655#issuecomment-1005214394 I can take a look at this to disable the edit option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ferruzzi opened a new pull request #20369: Standardize AWS Batch naming

2022-01-04 Thread GitBox
ferruzzi opened a new pull request #20369: URL: https://github.com/apache/airflow/pull/20369 Part of https://github.com/apache/airflow/issues/20296 In addition: - Fixed capitalization in some comments from `batch` to `Batch` where applicable. - Changed `execute(None)` and

[GitHub] [airflow] ferruzzi closed pull request #20369: Standardize AWS Batch naming

2022-01-04 Thread GitBox
ferruzzi closed pull request #20369: URL: https://github.com/apache/airflow/pull/20369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] turbaszek commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
turbaszek commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778391201 ## File path: airflow/decorators/__init__.py ## @@ -29,9 +30,11 @@ def __getattr__(self, name): if name.startswith("__"): raise

[GitHub] [airflow] ferruzzi commented on a change in pull request #20369: Standardize AWS Batch naming

2022-01-04 Thread GitBox
ferruzzi commented on a change in pull request #20369: URL: https://github.com/apache/airflow/pull/20369#discussion_r778387027 ## File path: airflow/providers/amazon/aws/hooks/batch_client.py ## @@ -538,3 +538,35 @@ def exp(tries): delay = 1 + pow(tries * 0.6, 2)

[airflow] branch main updated (f864d14 -> 9c0ba1b)

2022-01-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from f864d14 Fix precedence of affinity, nodeSelector, and tolerations (#20641) add 9c0ba1b Standardize AWS ECS

[GitHub] [airflow] eladkal merged pull request #20332: Standardize AWS ECS naming

2022-01-04 Thread GitBox
eladkal merged pull request #20332: URL: https://github.com/apache/airflow/pull/20332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] mingshi-wang commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
mingshi-wang commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778380857 ## File path: airflow/decorators/__init__.py ## @@ -29,9 +30,11 @@ def __getattr__(self, name): if name.startswith("__"):

[GitHub] [airflow] eladkal commented on a change in pull request #20369: Standardize AWS Batch naming

2022-01-04 Thread GitBox
eladkal commented on a change in pull request #20369: URL: https://github.com/apache/airflow/pull/20369#discussion_r778378157 ## File path: airflow/providers/amazon/aws/hooks/batch_client.py ## @@ -538,3 +538,35 @@ def exp(tries): delay = 1 + pow(tries * 0.6, 2)

[GitHub] [airflow] eladkal closed issue #17010: Add support for custom Trigger Rule logic

2022-01-04 Thread GitBox
eladkal closed issue #17010: URL: https://github.com/apache/airflow/issues/17010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] eladkal commented on issue #17010: Add support for custom Trigger Rule logic

2022-01-04 Thread GitBox
eladkal commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-1005155935 So I'm closing this issue for now. If needed we can revisit in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #20332: Standardize AWS ECS naming

2022-01-04 Thread GitBox
github-actions[bot] commented on pull request #20332: URL: https://github.com/apache/airflow/pull/20332#issuecomment-1005153877 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] turbaszek commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
turbaszek commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778373053 ## File path: airflow/decorators/__init__.py ## @@ -29,9 +30,11 @@ def __getattr__(self, name): if name.startswith("__"): raise

[GitHub] [airflow] turbaszek commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
turbaszek commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778373053 ## File path: airflow/decorators/__init__.py ## @@ -29,9 +30,11 @@ def __getattr__(self, name): if name.startswith("__"): raise

[airflow] branch main updated (298435a -> f864d14)

2022-01-04 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 298435a Add a button to set all tasks to skipped (#20455) add f864d14 Fix precedence of affinity,

[GitHub] [airflow] jedcunningham merged pull request #20641: Fix precedence of affinity, nodeSelector, and tolerations

2022-01-04 Thread GitBox
jedcunningham merged pull request #20641: URL: https://github.com/apache/airflow/pull/20641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham closed issue #20538: Change Helm Chart tolerations logic when combining multiple parts of values.yaml

2022-01-04 Thread GitBox
jedcunningham closed issue #20538: URL: https://github.com/apache/airflow/issues/20538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] malthe commented on issue #17010: Add support for custom Trigger Rule logic

2022-01-04 Thread GitBox
malthe commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-1005149267 I think the boolean combination idea is a good one – and probably @potiuk is right that throwing time in the mix is a bad one. That said, if it ain't broke don't fix it and

[GitHub] [airflow] mingshi-wang commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
mingshi-wang commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778344613 ## File path: airflow/decorators/__init__.py ## @@ -29,9 +30,11 @@ def __getattr__(self, name): if name.startswith("__"):

[GitHub] [airflow] turbaszek commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
turbaszek commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778334782 ## File path: docs/apache-airflow/tutorial_taskflow_api.rst ## @@ -208,6 +208,51 @@ Python version to run your function. These two options should

[GitHub] [airflow] ferruzzi commented on pull request #20332: Standardize AWS ECS naming

2022-01-04 Thread GitBox
ferruzzi commented on pull request #20332: URL: https://github.com/apache/airflow/pull/20332#issuecomment-1005107559 Huh. Neither can I now.I've rebased and removed the `Protocol` inheritance on L546. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] turbaszek commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
turbaszek commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778333159 ## File path: airflow/decorators/__init__.py ## @@ -29,9 +30,11 @@ def __getattr__(self, name): if name.startswith("__"): raise

[GitHub] [airflow] dstandish opened a new pull request #20658: Rename `to_delete` to `to_cancel` in TriggerRunner

2022-01-04 Thread GitBox
dstandish opened a new pull request #20658: URL: https://github.com/apache/airflow/pull/20658 The queue's purpose is to track triggers that need to be canceled. I found the language `to_delete` a bit confusing because for one it does not actually delete them but cancel them. The deletion

[GitHub] [airflow] rdeteix commented on issue #16010: Helm chart: How to enable HTTPS connection

2022-01-04 Thread GitBox
rdeteix commented on issue #16010: URL: https://github.com/apache/airflow/issues/16010#issuecomment-1005086285 Thx for the response. I've already tried it. Which k8s version are you working with ? I also tried it without the reverse proxy : ``` ingress:

[GitHub] [airflow] dstandish opened a new pull request #20657: Clarify variable names and use cleaner set diff syntax

2022-01-04 Thread GitBox
dstandish opened a new pull request #20657: URL: https://github.com/apache/airflow/pull/20657 The word 'old' could suggest 'triggers we already have' i.e. 'current triggers' as compared with the 'requested' triggers, or with 'triggers we need to create' a.k.a. new triggers. However,

[GitHub] [airflow] potiuk commented on issue #17010: Add support for custom Trigger Rule logic

2022-01-04 Thread GitBox
potiuk commented on issue #17010: URL: https://github.com/apache/airflow/issues/17010#issuecomment-1005074924 Agree with @eladkal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] mingshi-wang commented on a change in pull request #20530: Add sensor decorator

2022-01-04 Thread GitBox
mingshi-wang commented on a change in pull request #20530: URL: https://github.com/apache/airflow/pull/20530#discussion_r778301416 ## File path: airflow/decorators/sensor.py ## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r778300726 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,12 +93,103 @@ def shell(verbose: bool): @option_verbose -@main.command() -def

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r778300726 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -95,12 +93,103 @@ def shell(verbose: bool): @option_verbose -@main.command() -def

[GitHub] [airflow] mingshi-wang opened a new pull request #20656: Update base sensor operator to support XCOM return value

2022-01-04 Thread GitBox
mingshi-wang opened a new pull request #20656: URL: https://github.com/apache/airflow/pull/20656 Updated the base sensor operator such that an optional XCom value can be returned and pushed when the operator is executed. Users only need to override the poke() method to return a

[GitHub] [airflow] jedcunningham commented on issue #19038: Race condition when running multiple schedulers

2022-01-04 Thread GitBox
jedcunningham commented on issue #19038: URL: https://github.com/apache/airflow/issues/19038#issuecomment-1005065182 This should be fixed on 2.2.3 via #19904. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] jedcunningham closed issue #19038: Race condition when running multiple schedulers

2022-01-04 Thread GitBox
jedcunningham closed issue #19038: URL: https://github.com/apache/airflow/issues/19038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a change in pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
potiuk commented on a change in pull request #20338: URL: https://github.com/apache/airflow/pull/20338#discussion_r778296569 ## File path: dev/breeze/src/airflow_breeze/cache.py ## @@ -0,0 +1,67 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] pierrejeambrun commented on a change in pull request #20386: Add support for BeamGoPipelineOperator

2022-01-04 Thread GitBox
pierrejeambrun commented on a change in pull request #20386: URL: https://github.com/apache/airflow/pull/20386#discussion_r778291137 ## File path: airflow/providers/apache/beam/operators/beam.py ## @@ -470,3 +529,144 @@ def on_kill(self) -> None:

[GitHub] [airflow] mobuchowski commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

2022-01-04 Thread GitBox
mobuchowski commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r778287426 ## File path: airflow/listeners/spec.py ## @@ -0,0 +1,49 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] mobuchowski commented on a change in pull request #20443: Add Listener Plugin API that tracks TaskInstance state changes

2022-01-04 Thread GitBox
mobuchowski commented on a change in pull request #20443: URL: https://github.com/apache/airflow/pull/20443#discussion_r778286692 ## File path: airflow/jobs/local_task_job.py ## @@ -71,6 +74,8 @@ def __init__( # terminate multiple times self.terminating =

[GitHub] [airflow] Bowrna commented on pull request #20645: config command to toggle asciiart, cheatsheet

2022-01-04 Thread GitBox
Bowrna commented on pull request #20645: URL: https://github.com/apache/airflow/pull/20645#issuecomment-1005051028 @potiuk Could you also share your feedback on the files modified? This PR is still in draft state, but your feedback at this point would be useful -- This is an automated

[GitHub] [airflow] Bowrna commented on pull request #20338: Breeze2 build ci image

2022-01-04 Thread GitBox
Bowrna commented on pull request #20338: URL: https://github.com/apache/airflow/pull/20338#issuecomment-1005049302 > Loooks very, very close @Bowrna - just two comments left, I can merge and then I can add test case example @potiuk Could you share your reviews on the last two

[airflow] branch main updated (27fcd7e -> 298435a)

2022-01-04 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 27fcd7e [New] - Ci free space python (#20200) add 298435a Add a button to set all tasks to skipped (#20455)

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #20455: Add a button to set all tasks to skipped

2022-01-04 Thread GitBox
boring-cyborg[bot] commented on pull request #20455: URL: https://github.com/apache/airflow/pull/20455#issuecomment-1005045964 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] bbovenzi merged pull request #20455: Add a button to set all tasks to skipped

2022-01-04 Thread GitBox
bbovenzi merged pull request #20455: URL: https://github.com/apache/airflow/pull/20455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

  1   2   3   >