uranusjr merged pull request #20648:
URL: https://github.com/apache/airflow/pull/20648
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
uranusjr pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 64c0bd5 bugfix: deferred tasks does not cancel when DAG is marked
fail (#20649)
add a0cad07 Better error whe
uranusjr commented on issue #20419:
URL: https://github.com/apache/airflow/issues/20419#issuecomment-1005463171
Since new documentation for this would be targeting 2.3+ anyway, using
`from_email` is fine IMO.
Casing does not matter in config keys, `from_email` is entirely equivalent
uranusjr commented on a change in pull request #20527:
URL: https://github.com/apache/airflow/pull/20527#discussion_r778623392
##
File path: tests/providers/airbyte/hooks/test_airbyte.py
##
@@ -87,7 +87,7 @@ def test_wait_for_job_error(self, mock_get_job):
self.hoo
github-actions[bot] commented on pull request #19571:
URL: https://github.com/apache/airflow/pull/19571#issuecomment-1005484043
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not
github-actions[bot] commented on pull request #20639:
URL: https://github.com/apache/airflow/pull/20639#issuecomment-1005484348
The PR is likely ready to be merged. No tests are needed as no important
environment files, nor python files were modified by it. However, committers
might decide
kaxil merged pull request #20639:
URL: https://github.com/apache/airflow/pull/20639
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from a0cad07 Better error when param value has unexpected type (#20648)
add e8b5ab9 Docs: Clarify ``sentry_on`` v
github-actions[bot] commented on pull request #20661:
URL: https://github.com/apache/airflow/pull/20661#issuecomment-1005501861
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not
eladkal opened a new pull request #20670:
URL: https://github.com/apache/airflow/pull/20670
related: https://github.com/apache/airflow/pull/20332
fix test failures:
```
E TypeError: Protocols can only inherit from other
protocols, got
/usr/local/lib/
kazanzhy commented on a change in pull request #20651:
URL: https://github.com/apache/airflow/pull/20651#discussion_r778661904
##
File path: airflow/providers/imap/hooks/imap.py
##
@@ -71,7 +71,7 @@ def get_conn(self) -> 'ImapHook':
"""
if not self.mail_client
kaxil commented on a change in pull request #20657:
URL: https://github.com/apache/airflow/pull/20657#discussion_r778662088
##
File path: airflow/jobs/triggerer_job.py
##
@@ -382,8 +382,8 @@ def update_triggers(self, requested_trigger_ids: Set[int]):
# handling.
kaxil commented on pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#issuecomment-1005514664
oh .. there is https://github.com/apache/airflow/pull/20670 from @eladkal
too that address the same issue in a different way
--
This is an automated message from the Apache G
kaxil commented on pull request #20670:
URL: https://github.com/apache/airflow/pull/20670#issuecomment-1005514918
same as https://github.com/apache/airflow/pull/20669 .
cc @uranusjr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
github-actions[bot] commented on pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#issuecomment-1005515267
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and ta
eladkal commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778664620
##
File path: airflow/contrib/operators/ecs_operator.py
##
@@ -19,26 +19,12 @@
import warnings
-from airflow.providers.amazon.aws.operators.ecs imp
uranusjr commented on issue #19903:
URL: https://github.com/apache/airflow/issues/19903#issuecomment-1005535302
Oh I see what’s going on. This has nothing to do with the task function, but
the task _group_ function. Currently, the `@task_group` decorator is intended
to be used like this:
uranusjr opened a new pull request #20671:
URL: https://github.com/apache/airflow/pull/20671
Instead of always using the task returned by the task group function as the
dependency representation, also allow a task group function to *not* return any
task specifically.
Setting depende
kaxil closed pull request #20663:
URL: https://github.com/apache/airflow/pull/20663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
Jorricks commented on pull request #20663:
URL: https://github.com/apache/airflow/pull/20663#issuecomment-1005552396
Hey @kaxil,
Very nice addition. I agree that this improves the user experience.
Code looks good to me.
Thanks for the heads up!
--
This is an automated message fro
boring-cyborg[bot] commented on issue #20672:
URL: https://github.com/apache/airflow/issues/20672#issuecomment-1005553291
Thanks for opening your first issue here! Be sure to follow the issue
template!
--
This is an automated message from the Apache Git Service.
To respond to the mes
jon-evergreen opened a new issue #20672:
URL: https://github.com/apache/airflow/issues/20672
### Apache Airflow Provider(s)
amazon, postgres
### Versions of Apache Airflow Providers
apache-airflow-providers-amazon==2.4.0
apache-airflow-providers-postgres==2.4.0
ashb commented on pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005556253
Whats buildx vs buildkit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
potiuk commented on issue #20615:
URL: https://github.com/apache/airflow/issues/20615#issuecomment-1005556343
Last chance to make some quick testing :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
potiuk commented on pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005562336
> Whats buildx vs buildkit?
Essentially the same. Buildx is a plugin you can install in docker to get
more capabilities of buildkit available as "docker buildx build" co
potiuk edited a comment on pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005562336
> Whats buildx vs buildkit?
Essentially the same. Buildx is a plugin you can install in docker to get
more capabilities of buildkit available as "docker buildx bu
potiuk edited a comment on pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005562336
> Whats buildx vs buildkit?
Essentially the same. Buildx is a plugin you can install in docker to get
more capabilities of buildkit available as "docker buildx bu
potiuk edited a comment on pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005562336
> Whats buildx vs buildkit?
Essentially the same. Buildx is a plugin you can install in docker to get
more capabilities of buildkit available as "docker buildx bu
potiuk commented on pull request #20664:
URL: https://github.com/apache/airflow/pull/20664#issuecomment-1005567519
It also has all the nice things about building multi-platform images. The
nice thing about buldx is that you can have mutliple builders - for example
different builders for di
ashb opened a new pull request #20675:
URL: https://github.com/apache/airflow/pull/20675
The change to validate the subclassed executors in #18189 mistakenly
_required_ both celery and kubernetes libraries installed to run `airflow`.
Oopsie
---
**^ Add meaningful desc
potiuk commented on pull request #20238:
URL: https://github.com/apache/airflow/pull/20238#issuecomment-1005581275
Question: Should I try to split this one into smaller ones? Seems that it
did not get too much of interest so far. Maybe trying to split will help :D ?
--
This is an automat
potiuk commented on pull request #20338:
URL: https://github.com/apache/airflow/pull/20338#issuecomment-1005587584
Ah @Bowrna - one small thing - failing static check :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
github-actions[bot] commented on pull request #20675:
URL: https://github.com/apache/airflow/pull/20675#issuecomment-1005594416
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not
Melodie97 opened a new pull request #20677:
URL: https://github.com/apache/airflow/pull/20677
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more i
mobuchowski commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r778750727
##
File path: airflow/jobs/local_task_job.py
##
@@ -291,3 +296,13 @@ def _update_dagrun_state_for_paused_dag(self,
session=None):
if d
mobuchowski commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r778750799
##
File path: airflow/listeners/events.py
##
@@ -0,0 +1,73 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
mobuchowski commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r778751047
##
File path: airflow/listeners/listener.py
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contribu
mobuchowski commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r778751353
##
File path: airflow/listeners/listener.py
##
@@ -0,0 +1,84 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contribu
mobuchowski commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r778751491
##
File path: tests/jobs/test_scheduler_job.py
##
@@ -3434,6 +3435,12 @@ def test_timeout_triggers(self, dag_maker):
assert ti1.next_method
mobuchowski commented on a change in pull request #20443:
URL: https://github.com/apache/airflow/pull/20443#discussion_r778751767
##
File path: tests/listeners/test_listeners.py
##
@@ -0,0 +1,140 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more con
potiuk opened a new pull request #20678:
URL: https://github.com/apache/airflow/pull/20678
* removes PIP_INSTALL_USER variable
* upgrades PIP to 21.3.1
* removes AIRFLOW_INSTALL_USER_FLAG as it is not needed
* removes spurious usage of --upgrade flag for PIP
* adds better diagnos
subkanthi commented on pull request #20659:
URL: https://github.com/apache/airflow/pull/20659#issuecomment-1005620534
>
> Will this change allow clearing the TIs now from the List TIs page?
>
> Can you confirm, please?
Yes it does.
https://user-images.githubu
potiuk opened a new pull request #20679:
URL: https://github.com/apache/airflow/pull/20679
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more info
uranusjr commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778768017
##
File path: airflow/contrib/operators/ecs_operator.py
##
@@ -19,26 +19,12 @@
import warnings
-from airflow.providers.amazon.aws.operators.ecs im
uranusjr commented on a change in pull request #20678:
URL: https://github.com/apache/airflow/pull/20678#discussion_r778768590
##
File path: dev/README_RELEASE_PROVIDER_PACKAGES.md
##
@@ -611,9 +611,9 @@ provider packages. This is especially helpful when you want
to test integ
potiuk opened a new pull request #20680:
URL: https://github.com/apache/airflow/pull/20680
As discussed and lazy consensus achieved, we remove Python 2
from Airflow Reference images. This is the last remnant of
end-of-life Python2 which we only support by means of
using PythonVirtua
potiuk commented on a change in pull request #20678:
URL: https://github.com/apache/airflow/pull/20678#discussion_r778778319
##
File path: scripts/docker/install_airflow.sh
##
@@ -56,26 +56,26 @@ function install_airflow() {
pip uninstall apache-airflow --yes
turbaszek commented on a change in pull request #20530:
URL: https://github.com/apache/airflow/pull/20530#discussion_r778779137
##
File path: airflow/decorators/sensor.py
##
@@ -0,0 +1,89 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor li
kaxil closed pull request #20663:
URL: https://github.com/apache/airflow/pull/20663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
potiuk commented on a change in pull request #20678:
URL: https://github.com/apache/airflow/pull/20678#discussion_r778781006
##
File path: scripts/docker/install_pip_version.sh
##
@@ -30,11 +30,13 @@
. "$( dirname "${BASH_SOURCE[0]}" )/common.sh"
function install_pip_versio
potiuk commented on pull request #20678:
URL: https://github.com/apache/airflow/pull/20678#issuecomment-1005644993
All should be addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
ashb merged pull request #20675:
URL: https://github.com/apache/airflow/pull/20675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubsc
This is an automated email from the ASF dual-hosted git repository.
ash pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e8b5ab9 Docs: Clarify ``sentry_on`` value is not quoted with example
(#20639)
add 61b29d7 Don't import Celery or
mehmax commented on a change in pull request #19084:
URL: https://github.com/apache/airflow/pull/19084#discussion_r778804368
##
File path: airflow/providers/oracle/hooks/oracle.py
##
@@ -90,8 +91,19 @@ def get_conn(self) -> 'OracleHook':
dsn = conn.host
henriqueribeiro opened a new issue #20681:
URL: https://github.com/apache/airflow/issues/20681
### Apache Airflow version
2.1.4
### What happened
Recently I started to use TaskFlow API in some of my dag files where the
tasks are being dynamically generated and started t
boring-cyborg[bot] commented on issue #20681:
URL: https://github.com/apache/airflow/issues/20681#issuecomment-1005684020
Thanks for opening your first issue here! Be sure to follow the issue
template!
--
This is an automated message from the Apache Git Service.
To respond to the mes
potiuk commented on a change in pull request #20618:
URL: https://github.com/apache/airflow/pull/20618#discussion_r778816203
##
File path: airflow/providers/mysql/transfers/vertica_to_mysql.py
##
@@ -94,63 +94,72 @@ def execute(self, context: 'Context'):
vertica = Vert
wojsamjan commented on a change in pull request #20377:
URL: https://github.com/apache/airflow/pull/20377#discussion_r778823070
##
File path: airflow/providers/google/cloud/hooks/dataplex.py
##
@@ -0,0 +1,228 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# o
github-actions[bot] commented on pull request #20618:
URL: https://github.com/apache/airflow/pull/20618#issuecomment-1005693527
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not
ReadytoRocc commented on pull request #19194:
URL: https://github.com/apache/airflow/pull/19194#issuecomment-1005697139
@jedcunningham @uranusjr I needed to slightly modify some of the code due to
a mypy check that was not present when this PR was originally opened. Please
review again and
ephraimbuddy opened a new pull request #20683:
URL: https://github.com/apache/airflow/pull/20683
Deleted DAGs are not recreated most times when some other DAGs have SLAs
because of the time, it takes to execute slas.
---
**^ Add meaningful description above**
Read
potiuk opened a new pull request #20684:
URL: https://github.com/apache/airflow/pull/20684
This reverts commit 27fcd7e0be42dec8d5a68fb591239c4dbb0092f5.
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow
eladkal commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778842284
##
File path: airflow/contrib/operators/ecs_operator.py
##
@@ -19,26 +19,12 @@
import warnings
-from airflow.providers.amazon.aws.operators.ecs imp
BasPH opened a new pull request #20685:
URL: https://github.com/apache/airflow/pull/20685
The `airflow standalone` command generates a `standalone_admin_password.txt`
file with a random password. You don't want this in version control.
---
**^ Add meaningful description above**
github-actions[bot] commented on pull request #20684:
URL: https://github.com/apache/airflow/pull/20684#issuecomment-1005716586
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and ta
potiuk merged pull request #20684:
URL: https://github.com/apache/airflow/pull/20684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 61b29d7 Don't import Celery or Kubernetes at top level of CLI parser
(#20675)
add e374fae Revert "[New] - Ci f
nshetty15 commented on a change in pull request #19981:
URL: https://github.com/apache/airflow/pull/19981#discussion_r778848170
##
File path: airflow/providers/ssh/hooks/ssh.py
##
@@ -257,58 +259,74 @@ def get_conn(self) -> paramiko.SSHClient:
:rtype: paramiko.client.S
uranusjr closed issue #20655:
URL: https://github.com/apache/airflow/issues/20655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
uranusjr merged pull request #20659:
URL: https://github.com/apache/airflow/pull/20659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
This is an automated email from the ASF dual-hosted git repository.
uranusjr pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from e374fae Revert "[New] - Ci free space python (#20200)" (#20684)
add 1cff451 Disabled edit button in task inst
potiuk closed pull request #20680:
URL: https://github.com/apache/airflow/pull/20680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk closed pull request #20679:
URL: https://github.com/apache/airflow/pull/20679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk closed pull request #20678:
URL: https://github.com/apache/airflow/pull/20678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk closed pull request #20664:
URL: https://github.com/apache/airflow/pull/20664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
potiuk closed pull request #20618:
URL: https://github.com/apache/airflow/pull/20618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsub
kaxil merged pull request #20685:
URL: https://github.com/apache/airflow/pull/20685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
kaxilnaik pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git.
from 1cff451 Disabled edit button in task instances list view page (#20659)
add a08b74f Add ``standalone_admin_pa
kaxil closed pull request #20663:
URL: https://github.com/apache/airflow/pull/20663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
Bowrna commented on pull request #20645:
URL: https://github.com/apache/airflow/pull/20645#issuecomment-1005770120
@potiuk Gentle reminder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Bowrna commented on pull request #20066:
URL: https://github.com/apache/airflow/pull/20066#issuecomment-1005787192
@potiuk Do I have to comment out anything in this PR with regard to windows?
Or Can I move this PR to Open state?
--
This is an automated message from the Apache Git Service
potiuk opened a new pull request #20686:
URL: https://github.com/apache/airflow/pull/20686
We have a check that chekcs that our providers are importable
for Airlfow 2.1, hoewever some providers (nested ones) were missing
from the check. This PR checks one level deeper in providers to s
potiuk commented on pull request #20686:
URL: https://github.com/apache/airflow/pull/20686#issuecomment-1005811585
cc: @malthe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
github-actions[bot] commented on pull request #20686:
URL: https://github.com/apache/airflow/pull/20686#issuecomment-1005823501
The PR most likely needs to run full matrix of tests because it modifies
parts of the core of Airflow. However, committers might decide to merge it
quickly and ta
potiuk opened a new pull request #20687:
URL: https://github.com/apache/airflow/pull/20687
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more info
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005836955
Failed with
tests/core/test_core_to_contrib.py::TestMovingCoreToContrib::test_is_subclass_256_airflow_providers_amazon_aws_operators_ecs_ECSOperator:
TypeError: Protoc
uranusjr commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778922143
##
File path: airflow/contrib/operators/ecs_operator.py
##
@@ -19,26 +19,12 @@
import warnings
-from airflow.providers.amazon.aws.operators.ecs im
uranusjr commented on a change in pull request #20669:
URL: https://github.com/apache/airflow/pull/20669#discussion_r778922143
##
File path: airflow/contrib/operators/ecs_operator.py
##
@@ -19,26 +19,12 @@
import warnings
-from airflow.providers.amazon.aws.operators.ecs im
uranusjr commented on a change in pull request #20678:
URL: https://github.com/apache/airflow/pull/20678#discussion_r778923449
##
File path: scripts/docker/install_pip_version.sh
##
@@ -30,11 +30,13 @@
. "$( dirname "${BASH_SOURCE[0]}" )/common.sh"
function install_pip_vers
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005838730
No-one fault - selective checks did not run the tests as it is
"provider-only" change (theorethically).
--
This is an automated message from the Apache Git Service.
To respo
ashb commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005838773
But `ECSProtocol` is a protocol...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
potiuk edited a comment on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005838730
No-one fault - selective checks did not run the tests as it was
"provider-only" change (theorethically).
--
This is an automated message from the Apache Git Service.
uranusjr commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005841083
So is `EcsProtocol`. By inheriting from `EcsProtocol`, `ECSProtocol` is
already automatically a protocol, and inheriting from `Protocol` is redundant
either way.
--
This
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005840772
> But `ECSProtocol` is a protocol...
I know . But It helped for now. I tihnk there is some problem with the type
check. Since it is a deprecated class, I preferred to qu
uranusjr commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005841596
See also #20669 and #20670.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
potiuk commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005842177
```
for base in cls.__bases__:
uranusjr commented on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005842984
I’m going to close this one since this is only a subset of #20670, and we
should choose from either it or #20699 instead.
--
This is an automated message from the Apache G
uranusjr closed pull request #20687:
URL: https://github.com/apache/airflow/pull/20687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-uns
uranusjr edited a comment on pull request #20687:
URL: https://github.com/apache/airflow/pull/20687#issuecomment-1005842984
I’m going to close this one since this is only a subset of #20670, and we
should choose from either it or #20669 instead.
--
This is an automated message from the A
rustikk commented on pull request #20637:
URL: https://github.com/apache/airflow/pull/20637#issuecomment-1005844063
@kaxil I'm happy to help :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
1 - 100 of 291 matches
Mail list logo
