[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20962: Support generating SQL script for upgrades

2022-01-27 Thread GitBox
ephraimbuddy commented on a change in pull request #20962: URL: https://github.com/apache/airflow/pull/20962#discussion_r794256824 ## File path: airflow/utils/db.py ## @@ -1018,8 +1018,42 @@ def upgradedb(session: Session = NEW_SESSION): exit(1) with create_glob

[GitHub] [airflow] Greetlist commented on issue #19929: Deferrable Operators leave task in strange state on kill

2022-01-27 Thread GitBox
Greetlist commented on issue #19929: URL: https://github.com/apache/airflow/issues/19929#issuecomment-1023933892 > Later on, if the same task is started again, it finishes immediately, like it was continued after being deferred. I have a same problem in [#19612](https://github.com/a

[GitHub] [airflow] Greetlist commented on issue #20460: TimeDeltaSensorAsync task is failing occasionally

2022-01-27 Thread GitBox
Greetlist commented on issue #20460: URL: https://github.com/apache/airflow/issues/20460#issuecomment-1023924535 I have a similar problem in [#20308](https://github.com/apache/airflow/issues/20308), I fix it via a tricky way. I have a general solution in the issue, but I do not implement i

[airflow] branch main updated (684fe46 -> cdd9ea6)

2022-01-27 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 684fe46 Static check in Breeze2 (#20848) add cdd9ea6 Add possibility to create user in the Remote User mode

[GitHub] [airflow] jhtimmins merged pull request #19963: Add possibility to create user in the Remote User mode Auth.

2022-01-27 Thread GitBox
jhtimmins merged pull request #19963: URL: https://github.com/apache/airflow/pull/19963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] mik-laj commented on a change in pull request #21155: Fix #21096: Support boolean in extra__snowflake__insecure_mode

2022-01-27 Thread GitBox
mik-laj commented on a change in pull request #21155: URL: https://github.com/apache/airflow/pull/21155#discussion_r794167953 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -32,6 +32,14 @@ from airflow.utils.strings import to_boolean +def _try_to_boolea

[GitHub] [airflow] ferruzzi commented on pull request #21175: Fixes Docker xcom functionality

2022-01-27 Thread GitBox
ferruzzi commented on pull request #21175: URL: https://github.com/apache/airflow/pull/21175#issuecomment-1023834665 @uranusjr - You were looking at someone else's attempt at this, which has been sitting for a while. (link in the description) -- This is an automated message from the Apa

[GitHub] [airflow] ferruzzi opened a new pull request #21175: Fixes Docker xcom functionality

2022-01-27 Thread GitBox
ferruzzi opened a new pull request #21175: URL: https://github.com/apache/airflow/pull/21175 closes: https://github.com/apache/airflow/pull/19027 completes: https://github.com/apache/airflow/pull/19027/ Co-Author: https://github.com/asaf400 --- **^ Add meaning

[GitHub] [airflow] Yeonghobyun edited a comment on issue #21141: Not showing "Last Run" on Airflow Web UI

2022-01-27 Thread GitBox
Yeonghobyun edited a comment on issue #21141: URL: https://github.com/apache/airflow/issues/21141#issuecomment-1023790434 > I have faced the same issue when upgrading from 2.0.2 to 2.1.4, but it was resolved after upgrading again to 2.2.3. Is there any way to fix the source other tha

[GitHub] [airflow] Yeonghobyun commented on issue #21141: Not showing "Last Run" on Airflow Web UI

2022-01-27 Thread GitBox
Yeonghobyun commented on issue #21141: URL: https://github.com/apache/airflow/issues/21141#issuecomment-1023790434 > I have faced the same issue when upgrading from 2.0.2 to 2.1.4, but it was resolved after upgrading again to 2.2.3. Is there any way to fix the source other than upgra

[GitHub] [airflow] github-actions[bot] closed pull request #20132: Fix type hints in airflow.macros

2022-01-27 Thread GitBox
github-actions[bot] closed pull request #20132: URL: https://github.com/apache/airflow/pull/20132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] github-actions[bot] commented on pull request #19662: BaseOperator.on_kill should optionally accept airflow context

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #19662: URL: https://github.com/apache/airflow/pull/19662#issuecomment-1023755225 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] github-actions[bot] commented on issue #20309: Task exited with return code Negsignal.SIGSEGV

2022-01-27 Thread GitBox
github-actions[bot] commented on issue #20309: URL: https://github.com/apache/airflow/issues/20309#issuecomment-1023755186 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed issue #20309: Task exited with return code Negsignal.SIGSEGV

2022-01-27 Thread GitBox
github-actions[bot] closed issue #20309: URL: https://github.com/apache/airflow/issues/20309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [airflow] github-actions[bot] commented on pull request #19102: Increment Stats counter for task instance SLA misses

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #19102: URL: https://github.com/apache/airflow/pull/19102#issuecomment-1023755250 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank

[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View

2022-01-27 Thread GitBox
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1023750321 > I was thinking, should we even have any of this in the config? I think a better UX would be to show all possible events on the page and allow a user to check/uncheck eac

[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View

2022-01-27 Thread GitBox
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1023748689 > I wonder if something like the `All Instances` button in the task instance modal can be added as well. The button would link to the audit log browse view with pre-applie

[GitHub] [airflow] Acehaidrey commented on pull request #20733: Add Audit Log View to Dag View

2022-01-27 Thread GitBox
Acehaidrey commented on pull request #20733: URL: https://github.com/apache/airflow/pull/20733#issuecomment-1023747908 sorry all - I been dealing with more covid complications but now I am back. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] pateash closed pull request #21076: Adding GitHub provider

2022-01-27 Thread GitBox
pateash closed pull request #21076: URL: https://github.com/apache/airflow/pull/21076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[airflow] branch v2-2-test updated (e898e0e -> 5ad965d)

2022-01-27 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch v2-2-test in repository https://gitbox.apache.org/repos/asf/airflow.git. discard e898e0e Improved instructions for custom image build with docker compose (#21052) discard aae038c Add

[GitHub] [airflow] lewismc commented on pull request #20755: Augment xcom docs

2022-01-27 Thread GitBox
lewismc commented on pull request #20755: URL: https://github.com/apache/airflow/pull/20755#issuecomment-1023683095 @potiuk finally :) thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] lidalei commented on a change in pull request #21170: Add a note about broken DAG dependency graph

2022-01-27 Thread GitBox
lidalei commented on a change in pull request #21170: URL: https://github.com/apache/airflow/pull/21170#discussion_r794018564 ## File path: docs/apache-airflow/concepts/dags.rst ## @@ -713,7 +713,8 @@ Additional difficulty is that one DAG could wait for or trigger several runs

[GitHub] [airflow] github-actions[bot] commented on pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #18707: URL: https://github.com/apache/airflow/pull/18707#issuecomment-1023651349 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] potiuk edited a comment on issue #21171: Airflow schedules tasks early with an MSSQL Metadata DB on a non-UTC server

2022-01-27 Thread GitBox
potiuk edited a comment on issue #21171: URL: https://github.com/apache/airflow/issues/21171#issuecomment-1023643343 I think db-specific case will be better (if simple). We already have ~500 deps in Airflow total (including transitive) and while adding one more seems like no-biggie, adding

[GitHub] [airflow] jedcunningham closed pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run

2022-01-27 Thread GitBox
jedcunningham closed pull request #18707: URL: https://github.com/apache/airflow/pull/18707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] davidcaron opened a new pull request #18707: Fix mismatch in generated run_id and actual execution_date of dag run

2022-01-27 Thread GitBox
davidcaron opened a new pull request #18707: URL: https://github.com/apache/airflow/pull/18707 When execution_date is `None`, the generated name for the `run_id` contains the a generated `execution_date` in isoformat. That `execution_date`should be passed to `trigger_dag`, otherwise we h

[GitHub] [airflow] potiuk commented on issue #21171: Airflow schedules tasks early with an MSSQL Metadata DB on a non-UTC server

2022-01-27 Thread GitBox
potiuk commented on issue #21171: URL: https://github.com/apache/airflow/issues/21171#issuecomment-1023643343 I think db-specific case will be better (if simple) we already have ~500 deps in Airflow total (including transitive) and while adding one more seems like no-biggie, adding a 'util

[GitHub] [airflow] mattinbits commented on issue #21171: Airflow schedules tasks early with an MSSQL Metadata DB on a non-UTC server

2022-01-27 Thread GitBox
mattinbits commented on issue #21171: URL: https://github.com/apache/airflow/issues/21171#issuecomment-1023636680 @potiuk just to check before I attempt a fix. Are you happy with a solution that uses sqlalchemy-utc for all DB backends, or is it preferrable to have a solution that handles t

[GitHub] [airflow] potiuk commented on issue #21171: Airflow schedules tasks early with an MSSQL Metadata DB on a non-UTC server

2022-01-27 Thread GitBox
potiuk commented on issue #21171: URL: https://github.com/apache/airflow/issues/21171#issuecomment-1023627249 Not the first time MySQL bites us. Seems that indeed people even created packages to handle it correctly https://github.com/spoqa/sqlalchemy-utc. I will assign you to this one :)

[GitHub] [airflow] ferruzzi commented on issue #21169: `is_delete_operator_pod=True` and `random_name_suffix=False` can cause KubernetesPodOperator to delete the wrong pod

2022-01-27 Thread GitBox
ferruzzi commented on issue #21169: URL: https://github.com/apache/airflow/issues/21169#issuecomment-1023626676 Interesting combination of events. Another possible solution might be to check the failure cause before calling delete_pod, if it failed because the pod already existed, then do

[GitHub] [airflow] mattinbits opened a new issue #21171: Airflow schedules tasks early with an MSSQL Metadata DB on a non-UTC server

2022-01-27 Thread GitBox
mattinbits opened a new issue #21171: URL: https://github.com/apache/airflow/issues/21171 ### Apache Airflow version 2.2.2 ### What happened Airflow schedules a task an hour earlier than expected, when using an MSSQL metadata database where the DB server is set to the C

[GitHub] [airflow] eladkal commented on a change in pull request #21170: Add a note about broken DAG dependency graph

2022-01-27 Thread GitBox
eladkal commented on a change in pull request #21170: URL: https://github.com/apache/airflow/pull/21170#discussion_r793978951 ## File path: docs/apache-airflow/concepts/dags.rst ## @@ -713,7 +713,8 @@ Additional difficulty is that one DAG could wait for or trigger several runs

[GitHub] [airflow] lidalei commented on issue #21059: Dag dependency view is not rendering for Postgres backed Airflow

2022-01-27 Thread GitBox
lidalei commented on issue #21059: URL: https://github.com/apache/airflow/issues/21059#issuecomment-1023590394 @potiuk Thanks! I created a PR to explain the case. https://github.com/apache/airflow/pull/21170 -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [airflow] lidalei opened a new pull request #21170: Add a note about broken DAG dependency graph

2022-01-27 Thread GitBox
lidalei opened a new pull request #21170: URL: https://github.com/apache/airflow/pull/21170 Airflow webserver fails to render dependency graph is a dependency DAG is missing. The issue and cause was described in https://github.com/apache/airflow/issues/21059. related: [D

[GitHub] [airflow] SamWheating opened a new issue #21169: `is_delete_operator_pod=True` and `random_name_suffix=False` can cause KubernetesPodOperator to delete the wrong pod

2022-01-27 Thread GitBox
SamWheating opened a new issue #21169: URL: https://github.com/apache/airflow/issues/21169 ### Apache Airflow version 2.2.2 ### What happened When running multiple KubernetesPodOperators with `random_name_suffix=False` and `is_delete_pod_operator=True` the following wil

[GitHub] [airflow] josh-fell commented on a change in pull request #20998: Add dbt Cloud provider

2022-01-27 Thread GitBox
josh-fell commented on a change in pull request #20998: URL: https://github.com/apache/airflow/pull/20998#discussion_r793949682 ## File path: airflow/providers/dbt/cloud/hooks/dbt.py ## @@ -0,0 +1,488 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more c

[GitHub] [airflow] SangwanP opened a new issue #21168: Add "last updated timestamp" field to API endpoints

2022-01-27 Thread GitBox
SangwanP opened a new issue #21168: URL: https://github.com/apache/airflow/issues/21168 ### Description _No response_ ### Use case/motivation I would like to have a field added to API endpoints which reflects when a record, that is received in the API response, was last

[GitHub] [airflow] alexhallam commented on issue #21160: Table View

2022-01-27 Thread GitBox
alexhallam commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023564550 I agree! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] github-actions[bot] commented on pull request #21165: Update Broken link in api.rst

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #21165: URL: https://github.com/apache/airflow/pull/21165#issuecomment-1023563500 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] potiuk commented on pull request #21165: Update Broken link in api.rst

2022-01-27 Thread GitBox
potiuk commented on pull request #21165: URL: https://github.com/apache/airflow/pull/21165#issuecomment-1023563283 Static chekcs are failing though :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] potiuk commented on issue #21160: Table View

2022-01-27 Thread GitBox
potiuk commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023561952 Maybe worth re-evaluation after 2.3.0 is released. When you see how it works and if you are unhappy about it, this might be re-requrested (but in the new context). I do believe the

[GitHub] [airflow] github-actions[bot] commented on pull request #21162: Change logging level details of connection info in `get_connection()`

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #21162: URL: https://github.com/apache/airflow/pull/21162#issuecomment-1023560760 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] alexhallam commented on issue #21160: Table View

2022-01-27 Thread GitBox
alexhallam commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023560089 That makes sense. I still think explicit tables would be nice so statistics show without needing to hover, but it is not a big enough issue to fuss about. -- This is

[GitHub] [airflow] potiuk commented on issue #21156: Snowflake connection default value of extras insecure_mode set as string instead of boolean, throws error in Snowflake hook

2022-01-27 Thread GitBox
potiuk commented on issue #21156: URL: https://github.com/apache/airflow/issues/21156#issuecomment-1023559732 Duplicate of #21155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] potiuk closed issue #21156: Snowflake connection default value of extras insecure_mode set as string instead of boolean, throws error in Snowflake hook

2022-01-27 Thread GitBox
potiuk closed issue #21156: URL: https://github.com/apache/airflow/issues/21156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk commented on issue #21160: Table View

2022-01-27 Thread GitBox
potiuk commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023558040 Note - It is shown in "graphical" way not only as tooltip. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on issue #21160: Table View

2022-01-27 Thread GitBox
potiuk commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023557306 Duplicate of #18675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] potiuk commented on issue #21160: Table View

2022-01-27 Thread GitBox
potiuk commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023557116 There is a new tree view coming in Airlfwow 2.3.0 It's already merged. Initial version of it can be seen here https://github.com/apache/airflow/pull/18675 but it already had gone t

[GitHub] [airflow] potiuk closed issue #21160: Table View

2022-01-27 Thread GitBox
potiuk closed issue #21160: URL: https://github.com/apache/airflow/issues/21160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk edited a comment on issue #21059: Dag dependency view is not rendering for Postgres backed Airflow

2022-01-27 Thread GitBox
potiuk edited a comment on issue #21059: URL: https://github.com/apache/airflow/issues/21059#issuecomment-1023551897 Hmmm maybe it would be a good idea to add it as PR to https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/external_task_sensor.html?highlight=dag%20dependenc

[GitHub] [airflow] potiuk commented on issue #21059: Dag dependency view is not rendering for Postgres backed Airflow

2022-01-27 Thread GitBox
potiuk commented on issue #21059: URL: https://github.com/apache/airflow/issues/21059#issuecomment-1023551897 Hmmm maybe it woudl be a good idea to add it as PR to https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/external_task_sensor.html?highlight=dag%20dependency (I g

[GitHub] [airflow] julienledem commented on pull request #21157: taskinstance: set task on sqlalchemy taskinstance object

2022-01-27 Thread GitBox
julienledem commented on pull request #21157: URL: https://github.com/apache/airflow/pull/21157#issuecomment-1023548597 👍🏻 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] blag opened a new pull request #21167: Add a session backend to store session data in the database

2022-01-27 Thread GitBox
blag opened a new pull request #21167: URL: https://github.com/apache/airflow/pull/21167 This PR re-implements modified portions of [Flask-Session](https://github.com/fengsp/flask-session) to store session data in the database. TODO: * [ ] Tests --- **^ Add mean

[GitHub] [airflow] potiuk commented on a change in pull request #21155: Fix #21096: Support boolean in extra__snowflake__insecure_mode

2022-01-27 Thread GitBox
potiuk commented on a change in pull request #21155: URL: https://github.com/apache/airflow/pull/21155#discussion_r793872553 ## File path: airflow/providers/snowflake/hooks/snowflake.py ## @@ -32,6 +32,14 @@ from airflow.utils.strings import to_boolean +def _try_to_boolean

[GitHub] [airflow] boring-cyborg[bot] commented on issue #21166: DagFileProcessorManager - ERROR - new DAG tasks are delayed in airflow schedule

2022-01-27 Thread GitBox
boring-cyborg[bot] commented on issue #21166: URL: https://github.com/apache/airflow/issues/21166#issuecomment-1023497727 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] ckvtvm-arch opened a new issue #21166: DagFileProcessorManager - ERROR - new DAG tasks are delayed in airflow schedule

2022-01-27 Thread GitBox
ckvtvm-arch opened a new issue #21166: URL: https://github.com/apache/airflow/issues/21166 ### Apache Airflow version 2.2.3 (latest released) ### What happened new DAG tasks are delayed in scheduling. When a new task is added, it takes atleast 10 hours to schedule in ai

[GitHub] [airflow] fritz-astronomer opened a new pull request #21165: Update Broken link in api.rst

2022-01-27 Thread GitBox
fritz-astronomer opened a new pull request #21165: URL: https://github.com/apache/airflow/pull/21165 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**

[GitHub] [airflow] potiuk opened a new issue #21164: Breeze2 autocomplete requires `click-complete` to be installed

2022-01-27 Thread GitBox
potiuk opened a new issue #21164: URL: https://github.com/apache/airflow/issues/21164 ### Apache Airflow version main (development) ### What happened When I setup autocomplete for Breeze2 on a "bare" system when I have no packages installed, It fails autocomplete with t

[GitHub] [airflow] josh-fell commented on issue #21156: Snowflake connection default value of extras insecure_mode set as string instead of boolean, throws error in Snowflake hook

2022-01-27 Thread GitBox
josh-fell commented on issue #21156: URL: https://github.com/apache/airflow/issues/21156#issuecomment-1023480177 This is a duplicate of #21096 and #21155 has been raised to fix the issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[airflow] branch main updated (82adce5 -> 684fe46)

2022-01-27 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 82adce5 Ensure `on_task_instance_running` listener can get at task (#21157) add 684fe46 Static check in Breeze

[GitHub] [airflow] potiuk closed issue #20740: Breeze: Running static checks with Breeze

2022-01-27 Thread GitBox
potiuk closed issue #20740: URL: https://github.com/apache/airflow/issues/20740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr..

[GitHub] [airflow] potiuk merged pull request #20848: Static check in Breeze2

2022-01-27 Thread GitBox
potiuk merged pull request #20848: URL: https://github.com/apache/airflow/pull/20848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on pull request #20848: Static check in Breeze2

2022-01-27 Thread GitBox
potiuk commented on pull request #20848: URL: https://github.com/apache/airflow/pull/20848#issuecomment-1023474381 Lks great! I tested it locally and it works really neatly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #20962: Support generating SQL script for upgrades

2022-01-27 Thread GitBox
ephraimbuddy commented on a change in pull request #20962: URL: https://github.com/apache/airflow/pull/20962#discussion_r793840551 ## File path: airflow/utils/db.py ## @@ -1018,8 +1018,42 @@ def upgradedb(session: Session = NEW_SESSION): exit(1) with create_glob

[airflow] branch main updated: Ensure `on_task_instance_running` listener can get at task (#21157)

2022-01-27 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 82adce5 Ensure `on_task_instance_running` listener ca

[GitHub] [airflow] ashb merged pull request #21157: taskinstance: set task on sqlalchemy taskinstance object

2022-01-27 Thread GitBox
ashb merged pull request #21157: URL: https://github.com/apache/airflow/pull/21157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubsc

[GitHub] [airflow] potiuk opened a new issue #21163: `setup-autocomplete` in Breeze2 fails with "Permission denied"

2022-01-27 Thread GitBox
potiuk opened a new issue #21163: URL: https://github.com/apache/airflow/issues/21163 ### Apache Airflow version main (development) ### What happened When I run "setup-autocomplete" in the new Breeze with zsh it fails with "permission denied" as it tries to access `/.zs

[GitHub] [airflow] potiuk commented on a change in pull request #20848: Static check in Breeze2

2022-01-27 Thread GitBox
potiuk commented on a change in pull request #20848: URL: https://github.com/apache/airflow/pull/20848#discussion_r793829156 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -312,6 +313,47 @@ def build_docs(verbose: bool, docs_only: bool, spellcheck_only: bool, pack

[GitHub] [airflow] potiuk commented on pull request #20848: Static check in Breeze2

2022-01-27 Thread GitBox
potiuk commented on pull request #20848: URL: https://github.com/apache/airflow/pull/20848#issuecomment-1023454736 > @potiuk I think we can include tests for this PR with multiple ways of running the static code checks via breeze so that we can ensure that this code is working for multiple

[GitHub] [airflow] github-actions[bot] commented on pull request #20848: Static check in Breeze2

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #20848: URL: https://github.com/apache/airflow/pull/20848#issuecomment-1023454334 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] josh-fell opened a new pull request #21162: Change logging level details of connection info in `get_connection()`

2022-01-27 Thread GitBox
josh-fell opened a new pull request #21162: URL: https://github.com/apache/airflow/pull/21162 Related: #19883 Currently task logs can contain all of connection details depending on how the associated connection to the task is configured (i.e. if `host` is a provided connection attr)

[GitHub] [airflow] potiuk commented on a change in pull request #20848: Static check in Breeze2

2022-01-27 Thread GitBox
potiuk commented on a change in pull request #20848: URL: https://github.com/apache/airflow/pull/20848#discussion_r793826642 ## File path: dev/breeze/src/airflow_breeze/breeze.py ## @@ -312,6 +313,47 @@ def build_docs(verbose: bool, docs_only: bool, spellcheck_only: bool, pack

[GitHub] [airflow] edithturn opened a new pull request #21161: added selective ci checks py

2022-01-27 Thread GitBox
edithturn opened a new pull request #21161: URL: https://github.com/apache/airflow/pull/21161 **Rewrite selective check script in Python** 01. .github/workflows/build-images.yml and .github/workflows/ci.yaml they are calling the step: **Selective checks** airflow/scripts/ci/selectiv

[GitHub] [airflow] boring-cyborg[bot] commented on issue #21160: Table View

2022-01-27 Thread GitBox
boring-cyborg[bot] commented on issue #21160: URL: https://github.com/apache/airflow/issues/21160#issuecomment-1023437883 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] alexhallam opened a new issue #21160: Table View

2022-01-27 Thread GitBox
alexhallam opened a new issue #21160: URL: https://github.com/apache/airflow/issues/21160 ### Description One of the main things we want to know is task durations. The main way I know how to get this is to hover over the `Gannt` chart or use the `Task Duration` chart.

[airflow] branch main updated (0ac3b8c -> 362f397)

2022-01-27 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 0ac3b8c Return slack api call response in slack_hook (#21107) add 362f397 Update `version_added` for `[e

[GitHub] [airflow] jedcunningham merged pull request #21138: Update `version_added` for `[email] from_email`

2022-01-27 Thread GitBox
jedcunningham merged pull request #21138: URL: https://github.com/apache/airflow/pull/21138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] potiuk commented on a change in pull request #20847: Added other Opentelemery Instrumentations

2022-01-27 Thread GitBox
potiuk commented on a change in pull request #20847: URL: https://github.com/apache/airflow/pull/20847#discussion_r793799448 ## File path: airflow/www/gunicorn_config.py ## @@ -37,3 +42,18 @@ def on_starting(server): # Load providers before forking workers Providers

[GitHub] [airflow] github-actions[bot] commented on pull request #21150: Align Black and blacken-docs config

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #21150: URL: https://github.com/apache/airflow/pull/21150#issuecomment-1023419779 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] potiuk commented on pull request #21149: Rewrite Airflow documentation home page

2022-01-27 Thread GitBox
potiuk commented on pull request #21149: URL: https://github.com/apache/airflow/pull/21149#issuecomment-1023412406 I see. I love where it is going though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [airflow] zambadruzaman commented on issue #21059: Dag dependency view is not rendering for Postgres backed Airflow

2022-01-27 Thread GitBox
zambadruzaman commented on issue #21059: URL: https://github.com/apache/airflow/issues/21059#issuecomment-1023404868 Hi @lidalei, yes it was the exact same issue, when you delete any dags, make sure there is no other dag depends on the deleted dag. If you have a dag which has external trig

[GitHub] [airflow] subkanthi commented on a change in pull request #20794: Helm Chart - support for priorityClassName

2022-01-27 Thread GitBox
subkanthi commented on a change in pull request #20794: URL: https://github.com/apache/airflow/pull/20794#discussion_r793759521 ## File path: chart/templates/pgbouncer/pgbouncer-deployment.yaml ## @@ -59,6 +59,7 @@ spec: checksum/pgbouncer-config-secret: {{ include (pr

[GitHub] [airflow] subkanthi commented on a change in pull request #20794: Helm Chart - support for priorityClassName

2022-01-27 Thread GitBox
subkanthi commented on a change in pull request #20794: URL: https://github.com/apache/airflow/pull/20794#discussion_r793759521 ## File path: chart/templates/pgbouncer/pgbouncer-deployment.yaml ## @@ -59,6 +59,7 @@ spec: checksum/pgbouncer-config-secret: {{ include (pr

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages on consumption

2022-01-27 Thread GitBox
boring-cyborg[bot] commented on pull request #21159: URL: https://github.com/apache/airflow/pull/21159#issuecomment-1023366571 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Co

[GitHub] [airflow] LaPetiteSouris opened a new pull request #21159: [SQSSensor] Add opt-in to disable auto-delete messages on consumption

2022-01-27 Thread GitBox
LaPetiteSouris opened a new pull request #21159: URL: https://github.com/apache/airflow/pull/21159 ## What Add opt-in in `SQSSensor` to disable the behavior of automatically delete messages on consumption. This option is opt-in. By default it is set to `False`, which means the origi

[GitHub] [airflow] ashb commented on a change in pull request #20962: Support generating SQL script for upgrades

2022-01-27 Thread GitBox
ashb commented on a change in pull request #20962: URL: https://github.com/apache/airflow/pull/20962#discussion_r793756208 ## File path: airflow/utils/db.py ## @@ -1018,8 +1018,42 @@ def upgradedb(session: Session = NEW_SESSION): exit(1) with create_global_lock(

[GitHub] [airflow] github-actions[bot] commented on pull request #21157: taskinstance: set task on sqlalchemy taskinstance object

2022-01-27 Thread GitBox
github-actions[bot] commented on pull request #21157: URL: https://github.com/apache/airflow/pull/21157#issuecomment-1023362633 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] takuti opened a new pull request #21158: Fix documentation errors in apache-airflow/lineage.rst

2022-01-27 Thread GitBox
takuti opened a new pull request #21158: URL: https://github.com/apache/airflow/pull/21158 Noticed two errors in the [Lineage documentation page](https://airflow.apache.org/docs/apache-airflow/stable/lineage.html): - Inline code highlight "task_id=\`\`run_me_first\`\`" doesn't work d

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21158: Fix documentation errors in apache-airflow/lineage.rst

2022-01-27 Thread GitBox
boring-cyborg[bot] commented on pull request #21158: URL: https://github.com/apache/airflow/pull/21158#issuecomment-1023362232 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Co

[GitHub] [airflow] mobuchowski commented on pull request #21157: taskinstance: set task on sqlalchemy taskinstance object

2022-01-27 Thread GitBox
mobuchowski commented on pull request #21157: URL: https://github.com/apache/airflow/pull/21157#issuecomment-1023355726 cc @ashb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [airflow] mobuchowski opened a new pull request #21157: taskinstance: set task on sqlalchemy taskinstance object

2022-01-27 Thread GitBox
mobuchowski opened a new pull request #21157: URL: https://github.com/apache/airflow/pull/21157 In https://github.com/apache/airflow/pull/20443 we added TaskListener API. It's contract promises to pass TaskInstance object to listener plugin. However, what happens is not 100% true - the obj

[GitHub] [airflow] rsg17 commented on pull request #21084: [wip] Upload data from GCS to Presto

2022-01-27 Thread GitBox
rsg17 commented on pull request #21084: URL: https://github.com/apache/airflow/pull/21084#issuecomment-1023353126 @eladkal : yes! Thank you for checking. Will do it this weekend.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [airflow] jedcunningham commented on a change in pull request #20794: Helm Chart - support for priorityClassName

2022-01-27 Thread GitBox
jedcunningham commented on a change in pull request #20794: URL: https://github.com/apache/airflow/pull/20794#discussion_r793733937 ## File path: chart/templates/pgbouncer/pgbouncer-deployment.yaml ## @@ -59,6 +59,7 @@ spec: checksum/pgbouncer-config-secret: {{ include

[GitHub] [airflow] boring-cyborg[bot] commented on issue #21156: Snowflake connection default value of extras insecure_mode set as string instead of boolean, throws error in Snowflake hook

2022-01-27 Thread GitBox
boring-cyborg[bot] commented on issue #21156: URL: https://github.com/apache/airflow/issues/21156#issuecomment-1023338370 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] gregdorval-glf opened a new issue #21156: Snowflake connection default value of extras insecure_mode set as string instead of boolean, throws error in Snowflake hook

2022-01-27 Thread GitBox
gregdorval-glf opened a new issue #21156: URL: https://github.com/apache/airflow/issues/21156 ### Apache Airflow Provider(s) snowflake ### Versions of Apache Airflow Providers apache-airflow-providers-snowflake | 2.4.0 ### Apache Airflow version 2.2.3 (late

[GitHub] [airflow] lidalei commented on issue #21059: Dag dependency view is not rendering for Postgres backed Airflow

2022-01-27 Thread GitBox
lidalei commented on issue #21059: URL: https://github.com/apache/airflow/issues/21059#issuecomment-1023334116 > > Closed this issue, the problem is not due to any bug, it's configuration issue on my side. Hi @zambadruzaman, could u share which configuration issue? We

[GitHub] [airflow] mik-laj opened a new pull request #21155: Fix #21096: Support boolean in extra__snowflake__insecure_mode

2022-01-27 Thread GitBox
mik-laj opened a new pull request #21155: URL: https://github.com/apache/airflow/pull/21155 closes: #21096 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline

[GitHub] [airflow] Bowrna commented on pull request #21145: enter the shell breeze2 environment

2022-01-27 Thread GitBox
Bowrna commented on pull request #21145: URL: https://github.com/apache/airflow/pull/21145#issuecomment-1023245481 > > @potiuk i can see several env variables in scripts/ci/libraries/_initialization.sh. > > We definitely should not try to set all of those. They are needed by differe

[GitHub] [airflow] Melodie97 closed pull request #21154: Melodie97 docsupdate

2022-01-27 Thread GitBox
Melodie97 closed pull request #21154: URL: https://github.com/apache/airflow/pull/21154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] potiuk commented on pull request #21145: enter the shell breeze2 environment

2022-01-27 Thread GitBox
potiuk commented on pull request #21145: URL: https://github.com/apache/airflow/pull/21145#issuecomment-1023202231 > @potiuk i can see several env variables in scripts/ci/libraries/_initialization.sh. We definitely should not try to set all of those. They are needed by different par

  1   2   >