[GitHub] [airflow] dstandish commented on a change in pull request #19857: Enable json serialization for secrets backend

2022-03-04 Thread GitBox
dstandish commented on a change in pull request #19857: URL: https://github.com/apache/airflow/pull/19857#discussion_r820063884 ## File path: docs/apache-airflow/usage-cli.rst ## @@ -259,3 +259,91 @@ If you want to preview the commands but not execute them, use option ``--sql-

[GitHub] [airflow] dstandish commented on pull request #19857: Enable json serialization for secrets backend

2022-03-04 Thread GitBox
dstandish commented on pull request #19857: URL: https://github.com/apache/airflow/pull/19857#issuecomment-1059715688 OK finally have the docs in, i think, a decent place. Really required a lot of work to try to get things where they feel reasonably coherent (talking bout the managing con

[GitHub] [airflow] zjffdu commented on pull request #21954: Add support for Apache Zeppelin (#21953)

2022-03-04 Thread GitBox
zjffdu commented on pull request #21954: URL: https://github.com/apache/airflow/pull/21954#issuecomment-1059705679 I am Zeppelin PMC,I can help on review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] nitinmahawadiwar commented on issue #22013: Broken links on tutorial.html

2022-03-04 Thread GitBox
nitinmahawadiwar commented on issue #22013: URL: https://github.com/apache/airflow/issues/22013#issuecomment-1059694125 Please let me know if I can take this defect as a first contribution from my side. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22013: Broken links on tutorial.html

2022-03-04 Thread GitBox
boring-cyborg[bot] commented on issue #22013: URL: https://github.com/apache/airflow/issues/22013#issuecomment-1059693882 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] nitinmahawadiwar opened a new issue #22013: Broken links on tutorial.html

2022-03-04 Thread GitBox
nitinmahawadiwar opened a new issue #22013: URL: https://github.com/apache/airflow/issues/22013 ### Describe the issue with documentation 1. visit https://airflow.apache.org/docs/apache-airflow/2.2.4/tutorial.html 2. go to the section Templating with Jinja([](https://airflow.apac

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22012: sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: session

2022-03-04 Thread GitBox
boring-cyborg[bot] commented on issue #22012: URL: https://github.com/apache/airflow/issues/22012#issuecomment-1059687455 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] iamhimanshu0 opened a new issue #22012: sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such table: session

2022-03-04 Thread GitBox
iamhimanshu0 opened a new issue #22012: URL: https://github.com/apache/airflow/issues/22012 ### Apache Airflow version 2.2.4 (latest released) ### What happened I've installed apache-airflow version 2.2.4 on my system ubuntu 20.0.4 LTS and i'm using these steps - exp

[airflow] branch constraints-main updated: Updating constraints. Build id:1936979540

2022-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 54d8c2c Updating const

[airflow] branch main updated (f5f2216 -> 8c63a8d)

2022-03-04 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from f5f2216 Minor cleanup on Celery config (#21880) add 8c63a8d Add brief examples of integration test dags

[GitHub] [airflow] jedcunningham merged pull request #22009: Add brief examples of integration test dags you might want

2022-03-04 Thread GitBox
jedcunningham merged pull request #22009: URL: https://github.com/apache/airflow/pull/22009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] github-actions[bot] commented on pull request #22009: Add brief examples of integration test dags you might want

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #22009: URL: https://github.com/apache/airflow/pull/22009#issuecomment-1059673859 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] edithturn commented on pull request #22008: Replace build image bash script in CI with build image in python

2022-03-04 Thread GitBox
edithturn commented on pull request #22008: URL: https://github.com/apache/airflow/pull/22008#issuecomment-1059662372 @potiuk these are what I did and the status of this PR. * There were many things that were synchronized with the PR of @Bowrna 👏🏼 * In Breeze.py I am taking two-va

[GitHub] [airflow-site] jedcunningham commented on pull request #555: Remove MSSQL from the published doc

2022-03-04 Thread GitBox
jedcunningham commented on pull request #555: URL: https://github.com/apache/airflow-site/pull/555#issuecomment-1059659080 Looks good, but we need to merge https://github.com/apache/airflow/pull/22011 first then regenerate, or manually remove the changes in `changelog.html` in this pr.

[GitHub] [airflow] jedcunningham opened a new pull request #22011: Fix 2.2.4 changelog date and remove dups

2022-03-04 Thread GitBox
jedcunningham opened a new pull request #22011: URL: https://github.com/apache/airflow/pull/22011 This was already fixed in `main`, but needs to be fixed in `v2-2-stable` directly so rebuilt docs and future patch releases have the right info. -- This is an automated message from the Apac

[GitHub] [airflow] o-nikolas opened a new pull request #22010: Add docs and sample dags for AWS Batch Operator/Sensor

2022-03-04 Thread GitBox
o-nikolas opened a new pull request #22010: URL: https://github.com/apache/airflow/pull/22010 Part of a project to add, simplify and standardize AWS sample dags and docs in preparation for adding System Testing. related: #21828 related: #21920 --- **^ Add meaning

[GitHub] [airflow] ac1997 commented on pull request #21351: Add and use supports_celery attribute for cli celery command validation

2022-03-04 Thread GitBox
ac1997 commented on pull request #21351: URL: https://github.com/apache/airflow/pull/21351#issuecomment-1059624470 Bumping this PR for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] alekseiloginov commented on a change in pull request #20882: Add Looker PDT operators

2022-03-04 Thread GitBox
alekseiloginov commented on a change in pull request #20882: URL: https://github.com/apache/airflow/pull/20882#discussion_r819993056 ## File path: docs/apache-airflow-providers-google/operators/cloud/looker.rst ## @@ -39,29 +39,7 @@ To use these operators, you must do a few thi

[GitHub] [airflow] github-actions[bot] closed pull request #19852: created SFTPBatchOperator which add batch function

2022-03-04 Thread GitBox
github-actions[bot] closed pull request #19852: URL: https://github.com/apache/airflow/pull/19852 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] josh-fell edited a comment on pull request #21997: [Feature] Updates FTPHook provider to have test_connection

2022-03-04 Thread GitBox
josh-fell edited a comment on pull request #21997: URL: https://github.com/apache/airflow/pull/21997#issuecomment-1059615713 It would be a good idea to add a `test_connection_failed` test as well. Also, it doesn't need to be in this PR but feel free to add if you feel up to it, but a

[GitHub] [airflow] josh-fell commented on pull request #21997: [Feature] Updates FTPHook provider to have test_connection

2022-03-04 Thread GitBox
josh-fell commented on pull request #21997: URL: https://github.com/apache/airflow/pull/21997#issuecomment-1059615713 It would be a good idea to add a `test_connection_failed` test as well. Also, it doesn't need to be in this PR but feel free to add if you feel up to it, to also add

[GitHub] [airflow] edithturn opened a new pull request #22008: Replace build image bash script in CI with build image in python

2022-03-04 Thread GitBox
edithturn opened a new pull request #22008: URL: https://github.com/apache/airflow/pull/22008 The script to build image is already created in python: build_image.py. This PR replaces ./dev/breeze/src/airflow_breeze/ci/ci_build_ci_image_on_ci.sh with build_image.py Closes #20741 --

[GitHub] [airflow] edithturn closed pull request #21676: change build ci image for build_image python

2022-03-04 Thread GitBox
edithturn closed pull request #21676: URL: https://github.com/apache/airflow/pull/21676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[airflow] branch main updated (e9b42d6 -> f5f2216)

2022-03-04 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from e9b42d6 Don't validate that Params are JSON when NOTSET (#22000) add f5f2216 Minor cleanup on Celery con

[GitHub] [airflow] jedcunningham merged pull request #21880: Minor cleanup on Celery config

2022-03-04 Thread GitBox
jedcunningham merged pull request #21880: URL: https://github.com/apache/airflow/pull/21880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [airflow] SangwanP opened a new issue #22007: Add Variable, Connection "description" fields available in the API

2022-03-04 Thread GitBox
SangwanP opened a new issue #22007: URL: https://github.com/apache/airflow/issues/22007 ### Description I'd like to get the "description" field from the variable, and connection table available through the REST API for the calls: 1. /variables/{key} 2. /connections/{conn_id

[GitHub] [airflow] SangwanP opened a new issue #22006: Add ability to disable a running DAG only after after it's in a finished state

2022-03-04 Thread GitBox
SangwanP opened a new issue #22006: URL: https://github.com/apache/airflow/issues/22006 ### Description I'd like the ability to "drain" a DAG from the UI. This would mean: - If a DAG is in a running state - disable the DAG after the run reaches a finished state (success/faile

[GitHub] [airflow] kazanzhy opened a new pull request #22005: Update `moto` library to version 3.0

2022-03-04 Thread GitBox
kazanzhy opened a new pull request #22005: URL: https://github.com/apache/airflow/pull/22005 Some of the RDS functionality was added to `moto` recently. Therefore, there are needed to upgrade version of the library -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] ashb opened a new pull request #22004: Add map_index to RenderedTaskInstanceFields

2022-03-04 Thread GitBox
ashb opened a new pull request #22004: URL: https://github.com/apache/airflow/pull/22004 In order to do this "properly" we have also migrated it from using execution_date to run_id in its PK -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] dstandish edited a comment on pull request #19857: Enable json serialization for secrets backend

2022-03-04 Thread GitBox
dstandish edited a comment on pull request #19857: URL: https://github.com/apache/airflow/pull/19857#issuecomment-1058896816 ~had to refactor / simplify tests, done that in #21983, which now needs to be merged first.~ <-- merged now -- This is an automated message from the Apache Git Ser

[airflow] branch main updated (28e3d65 -> e9b42d6)

2022-03-04 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 28e3d65 Add per-DAG delete permissions (#21938) add e9b42d6 Don't validate that Params are JSON when NOTSET

[GitHub] [airflow] dstandish merged pull request #22000: Don't validate that Params are JSON when NOTSET

2022-03-04 Thread GitBox
dstandish merged pull request #22000: URL: https://github.com/apache/airflow/pull/22000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[airflow] branch main updated: Add per-DAG delete permissions (#21938)

2022-03-04 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 28e3d65 Add per-DAG delete permissions (#21938)

[GitHub] [airflow] kaxil merged pull request #21938: Add per-DAG delete permissions

2022-03-04 Thread GitBox
kaxil merged pull request #21938: URL: https://github.com/apache/airflow/pull/21938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [airflow] jedcunningham opened a new pull request #22003: Use towncrier for core and helm chart changelogs

2022-03-04 Thread GitBox
jedcunningham opened a new pull request #22003: URL: https://github.com/apache/airflow/pull/22003 This proposes a few changes, primarily combining our existing changelog and updating docs into a single "release notes" doc, and start using towncrier to help generate it. More details

[GitHub] [airflow] dstandish commented on a change in pull request #22000: Don't validate that Params are JSON when NOTSET

2022-03-04 Thread GitBox
dstandish commented on a change in pull request #22000: URL: https://github.com/apache/airflow/pull/22000#discussion_r819880585 ## File path: tests/models/test_param.py ## @@ -272,7 +273,24 @@ def return_num(num): ti = dr.get_task_instances()[0] assert ti.xcom

[GitHub] [airflow] potiuk commented on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
potiuk commented on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059474562 > I guess for 2.3.0 we have to either decide to officially support it, tag it as experimental in those howto docs, or remove the docs from main, otherwise we will have the sam

[GitHub] [airflow] blag commented on a change in pull request #22000: Don't validate that Params are JSON when NOTSET

2022-03-04 Thread GitBox
blag commented on a change in pull request #22000: URL: https://github.com/apache/airflow/pull/22000#discussion_r819871935 ## File path: tests/models/test_param.py ## @@ -272,7 +273,24 @@ def return_num(num): ti = dr.get_task_instances()[0] assert ti.xcom_pull

[GitHub] [airflow] blag commented on a change in pull request #22000: Don't validate that Params are JSON when NOTSET

2022-03-04 Thread GitBox
blag commented on a change in pull request #22000: URL: https://github.com/apache/airflow/pull/22000#discussion_r819870455 ## File path: tests/models/test_param.py ## @@ -272,7 +273,24 @@ def return_num(num): ti = dr.get_task_instances()[0] assert ti.xcom_pull

[airflow-site] 01/01: Remove MSSQL from the published doc

2022-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch 2.2.4-fix-docs in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 7416b30b58647e1b3e51dd3c6dc56e783a1eb3bd Author: Jarek Potiuk AuthorDate: Fri Mar 4 20:54:52 2022 +0100

[airflow-site] branch 2.2.4-fix-docs created (now 7416b30)

2022-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch 2.2.4-fix-docs in repository https://gitbox.apache.org/repos/asf/airflow-site.git. at 7416b30 Remove MSSQL from the published doc This branch includes the following new commits: new

[GitHub] [airflow] jedcunningham edited a comment on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
jedcunningham edited a comment on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059467519 All good, I just started poking around because I didn't know how it got there either and was worried I goofed up 👍 I guess for 2.3.0 we have to either deci

[GitHub] [airflow] jedcunningham commented on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
jedcunningham commented on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059467519 All good, I just started poking around because I didn't know how it got there either and was worried I goofed up 👍 I guess for 2.3.0 we have to either decide to a

[GitHub] [airflow] zachliu opened a new pull request #22002: retry on very specific eni provision failures

2022-03-04 Thread GitBox
zachliu opened a new pull request #22002: URL: https://github.com/apache/airflow/pull/22002 In an old PR https://github.com/apache/airflow/pull/14263 we tried to add a "retry" mechanism for triggering new ECS task but it didn't work as expected according to my explanation in https://github

[GitHub] [airflow] potiuk commented on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
potiuk commented on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059463661 BTW. @jedcunningham - I assumed it was MY wrong cherry-pick to be precise :) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] potiuk commented on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
potiuk commented on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059463175 > I certainly don't have a complete history here, but it does look like it was intentionally added before 2.2.0 and wasn't a result of a rogue cherry-pick: > > #17018

[GitHub] [airflow] HardikVijayPatel edited a comment on issue #21951: Tasks stuck in scheduled state from different dags waiting for other dag tasks to complete first

2022-03-04 Thread GitBox
HardikVijayPatel edited a comment on issue #21951: URL: https://github.com/apache/airflow/issues/21951#issuecomment-1059458794 > max_active_tasks_per_dag == dag_concurrency. > > There was a rename of dag_concurrency to max_active_tasks_per_dag. Can you set this correctly? @eph

[GitHub] [airflow] HardikVijayPatel commented on issue #21951: Tasks stuck in scheduled state from different dags waiting for other dag tasks to complete first

2022-03-04 Thread GitBox
HardikVijayPatel commented on issue #21951: URL: https://github.com/apache/airflow/issues/21951#issuecomment-1059458794 > max_active_tasks_per_dag == dag_concurrency. > > There was a rename of dag_concurrency to max_active_tasks_per_dag. Can you set this correctly? I do have t

[GitHub] [airflow] jedcunningham commented on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
jedcunningham commented on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059456434 I certainly don't have a complete history here, but it does look like it was intentionally added before 2.2.0 and wasn't a result of a rogue cherry-pick: https://

[GitHub] [airflow] potiuk commented on a change in pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
potiuk commented on a change in pull request #21998: URL: https://github.com/apache/airflow/pull/21998#discussion_r819855034 ## File path: docs/apache-airflow/howto/set-up-database.rst ## @@ -27,14 +27,13 @@ The document below describes the database engine configurations, the

[GitHub] [airflow] frankcash closed pull request #21997: [Feature] Updates FTPHook provider to have test_connection

2022-03-04 Thread GitBox
frankcash closed pull request #21997: URL: https://github.com/apache/airflow/pull/21997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] malthe commented on a change in pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
malthe commented on a change in pull request #21998: URL: https://github.com/apache/airflow/pull/21998#discussion_r819849329 ## File path: docs/apache-airflow/howto/set-up-database.rst ## @@ -27,14 +27,13 @@ The document below describes the database engine configurations, the

[airflow] branch constraints-main updated: Updating constraints. Build id:1935273461

2022-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new a735047 Updating const

[airflow] branch v2-2-stable updated: Remove misleading MSSQL information from the docs (#21998)

2022-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch v2-2-stable in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v2-2-stable by this push: new 1be54f2 Remove misleading MSSQL info

[GitHub] [airflow] potiuk merged pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
potiuk merged pull request #21998: URL: https://github.com/apache/airflow/pull/21998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] github-actions[bot] commented on pull request #22000: Don't validate that Params are JSON when NOTSET

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #22000: URL: https://github.com/apache/airflow/pull/22000#issuecomment-1059435107 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22001: Global gantt chart (across all DAGs)

2022-03-04 Thread GitBox
boring-cyborg[bot] commented on issue #22001: URL: https://github.com/apache/airflow/issues/22001#issuecomment-1059431556 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] alejandrofm opened a new issue #22001: Global gantt chart (across all DAGs)

2022-03-04 Thread GitBox
alejandrofm opened a new issue #22001: URL: https://github.com/apache/airflow/issues/22001 ### Description Hi, now we have a Gantt view inside each DAG which helps to understand the overlapping/idle times/etc on each one. The request is for a global Gantt across all DAGs ###

[GitHub] [airflow] dstandish opened a new pull request #22000: Don't validate that Params are JSON when NOTSET

2022-03-04 Thread GitBox
dstandish opened a new pull request #22000: URL: https://github.com/apache/airflow/pull/22000 If params are NOTSET, then JSON validation will of course fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] RNHTTR edited a comment on issue #21972: Cycle detected in dag when there is no cycle using taskgroups and the taskflow api

2022-03-04 Thread GitBox
RNHTTR edited a comment on issue #21972: URL: https://github.com/apache/airflow/issues/21972#issuecomment-1059417995 I don't believe this is an import error. The offending error message can be found in [utils/dag_cycle_tester.py](https://github.com/apache/airflow/blob/efd365274a548e7dd859c

[GitHub] [airflow] RNHTTR commented on issue #21972: Cycle detected in dag when there is no cycle using taskgroups and the taskflow api

2022-03-04 Thread GitBox
RNHTTR commented on issue #21972: URL: https://github.com/apache/airflow/issues/21972#issuecomment-1059417995 I don't believe this is an import error. The offending error message can be found in [utils/dag_cycle_tester.py](https://github.com/apache/airflow/blob/efd365274a548e7dd859ca1823da

[airflow] branch main updated (b153a2e -> e81527c)

2022-03-04 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from b153a2e Add test to run DB downgrade in the CI (#21273) add e81527c Simplify tests for CLI connections comma

[GitHub] [airflow] dstandish merged pull request #21983: Simplify tests for CLI connections commands

2022-03-04 Thread GitBox
dstandish merged pull request #21983: URL: https://github.com/apache/airflow/pull/21983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [airflow] caxefaizan edited a comment on pull request #21990: missing quotes

2022-03-04 Thread GitBox
caxefaizan edited a comment on pull request #21990: URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059408977 > Should be lowercase true I think tried using lower case. didn't work. with and without quotes -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] caxefaizan commented on pull request #21990: missing quotes

2022-03-04 Thread GitBox
caxefaizan commented on pull request #21990: URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059408977 > Should be lowercase true I think tried using lower case. didn't work. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [airflow] github-actions[bot] commented on pull request #21990: missing quotes

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #21990: URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059406985 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] subkanthi opened a new pull request #21999: Added support to override auth_type in auth_file in pgbouncer helm configuration

2022-03-04 Thread GitBox
subkanthi opened a new pull request #21999: URL: https://github.com/apache/airflow/pull/21999 Added support to override auth_type in auth_file in pgbouncer helm configuration closes: #19654 --- **^ Add meaningful description above** Read the **[Pull Request

[GitHub] [airflow] potiuk commented on pull request #21990: missing quotes

2022-03-04 Thread GitBox
potiuk commented on pull request #21990: URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059405965 Should be lowercase true I think -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] github-actions[bot] commented on pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #21998: URL: https://github.com/apache/airflow/pull/21998#issuecomment-1059401971 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide

[GitHub] [airflow] github-actions[bot] commented on pull request #21983: Simplify tests for CLI connections commands

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #21983: URL: https://github.com/apache/airflow/pull/21983#issuecomment-1059401450 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[airflow] branch main updated (1949f5d -> b153a2e)

2022-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 1949f5d Change the storage of frame to use threadLocal rather than Dict (#21993) add b153a2e Add test to run D

[GitHub] [airflow] potiuk merged pull request #21273: Add test to run DB downgrade in the CI

2022-03-04 Thread GitBox
potiuk merged pull request #21273: URL: https://github.com/apache/airflow/pull/21273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[airflow] branch main updated: Change the storage of frame to use threadLocal rather than Dict (#21993)

2022-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1949f5d Change the storage of frame to use threadL

[GitHub] [airflow] potiuk merged pull request #21993: Change the storage of frame to use threadLocal rather than Dict

2022-03-04 Thread GitBox
potiuk merged pull request #21993: URL: https://github.com/apache/airflow/pull/21993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk opened a new pull request #21998: Remove misleading MSSQL information from the docs

2022-03-04 Thread GitBox
potiuk opened a new pull request #21998: URL: https://github.com/apache/airflow/pull/21998 Some of the past cherry-picks brought MSSQL information to Airflow docs in stable version. This should be removed. --- **^ Add meaningful description above** Read the **[Pul

[GitHub] [airflow] bbovenzi commented on pull request #21555: Add queue button to click-on-DagRun interface.

2022-03-04 Thread GitBox
bbovenzi commented on pull request #21555: URL: https://github.com/apache/airflow/pull/21555#issuecomment-1059375507 I updated the Run Modal UI: https://user-images.githubusercontent.com/4600967/156813390-4a005dea-d79c-40e8-ab33-8b4723a9cefa.png";> -- This is an automated messa

[airflow] branch main updated (2b4d146 -> 9ce45ff)

2022-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git. from 2b4d146 Fix changelog/updating typos (#21979) add 9ce45ff Rename 'S3' hook name to 'Amazon S3' (#21988) No new

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #21988: Rename 'S3' hook name to 'Amazon S3'

2022-03-04 Thread GitBox
boring-cyborg[bot] commented on pull request #21988: URL: https://github.com/apache/airflow/pull/21988#issuecomment-1059368007 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [airflow] potiuk merged pull request #21988: Rename 'S3' hook name to 'Amazon S3'

2022-03-04 Thread GitBox
potiuk merged pull request #21988: URL: https://github.com/apache/airflow/pull/21988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on pull request #21993: Change the storage of frame to use threadLocal rather than Dict

2022-03-04 Thread GitBox
potiuk commented on pull request #21993: URL: https://github.com/apache/airflow/pull/21993#issuecomment-1059365140 Looks like a docs-build inventory fetching problem only. Close/reopen to rebuild to be 100% sure. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] potiuk closed pull request #21993: Change the storage of frame to use threadLocal rather than Dict

2022-03-04 Thread GitBox
potiuk closed pull request #21993: URL: https://github.com/apache/airflow/pull/21993 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsub

[GitHub] [airflow] potiuk commented on issue #21987: Airflow S3 connection name

2022-03-04 Thread GitBox
potiuk commented on issue #21987: URL: https://github.com/apache/airflow/issues/21987#issuecomment-1059363849 Sure. Feel free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [airflow] steveyz-astro commented on pull request #21981: If uploading task logs to S3 fails, retry once

2022-03-04 Thread GitBox
steveyz-astro commented on pull request #21981: URL: https://github.com/apache/airflow/pull/21981#issuecomment-1059352470 @uranusjr generally the marginal benefit will be for a single retry. s3 oneshot uploads fail randomly very occasionally but failures do happen. Consecutive fa

[GitHub] [airflow] github-actions[bot] commented on pull request #21988: Rename 'S3' hook name to 'Amazon S3'

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #21988: URL: https://github.com/apache/airflow/pull/21988#issuecomment-1059364196 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not

[GitHub] [airflow] mik-laj commented on pull request #21988: Rename 'S3' hook name to 'Amazon S3'

2022-03-04 Thread GitBox
mik-laj commented on pull request #21988: URL: https://github.com/apache/airflow/pull/21988#issuecomment-1059364033 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] mik-laj commented on pull request #21991: Show import error for 'airflow dags list' CLI command

2022-03-04 Thread GitBox
mik-laj commented on pull request #21991: URL: https://github.com/apache/airflow/pull/21991#issuecomment-1059352655 Related PR: https://github.com/apache/airflow/pull/15087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] mik-laj commented on pull request #21991: Show import error for 'airflow dags list' CLI command

2022-03-04 Thread GitBox
mik-laj commented on pull request #21991: URL: https://github.com/apache/airflow/pull/21991#issuecomment-1059351450 Won't that cause problem for scripts that process the output of this command? I think we should display import errors on stderr. -- This is an automated message from the Ap

[GitHub] [airflow] eladkal closed issue #21995: Does not appear dags in mwaa

2022-03-04 Thread GitBox
eladkal closed issue #21995: URL: https://github.com/apache/airflow/issues/21995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [airflow] eladkal commented on issue #21995: Does not appear dags in mwaa

2022-03-04 Thread GitBox
eladkal commented on issue #21995: URL: https://github.com/apache/airflow/issues/21995#issuecomment-1059343518 Please report your issue to MWAA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] alekseiloginov commented on a change in pull request #20882: Add Looker PDT operators

2022-03-04 Thread GitBox
alekseiloginov commented on a change in pull request #20882: URL: https://github.com/apache/airflow/pull/20882#discussion_r819734146 ## File path: docs/apache-airflow-providers-google/operators/cloud/looker.rst ## @@ -39,29 +39,7 @@ To use these operators, you must do a few thi

[GitHub] [airflow] alekseiloginov commented on a change in pull request #20882: Add Looker PDT operators

2022-03-04 Thread GitBox
alekseiloginov commented on a change in pull request #20882: URL: https://github.com/apache/airflow/pull/20882#discussion_r819734146 ## File path: docs/apache-airflow-providers-google/operators/cloud/looker.rst ## @@ -39,29 +39,7 @@ To use these operators, you must do a few thi

[GitHub] [airflow] jedcunningham commented on a change in pull request #21991: Show import error for 'airflow dags list' CLI command

2022-03-04 Thread GitBox
jedcunningham commented on a change in pull request #21991: URL: https://github.com/apache/airflow/pull/21991#discussion_r819718094 ## File path: airflow/cli/commands/dag_command.py ## @@ -315,6 +315,12 @@ def dag_next_execution(args): def dag_list_dags(args): """Displays

[GitHub] [airflow] john-jac commented on issue #13824: Cloudwatch Integration: SIGTERM/SIGKILL Sent Following DAG Completion, Causing Errors in Worker Logs

2022-03-04 Thread GitBox
john-jac commented on issue #13824: URL: https://github.com/apache/airflow/issues/13824#issuecomment-1059316054 Thanks @andormarkus ! Are you able to reproduce when using the celery executor? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] ephraimbuddy commented on a change in pull request #21965: Mapped task instance endpoint

2022-03-04 Thread GitBox
ephraimbuddy commented on a change in pull request #21965: URL: https://github.com/apache/airflow/pull/21965#discussion_r819705023 ## File path: airflow/api_connexion/openapi/v1.yaml ## @@ -134,6 +134,7 @@ info: | v2.0 | Initial release | | v2.0.2| Added /plugins

[GitHub] [airflow] ephraimbuddy commented on issue #21947: "deadlock detected" error in dag table updates

2022-03-04 Thread GitBox
ephraimbuddy commented on issue #21947: URL: https://github.com/apache/airflow/issues/21947#issuecomment-1059294902 Deadlocks are fine except if they caused the scheduler to stop. From the log above, this happens in your database and does not stop your scheduler. Looks similar to this fix

[GitHub] [airflow] imbaczek commented on issue #21947: "deadlock detected" error in dag table updates

2022-03-04 Thread GitBox
imbaczek commented on issue #21947: URL: https://github.com/apache/airflow/issues/21947#issuecomment-1059285594 Just one active scheduler at a time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] github-actions[bot] commented on pull request #21993: Change the storage of frame to use threadLocal rather than Dict

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #21993: URL: https://github.com/apache/airflow/pull/21993#issuecomment-1059263633 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

[GitHub] [airflow] caxefaizan commented on pull request #21990: missing quotes

2022-03-04 Thread GitBox
caxefaizan commented on pull request #21990: URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059261424 shouldn't merge yet. it still is erroring out after adding quotes. airflow.exceptions.AirflowConfigException: Failed to convert value to bool. Please check "LOAD_EXA

[GitHub] [airflow] potiuk commented on a change in pull request #21993: Change the storage of frame to use threadLocal rather than Dict

2022-03-04 Thread GitBox
potiuk commented on a change in pull request #21993: URL: https://github.com/apache/airflow/pull/21993#discussion_r819664282 ## File path: airflow/models/taskinstance.py ## @@ -1746,14 +1745,23 @@ def handle_failure( if error: if isinstance(error, BaseEx

[GitHub] [airflow] github-actions[bot] commented on pull request #21965: Mapped task instance endpoint

2022-03-04 Thread GitBox
github-actions[bot] commented on pull request #21965: URL: https://github.com/apache/airflow/pull/21965#issuecomment-1059251874 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and ta

  1   2   >