[GitHub] [airflow] github-actions[bot] commented on pull request #22848: Disable foreign keys on sqlite when modifying dag_run

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #22848: URL: https://github.com/apache/airflow/pull/22848#issuecomment-1092482704 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk

[GitHub] [airflow] appassionate commented on issue #21867: Retry for TaskGroup

2022-04-07 Thread GitBox
appassionate commented on issue #21867: URL: https://github.com/apache/airflow/issues/21867#issuecomment-1092473308 Hi, I believe Taskgroup is supposed to have the same "retry” feature that subdagopt had. In other words, TaskGroup (in my opinion) might will be like a "sub-pipeline" that ca

[GitHub] [airflow] jedcunningham opened a new pull request, #22851: Revert "Print configuration on scheduler startup. (#22588)"

2022-04-07 Thread GitBox
jedcunningham opened a new pull request, #22851: URL: https://github.com/apache/airflow/pull/22851 This reverts commit 78586b45a0f6007ab6b94c35b33790a944856e5e from #22588. I played with incorporating these concepts into `airflow config list` behind flags tonight, but had trouble main

[GitHub] [airflow] dstandish commented on a diff in pull request #22848: Disable foreign keys on sqlite when modifying dag_run

2022-04-07 Thread GitBox
dstandish commented on code in PR #22848: URL: https://github.com/apache/airflow/pull/22848#discussion_r845742545 ## airflow/migrations/utils.py: ## @@ -41,3 +41,16 @@ def get_mssql_table_constraints(conn, table_name): for constraint, constraint_type, col_name in result:

[GitHub] [airflow] dstandish opened a new pull request, #22850: Fix purge dangling rows in pre-upgrade check

2022-04-07 Thread GitBox
dstandish opened a new pull request, #22850: URL: https://github.com/apache/airflow/pull/22850 WIP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

[airflow] branch main updated: Support conf param override for backfill runs (#22837)

2022-04-07 Thread houqp
This is an automated email from the ASF dual-hosted git repository. houqp pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 913eaa0e95 Support conf param override for backfill

[GitHub] [airflow] houqp merged pull request #22837: Support conf param override for backfill runs

2022-04-07 Thread GitBox
houqp merged PR #22837: URL: https://github.com/apache/airflow/pull/22837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.ap

[GitHub] [airflow] uranusjr commented on a diff in pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-07 Thread GitBox
uranusjr commented on code in PR #22699: URL: https://github.com/apache/airflow/pull/22699#discussion_r845733347 ## airflow/models/dag.py: ## @@ -2280,6 +2284,12 @@ def create_dagrun( "Creating DagRun needs either `run_id` or both `run_type` and `execution_date

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22848: Disable foreign keys on sqlite when modifying dag_run

2022-04-07 Thread GitBox
jedcunningham commented on code in PR #22848: URL: https://github.com/apache/airflow/pull/22848#discussion_r845732615 ## airflow/migrations/utils.py: ## @@ -41,3 +41,16 @@ def get_mssql_table_constraints(conn, table_name): for constraint, constraint_type, col_name in result

[GitHub] [airflow] jedcunningham commented on a diff in pull request #22848: Disable foreign keys on sqlite when modifying dag_run

2022-04-07 Thread GitBox
jedcunningham commented on code in PR #22848: URL: https://github.com/apache/airflow/pull/22848#discussion_r845732463 ## airflow/migrations/utils.py: ## @@ -41,3 +41,16 @@ def get_mssql_table_constraints(conn, table_name): for constraint, constraint_type, col_name in result

[GitHub] [airflow] github-actions[bot] commented on pull request #22804: Support log download in task log view

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #22804: URL: https://github.com/apache/airflow/pull/22804#issuecomment-1092435684 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] uranusjr opened a new pull request, #22849: Allow using mapped upstream's aggregated XCom

2022-04-07 Thread GitBox
uranusjr opened a new pull request, #22849: URL: https://github.com/apache/airflow/pull/22849 Fix #22833. This needs two changes. First, when the upstream pushes the return value to XCom, we need to identify that the pushed value is not used on its own, but only aggregated with other

[GitHub] [airflow] dstandish opened a new pull request, #22848: Disable foreign keys on sqlite when modifying dag_run

2022-04-07 Thread GitBox
dstandish opened a new pull request, #22848: URL: https://github.com/apache/airflow/pull/22848 If we do not disable FKs then it has the side effect of deleting all task instances. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] houqp closed pull request #22698: support dag serialization with custom ti_deps rules

2022-04-07 Thread GitBox
houqp closed pull request #22698: support dag serialization with custom ti_deps rules URL: https://github.com/apache/airflow/pull/22698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [airflow] houqp commented on pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-07 Thread GitBox
houqp commented on PR #22699: URL: https://github.com/apache/airflow/pull/22699#issuecomment-1092411914 updated code to disable button in the UI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] hankehly commented on a diff in pull request #22804: Support log download in task log view

2022-04-07 Thread GitBox
hankehly commented on code in PR #22804: URL: https://github.com/apache/airflow/pull/22804#discussion_r845710406 ## airflow/www/static/js/ti_log.js: ## @@ -153,4 +171,10 @@ $(document).ready(() => { const autoTailing = i === TOTAL_ATTEMPTS; autoTailingLog(i, null, auto

[GitHub] [airflow] uranusjr commented on a diff in pull request #22804: Support log download in task log view

2022-04-07 Thread GitBox
uranusjr commented on code in PR #22804: URL: https://github.com/apache/airflow/pull/22804#discussion_r845710038 ## airflow/www/static/js/ti_log.js: ## @@ -153,4 +171,10 @@ $(document).ready(() => { const autoTailing = i === TOTAL_ATTEMPTS; autoTailingLog(i, null, auto

[GitHub] [airflow] houqp commented on pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-07 Thread GitBox
houqp commented on PR #22699: URL: https://github.com/apache/airflow/pull/22699#issuecomment-1092401944 @ashb @uranusjr if we pass the responsibility to `Timetable.infer_manual_data_interval`, how do we enforce this given users can override `infer_manual_data_interval`'s behavior with subcl

[GitHub] [airflow] evanrosebrook commented on pull request #22676: Fix helm name override

2022-04-07 Thread GitBox
evanrosebrook commented on PR #22676: URL: https://github.com/apache/airflow/pull/22676#issuecomment-1092397752 Seems like a `lookup` based solution is the only viable option. I understand that it won't work for `dry-run`s etc, but I haven't been able to think of anything else. Any other id

[airflow] branch main updated: Temporarily disable task_fail pre-upgrade duplicates check (#22839)

2022-04-07 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 57884f93dd Temporarily disable task_fail pre-upg

[GitHub] [airflow] dstandish merged pull request #22839: Temporarily disable task_fail pre-upgrade duplicates check

2022-04-07 Thread GitBox
dstandish merged PR #22839: URL: https://github.com/apache/airflow/pull/22839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[airflow] branch main updated (1f29d84441 -> 4993c7c941)

2022-04-07 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 1f29d84441 Bump prismjs from 1.26.0 to 1.27.0 in /airflow/www (#22823) add 4993c7c941 Add 2.2.5 to revision hea

[GitHub] [airflow] dstandish merged pull request #22841: Add 2.2.5 to revision heads map

2022-04-07 Thread GitBox
dstandish merged PR #22841: URL: https://github.com/apache/airflow/pull/22841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[GitHub] [airflow] SasanAhmadi commented on issue #22836: Status of testing Providers that were prepared on April 07, 2022

2022-04-07 Thread GitBox
SasanAhmadi commented on issue #22836: URL: https://github.com/apache/airflow/issues/22836#issuecomment-1092319349 from my side: - testing for jenkins sensor was done: https://github.com/apache/airflow/pull/22421 - testing for jenkins job trigger operator was done: https://github.com/

[GitHub] [airflow] hankehly commented on pull request #22804: Support log download in task log view

2022-04-07 Thread GitBox
hankehly commented on PR #22804: URL: https://github.com/apache/airflow/pull/22804#issuecomment-1092318616 @uranusjr @bbovenzi Please check again at your earliest convenience -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] github-actions[bot] commented on pull request #21281: Mask secrets in stdout for `airflow tasks test ...` CLI command (#17476)

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #21281: URL: https://github.com/apache/airflow/pull/21281#issuecomment-1092317901 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on pull request #21431: [scheduler HA]catch sqlalchemy leaking LockNotAvailable Exception during multiple scheduler instances comes up

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #21431: URL: https://github.com/apache/airflow/pull/21431#issuecomment-1092317888 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22847: Click on Show record on List Users page gives error

2022-04-07 Thread GitBox
boring-cyborg[bot] commented on issue #22847: URL: https://github.com/apache/airflow/issues/22847#issuecomment-1092306095 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] l0n3r4n83r opened a new issue, #22847: Click on Show record on List Users page gives error

2022-04-07 Thread GitBox
l0n3r4n83r opened a new issue, #22847: URL: https://github.com/apache/airflow/issues/22847 ### Apache Airflow version 2.2.4 ### What happened Click Admin -> List Users -> Click on Show Record (Magnifying Glass icon) gives the following error ``` Python version:

[GitHub] [airflow] MatrixManAtYrService commented on issue #22843: When passing the 'False' value to the parameters of a decorated dag function I get this traceback

2022-04-07 Thread GitBox
MatrixManAtYrService commented on issue #22843: URL: https://github.com/apache/airflow/issues/22843#issuecomment-1092301293 This appears to be the case for any falsey value. Consider this dag: ```python3 @dag def paramstuff(x, a=Param(2, minimum=0)): @task def add(

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22846: UUID encoded in CassandraToGCSOperator but not other operators

2022-04-07 Thread GitBox
boring-cyborg[bot] commented on issue #22846: URL: https://github.com/apache/airflow/issues/22846#issuecomment-1092300050 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] fuxiao224 opened a new issue, #22846: UUID encoded in CassandraToGCSOperator but not other operators

2022-04-07 Thread GitBox
fuxiao224 opened a new issue, #22846: URL: https://github.com/apache/airflow/issues/22846 ### Apache Airflow version 2.2.5 (latest released) ### What happened I noticed that UUID is encoded in CassandraToGCSOperator by: `elif isinstance(value, UUID):

[GitHub] [airflow] MatrixManAtYrService commented on issue #22843: When passing the 'False' value to the parameters of a decorated dag function I get this traceback

2022-04-07 Thread GitBox
MatrixManAtYrService commented on issue #22843: URL: https://github.com/apache/airflow/issues/22843#issuecomment-1092280928 My initial feeling is that positional args on dag decorated functions should not be interpreted as dag params, so you could do things like this: ```python3 @t

[GitHub] [airflow] jedcunningham opened a new pull request, #22845: Cleanup dup code now that k8s provider requires 2.3.0+

2022-04-07 Thread GitBox
jedcunningham opened a new pull request, #22845: URL: https://github.com/apache/airflow/pull/22845 The kubernetes provider now requires core 2.3.0+, so we can safely dedup this code 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jedcunningham opened a new pull request, #22844: Docs: `remote_log_conn_id` can also be used to write logs

2022-04-07 Thread GitBox
jedcunningham opened a new pull request, #22844: URL: https://github.com/apache/airflow/pull/22844 Soften the language for `remote_log_conn_id` because some remote services do use it to write (s3). Related: #20499 -- This is an automated message from the Apache Git Service. To resp

[GitHub] [airflow] eladkal commented on pull request #22841: Add 2.2.5 to revision heads map

2022-04-07 Thread GitBox
eladkal commented on PR #22841: URL: https://github.com/apache/airflow/pull/22841#issuecomment-1092245810 Should we mention it as a step in https://github.com/apache/airflow/blob/main/dev/README_RELEASE_AIRFLOW.md -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] pateash commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
pateash commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092224154 @potiuk, I didn't mean to be rhetorical or disrespectful. I just wanted to have some discussion around this. As I have faced this scenario before as well in our usecases

[GitHub] [airflow] eladkal commented on issue #15994: Use inclusive words in Apache Airflow project

2022-04-07 Thread GitBox
eladkal commented on issue #15994: URL: https://github.com/apache/airflow/issues/15994#issuecomment-1092210860 PR for renaming `DummyOperator`: https://github.com/apache/airflow/pull/22832 The only task left on this issue is the task that this issue was created for :) We need a pr

[GitHub] [airflow] potiuk commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
potiuk commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092202617 > Why not? No. I specifically ask Why? - because when you want to add something you have to justify it rather than someone should justify why you should not do it. That's ver

[GitHub] [airflow] bbovenzi commented on issue #22762: Grid view details shows `_PythonDecoratedOperator` instead of `@task.python`

2022-04-07 Thread GitBox
bbovenzi commented on issue #22762: URL: https://github.com/apache/airflow/issues/22762#issuecomment-1092184960 Just heads up, this isn't just the API endpoint used by Grid view. Here is the same issue in Graph view: https://user-images.githubusercontent.com/4600967/162295951-488b3984

[GitHub] [airflow] eladkal commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
eladkal commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092180331 >and as @eladkal pointed out the following workaround has the issue that, it doesn't stop/skip the sensor which has not ran successfully yet. Yes but this is is not limited t

[GitHub] [airflow] eladkal commented on a diff in pull request #22758: Add S3CreateObjectOperator

2022-04-07 Thread GitBox
eladkal commented on code in PR #22758: URL: https://github.com/apache/airflow/pull/22758#discussion_r845540146 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -318,6 +318,94 @@ def execute(self, context: 'Context'): ) +class S3CreateObjectOperator(BaseOperat

[GitHub] [airflow] eladkal commented on a diff in pull request #22758: Add S3CreateObjectOperator

2022-04-07 Thread GitBox
eladkal commented on code in PR #22758: URL: https://github.com/apache/airflow/pull/22758#discussion_r845540146 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -318,6 +318,94 @@ def execute(self, context: 'Context'): ) +class S3CreateObjectOperator(BaseOperat

[GitHub] [airflow] vincbeck commented on issue #22836: Status of testing Providers that were prepared on April 07, 2022

2022-04-07 Thread GitBox
vincbeck commented on issue #22836: URL: https://github.com/apache/airflow/issues/22836#issuecomment-1092172728 All mine are doc and sample dag related so it's all good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] vincbeck commented on a diff in pull request #22758: Add S3CreateObjectOperator

2022-04-07 Thread GitBox
vincbeck commented on code in PR #22758: URL: https://github.com/apache/airflow/pull/22758#discussion_r84553 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -318,6 +318,94 @@ def execute(self, context: 'Context'): ) +class S3CreateObjectOperator(BaseOpera

[GitHub] [airflow] mnojek commented on issue #22836: Status of testing Providers that were prepared on April 07, 2022

2022-04-07 Thread GitBox
mnojek commented on issue #22836: URL: https://github.com/apache/airflow/issues/22836#issuecomment-1092170175 From my side the testing for Google was done :) #22311 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] houqp commented on a diff in pull request #22793: Support DAGRun type reset through the backfill command

2022-04-07 Thread GitBox
houqp commented on code in PR #22793: URL: https://github.com/apache/airflow/pull/22793#discussion_r845532972 ## airflow/models/dagrun.py: ## @@ -217,6 +217,12 @@ def set_state(self, state: DagRunState): if state == State.QUEUED: self.queued_at = ti

[GitHub] [airflow] houqp commented on a diff in pull request #22793: Support DAGRun type reset through the backfill command

2022-04-07 Thread GitBox
houqp commented on code in PR #22793: URL: https://github.com/apache/airflow/pull/22793#discussion_r845532544 ## airflow/models/dagrun.py: ## @@ -217,6 +217,12 @@ def set_state(self, state: DagRunState): if state == State.QUEUED: self.queued_at = ti

[GitHub] [airflow] pateash commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
pateash commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092166923 > > Ideally, We should have a sensor, which allows this > > Why? Why not? this is a really common scenario. and as @eladkal pointed out the following workaround

[GitHub] [airflow] eladkal commented on a diff in pull request #22758: Add S3CreateObjectOperator

2022-04-07 Thread GitBox
eladkal commented on code in PR #22758: URL: https://github.com/apache/airflow/pull/22758#discussion_r845531831 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -318,6 +318,94 @@ def execute(self, context: 'Context'): ) +class S3CreateObjectOperator(BaseOperat

[GitHub] [airflow] potiuk commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
potiuk commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092161450 > Ideally, We should have a sensor, which allows this Why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [airflow] pateash commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
pateash commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092160395 > Isn't that just? > ``` > s1 = Sensor() > s2 = Sensor() > op = Operator(trigger_rule='one_success') > [s1, s2] >> op > ``` > > I guess what missing to make

[GitHub] [airflow] tronlightracer opened a new issue, #22843: When passing the 'False' value to the parameters of a decorated dag function I get this traceback

2022-04-07 Thread GitBox
tronlightracer opened a new issue, #22843: URL: https://github.com/apache/airflow/issues/22843 ### Apache Airflow version 2.2.3 ### What happened When passing the `False` value to a decorated dag function I get this traceback below. Also the default value is not shown wh

[GitHub] [airflow] vincbeck commented on a diff in pull request #22758: Add S3CreateObjectOperator

2022-04-07 Thread GitBox
vincbeck commented on code in PR #22758: URL: https://github.com/apache/airflow/pull/22758#discussion_r845521556 ## airflow/providers/amazon/aws/operators/s3.py: ## @@ -318,6 +318,94 @@ def execute(self, context: 'Context'): ) +class S3CreateObjectOperator(BaseOpera

[GitHub] [airflow] potiuk commented on issue #22842: Environment variables for elastic search logging have no effect

2022-04-07 Thread GitBox
potiuk commented on issue #22842: URL: https://github.com/apache/airflow/issues/22842#issuecomment-1092146627 This is complete misunderstanding of elasticsearch configuration https://airflow.apache.org/docs/apache-airflow-providers-elasticsearch/stable/logging/index.html You won't get

[GitHub] [airflow] potiuk closed issue #22842: Environment variables for elastic search logging have no effect

2022-04-07 Thread GitBox
potiuk closed issue #22842: Environment variables for elastic search logging have no effect URL: https://github.com/apache/airflow/issues/22842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] boring-cyborg[bot] commented on issue #22842: Environment variables for elastic search logging have no effect

2022-04-07 Thread GitBox
boring-cyborg[bot] commented on issue #22842: URL: https://github.com/apache/airflow/issues/22842#issuecomment-1092129741 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] pastushenkoy opened a new issue, #22842: Environment variables for elastic search logging have no effect

2022-04-07 Thread GitBox
pastushenkoy opened a new issue, #22842: URL: https://github.com/apache/airflow/issues/22842 ### Apache Airflow version 2.2.5 (latest released) ### What happened When I start airflow in official docker container with command: ``` docker run \ -e AIRFLOW__E

[GitHub] [airflow] eladkal commented on issue #22816: Providing Composite Sensors

2022-04-07 Thread GitBox
eladkal commented on issue #22816: URL: https://github.com/apache/airflow/issues/22816#issuecomment-1092123370 Isn't that just? ``` s1 = Sensor() s2 = Sensor() op = Operator(trigger_rule='one_success') [s1, s2] >> op ``` I guess what missing to make it complete is whe

[GitHub] [airflow] collinmcnulty commented on pull request #22332: Events Timetable

2022-04-07 Thread GitBox
collinmcnulty commented on PR #22332: URL: https://github.com/apache/airflow/pull/22332#issuecomment-1092119473 I recreated the failing test locally with ``` ./breeze --github-image-id latest --backend sqlite --python 3.10 --db-reset --skip-mounting-local-sources --test-type Core she

[GitHub] [airflow] eladkal commented on a diff in pull request #22832: [WIP] Deprecate `DummyOperator` in favor of `EmptyOperator`

2022-04-07 Thread GitBox
eladkal commented on code in PR #22832: URL: https://github.com/apache/airflow/pull/22832#discussion_r845490726 ## airflow/serialization/serialized_objects.py: ## @@ -629,7 +629,7 @@ def _serialize_node(cls, op: Union[BaseOperator, MappedOperator], include_deps: serial

[GitHub] [airflow] github-actions[bot] commented on pull request #22841: Add 2.2.5 to revision heads map

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #22841: URL: https://github.com/apache/airflow/pull/22841#issuecomment-1092114435 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk

[GitHub] [airflow] dstandish opened a new pull request, #22841: Add 2.2.5 to revision heads map

2022-04-07 Thread GitBox
dstandish opened a new pull request, #22841: URL: https://github.com/apache/airflow/pull/22841 This is necessary to allow for downgrade to 2.2.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] tanelk commented on issue #20982: Triggered tasks from web-ui are killed by scheduler because they are orphaned task instances

2022-04-07 Thread GitBox
tanelk commented on issue #20982: URL: https://github.com/apache/airflow/issues/20982#issuecomment-1092089810 I have never worked with kubernetes, but based on the triggering code: https://github.com/apache/airflow/blob/1f29d844411522e9a2cd4a14c3573e903b4e5074/airflow/www/views.py#L1786-L

[GitHub] [airflow] github-actions[bot] commented on pull request #22840: Better handle Grid auto-refresh errors

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #22840: URL: https://github.com/apache/airflow/pull/22840#issuecomment-1092087079 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] potiuk commented on issue #22448: Migrate HTTP example DAGs to new design

2022-04-07 Thread GitBox
potiuk commented on issue #22448: URL: https://github.com/apache/airflow/issues/22448#issuecomment-1092086813 Feel free. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated (56ab82ed7a -> 1f29d84441)

2022-04-07 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 56ab82ed7a Prepare mid-April provider documentation. (#22819) add 1f29d84441 Bump prismjs from 1.26.0 to 1.27.0

[GitHub] [airflow] bbovenzi merged pull request #22823: Bump prismjs from 1.26.0 to 1.27.0 in /airflow/www

2022-04-07 Thread GitBox
bbovenzi merged PR #22823: URL: https://github.com/apache/airflow/pull/22823 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[GitHub] [airflow] bbovenzi opened a new pull request, #22840: Better handle Grid auto-refresh errors

2022-04-07 Thread GitBox
bbovenzi opened a new pull request, #22840: URL: https://github.com/apache/airflow/pull/22840 If there was an error during autorefresh in Grid view. The page would crash because we weren't handling the error well. `axios` handles errors better than fetch so I swapped that in and added a toa

[airflow] 01/01: Better handle auto-refresh errors

2022-04-07 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a commit to branch handle-grid-autorefresh-errors in repository https://gitbox.apache.org/repos/asf/airflow.git commit 9c8f84b794673f06b808f8c35be652d416671e97 Author: Brent Bovenzi AuthorDate: Thu Apr 7 14:29:16

[airflow] branch handle-grid-autorefresh-errors created (now 9c8f84b794)

2022-04-07 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch handle-grid-autorefresh-errors in repository https://gitbox.apache.org/repos/asf/airflow.git at 9c8f84b794 Better handle auto-refresh errors This branch includes the following new commit

[GitHub] [airflow] github-actions[bot] commented on pull request #22839: Temporarily disable task_fail pre-upgrade duplicates check

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #22839: URL: https://github.com/apache/airflow/pull/22839#issuecomment-1092048404 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk

[GitHub] [airflow] dstandish opened a new pull request, #22839: Temporarily disable task_fail pre-upgrade duplicates check

2022-04-07 Thread GitBox
dstandish opened a new pull request, #22839: URL: https://github.com/apache/airflow/pull/22839 I am reworking it to actually move the rows but for now we can disable it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] potiuk commented on issue #21104: Breeze: Exec'ing into running Breeze

2022-04-07 Thread GitBox
potiuk commented on issue #21104: URL: https://github.com/apache/airflow/issues/21104#issuecomment-1092029499 Please :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [airflow] Siraj-Qazi commented on pull request #21053: Fix: Exception when parsing log #20966

2022-04-07 Thread GitBox
Siraj-Qazi commented on PR #21053: URL: https://github.com/apache/airflow/pull/21053#issuecomment-1092019535 @microhuang where you @? > @microhuang do you wish to finish the work on this PR? -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [airflow] houqp commented on pull request #22698: support dag serialization with custom ti_deps rules

2022-04-07 Thread GitBox
houqp commented on PR #22698: URL: https://github.com/apache/airflow/pull/22698#issuecomment-1092010940 @ashb pushed a new version to raise serialization error exception in both serialization and deserialization code paths so user will be always aware of the problem. -- This is an automa

[GitHub] [airflow] Bowrna commented on pull request #22811: AIP-47 es new system tests

2022-04-07 Thread GitBox
Bowrna commented on PR #22811: URL: https://github.com/apache/airflow/pull/22811#issuecomment-1092007009 I get the following error when I run the test using pytest in breeze environment for Elasticsearch. Could you share your insights on where I am going wrong? I have configured to run the

[GitHub] [airflow] Bowrna commented on issue #21104: Breeze: Exec'ing into running Breeze

2022-04-07 Thread GitBox
Bowrna commented on issue #21104: URL: https://github.com/apache/airflow/issues/21104#issuecomment-1092004045 @potiuk Shall I pick up this task? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] github-actions[bot] commented on pull request #22837: Support conf param override for backfill runs

2022-04-07 Thread GitBox
github-actions[bot] commented on PR #22837: URL: https://github.com/apache/airflow/pull/22837#issuecomment-1091979189 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk

[GitHub] [airflow] eugene-nikolaev commented on issue #16163: Confusing log for long running tasks: "dependency 'Task Instance Not Running' FAILED: Task is in the running state"

2022-04-07 Thread GitBox
eugene-nikolaev commented on issue #16163: URL: https://github.com/apache/airflow/issues/16163#issuecomment-1091972835 Hi! Just ran into the issue, having an "amqp://" starting broker url. Will it be fixed in 2.3.0? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [airflow] PronetAI opened a new pull request, #22838: Update list-integrations.py

2022-04-07 Thread GitBox
PronetAI opened a new pull request, #22838: URL: https://github.com/apache/airflow/pull/22838 Lets us put all of the import modules into one file for file reduction, also one quick questions, why are we importing from airflow.hooks.base import BaseHook from airflow.models.baseoperator

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #22838: Update list-integrations.py

2022-04-07 Thread GitBox
boring-cyborg[bot] commented on PR #22838: URL: https://github.com/apache/airflow/pull/22838#issuecomment-1091972008 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] uranusjr commented on pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-07 Thread GitBox
uranusjr commented on PR #22699: URL: https://github.com/apache/airflow/pull/22699#issuecomment-1091970513 That’d work. Another solution I can think of is to introduce a helper class: ```python from airflow.timetables import ScheduleInterval DAG(timetable=ScheduleInterval(wha

[GitHub] [airflow] uranusjr commented on a diff in pull request #22787: Set Grid view data as camelCase in webserver

2022-04-07 Thread GitBox
uranusjr commented on code in PR #22787: URL: https://github.com/apache/airflow/pull/22787#discussion_r845357929 ## airflow/www/utils.py: ## @@ -113,6 +113,17 @@ def get_mapped_summary(parent_instance, task_instances): if parent_instance.prev_attempted_tries != 0

[airflow] branch providers-amazon created (now f77417eb0d)

2022-04-07 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch providers-amazon in repository https://gitbox.apache.org/repos/asf/airflow.git at f77417eb0d Fix K8S changelog to be PyPI-compatible (#20614) No new revisions were added by this update.

[GitHub] [airflow] dan-vaughan commented on pull request #22182: Add securityContext config for Redis to helm chart

2022-04-07 Thread GitBox
dan-vaughan commented on PR #22182: URL: https://github.com/apache/airflow/pull/22182#issuecomment-1091966854 @jedcunningham I fixed a test error & have tested locally, I think I need you to trigger the full set of unit-tests before we merge this in? -- This is an automated message from t

[GitHub] [airflow] ashb commented on a diff in pull request #22787: Set Grid view data as camelCase in webserver

2022-04-07 Thread GitBox
ashb commented on code in PR #22787: URL: https://github.com/apache/airflow/pull/22787#discussion_r845353739 ## airflow/www/static/js/tree/treeDataUtils.js: ## @@ -17,5 +17,13 @@ * under the License. */ -// eslint-disable-next-line import/prefer-default-export export cons

[airflow] branch camelCase-tree-data updated (bf5119c985 -> 127fc674ec)

2022-04-07 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch camelCase-tree-data in repository https://gitbox.apache.org/repos/asf/airflow.git from bf5119c985 Use JSON.parse() for treeData add 127fc674ec Fix test, swap formatData to a parseJson

[GitHub] [airflow] houqp opened a new pull request, #22837: Support conf param override for backfill runs

2022-04-07 Thread GitBox
houqp opened a new pull request, #22837: URL: https://github.com/apache/airflow/pull/22837 It was not possible to trigger a backfill run with a different dag run conf prior to this rix. --- **^ Add meaningful description above** Read the **[Pull Request Guid

[GitHub] [airflow] ashb commented on pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-07 Thread GitBox
ashb commented on PR #22699: URL: https://github.com/apache/airflow/pull/22699#issuecomment-1091920130 Oh yeah -- maybe we move the handling of the param to Timetable classes, but accept the parameter on the DAG constructor? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] uranusjr commented on pull request #22699: add allow_manual DAG argument to prevent scheduled DAGs from being triggered manually

2022-04-07 Thread GitBox
uranusjr commented on PR #22699: URL: https://github.com/apache/airflow/pull/22699#issuecomment-1091911716 Adding it to the timetable sounds like the right thing, but has the obvious downside of making easy cases currently using `schedule_interval` much more verbose. -- This is an automa

[airflow] branch camelCase-tree-data updated (0552abc465 -> bf5119c985)

2022-04-07 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch camelCase-tree-data in repository https://gitbox.apache.org/repos/asf/airflow.git from 0552abc465 Fix react tests add bf5119c985 Use JSON.parse() for treeData No new revisions were ad

[GitHub] [airflow] bbovenzi commented on issue #22774: UI bug in recent chromium when search for a variable

2022-04-07 Thread GitBox
bbovenzi commented on issue #22774: URL: https://github.com/apache/airflow/issues/22774#issuecomment-1091910385 @parisni Could you add a screenshot of the filter you are trying to apply? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [airflow] uranusjr commented on a diff in pull request #22671: Support for sorting DAGs in the web UI

2022-04-07 Thread GitBox
uranusjr commented on code in PR #22671: URL: https://github.com/apache/airflow/pull/22671#discussion_r845302277 ## airflow/www/views.py: ## @@ -756,13 +758,13 @@ def index(self): current_dags = all_dags num_of_all_dags = all_dags_count -

[GitHub] [airflow] potiuk opened a new issue, #22836: Status of testing Providers that were prepared on April 07, 2022

2022-04-07 Thread GitBox
potiuk opened a new issue, #22836: URL: https://github.com/apache/airflow/issues/22836 ### Body I have a kind request for all the contributors to the latest provider packages release. Could you please help us to test the RC versions of the providers? Let us know in the comme

[GitHub] [airflow] bbovenzi commented on a diff in pull request #22835: Remove extraneous json parsing in Calendar and Grid

2022-04-07 Thread GitBox
bbovenzi commented on code in PR #22835: URL: https://github.com/apache/airflow/pull/22835#discussion_r845297135 ## airflow/www/static/js/calendar.js: ## @@ -63,9 +63,6 @@ const dateFormat = '-MM-DD'; document.addEventListener('DOMContentLoaded', () => { $('span.status_s

[airflow-site] branch add-documentation-2022-04-07 created (now d14ab02dd)

2022-04-07 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-documentation-2022-04-07 in repository https://gitbox.apache.org/repos/asf/airflow-site.git at d14ab02dd Add documentation for packages - 2022-04-07 This branch includes the following

[GitHub] [airflow] ashb commented on a diff in pull request #22835: Remove extraneous json parsing in Calendar and Grid

2022-04-07 Thread GitBox
ashb commented on code in PR #22835: URL: https://github.com/apache/airflow/pull/22835#discussion_r845294811 ## airflow/www/static/js/calendar.js: ## @@ -63,9 +63,6 @@ const dateFormat = '-MM-DD'; document.addEventListener('DOMContentLoaded', () => { $('span.status_squar

[GitHub] [airflow] bbovenzi closed pull request #22835: Remove extraneous json parsing in Calendar and Grid

2022-04-07 Thread GitBox
bbovenzi closed pull request #22835: Remove extraneous json parsing in Calendar and Grid URL: https://github.com/apache/airflow/pull/22835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [airflow] ashb commented on a diff in pull request #22835: Remove extraneous json parsing in Calendar and Grid

2022-04-07 Thread GitBox
ashb commented on code in PR #22835: URL: https://github.com/apache/airflow/pull/22835#discussion_r845293558 ## airflow/www/static/js/calendar.js: ## @@ -63,9 +63,6 @@ const dateFormat = '-MM-DD'; document.addEventListener('DOMContentLoaded', () => { $('span.status_squar

  1   2   3   >