[GitHub] [airflow] github-actions[bot] commented on pull request #23180: Fix LocalFilesystemToS3Operator and S3CreateObjectOperator to support full s3:// style keys

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #23180: URL: https://github.com/apache/airflow/pull/23180#issuecomment-1120147295 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] feluelle commented on issue #23514: Json files from S3 downloading as text files

2022-05-06 Thread GitBox
feluelle commented on issue #23514: URL: https://github.com/apache/airflow/issues/23514#issuecomment-1120145961 Hi @kalyani-subbiah, I would say we can change this behavior to use open and write to a real file instead of a temp file as like you said you can properly set the file name

[GitHub] [airflow] eladkal commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
eladkal commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867312062 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_type=ident

[airflow] branch main updated: Update the Athena Sample DAG and Docs (#23428)

2022-05-06 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 46af5baba8 Update the Athena Sample DAG and Docs (

[GitHub] [airflow] eladkal merged pull request #23428: Update the Athena Sample DAG and Docs

2022-05-06 Thread GitBox
eladkal merged PR #23428: URL: https://github.com/apache/airflow/pull/23428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow] branch main updated: Fix accidental including of providers in airflow package (#23552)

2022-05-06 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 29ec8d0a06 Fix accidental including of providers i

[GitHub] [airflow] eladkal merged pull request #23552: Fix accidental including of providers in airflow package

2022-05-06 Thread GitBox
eladkal merged PR #23552: URL: https://github.com/apache/airflow/pull/23552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[GitHub] [airflow] github-actions[bot] commented on pull request #23549: Change chart annotation generator to use RELEASE_NOTES

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #23549: URL: https://github.com/apache/airflow/pull/23549#issuecomment-1120128209 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] zachliu commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-05-06 Thread GitBox
zachliu commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1120127422 further investigation shows that we are removing the same "permissions" and "permission views" repeatedly and trying to add them back repeatedly: ``` webserver_1 | [2022-05-0

[GitHub] [airflow] github-actions[bot] commented on pull request #23551: Add logging in to Github Registry for breeze pull

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #23551: URL: https://github.com/apache/airflow/pull/23551#issuecomment-1120127098 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk

[GitHub] [airflow] github-actions[bot] commented on pull request #23552: Fix accidental including of providers in airflow package

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #23552: URL: https://github.com/apache/airflow/pull/23552#issuecomment-1120113227 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] jedcunningham closed pull request #23548: Helm chart 1.6.0rc1

2022-05-06 Thread GitBox
jedcunningham closed pull request #23548: Helm chart 1.6.0rc1 URL: https://github.com/apache/airflow/pull/23548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] rahulgoyal2987 commented on a diff in pull request #23490: Fixed Kubernetes Operator large xcom content Defect

2022-05-06 Thread GitBox
rahulgoyal2987 commented on code in PR #23490: URL: https://github.com/apache/airflow/pull/23490#discussion_r867287298 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -368,20 +368,25 @@ def extract_xcom(self, pod: V1Pod) -> str: _preload_content

[GitHub] [airflow] potiuk opened a new pull request, #23552: Fix accidental including of providers in airflow package

2022-05-06 Thread GitBox
potiuk opened a new pull request, #23552: URL: https://github.com/apache/airflow/pull/23552 The change #23454 accidentally remove INSTALL_PROVIDERS_FROM_SOURCES setting to "false" which resulted in airflow package containing all providers. This has been caught by our tests (but it was o

[GitHub] [airflow] github-actions[bot] commented on pull request #22184: Add run_id and map_index to SlaMiss

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #22184: URL: https://github.com/apache/airflow/pull/22184#issuecomment-1120085434 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on pull request #22393: Update redis_pub_sub.py

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #22393: URL: https://github.com/apache/airflow/pull/22393#issuecomment-1120085399 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on pull request #21283: Cleanup session.commit() when @provide_session decorator is used

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #21283: URL: https://github.com/apache/airflow/pull/21283#issuecomment-1120085463 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] closed pull request #21890: Update google-cloud-spanner version

2022-05-06 Thread GitBox
github-actions[bot] closed pull request #21890: Update google-cloud-spanner version URL: https://github.com/apache/airflow/pull/21890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [airflow] github-actions[bot] commented on pull request #22210: fix AttributeError

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #22210: URL: https://github.com/apache/airflow/pull/22210#issuecomment-1120085427 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on pull request #22214: Make SlaMiss test stricter

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #22214: URL: https://github.com/apache/airflow/pull/22214#issuecomment-1120085412 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] repl-chris commented on pull request #23432: Automatically reschedule stuck queued tasks in CeleryExecutor

2022-05-06 Thread GitBox
repl-chris commented on PR #23432: URL: https://github.com/apache/airflow/pull/23432#issuecomment-1120081308 > For that reason I think I'd like you to look at If we can see if the taskmeta is _actually_ lost, to separate "lost" from "just in a queue behind n long running tasks." @ash

[airflow] branch main updated (3ed0747464 -> 4058bae652)

2022-05-06 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 3ed0747464 Seperate provider verification as standalone breeze command (#23454) add 4058bae652 Replace `pytest.ma

[GitHub] [airflow] potiuk merged pull request #23541: Replace `pytest.mark.xfail` in Postgres tests

2022-05-06 Thread GitBox
potiuk merged PR #23541: URL: https://github.com/apache/airflow/pull/23541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk opened a new pull request, #23551: Add logging in to Github Registry for breeze pull

2022-05-06 Thread GitBox
potiuk opened a new pull request, #23551: URL: https://github.com/apache/airflow/pull/23551 All of the Airlfow Images are Public in ghcr.io but default setting for iamges is "private" and when users want to build CI workflows in their forks, had to manually change their images to Public

[GitHub] [airflow] epapineau commented on pull request #22938: Enable dbt Cloud provider to interact with single tenant instances

2022-05-06 Thread GitBox
epapineau commented on PR #22938: URL: https://github.com/apache/airflow/pull/22938#issuecomment-1120075557 @sungchun12 Added to the PR. Please let me know if you'd like any others :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] jedcunningham commented on pull request #23450: Add await all containers option to Kubernetes Pod Operator

2022-05-06 Thread GitBox
jedcunningham commented on PR #23450: URL: https://github.com/apache/airflow/pull/23450#issuecomment-1120072563 I'm wondering if instead we should just check the `base` container state, not just wait until any container finishes. We also need to be mindful of how this will play with

[GitHub] [airflow] github-actions[bot] commented on pull request #23541: Replace `pytest.mark.xfail` in Postgres tests

2022-05-06 Thread GitBox
github-actions[bot] commented on PR #23541: URL: https://github.com/apache/airflow/pull/23541#issuecomment-1120067794 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] repl-chris commented on a diff in pull request #23432: Automatically reschedule stuck queued tasks in CeleryExecutor

2022-05-06 Thread GitBox
repl-chris commented on code in PR #23432: URL: https://github.com/apache/airflow/pull/23432#discussion_r867255995 ## airflow/executors/celery_executor.py: ## @@ -358,6 +369,71 @@ def _check_for_stalled_adopted_tasks(self): for key in timedout_keys:

[GitHub] [airflow] potiuk merged pull request #23454: Separate provider verification as standalone breeze command

2022-05-06 Thread GitBox
potiuk merged PR #23454: URL: https://github.com/apache/airflow/pull/23454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk closed issue #23430: CI: Rewrite provider verification as Breeze command

2022-05-06 Thread GitBox
potiuk closed issue #23430: CI: Rewrite provider verification as Breeze command URL: https://github.com/apache/airflow/issues/23430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [airflow] potiuk commented on pull request #23454: Separate provider verification as standalone breeze command

2022-05-06 Thread GitBox
potiuk commented on PR #23454: URL: https://github.com/apache/airflow/pull/23454#issuecomment-1120060738 Just random failiure. Merging finally ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] repl-chris commented on a diff in pull request #23432: Automatically reschedule stuck queued tasks in CeleryExecutor

2022-05-06 Thread GitBox
repl-chris commented on code in PR #23432: URL: https://github.com/apache/airflow/pull/23432#discussion_r867250315 ## airflow/config_templates/config.yml: ## @@ -1788,6 +1788,13 @@ type: string example: ~ default: "False" +- name: stuck_queued_task_check

[GitHub] [airflow] kalyani-subbiah commented on issue #23514: Json files from S3 downloading as text files

2022-05-06 Thread GitBox
kalyani-subbiah commented on issue #23514: URL: https://github.com/apache/airflow/issues/23514#issuecomment-1120046815 I see. In my project since I'm downloading a lot of files, the filenames are important to keep track of what the contents are. When it gets downloaded as a temp file with a

[GitHub] [airflow] fritz-astronomer opened a new issue, #23550: Dynamic Task Mapping is Immutable within a Run

2022-05-06 Thread GitBox
fritz-astronomer opened a new issue, #23550: URL: https://github.com/apache/airflow/issues/23550 ### Apache Airflow version 2.3.0 (latest released) ### What happened Looks like mapped tasks are immutable, even when the source XCOM that created them changes. This

[GitHub] [airflow] jedcunningham opened a new pull request, #23549: Change chart annotation generator to use RELEASE_NOTES

2022-05-06 Thread GitBox
jedcunningham opened a new pull request, #23549: URL: https://github.com/apache/airflow/pull/23549 The script that builds the changelog for ArtifactHub needs to be updated to use the new RELEASE_NOTES. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] jedcunningham opened a new pull request, #23548: Helm chart 1.6.0rc1

2022-05-06 Thread GitBox
jedcunningham opened a new pull request, #23548: URL: https://github.com/apache/airflow/pull/23548 Time to release an RC1 for the helm chart! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
pierrejeambrun commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867219719 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_typ

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
pierrejeambrun commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867219719 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_typ

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
pierrejeambrun commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867219719 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_typ

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
pierrejeambrun commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867219719 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_typ

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
pierrejeambrun commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867219719 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_typ

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
pierrejeambrun commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r867219719 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_typ

[GitHub] [airflow] potiuk commented on pull request #23391: Add slim images to release process

2022-05-06 Thread GitBox
potiuk commented on PR #23391: URL: https://github.com/apache/airflow/pull/23391#issuecomment-1119996791 I think all comments address. Thanks @jedcunningham for all the grammar corrections too :) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [airflow] repl-chris commented on a diff in pull request #23432: Automatically reschedule stuck queued tasks in CeleryExecutor

2022-05-06 Thread GitBox
repl-chris commented on code in PR #23432: URL: https://github.com/apache/airflow/pull/23432#discussion_r867199084 ## airflow/executors/celery_executor.py: ## @@ -358,6 +369,71 @@ def _check_for_stalled_adopted_tasks(self): for key in timedout_keys:

[GitHub] [airflow] vincbeck opened a new pull request, #23547: Add doc and sample dag for EC2

2022-05-06 Thread GitBox
vincbeck opened a new pull request, #23547: URL: https://github.com/apache/airflow/pull/23547 Add doc and sample dag for EC2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] vincbeck commented on a diff in pull request #21863: Add Quicksight create ingestion Hook and Operator

2022-05-06 Thread GitBox
vincbeck commented on code in PR #21863: URL: https://github.com/apache/airflow/pull/21863#discussion_r867176559 ## airflow/providers/amazon/aws/example_dags/example_quicksight.py: ## @@ -0,0 +1,65 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contr

[GitHub] [airflow] repl-chris commented on pull request #23462: Fix broken dagrun links when many runs start at the same time

2022-05-06 Thread GitBox
repl-chris commented on PR #23462: URL: https://github.com/apache/airflow/pull/23462#issuecomment-1119979760 > > @repl-chris Do you mind updating the branch to the latest on main? I think that could solve the failing checks @bbovenzi ok, I have rebased it on latest `ma

[GitHub] [airflow] boring-cyborg[bot] commented on issue #23546: Gantt Chart Broken After Deleting a Task

2022-05-06 Thread GitBox
boring-cyborg[bot] commented on issue #23546: URL: https://github.com/apache/airflow/issues/23546#issuecomment-1119972502 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] joelossher opened a new issue, #23546: Gantt Chart Broken After Deleting a Task

2022-05-06 Thread GitBox
joelossher opened a new issue, #23546: URL: https://github.com/apache/airflow/issues/23546 ### Apache Airflow version 2.2.5 ### What happened After a task was deleted from a DAG we received the following message when visiting the gantt view for the DAG in the webserver.

[GitHub] [airflow] eladkal commented on issue #23519: Calendar view is taking too long to load in airflow 2.3.0

2022-05-06 Thread GitBox
eladkal commented on issue #23519: URL: https://github.com/apache/airflow/issues/23519#issuecomment-1119967446 Please add more information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [airflow] potiuk commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
potiuk commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119962502 And to repeat what I've already stated - you **Cannot** base your business continuity on the fact if we release or not. -- This is an automated message from the Apache Git Servic

[GitHub] [airflow] potiuk commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
potiuk commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119962114 When it's ready @SarbjitGahra . This is the only answer we can giv as we do not know if we won't find any regressions that will prevent us from releasing. -- This is an automated

[GitHub] [airflow] SarbjitGahra commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
SarbjitGahra commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119961513 Thank you for the information. When do you expect to release this version ? -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23116: TrinoHook add authentication via JWT token and Impersonation

2022-05-06 Thread GitBox
boring-cyborg[bot] commented on PR #23116: URL: https://github.com/apache/airflow/pull/23116#issuecomment-1119959261 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] eladkal closed issue #18969: Trino JWT Authentication Support

2022-05-06 Thread GitBox
eladkal closed issue #18969: Trino JWT Authentication Support URL: https://github.com/apache/airflow/issues/18969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[airflow] branch main updated: TrinoHook add authentication via JWT token and Impersonation (#23116)

2022-05-06 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ccb5ce934c TrinoHook add authentication via JWT to

[GitHub] [airflow] eladkal merged pull request #23116: TrinoHook add authentication via JWT token and Impersonation

2022-05-06 Thread GitBox
eladkal merged PR #23116: URL: https://github.com/apache/airflow/pull/23116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[GitHub] [airflow] potiuk commented on pull request #22965: Upgrade to support Google Ads v10

2022-05-06 Thread GitBox
potiuk commented on PR #22965: URL: https://github.com/apache/airflow/pull/22965#issuecomment-1119945340 Just wanted you to give heads up @SarbjitGahra @anthonyjgraff that if your business continuity depends on the ads, this is not something our decisions on releasing or not releasing the p

[GitHub] [airflow] potiuk commented on pull request #22965: Upgrade to support Google Ads v10

2022-05-06 Thread GitBox
potiuk commented on PR #22965: URL: https://github.com/apache/airflow/pull/22965#issuecomment-1119942565 > Sounds great. Just as a heads up, V8 of the API will stop working on Wednesday 11th - definitely makes sense to group the Google Provider changes together, but we'll be a bit stuck if

[GitHub] [airflow] eladkal commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
eladkal commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119933223 The issue is resolved in main we just didn't release the new version yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] SarbjitGahra commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
SarbjitGahra commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119928131 Hi @eladkal The original issue never resolved the main problem. Comments by the author of the original issue- >Sounds great. Just as a heads up, V8 of the API will s

[GitHub] [airflow] SarbjitGahra commented on pull request #22965: Upgrade to support Google Ads v10

2022-05-06 Thread GitBox
SarbjitGahra commented on PR #22965: URL: https://github.com/apache/airflow/pull/22965#issuecomment-1119926688 > Sounds great. Just as a heads up, V8 of the API will stop working on Wednesday 11th - definitely makes sense to group the Google Provider changes together, but we'll be a bit stu

[GitHub] [airflow] eladkal closed issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
eladkal closed issue #23543: apache-airflow-providers-google not compatible with google-ads URL: https://github.com/apache/airflow/issues/23543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] eladkal commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
eladkal commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119918432 Duplicated https://github.com/apache/airflow/issues/22111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] boring-cyborg[bot] commented on issue #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
boring-cyborg[bot] commented on issue #23543: URL: https://github.com/apache/airflow/issues/23543#issuecomment-1119914765 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] SarbjitGahra opened a new issue, #23543: apache-airflow-providers-google not compatible with google-ads

2022-05-06 Thread GitBox
SarbjitGahra opened a new issue, #23543: URL: https://github.com/apache/airflow/issues/23543 ### Apache Airflow Provider(s) google ### Versions of Apache Airflow Providers apache-airflow-providers-google6.8.0 apache-airflow-providers-amazon3.2.0 apach

[GitHub] [airflow] tagoad opened a new issue, #23542: Grid View: Task order rearranges constantly with auto-refresh on

2022-05-06 Thread GitBox
tagoad opened a new issue, #23542: URL: https://github.com/apache/airflow/issues/23542 ### Apache Airflow version 2.3.0 (latest released) ### What happened While navigating the Grid view with auto refresh on the list of tasks is constantly rearranging. You can have the t

[GitHub] [airflow] boring-cyborg[bot] commented on issue #23542: Grid View: Task order rearranges constantly with auto-refresh on

2022-05-06 Thread GitBox
boring-cyborg[bot] commented on issue #23542: URL: https://github.com/apache/airflow/issues/23542#issuecomment-1119914561 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] bbovenzi commented on pull request #23462: Fix broken dagrun links when many runs start at the same time

2022-05-06 Thread GitBox
bbovenzi commented on PR #23462: URL: https://github.com/apache/airflow/pull/23462#issuecomment-1119875439 @repl-chris Do you mind updating the branch to the latest on main? I think that could solve the failing checks -- This is an automated message from the Apache Git Service. To respond

[GitHub] [airflow] tirkarthi commented on issue #23533: Using `expand` on `PostgresOperator` with return value from `PythonOperator` crashes scheduler

2022-05-06 Thread GitBox
tirkarthi commented on issue #23533: URL: https://github.com/apache/airflow/issues/23533#issuecomment-1119869540 The `RuntimeError` related changes were https://github.com/apache/airflow/pull/21641 . cc: @uranusjr -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] o-nikolas commented on a diff in pull request #23470: Fix conn close error on retrieving log events

2022-05-06 Thread GitBox
o-nikolas commented on code in PR #23470: URL: https://github.com/apache/airflow/pull/23470#discussion_r867059888 ## airflow/providers/amazon/aws/operators/ecs.py: ## @@ -139,6 +139,9 @@ def _get_log_events(self, skip: int = 0) -> Generator: self.logger.warning(

[GitHub] [airflow] o-nikolas commented on a diff in pull request #23490: Fixed Kubernetes Operator large xcom content Defect

2022-05-06 Thread GitBox
o-nikolas commented on code in PR #23490: URL: https://github.com/apache/airflow/pull/23490#discussion_r867059383 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -368,20 +368,25 @@ def extract_xcom(self, pod: V1Pod) -> str: _preload_content=Fals

[airflow] branch main updated: Update docs Amazon Glacier Docs (#23372)

2022-05-06 Thread jhtimmins
This is an automated email from the ASF dual-hosted git repository. jhtimmins pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6065d1203e Update docs Amazon Glacier Docs (#233

[GitHub] [airflow] jhtimmins merged pull request #23372: Update docs Amazon Glacier Docs

2022-05-06 Thread GitBox
jhtimmins merged PR #23372: URL: https://github.com/apache/airflow/pull/23372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[GitHub] [airflow] ephraimbuddy commented on issue #23512: Random "duplicate key value violates unique constraint" errors when initializing the postgres database

2022-05-06 Thread GitBox
ephraimbuddy commented on issue #23512: URL: https://github.com/apache/airflow/issues/23512#issuecomment-1119843495 Oh, I assigned it to you because you checked that you are willing to submit a PR. I'll unassign you now :) -- This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] eladkal opened a new pull request, #23541: Replace `pytest.mark.xfail` in Postgres texts

2022-05-06 Thread GitBox
eladkal opened a new pull request, #23541: URL: https://github.com/apache/airflow/pull/23541 related: https://github.com/apache/airflow/issues/23539 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob

[GitHub] [airflow] pingzh opened a new issue, #23540: tasks log is not correctly captured

2022-05-06 Thread GitBox
pingzh opened a new issue, #23540: URL: https://github.com/apache/airflow/issues/23540 ### Apache Airflow version 2.2.4 ### What happened When the task is executed via `exec` https://github.com/apache/airflow/blob/2.2.4/airflow/task/task_runner/standard_task_runner.py#L4

[GitHub] [airflow] potiuk commented on issue #23539: Get rid of the Xfail tests in Airflow

2022-05-06 Thread GitBox
potiuk commented on issue #23539: URL: https://github.com/apache/airflow/issues/23539#issuecomment-1119831113 cc: @eladkal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk opened a new issue, #23539: Get rid of the Xfail tests in Airflow

2022-05-06 Thread GitBox
potiuk opened a new issue, #23539: URL: https://github.com/apache/airflow/issues/23539 ### Body We have a number of xfail tests in Airflow and they should be fixed as they they might mislead people into thinking those are errors causing CI failures: - [ ] tests/utils/log/test_s

[GitHub] [airflow] potiuk commented on pull request #23537: Add IPV6 form of the address in cassandra status check

2022-05-06 Thread GitBox
potiuk commented on PR #23537: URL: https://github.com/apache/airflow/pull/23537#issuecomment-1119824448 cc: @eladkal - I've added a note in https://github.com/apache/airflow/issues/23538 so that we make a better /coloured output indicating the reason for failure when docker containers are

[GitHub] [airflow] potiuk opened a new issue, #23538: CI: convert tests to use Breeze tests command

2022-05-06 Thread GitBox
potiuk opened a new issue, #23538: URL: https://github.com/apache/airflow/issues/23538 The tests that are run in CI should use `breeze` and parallellism implemented in Python. NOTE: We should pay an attention to provide better error feedback when docker containers could not be start

[GitHub] [airflow] potiuk opened a new pull request, #23537: Add IPV6 form of the address in cassandra status check

2022-05-06 Thread GitBox
potiuk opened a new pull request, #23537: URL: https://github.com/apache/airflow/pull/23537 This PR fixes problem introduced in 3.0.26 of cassandra image which adds square brackets around IP address regardless of its type. The problem was workarounded by pinning cassandra to 3.0.25

[GitHub] [airflow] mwoods-familiaris commented on issue #13542: Task stuck in "scheduled" or "queued" state, pool has all slots queued, nothing is executing

2022-05-06 Thread GitBox
mwoods-familiaris commented on issue #13542: URL: https://github.com/apache/airflow/issues/13542#issuecomment-1119807111 Also experiencing this issue on MWAA 2.2.2. Seeing the same pattern as another commenter, in that when a DAG gets "stuck" with the first task in a queued state, it takes

[GitHub] [airflow] ianbuss commented on issue #23532: Airflow .airflowignore not handling soft link properly.

2022-05-06 Thread GitBox
ianbuss commented on issue #23532: URL: https://github.com/apache/airflow/issues/23532#issuecomment-1119800719 Have prepped a simple initial PR which should hopefully restore the original behaviour (and includes the test case provided by @tirkarthi - thanks!) but would be good to get some a

[GitHub] [airflow] mpeteuil opened a new pull request, #23536: Apply specific ID collation to root_dag_id too

2022-05-06 Thread GitBox
mpeteuil opened a new pull request, #23536: URL: https://github.com/apache/airflow/pull/23536 Motivation In certain databases there is a need to set the collation for ID fields like `dag_id` or `task_id` to something different than the database default. This is because in MySQL with

[GitHub] [airflow] ianbuss opened a new pull request, #23535: Fix regression in ignoring symlinks

2022-05-06 Thread GitBox
ianbuss opened a new pull request, #23535: URL: https://github.com/apache/airflow/pull/23535 In 2.3.0 we modified the way files are ignored and introduced a new syntax for ignorefile expressions. Unfortunately this change introduced a regression where ignore rules that refer to symlink path

[GitHub] [airflow] eladkal commented on a diff in pull request #23442: Opsgenie: Fix `close_alert` to properly send `kwargs`

2022-05-06 Thread GitBox
eladkal commented on code in PR #23442: URL: https://github.com/apache/airflow/pull/23442#discussion_r866990971 ## airflow/providers/opsgenie/hooks/opsgenie.py: ## @@ -126,7 +126,7 @@ def close_alert( identifier=identifier, identifier_type=ident

[GitHub] [airflow] potiuk commented on issue #23532: Airflow .airflowignore not handling soft link properly.

2022-05-06 Thread GitBox
potiuk commented on issue #23532: URL: https://github.com/apache/airflow/issues/23532#issuecomment-1119781028 Agree soft-links in tree are bad idea that will lead to duplication which is never good in this case. But soft-links are also dangerous for another reason - bacause of potential re

[GitHub] [airflow] ashb commented on a diff in pull request #23432: Automatically reschedule stuck queued tasks in CeleryExecutor

2022-05-06 Thread GitBox
ashb commented on code in PR #23432: URL: https://github.com/apache/airflow/pull/23432#discussion_r866976840 ## airflow/executors/celery_executor.py: ## @@ -358,6 +369,71 @@ def _check_for_stalled_adopted_tasks(self): for key in timedout_keys: self.

[GitHub] [airflow] NickYadance closed pull request #23534: path

2022-05-06 Thread GitBox
NickYadance closed pull request #23534: path URL: https://github.com/apache/airflow/pull/23534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23534: path

2022-05-06 Thread GitBox
boring-cyborg[bot] commented on PR #23534: URL: https://github.com/apache/airflow/pull/23534#issuecomment-1119777984 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] NickYadance opened a new pull request, #23534: path

2022-05-06 Thread GitBox
NickYadance opened a new pull request, #23534: URL: https://github.com/apache/airflow/pull/23534 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more

[airflow] branch main updated: Change approach to finding bad rows to LEFT OUTER JOIN. (#23528)

2022-05-06 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 22a9293ff8 Change approach to finding bad rows to LEFT

[GitHub] [airflow] ashb merged pull request #23528: Change approach to finding bad rows to LEFT OUTER JOIN.

2022-05-06 Thread GitBox
ashb merged PR #23528: URL: https://github.com/apache/airflow/pull/23528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apa

[GitHub] [airflow] ianbuss commented on issue #23532: Airflow .airflowignore not handling soft link properly.

2022-05-06 Thread GitBox
ianbuss commented on issue #23532: URL: https://github.com/apache/airflow/issues/23532#issuecomment-1119770040 OK, and you have a `.airflowignore` that has `repo.git/` or similar? I guess there's a wider question here about whether Airflow should be following symlinks at all as it wal

[GitHub] [airflow] NickYadance commented on issue #23532: Airflow .airflowignore not handling soft link properly.

2022-05-06 Thread GitBox
NickYadance commented on issue #23532: URL: https://github.com/apache/airflow/issues/23532#issuecomment-1119755802 @ianbuss sure , check this: https://user-images.githubusercontent.com/10060849/167166752-061b91af-ee7f-4a7f-a883-0f20b2d27e84.png";> Can't find a simple way to work aro

[GitHub] [airflow] potiuk closed pull request #23362: Added key '-c' in dumb-init

2022-05-06 Thread GitBox
potiuk closed pull request #23362: Added key '-c' in dumb-init URL: https://github.com/apache/airflow/pull/23362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on pull request #23362: Added key '-c' in dumb-init

2022-05-06 Thread GitBox
potiuk commented on PR #23362: URL: https://github.com/apache/airflow/pull/23362#issuecomment-1119748180 This is not correct way of doing it. While it is neded for celery it is disruptive for other containers so there is another way of doing it: https://airflow.apache.org/docs/docker

[GitHub] [airflow] ianbuss commented on issue #23532: Airflow .airflowignore not handling soft link properly.

2022-05-06 Thread GitBox
ianbuss commented on issue #23532: URL: https://github.com/apache/airflow/issues/23532#issuecomment-1119736848 Hopefully this can be relatively easily fixed with a change to `absolute()` rather than `resolve()` on the path but we should set up a realistic test case for the git-sync use case

[GitHub] [airflow] jedcunningham commented on pull request #23528: Change approach to finding bad rows to LEFT OUTER JOIN.

2022-05-06 Thread GitBox
jedcunningham commented on PR #23528: URL: https://github.com/apache/airflow/pull/23528#issuecomment-1119734885 I've also tested this on mysql, both 2.1.4 and 2.2.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

  1   2   >