[GitHub] [airflow] koconder commented on pull request #23922: Update constraints-3.7.txt

2022-05-25 Thread GitBox
koconder commented on PR #23922: URL: https://github.com/apache/airflow/pull/23922#issuecomment-1138223808 @uranusjr i rolled back my review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] koconder commented on issue #23917: Wrong dependecy version of requests for Databricks provider

2022-05-25 Thread GitBox
koconder commented on issue #23917: URL: https://github.com/apache/airflow/issues/23917#issuecomment-1138218591 Started a PR for this based on the comment/test from @collinmcnulty as https://github.com/apache/airflow/pull/23927 -- This is an automated message from the Apache Git Service.

[GitHub] [airflow] koconder opened a new pull request, #23927: Update dep for databricks #23917

2022-05-25 Thread GitBox
koconder opened a new pull request, #23927: URL: https://github.com/apache/airflow/pull/23927 Patch fix of requirements for Databricks Provider, quick fix for #23917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] jedcunningham commented on pull request #23450: Add await all containers option to Kubernetes Pod Operator

2022-05-25 Thread GitBox
jedcunningham commented on PR #23450: URL: https://github.com/apache/airflow/pull/23450#issuecomment-1138200270 I still have concerns with how this will interact with [delete_worker_pods](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#delete-worker-pods) being

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23450: Add await all containers option to Kubernetes Pod Operator

2022-05-25 Thread GitBox
jedcunningham commented on code in PR #23450: URL: https://github.com/apache/airflow/pull/23450#discussion_r882354593 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -259,16 +259,16 @@ def await_container_completion(self, pod: V1Pod, container_name: str) -> Non

[GitHub] [airflow] dstandish commented on a diff in pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
dstandish commented on code in PR #23924: URL: https://github.com/apache/airflow/pull/23924#discussion_r882350878 ## airflow/www/views.py: ## @@ -258,7 +258,11 @@ def task_group_to_grid(task_item_or_group, dag, dag_runs, session): if isinstance(task_item_or_group, Abstract

[GitHub] [airflow] uranusjr commented on a diff in pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
uranusjr commented on code in PR #23924: URL: https://github.com/apache/airflow/pull/23924#discussion_r882347348 ## airflow/www/views.py: ## @@ -258,7 +258,11 @@ def task_group_to_grid(task_item_or_group, dag, dag_runs, session): if isinstance(task_item_or_group, AbstractO

[GitHub] [airflow] uranusjr commented on a diff in pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
uranusjr commented on code in PR #23924: URL: https://github.com/apache/airflow/pull/23924#discussion_r882347348 ## airflow/www/views.py: ## @@ -258,7 +258,11 @@ def task_group_to_grid(task_item_or_group, dag, dag_runs, session): if isinstance(task_item_or_group, AbstractO

[GitHub] [airflow] dstandish commented on pull request #23450: Add await all containers option to Kubernetes Pod Operator

2022-05-25 Thread GitBox
dstandish commented on PR #23450: URL: https://github.com/apache/airflow/pull/23450#issuecomment-1138181791 i'm not seeing the `await all containers` option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [airflow] dstandish commented on a diff in pull request #23450: Add await all containers option to Kubernetes Pod Operator

2022-05-25 Thread GitBox
dstandish commented on code in PR #23450: URL: https://github.com/apache/airflow/pull/23450#discussion_r882329273 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -259,16 +259,16 @@ def await_container_completion(self, pod: V1Pod, container_name: str) -> None:

[GitHub] [airflow] dstandish commented on a diff in pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
dstandish commented on code in PR #23924: URL: https://github.com/apache/airflow/pull/23924#discussion_r882323655 ## airflow/www/views.py: ## @@ -258,7 +258,11 @@ def task_group_to_grid(task_item_or_group, dag, dag_runs, session): if isinstance(task_item_or_group, Abstract

[GitHub] [airflow] epapineau commented on a diff in pull request #22938: Enable dbt Cloud provider to interact with single tenant instances

2022-05-25 Thread GitBox
epapineau commented on code in PR #22938: URL: https://github.com/apache/airflow/pull/22938#discussion_r882311354 ## tests/providers/dbt/cloud/hooks/test_dbt_cloud.py: ## @@ -129,6 +129,13 @@ def test_init_hook(self): assert hook.auth_type == TokenAuth assert h

[GitHub] [airflow] dstandish commented on issue #15770: google provider requires leveldb installed in system

2022-05-25 Thread GitBox
dstandish commented on issue #15770: URL: https://github.com/apache/airflow/issues/15770#issuecomment-1138141449 @rodrigo-fss pretty sure that leveldb was made optional in google provider. You might try installing a more recent version of the provider. Which one did you try to install?

[GitHub] [airflow] github-actions[bot] commented on pull request #23923: Alphabetizes two tables

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #23923: URL: https://github.com/apache/airflow/pull/23923#issuecomment-1138140796 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] uranusjr commented on a diff in pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
uranusjr commented on code in PR #23924: URL: https://github.com/apache/airflow/pull/23924#discussion_r882302253 ## airflow/www/views.py: ## @@ -258,7 +258,11 @@ def task_group_to_grid(task_item_or_group, dag, dag_runs, session): if isinstance(task_item_or_group, AbstractO

[GitHub] [airflow] epapineau commented on a diff in pull request #22938: Enable dbt Cloud provider to interact with single tenant instances

2022-05-25 Thread GitBox
epapineau commented on code in PR #22938: URL: https://github.com/apache/airflow/pull/22938#discussion_r882295284 ## airflow/providers/dbt/cloud/hooks/dbt.py: ## @@ -133,6 +133,7 @@ class DbtCloudHook(HttpHook): Interact with dbt Cloud using the V2 API. :param dbt_cl

[GitHub] [airflow] gbonazzoli opened a new issue, #23926: Airflow 2.3.1 - gunicorn keeps removing and adding Permission menu access on Permissions to role Admin

2022-05-25 Thread GitBox
gbonazzoli opened a new issue, #23926: URL: https://github.com/apache/airflow/issues/23926 ### Apache Airflow version 2.3.1 (latest released) ### What happened gunicorn log file is full of these messages. This behavior was present also in release 2.3.0 I do

[GitHub] [airflow] eduardchai commented on issue #23852: Status of testing of Apache Airflow 2.3.1rc1

2022-05-25 Thread GitBox
eduardchai commented on issue #23852: URL: https://github.com/apache/airflow/issues/23852#issuecomment-1138125131 I have confirmed that https://github.com/apache/airflow/pull/23617 has been fixed 🎉 . Thank you! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] gbonazzoli opened a new issue, #23925: Airflow 2.3.1 : "CryptographyDeprecationWarning: Blowfish has been deprecated" message on gunicorn 20.1.0 startup

2022-05-25 Thread GitBox
gbonazzoli opened a new issue, #23925: URL: https://github.com/apache/airflow/issues/23925 ### Apache Airflow version 2.3.1 (latest released) ### What happened I get the following warning on the startup of gunicorn: ``` root@airflow:~/airflow# airflow webserver

[GitHub] [airflow] eduardchai commented on issue #23852: Status of testing of Apache Airflow 2.3.1rc1

2022-05-25 Thread GitBox
eduardchai commented on issue #23852: URL: https://github.com/apache/airflow/issues/23852#issuecomment-1138117110 > For #23590 (related to #23489 and #23580), tasks with `.` are shown again in grid view. > > I checked that #23521 also fixes the scheduler error loop too. The tas

[GitHub] [airflow] uranusjr commented on issue #15770: google provider requires leveldb installed in system

2022-05-25 Thread GitBox
uranusjr commented on issue #15770: URL: https://github.com/apache/airflow/issues/15770#issuecomment-1138107437 You would probably have better luck reaching out to the plyvel maintainers. https://github.com/wbolster/plyvel -- This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] jedcunningham commented on pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
jedcunningham commented on PR #23924: URL: https://github.com/apache/airflow/pull/23924#issuecomment-1138105827 Maybe, but I'm not sure sending a bunch of nulls out to the front end is really useful. This restores the behavior pre #23813, as I'm pretty sure this new behavior wasn't intentio

[GitHub] [airflow] eladkal commented on issue #23910: Airflow SalesforceHook empty security token

2022-05-25 Thread GitBox
eladkal commented on issue #23910: URL: https://github.com/apache/airflow/issues/23910#issuecomment-1138082779 Please follow https://airflow.apache.org/docs/apache-airflow-providers-salesforce/stable/connections/salesforce.html There are different types of authentication to snowfla

[GitHub] [airflow] uranusjr commented on pull request #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
uranusjr commented on PR #23924: URL: https://github.com/apache/airflow/pull/23924#issuecomment-1138081514 Would it be more straightforward to do this at the front end instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] parvezmkhan commented on issue #23910: Airflow SalesforceHook empty security token

2022-05-25 Thread GitBox
parvezmkhan commented on issue #23910: URL: https://github.com/apache/airflow/issues/23910#issuecomment-1138079358 @eladkal Thanks a lot for looking into this. I upgraded to 3.4.4 as shown below ` pip install --upgrade apache-airflow-providers-salesforce==3.4.4 pip sho

[GitHub] [airflow] github-actions[bot] commented on issue #16703: Workers silently crash after memory build up

2022-05-25 Thread GitBox
github-actions[bot] commented on issue #16703: URL: https://github.com/apache/airflow/issues/16703#issuecomment-1138004676 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] chenglongyan commented on pull request #21560: Add template_fields and constructor parameters to displaying

2022-05-25 Thread GitBox
chenglongyan commented on PR #21560: URL: https://github.com/apache/airflow/pull/21560#issuecomment-1137998152 not stale ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] jedcunningham opened a new pull request, #23924: Only return non-None task summaries for grid view

2022-05-25 Thread GitBox
jedcunningham opened a new pull request, #23924: URL: https://github.com/apache/airflow/pull/23924 If we do return None's, it breaks the grid view when a new task is added to a DAG. Fixes: #23908 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [airflow] hankehly commented on issue #22708: Rewrite Airflow CLI commands with Click

2022-05-25 Thread GitBox
hankehly commented on issue #22708: URL: https://github.com/apache/airflow/issues/22708#issuecomment-1137977091 @blag Hello, I'd like to continue contributing to this PR a few commands at a time. If someone could kindly take a look at / merge the PRs I submitted, I would gladly pick up anot

[GitHub] [airflow] vincbeck commented on pull request #23918: Fix the xfail test for batch

2022-05-25 Thread GitBox
vincbeck commented on PR #23918: URL: https://github.com/apache/airflow/pull/23918#issuecomment-1137955714 For the record, the test is still failing. I need to investigate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] koconder commented on pull request #23907: Light Refactor and Clean-up AWS Provider

2022-05-25 Thread GitBox
koconder commented on PR #23907: URL: https://github.com/apache/airflow/pull/23907#issuecomment-1137949813 Thanks @o-nikolas @ferruzzi @vincbeck i have made the required changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] o-nikolas commented on a diff in pull request #23907: Light Refactor and Clean-up AWS Provider

2022-05-25 Thread GitBox
o-nikolas commented on code in PR #23907: URL: https://github.com/apache/airflow/pull/23907#discussion_r882156054 ## tests/providers/amazon/aws/utils/eks_test_utils.py: ## @@ -164,10 +164,14 @@ def region_matches_partition(region: str, partition: str) -> bool: ("us-gov

[GitHub] [airflow] rodrigo-fss commented on issue #15933: Consider splitting Google Provider

2022-05-25 Thread GitBox
rodrigo-fss commented on issue #15933: URL: https://github.com/apache/airflow/issues/15933#issuecomment-1137895336 Hello guys any updates? I'm still struggling with the leveldb requirement to install the google provider and I can see that it wasn't split apart yet. Do you have any recomm

[GitHub] [airflow] rodrigo-fss commented on issue #15770: google provider requires leveldb installed in system

2022-05-25 Thread GitBox
rodrigo-fss commented on issue #15770: URL: https://github.com/apache/airflow/issues/15770#issuecomment-1137892244 Hello guys any updates? I'm still struggling with the leveldb requirement to install the google provider and I can see that it wasn't split apart yet. Do you have any recomm

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23841: Make CI and PROD image builds consistent

2022-05-25 Thread GitBox
jedcunningham commented on code in PR #23841: URL: https://github.com/apache/airflow/pull/23841#discussion_r882135705 ## .github/workflows/ci.yml: ## @@ -309,8 +309,6 @@ jobs: with: python-version: ${{ needs.build-info.outputs.defaultPythonVersion }}

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23841: Make CI and PROD image builds consistent

2022-05-25 Thread GitBox
jedcunningham commented on code in PR #23841: URL: https://github.com/apache/airflow/pull/23841#discussion_r882135149 ## .github/workflows/ci.yml: ## @@ -328,6 +326,8 @@ jobs: awk 'BEGIN{FS="="} {print $3}' | sed s'/["}]//g') echo "DEBIAN_VERSION=${DEBIAN

[airflow-site] branch fix_2.3.1_date created (now 265391e8e)

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch fix_2.3.1_date in repository https://gitbox.apache.org/repos/asf/airflow-site.git at 265391e8e Fix 2.3.1 release date This branch includes the following new commits: new 26539

[airflow-site] 01/01: Fix 2.3.1 release date

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch fix_2.3.1_date in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit 265391e8e59c6ebdb0f8bb7bf0d504ed975a7d34 Author: Jed Cunningham AuthorDate: Wed May 25 15:26:50 202

[airflow] branch v2-3-test updated: Fix release date for 2.3.1

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch v2-3-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v2-3-test by this push: new 838b97c9a0 Fix release date for 2.

[GitHub] [airflow] romj4k3 commented on issue #14529: Clear the entire TaskGroup section

2022-05-25 Thread GitBox
romj4k3 commented on issue #14529: URL: https://github.com/apache/airflow/issues/14529#issuecomment-1137858773 Hey guys, what's going on with that task? I need this solution. Please, do it :) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[airflow] branch v2-3-test updated (b42172614b -> ee100a592e)

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch v2-3-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit b42172614b Update release date on Release note omit 003971fab9 Add limit for JPype1 (#23847) omit 1

[GitHub] [airflow] mfjackson opened a new pull request, #23923: Alphabetizes two tables

2022-05-25 Thread GitBox
mfjackson opened a new pull request, #23923: URL: https://github.com/apache/airflow/pull/23923 The rest of the page has consistently alphabetized tables. This commit fixes three `extras` that were not alphabetized. --- **^ Add meaningful description above** Read the

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23922: Update constraints-3.7.txt

2022-05-25 Thread GitBox
boring-cyborg[bot] commented on PR #23922: URL: https://github.com/apache/airflow/pull/23922#issuecomment-1137813949 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] mcastelloNum35ator opened a new pull request, #23922: Update constraints-3.7.txt

2022-05-25 Thread GitBox
mcastelloNum35ator opened a new pull request, #23922: URL: https://github.com/apache/airflow/pull/23922 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** f

[GitHub] [airflow] Dark-Knight11 commented on issue #23832: AWS Glue Hook to implement enhanced logging

2022-05-25 Thread GitBox
Dark-Knight11 commented on issue #23832: URL: https://github.com/apache/airflow/issues/23832#issuecomment-1137808156 Ok, Thanks. I'll look into it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch main updated (d55df994f6 -> 423b905ccd)

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d55df994f6 Update environments documentation links (#23920) add 423b905ccd `2.3.1` has been released (#2391

[GitHub] [airflow] jedcunningham merged pull request #23912: `2.3.1` has been released

2022-05-25 Thread GitBox
jedcunningham merged PR #23912: URL: https://github.com/apache/airflow/pull/23912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[airflow] branch main updated: Update environments documentation links (#23920)

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d55df994f6 Update environments documentation

[GitHub] [airflow] jedcunningham commented on pull request #23920: Update environments documentation links.

2022-05-25 Thread GitBox
jedcunningham commented on PR #23920: URL: https://github.com/apache/airflow/pull/23920#issuecomment-1137801290 Thanks again @igorborgest 🍺 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [airflow] jedcunningham merged pull request #23920: Update environments documentation links.

2022-05-25 Thread GitBox
jedcunningham merged PR #23920: URL: https://github.com/apache/airflow/pull/23920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] github-actions[bot] commented on pull request #23920: Update environments documentation links.

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #23920: URL: https://github.com/apache/airflow/pull/23920#issuecomment-1137792513 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23920: Update environments documentation links.

2022-05-25 Thread GitBox
jedcunningham commented on code in PR #23920: URL: https://github.com/apache/airflow/pull/23920#discussion_r882055531 ## CONTRIBUTING.rst: ## @@ -503,10 +503,10 @@ Development Environments There are two environments, available on Linux and macOS, that you can use to develop Ap

[GitHub] [airflow] jedcunningham commented on pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
jedcunningham commented on PR #23919: URL: https://github.com/apache/airflow/pull/23919#issuecomment-1137774528 Thanks @igorborgest! Congrats on your first commit 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [airflow] jedcunningham merged pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
jedcunningham merged PR #23919: URL: https://github.com/apache/airflow/pull/23919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[airflow] branch main updated: Fix Breeze documentation typo (#23919)

2022-05-25 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2e95153ec9 Fix Breeze documentation typo (#2

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
boring-cyborg[bot] commented on PR #23919: URL: https://github.com/apache/airflow/pull/23919#issuecomment-1137771320 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] collinmcnulty commented on issue #23917: Wrong dependecy version of requests for Databricks provider

2022-05-25 Thread GitBox
collinmcnulty commented on issue #23917: URL: https://github.com/apache/airflow/issues/23917#issuecomment-1137768141 I have also reproduced this error and confirmed that adding `requests>=2.27,<3` fixes the problem. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [airflow] igorborgest opened a new pull request, #23920: Update environments documentation links.

2022-05-25 Thread GitBox
igorborgest opened a new pull request, #23920: URL: https://github.com/apache/airflow/pull/23920 The environment documentation links are outdated in the CONTRIBUTION guide. So I update that. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #23919: URL: https://github.com/apache/airflow/pull/23919#issuecomment-1137752486 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[airflow] branch main updated: Chart: Update default airflow version to `2.3.1` (#23913)

2022-05-25 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 3aec3aa81c Chart: Update default airflow v

[GitHub] [airflow] ephraimbuddy merged pull request #23913: Chart: Update default airflow version to `2.3.1`

2022-05-25 Thread GitBox
ephraimbuddy merged PR #23913: URL: https://github.com/apache/airflow/pull/23913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

[GitHub] [airflow] igorborgest commented on a diff in pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
igorborgest commented on code in PR #23919: URL: https://github.com/apache/airflow/pull/23919#discussion_r882014299 ## dev/breeze/README.md: ## @@ -21,11 +21,11 @@ **Table of Contents** *generated with [DocToc](https://github.com/thlorenz/doctoc)* -- [Apache AirAirflow Br

[GitHub] [airflow] jedcunningham commented on a diff in pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
jedcunningham commented on code in PR #23919: URL: https://github.com/apache/airflow/pull/23919#discussion_r881991562 ## dev/breeze/README.md: ## @@ -21,11 +21,11 @@ **Table of Contents** *generated with [DocToc](https://github.com/thlorenz/doctoc)* -- [Apache AirAirflow

[GitHub] [airflow] vincbeck commented on pull request #23857: Create `get_partition` and `create_partition` methods in `GlueCatalogHook`

2022-05-25 Thread GitBox
vincbeck commented on PR #23857: URL: https://github.com/apache/airflow/pull/23857#issuecomment-1137691347 Thanks for making these changes. It looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
boring-cyborg[bot] commented on PR #23919: URL: https://github.com/apache/airflow/pull/23919#issuecomment-1137689713 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] igorborgest opened a new pull request, #23919: Fix Breeze documentation typo.

2022-05-25 Thread GitBox
igorborgest opened a new pull request, #23919: URL: https://github.com/apache/airflow/pull/23919 Just a small typo fix in the Breeze documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] bbovenzi commented on issue #23772: New grid view in Airflow 2.3.0 has very slow performance on large DAGs relative to tree view in 2.2.5

2022-05-25 Thread GitBox
bbovenzi commented on issue #23772: URL: https://github.com/apache/airflow/issues/23772#issuecomment-1137673764 Yes, that change was just for dynamic tasks. I am working on more optimizations. They just didn't make it in time for 2.3.1. -- This is an automated message from the Apache Git

[GitHub] [airflow] vincbeck commented on a diff in pull request #23918: Fix the xfail test for batch

2022-05-25 Thread GitBox
vincbeck commented on code in PR #23918: URL: https://github.com/apache/airflow/pull/23918#discussion_r881977334 ## tests/providers/amazon/aws/hooks/test_batch_waiters.py: ## @@ -274,19 +273,17 @@ def test_batch_job_waiting(aws_clients, aws_region, job_queue_name, job_definiti

[GitHub] [airflow] vincbeck commented on a diff in pull request #23918: Fix the xfail test for batch

2022-05-25 Thread GitBox
vincbeck commented on code in PR #23918: URL: https://github.com/apache/airflow/pull/23918#discussion_r881977031 ## tests/providers/amazon/aws/hooks/test_batch_waiters.py: ## @@ -274,19 +273,17 @@ def test_batch_job_waiting(aws_clients, aws_region, job_queue_name, job_definiti

[GitHub] [airflow] vincbeck opened a new pull request, #23918: Fix the xfail test for batch

2022-05-25 Thread GitBox
vincbeck opened a new pull request, #23918: URL: https://github.com/apache/airflow/pull/23918 One of the test in the batch hook was marked as xfail as part of this [PR](https://github.com/apache/airflow/pull/11020). #23539 has been created to fix all the tests flagged as xfail in airflow. T

[airflow-site] branch announce-airflow-2.3.1 updated (912e07878 -> 2f83fa028)

2022-05-25 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch announce-airflow-2.3.1 in repository https://gitbox.apache.org/repos/asf/airflow-site.git omit 912e07878 Announce Apache Airflow 2.3.1 add 2f83fa028 Announce Apache Airflow 2.3.

[GitHub] [airflow] boring-cyborg[bot] commented on issue #23917: Wrong dependecy version of requests for Databricks provider

2022-05-25 Thread GitBox
boring-cyborg[bot] commented on issue #23917: URL: https://github.com/apache/airflow/issues/23917#issuecomment-1137661206 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] yershovkiril opened a new issue, #23917: Wrong dependecy version of requests for Databricks provider

2022-05-25 Thread GitBox
yershovkiril opened a new issue, #23917: URL: https://github.com/apache/airflow/issues/23917 ### Apache Airflow Provider(s) databricks ### Versions of Apache Airflow Providers apache-airflow-providers-databricks==2.7.0 ### Apache Airflow version 2.2.

[GitHub] [airflow-site] ephraimbuddy commented on pull request #602: Announce Apache Airflow 2.3.1

2022-05-25 Thread GitBox
ephraimbuddy commented on PR #602: URL: https://github.com/apache/airflow-site/pull/602#issuecomment-1137660230 Yeah. Have fixed it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[airflow-site] branch announce-airflow-2.3.1 updated (99ff5bd1f -> 912e07878)

2022-05-25 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch announce-airflow-2.3.1 in repository https://gitbox.apache.org/repos/asf/airflow-site.git omit 99ff5bd1f Announce Apache Airflow 2.3.1 add 912e07878 Announce Apache Airflow 2.3.

[GitHub] [airflow] joshzana commented on issue #23772: New grid view in Airflow 2.3.0 has very slow performance on large DAGs relative to tree view in 2.2.5

2022-05-25 Thread GitBox
joshzana commented on issue #23772: URL: https://github.com/apache/airflow/issues/23772#issuecomment-1137636500 @bbovenzi Thanks for the progress so far. I tried out the new 2.3.1 release with #23813 in it, but this is still an issue for us. The big DAG mentioned above is now taking >60 s

[GitHub] [airflow] josh-fell commented on pull request #23915: Add new SQLCheckOperators

2022-05-25 Thread GitBox
josh-fell commented on PR #23915: URL: https://github.com/apache/airflow/pull/23915#issuecomment-1137585513 > Question I have for reviewers: would it make sense to add the Snowflake, Bigquery, Redshift, etc... versions of this operator in with this PR, or open a separate issue & PR for the

[GitHub] [airflow] alexperry-shifu commented on issue #16176: Quickstart Helm Chart fails post-install

2022-05-25 Thread GitBox
alexperry-shifu commented on issue #16176: URL: https://github.com/apache/airflow/issues/16176#issuecomment-1137578980 >> So yes. The project is doing quite fine and we have plenty of happy and collaborating users. HAHAHAHAHA!!! Dude, it wasn't me this time! While I am enj

[GitHub] [airflow] Taragolis commented on issue #23832: AWS Glue Hook to implement enhanced logging

2022-05-25 Thread GitBox
Taragolis commented on issue #23832: URL: https://github.com/apache/airflow/issues/23832#issuecomment-1137572804 @Dark-Knight11 I would like to warn about side effect of fetch AWS Glue Logs into Airflow Tasks logs (already mentioned in the almost the same issue https://github.com/apache/air

[GitHub] [airflow] denimalpaca commented on pull request #23915: Add new SQLCheckOperators

2022-05-25 Thread GitBox
denimalpaca commented on PR #23915: URL: https://github.com/apache/airflow/pull/23915#issuecomment-1137489675 Question I have for reviewers: would it make sense to add the Snowflake, Bigquery, Redshift, etc... versions of this operator in with this PR, or open a separate issue & PR for the

[GitHub] [airflow] denimalpaca commented on a diff in pull request #23915: Add new SQLCheckOperators

2022-05-25 Thread GitBox
denimalpaca commented on code in PR #23915: URL: https://github.com/apache/airflow/pull/23915#discussion_r881842380 ## airflow/operators/sql.py: ## @@ -467,6 +467,218 @@ def push(self, meta_data): self.log.info("Log from %s:\n%s", self.dag_id, info) +def _get_failed

[GitHub] [airflow] gpoulin commented on issue #23760: OOME when using GCSObjectsWithPrefixExistenceSensor on bucket with many objects

2022-05-25 Thread GitBox
gpoulin commented on issue #23760: URL: https://github.com/apache/airflow/issues/23760#issuecomment-1137479791 @potiuk how do you usually manage backward compatibility? GCSHook.list already take a `max_result` parameter, but it's actually the pagination size [ref](https://github.com/apache/

[GitHub] [airflow] javad87 commented on issue #16176: Quickstart Helm Chart fails post-install

2022-05-25 Thread GitBox
javad87 commented on issue #16176: URL: https://github.com/apache/airflow/issues/16176#issuecomment-1137478848 I guess this issue has not resolved yet; since, I get the same Error, when excuting this command: helm upgrade --install airflow apache-airflow/airflow --namespace airflow --cr

[GitHub] [airflow] gpoulin commented on issue #23760: OOME when using GCSObjectsWithPrefixExistenceSensor on bucket with many objects

2022-05-25 Thread GitBox
gpoulin commented on issue #23760: URL: https://github.com/apache/airflow/issues/23760#issuecomment-1137478854 @potiuk how do you usually manage backward compatibility? GCSHook.list already take a `max_result` parameter, but it's actually the pagination size [ref](https://github.com/apache/

[GitHub] [airflow] chenglongyan commented on pull request #21560: Add template_fields and constructor parameters to displaying

2022-05-25 Thread GitBox
chenglongyan commented on PR #21560: URL: https://github.com/apache/airflow/pull/21560#issuecomment-1137473624 Reopen !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ferruzzi commented on a diff in pull request #23907: Light Refactor and Clean-up AWS Provider

2022-05-25 Thread GitBox
ferruzzi commented on code in PR #23907: URL: https://github.com/apache/airflow/pull/23907#discussion_r881819741 ## airflow/providers/amazon/aws/hooks/glue.py: ## @@ -74,7 +74,7 @@ def __init__( raise ValueError("Cannot specify num_of_dpus with custom WorkerTyp

[GitHub] [airflow] ashb commented on pull request #23889: On backfill callback

2022-05-25 Thread GitBox
ashb commented on PR #23889: URL: https://github.com/apache/airflow/pull/23889#issuecomment-1137458950 I'm not sure this is worth adding to the API, especially given the work around suggested by Elad, coupled with .https://airflow.apache.org/docs/apache-airflow/stable/concepts/cluster-polic

[GitHub] [airflow] ashb closed pull request #23889: On backfill callback

2022-05-25 Thread GitBox
ashb closed pull request #23889: On backfill callback URL: https://github.com/apache/airflow/pull/23889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham closed pull request #23913: Chart: Update default airflow version to `2.3.1`

2022-05-25 Thread GitBox
jedcunningham closed pull request #23913: Chart: Update default airflow version to `2.3.1` URL: https://github.com/apache/airflow/pull/23913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] github-actions[bot] commented on pull request #23916: Add support to specify language name in PapermillOperator

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #23916: URL: https://github.com/apache/airflow/pull/23916#issuecomment-1137441054 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] nhojjohn commented on a diff in pull request #23916: Add support to specify language name in PapermillOperator

2022-05-25 Thread GitBox
nhojjohn commented on code in PR #23916: URL: https://github.com/apache/airflow/pull/23916#discussion_r881799239 ## tests/providers/papermill/operators/test_papermill.py: ## @@ -75,3 +79,4 @@ def test_render_template(self): assert '/tmp/out-test_render_template.ipynb' =

[GitHub] [airflow] uranusjr commented on pull request #23887: Remove hack from BigQuery DTS hook

2022-05-25 Thread GitBox
uranusjr commented on PR #23887: URL: https://github.com/apache/airflow/pull/23887#issuecomment-1137440311 Simply add a line to the `google` entry in `setup.py`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] github-actions[bot] commented on pull request #23906: docs: amazon-provider retry modes

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #23906: URL: https://github.com/apache/airflow/pull/23906#issuecomment-1137436941 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] henriqueribeiro commented on pull request #23887: Remove hack from BigQuery DTS hook

2022-05-25 Thread GitBox
henriqueribeiro commented on PR #23887: URL: https://github.com/apache/airflow/pull/23887#issuecomment-1137436574 > So does `pip install apache-airflow-providers-google proto-plus-python<1.19.6` fail? It is not enough to rely on the implicit version behaviour, but we should actively disallo

[GitHub] [airflow] github-actions[bot] commented on pull request #23872: DagFileProcessorManager: Start a new process group only if current process not a session leader

2022-05-25 Thread GitBox
github-actions[bot] commented on PR #23872: URL: https://github.com/apache/airflow/pull/23872#issuecomment-1137433781 The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk

[GitHub] [airflow] zachliu commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-05-25 Thread GitBox
zachliu commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1137434313 @ashb steps to reproduce: https://github.com/apache/airflow/discussions/23908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] uranusjr commented on a diff in pull request #23915: Add new SQLCheckOperators

2022-05-25 Thread GitBox
uranusjr commented on code in PR #23915: URL: https://github.com/apache/airflow/pull/23915#discussion_r881790085 ## airflow/operators/sql.py: ## @@ -467,6 +467,218 @@ def push(self, meta_data): self.log.info("Log from %s:\n%s", self.dag_id, info) +def _get_failed_te

[GitHub] [airflow] uranusjr commented on a diff in pull request #23915: Add new SQLCheckOperators

2022-05-25 Thread GitBox
uranusjr commented on code in PR #23915: URL: https://github.com/apache/airflow/pull/23915#discussion_r881787575 ## airflow/operators/sql.py: ## @@ -467,6 +467,218 @@ def push(self, meta_data): self.log.info("Log from %s:\n%s", self.dag_id, info) +def _get_failed_te

[GitHub] [airflow] uranusjr commented on a diff in pull request #23916: Add support to specify language name in PapermillOperator

2022-05-25 Thread GitBox
uranusjr commented on code in PR #23916: URL: https://github.com/apache/airflow/pull/23916#discussion_r881784882 ## tests/providers/papermill/operators/test_papermill.py: ## @@ -75,3 +79,4 @@ def test_render_template(self): assert '/tmp/out-test_render_template.ipynb' =

[GitHub] [airflow] uranusjr commented on pull request #23887: Remove hack from BigQuery DTS hook

2022-05-25 Thread GitBox
uranusjr commented on PR #23887: URL: https://github.com/apache/airflow/pull/23887#issuecomment-1137422457 So does `pip install apache-airflow-providers-google proto-plus-python<1.19.6` fail? It is not enough to rely on the implicit version behaviour, but we should actively disallow invalid

  1   2   >