This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 73446f28e9 Add TaskInstance State 'REMOVED' to finished states and
success states (#23797)
add 97b443aa59 Remove
github-actions[bot] commented on PR #23981:
URL: https://github.com/apache/airflow/pull/23981#issuecomment-1140231100
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not modify the
potiuk merged PR #23981:
URL: https://github.com/apache/airflow/pull/23981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
eladkal opened a new pull request, #23983:
URL: https://github.com/apache/airflow/pull/23983
We have some operators/sensors that use `*_execution_date` as the class
parameters. This PR deprecate the usage of these parameters and replace it with
`logical_date`.
There is no change in
potiuk commented on PR #23981:
URL: https://github.com/apache/airflow/pull/23981#issuecomment-1140230872
Ah right .. my bad. I somehow thought it's more than that. (next time - note
to self "read with understanding" 臘 ).
You are perfectly right - this case is different.
--
This
eladkal commented on PR #23981:
URL: https://github.com/apache/airflow/pull/23981#issuecomment-1140230502
> The problem with such changes is that it REQUIRES the users to migrate all
their dags (in one go in case they use it)
This case is different. No one can actually use
potiuk commented on PR #23981:
URL: https://github.com/apache/airflow/pull/23981#issuecomment-1140229538
However, I also understand why @eladkal would like to have it - this would
be helpful to "force" the users of internally managed service to get rid of
some deprecations.
After
potiuk commented on PR #23981:
URL: https://github.com/apache/airflow/pull/23981#issuecomment-1140228471
I'd love to hear what other think, but I consider it a heavily breaking
change and we should not do it (at least not in this form).
The problem with such changes is that it
potiuk opened a new pull request, #23982:
URL: https://github.com/apache/airflow/pull/23982
The --volume flag is an old style of specifying mounts used by docker,
the newer and more explicit version is --mount where you have to
specify type, source, destination in the form of key/value
potiuk commented on PR #23980:
URL: https://github.com/apache/airflow/pull/23980#issuecomment-1140225414
Ah cool. I just used the new DRY_RUN feature to debug it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
javad87 commented on issue #16176:
URL: https://github.com/apache/airflow/issues/16176#issuecomment-1140224257
> I guess this issue has not resolved yet; since, I get the same Error, when
excuting this command: helm upgrade --install airflow apache-airflow/airflow
--namespace airflow
eladkal commented on PR #23980:
URL: https://github.com/apache/airflow/pull/23980#issuecomment-1140218983
static checks fail :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 0723b36dcb Updating
potiuk commented on PR #23980:
URL: https://github.com/apache/airflow/pull/23980#issuecomment-1140215819
This is a result of
https://apache-airflow.slack.com/archives/CCPRP7943/p1653687219387939
discussion in slack where WSL2 user had problems with running pre-commits.
--
This is an
eladkal opened a new pull request, #23981:
URL: https://github.com/apache/airflow/pull/23981
This parameter is deprecated since Airflow 2.0/first phase of providers. We
can safely remove it now since if parameter is used by user the code doesn't
run as it raises exception.
Noting:
potiuk opened a new pull request, #23980:
URL: https://github.com/apache/airflow/pull/23980
The pre-commits that require CI image run docker command under
the hood that is highly optimized for performance (only mounts
files that are necessary to be mounted) - in order to improve
This is an automated email from the ASF dual-hosted git repository.
ephraimanierobi pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 73446f28e9 Add TaskInstance State
ephraimbuddy merged PR #23797:
URL: https://github.com/apache/airflow/pull/23797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ephraimbuddy commented on code in PR #23510:
URL: https://github.com/apache/airflow/pull/23510#discussion_r884091662
##
airflow/security/permissions.py:
##
@@ -66,14 +66,16 @@
DAG_ACTIONS = {ACTION_CAN_READ, ACTION_CAN_EDIT, ACTION_CAN_DELETE}
-def
This is an automated email from the ASF dual-hosted git repository.
xddeng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 33eef7b8a1 Fix links in documentation (#23975)
XD-DENG merged PR #23975:
URL: https://github.com/apache/airflow/pull/23975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #23975:
URL: https://github.com/apache/airflow/pull/23975#issuecomment-1140191489
The PR is likely ready to be merged. No tests are needed as no important
environment files, nor python files were modified by it. However, committers
might decide that full
eladkal commented on issue #23963:
URL: https://github.com/apache/airflow/issues/23963#issuecomment-1140190647
@SaumyaBhushan Follow
https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst
--
This is an automated message from the Apache Git Service.
To respond to the
eladkal opened a new pull request, #23979:
URL: https://github.com/apache/airflow/pull/23979
Adding the funcitonality to run a single query against presto and send the
result as slack message.
Similar to `SnowflakeToSlackOperator`
---
**^ Add meaningful description
github-actions[bot] commented on PR #23976:
URL: https://github.com/apache/airflow/pull/23976#issuecomment-1140190331
The PR is likely OK to be merged with just subset of tests for default
Python and Database versions without running the full matrix of tests, because
it does not modify the
potiuk commented on PR #23970:
URL: https://github.com/apache/airflow/pull/23970#issuecomment-1140188174
Cool. I think you will have the shortest possible path from contributing
workshop to actually released feature. We are going to release 2.3.2 soon and
it's going to be included :)
--
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new af23a014f3 Helm logo no longer a link (#23977)
potiuk merged PR #23977:
URL: https://github.com/apache/airflow/pull/23977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #23977:
URL: https://github.com/apache/airflow/pull/23977#issuecomment-1140184878
The PR is likely ready to be merged. No tests are needed as no important
environment files, nor python files were modified by it. However, committers
might decide that full
eladkal commented on PR #23971:
URL: https://github.com/apache/airflow/pull/23971#issuecomment-1140184592
Note about changes to DbapiHook.
The hook can be updated in next Airflow version but providers must be
compatible with Airflow>=2.1 so depending on the changes you might need to add
ephraimbuddy commented on code in PR #23510:
URL: https://github.com/apache/airflow/pull/23510#discussion_r884080722
##
airflow/security/permissions.py:
##
@@ -66,14 +66,16 @@
DAG_ACTIONS = {ACTION_CAN_READ, ACTION_CAN_EDIT, ACTION_CAN_DELETE}
-def
uranusjr commented on code in PR #23510:
URL: https://github.com/apache/airflow/pull/23510#discussion_r884080227
##
airflow/security/permissions.py:
##
@@ -66,14 +66,16 @@
DAG_ACTIONS = {ACTION_CAN_READ, ACTION_CAN_EDIT, ACTION_CAN_DELETE}
-def
ephraimbuddy commented on code in PR #23510:
URL: https://github.com/apache/airflow/pull/23510#discussion_r884078926
##
airflow/security/permissions.py:
##
@@ -66,14 +66,16 @@
DAG_ACTIONS = {ACTION_CAN_READ, ACTION_CAN_EDIT, ACTION_CAN_DELETE}
-def
101 - 133 of 133 matches
Mail list logo
