[GitHub] [airflow] uranusjr opened a new pull request, #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
uranusjr opened a new pull request, #24626: URL: https://github.com/apache/airflow/pull/24626 This allows Breeze to run images of another platform, such as AMD64 on an ARM machine. For some reason a dependency is not building correctly on ARM. I’ll probably look into that later, but

[GitHub] [airflow] github-actions[bot] commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165281093 The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full

[GitHub] [airflow] itayB opened a new pull request, #24627: docs: sqlalchemy link update

2022-06-24 Thread GitBox
itayB opened a new pull request, #24627: URL: https://github.com/apache/airflow/pull/24627 following to this change: https://github.com/apache/airflow/pull/22114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
ephraimbuddy commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905789002 ## airflow/models/dataset.py: ## @@ -0,0 +1,61 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

[GitHub] [airflow] uranusjr commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
uranusjr commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165284348 Hmm, I was under the impression `breeze tests` also needs this, but apparently it does not and “correctly” picks up the AMD-based image. This leads me to think maybe we are doing somet

[GitHub] [airflow] potiuk commented on issue #24466: Long running tasks being killed with CeleryKubernetesExecutor

2022-06-24 Thread GitBox
potiuk commented on issue #24466: URL: https://github.com/apache/airflow/issues/24466#issuecomment-1165289714 > This should be reproduceable and i'm investigating on it. Woudl be great to get more evidence of it - especially to see if it is reproducible in latest released Airflow.!

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165294233 > Hmm, I was under the impression `breeze tests` also needs this, but apparently it does not and “correctly” picks up the AMD-based image. This leads me to think maybe we are doing somet

[GitHub] [airflow] argibbs commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-24 Thread GitBox
argibbs commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1165297652 Static checks passing locally now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165298700 BTW. Initially the idea was that you'd only ever need to "run" stuff on the platform you have - so all the "execution" shoudl by defaiult only be possible on the local platform of yours.

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165299635 but I might want to explore "fixing" the build status to be per image + platform combination. This seems like a useful thing to have. -- This is an automated message from the Apache Gi

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165301363 (or you might want to look at it if you want - I can take a look and point out to where they shoudl be changed @uranusjr ). might be good learning experience :D -- This is an automate

[GitHub] [airflow] phanikumv commented on a diff in pull request #24617: Add test_connection method to Databricks hook

2022-06-24 Thread GitBox
phanikumv commented on code in PR #24617: URL: https://github.com/apache/airflow/pull/24617#discussion_r905819422 ## tests/providers/databricks/hooks/test_databricks.py: ## @@ -178,11 +179,18 @@ def uninstall_endpoint(host): def list_jobs_endpoint(host): """ -Utility

[GitHub] [airflow] phanikumv commented on a diff in pull request #24617: Add test_connection method to Databricks hook

2022-06-24 Thread GitBox
phanikumv commented on code in PR #24617: URL: https://github.com/apache/airflow/pull/24617#discussion_r905819618 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -408,3 +410,19 @@ def get_repo_by_path(self, path: str) -> Optional[str]: raise e

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-24 Thread GitBox
ephraimbuddy commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r905811972 ## airflow/providers/core/sql/operators/sql.py: ## @@ -0,0 +1,308 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [airflow] blag commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
blag commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905825160 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[GitHub] [airflow] blag opened a new pull request, #24628: Rewrite the 'celery' command to use Click

2022-06-24 Thread GitBox
blag opened a new pull request, #24628: URL: https://github.com/apache/airflow/pull/24628 This is part of a series of PRs breaking up #22613 into smaller, more reviewable chunks. The end result will be rewriting the existing `airflow` CLI to use Click instead of argparse. For motivation, pl

[GitHub] [airflow] gaurav-batra-couture opened a new pull request, #24629: Build fix

2022-06-24 Thread GitBox
gaurav-batra-couture opened a new pull request, #24629: URL: https://github.com/apache/airflow/pull/24629 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24629: Build fix

2022-06-24 Thread GitBox
boring-cyborg[bot] commented on PR #24629: URL: https://github.com/apache/airflow/pull/24629#issuecomment-1165319628 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] gaurav-batra-couture closed pull request #24629: Build fix

2022-06-24 Thread GitBox
gaurav-batra-couture closed pull request #24629: Build fix URL: https://github.com/apache/airflow/pull/24629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[GitHub] [airflow] potiuk merged pull request #24627: docs: sqlalchemy link update

2022-06-24 Thread GitBox
potiuk merged PR #24627: URL: https://github.com/apache/airflow/pull/24627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: docs: sqlalchemy link update (#24627)

2022-06-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2113d72466 docs: sqlalchemy link update (#24627) 21

[GitHub] [airflow] potiuk commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
potiuk commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905834855 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [airflow] potiuk commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
potiuk commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905834855 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [airflow] potiuk commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
potiuk commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905834855 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [airflow] potiuk commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
potiuk commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905837067 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [airflow] potiuk commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
potiuk commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905837067 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

[GitHub] [airflow] ming-zhang-SN opened a new issue, #24630: All the task cells in the same row are showing same state (latest state)

2022-06-24 Thread GitBox
ming-zhang-SN opened a new issue, #24630: URL: https://github.com/apache/airflow/issues/24630 ### Apache Airflow version 2.3.2 (latest released) ### What happened For latest version (2.3.2), on grid view UI all the task cells in the same row are showing same state(latest

[GitHub] [airflow] boring-cyborg[bot] commented on issue #24630: All the task cells in the same row are showing same state (latest state)

2022-06-24 Thread GitBox
boring-cyborg[bot] commented on issue #24630: URL: https://github.com/apache/airflow/issues/24630#issuecomment-1165333427 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] potiuk opened a new pull request, #24634: Allows to specify different Python base image when building images

2022-06-24 Thread GitBox
potiuk opened a new pull request, #24634: URL: https://github.com/apache/airflow/pull/24634 Today Python released new images that seems to break some of our dependencies (at least on M1/ARM). This PR adds a workaround possibility to add --python-base-image option to override the defa

[airflow] branch constraints-main updated: Updating constraints. Build id:2554436856

2022-06-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 0595b1698d Updating con

[GitHub] [airflow] potiuk opened a new pull request, #24635: Limit azure-servicebus to not be used on ARM

2022-06-24 Thread GitBox
potiuk opened a new pull request, #24635: URL: https://github.com/apache/airflow/pull/24635 Azure service bus uses uamqp which does not build for ARM architecture and we need to disable it as a dependency for ARM. --- **^ Add meaningful description above** Read the

[GitHub] [airflow] gmsantos commented on pull request #24635: Limit azure-servicebus to not be used on ARM

2022-06-24 Thread GitBox
gmsantos commented on PR #24635: URL: https://github.com/apache/airflow/pull/24635#issuecomment-1165387258 related https://github.com/Azure/azure-uamqp-python/issues/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #24635: Limit azure-servicebus to not be used on ARM

2022-06-24 Thread GitBox
potiuk commented on PR #24635: URL: https://github.com/apache/airflow/pull/24635#issuecomment-1165387826 > related [Azure/azure-uamqp-python#191](https://github.com/Azure/azure-uamqp-python/issues/191) Cool. I will add t as comment to the setup to track it -- This is an automated

[GitHub] [airflow] potiuk merged pull request #24635: Limit azure-servicebus to not be used on ARM

2022-06-24 Thread GitBox
potiuk merged PR #24635: URL: https://github.com/apache/airflow/pull/24635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: Limit azure-servicebus to not be used on ARM (#24635)

2022-06-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 477f907b34 Limit azure-servicebus to not be used on

[GitHub] [airflow] uranusjr merged pull request #24622: Add gcp_conn_id argument to GoogleDriveToLocalOperator

2022-06-24 Thread GitBox
uranusjr merged PR #24622: URL: https://github.com/apache/airflow/pull/24622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[airflow] branch main updated: Add gcp_conn_id argument to GoogleDriveToLocalOperator (#24622)

2022-06-24 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ded22eb5b6 Add gcp_conn_id argument to GoogleDriv

[GitHub] [airflow] uranusjr commented on issue #24624: Redacted Variables override original value

2022-06-24 Thread GitBox
uranusjr commented on issue #24624: URL: https://github.com/apache/airflow/issues/24624#issuecomment-1165413332 Since a variable can contain any value (including a blank string), there’s no way I can think of we can restore the original value without sending the value to the frontend. So I

[GitHub] [airflow] Megha-Sai-Sree-PINNAKA commented on issue #16654: "Suggest a change on this page" button bug/change request

2022-06-24 Thread GitBox
Megha-Sai-Sree-PINNAKA commented on issue #16654: URL: https://github.com/apache/airflow/issues/16654#issuecomment-1165419894 Hello @potiuk and @mik-laj I understood that there are 2 ways to display the documentation on [airflow website](https://airflow.apache.org/docs/apache-airflow/

[GitHub] [airflow] argibbs commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-24 Thread GitBox
argibbs commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1165422166 @potiuk @josh-fell w00t, it's passed. Can either of you merge it for me? I (understandably) don't have write access. -- This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] uranusjr commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
uranusjr commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165423800 I think retaining the logic is fine—but the problem is that `shell` (and other developer commands) currently has a different definition to “the platform you have” to `tests`. Personall

[GitHub] [airflow] uranusjr merged pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
uranusjr merged PR #24626: URL: https://github.com/apache/airflow/pull/24626 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[airflow] branch main updated: Add --platform to breeze shell and start-airflow (#24626)

2022-06-24 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5a8209e509 Add --platform to breeze shell and sta

[GitHub] [airflow] github-actions[bot] commented on pull request #24617: Add test_connection method to Databricks hook

2022-06-24 Thread GitBox
github-actions[bot] commented on PR #24617: URL: https://github.com/apache/airflow/pull/24617#issuecomment-1165426922 The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the

[GitHub] [airflow] ashb commented on a diff in pull request #24617: Add test_connection method to Databricks hook

2022-06-24 Thread GitBox
ashb commented on code in PR #24617: URL: https://github.com/apache/airflow/pull/24617#discussion_r905930197 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -408,3 +410,18 @@ def get_repo_by_path(self, path: str) -> Optional[str]: raise e r

[GitHub] [airflow] ashb commented on issue #24620: Grid view disappears when hovering over skipped tasks

2022-06-24 Thread GitBox
ashb commented on issue #24620: URL: https://github.com/apache/airflow/issues/24620#issuecomment-1165435339 I think this was caused by hovering over a skipped mapped task -- i.e. when `make_list` in our example map dags returns a zero length list. We may have already fixed this in mai

[GitHub] [airflow] phanikumv commented on a diff in pull request #24617: Add test_connection method to Databricks hook

2022-06-24 Thread GitBox
phanikumv commented on code in PR #24617: URL: https://github.com/apache/airflow/pull/24617#discussion_r905948574 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -408,3 +410,18 @@ def get_repo_by_path(self, path: str) -> Optional[str]: raise e

[GitHub] [airflow] ashb commented on issue #24620: Grid view disappears when hovering over skipped tasks

2022-06-24 Thread GitBox
ashb commented on issue #24620: URL: https://github.com/apache/airflow/issues/24620#issuecomment-1165458097 Yes, confirmed it's a bug in 2.3.2 but not a problem in main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] ashb commented on a diff in pull request #24613: Add dataset model

2022-06-24 Thread GitBox
ashb commented on code in PR #24613: URL: https://github.com/apache/airflow/pull/24613#discussion_r905960701 ## airflow/migrations/versions/0113_2_4_0_add_dataset_model.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributo

[GitHub] [airflow] phanikumv commented on a diff in pull request #24617: Add test_connection method to Databricks hook

2022-06-24 Thread GitBox
phanikumv commented on code in PR #24617: URL: https://github.com/apache/airflow/pull/24617#discussion_r905972816 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -408,3 +410,18 @@ def get_repo_by_path(self, path: str) -> Optional[str]: raise e

[GitHub] [airflow] denimalpaca commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-24 Thread GitBox
denimalpaca commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r906013654 ## airflow/providers/core/sql/operators/sql.py: ## @@ -0,0 +1,308 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

[GitHub] [airflow] bbovenzi closed issue #24620: Grid view disappears when hovering over skipped tasks

2022-06-24 Thread GitBox
bbovenzi closed issue #24620: Grid view disappears when hovering over skipped tasks URL: https://github.com/apache/airflow/issues/24620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [airflow] bbovenzi commented on issue #24620: Grid view disappears when hovering over skipped tasks

2022-06-24 Thread GitBox
bbovenzi commented on issue #24620: URL: https://github.com/apache/airflow/issues/24620#issuecomment-1165530947 It looks like it was fixed in https://github.com/apache/airflow/commit/451a6f4d9ff8b744075e2f25099046c77f28179e#diff-50b1f3bc397270b30a4ed4928fb0a03896ecae7e9278546acccb5d53bd1c0f3

[GitHub] [airflow] potiuk commented on issue #24624: Redacted Variables override original value

2022-06-24 Thread GitBox
potiuk commented on issue #24624: URL: https://github.com/apache/airflow/issues/24624#issuecomment-1165532160 Why don't we simply remove the "hidden" field from the export altogether. This would be consistent with the approach that hidden values should never be accessible from the UI. The u

[GitHub] [airflow] dstandish commented on pull request #24613: Add dataset model

2022-06-24 Thread GitBox
dstandish commented on PR #24613: URL: https://github.com/apache/airflow/pull/24613#issuecomment-1165540629 > We put `DAG` and `DagModel` in the same module, so the same can be done here. yeah i know about dagmodel @uranusjr, but @ashb's comment indicated to me that putting in diff l

[GitHub] [airflow] ashb commented on a diff in pull request #24044: Have consistent types between the ORM and the migration files

2022-06-24 Thread GitBox
ashb commented on code in PR #24044: URL: https://github.com/apache/airflow/pull/24044#discussion_r906032357 ## airflow/utils/db.py: ## @@ -1675,6 +1675,56 @@ def create_global_lock( pass +def compare_type(context, inspected_column, metadata_column, inspected_ty

[GitHub] [airflow] krcrouse opened a new pull request, #24636: Fix pid check

2022-06-24 Thread GitBox
krcrouse opened a new pull request, #24636: URL: https://github.com/apache/airflow/pull/24636 related: #17507 related: #20992 --- This fixes issues in which running a task with impersonation leads to the error `Recorded pid {PID1} does not match the current pid {PID2}`. The issue

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24636: Fix pid check

2022-06-24 Thread GitBox
boring-cyborg[bot] commented on PR #24636: URL: https://github.com/apache/airflow/pull/24636#issuecomment-1165544969 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] ashb commented on a diff in pull request #24044: Have consistent types between the ORM and the migration files

2022-06-24 Thread GitBox
ashb commented on code in PR #24044: URL: https://github.com/apache/airflow/pull/24044#discussion_r906035960 ## airflow/migrations/versions/0112_2_4_0_compare_types_between_orm_and_db.py: ## @@ -0,0 +1,267 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or

[GitHub] [airflow] cgadam commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-06-24 Thread GitBox
cgadam commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1165551292 +1 on this one. I've also brought this up on: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1656075135345789 -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] ashb commented on pull request #24613: Add dataset model

2022-06-24 Thread GitBox
ashb commented on PR #24613: URL: https://github.com/apache/airflow/pull/24613#issuecomment-1165559119 You understood correctly @dstandish , but that said we don't have a place for those extra classes to live, so for now follow DAG/DagModel (though I hate the `Model` suffix) so we can get t

[GitHub] [airflow] ashb commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-06-24 Thread GitBox
ashb commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1165563736 > +1 on this one. I've also brought this up on: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1656075135345789 Have you tried with 2.3.2? -- This is an automated messa

[GitHub] [airflow] bbovenzi commented on issue #24630: All the task cells in the same row are showing same state (latest state)

2022-06-24 Thread GitBox
bbovenzi commented on issue #24630: URL: https://github.com/apache/airflow/issues/24630#issuecomment-1165564792 Duplicate of https://github.com/apache/airflow/issues/24410 and fixed in https://github.com/apache/airflow/pull/24327 -- This is an automated message from the Apache Git Service

[GitHub] [airflow] bbovenzi closed issue #24630: All the task cells in the same row are showing same state (latest state)

2022-06-24 Thread GitBox
bbovenzi closed issue #24630: All the task cells in the same row are showing same state (latest state) URL: https://github.com/apache/airflow/issues/24630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] uranusjr commented on pull request #24373: Fix timezone display for logs on UI by adding %z for %(asctime)s (#23796)

2022-06-24 Thread GitBox
uranusjr commented on PR #24373: URL: https://github.com/apache/airflow/pull/24373#issuecomment-1165565198 Failure unrelated (and this doesn’t change the providers). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] uranusjr merged pull request #24373: Add %z for %(asctime)s to fix timezone for logs on UI

2022-06-24 Thread GitBox
uranusjr merged PR #24373: URL: https://github.com/apache/airflow/pull/24373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[GitHub] [airflow] uranusjr closed issue #23796: Webserver shows wrong datetime (timezone) in log

2022-06-24 Thread GitBox
uranusjr closed issue #23796: Webserver shows wrong datetime (timezone) in log URL: https://github.com/apache/airflow/issues/23796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24373: Add %z for %(asctime)s to fix timezone for logs on UI

2022-06-24 Thread GitBox
boring-cyborg[bot] commented on PR #24373: URL: https://github.com/apache/airflow/pull/24373#issuecomment-1165566139 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[airflow] branch main updated: Add %z for %(asctime)s to fix timezone for logs on UI (#24373)

2022-06-24 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7de050ceeb Add %z for %(asctime)s to fix timezone

[GitHub] [airflow] bbovenzi commented on issue #24410: Airflow Grid view UI issues

2022-06-24 Thread GitBox
bbovenzi commented on issue #24410: URL: https://github.com/apache/airflow/issues/24410#issuecomment-1165569509 Actually, 2 was fixed in https://github.com/apache/airflow/pull/23934 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [airflow] bbovenzi closed issue #24410: Airflow Grid view UI issues

2022-06-24 Thread GitBox
bbovenzi closed issue #24410: Airflow Grid view UI issues URL: https://github.com/apache/airflow/issues/24410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [airflow] potiuk commented on issue #16654: "Suggest a change on this page" button bug/change request

2022-06-24 Thread GitBox
potiuk commented on issue #16654: URL: https://github.com/apache/airflow/issues/16654#issuecomment-1165579653 The .py files are generated by autoapi plugin - that's what I know. once the build is done, they are all generated in _api subfolder, so the most likely way to check it is to use th

[GitHub] [airflow] cgadam commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-06-24 Thread GitBox
cgadam commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1165588430 > > +1 on this one. I've also brought this up on: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1656075135345789 > > Have you tried with 2.3.2? Yep, I'm actually

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24044: Have consistent types between the ORM and the migration files

2022-06-24 Thread GitBox
ephraimbuddy commented on code in PR #24044: URL: https://github.com/apache/airflow/pull/24044#discussion_r906079039 ## airflow/models/taskinstance.py: ## @@ -458,13 +458,16 @@ class TaskInstance(Base, LoggingMixin): pid = Column(Integer) executor_config = Column(Pickl

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24623: Grid task log, multi select and ts files migration.

2022-06-24 Thread GitBox
bbovenzi commented on code in PR #24623: URL: https://github.com/apache/airflow/pull/24623#discussion_r906080330 ## airflow/www/static/js/grid/api/useTaskLog.tsx: ## @@ -17,23 +17,31 @@ * under the License. */ -import axios from 'axios'; +import axios, { AxiosResponse } fr

[GitHub] [airflow] bbovenzi commented on a diff in pull request #24623: Grid task log, multi select and ts files migration.

2022-06-24 Thread GitBox
bbovenzi commented on code in PR #24623: URL: https://github.com/apache/airflow/pull/24623#discussion_r906082433 ## airflow/www/static/js/grid/details/content/taskInstance/index.tsx: ## @@ -205,7 +205,7 @@ const TaskInstance = ({ taskId, runId }: Props) => {

[GitHub] [airflow] potiuk closed issue #19754: ExternalTaskSensor should skip if soft_fail=True and external task in one of the failed_states

2022-06-24 Thread GitBox
potiuk closed issue #19754: ExternalTaskSensor should skip if soft_fail=True and external task in one of the failed_states URL: https://github.com/apache/airflow/issues/19754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] potiuk merged pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-24 Thread GitBox
potiuk merged PR #23647: URL: https://github.com/apache/airflow/pull/23647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-24 Thread GitBox
boring-cyborg[bot] commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1165596382 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[airflow] branch main updated: ExternalTaskSensor respects soft_fail if the external task enters a failed_state (#23647)

2022-06-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1b345981f6 ExternalTaskSensor respects soft_fail if

[GitHub] [airflow] potiuk commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-24 Thread GitBox
potiuk commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1165596473 :tada: :tada: :tada: :tada: :tada: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] potiuk commented on pull request #23647: ExternalTaskSensor respects soft_fail if the external task enters a failed_state

2022-06-24 Thread GitBox
potiuk commented on PR #23647: URL: https://github.com/apache/airflow/pull/23647#issuecomment-1165597942 Too bad you became 2098th contributor... it was close though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165602817 Ah yeah. This might also be handy when it comes to running tests on ARM in CI when we convert our CI to use the new breeze for testing (that one is still pending). but if it's on

[GitHub] [airflow] potiuk commented on pull request #24626: Add --platform to breeze shell and start-airflow

2022-06-24 Thread GitBox
potiuk commented on PR #24626: URL: https://github.com/apache/airflow/pull/24626#issuecomment-1165603782 Tests run docker-compose under the hoood. You can run it with `--dry-run` and see the command and then it's easy to copy&paste manully after manually correcting the compose file. This is

[GitHub] [airflow] potiuk commented on pull request #24373: Add %z for %(asctime)s to fix timezone for logs on UI

2022-06-24 Thread GitBox
potiuk commented on PR #24373: URL: https://github.com/apache/airflow/pull/24373#issuecomment-1165609482 The failure was because oit was not rebased BTW -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] bbovenzi commented on issue #23588: After upgrade from Airflow 2.2.4, grid disappears for some DAGs

2022-06-24 Thread GitBox
bbovenzi commented on issue #23588: URL: https://github.com/apache/airflow/issues/23588#issuecomment-1165611019 Yes, I don't think we made the UI-side fix in time for 2.3.2 but it will be in 2.3.3 -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [airflow-site] potiuk merged pull request #617: Alphabetize based on link text not url

2022-06-24 Thread GitBox
potiuk merged PR #617: URL: https://github.com/apache/airflow-site/pull/617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow-site] branch main updated: Alphabetize based on link text not url (#617)

2022-06-24 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new f467b83147 Alphabetize based on link text not

[GitHub] [airflow] denimalpaca commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-24 Thread GitBox
denimalpaca commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r906112005 ## airflow/providers/core/sql/operators/sql.py: ## @@ -0,0 +1,308 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licens

[GitHub] [airflow-site] potiuk merged pull request #613: Fix example_dags and system tests "source" links in documentation

2022-06-24 Thread GitBox
potiuk merged PR #613: URL: https://github.com/apache/airflow-site/pull/613 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ f467b831478d4c01bc3ce4786b4e47189729706c 🚀

2022-06-24 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new f041181ee8 Deploying to gh-pages f

[GitHub] [airflow] potiuk commented on pull request #24634: Allows to specify different Python base image when building images

2022-06-24 Thread GitBox
potiuk commented on PR #24634: URL: https://github.com/apache/airflow/pull/24634#issuecomment-1165631276 Might be useful in the future in case Python base image break something (we thought it was the case today but it turned out to be amqp on ARM). -- This is an automated message from the

[GitHub] [airflow-site] potiuk closed issue #324: Documentation: The copy button (for source code) is misplaced and links to 404

2022-06-24 Thread GitBox
potiuk closed issue #324: Documentation: The copy button (for source code) is misplaced and links to 404 URL: https://github.com/apache/airflow-site/issues/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow-site] potiuk commented on issue #324: Documentation: The copy button (for source code) is misplaced and links to 404

2022-06-24 Thread GitBox
potiuk commented on issue #324: URL: https://github.com/apache/airflow-site/issues/324#issuecomment-1165648361 Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [airflow-site] potiuk commented on issue #536: Links to provider example dags are broken

2022-06-24 Thread GitBox
potiuk commented on issue #536: URL: https://github.com/apache/airflow-site/issues/536#issuecomment-1165649853 This is all fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on issue #23480: Broken link example_external_task_marker_dag.html

2022-06-24 Thread GitBox
potiuk commented on issue #23480: URL: https://github.com/apache/airflow/issues/23480#issuecomment-1165651077 The links are fixed. For older missing source links we now have link to the direct version in Github. For new pages that we will generate (2.3.3+) they will lead to embedded sources

[GitHub] [airflow] potiuk closed issue #23480: Broken link example_external_task_marker_dag.html

2022-06-24 Thread GitBox
potiuk closed issue #23480: Broken link example_external_task_marker_dag.html URL: https://github.com/apache/airflow/issues/23480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-24 Thread GitBox
ephraimbuddy commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r906159148 ## airflow/providers/core/sql/operators/sql.py: ## @@ -0,0 +1,308 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #24476: Add Core SQL Provider

2022-06-24 Thread GitBox
ephraimbuddy commented on code in PR #24476: URL: https://github.com/apache/airflow/pull/24476#discussion_r905811972 ## airflow/providers/core/sql/operators/sql.py: ## @@ -0,0 +1,308 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor licen

[GitHub] [airflow] chenglongyan closed pull request #24541: Migrate Google example DAG mssql_to_gcs to new design AIP-47

2022-06-24 Thread GitBox
chenglongyan closed pull request #24541: Migrate Google example DAG mssql_to_gcs to new design AIP-47 URL: https://github.com/apache/airflow/pull/24541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

  1   2   >