[GitHub] [airflow] zaibacu commented on issue #22035: In 'list users', clicking 'show record' button returns an error page

2023-01-04 Thread GitBox
zaibacu commented on issue #22035: URL: https://github.com/apache/airflow/issues/22035#issuecomment-1371882785 Still broken in 2.4.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 20e12f345f Updating con

[GitHub] [airflow] j-martin commented on pull request #28736: css, cap dropdown menu size dynamically

2023-01-04 Thread GitBox
j-martin commented on PR #28736: URL: https://github.com/apache/airflow/pull/28736#issuecomment-1371859134 In this case, the `85vh` is only ever reached if the menu items count is significant enough. Prior to https://github.com/apache/airflow/pull/28561, the menu could be much longer than t

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28675: MongoHook optimization

2023-01-04 Thread GitBox
stamixthereal commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1062167244 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -74,12 +68,13 @@ def __exit__( exc_val: BaseException | None, exc_tb: TracebackType | None,

[GitHub] [airflow] uranusjr commented on a diff in pull request #28097: logging poke info when external dag is not none and task_id and task_ids are none

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28097: URL: https://github.com/apache/airflow/pull/28097#discussion_r1062158484 ## airflow/sensors/external_task.py: ## @@ -140,21 +140,30 @@ def __init__( f"`{self.allowed_states}` and failed states `{self.failed_states}`"

[GitHub] [airflow] uranusjr commented on a diff in pull request #28675: MongoHook optimization

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1062156579 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -74,12 +68,13 @@ def __exit__( exc_val: BaseException | None, exc_tb: TracebackType | None, )

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28675: MongoHook optimization

2023-01-04 Thread GitBox
stamixthereal commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1062154743 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -74,12 +68,13 @@ def __exit__( exc_val: BaseException | None, exc_tb: TracebackType | None,

[GitHub] [airflow] uranusjr commented on pull request #28724: Use dagrun instead of DagFileProcessor in backfill_job test

2023-01-04 Thread GitBox
uranusjr commented on PR #28724: URL: https://github.com/apache/airflow/pull/28724#issuecomment-1371841783 Also, could you do some history digging (`git blame`) to find when the xfail was added, and if there’s any reasoning associated with the addition. -- This is an automated message fro

[GitHub] [airflow] uranusjr commented on a diff in pull request #28724: Use dagrun instead of DagFileProcessor in backfill_job test

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28724: URL: https://github.com/apache/airflow/pull/28724#discussion_r1062153339 ## tests/jobs/test_backfill_job.py: ## @@ -147,31 +147,22 @@ def test_dag_run_with_finished_tasks_set_to_success(self, dag_maker): assert State.SUCCESS =

[airflow] branch main updated: clean verify_providers.py warnings for `DummyOperator` (#28726)

2023-01-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 0be5c90639 clean verify_providers.py warnings for

[GitHub] [airflow] eladkal merged pull request #28726: clean verify_providers.py warnings for `DummyOperator`

2023-01-04 Thread GitBox
eladkal merged PR #28726: URL: https://github.com/apache/airflow/pull/28726 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[GitHub] [airflow] uranusjr commented on a diff in pull request #28502: Migrate DagFileProcessor.manage_slas to Internal API

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28502: URL: https://github.com/apache/airflow/pull/28502#discussion_r1062145096 ## airflow/dag_processing/processor.py: ## @@ -365,8 +365,10 @@ def __init__(self, dag_ids: list[str] | None, dag_directory: str, log: logging.L self._dag_

[GitHub] [airflow] uranusjr commented on a diff in pull request #28675: MongoHook optimization

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1062144203 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -74,12 +68,13 @@ def __exit__( exc_val: BaseException | None, exc_tb: TracebackType | None, )

[GitHub] [airflow] uranusjr commented on a diff in pull request #28675: MongoHook optimization

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28675: URL: https://github.com/apache/airflow/pull/28675#discussion_r1062144019 ## airflow/providers/mongo/hooks/mongo.py: ## @@ -90,15 +85,25 @@ def get_conn(self) -> MongoClient: options.update({"ssl_cert_reqs": CERT_NONE})

[GitHub] [airflow] uranusjr commented on a diff in pull request #28693: AIP-44 Migrate DagModel.get_paused_dag_ids to Internal API

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28693: URL: https://github.com/apache/airflow/pull/28693#discussion_r1062143530 ## airflow/api_internal/endpoints/rpc_api_endpoint.py: ## @@ -24,6 +24,7 @@ from airflow.api_connexion.types import APIResponse from airflow.dag_processing.proce

[GitHub] [airflow] clairezhuang commented on issue #27830: DatabricksSubmitRunDeferrableOperator runs in timeout when using AAD Token for SPN

2023-01-04 Thread GitBox
clairezhuang commented on issue #27830: URL: https://github.com/apache/airflow/issues/27830#issuecomment-1371829492 The job runs 5-10 minutes and thanks for your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] uranusjr commented on pull request #28736: css, cap dropdown menu size dynamically

2023-01-04 Thread GitBox
uranusjr commented on PR #28736: URL: https://github.com/apache/airflow/pull/28736#issuecomment-1371821775 Would it be a good idea to use `min` here? 75vh can be quite long in some situations. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[airflow] branch main updated: Add retry to purge_inactive_dag_warnings (#28481)

2023-01-04 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5289938ec1 Add retry to purge_inactive_dag_warnin

[GitHub] [airflow] uranusjr merged pull request #28481: Add retry to purge_inactive_dag_warnings

2023-01-04 Thread GitBox
uranusjr merged PR #28481: URL: https://github.com/apache/airflow/pull/28481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

[GitHub] [airflow] uranusjr commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1062126884 ## airflow/cli/commands/connection_command.py: ## @@ -301,19 +301,26 @@ def connections_delete(args): def connections_import(args): """Imports connections from

[GitHub] [airflow] uranusjr commented on a diff in pull request #28738: Add --overwrite option to `connections import` CLI command

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28738: URL: https://github.com/apache/airflow/pull/28738#discussion_r1062125362 ## airflow/cli/commands/connection_command.py: ## @@ -301,19 +301,26 @@ def connections_delete(args): def connections_import(args): """Imports connections from

[GitHub] [airflow] JGoldman110 commented on issue #28381: CVE-2019-17495 for swagger-ui

2023-01-04 Thread GitBox
JGoldman110 commented on issue #28381: URL: https://github.com/apache/airflow/issues/28381#issuecomment-1371638000 The maintainer of `swagger-ui-bundle` has abandoned the project, and this is a dependency of the `connexion[swagger-ui]` extra. I don't see any alternative python package which

[GitHub] [airflow] ccwillia commented on issue #28010: Airflow does not pass through Celery's support for Redis Sentinel over SSL.

2023-01-04 Thread GitBox
ccwillia commented on issue #28010: URL: https://github.com/apache/airflow/issues/28010#issuecomment-1371614180 Was this ever resolved? I am using a single sentinel URL in airflow 1.10.10 which works. I have begun migrating to airflow 2.5 and it does not appear to be working -- This is

[GitHub] [airflow] Taragolis commented on issue #28731: AttributeError: 'ExaStatement' object has no attribute 'description'

2023-01-04 Thread GitBox
Taragolis commented on issue #28731: URL: https://github.com/apache/airflow/issues/28731#issuecomment-1371576296 Yep, for some reason it does not propagate parameters to the method which supports parameters. Maybe we do not need to use DbApiHook for databases which do not have fully

[GitHub] [airflow] github-actions[bot] closed pull request #26710: Add config to control Kubernetes Client retry behaviour

2023-01-04 Thread GitBox
github-actions[bot] closed pull request #26710: Add config to control Kubernetes Client retry behaviour URL: https://github.com/apache/airflow/pull/26710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] hussein-awala commented on issue #28734: helmChart values.yaml with log persistence enabled follow the documentation cause errors

2023-01-04 Thread GitBox
hussein-awala commented on issue #28734: URL: https://github.com/apache/airflow/issues/28734#issuecomment-1371568027 This is not a problem in the chart but a restriction in kubernetes, as there are some immutable fields in the statefulset (the kubernetes object used to run ariflow worker wh

[GitHub] [airflow] o-nikolas commented on pull request #28161: AIP-51 - Executor Coupling in Logging

2023-01-04 Thread GitBox
o-nikolas commented on PR #28161: URL: https://github.com/apache/airflow/pull/28161#issuecomment-1371567456 > @o-nikolas i did some manual testing with different executors. it is working as expected. Fantastic! Thanks @snjypl! Sorry for the delayed response but I was out on hol

[GitHub] [airflow] o-nikolas commented on pull request #28638: Fix for LocalKubernetesExecutor scheduler is not serving logs

2023-01-04 Thread GitBox
o-nikolas commented on PR #28638: URL: https://github.com/apache/airflow/pull/28638#issuecomment-1371561421 Hey folks! I definitely agree with splitting out `is_local` into more fine grained compatibility flags/properties ([see here](https://github.com/apache/airflow/issues/28276#iss

[GitHub] [airflow] potiuk commented on issue #11708: Git sync for plugins in the Helm Chart

2023-01-04 Thread GitBox
potiuk commented on issue #11708: URL: https://github.com/apache/airflow/issues/11708#issuecomment-1371554995 > hey guys, just curious: is this approach even possible? I mean: sync plugins with git-sync. I had impression that 'plugins' must be in place before airflow starts. Otherwise if yo

[GitHub] [airflow] o-nikolas commented on issue #28276: AIP - 51 Make CeleryKubernetesExecutor extends BaseExecutor for a common API.

2023-01-04 Thread GitBox
o-nikolas commented on issue #28276: URL: https://github.com/apache/airflow/issues/28276#issuecomment-1371553409 > I think if we split is_local flag to those three values, we should be able to determine the right set of properties that each executor should have. Hey @potiuk thanks for

[GitHub] [airflow] potiuk closed issue #28665: Exception method for using Airflow with error handling in Slack

2023-01-04 Thread GitBox
potiuk closed issue #28665: Exception method for using Airflow with error handling in Slack URL: https://github.com/apache/airflow/issues/28665 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [airflow] alff commented on issue #11708: Git sync for plugins in the Helm Chart

2023-01-04 Thread GitBox
alff commented on issue #11708: URL: https://github.com/apache/airflow/issues/11708#issuecomment-1371552619 hey guys, just curious: is this approach even possible? I mean: sync plugins with git-sync. I had impression that 'plugins' must be in place before airflow starts. Otherwise if you st

[GitHub] [airflow] potiuk commented on issue #28665: Exception method for using Airflow with error handling in Slack

2023-01-04 Thread GitBox
potiuk commented on issue #28665: URL: https://github.com/apache/airflow/issues/28665#issuecomment-1371552613 Seems like a discussion/troubleshooting rather than issue - and the description is very difficult to understand. I do not even understand what your problem is @emincanoguz11.

[GitHub] [airflow] Taragolis commented on issue #28658: Fix Quarantine tests

2023-01-04 Thread GitBox
Taragolis commented on issue #28658: URL: https://github.com/apache/airflow/issues/28658#issuecomment-1371549619 [TestImpersonation](https://github.com/apache/airflow/blob/bfcae349b88fd959e32bfacd027a5be976fe2132/tests/core/test_impersonation_tests.py#L117), [TestImpersonationWithCustomPyt

[GitHub] [airflow] potiuk commented on issue #28731: AttributeError: 'ExaStatement' object has no attribute 'description'

2023-01-04 Thread GitBox
potiuk commented on issue #28731: URL: https://github.com/apache/airflow/issues/28731#issuecomment-1371544669 @Taragolis ->seems the DB-API-2 wrapper is not used because it does not support placeholders /parameters. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [airflow] potiuk commented on issue #28731: AttributeError: 'ExaStatement' object has no attribute 'description'

2023-01-04 Thread GitBox
potiuk commented on issue #28731: URL: https://github.com/apache/airflow/issues/28731#issuecomment-1371542359 Thanks for reporitng @mkalinna BTW. For the moment, the easy workaround for now is to downgrade Exasol provider to previous working version (4.1.1) -- This is an automated message

[GitHub] [airflow] Taragolis commented on issue #28665: Exception method for using Airflow with error handling in Slack

2023-01-04 Thread GitBox
Taragolis commented on issue #28665: URL: https://github.com/apache/airflow/issues/28665#issuecomment-1371542104 Could you provide a sample DAG code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] hussein-awala commented on pull request #28711: Disable the dag file processor agent when dag_dir_list_interval is negative value

2023-01-04 Thread GitBox
hussein-awala commented on PR #28711: URL: https://github.com/apache/airflow/pull/28711#issuecomment-1371539491 @ashb I reread the code of `DagFileProcessorManager` and I found that it only does two types of cleaning: 1- clean stale dags 2- clean the import errors for files that no lon

[GitHub] [airflow] potiuk commented on a diff in pull request #28697: Allow to specify `pip` version via github URL in Docker/CI workflow

2023-01-04 Thread GitBox
potiuk commented on code in PR #28697: URL: https://github.com/apache/airflow/pull/28697#discussion_r1061962761 ## Dockerfile: ## @@ -445,6 +436,18 @@ function common::show_pip_version_and_location() { echo "pip on path: $(which pip)" echo "Using pip: $(pip --version)"

[GitHub] [airflow] o-nikolas commented on pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-04 Thread GitBox
o-nikolas commented on PR #28710: URL: https://github.com/apache/airflow/pull/28710#issuecomment-1371533722 > ok @o-nikolas and @feluelle i have updated these tests to move the "tokens" to individual params. it's not quite "putting the test values in the tuple", which, if i understood corre

[GitHub] [airflow] potiuk commented on a diff in pull request #28697: Allow to specify `pip` version via github URL in Docker/CI workflow

2023-01-04 Thread GitBox
potiuk commented on code in PR #28697: URL: https://github.com/apache/airflow/pull/28697#discussion_r1061960382 ## Dockerfile: ## @@ -445,6 +436,18 @@ function common::show_pip_version_and_location() { echo "pip on path: $(which pip)" echo "Using pip: $(pip --version)"

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-04 Thread GitBox
o-nikolas commented on code in PR #28710: URL: https://github.com/apache/airflow/pull/28710#discussion_r1061955523 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -884,66 +883,75 @@ def do_something(self, bucket_name=None, key=None): else: -class MyHook(S3

[GitHub] [airflow] hussein-awala commented on a diff in pull request #28711: Disable the dag file processor agent when dag_dir_list_interval is negative value

2023-01-04 Thread GitBox
hussein-awala commented on code in PR #28711: URL: https://github.com/apache/airflow/pull/28711#discussion_r1061955624 ## airflow/jobs/scheduler_job.py: ## @@ -151,6 +151,7 @@ def __init__( # How many seconds do we wait for tasks to heartbeat before mark them as zombie

[GitHub] [airflow] Taragolis commented on issue #28731: AttributeError: 'ExaStatement' object has no attribute 'description'

2023-01-04 Thread GitBox
Taragolis commented on issue #28731: URL: https://github.com/apache/airflow/issues/28731#issuecomment-1371522930 > AttributeError: 'ExaStatement' object has no attribute 'description' Something here went wrong. Because description property is a mandatory in [DB-API 2](https://peps.pyt

[GitHub] [airflow] Taragolis commented on issue #28731: AttributeError: 'ExaStatement' object has no attribute 'description'

2023-01-04 Thread GitBox
Taragolis commented on issue #28731: URL: https://github.com/apache/airflow/issues/28731#issuecomment-1371513544 > It seems likely the issue was introduced in a refactoring of the Exasol Hook to use common DBApiHook https://github.com/apache/airflow/pull/28009/commits This one includ

[GitHub] [airflow] potiuk merged pull request #28717: Update new committer onboarding steps

2023-01-04 Thread GitBox
potiuk merged PR #28717: URL: https://github.com/apache/airflow/pull/28717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: Update new committer onboarding steps (#28717)

2023-01-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 628a71aa14 Update new committer onboarding steps (#

[GitHub] [airflow] hussein-awala commented on a diff in pull request #28713: Add a param for get_dags endpoint to list only unpaused dags

2023-01-04 Thread GitBox
hussein-awala commented on code in PR #28713: URL: https://github.com/apache/airflow/pull/28713#discussion_r1061917772 ## airflow/api_connexion/endpoints/dag_endpoint.py: ## @@ -74,14 +74,15 @@ def get_dags( tags: Collection[str] | None = None, dag_id_pattern: str | No

[GitHub] [airflow] dstandish commented on pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-04 Thread GitBox
dstandish commented on PR #28710: URL: https://github.com/apache/airflow/pull/28710#issuecomment-1371446257 ok @o-nikolas and @feluelle i have updated these tests to move the "tokens" to individual params. it's not quite "putting the test values in the tuple", which, if i understood correc

[GitHub] [airflow] pierrejeambrun closed issue #22320: Copying DAG ID from UI and pasting in Slack includes schedule

2023-01-04 Thread GitBox
pierrejeambrun closed issue #22320: Copying DAG ID from UI and pasting in Slack includes schedule URL: https://github.com/apache/airflow/issues/22320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch main updated: Nest header blocks in divs to fix dagid copy nit on dag.html (#28643)

2023-01-04 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9aea857343 Nest header blocks in divs to fi

[GitHub] [airflow] pierrejeambrun merged pull request #28643: Nest header blocks in divs to fix dagid copy nit on dag.html

2023-01-04 Thread GitBox
pierrejeambrun merged PR #28643: URL: https://github.com/apache/airflow/pull/28643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@a

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-04 Thread GitBox
pierrejeambrun commented on code in PR #28375: URL: https://github.com/apache/airflow/pull/28375#discussion_r1061871292 ## airflow/executors/executor_loader.py: ## @@ -167,10 +167,3 @@ def __load_local_kubernetes_executor(cls) -> BaseExecutor: local_kubernetes_executo

[GitHub] [airflow] natanweinberger commented on pull request #15177: Import connections from a file

2023-01-04 Thread GitBox
natanweinberger commented on PR #15177: URL: https://github.com/apache/airflow/pull/15177#issuecomment-1371425682 > Hi @natanweinberger , can we have a `--override` option which updates the connection when there is a conflict ? Good idea, I just opened a PR that adds this functionalit

[GitHub] [airflow] irudson commented on a diff in pull request #28705: Update S3ToRedshift Operator docs to indicate multiple key functionality

2023-01-04 Thread GitBox
irudson commented on code in PR #28705: URL: https://github.com/apache/airflow/pull/28705#discussion_r1061885226 ## airflow/providers/amazon/aws/transfers/s3_to_redshift.py: ## @@ -42,7 +42,7 @@ class S3ToRedshiftOperator(BaseOperator): :param schema: reference to a specifi

[GitHub] [airflow] michaelmicheal commented on pull request #28481: dagwarning, add retry to purge_inactive_dag_warnings

2023-01-04 Thread GitBox
michaelmicheal commented on PR #28481: URL: https://github.com/apache/airflow/pull/28481#issuecomment-1371416934 @uranusjr, @kaxil , is this good to merge? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] dstandish commented on a diff in pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-04 Thread GitBox
dstandish commented on code in PR #28710: URL: https://github.com/apache/airflow/pull/28710#discussion_r1061869329 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -825,3 +826,143 @@ def test_delete_bucket_tagging_with_no_tags(self): with pytest.raises(ClientErro

[GitHub] [airflow] dstandish commented on a diff in pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-04 Thread GitBox
dstandish commented on code in PR #28710: URL: https://github.com/apache/airflow/pull/28710#discussion_r1061868471 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -825,3 +826,143 @@ def test_delete_bucket_tagging_with_no_tags(self): with pytest.raises(ClientErro

[airflow] branch main updated (a7e1cb2fbf -> 1da17be376)

2023-01-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a7e1cb2fbf Add general-purpose "notifier" concept to DAGs (#28569) add 1da17be376 Fix "airflow tasks rend

[GitHub] [airflow] ephraimbuddy merged pull request #28698: Fix "airflow tasks render" cli command for mapped task instances

2023-01-04 Thread GitBox
ephraimbuddy merged PR #28698: URL: https://github.com/apache/airflow/pull/28698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

[GitHub] [airflow] ephraimbuddy closed issue #26555: "airflow tasks render/state" cli commands do not work for mapped task instances

2023-01-04 Thread GitBox
ephraimbuddy closed issue #26555: "airflow tasks render/state" cli commands do not work for mapped task instances URL: https://github.com/apache/airflow/issues/26555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[airflow] branch main updated (24af35b18f -> a7e1cb2fbf)

2023-01-04 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 24af35b18f Add tests to document current s3 hook decorator behavior (#28707) add a7e1cb2fbf Add general-

[GitHub] [airflow] ephraimbuddy merged pull request #28569: Add general-purpose "notifier" concept to DAGs

2023-01-04 Thread GitBox
ephraimbuddy merged PR #28569: URL: https://github.com/apache/airflow/pull/28569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

[GitHub] [airflow] ephraimbuddy closed issue #28405: Add general-purpose "notifier" concept to DAGs for easier slack/teams/email notifications

2023-01-04 Thread GitBox
ephraimbuddy closed issue #28405: Add general-purpose "notifier" concept to DAGs for easier slack/teams/email notifications URL: https://github.com/apache/airflow/issues/28405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [airflow] dstandish commented on a diff in pull request #28710: Apply "unify bucket and key" before "provide bucket"

2023-01-04 Thread GitBox
dstandish commented on code in PR #28710: URL: https://github.com/apache/airflow/pull/28710#discussion_r1061865510 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -825,3 +826,143 @@ def test_delete_bucket_tagging_with_no_tags(self): with pytest.raises(ClientErro

[GitHub] [airflow] rkarish commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-04 Thread GitBox
rkarish commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1371395461 That would be great to get another set of eyes on this. Congratulations on becoming a Committer by the way! Would love for you to do the honors on this one 😄 . -- This is an automate

[GitHub] [airflow] rkarish commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-04 Thread GitBox
rkarish commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1371388933 You're welcome and Happy New Year! I figured you were on vacation, no rush on the review! -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [airflow] o-nikolas commented on pull request #28375: AIP-51 - Misc. Compatibility Checks

2023-01-04 Thread GitBox
o-nikolas commented on PR #28375: URL: https://github.com/apache/airflow/pull/28375#issuecomment-1371385753 > Hey Niko, I've submitted some more changes based on the feedback and requests. I reworked the pickling support attribute, switched to using your get executor class helper method, an

[airflow] branch main updated (fc510e8112 -> 24af35b18f)

2023-01-04 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from fc510e8112 Remove niko from triage group (#28733) add 24af35b18f Add tests to document current s3 hook decorato

[GitHub] [airflow] dstandish merged pull request #28707: Add tests to document current s3 hook decorator behavior

2023-01-04 Thread GitBox
dstandish merged PR #28707: URL: https://github.com/apache/airflow/pull/28707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[GitHub] [airflow] dstandish commented on pull request #28707: Add tests to document current s3 hook decorator behavior

2023-01-04 Thread GitBox
dstandish commented on PR #28707: URL: https://github.com/apache/airflow/pull/28707#issuecomment-1371379854 thanks @o-nikolas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow] dstandish commented on pull request #28721: Use connection URI in SqliteHook

2023-01-04 Thread GitBox
dstandish commented on PR #28721: URL: https://github.com/apache/airflow/pull/28721#issuecomment-1371378599 > I have found a solution [f3eaec7](https://github.com/apache/airflow/commit/f3eaec7875fc7bc373069320cf72d5852dbbc812) which does not require the conn_type to be added on user side. P

[GitHub] [airflow] natanweinberger opened a new pull request, #28738: Add connection cli overwrite flag

2023-01-04 Thread GitBox
natanweinberger opened a new pull request, #28738: URL: https://github.com/apache/airflow/pull/28738 The CLI command `airflow connections import ` cannot overwrite existing connections. Conflicts are skipped with the message `Could not import connection : connection already exists.`

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28528: Fixes to how DebugExecutor handles sensors

2023-01-04 Thread GitBox
vandonr-amz commented on code in PR #28528: URL: https://github.com/apache/airflow/pull/28528#discussion_r1061834010 ## airflow/ti_deps/deps/ready_to_reschedule.py: ## @@ -44,7 +45,8 @@ def _get_dep_statuses(self, ti, session, dep_context): from airflow.models.mappedope

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28472: Add AWS Sagemaker Auto ML operator and sensor

2023-01-04 Thread GitBox
vandonr-amz commented on code in PR #28472: URL: https://github.com/apache/airflow/pull/28472#discussion_r1061820842 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -958,3 +958,96 @@ def execute(self, context: Context): if group_created:

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #28472: Add AWS Sagemaker Auto ML operator and sensor

2023-01-04 Thread GitBox
vandonr-amz commented on code in PR #28472: URL: https://github.com/apache/airflow/pull/28472#discussion_r1061820842 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -958,3 +958,96 @@ def execute(self, context: Context): if group_created:

[GitHub] [airflow] bbovenzi opened a new issue, #28737: Add legend to grid view

2023-01-04 Thread GitBox
bbovenzi opened a new issue, #28737: URL: https://github.com/apache/airflow/issues/28737 ### Description It would be useful to add a simple legend to the grid view. - Help a user understand the icons for a manual / backfill / dataset triggered dag runs - Help a user understa

[GitHub] [airflow] bbovenzi commented on a diff in pull request #26993: Fix ti._try_number for deferred and up_for_reschedule tasks

2023-01-04 Thread GitBox
bbovenzi commented on code in PR #26993: URL: https://github.com/apache/airflow/pull/26993#discussion_r1061808714 ## airflow/utils/state.py: ## @@ -137,6 +137,20 @@ def color_fg(cls, state): return "white" return "black" +waiting: frozenset[TaskInstan

[GitHub] [airflow] michaelmicheal opened a new pull request, #28736: css, cap dropdown menu size dynamically

2023-01-04 Thread GitBox
michaelmicheal opened a new pull request, #28736: URL: https://github.com/apache/airflow/pull/28736 In this PR: https://github.com/apache/airflow/pull/28561, I capped the dropdown menu size to 300px and made it scrollable past there. Instead, we should cap it at 85%. https://user-images.

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #28521: Update doc for API clients release policy

2023-01-04 Thread GitBox
pierrejeambrun commented on code in PR #28521: URL: https://github.com/apache/airflow/pull/28521#discussion_r1061792206 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -41,6 +41,7 @@ - [Summarize the voting for the Apache Airflow release](#summarize-the-voting-for-the-apache-airflow

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28735: Change pool of processing statuses of Campaign Manager report

2023-01-04 Thread GitBox
boring-cyborg[bot] commented on PR #28735: URL: https://github.com/apache/airflow/pull/28735#issuecomment-1371242361 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] kacpermuda opened a new pull request, #28735: Change pool of processing statuses of Campaign Manager report

2023-01-04 Thread GitBox
kacpermuda opened a new pull request, #28735: URL: https://github.com/apache/airflow/pull/28735 Google Campaign Manager 360, in their latest api version (v4), introduced a new status that a report file can return. As v4 is the only version that is currently supported, we should update t

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28717: Update new committer onboarding steps

2023-01-04 Thread GitBox
o-nikolas commented on code in PR #28717: URL: https://github.com/apache/airflow/pull/28717#discussion_r1061740765 ## COMMITTERS.rst: ## @@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach 4. Wait at least 30 minutes for an em

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28717: Update new committer onboarding steps

2023-01-04 Thread GitBox
o-nikolas commented on code in PR #28717: URL: https://github.com/apache/airflow/pull/28717#discussion_r1061739836 ## COMMITTERS.rst: ## @@ -188,3 +188,4 @@ To be able to merge PRs, committers have to integrate their GitHub ID with Apach 4. Wait at least 30 minutes for an em

[GitHub] [airflow] hughlunnon commented on issue #28381: CVE-2019-17495 for swagger-ui

2023-01-04 Thread GitBox
hughlunnon commented on issue #28381: URL: https://github.com/apache/airflow/issues/28381#issuecomment-1371231585 I'm sorry, I've been completely snowed under, and being a JVM guy I don't know (easily) how to work with the dependency management in python (if I did I figure it'd be a 5 min j

[airflow] branch main updated (df0e4c9ad4 -> fc510e8112)

2023-01-04 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from df0e4c9ad4 Clarify about docker compose (#28729) add fc510e8112 Remove niko from triage group (#28733) No

[GitHub] [airflow] jedcunningham merged pull request #28733: Remove niko from triage group

2023-01-04 Thread GitBox
jedcunningham merged PR #28733: URL: https://github.com/apache/airflow/pull/28733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] JGoldman110 commented on issue #28381: CVE-2019-17495 for swagger-ui

2023-01-04 Thread GitBox
JGoldman110 commented on issue #28381: URL: https://github.com/apache/airflow/issues/28381#issuecomment-1371220970 @potiuk & @hughlunnon we have just upgraded to 2.5.0 and this vulnubility is coming up from our scans. Happy to raise a PR to resolve. -- This is an automated message from t

[GitHub] [airflow] jbandoro commented on issue #28679: Status of testing Providers that were prepared on January 02, 2023

2023-01-04 Thread GitBox
jbandoro commented on issue #28679: URL: https://github.com/apache/airflow/issues/28679#issuecomment-1371218773 Tested #28235 and it looks good, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] minnieshi opened a new issue, #28734: helmChart values.yaml with log persistence enabled follow the documentation cause errors

2023-01-04 Thread GitBox
minnieshi opened a new issue, #28734: URL: https://github.com/apache/airflow/issues/28734 ### Official Helm Chart version 1.7.0 (latest released) ### Apache Airflow version 2.4.1 ### Kubernetes Version v1.22.6 ### Helm Chart configuration see b

[GitHub] [airflow] eladkal opened a new pull request, #28733: Remove niko from triage group

2023-01-04 Thread GitBox
eladkal opened a new pull request, #28733: URL: https://github.com/apache/airflow/pull/28733 Now that niko is committer not need for triage role --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/mai

[GitHub] [airflow] yxiao1996 commented on pull request #28686: Update gantt chart UI to display queued state of tasks

2023-01-04 Thread GitBox
yxiao1996 commented on PR #28686: URL: https://github.com/apache/airflow/pull/28686#issuecomment-1371162750 ``` Unknown warnings generated: /usr/local/lib/python3.7/site-packages/airflow/models/base.py:49:[31mDeprecated API features detected! These feature(s) are not compatible wi

[GitHub] [airflow] eladkal commented on a diff in pull request #28721: Use connection URI in SqliteHook

2023-01-04 Thread GitBox
eladkal commented on code in PR #28721: URL: https://github.com/apache/airflow/pull/28721#discussion_r1061651779 ## airflow/providers/sqlite/hooks/sqlite.py: ## @@ -33,13 +34,16 @@ class SqliteHook(DbApiHook): def get_conn(self) -> sqlite3.dbapi2.Connection: """R

[airflow] branch main updated: Clarify about docker compose (#28729)

2023-01-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new df0e4c9ad4 Clarify about docker compose (#28729) d

[GitHub] [airflow] eladkal merged pull request #28729: Clarify about docker compose

2023-01-04 Thread GitBox
eladkal merged PR #28729: URL: https://github.com/apache/airflow/pull/28729 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[GitHub] [airflow] uranusjr commented on a diff in pull request #28697: Allow to specify `pip` version via github URL in Docker/CI workflow

2023-01-04 Thread GitBox
uranusjr commented on code in PR #28697: URL: https://github.com/apache/airflow/pull/28697#discussion_r1061641932 ## Dockerfile: ## @@ -445,6 +436,18 @@ function common::show_pip_version_and_location() { echo "pip on path: $(which pip)" echo "Using pip: $(pip --version)"

[GitHub] [airflow] uranusjr commented on issue #28723: Fix all deprecations for SQLAlchemy 2.0

2023-01-04 Thread GitBox
uranusjr commented on issue #28723: URL: https://github.com/apache/airflow/issues/28723#issuecomment-1371108400 I think we should support both 1.4 and 2.0 for at least one minor release, preferrably much longer. Dependencies don’t tend to catch up very fast for this kind of migrations, and

[GitHub] [airflow] stamixthereal commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2023-01-04 Thread GitBox
stamixthereal commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1061626539 ## airflow/api/client/json_client.py: ## @@ -40,63 +55,99 @@ def _request(self, url, method="GET", json=None): except Exception: d

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28619: Fix code readability, add docstrings to json_client

2023-01-04 Thread GitBox
ephraimbuddy commented on code in PR #28619: URL: https://github.com/apache/airflow/pull/28619#discussion_r1061624893 ## airflow/api/client/json_client.py: ## @@ -40,63 +55,99 @@ def _request(self, url, method="GET", json=None): except Exception: da

[GitHub] [airflow] ephraimbuddy commented on a diff in pull request #28521: Update doc for API clients release policy

2023-01-04 Thread GitBox
ephraimbuddy commented on code in PR #28521: URL: https://github.com/apache/airflow/pull/28521#discussion_r1061620448 ## dev/README_RELEASE_AIRFLOW.md: ## @@ -41,6 +41,7 @@ - [Summarize the voting for the Apache Airflow release](#summarize-the-voting-for-the-apache-airflow-r

  1   2   3   >