[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1069052780 ## airflow/utils/log/file_task_handler.py: ## @@ -73,6 +73,19 @@ def _fetch_logs_from_service(url, log_relative_path): return response +class

[GitHub] [airflow] boring-cyborg[bot] commented on issue #28912: quick start fails: DagRun for example_bash_operator with run_id or execution_date of '2015-01-01' not found

2023-01-12 Thread GitBox
boring-cyborg[bot] commented on issue #28912: URL: https://github.com/apache/airflow/issues/28912#issuecomment-1381441700 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] gxcuit opened a new issue, #28912: quick start fails: DagRun for example_bash_operator with run_id or execution_date of '2015-01-01' not found

2023-01-12 Thread GitBox
gxcuit opened a new issue, #28912: URL: https://github.com/apache/airflow/issues/28912 ### Apache Airflow version 2.5.0 ### What happened I follow the [quick start guide](https://airflow.apache.org/docs/apache-airflow/stable/start.html) When I execute `airflow

[airflow] branch main updated: Removal of flake8 file has broken breeze bind mounts (#28909)

2023-01-12 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 118d6505a5 Removal of flake8 file has broken

[GitHub] [airflow] Taragolis merged pull request #28909: Removal of flake8 file has broken breeze bind mounts

2023-01-12 Thread GitBox
Taragolis merged PR #28909: URL: https://github.com/apache/airflow/pull/28909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] Taragolis commented on a diff in pull request #28911: Making logging for HttpHook optional

2023-01-12 Thread GitBox
Taragolis commented on code in PR #28911: URL: https://github.com/apache/airflow/pull/28911#discussion_r1069048452 ## airflow/providers/http/hooks/http.py: ## @@ -147,7 +147,11 @@ def run( req = requests.Request(self.method, url, data=data, headers=headers,

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new fe361b49cb Updating

[GitHub] [airflow] johannaojeling commented on a diff in pull request #28764: Add support for running a Beam Go pipeline with an executable binary

2023-01-12 Thread GitBox
johannaojeling commented on code in PR #28764: URL: https://github.com/apache/airflow/pull/28764#discussion_r1069027057 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -520,12 +524,26 @@ class BeamRunGoPipelineOperator(BeamBasePipelineOperator): For more

[GitHub] [airflow] uranusjr commented on a diff in pull request #28894: Strip markup from `appbuilder.app_name` if `instance_name_has_markup = True`

2023-01-12 Thread GitBox
uranusjr commented on code in PR #28894: URL: https://github.com/apache/airflow/pull/28894#discussion_r1069023150 ## airflow/www/app.py: ## @@ -81,10 +82,18 @@ def create_app(config=None, testing=False): flask_app.config["PERMANENT_SESSION_LIFETIME"] =

[GitHub] [airflow] uranusjr commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
uranusjr commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1069019480 ## airflow/utils/log/file_task_handler.py: ## @@ -73,6 +73,19 @@ def _fetch_logs_from_service(url, log_relative_path): return response +class

[GitHub] [airflow] uranusjr commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
uranusjr commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1069020356 ## airflow/utils/log/file_task_handler.py: ## @@ -73,6 +73,19 @@ def _fetch_logs_from_service(url, log_relative_path): return response +class

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1069018218 ## airflow/utils/log/file_task_handler.py: ## @@ -73,6 +73,19 @@ def _fetch_logs_from_service(url, log_relative_path): return response +class

[GitHub] [airflow] uranusjr commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
uranusjr commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068991510 ## airflow/utils/log/file_task_handler.py: ## @@ -73,6 +73,19 @@ def _fetch_logs_from_service(url, log_relative_path): return response +class

[GitHub] [airflow] uranusjr commented on issue #28898: A way to set an environment variable as a sensible config

2023-01-12 Thread GitBox
uranusjr commented on issue #28898: URL: https://github.com/apache/airflow/issues/28898#issuecomment-1381384425 Looks like this is affected by #28756 and the proposed solution wouldn’t be needed since that is fixed? -- This is an automated message from the Apache Git Service. To respond

[airflow] branch main updated: KubenetesExecutor sends state even when successful (#28871)

2023-01-12 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8a9959cc1e KubenetesExecutor sends state even

[GitHub] [airflow] uranusjr merged pull request #28871: KubenetesExecutor sends state even when successful

2023-01-12 Thread GitBox
uranusjr merged PR #28871: URL: https://github.com/apache/airflow/pull/28871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #28881: No multiline log entry for bash env vars

2023-01-12 Thread GitBox
uranusjr commented on PR #28881: URL: https://github.com/apache/airflow/pull/28881#issuecomment-1381376597 Need to fix test to match the new behaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] amoghrajesh commented on issue #27507: Making logging for HttpHook optional

2023-01-12 Thread GitBox
amoghrajesh commented on issue #27507: URL: https://github.com/apache/airflow/issues/27507#issuecomment-1381368523 Thank you @potiuk! I was able to reproduce this locally and have tried providing a fix for this here https://github.com/apache/airflow/pull/28911 -- This is an automated

[GitHub] [airflow] uranusjr commented on a diff in pull request #28777: Fix dag run conf encoding with non-JSON serializable values

2023-01-12 Thread GitBox
uranusjr commented on code in PR #28777: URL: https://github.com/apache/airflow/pull/28777#discussion_r1068974814 ## airflow/utils/json.py: ## @@ -59,7 +59,11 @@ def default(self, o: Any) -> Any: data = serialize(o) if isinstance(data, dict) and DATA

[GitHub] [airflow] amoghrajesh opened a new pull request, #28911: Making logging for HttpHook optional

2023-01-12 Thread GitBox
amoghrajesh opened a new pull request, #28911: URL: https://github.com/apache/airflow/pull/28911 In tasks that perform multiple requests, the log file is getting cluttered by additional info logs in the http hook This PR adds a kwarg that controls this logs behaviour ---

[GitHub] [airflow] uranusjr commented on a diff in pull request #28764: Add support for running a Beam Go pipeline with an executable binary

2023-01-12 Thread GitBox
uranusjr commented on code in PR #28764: URL: https://github.com/apache/airflow/pull/28764#discussion_r1068967457 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -520,12 +524,26 @@ class BeamRunGoPipelineOperator(BeamBasePipelineOperator): For more detail on

[GitHub] [airflow] uranusjr commented on a diff in pull request #28764: Add support for running a Beam Go pipeline with an executable binary

2023-01-12 Thread GitBox
uranusjr commented on code in PR #28764: URL: https://github.com/apache/airflow/pull/28764#discussion_r1068967457 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -520,12 +524,26 @@ class BeamRunGoPipelineOperator(BeamBasePipelineOperator): For more detail on

[GitHub] [airflow] johannaojeling commented on a diff in pull request #28764: Add support for running a Beam Go pipeline with an executable binary

2023-01-12 Thread GitBox
johannaojeling commented on code in PR #28764: URL: https://github.com/apache/airflow/pull/28764#discussion_r1068951137 ## airflow/providers/apache/beam/operators/beam.py: ## @@ -563,8 +582,13 @@ def __init__( ) self.dataflow_support_impersonation = False

[airflow] branch main updated: Avoid circular import from S3HookUriParseFailure (#28908)

2023-01-12 Thread dstandish
This is an automated email from the ASF dual-hosted git repository. dstandish pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9a643363e9 Avoid circular import from

[GitHub] [airflow] dstandish merged pull request #28908: Avoid circular import from S3HookUriParseFailure

2023-01-12 Thread GitBox
dstandish merged PR #28908: URL: https://github.com/apache/airflow/pull/28908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] EricGao888 commented on issue #21953: Add support for Apache Zeppelin

2023-01-12 Thread GitBox
EricGao888 commented on issue #21953: URL: https://github.com/apache/airflow/issues/21953#issuecomment-1381279191 > Hi @EricGao888 do you intend to complete the PR? Sorry to reply late. Currently Apache Zeppelin hasn't released pyzeppelin yet. In my previous PR for airflow zeppelin

[GitHub] [airflow] boring-cyborg[bot] commented on issue #28910: Misnamed param in EcsRunTaskOperator

2023-01-12 Thread GitBox
boring-cyborg[bot] commented on issue #28910: URL: https://github.com/apache/airflow/issues/28910#issuecomment-1381187717 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] deanmorin opened a new issue, #28910: Misnamed param in EcsRunTaskOperator

2023-01-12 Thread GitBox
deanmorin opened a new issue, #28910: URL: https://github.com/apache/airflow/issues/28910 ### What do you see as an issue? In the `EcsRunTaskOperator`, one of the params in the docstring is `region_name`, but it should be `region`:

[GitHub] [airflow] vandonr-amz commented on pull request #28816: introduce a method to convert dictionaries to boto-style key-value lists

2023-01-12 Thread GitBox
vandonr-amz commented on PR #28816: URL: https://github.com/apache/airflow/pull/28816#issuecomment-1381159841 > * Can this be more-universal across the provider? There are likely other operators that have the same thing, ISTR there are some EC2 operators. I didn't find other

[GitHub] [airflow] o-nikolas opened a new pull request, #28909: Removal of flake8 file has broken breeze bind mounts

2023-01-12 Thread GitBox
o-nikolas opened a new pull request, #28909: URL: https://github.com/apache/airflow/pull/28909 Don't try mount .flake8 anymore, it has been removed in #28893 When running `breeze tests `, got the following: ``` ERROR: for airflow-test-all_airflow_run Cannot create container

[GitHub] [airflow] github-actions[bot] commented on pull request #27787: POC / WIP testing out using logfmt for more structured logging

2023-01-12 Thread GitBox
github-actions[bot] commented on PR #27787: URL: https://github.com/apache/airflow/pull/27787#issuecomment-1381134659 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[airflow] branch constraints-2-5 updated: Updating constraints. Build id:

2023-01-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-5 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-5 by this push: new 95e8c20cb3 Updating

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
jedcunningham commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068774299 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068772776 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] dstandish opened a new pull request, #28908: Avoid circular import from S3HookUriParseFailure

2023-01-12 Thread GitBox
dstandish opened a new pull request, #28908: URL: https://github.com/apache/airflow/pull/28908 Otherwise, webserver fails to start when s3 configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068772776 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068772776 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] jedcunningham commented on pull request #28902: Chart: Update default git-sync version to 3.6.2

2023-01-12 Thread GitBox
jedcunningham commented on PR #28902: URL: https://github.com/apache/airflow/pull/28902#issuecomment-1381104443 Cool! Can you add a newsfragement for this ([here is an example](https://github.com/apache/airflow/blob/main/chart/newsfragments/28074.significant.rst))? -- This is an

[airflow] branch main updated: [AIP-51] Fix calculate_env for non local executor (#28897)

2023-01-12 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4619e9e0ca [AIP-51] Fix calculate_env for

[GitHub] [airflow] pierrejeambrun merged pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
pierrejeambrun merged PR #28897: URL: https://github.com/apache/airflow/pull/28897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
jedcunningham commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r106876 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
jedcunningham commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068766395 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] jedcunningham commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
jedcunningham commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068765818 ## dev/breeze/src/airflow_breeze/commands/minor_release_command.py: ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-12 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 749ac6c2cd Updating

[GitHub] [airflow] hussein-awala opened a new pull request, #28907: add some statsd metrics for dataset

2023-01-12 Thread GitBox
hussein-awala opened a new pull request, #28907: URL: https://github.com/apache/airflow/pull/28907 closes: #28803 --- **^ Add meaningful description above** Read the **[Pull Request

[airflow] branch v2-5-test updated (449d6be50b -> ca3f70c063)

2023-01-12 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-5-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit 449d6be50b Add Changelog for 2.5.1 omit 333a4a89b8 Update Airflow version to 2.5.1 add

[GitHub] [airflow] dstandish commented on a diff in pull request #28899: Be more selective when adopting pods with KubernetesExecutor

2023-01-12 Thread GitBox
dstandish commented on code in PR #28899: URL: https://github.com/apache/airflow/pull/28899#discussion_r1068699650 ## airflow/executors/kubernetes_executor.py: ## @@ -772,7 +773,15 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[airflow] branch main updated (ce858a5d71 -> a1f23fea12)

2023-01-12 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ce858a5d71 Switch to ruff for faster static checks (#28893) add a1f23fea12 Fix pyzmq warning stopping provider

[GitHub] [airflow] ashb merged pull request #28901: Fix pyzmq warning stopping provider package tests

2023-01-12 Thread GitBox
ashb merged PR #28901: URL: https://github.com/apache/airflow/pull/28901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] jedcunningham commented on a diff in pull request #28899: Be more selective when adopting pods with KubernetesExecutor

2023-01-12 Thread GitBox
jedcunningham commented on code in PR #28899: URL: https://github.com/apache/airflow/pull/28899#discussion_r1068688986 ## airflow/executors/kubernetes_executor.py: ## @@ -772,7 +773,15 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #28902: Chart: Update default git-sync version to 3.6.2

2023-01-12 Thread GitBox
boring-cyborg[bot] commented on PR #28902: URL: https://github.com/apache/airflow/pull/28902#issuecomment-1381026368 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] aleveille opened a new pull request, #28902: Chart: Update default git-sync version to 3.6.2

2023-01-12 Thread GitBox
aleveille opened a new pull request, #28902: URL: https://github.com/apache/airflow/pull/28902 This is Helm/Kubernetes change only to update the git-sync container from v3.4.0 to v3.6.2. The v3.4.0 version is a bit old and has several security vulnerabilities. snyk

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068688836 ## .github/workflows/ci.yml: ## @@ -747,6 +747,41 @@ jobs: run: breeze ci fix-ownership if: always() + test-airflow-release-commands: Review

[GitHub] [airflow] ashb merged pull request #28893: Switch to ruff for faster static checks

2023-01-12 Thread GitBox
ashb merged PR #28893: URL: https://github.com/apache/airflow/pull/28893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068687794 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[airflow] branch main updated: Switch to ruff for faster static checks (#28893)

2023-01-12 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ce858a5d71 Switch to ruff for faster static checks

[GitHub] [airflow] ashb commented on pull request #28893: Switch to ruff for faster static checks

2023-01-12 Thread GitBox
ashb commented on PR #28893: URL: https://github.com/apache/airflow/pull/28893#issuecomment-1381023650 Everything but providers green. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068687097 ## dev/breeze/src/airflow_breeze/commands/release_command.py: ## @@ -0,0 +1,284 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068684138 ## dev/breeze/src/airflow_breeze/commands/release_candidate_command.py: ## @@ -0,0 +1,343 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068683888 ## dev/breeze/src/airflow_breeze/commands/minor_release_command.py: ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068683038 ## dev/breeze/src/airflow_breeze/commands/minor_release_command.py: ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] csm10495 commented on pull request #28808: Allow setting the name for the base container within K8s Pod Operator

2023-01-12 Thread GitBox
csm10495 commented on PR #28808: URL: https://github.com/apache/airflow/pull/28808#issuecomment-1381019209 @jedcunningham check again when you can. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068681488 ## dev/breeze/src/airflow_breeze/commands/minor_release_command.py: ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] potiuk commented on a diff in pull request #27829: Improving the release process

2023-01-12 Thread GitBox
potiuk commented on code in PR #27829: URL: https://github.com/apache/airflow/pull/27829#discussion_r1068681215 ## dev/breeze/src/airflow_breeze/commands/minor_release_command.py: ## @@ -0,0 +1,183 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068671686 ## airflow/utils/log/trigger_handler.py: ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068668177 ## airflow/jobs/triggerer_job.py: ## @@ -87,19 +241,29 @@ def on_kill(self): """ self.runner.stop = True +def _kill_listener(self): +

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068665627 ## airflow/utils/log/trigger_handler.py: ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] potiuk commented on issue #28884: Azure Blob storage exposes crendentials in UI

2023-01-12 Thread GitBox
potiuk commented on issue #28884: URL: https://github.com/apache/airflow/issues/28884#issuecomment-1381006821 Examples can be found how other hooks do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk commented on issue #28884: Azure Blob storage exposes crendentials in UI

2023-01-12 Thread GitBox
potiuk commented on issue #28884: URL: https://github.com/apache/airflow/issues/28884#issuecomment-1381006194 The fix for that would be to hide extra field, if someone would like to do it, that would be cool. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068664556 ## airflow/utils/log/trigger_handler.py: ## @@ -0,0 +1,134 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068663594 ## airflow/jobs/triggerer_job.py: ## @@ -245,11 +410,10 @@ async def arun(self): await self.cleanup_finished_triggers() # Sleep for a bit

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
o-nikolas commented on code in PR #28897: URL: https://github.com/apache/airflow/pull/28897#discussion_r1068657234 ## tests/cli/commands/test_standalone_command.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
pierrejeambrun commented on code in PR #28897: URL: https://github.com/apache/airflow/pull/28897#discussion_r1068656844 ## tests/cli/commands/test_standalone_command.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
pierrejeambrun commented on code in PR #28897: URL: https://github.com/apache/airflow/pull/28897#discussion_r1068653769 ## tests/cli/commands/test_standalone_command.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
pierrejeambrun commented on code in PR #28897: URL: https://github.com/apache/airflow/pull/28897#discussion_r1068653769 ## tests/cli/commands/test_standalone_command.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] o-nikolas commented on a diff in pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
o-nikolas commented on code in PR #28897: URL: https://github.com/apache/airflow/pull/28897#discussion_r1068648627 ## tests/cli/commands/test_standalone_command.py: ## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068646963 ## airflow/api_connexion/openapi/v1.yaml: ## @@ -1656,6 +1656,12 @@ paths: - $ref: '#/components/parameters/FullContent' - $ref:

[GitHub] [airflow] dstandish commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
dstandish commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1068645926 ## airflow/example_dags/example_time_delta_sensor_async.py: ## @@ -36,6 +36,6 @@ catchup=False, tags=["example"], ) as dag: -wait =

[airflow] branch v2-5-test updated (6aa136024b -> 449d6be50b)

2023-01-12 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch v2-5-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit 6aa136024b Add Changelog for 2.5.1 omit ee47f8b2d9 Update Airflow version to 2.5.1 add

[GitHub] [airflow] dstandish commented on a diff in pull request #28899: Be more selective when adopting pods with KubernetesExecutor

2023-01-12 Thread GitBox
dstandish commented on code in PR #28899: URL: https://github.com/apache/airflow/pull/28899#discussion_r1068642930 ## airflow/executors/kubernetes_executor.py: ## @@ -772,7 +773,15 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] dstandish commented on a diff in pull request #28899: Be more selective when adopting pods with KubernetesExecutor

2023-01-12 Thread GitBox
dstandish commented on code in PR #28899: URL: https://github.com/apache/airflow/pull/28899#discussion_r1068642016 ## airflow/executors/kubernetes_executor.py: ## @@ -772,7 +773,15 @@ def try_adopt_task_instances(self, tis: Sequence[TaskInstance]) -> Sequence[Task

[GitHub] [airflow] ashb commented on a diff in pull request #27758: Enable trigger logging in webserver

2023-01-12 Thread GitBox
ashb commented on code in PR #27758: URL: https://github.com/apache/airflow/pull/27758#discussion_r1067960711 ## airflow/api_connexion/openapi/v1.yaml: ## @@ -1656,6 +1656,12 @@ paths: - $ref: '#/components/parameters/FullContent' - $ref:

[GitHub] [airflow] dstandish commented on pull request #28881: No multiline log entry for bash env vars

2023-01-12 Thread GitBox
dstandish commented on PR #28881: URL: https://github.com/apache/airflow/pull/28881#issuecomment-1380976421 i think repr is better because it will stay on one line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] dstandish commented on a diff in pull request #28871: KubenetesExecutor sends state even when successful

2023-01-12 Thread GitBox
dstandish commented on code in PR #28871: URL: https://github.com/apache/airflow/pull/28871#discussion_r1068629030 ## airflow/executors/kubernetes_executor.py: ## @@ -763,13 +763,14 @@ def _change_state(self, key: TaskInstanceKey, state: str | None, pod_id: str, na

[GitHub] [airflow] dstandish commented on a diff in pull request #28871: KubenetesExecutor sends state even when successful

2023-01-12 Thread GitBox
dstandish commented on code in PR #28871: URL: https://github.com/apache/airflow/pull/28871#discussion_r1068636272 ## airflow/executors/kubernetes_executor.py: ## @@ -763,13 +763,14 @@ def _change_state(self, key: TaskInstanceKey, state: str | None, pod_id: str, na

[GitHub] [airflow] pierrejeambrun commented on pull request #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
pierrejeambrun commented on PR #28897: URL: https://github.com/apache/airflow/pull/28897#issuecomment-1380974459 cc: @o-nikolas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated (141338b24e -> 14783c63c5)

2023-01-12 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 141338b24e Use entire tenant domain name in dbt Cloud connection (#28890) add 14783c63c5 Skip pushing early

[GitHub] [airflow] potiuk merged pull request #28895: Skip pushing early image cache for non-main branches

2023-01-12 Thread GitBox
potiuk merged PR #28895: URL: https://github.com/apache/airflow/pull/28895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] ashb commented on pull request #28893: Switch to ruff for faster static checks

2023-01-12 Thread GitBox
ashb commented on PR #28893: URL: https://github.com/apache/airflow/pull/28893#issuecomment-1380972692 https://github.com/apache/airflow/pull/28901 to fix the provider tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [airflow] vincbeck commented on pull request #28900: [WIP] Convert DagFileProcessor.execute_callbacks to Internal API

2023-01-12 Thread GitBox
vincbeck commented on PR #28900: URL: https://github.com/apache/airflow/pull/28900#issuecomment-1380970882 @mhenc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] vincbeck opened a new pull request, #28900: [WIP] Convert DagFileProcessor.execute_callbacks to Internal API

2023-01-12 Thread GitBox
vincbeck opened a new pull request, #28900: URL: https://github.com/apache/airflow/pull/28900 Closes #28269 Since this issue is massive and will some need some help from the community, I rather create a draft PR to see where I am going and get some early feedbacks from you guys :).

[GitHub] [airflow] dstandish commented on a diff in pull request #28871: KubenetesExecutor sends state even when successful

2023-01-12 Thread GitBox
dstandish commented on code in PR #28871: URL: https://github.com/apache/airflow/pull/28871#discussion_r1068629030 ## airflow/executors/kubernetes_executor.py: ## @@ -763,13 +763,14 @@ def _change_state(self, key: TaskInstanceKey, state: str | None, pod_id: str, na

[GitHub] [airflow] aprettyloner commented on issue #28751: KubernetesExecutor leaves failed pods due to deepcopy issue with Google providers

2023-01-12 Thread GitBox
aprettyloner commented on issue #28751: URL: https://github.com/apache/airflow/issues/28751#issuecomment-1380965609 @uranusjr Also experiencing this with `BigQueryExecuteQueryOperator`. Interestingly, the task pod fails but then ### Environment Airflow 2.4.3 Python 3.8.15

[GitHub] [airflow] josh-fell commented on pull request #28889: Add `on_kill()` to `DataprocInstantiateInlineWorkflowTemplateOperator`

2023-01-12 Thread GitBox
josh-fell commented on PR #28889: URL: https://github.com/apache/airflow/pull/28889#issuecomment-1380958124 > Need some help in adding test cases here. Take a look at some of the [existing provider tests](https://github.com/apache/airflow/tree/main/tests/providers) that call

[GitHub] [airflow] josh-fell commented on a diff in pull request #28889: Add `on_kill()` to `DataprocInstantiateInlineWorkflowTemplateOperator`

2023-01-12 Thread GitBox
josh-fell commented on code in PR #28889: URL: https://github.com/apache/airflow/pull/28889#discussion_r1068607878 ## airflow/providers/google/cloud/operators/dataproc.py: ## @@ -1779,6 +1779,10 @@ def execute(self, context: Context): self.log.info("Template

[GitHub] [airflow] jedcunningham opened a new pull request, #28899: Be more selective when adopting pods with KubernetesExecutor

2023-01-12 Thread GitBox
jedcunningham opened a new pull request, #28899: URL: https://github.com/apache/airflow/pull/28899 When trying to adopt "resettable" TIs from SchedulerJob, we should not list out all the pods to compare against, only those that didn't succeed. This means we will get any pods that are still

[GitHub] [airflow] portoedu opened a new issue, #28898: A way to set an environment variable as a sensible config

2023-01-12 Thread GitBox
portoedu opened a new issue, #28898: URL: https://github.com/apache/airflow/issues/28898 ### Description A way to set an environment variable as a sensible config so that airflow hides it in the configuration page. ### Use case/motivation For security measures, we set

[GitHub] [airflow] boring-cyborg[bot] commented on issue #28898: A way to set an environment variable as a sensible config

2023-01-12 Thread GitBox
boring-cyborg[bot] commented on issue #28898: URL: https://github.com/apache/airflow/issues/28898#issuecomment-1380942874 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] pierrejeambrun commented on issue #27929: AIP-51 - Single Threaded Executors

2023-01-12 Thread GitBox
pierrejeambrun commented on issue #27929: URL: https://github.com/apache/airflow/issues/27929#issuecomment-1380939634 https://github.com/apache/airflow/pull/28897 At the moment it looks like this piece of code does not have tests. I'll see if we can add some :) -- This is

[GitHub] [airflow] pierrejeambrun opened a new pull request, #28897: [AIP-51] Fix calculate_env for non local executor

2023-01-12 Thread GitBox
pierrejeambrun opened a new pull request, #28897: URL: https://github.com/apache/airflow/pull/28897 https://github.com/apache/airflow/pull/27941 introduced a mistake in the `calculate_env` function. This fixes it. -- This is an automated message from the Apache Git Service. To

  1   2   3   >