[GitHub] [airflow] argibbs commented on pull request #25516: Optimize scheduler processing query

2023-02-22 Thread via GitHub
argibbs commented on PR #25516: URL: https://github.com/apache/airflow/pull/25516#issuecomment-1441311891 @dene14 Can I ask what happened here? Did you realise the changed query wasn't equivalent? Or is there something else going on? -- This is an automated message from the Apache Git

[airflow] branch main updated: Fix leak sensitive field via V1EnvVar on exception (#29016)

2023-02-22 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 78115c5ca9 Fix leak sensitive field via V1EnvVar

[GitHub] [airflow] uranusjr merged pull request #29016: Fix leak sensitive field via V1EnvVar on exception

2023-02-22 Thread via GitHub
uranusjr merged PR #29016: URL: https://github.com/apache/airflow/pull/29016 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] uranusjr commented on pull request #29704: Correct version label for data interval variables in documentation

2023-02-22 Thread via GitHub
uranusjr commented on PR #29704: URL: https://github.com/apache/airflow/pull/29704#issuecomment-1441295827 Can you check other variables below? I suspect `prev_data_interval_start_success` and `prev_data_interval_end_success` are also available. -- This is an automated message from the

[airflow] branch main updated (f99d27e5bd -> 946bded31a)

2023-02-22 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f99d27e5bd Fix contributors quick start test example (#29713) add 946bded31a Revert "Quarantine

[GitHub] [airflow] uranusjr closed issue #29679: Fix Quarantined `test_cli_internal_api_background`

2023-02-22 Thread via GitHub
uranusjr closed issue #29679: Fix Quarantined `test_cli_internal_api_background` URL: https://github.com/apache/airflow/issues/29679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] uranusjr merged pull request #29688: Revert "Quarantine `test_cli_internal_api_background`"

2023-02-22 Thread via GitHub
uranusjr merged PR #29688: URL: https://github.com/apache/airflow/pull/29688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] phanikumv commented on a diff in pull request #29695: Add `DbtCloudJobRunAsyncSensor`

2023-02-22 Thread via GitHub
phanikumv commented on code in PR #29695: URL: https://github.com/apache/airflow/pull/29695#discussion_r1115301175 ## airflow/providers/dbt/cloud/sensors/dbt.py: ## @@ -64,3 +72,56 @@ def poke(self, context: Context) -> bool: raise DbtCloudJobRunException(f"Job run

[GitHub] [airflow] phanikumv commented on a diff in pull request #29695: Add `DbtCloudJobRunAsyncSensor`

2023-02-22 Thread via GitHub
phanikumv commented on code in PR #29695: URL: https://github.com/apache/airflow/pull/29695#discussion_r1115300047 ## airflow/providers/dbt/cloud/sensors/dbt.py: ## @@ -64,3 +72,56 @@ def poke(self, context: Context) -> bool: raise DbtCloudJobRunException(f"Job run

[GitHub] [airflow] phanikumv commented on a diff in pull request #29695: Add `DbtCloudJobRunAsyncSensor`

2023-02-22 Thread via GitHub
phanikumv commented on code in PR #29695: URL: https://github.com/apache/airflow/pull/29695#discussion_r1115299464 ## airflow/providers/dbt/cloud/sensors/dbt.py: ## @@ -64,3 +72,56 @@ def poke(self, context: Context) -> bool: raise DbtCloudJobRunException(f"Job run

[GitHub] [airflow] phanikumv commented on a diff in pull request #29695: Add `DbtCloudJobRunAsyncSensor`

2023-02-22 Thread via GitHub
phanikumv commented on code in PR #29695: URL: https://github.com/apache/airflow/pull/29695#discussion_r1115297396 ## airflow/providers/dbt/cloud/sensors/dbt.py: ## @@ -64,3 +72,56 @@ def poke(self, context: Context) -> bool: raise DbtCloudJobRunException(f"Job run

[GitHub] [airflow] github-actions[bot] commented on issue #19015: Remote logging using GCP connection from connection table broken

2023-02-22 Thread via GitHub
github-actions[bot] commented on issue #19015: URL: https://github.com/apache/airflow/issues/19015#issuecomment-1441288400 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last

[GitHub] [airflow] github-actions[bot] commented on issue #19082: Dag with Schedule: None that is always triggered from TriggerDagRunOperator ignores Runs setting in UI

2023-02-22 Thread via GitHub
github-actions[bot] commented on issue #19082: URL: https://github.com/apache/airflow/issues/19082#issuecomment-1441288369 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last

[GitHub] [airflow] uranusjr commented on a diff in pull request #29711: fix update_mask in patch variable route

2023-02-22 Thread via GitHub
uranusjr commented on code in PR #29711: URL: https://github.com/apache/airflow/pull/29711#discussion_r1115284506 ## airflow/api_connexion/endpoints/variable_endpoint.py: ## @@ -103,15 +109,22 @@ def patch_variable(*, variable_key: str, update_mask: UpdateMask = None) -> Resp

[airflow] branch constraints-main updated: Updating constraints. Github run id:4249610569

2023-02-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 69ad0700ca Updating

[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-22 Thread via GitHub
uranusjr commented on PR #29608: URL: https://github.com/apache/airflow/pull/29608#issuecomment-1441235817 By the way, the argument name can probably be shortened to just `--xcom` or `--xcoms`? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] uranusjr commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-22 Thread via GitHub
uranusjr commented on PR #29608: URL: https://github.com/apache/airflow/pull/29608#issuecomment-1441235340 Allowing a path makes sense to me. Since a JSON string has a pretty distinctive shape (starts and ends with either brackets or braces depending on which format we decide to use), I

[GitHub] [airflow] uranusjr commented on pull request #29714: Add database check_migrations config

2023-02-22 Thread via GitHub
uranusjr commented on PR #29714: URL: https://github.com/apache/airflow/pull/29714#issuecomment-1441231442 I have wondered if we should have three values for this. `true` (default) migrates the database automatically, `check` only checks if the database is up-to-date, and `false` does

[GitHub] [airflow] uranusjr commented on a diff in pull request #29714: Add database check_migrations config

2023-02-22 Thread via GitHub
uranusjr commented on code in PR #29714: URL: https://github.com/apache/airflow/pull/29714#discussion_r1115249955 ## tests/cli/commands/test_scheduler_command.py: ## @@ -73,6 +73,23 @@ def test_skip_serve_logs(self, mock_process, mock_scheduler_job, executor):

[airflow] branch main updated (644cea14ff -> f99d27e5bd)

2023-02-22 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 644cea14ff Updated Telegram Provider to ensure compatbility with >=20.0.0 (#28953) add f99d27e5bd Fix

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29713: Fix contributors quick start test example

2023-02-22 Thread via GitHub
boring-cyborg[bot] commented on PR #29713: URL: https://github.com/apache/airflow/pull/29713#issuecomment-1441224315 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] uranusjr merged pull request #29713: Fix contributors quick start test example

2023-02-22 Thread via GitHub
uranusjr merged PR #29713: URL: https://github.com/apache/airflow/pull/29713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Updated Telegram Provider to ensure compatbility with >=20.0.0 (#28953)

2023-02-22 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 644cea14ff Updated Telegram Provider to ensure

[GitHub] [airflow] eladkal closed issue #28670: Support telegram-bot v20+

2023-02-22 Thread via GitHub
eladkal closed issue #28670: Support telegram-bot v20+ URL: https://github.com/apache/airflow/issues/28670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] eladkal merged pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-22 Thread via GitHub
eladkal merged PR #28953: URL: https://github.com/apache/airflow/pull/28953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Make cncf.kubernetes required for flink provider (#29710)

2023-02-22 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 68412e1664 Make cncf.kubernetes required for

[GitHub] [airflow] eladkal merged pull request #29710: Make cncf.kubernetes required for flink provider

2023-02-22 Thread via GitHub
eladkal merged PR #29710: URL: https://github.com/apache/airflow/pull/29710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch constraints-main updated: Updating constraints. Github run id:4248713067

2023-02-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new d1a34237f9 Updating

[GitHub] [airflow] tatiana commented on a diff in pull request #29714: Add database check_migrations config

2023-02-22 Thread via GitHub
tatiana commented on code in PR #29714: URL: https://github.com/apache/airflow/pull/29714#discussion_r1115193904 ## tests/cli/commands/test_scheduler_command.py: ## @@ -73,6 +73,23 @@ def test_skip_serve_logs(self, mock_process, mock_scheduler_job, executor):

[GitHub] [airflow] tatiana opened a new pull request, #29714: Add database check_migrations config

2023-02-22 Thread via GitHub
tatiana opened a new pull request, #29714: URL: https://github.com/apache/airflow/pull/29714 To enable/disable run alembic migrations during Airflow start-up. Sometimes this operation can be expensive, and the deployment can assert that the Airflow metadata database is up-to-date.

[airflow] branch main updated: Propose to upgrade to newer dependencies in case build CI image fail (#29705)

2023-02-22 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f03885421e Propose to upgrade to newer

[GitHub] [airflow] eladkal merged pull request #29705: Propose to upgrade to newer dependencies in case build CI image fail

2023-02-22 Thread via GitHub
eladkal merged PR #29705: URL: https://github.com/apache/airflow/pull/29705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] tatiana opened a new pull request, #29713: Fix contributors quick start test example

2023-02-22 Thread via GitHub
tatiana opened a new pull request, #29713: URL: https://github.com/apache/airflow/pull/29713 The file `tests/utils/test_decorators.py` no longer exists. Replace it with another existing test file (`tests/utils/test_dates.py`). -- This is an automated message from the Apache Git

[GitHub] [airflow] maxnathaniel commented on issue #22408: Streamline trigger dag UX

2023-02-22 Thread via GitHub
maxnathaniel commented on issue #22408: URL: https://github.com/apache/airflow/issues/22408#issuecomment-1441084053 @bbovenzi apologies, have been busy with work. Will continue where I had left off with this task this week and aim to push out something by end of week. -- This is an

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29712: EMRHook.get_cluster_id_by_name() doesn't use pagination

2023-02-22 Thread via GitHub
boring-cyborg[bot] commented on issue #29712: URL: https://github.com/apache/airflow/issues/29712#issuecomment-1441070983 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] thirtyseven opened a new issue, #29712: EMRHook.get_cluster_id_by_name() doesn't use pagination

2023-02-22 Thread via GitHub
thirtyseven opened a new issue, #29712: URL: https://github.com/apache/airflow/issues/29712 ### Apache Airflow version 2.5.1 ### What happened When using EMRHook.get_cluster_id_by_name or any any operator that depends on it (e.g. EMRAddStepsOperator), if the results of

[GitHub] [airflow] xinbinhuang commented on pull request #29710: Make cncf.kubernetes required for flink provider

2023-02-22 Thread via GitHub
xinbinhuang commented on PR #29710: URL: https://github.com/apache/airflow/pull/29710#issuecomment-1441063136 > Actually @xinbinhuang - this one is "proper" as it turned out after discussion in [#29691 (reply in

[GitHub] [airflow] dimberman commented on pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-22 Thread via GitHub
dimberman commented on PR #29608: URL: https://github.com/apache/airflow/pull/29608#issuecomment-1441061234 Hi @vemikhaylov thank you for setting up this PR. This is a pretty important missing piece of the local dev story. It would make sense also to offer the option to pass in a

[airflow] branch main updated (9aa873ad69 -> fa620566f1)

2023-02-22 Thread dimberman
This is an automated email from the ASF dual-hosted git repository. dimberman pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 9aa873ad69 Add more precise optional dependency to cncf.kubernetes from flink (#29707) add fa620566f1 Reuse

[GitHub] [airflow] dimberman merged pull request #29692: Reuse mock import from util module

2023-02-22 Thread via GitHub
dimberman merged PR #29692: URL: https://github.com/apache/airflow/pull/29692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] josh-fell commented on a diff in pull request #29695: Add `DbtCloudJobRunAsyncSensor`

2023-02-22 Thread via GitHub
josh-fell commented on code in PR #29695: URL: https://github.com/apache/airflow/pull/29695#discussion_r1114587026 ## airflow/providers/dbt/cloud/sensors/dbt.py: ## @@ -64,3 +72,56 @@ def poke(self, context: Context) -> bool: raise DbtCloudJobRunException(f"Job run

[GitHub] [airflow] dimberman commented on pull request #29706: Remove Run task action from UI

2023-02-22 Thread via GitHub
dimberman commented on PR #29706: URL: https://github.com/apache/airflow/pull/29706#issuecomment-1441049590 @kaxil what would be the benefit of keeping it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] dimberman commented on a diff in pull request #29695: Add `DbtCloudJobRunAsyncSensor`

2023-02-22 Thread via GitHub
dimberman commented on code in PR #29695: URL: https://github.com/apache/airflow/pull/29695#discussion_r1115132610 ## airflow/providers/dbt/cloud/sensors/dbt.py: ## @@ -64,3 +72,56 @@ def poke(self, context: Context) -> bool: raise DbtCloudJobRunException(f"Job run

[GitHub] [airflow] hussein-awala commented on issue #29696: expected to get frame set in local storage but it was not

2023-02-22 Thread via GitHub
hussein-awala commented on issue #29696: URL: https://github.com/apache/airflow/issues/29696#issuecomment-1441040337 This issue duplicates #23740. Based on @potiuk [answer](https://github.com/apache/airflow/issues/23740#issuecomment-1128462269), the warning was a bug and it was

[GitHub] [airflow] github-actions[bot] commented on issue #27657: Zombie tasks detected after service restart sometimes do not retry

2023-02-22 Thread via GitHub
github-actions[bot] commented on issue #27657: URL: https://github.com/apache/airflow/issues/27657#issuecomment-1441031486 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] commented on issue #28399: Dataproc Generator should allow creating spot instances

2023-02-22 Thread via GitHub
github-actions[bot] commented on issue #28399: URL: https://github.com/apache/airflow/issues/28399#issuecomment-1441031459 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] maxnathaniel commented on pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-22 Thread via GitHub
maxnathaniel commented on PR #28953: URL: https://github.com/apache/airflow/pull/28953#issuecomment-1441023946 @eladkal thanks for pushing the fix for the static checks issue. Been trying to troubleshoot the precommit cmd on both my local machine and on devpod for the past day. -- This

[GitHub] [airflow] maxnathaniel commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-22 Thread via GitHub
maxnathaniel commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1115118926 ## airflow/providers/telegram/provider.yaml: ## @@ -39,7 +40,7 @@ dependencies: # The telegram bot 20.0.0 is not yet compatible with our provider as

[GitHub] [airflow] hussein-awala opened a new pull request, #29711: fix update_mask in patch variable route

2023-02-22 Thread via GitHub
hussein-awala opened a new pull request, #29711: URL: https://github.com/apache/airflow/pull/29711 closes: #29702 --- `patch_variable` route does not allow updating the variable description. This PR updates the method and uses the same pattern used in the other routes to

[GitHub] [airflow] IKholopov commented on pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator

2023-02-22 Thread via GitHub
IKholopov commented on PR #29680: URL: https://github.com/apache/airflow/pull/29680#issuecomment-1440995701 > (best is to squash the commits and rebase on top of the main and add good description). I've added a detailed description to the commit, let me know if you meant any other

[GitHub] [airflow] Taragolis commented on pull request #29522: Add support in AWS Batch Operator for multinode jobs

2023-02-22 Thread via GitHub
Taragolis commented on PR #29522: URL: https://github.com/apache/airflow/pull/29522#issuecomment-1440984836 Sorry, not yet. Hectic days. I will try tomorrow morning. I we also have a question about log links, but let me check it first. -- This is an automated message from the

[GitHub] [airflow] potiuk commented on pull request #29710: Make cncf.kubernetes required for flink provider

2023-02-22 Thread via GitHub
potiuk commented on PR #29710: URL: https://github.com/apache/airflow/pull/29710#issuecomment-1440975390 Actually @xinbinhuang - this one is "proper" as it turned out after discussion in https://github.com/apache/airflow/discussions/29691#discussioncomment-5082365 -- This is an

[GitHub] [airflow] potiuk opened a new pull request, #29710: Make cncf.kubernetes required for flink provider

2023-02-22 Thread via GitHub
potiuk opened a new pull request, #29710: URL: https://github.com/apache/airflow/pull/29710 The #29707 added version to optional cncf.kubernetes dependency, but in fact the kubernetes provider is a required dependency so we need to change it to be so. --- **^ Add

[GitHub] [airflow] vemikhaylov opened a new pull request, #29709: Replace blockquote + Note: with RST note in docs

2023-02-22 Thread via GitHub
vemikhaylov opened a new pull request, #29709: URL: https://github.com/apache/airflow/pull/29709 As a follow to #29678 replacing other places containing a blockquote `::` + explicit "Note" in text with the RST `.. note::` for the better styling and consistency. In the case of the TaskFlow

[GitHub] [airflow] bugraoz93 commented on issue #29312: AIP-44 Migrate TaskInstance._run_raw_task to Internal API

2023-02-22 Thread via GitHub
bugraoz93 commented on issue #29312: URL: https://github.com/apache/airflow/issues/29312#issuecomment-1440955706 I would like to work on this after #29311. Of course, if there is no one who is already a volunteer. -- This is an automated message from the Apache Git Service. To respond to

[airflow] branch main updated (8449180f48 -> 9aa873ad69)

2023-02-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 8449180f48 Move extra links position in grid view (#29703) add 9aa873ad69 Add more precise optional dependency to

[GitHub] [airflow] potiuk merged pull request #29707: Add more precise optional dependency to cncf.kubernetes from flink

2023-02-22 Thread via GitHub
potiuk merged PR #29707: URL: https://github.com/apache/airflow/pull/29707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] steren commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
steren commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1115064629 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] steren commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
steren commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1114938265 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] potiuk commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
potiuk commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1115061103 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] potiuk commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
potiuk commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1115058589 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] potiuk commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
potiuk commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1115058589 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] pgagnon commented on a diff in pull request #29708: Avoid including fallback message for S3TaskHandler if streaming logs

2023-02-22 Thread via GitHub
pgagnon commented on code in PR #29708: URL: https://github.com/apache/airflow/pull/29708#discussion_r1115052220 ## airflow/providers/amazon/aws/log/s3_task_handler.py: ## @@ -128,8 +128,12 @@ def _read(self, ti, try_number, metadata=None): if logs: return

[GitHub] [airflow] bugraoz93 commented on pull request #29682: Migrate BaseJob.heartbeat to InternalAPI

2023-02-22 Thread via GitHub
bugraoz93 commented on PR #29682: URL: https://github.com/apache/airflow/pull/29682#issuecomment-1440893832 Thanks for the hint! Sure, when it is shaped, we can close it if necessary or I can do the necessary changes such as making the method compatible with the Internal API call or other

[GitHub] [airflow] dstandish commented on a diff in pull request #29708: Avoid including fallback message for S3TaskHandler if streaming logs

2023-02-22 Thread via GitHub
dstandish commented on code in PR #29708: URL: https://github.com/apache/airflow/pull/29708#discussion_r1115028212 ## airflow/providers/amazon/aws/log/s3_task_handler.py: ## @@ -128,8 +128,12 @@ def _read(self, ti, try_number, metadata=None): if logs:

[GitHub] [airflow] bugraoz93 commented on pull request #29688: Revert "Quarantine `test_cli_internal_api_background`"

2023-02-22 Thread via GitHub
bugraoz93 commented on PR #29688: URL: https://github.com/apache/airflow/pull/29688#issuecomment-1440880601 Good finding! It seems like #29681 fixed the following error. [Tests / Quarantined tests -

[GitHub] [airflow] vandonr-amz commented on pull request #29522: Add support in AWS Batch Operator for multinode jobs

2023-02-22 Thread via GitHub
vandonr-amz commented on PR #29522: URL: https://github.com/apache/airflow/pull/29522#issuecomment-1440877048 did you have time to check the options ? If we want to do it, I think that rewriting the whole batch hook and operator(s) should probably separated from that PR, which is just

[GitHub] [airflow] pdebelak opened a new pull request, #29708: Avoid including fallback message for S3TaskHandler if streaming logs

2023-02-22 Thread via GitHub
pdebelak opened a new pull request, #29708: URL: https://github.com/apache/airflow/pull/29708 This checks the metadata for the log_pos and if it is present and greater than 1 it doesn't include the "Falling back to local log" message. closes: #29393 --- **^ Add

[GitHub] [airflow] AlexG1105 commented on issue #16163: Confusing log for long running tasks: "dependency 'Task Instance Not Running' FAILED: Task is in the running state"

2023-02-22 Thread via GitHub
AlexG1105 commented on issue #16163: URL: https://github.com/apache/airflow/issues/16163#issuecomment-1440865079 > Hello, we are on Version: 2.2.5+composer and we have the same problem but in our case the task is really stopped and retried by our policy. So the message is not harmless as

[GitHub] [airflow] vemikhaylov commented on pull request #29678: FIx formatting of Dataset inlet/outlet note in TaskFlow concepts

2023-02-22 Thread via GitHub
vemikhaylov commented on PR #29678: URL: https://github.com/apache/airflow/pull/29678#issuecomment-1440862879 > it looked like the rST had a directive started but never finished (i.e. just a hanging `..`); I'm definitely not an RST expert, but I think just a single "::" quotes the

[airflow] branch constraints-main updated: Updating constraints. Github run id:4246727798

2023-02-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e991a18979 Updating

[airflow] branch revert-29408-docker-compose-change-example updated (ab54df3039 -> b50445be06)

2023-02-22 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch revert-29408-docker-compose-change-example in repository https://gitbox.apache.org/repos/asf/airflow.git discard ab54df3039 Revert "Improve health checks in example docker-compose and

[GitHub] [airflow] potiuk opened a new pull request, #29707: Add more precise optional dependency to cncf.kubernetes from flink

2023-02-22 Thread via GitHub
potiuk opened a new pull request, #29707: URL: https://github.com/apache/airflow/pull/29707 The Flink provider has an optional cncf.kubernetes depedency that requires cncf.kubernetes at least in version 5.1.0 (some new features of the classes in cncf.kubernetes are used in Flink on

[GitHub] [airflow] dstandish commented on pull request #22253: Add SparkKubernetesOperator crd implementation

2023-02-22 Thread via GitHub
dstandish commented on PR #22253: URL: https://github.com/apache/airflow/pull/22253#issuecomment-1440795999 > any chance you could do a final review and merge this, it took too long You are right, it's too long, I apologize. This happens to be an extremely difficult week for me but

[GitHub] [airflow] bbovenzi opened a new pull request, #29706: Remove Run task action from UI

2023-02-22 Thread via GitHub
bbovenzi opened a new pull request, #29706: URL: https://github.com/apache/airflow/pull/29706 `Airflow.run` is broken. It tries to start an executor. From the UI, users should use Clear instead. This PR removes the Run buttons from the UI (we will only show clear or mark failure/success):

[GitHub] [airflow] dstandish commented on issue #29393: S3TaskHandler continuously returns "*** Falling back to local log" even if log_pos is provided when log not in s3

2023-02-22 Thread via GitHub
dstandish commented on issue #29393: URL: https://github.com/apache/airflow/issues/29393#issuecomment-1440788093 @pdebelak sounds good in any case, your comment seems reasonable: > I'd expect the falling back message only to be included in calls with no log_pos in the metadata

[GitHub] [airflow] pdebelak commented on issue #29393: S3TaskHandler continuously returns "*** Falling back to local log" even if log_pos is provided when log not in s3

2023-02-22 Thread via GitHub
pdebelak commented on issue #29393: URL: https://github.com/apache/airflow/issues/29393#issuecomment-1440784148 @dstandish > Is there some reason y'all prefer the legacy logs view? I did not know there was a different place to see logs. I see now what you are talking about.

[GitHub] [airflow] dstandish commented on issue #29393: S3TaskHandler continuously returns "*** Falling back to local log" even if log_pos is provided when log not in s3

2023-02-22 Thread via GitHub
dstandish commented on issue #29393: URL: https://github.com/apache/airflow/issues/29393#issuecomment-1440780450 Hi y'all, thanks for the issue reports :) I did not spend nearly as much time live testing the legacy logs view as I did with the grid logs view. Is there some reason

[GitHub] [airflow] steren commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
steren commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1114938265 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[airflow] branch main updated (d4af0cac02 -> 8449180f48)

2023-02-22 Thread bbovenzi
This is an automated email from the ASF dual-hosted git repository. bbovenzi pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from d4af0cac02 Handle `github_method_args` in GithubOperator when not provided (#29699) add 8449180f48 Move extra

[GitHub] [airflow] bbovenzi merged pull request #29703: Move extra links position in grid view

2023-02-22 Thread via GitHub
bbovenzi merged PR #29703: URL: https://github.com/apache/airflow/pull/29703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on a diff in pull request #28525: Add CloudRunExecuteJobOperator

2023-02-22 Thread via GitHub
potiuk commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1114919470 ## airflow/providers/google/cloud/hooks/cloud_run.py: ## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[airflow] branch main updated: Handle `github_method_args` in GithubOperator when not provided (#29699)

2023-02-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d4af0cac02 Handle `github_method_args` in

[GitHub] [airflow] potiuk merged pull request #29699: Handle `github_method_args` in GithubOperator when not provided

2023-02-22 Thread via GitHub
potiuk merged PR #29699: URL: https://github.com/apache/airflow/pull/29699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated (ba2d562cfb -> 8b178f185a)

2023-02-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from ba2d562cfb Add `wait_for_completion` param in `RedshiftCreateClusterOperator` (#29657) add 8b178f185a Clarify

[GitHub] [airflow] potiuk merged pull request #29627: Clarify `service_config` in AWS Connection

2023-02-22 Thread via GitHub
potiuk merged PR #29627: URL: https://github.com/apache/airflow/pull/29627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Add `wait_for_completion` param in `RedshiftCreateClusterOperator` (#29657)

2023-02-22 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ba2d562cfb Add `wait_for_completion` param in

[GitHub] [airflow] potiuk merged pull request #29657: Add `wait_for_completion` param in `RedshiftCreateClusterOperator`

2023-02-22 Thread via GitHub
potiuk merged PR #29657: URL: https://github.com/apache/airflow/pull/29657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29245: fix code checking job names in sagemaker

2023-02-22 Thread via GitHub
vandonr-amz commented on code in PR #29245: URL: https://github.com/apache/airflow/pull/29245#discussion_r1114902167 ## airflow/providers/amazon/aws/operators/sagemaker.py: ## @@ -106,6 +108,41 @@ def _create_integer_fields(self) -> None: """

[GitHub] [airflow] vandonr-amz commented on a diff in pull request #29705: Propose to upgrade to newer dependencies in case build CI image fail

2023-02-22 Thread via GitHub
vandonr-amz commented on code in PR #29705: URL: https://github.com/apache/airflow/pull/29705#discussion_r1114893673 ## dev/breeze/src/airflow_breeze/commands/ci_image_commands.py: ## @@ -504,24 +504,29 @@ def run_build_ci_image( check=False,

[GitHub] [airflow] potiuk opened a new pull request, #29705: Propose to upgrade to newer dependencies in case build CI image fail

2023-02-22 Thread via GitHub
potiuk opened a new pull request, #29705: URL: https://github.com/apache/airflow/pull/29705 When build image fails it might be because there might be conflicts with current constraints. In case this happens we propose to add `--upgrade-to-newer-dependencies` flag. --- **^

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29704: Correct date for data interval variables

2023-02-22 Thread via GitHub
boring-cyborg[bot] commented on PR #29704: URL: https://github.com/apache/airflow/pull/29704#issuecomment-1440713584 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[GitHub] [airflow] EricPickup opened a new pull request, #29704: Correct date for data interval variables

2023-02-22 Thread via GitHub
EricPickup opened a new pull request, #29704: URL: https://github.com/apache/airflow/pull/29704 The documentation suggests that the `data_interval_start` and `data_interval_end` context variables were added in version `2.3`, however they were added as part of `2.2`. Gave me a scare when I

[GitHub] [airflow] bbovenzi opened a new pull request, #29703: Move extra links position in grid view

2023-02-22 Thread via GitHub
bbovenzi opened a new pull request, #29703: URL: https://github.com/apache/airflow/pull/29703 Before, we were rendering extra links below all of the task instance details in the grid view. It was easy to forget about them. Instead, they should be more visible and above the table of task

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29702: Updating Variables Description via PATCH in Airflow API is Clearing the existing description field of the variable and unable to update

2023-02-22 Thread via GitHub
boring-cyborg[bot] commented on issue #29702: URL: https://github.com/apache/airflow/issues/29702#issuecomment-1440670081 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] PannagaMayya opened a new issue, #29702: Updating Variables Description via PATCH in Airflow API is Clearing the existing description field of the variable and unable to update desc

2023-02-22 Thread via GitHub
PannagaMayya opened a new issue, #29702: URL: https://github.com/apache/airflow/issues/29702 ### Apache Airflow version 2.5.1 ### What happened When i made these patch requests to update description of the variable via axios ### 1) Trying to modify new value and

[GitHub] [airflow] josh-fell commented on a diff in pull request #29548: Add `EC2CreateInstanceOperator`, `EC2TerminateInstanceOperator`

2023-02-22 Thread via GitHub
josh-fell commented on code in PR #29548: URL: https://github.com/apache/airflow/pull/29548#discussion_r1113095186 ## airflow/providers/amazon/aws/operators/ec2.py: ## @@ -116,3 +116,141 @@ def execute(self, context: Context): target_state="stopped",

[GitHub] [airflow] bbovenzi commented on a diff in pull request #29413: Add a new graph inside of the grid view

2023-02-22 Thread via GitHub
bbovenzi commented on code in PR #29413: URL: https://github.com/apache/airflow/pull/29413#discussion_r1114817390 ## airflow/www/views.py: ## @@ -3591,6 +3591,42 @@ def extra_links(self, *, session: Session = NEW_SESSION): else: return {"url": None,

[GitHub] [airflow] eladkal commented on a diff in pull request #28953: Updated Telegram Provider to ensure compatbility with >=20.0.0

2023-02-22 Thread via GitHub
eladkal commented on code in PR #28953: URL: https://github.com/apache/airflow/pull/28953#discussion_r1114794911 ## airflow/providers/telegram/provider.yaml: ## @@ -39,7 +40,7 @@ dependencies: # The telegram bot 20.0.0 is not yet compatible with our provider as documented

[GitHub] [airflow] bbovenzi commented on a diff in pull request #29413: Add a new graph inside of the grid view

2023-02-22 Thread via GitHub
bbovenzi commented on code in PR #29413: URL: https://github.com/apache/airflow/pull/29413#discussion_r1114762187 ## airflow/www/webpack.config.js: ## @@ -136,6 +137,15 @@ const config = { 'css-loader', ], }, + // Extract css files + { +

  1   2   >