[GitHub] [airflow] duke8585 commented on pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-02-25 Thread via GitHub
duke8585 commented on PR #29195: URL: https://github.com/apache/airflow/pull/29195#issuecomment-1445290110 thanks everyone. i learned quite some things here :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [airflow] eladkal commented on pull request #28950: Sensor for Databricks partition and table changes

2023-02-25 Thread via GitHub
eladkal commented on PR #28950: URL: https://github.com/apache/airflow/pull/28950#issuecomment-1445289438 > Details doc build is failing :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] eladkal commented on issue #18371: Upgrade google-api-python-client to 2.x.x

2023-02-25 Thread via GitHub
eladkal commented on issue #18371: URL: https://github.com/apache/airflow/issues/18371#issuecomment-1445285771 Will be tracked in https://github.com/apache/airflow/issues/27292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] eladkal closed issue #18371: Upgrade google-api-python-client to 2.x.x

2023-02-25 Thread via GitHub
eladkal closed issue #18371: Upgrade google-api-python-client to 2.x.x URL: https://github.com/apache/airflow/issues/18371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [airflow] github-actions[bot] commented on issue #20788: AIrflow Scheduler does not schedule any tasks when >max running tasks queued with non-existant pool

2023-02-25 Thread via GitHub
github-actions[bot] commented on issue #20788: URL: https://github.com/apache/airflow/issues/20788#issuecomment-1445283414 This issue has been automatically marked as stale because it has been open for 365 days without any activity. There has been several Airflow releases since last activit

[GitHub] [airflow] harishkrao commented on pull request #28950: Sensor for Databricks partition and table changes

2023-02-25 Thread via GitHub
harishkrao commented on PR #28950: URL: https://github.com/apache/airflow/pull/28950#issuecomment-1445274083 @eladkal changed the unit tests, can you please review once more? Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] eladkal closed issue #15668: Extend Error Notifications to REST API actions

2023-02-25 Thread via GitHub
eladkal closed issue #15668: Extend Error Notifications to REST API actions URL: https://github.com/apache/airflow/issues/15668 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] Bowrna opened a new pull request, #29773: better description for limit in api

2023-02-25 Thread via GitHub
Bowrna opened a new pull request, #29773: URL: https://github.com/apache/airflow/pull/29773 I have made changes in config.yml file with better description for maximum page limit and fallback page limit closes: #27425 --- **^ Add meaningful description above** Read

[GitHub] [airflow] eladkal commented on issue #22365: 'external_trigger' in OpenAPI specs has a default value which as a result, will be always included in the request body by the generated OpenAPI sp

2023-02-25 Thread via GitHub
eladkal commented on issue #22365: URL: https://github.com/apache/airflow/issues/22365#issuecomment-1445269435 @omarsmak are you still working on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [airflow] eladkal commented on pull request #29772: Support deleting the local log files when using remote logging

2023-02-25 Thread via GitHub
eladkal commented on PR #29772: URL: https://github.com/apache/airflow/pull/29772#issuecomment-1445268002 >To avoid adding unnecessary extra dependency between these providers and the Airflow core, I didn't create a new Airflow config as discussed in the issue, so users can still upgrade pr

[GitHub] [airflow] hussein-awala opened a new pull request, #29772: Support deleting the local log files when using remote logging

2023-02-25 Thread via GitHub
hussein-awala opened a new pull request, #29772: URL: https://github.com/apache/airflow/pull/29772 closes: #16142 --- In this PR, I add a new parameter `delete_local_copy` for `S3TaskHandler`, `GCSTaskHandler` and `OSSTaskHandler` (`WasbTaskHandler` already has it), to support del

[GitHub] [airflow] github-actions[bot] commented on pull request #24652: Add ``@task.snowpark`` decorator

2023-02-25 Thread via GitHub
github-actions[bot] commented on PR #24652: URL: https://github.com/apache/airflow/pull/24652#issuecomment-1445232475 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] hussein-awala opened a new pull request, #29771: [WIP] Deprecate `execution_date` in the Airflow REST API

2023-02-25 Thread via GitHub
hussein-awala opened a new pull request, #29771: URL: https://github.com/apache/airflow/pull/29771 closes: #29745 --- Deprecate `execution_date` in the Airflow REST API and support logical date in all the endpoints. -- This is an automated message from the Apache Git Service. T

[airflow] branch main updated: Fixing Task Duration view in case of manual DAG runs only (#22015) (#29195)

2023-02-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8b8552f5c4 Fixing Task Duration view in case of man

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-02-25 Thread via GitHub
boring-cyborg[bot] commented on PR #29195: URL: https://github.com/apache/airflow/pull/29195#issuecomment-1445213477 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk merged pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-02-25 Thread via GitHub
potiuk merged PR #29195: URL: https://github.com/apache/airflow/pull/29195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk closed issue #22015: Allow showing more than 25 last DAG runs in the task duration view

2023-02-25 Thread via GitHub
potiuk closed issue #22015: Allow showing more than 25 last DAG runs in the task duration view URL: https://github.com/apache/airflow/issues/22015 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on pull request #29766: Upgrade FAB to 4.3.0

2023-02-25 Thread via GitHub
potiuk commented on PR #29766: URL: https://github.com/apache/airflow/pull/29766#issuecomment-1445211243 Yep. Ready for tests/review. Also added specific test for rate_limiting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [airflow] potiuk commented on a diff in pull request #29769: Fix compile www assets dev

2023-02-25 Thread via GitHub
potiuk commented on code in PR #29769: URL: https://github.com/apache/airflow/pull/29769#discussion_r1117982459 ## scripts/ci/pre_commit/pre_commit_compile_www_assets_dev.py: ## @@ -35,6 +35,7 @@ if __name__ == "__main__": www_directory = AIRFLOW_SOURCES_PATH / "airflow"

[GitHub] [airflow] potiuk commented on a diff in pull request #29769: Fix compile www assets dev

2023-02-25 Thread via GitHub
potiuk commented on code in PR #29769: URL: https://github.com/apache/airflow/pull/29769#discussion_r1117982374 ## scripts/ci/pre_commit/pre_commit_compile_www_assets_dev.py: ## @@ -35,6 +35,7 @@ if __name__ == "__main__": www_directory = AIRFLOW_SOURCES_PATH / "airflow"

[GitHub] [airflow] pierrejeambrun closed pull request #29769: Fix compile www assets dev

2023-02-25 Thread via GitHub
pierrejeambrun closed pull request #29769: Fix compile www assets dev URL: https://github.com/apache/airflow/pull/29769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [airflow] eladkal closed issue #15672: Add option to send webserver audit logging to stdout

2023-02-25 Thread via GitHub
eladkal closed issue #15672: Add option to send webserver audit logging to stdout URL: https://github.com/apache/airflow/issues/15672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [airflow] pierrejeambrun opened a new pull request, #29769: Fix compile www assets dev

2023-02-25 Thread via GitHub
pierrejeambrun opened a new pull request, #29769: URL: https://github.com/apache/airflow/pull/29769 `.build/www` is missing, and therefore asset compilation was not performed. Ensure that this directory exists before redirecting the compilation output. To reproduce: ``` rm

[GitHub] [airflow] potiuk commented on a diff in pull request #29760: `KubernetesPodOperator._render_nested_template_fields` improved by changing the conditionals for a map

2023-02-25 Thread via GitHub
potiuk commented on code in PR #29760: URL: https://github.com/apache/airflow/pull/29760#discussion_r1117978501 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -378,22 +378,16 @@ def _render_nested_template_fields( seen_oids: set, ) -> None:

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29760: `KubernetesPodOperator._render_nested_template_fields` improved by changing the conditionals for a map

2023-02-25 Thread via GitHub
hussein-awala commented on code in PR #29760: URL: https://github.com/apache/airflow/pull/29760#discussion_r1117977100 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -378,22 +378,16 @@ def _render_nested_template_fields( seen_oids: set, ) -

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29768: Add prettier formatting for www

2023-02-25 Thread via GitHub
pierrejeambrun commented on code in PR #29768: URL: https://github.com/apache/airflow/pull/29768#discussion_r1117976042 ## airflow/www/.prettierrc: ## @@ -0,0 +1,10 @@ +{ Review Comment: This is necessary because prettier is otherwise using the default config in `.editorcon

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29768: Add prettier formatting for www

2023-02-25 Thread via GitHub
pierrejeambrun commented on code in PR #29768: URL: https://github.com/apache/airflow/pull/29768#discussion_r1117976042 ## airflow/www/.prettierrc: ## @@ -0,0 +1,10 @@ +{ Review Comment: This is necessary because prettier is otherwise using the default config in `.editorcon

[GitHub] [airflow] pierrejeambrun opened a new pull request, #29768: Add prettier formatting for www

2023-02-25 Thread via GitHub
pierrejeambrun opened a new pull request, #29768: URL: https://github.com/apache/airflow/pull/29768 **Issue**: Formatting with eslint is too permissive. 2 different formatting style can be considered 'valid' for eslint but quite different in practice. Also formatting with eslint is not t

[GitHub] [airflow] potiuk commented on pull request #29766: Upgrade FAB to 4.3.0

2023-02-25 Thread via GitHub
potiuk commented on PR #29766: URL: https://github.com/apache/airflow/pull/29766#issuecomment-1445196182 I think all the tests should pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] potiuk commented on pull request #29357: Template extra volumes in helm chart

2023-02-25 Thread via GitHub
potiuk commented on PR #29357: URL: https://github.com/apache/airflow/pull/29357#issuecomment-1445191287 > My 2c, an example like @planoe suggested is enough. We can't put everything in the prod guide, it'd be way too long. We could consider documenting more advanced features, but we should

[GitHub] [airflow] jedcunningham commented on pull request #29357: Template extra volumes in helm chart

2023-02-25 Thread via GitHub
jedcunningham commented on PR #29357: URL: https://github.com/apache/airflow/pull/29357#issuecomment-1445190811 My 2c, an example like @planoe suggested is enough. We can't put everything in the prod guide, it'd be way too long. We could consider documenting more advanced features, but we s

[airflow] branch main updated (851cedf088 -> de2889c2e9)

2023-02-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 851cedf088 Upgrade pip to version 23.0.1 (#29767) add de2889c2e9 Add workaround for Airflow consuming all memory i

[GitHub] [airflow] potiuk merged pull request #29751: Add workaround for Airflow consuming all memory in some OS'es

2023-02-25 Thread via GitHub
potiuk merged PR #29751: URL: https://github.com/apache/airflow/pull/29751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] hussein-awala commented on pull request #29762: Add an example for dynamic task mapping with non-TaskFlow operator

2023-02-25 Thread via GitHub
hussein-awala commented on PR #29762: URL: https://github.com/apache/airflow/pull/29762#issuecomment-1445183541 It seems like the serialized task from `Mapped(_PythonDecoratedOperator)` has a field `_operator_name` which we use in [this test](https://github.com/apache/airflow/blob/main/test

[GitHub] [airflow] vemikhaylov commented on a diff in pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-25 Thread via GitHub
vemikhaylov commented on code in PR #29608: URL: https://github.com/apache/airflow/pull/29608#discussion_r1117962738 ## airflow/example_dags/example_passing_xcoms_via_test_command.py: ## @@ -0,0 +1,57 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[airflow] branch main updated: Upgrade pip to version 23.0.1 (#29767)

2023-02-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 851cedf088 Upgrade pip to version 23.0.1 (#29767) 8

[GitHub] [airflow] potiuk merged pull request #29767: Upgrade pip to version 23.0.1

2023-02-25 Thread via GitHub
potiuk merged PR #29767: URL: https://github.com/apache/airflow/pull/29767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] vemikhaylov commented on a diff in pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-25 Thread via GitHub
vemikhaylov commented on code in PR #29608: URL: https://github.com/apache/airflow/pull/29608#discussion_r1117956211 ## airflow/cli/commands/task_command.py: ## @@ -596,6 +597,10 @@ def task_test(args, dag=None): task, args.map_index, exec_date_or_run_id=args.execution

[GitHub] [airflow] vemikhaylov commented on a diff in pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-25 Thread via GitHub
vemikhaylov commented on code in PR #29608: URL: https://github.com/apache/airflow/pull/29608#discussion_r1117955516 ## airflow/models/taskinstance.py: ## @@ -2741,6 +2749,14 @@ def tg2(inp): map_index_start = ancestor_map_index * further_count return range(map

[GitHub] [airflow] pierrejeambrun commented on issue #29358: Cannot use TypedDict object when defining params

2023-02-25 Thread via GitHub
pierrejeambrun commented on issue #29358: URL: https://github.com/apache/airflow/issues/29358#issuecomment-1445166734 @jcobb-healx Are you still working on this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #29766: Upgrade FAB to 4.3.0

2023-02-25 Thread via GitHub
potiuk commented on PR #29766: URL: https://github.com/apache/airflow/pull/29766#issuecomment-1445165868 Nice ... It seems our unit tests are failing now because rate limit has been exceeded :) ``` [2023-02-25T17:21:02.852+] {extension.py:981} INFO - ratelimit 10 per 20

[GitHub] [airflow] potiuk opened a new pull request, #29767: Upgrade pip to version 23.0.1

2023-02-25 Thread via GitHub
potiuk opened a new pull request, #29767: URL: https://github.com/apache/airflow/pull/29767 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more info

[GitHub] [airflow] potiuk commented on pull request #29726: Created CloudSQLCloneInstanceOperator to clone cloudSQL instances.

2023-02-25 Thread via GitHub
potiuk commented on PR #29726: URL: https://github.com/apache/airflow/pull/29726#issuecomment-1445159878 tests/static checks are failing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] potiuk commented on pull request #28336: Fixed hanged KubernetesPodOperator

2023-02-25 Thread via GitHub
potiuk commented on PR #28336: URL: https://github.com/apache/airflow/pull/28336#issuecomment-1445155729 Needs re-review @dimberman @dstandish I guess. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] potiuk closed issue #29588: Support execution_date parameter in dags list-runs CLI

2023-02-25 Thread via GitHub
potiuk closed issue #29588: Support execution_date parameter in dags list-runs CLI URL: https://github.com/apache/airflow/issues/29588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] potiuk commented on issue #29588: Support execution_date parameter in dags list-runs CLI

2023-02-25 Thread via GitHub
potiuk commented on issue #29588: URL: https://github.com/apache/airflow/issues/29588#issuecomment-1445155489 Closing it provisionally as fixed then. In case @ellisms has some more to add we can always reopen it. -- This is an automated message from the Apache Git Service. To respond to t

[airflow] branch main updated: Description of dag_processing.last_duration (#29740)

2023-02-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4e3b5ae724 Description of dag_processing.last_durat

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29740: Description of dag_processing.last_duration

2023-02-25 Thread via GitHub
boring-cyborg[bot] commented on PR #29740: URL: https://github.com/apache/airflow/pull/29740#issuecomment-1445154972 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk merged pull request #29740: Description of dag_processing.last_duration

2023-02-25 Thread via GitHub
potiuk merged PR #29740: URL: https://github.com/apache/airflow/pull/29740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on issue #29663: Option to Disable High Cardinality Metrics on Statsd

2023-02-25 Thread via GitHub
potiuk commented on issue #29663: URL: https://github.com/apache/airflow/issues/29663#issuecomment-1445154381 > I prefer the second option because it's more dynamic, and we can use it to disable one of the two tags or another different tag. > > @potiuk what do you think? Yep. S

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ 27bdc4d162c8407fbf243e7b7ee9da614dc25c9e 🚀

2023-02-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new 6209b92241 Deploying to gh-pages f

[GitHub] [airflow] potiuk commented on pull request #29624: Can't configure Kubernetes and Celery workers in Helm Chart

2023-02-25 Thread via GitHub
potiuk commented on PR #29624: URL: https://github.com/apache/airflow/pull/29624#issuecomment-1445151205 I think... Let's try what @hussein-awala proposes :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [airflow-site] potiuk merged pull request #745: Improve style for community unsubscribe list/links

2023-02-25 Thread via GitHub
potiuk merged PR #745: URL: https://github.com/apache/airflow-site/pull/745 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow-site] branch main updated: Improve style for community unsubscribe list/links (#745)

2023-02-25 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 27bdc4d162 Improve style for community unsubsc

[GitHub] [airflow-site] potiuk commented on pull request #745: Improve style for community unsubscribe list/links

2023-02-25 Thread via GitHub
potiuk commented on PR #745: URL: https://github.com/apache/airflow-site/pull/745#issuecomment-1445149302 LGTM :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [airflow] potiuk commented on pull request #29766: Upgrade FAB to 4.3.0

2023-02-25 Thread via GitHub
potiuk commented on PR #29766: URL: https://github.com/apache/airflow/pull/29766#issuecomment-1445147943 This one attempts to sync the changes in FAB 4.3.0 including @bolkedebruin rate limiter. I think as an "end product" we should have rate limiting enabled by default, but would lov

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29756: Adding sorting keys to generate_pages

2023-02-25 Thread via GitHub
amoghrajesh commented on code in PR #29756: URL: https://github.com/apache/airflow/pull/29756#discussion_r1117942383 ## airflow/www/views.py: ## @@ -895,6 +895,8 @@ def _iter_parsed_moved_data_table_names(): search=escape(arg_search_query) if arg_search_query el

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29756: Adding sorting keys to generate_pages

2023-02-25 Thread via GitHub
amoghrajesh commented on code in PR #29756: URL: https://github.com/apache/airflow/pull/29756#discussion_r1117942284 ## airflow/www/utils.py: ## @@ -219,7 +219,16 @@ def get_params(**kwargs): return urlencode({d: v for d, v in kwargs.items() if v is not None}, True) -de

[GitHub] [airflow] potiuk opened a new pull request, #29766: Upgrade FAB to 4.3.0

2023-02-25 Thread via GitHub
potiuk opened a new pull request, #29766: URL: https://github.com/apache/airflow/pull/29766 FAB 4.3.0 added rate limiting and we would like to upgrade to this version. This requires to bring some of the changes from the PRs merged in Flask App Builder: * https://github.com/dpga

[GitHub] [airflow] vemikhaylov commented on a diff in pull request #29608: Enable passing --xcom-args to tasks test CLI command

2023-02-25 Thread via GitHub
vemikhaylov commented on code in PR #29608: URL: https://github.com/apache/airflow/pull/29608#discussion_r1117940737 ## airflow/cli/cli_parser.py: ## @@ -36,13 +38,24 @@ from airflow.exceptions import AirflowException from airflow.executors.executor_constants import CELERY_EXE

[GitHub] [airflow] pierrejeambrun commented on a diff in pull request #29756: Adding sorting keys to generate_pages

2023-02-25 Thread via GitHub
pierrejeambrun commented on code in PR #29756: URL: https://github.com/apache/airflow/pull/29756#discussion_r1117939177 ## airflow/www/views.py: ## @@ -895,6 +895,8 @@ def _iter_parsed_moved_data_table_names(): search=escape(arg_search_query) if arg_search_query

[GitHub] [airflow] eladkal commented on pull request #28950: Sensor for Databricks partition and table changes

2023-02-25 Thread via GitHub
eladkal commented on PR #28950: URL: https://github.com/apache/airflow/pull/28950#issuecomment-1445138470 Tests are failing ``` FAILED tests/providers/databricks/sensors/test_databricks_partition.py::TestDatabricksPartitionSensor::test_poke_changes_failure - AssertionError: AirflowExc

[GitHub] [airflow-site] pierrejeambrun opened a new pull request, #745: Improve style for community unsubscribe list/links

2023-02-25 Thread via GitHub
pierrejeambrun opened a new pull request, #745: URL: https://github.com/apache/airflow-site/pull/745 Small PR to update the style of the community page: - remove grey dot in the list items (all screen size) - fix layout (only for small screens / mobiles) ## Before list item + lay

[airflow-site] branch improve-community-unsubscribe-style created (now da114c04e9)

2023-02-25 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch improve-community-unsubscribe-style in repository https://gitbox.apache.org/repos/asf/airflow-site.git at da114c04e9 Improve style for community unsubscribe list/links This branch

[airflow-site] 01/01: Improve style for community unsubscribe list/links

2023-02-25 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch improve-community-unsubscribe-style in repository https://gitbox.apache.org/repos/asf/airflow-site.git commit da114c04e9766f3ddd856f0c64701bde86177b6e Author: pierrejeambrun AuthorDate: S

[GitHub] [airflow] quoctienkt commented on issue #29765: ValueError: preexec_fn is not supported on Windows platforms

2023-02-25 Thread via GitHub
quoctienkt commented on issue #29765: URL: https://github.com/apache/airflow/issues/29765#issuecomment-1445135945 @potiuk Thanks for quick response! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on issue #29765: ValueError: preexec_fn is not supported on Windows platforms

2023-02-25 Thread via GitHub
potiuk commented on issue #29765: URL: https://github.com/apache/airflow/issues/29765#issuecomment-1445134140 Correct. Airflow does not work on windows natively (this is documented in our prerequisites) - see note at https://airflow.apache.org/docs/apache-airflow/stable/installation/prerequ

[GitHub] [airflow] potiuk closed issue #29765: ValueError: preexec_fn is not supported on Windows platforms

2023-02-25 Thread via GitHub
potiuk closed issue #29765: ValueError: preexec_fn is not supported on Windows platforms URL: https://github.com/apache/airflow/issues/29765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [airflow] quoctienkt opened a new issue, #29765: ValueError: preexec_fn is not supported on Windows platforms

2023-02-25 Thread via GitHub
quoctienkt opened a new issue, #29765: URL: https://github.com/apache/airflow/issues/29765 ### Apache Airflow version 2.5.1 ### What happened I'm following Airflow tutorial, and I faced error when come to this doc: [Tutorials - Testing section](https://airflow.apache.

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29765: ValueError: preexec_fn is not supported on Windows platforms

2023-02-25 Thread via GitHub
boring-cyborg[bot] commented on issue #29765: URL: https://github.com/apache/airflow/issues/29765#issuecomment-1445130483 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mess

[airflow] branch constraints-main updated: Updating constraints. Github run id:4270194952

2023-02-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 7bea1da64d Updating con

[GitHub] [airflow] potiuk commented on pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-02-25 Thread via GitHub
potiuk commented on PR #29195: URL: https://github.com/apache/airflow/pull/29195#issuecomment-1445125616 Closed/reopened to rebuild -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [airflow] duke8585 opened a new pull request, #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-02-25 Thread via GitHub
duke8585 opened a new pull request, #29195: URL: https://github.com/apache/airflow/pull/29195 Currently, if a DAG history is solely comprised of manual runs, they cannot be filtered down by `nums` in the duration view, because in this case, the min_date defaults to the current utc_epoch. Co

[GitHub] [airflow] potiuk closed pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-02-25 Thread via GitHub
potiuk closed pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015) URL: https://github.com/apache/airflow/pull/29195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [airflow] potiuk commented on issue #29555: Dag Fails while creating a Dynamic Tasks using airflow variables.

2023-02-25 Thread via GitHub
potiuk commented on issue #29555: URL: https://github.com/apache/airflow/issues/29555#issuecomment-1445125338 Yes. You miss the fact that Airlfow 2.2 does not have dyamic task mapping implemented. You need to upgrade (ideally to 2.5.1 as this one contains most bug fixes and new features) in

[GitHub] [airflow] eladkal opened a new pull request, #29764: Relax version of azure-mgmt-datafactory

2023-02-25 Thread via GitHub
eladkal opened a new pull request, #29764: URL: https://github.com/apache/airflow/pull/29764 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more inf

[GitHub] [airflow] potiuk commented on pull request #29609: Decouple production executor warning in dags UI

2023-02-25 Thread via GitHub
potiuk commented on PR #29609: URL: https://github.com/apache/airflow/pull/29609#issuecomment-1445121921 I think it needs rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [airflow] potiuk commented on pull request #29446: Scheduler, make stale DAG deactivation threshold configurable instead of using dag processing timeout

2023-02-25 Thread via GitHub
potiuk commented on PR #29446: URL: https://github.com/apache/airflow/pull/29446#issuecomment-1445121785 Needs fixing tests :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [airflow-site] pierrejeambrun commented on pull request #744: Fix wrapping of unsubscribe lists in the community page

2023-02-25 Thread via GitHub
pierrejeambrun commented on PR #744: URL: https://github.com/apache/airflow-site/pull/744#issuecomment-1445121408 No worries I'll take a look thank you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow-site] potiuk commented on pull request #744: Fix wrapping of unsubscribe lists in the community page

2023-02-25 Thread via GitHub
potiuk commented on PR #744: URL: https://github.com/apache/airflow-site/pull/744#issuecomment-1445121403 But yeah. it can be done better for sure :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow-site] potiuk commented on pull request #744: Fix wrapping of unsubscribe lists in the community page

2023-02-25 Thread via GitHub
potiuk commented on PR #744: URL: https://github.com/apache/airflow-site/pull/744#issuecomment-1445121228 I am not that good of in css and javascript to know where and how to do it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [airflow-site] pierrejeambrun commented on pull request #744: Fix wrapping of unsubscribe lists in the community page

2023-02-25 Thread via GitHub
pierrejeambrun commented on PR #744: URL: https://github.com/apache/airflow-site/pull/744#issuecomment-1445121119 Also it was already the case, but the long emails are breaking the layout for mobile, and this is making it worse: ![image](https://user-images.githubusercontent.com/14861206

[GitHub] [airflow-site] pierrejeambrun commented on pull request #744: Fix wrapping of unsubscribe lists in the community page

2023-02-25 Thread via GitHub
pierrejeambrun commented on PR #744: URL: https://github.com/apache/airflow-site/pull/744#issuecomment-1445120325 @potiuk We might want to add a css class to the new 'ul' items so it removes the default 'grey dot' for list items. ![image](https://user-images.githubusercontent.com/148

[GitHub] [airflow] Taragolis opened a new pull request, #29763: Remove remaining old-style Amazon System Tests

2023-02-25 Thread via GitHub
Taragolis opened a new pull request, #29763: URL: https://github.com/apache/airflow/pull/29763 Remaining `TestS3BucketExampleDagsSystem` test refers to DAG which not exists (potentially for a long time) so better to drop it rather than try to fix it -- This is an automated message from t

[GitHub] [airflow] eladkal commented on pull request #29518: Google Cloud Providers - Fix _MethodDefault deepcopy failure

2023-02-25 Thread via GitHub
eladkal commented on PR #29518: URL: https://github.com/apache/airflow/pull/29518#issuecomment-1445119546 > Sounds good, created https://github.com/apache/airflow/pull/29680 merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [airflow] eladkal merged pull request #29680: Google Cloud Providers - Introduce GoogleCloudBaseOperator

2023-02-25 Thread via GitHub
eladkal merged PR #29680: URL: https://github.com/apache/airflow/pull/29680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[airflow] branch main updated (717426ec40 -> 1e7c064560)

2023-02-25 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 717426ec40 Correct version label for data interval variables in documentation (#29704) add 1e7c064560 Google Clo

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ 5bb987e6811a799f7053d5e13f5bd89d8185ebcb 🚀

2023-02-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new 33ac8b77bf Deploying to gh-pages f

[GitHub] [airflow] hussein-awala commented on issue #29303: KubernetesPodOperator not make task status to success due the task execution time is very short

2023-02-25 Thread via GitHub
hussein-awala commented on issue #29303: URL: https://github.com/apache/airflow/issues/29303#issuecomment-1445116060 > kubectl get pod t-crawler-gem-ipo-request-39a8a54e91394e8198711966fb7ec66d -o jsonpath='{.status.phase}' -n crawler Succeeded @chuxiangfeng Since kubectl returns S

[airflow-site] branch main updated: Fix wrapping of unsubscribe lists in the community page (#744)

2023-02-25 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new 5bb987e681 Fix wrapping of unsubscribe

[GitHub] [airflow-site] pierrejeambrun merged pull request #744: Fix wrapping of unsubscribe lists in the community page

2023-02-25 Thread via GitHub
pierrejeambrun merged PR #744: URL: https://github.com/apache/airflow-site/pull/744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [airflow] potiuk commented on a diff in pull request #29760: `KubernetesPodOperator._render_nested_template_fields` improved by changing the conditionals for a map

2023-02-25 Thread via GitHub
potiuk commented on code in PR #29760: URL: https://github.com/apache/airflow/pull/29760#discussion_r1117921522 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -378,22 +378,16 @@ def _render_nested_template_fields( seen_oids: set, ) -> None:

[GitHub] [airflow] potiuk commented on a diff in pull request #29760: `KubernetesPodOperator._render_nested_template_fields` improved by changing the conditionals for a map

2023-02-25 Thread via GitHub
potiuk commented on code in PR #29760: URL: https://github.com/apache/airflow/pull/29760#discussion_r1117921546 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -378,22 +378,16 @@ def _render_nested_template_fields( seen_oids: set, ) -> None:

[GitHub] [airflow] potiuk commented on a diff in pull request #29760: `KubernetesPodOperator._render_nested_template_fields` improved by changing the conditionals for a map

2023-02-25 Thread via GitHub
potiuk commented on code in PR #29760: URL: https://github.com/apache/airflow/pull/29760#discussion_r1117921522 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -378,22 +378,16 @@ def _render_nested_template_fields( seen_oids: set, ) -> None:

[GitHub] [airflow] jose-lpa commented on a diff in pull request #29760: `KubernetesPodOperator._render_nested_template_fields` improved by changing the conditionals for a map

2023-02-25 Thread via GitHub
jose-lpa commented on code in PR #29760: URL: https://github.com/apache/airflow/pull/29760#discussion_r1117921298 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -378,22 +378,16 @@ def _render_nested_template_fields( seen_oids: set, ) -> Non

[GitHub] [airflow] hussein-awala opened a new pull request, #29762: Add an example for dynamic task mapping with non-TaskFlow operator

2023-02-25 Thread via GitHub
hussein-awala opened a new pull request, #29762: URL: https://github.com/apache/airflow/pull/29762 closes: #29754 --- Add a full example for dynamic task mapping with non-TaskFlow operator and include it in dynamic task mapping documentation. -- This is an automated message

[GitHub] [airflow] potiuk commented on pull request #29357: Template extra volumes in helm chart

2023-02-25 Thread via GitHub
potiuk commented on PR #29357: URL: https://github.com/apache/airflow/pull/29357#issuecomment-1445113019 I think we also need a small chapter in Production Guide: https://airflow.apache.org/docs/helm-chart/stable/production-guide.html with short explanation of the use case and why you would

[GitHub] [airflow] potiuk closed issue #13706: Build only one CI image and run less jobs for docs-only PRs

2023-02-25 Thread via GitHub
potiuk closed issue #13706: Build only one CI image and run less jobs for docs-only PRs URL: https://github.com/apache/airflow/issues/13706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] potiuk commented on issue #13706: Build only one CI image and run less jobs for docs-only PRs

2023-02-25 Thread via GitHub
potiuk commented on issue #13706: URL: https://github.com/apache/airflow/issues/13706#issuecomment-1445111464 Yes. Done a long time ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [airflow] eladkal commented on issue #13706: Build only one CI image and run less jobs for docs-only PRs

2023-02-25 Thread via GitHub
eladkal commented on issue #13706: URL: https://github.com/apache/airflow/issues/13706#issuecomment-1445110413 I think this one is completed? i checked few PRs with doc-only label (for release notes) and It invoked only the relevant doc test -- This is an automated message from the Apa

  1   2   >