[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
Abhishek-kumar-samsung commented on code in PR #29927: URL: https://github.com/apache/airflow/pull/29927#discussion_r1125616329 ## BREEZE.rst: ## @@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag): Once this is complete, you should have ``br

[GitHub] [airflow] potiuk commented on pull request #29923: Separate CI Job to run Pytest collection check

2023-03-04 Thread via GitHub
potiuk commented on PR #29923: URL: https://github.com/apache/airflow/pull/29923#issuecomment-1455015964 This one will be very helpful when things like "new dependency release" breaking test imports - only real unit tests will be affected and it will be clear that test collection is the cu

[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29927: URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613733 ## BREEZE.rst: ## @@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag): Once this is complete, you should have ``breeze`` binary on

[GitHub] [airflow] Abhishek-kumar-samsung commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
Abhishek-kumar-samsung commented on code in PR #29927: URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613360 ## BREEZE.rst: ## @@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag): Once this is complete, you should have ``br

[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29927: URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613208 ## BREEZE.rst: ## @@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag): Once this is complete, you should have ``breeze`` binary on

[GitHub] [airflow] potiuk commented on a diff in pull request #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29927: URL: https://github.com/apache/airflow/pull/29927#discussion_r1125613009 ## BREEZE.rst: ## @@ -233,6 +233,16 @@ Run this command to install Breeze (make sure to use ``-e`` flag): Once this is complete, you should have ``breeze`` binary on

[GitHub] [airflow] potiuk commented on issue #29918: Add Triggers to provider information

2023-03-04 Thread via GitHub
potiuk commented on issue #29918: URL: https://github.com/apache/airflow/issues/29918#issuecomment-1455013440 Yep. That's the point. We don't have them there and we need to add them :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] phanikumv commented on a diff in pull request #29801: Add deferrable `AzureDataFactoryPipelineRunStatusSensor`

2023-03-04 Thread via GitHub
phanikumv commented on code in PR #29801: URL: https://github.com/apache/airflow/pull/29801#discussion_r1125612675 ## airflow/providers/microsoft/azure/sensors/data_factory.py: ## @@ -78,3 +84,60 @@ def poke(self, context: Context) -> bool: raise AzureDataFactoryPip

[GitHub] [airflow] Abhishek-kumar-samsung commented on pull request #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
Abhishek-kumar-samsung commented on PR #29927: URL: https://github.com/apache/airflow/pull/29927#issuecomment-1455012534 @Taragolis @eladkal @potiuk can you please review. I have updated Breeze.rst to handle docker errors that may come while running breeze first time. -- This is an

[GitHub] [airflow] Abhishek-kumar-samsung opened a new pull request, #29927: Solution to docker errors that may come while running breeze

2023-03-04 Thread via GitHub
Abhishek-kumar-samsung opened a new pull request, #29927: URL: https://github.com/apache/airflow/pull/29927 Solution to docker errors that may come while running breeze -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [airflow] eladkal closed pull request #28230: Add deferrable mode to Kubernetes and GKE operators

2023-03-04 Thread via GitHub
eladkal closed pull request #28230: Add deferrable mode to Kubernetes and GKE operators URL: https://github.com/apache/airflow/pull/28230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] eladkal commented on pull request #28230: Add deferrable mode to Kubernetes and GKE operators

2023-03-04 Thread via GitHub
eladkal commented on PR #28230: URL: https://github.com/apache/airflow/pull/28230#issuecomment-1455011791 > @eladkal Hi! This PR was splitted to 2 separate. Please, check the link in the comment above :) I think this PR can be closed in this case. But i am not the owner, so i cant. T

[GitHub] [airflow] VladaZakharova commented on pull request #28230: Add deferrable mode to Kubernetes and GKE operators

2023-03-04 Thread via GitHub
VladaZakharova commented on PR #28230: URL: https://github.com/apache/airflow/pull/28230#issuecomment-1455010371 @eladkal Hi! This PR was splitted to 2 separate. Please, check the link in the comment above :) I think this PR can be closed in this case. But i am not the owner, so i

[GitHub] [airflow] amoghrajesh commented on pull request #29926: Making webserver config customisable

2023-03-04 Thread via GitHub
amoghrajesh commented on PR #29926: URL: https://github.com/apache/airflow/pull/29926#issuecomment-1455009300 @uranusjr the unit test is a WIP. The application code is up to date. I do not see formatting issues in that file -- This is an automated message from the Apache Git Service. To r

[GitHub] [airflow] uranusjr commented on pull request #29926: Making webserver config customisable

2023-03-04 Thread via GitHub
uranusjr commented on PR #29926: URL: https://github.com/apache/airflow/pull/29926#issuecomment-1455008348 This looks like a work in progress? A lot of leftover and incorrectly formatted code. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [airflow] amoghrajesh commented on issue #10206: Make `webserver_config.py` location customizable

2023-03-04 Thread via GitHub
amoghrajesh commented on issue #10206: URL: https://github.com/apache/airflow/issues/10206#issuecomment-1455003743 @potiuk added a PR: https://github.com/apache/airflow/pull/29926/. It is still in its first stage, figuring out a way to get a unit test up and running -- This is an automate

[GitHub] [airflow] uranusjr commented on pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

2023-03-04 Thread via GitHub
uranusjr commented on PR #29909: URL: https://github.com/apache/airflow/pull/29909#issuecomment-1455003651 Iā€™m not sure a new directive is worthwhile tbh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [airflow] amoghrajesh opened a new pull request, #29926: Making webserver config customisable

2023-03-04 Thread via GitHub
amoghrajesh opened a new pull request, #29926: URL: https://github.com/apache/airflow/pull/29926 The webserver_config.py is hard coded and is not customisable at the moment. It would be nice to read this config from the config directory instead of the root too. This PR adds support to p

[airflow] branch constraints-main updated: Updating constraints. Github run id:4334506027

2023-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e546fa0905 Updating con

[GitHub] [airflow] SamWheating commented on a diff in pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

2023-03-04 Thread via GitHub
SamWheating commented on code in PR #29909: URL: https://github.com/apache/airflow/pull/29909#discussion_r1125601470 ## airflow/timetables/simple.py: ## @@ -108,6 +109,37 @@ def next_dagrun_info( return DagRunInfo.exact(run_after) +class ContinuousTimetable(_Trivial

[GitHub] [airflow] SamWheating commented on a diff in pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

2023-03-04 Thread via GitHub
SamWheating commented on code in PR #29909: URL: https://github.com/apache/airflow/pull/29909#discussion_r1125601220 ## airflow/timetables/simple.py: ## @@ -108,6 +109,37 @@ def next_dagrun_info( return DagRunInfo.exact(run_after) +class ContinuousTimetable(_Trivial

[GitHub] [airflow] amoghrajesh commented on issue #10206: Make `webserver_config.py` location customizable

2023-03-04 Thread via GitHub
amoghrajesh commented on issue #10206: URL: https://github.com/apache/airflow/issues/10206#issuecomment-1454995218 I think deprecation will be a big change and that we should move eventually to it. For a start, we can start prioritising the webserver config present in config over what is pr

[airflow] branch main updated: Limit importlib-metadata backwport to < 5.0.0 (#29924)

2023-03-04 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4ea457a5ca Limit importlib-metadata backwport to <

[GitHub] [airflow] eladkal merged pull request #29924: Limit importlib-metadata backport to < 5.0.0

2023-03-04 Thread via GitHub
eladkal merged PR #29924: URL: https://github.com/apache/airflow/pull/29924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-04 Thread via GitHub
amoghrajesh commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1125597806 ## tests/kubernetes/test_client.py: ## @@ -78,3 +80,23 @@ def test_disable_verify_ssl(self): else: configuration = Configuration()

[GitHub] [airflow] npsables commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

2023-03-04 Thread via GitHub
npsables commented on PR #29526: URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454981046 This is actually the first time I have contributed to any opensource. It's meaningful to me. Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

2023-03-04 Thread via GitHub
hussein-awala commented on code in PR #29909: URL: https://github.com/apache/airflow/pull/29909#discussion_r1125588592 ## airflow/timetables/simple.py: ## @@ -108,6 +109,37 @@ def next_dagrun_info( return DagRunInfo.exact(run_after) +class ContinuousTimetable(_Trivi

[GitHub] [airflow] hussein-awala commented on issue #29912: BigQueryToGCSOperator does not wait for completion

2023-03-04 Thread via GitHub
hussein-awala commented on issue #29912: URL: https://github.com/apache/airflow/issues/29912#issuecomment-1454965669 @benjyblack Sorry I just tested a solution to fix this bug and it worked, so I created the PR #29925, can you check it? -- This is an automated message from the Apache Git

[GitHub] [airflow] hussein-awala opened a new pull request, #29925: Fix BigQueryToGCSOperator by waiting insert_job result in normal mode

2023-03-04 Thread via GitHub
hussein-awala opened a new pull request, #29925: URL: https://github.com/apache/airflow/pull/29925 closes: #29912 --- In deferrable mode, we should not wait the job result in the worker, instead we create a trigger and we wait the end of the job in the triggerer, and this is what

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-04 Thread via GitHub
hussein-awala commented on code in PR #29809: URL: https://github.com/apache/airflow/pull/29809#discussion_r1125584719 ## tests/kubernetes/test_client.py: ## @@ -78,3 +80,23 @@ def test_disable_verify_ssl(self): else: configuration = Configuration()

[GitHub] [airflow] Bowrna commented on issue #29918: Add Triggers to provider information

2023-03-04 Thread via GitHub
Bowrna commented on issue #29918: URL: https://github.com/apache/airflow/issues/29918#issuecomment-1454956665 hi @potiuk I don't see trigger information as part of `providers.yaml` for `cncf.kubernetes` file too. Am i looking at the wrong place? https://github.com/apache/airflow/blob

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454953933 the right fix is here https://github.com/apache/airflow/pull/29924 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [airflow] potiuk opened a new pull request, #29924: Limit importlib-metadata backwport to < 5.0.0

2023-03-04 Thread via GitHub
potiuk opened a new pull request, #29924: URL: https://github.com/apache/airflow/pull/29924 The Importlib-metadata 5 breaks importing Celery < 5.3.0. Until Celery 5.3.0 gets released (it is pre-release/beta now) we should workaround the problem by limiting importlib-metadata to < 5.0.0.

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454953026 (so no need to take a look @o-nikolas ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] potiuk closed pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk closed pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)" URL: https://github.com/apache/airflow/pull/29922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454952959 Confirmed. This is a regrression in importlib_metadata that will be fixed in upcoming celerly 5.3. Workaround is coming. -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454950832 I think it is a different thing - side-effect of argcomplete released few moments ago (which drags importlb upgrade with it). -- This is an automated message from the Apache Git Servic

[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled

2023-03-04 Thread via GitHub
potiuk commented on PR #29838: URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454949619 Nope. It happens in main - we need to fix it there first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454948654 Strange enough it did NOT fail in https://github.com/apache/airflow/pull/29923 ... so I start thinking there could be some intermediate problem. -- This is an automated message from t

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454948039 šŸ™ :) @o-nikolas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454947217 I also added this one https://github.com/apache/airflow/pull/29923 to clearer show when things like that happen (there will be separate job doing the test collection) and also allowing

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454946427 Yep. Strange. I need approval to merge it though :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] potiuk opened a new pull request, #29923: Separate CI Job to run Pytest collection check

2023-03-04 Thread via GitHub
potiuk opened a new pull request, #29923: URL: https://github.com/apache/airflow/pull/29923 Before we attempt to run tests in parallel, we quickly check once if Pytest collection works. This is in order to avoid costly parallel test execution if that makes no sense to initialize all the par

[GitHub] [airflow] o-nikolas commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
o-nikolas commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454942880 > @o-nikolas - you will have to redo that one again and we need to carefully look at what was going on with the import. Interesting, I'll have to find the way to replicate the e

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454942151 @o-nikolas - you will have to redo that one again and we need to carefully look at what was going on with the import. -- This is an automated message from the Apache Git Service. To re

[GitHub] [airflow] potiuk commented on pull request #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk commented on PR #29922: URL: https://github.com/apache/airflow/pull/29922#issuecomment-1454941979 Not sure why, but I think #https://github.com/apache/airflow/pull/29609 broken pytest collection in main (looks like a circular import). For some reason it did not happen in the original

[GitHub] [airflow] syun64 commented on pull request #29881: Blocklist to disable specific metric tags or metric names

2023-03-04 Thread via GitHub
syun64 commented on PR #29881: URL: https://github.com/apache/airflow/pull/29881#issuecomment-1454941871 > I think it is very confusing as defined now. I think we should change "allow_list_validator" field into "list_validator" and have two implementations: > > * AllowListValidator

[GitHub] [airflow] potiuk opened a new pull request, #29922: Revert "Decouple production executor warning in dags UI (#29609)"

2023-03-04 Thread via GitHub
potiuk opened a new pull request, #29922: URL: https://github.com/apache/airflow/pull/29922 This reverts commit 88ed20a813393e642de00ec920593bda7b5471cf. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow

[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled

2023-03-04 Thread via GitHub
potiuk commented on PR #29838: URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454935419 Looks like there are some side-effects of that change - the errors look quite related. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [airflow] potiuk commented on pull request #29917: Reformat chart templates

2023-03-04 Thread via GitHub
potiuk commented on PR #29917: URL: https://github.com/apache/airflow/pull/29917#issuecomment-1454934858 Nice. Today I learned about nindent. Others? @jedcunningham @dstandish - are you ok with this? -- This is an automated message from the Apache Git Service. To respond to the mess

[airflow] branch main updated (bf27e5379c -> ab22544b75)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from bf27e5379c Move string enum class to utils module + add test (#29906) add ab22544b75 fix: mount kerberos.keytab to

[GitHub] [airflow] potiuk commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

2023-03-04 Thread via GitHub
potiuk commented on PR #29526: URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454933561 Indeed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #29526: fix: mount kerberos.keytab to worker when enable

2023-03-04 Thread via GitHub
boring-cyborg[bot] commented on PR #29526: URL: https://github.com/apache/airflow/pull/29526#issuecomment-1454933536 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [airflow] potiuk merged pull request #29526: fix: mount kerberos.keytab to worker when enable

2023-03-04 Thread via GitHub
potiuk merged PR #29526: URL: https://github.com/apache/airflow/pull/29526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk merged pull request #29906: Move string enum class to utils module + add test

2023-03-04 Thread via GitHub
potiuk merged PR #29906: URL: https://github.com/apache/airflow/pull/29906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated (f55b9576b1 -> bf27e5379c)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f55b9576b1 `GoogleDriveHook`: Fixing log message + adding more verbose documentation (#29694) add bf27e5379c Move

[GitHub] [airflow] github-actions[bot] closed pull request #28874: Add `HivePartitionAsyncSensor`

2023-03-04 Thread via GitHub
github-actions[bot] closed pull request #28874: Add `HivePartitionAsyncSensor` URL: https://github.com/apache/airflow/pull/28874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] github-actions[bot] closed pull request #28183: allows users to write dag_id and task_id in their national characters, added display name for dag / task

2023-03-04 Thread via GitHub
github-actions[bot] closed pull request #28183: allows users to write dag_id and task_id in their national characters, added display name for dag / task URL: https://github.com/apache/airflow/pull/28183 -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [airflow] github-actions[bot] closed pull request #28854: Add missing types to `decorators.base`

2023-03-04 Thread via GitHub
github-actions[bot] closed pull request #28854: Add missing types to `decorators.base` URL: https://github.com/apache/airflow/pull/28854 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] github-actions[bot] closed pull request #28889: Add `on_kill()` to `DataprocInstantiateInlineWorkflowTemplateOperator`

2023-03-04 Thread via GitHub
github-actions[bot] closed pull request #28889: Add `on_kill()` to `DataprocInstantiateInlineWorkflowTemplateOperator` URL: https://github.com/apache/airflow/pull/28889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] github-actions[bot] commented on pull request #28980: Ensure non-JSON types go through encoder

2023-03-04 Thread via GitHub
github-actions[bot] commented on PR #28980: URL: https://github.com/apache/airflow/pull/28980#issuecomment-1454932776 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on pull request #29008: Implement XComArg helper function convert()

2023-03-04 Thread via GitHub
github-actions[bot] commented on PR #29008: URL: https://github.com/apache/airflow/pull/29008#issuecomment-1454932762 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on issue #29133: Airflow triggered the upstream task even the downstream task not executed completely.

2023-03-04 Thread via GitHub
github-actions[bot] commented on issue #29133: URL: https://github.com/apache/airflow/issues/29133#issuecomment-1454932743 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] closed issue #29133: Airflow triggered the upstream task even the downstream task not executed completely.

2023-03-04 Thread via GitHub
github-actions[bot] closed issue #29133: Airflow triggered the upstream task even the downstream task not executed completely. URL: https://github.com/apache/airflow/issues/29133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [airflow] potiuk commented on a diff in pull request #29914: Ssh connection docs: Fix wrong escaping of the newline

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29914: URL: https://github.com/apache/airflow/pull/29914#discussion_r1125576552 ## docs/apache-airflow-providers-ssh/connections/ssh.rst: ## @@ -99,7 +99,7 @@ Extra (optional) .. code-block:: bash - python -c 'import re, sys; print(

[GitHub] [airflow] potiuk commented on a diff in pull request #29914: Ssh connection docs: Fix wrong escaping of the newline

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29914: URL: https://github.com/apache/airflow/pull/29914#discussion_r1125576552 ## docs/apache-airflow-providers-ssh/connections/ssh.rst: ## @@ -99,7 +99,7 @@ Extra (optional) .. code-block:: bash - python -c 'import re, sys; print(

[GitHub] [airflow] potiuk commented on a diff in pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29909: URL: https://github.com/apache/airflow/pull/29909#discussion_r1125576178 ## airflow/timetables/simple.py: ## @@ -108,6 +109,37 @@ def next_dagrun_info( return DagRunInfo.exact(run_after) +class ContinuousTimetable(_TrivialTimet

[GitHub] [airflow] potiuk commented on pull request #29913: Fix mapped tasks partial arguments when DAG default args are provided

2023-03-04 Thread via GitHub
potiuk commented on PR #29913: URL: https://github.com/apache/airflow/pull/29913#issuecomment-1454928157 cc: @uranusjr . This definitely needs your insight :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[airflow] branch main updated: `GoogleDriveHook`: Fixing log message + adding more verbose documentation (#29694)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f55b9576b1 `GoogleDriveHook`: Fixing log message +

[GitHub] [airflow] potiuk merged pull request #29694: `GoogleDriveHook`: Fixing log message + adding more verbose documentation

2023-03-04 Thread via GitHub
potiuk merged PR #29694: URL: https://github.com/apache/airflow/pull/29694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on pull request #29446: Scheduler, make stale DAG deactivation threshold configurable instead of using dag processing timeout

2023-03-04 Thread via GitHub
potiuk commented on PR #29446: URL: https://github.com/apache/airflow/pull/29446#issuecomment-1454927375 > > Rebased to account for workarounded issue with boto3. But seems the issue has been fixed @ephraimbuddy > > Thanks is this good to merge? Waiitng for @ephraimbuddy to rem

[airflow] branch main updated (035ad26d79 -> 88ed20a813)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 035ad26d79 Add "BOOLEAN" to type_map of MSSQLToGCSOperator, fix incorrect bit->int type conversion by specifying BIT f

[GitHub] [airflow] potiuk merged pull request #29609: Decouple production executor warning in dags UI

2023-03-04 Thread via GitHub
potiuk merged PR #29609: URL: https://github.com/apache/airflow/pull/29609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] mabrikan commented on pull request #29838: Remove replicas if KEDA is enabled

2023-03-04 Thread via GitHub
mabrikan commented on PR #29838: URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454925728 Done, @potiuk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] mabrikan closed pull request #29838: Remove replicas if KEDA is enabled

2023-03-04 Thread via GitHub
mabrikan closed pull request #29838: Remove replicas if KEDA is enabled URL: https://github.com/apache/airflow/pull/29838 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [airflow] tqtensor commented on pull request #29181: feat: add Dataproc preemptibility to ClusterGenerator class

2023-03-04 Thread via GitHub
tqtensor commented on PR #29181: URL: https://github.com/apache/airflow/pull/29181#issuecomment-1454922915 Nice to hear from you, @potiuk; I will reopen the PR again. I understand and acknowledge your message from the video. šŸ˜€ -- This is an automated message from the Apache Git Service. T

[GitHub] [airflow] potiuk commented on pull request #29181: feat: add Dataproc preemptibility to ClusterGenerator class

2023-03-04 Thread via GitHub
potiuk commented on PR #29181: URL: https://github.com/apache/airflow/pull/29181#issuecomment-1454921460 (also @mcoca-dst you can just open and re-submit similar change again if @tqtensor's experience is so bad that he decides not to try again, this feature indeed ssems useful for dataproc

[GitHub] [airflow] eladkal commented on a diff in pull request #29694: `GoogleDriveHook`: Fixing log message + adding more verbose documentation

2023-03-04 Thread via GitHub
eladkal commented on code in PR #29694: URL: https://github.com/apache/airflow/pull/29694#discussion_r1125572952 ## airflow/providers/google/suite/hooks/drive.py: ## @@ -243,8 +292,21 @@ def upload_file( .create(body=file_metadata, media_body=media, fields="id", su

[GitHub] [airflow] potiuk commented on pull request #29181: feat: add Dataproc preemptibility to ClusterGenerator class

2023-03-04 Thread via GitHub
potiuk commented on PR #29181: URL: https://github.com/apache/airflow/pull/29181#issuecomment-1454920778 Because likely you were unlucky and not patient enough. When you have 100s of PRs to look at you can miss some of those. Feel free to re-open it and try again. And you can watch my talk

[GitHub] [airflow] tqtensor commented on pull request #29181: feat: add Dataproc preemptibility to ClusterGenerator class

2023-03-04 Thread via GitHub
tqtensor commented on PR #29181: URL: https://github.com/apache/airflow/pull/29181#issuecomment-1454919788 I used to implement this fix a few weeks ago and then created a PR to merge. But I wonder why no one reviewed it even though I asked in the Slack channel to review PR. So finally, I cl

[GitHub] [airflow] michaelmicheal commented on pull request #29446: Scheduler, make stale DAG deactivation threshold configurable instead of using dag processing timeout

2023-03-04 Thread via GitHub
michaelmicheal commented on PR #29446: URL: https://github.com/apache/airflow/pull/29446#issuecomment-1454919583 > Rebased to account for workarounded issue with boto3. But seems the issue has been fixed @ephraimbuddy Thanks is this good to merge? -- This is an automated message fr

[GitHub] [airflow] potiuk commented on pull request #29609: Decouple production executor warning in dags UI

2023-03-04 Thread via GitHub
potiuk commented on PR #29609: URL: https://github.com/apache/airflow/pull/29609#issuecomment-1454918303 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[airflow] branch main updated: Add "BOOLEAN" to type_map of MSSQLToGCSOperator, fix incorrect bit->int type conversion by specifying BIT fields explicitly (#29902)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 035ad26d79 Add "BOOLEAN" to type_map of MSSQLToGCSO

[GitHub] [airflow] potiuk merged pull request #29902: Add "BOOLEAN" to type map of MSSQLToGCSOperator and fix incorrect BIT->INT conversion

2023-03-04 Thread via GitHub
potiuk merged PR #29902: URL: https://github.com/apache/airflow/pull/29902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk closed issue #11874: MSSQLToBigQuery incorrect type conversion bit-->integer

2023-03-04 Thread via GitHub
potiuk closed issue #11874: MSSQLToBigQuery incorrect type conversion bit-->integer URL: https://github.com/apache/airflow/issues/11874 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [airflow] potiuk commented on pull request #29805: Minor improvements to Param docs

2023-03-04 Thread via GitHub
potiuk commented on PR #29805: URL: https://github.com/apache/airflow/pull/29805#issuecomment-1454912849 doc build is failing - I recomend to run `breeze build-docs` before rebasing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [airflow] potiuk commented on a diff in pull request #29694: `GoogleDriveHook`: Fixing log message + adding more verbose documentation

2023-03-04 Thread via GitHub
potiuk commented on code in PR #29694: URL: https://github.com/apache/airflow/pull/29694#discussion_r1125569580 ## airflow/providers/google/suite/hooks/drive.py: ## @@ -243,8 +292,21 @@ def upload_file( .create(body=file_metadata, media_body=media, fields="id", sup

[GitHub] [airflow] hussein-awala commented on pull request #29052: Fix KubernetesPodOperator xcom push when `get_logs=False`

2023-03-04 Thread via GitHub
hussein-awala commented on PR #29052: URL: https://github.com/apache/airflow/pull/29052#issuecomment-1454912178 @eladkal is it too late to add this fix to cncf.kubernetes release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[airflow] branch main updated: Google Cloud Providers - Fix _MethodDefault deepcopy failure (#29518)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5a632f78eb Google Cloud Providers - Fix _MethodDefa

[GitHub] [airflow] potiuk closed issue #28751: KubernetesExecutor leaves failed pods due to deepcopy issue with Google providers

2023-03-04 Thread via GitHub
potiuk closed issue #28751: KubernetesExecutor leaves failed pods due to deepcopy issue with Google providers URL: https://github.com/apache/airflow/issues/28751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [airflow] potiuk merged pull request #29518: Google Cloud Providers - Fix _MethodDefault deepcopy failure

2023-03-04 Thread via GitHub
potiuk merged PR #29518: URL: https://github.com/apache/airflow/pull/29518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: Mask out non-access bits when comparion file modes (#29886)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ec31648be4 Mask out non-access bits when comparion

[GitHub] [airflow] potiuk merged pull request #29886: Mask out non-access bits when comparing file modes

2023-03-04 Thread via GitHub
potiuk merged PR #29886: URL: https://github.com/apache/airflow/pull/29886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: Updates to check_files to produce a more useful Dockerfile (#29469)

2023-03-04 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9845d7b565 Updates to check_files to produce a more

[GitHub] [airflow] potiuk merged pull request #29469: Updates to provider release verification documentation and check_files to produce a more useful Dockerfile

2023-03-04 Thread via GitHub
potiuk merged PR #29469: URL: https://github.com/apache/airflow/pull/29469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch constraints-main updated: Updating constraints. Github run id:4332975853

2023-03-04 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new fc11f55e0a Updating con

[GitHub] [airflow] potiuk commented on pull request #24588: add: container securityContext not available in podSecurityContext

2023-03-04 Thread via GitHub
potiuk commented on PR #24588: URL: https://github.com/apache/airflow/pull/24588#issuecomment-1454909252 Still errors . I stronly recommend installing `pre-commit` and using it. Then a number of iterations you would have to do would be much smaller . -- This is an automated message from t

[GitHub] [airflow] potiuk commented on pull request #29838: Remove replicas if KEDA is enabled

2023-03-04 Thread via GitHub
potiuk commented on PR #29838: URL: https://github.com/apache/airflow/pull/29838#issuecomment-1454904373 needs static checks fixes and rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] hussein-awala commented on pull request #29762: Add an example for dynamic task mapping with non-TaskFlow operator

2023-03-04 Thread via GitHub
hussein-awala commented on PR #29762: URL: https://github.com/apache/airflow/pull/29762#issuecomment-1454902445 @josh-fell @potiuk The test `test_deserialization_across_process` failes because of [this assertion](https://github.com/apache/airflow/blob/main/tests/serialization/test_dag_seri

[GitHub] [airflow] potiuk closed issue #29872: Task running again after finishing getting a SUCCESS

2023-03-04 Thread via GitHub
potiuk closed issue #29872: Task running again after finishing getting a SUCCESS URL: https://github.com/apache/airflow/issues/29872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

  1   2   3   >