[GitHub] [airflow] uranusjr commented on pull request #30083: Account for change in UTC offset when performing next schedule calculations

2023-03-15 Thread via GitHub
uranusjr commented on PR #30083: URL: https://github.com/apache/airflow/pull/30083#issuecomment-1471387016 Many things to fix. Actually the test failure is DST related, which strongly indicates the logic is wrong (in the sense of not being backward compatible). -- This is an automated mes

[GitHub] [airflow] uranusjr commented on a diff in pull request #27106: Fix warning in airflow tasks test command regarding absence of data_interval

2023-03-15 Thread via GitHub
uranusjr commented on code in PR #27106: URL: https://github.com/apache/airflow/pull/27106#discussion_r1138174686 ## airflow/cli/commands/task_command.py: ## @@ -126,10 +126,12 @@ def _get_dag_run( dag_run = DagRun(dag.dag_id, run_id=exec_date_or_run_id, execution_date

[GitHub] [airflow] josh-fell opened a new pull request, #30138: Remove required validations in Hashicorp Vault conn form

2023-03-15 Thread via GitHub
josh-fell opened a new pull request, #30138: URL: https://github.com/apache/airflow/pull/30138 #30057 added a couple field validators in a new connection form for Hashicorp Vault. Behind the scenes, all connection form data is persisted upon submission. When creating a new connection that i

[GitHub] [airflow] uranusjr commented on a diff in pull request #29094: Add `max_active_tis_per_dagrun` for Dynamic Task Mapping

2023-03-15 Thread via GitHub
uranusjr commented on code in PR #29094: URL: https://github.com/apache/airflow/pull/29094#discussion_r1138123017 ## airflow/jobs/scheduler_job.py: ## @@ -221,26 +221,31 @@ def is_alive(self, grace_multiplier: float | None = None) -> bool: def __get_concurrency_maps(

[GitHub] [airflow] uranusjr commented on a diff in pull request #29094: Add `max_active_tis_per_dagrun` for Dynamic Task Mapping

2023-03-15 Thread via GitHub
uranusjr commented on code in PR #29094: URL: https://github.com/apache/airflow/pull/29094#discussion_r1138123017 ## airflow/jobs/scheduler_job.py: ## @@ -221,26 +221,31 @@ def is_alive(self, grace_multiplier: float | None = None) -> bool: def __get_concurrency_maps(

[GitHub] [airflow] uranusjr commented on a diff in pull request #29094: Add `max_active_tis_per_dagrun` for Dynamic Task Mapping

2023-03-15 Thread via GitHub
uranusjr commented on code in PR #29094: URL: https://github.com/apache/airflow/pull/29094#discussion_r1138121909 ## airflow/jobs/scheduler_job.py: ## @@ -221,26 +221,31 @@ def is_alive(self, grace_multiplier: float | None = None) -> bool: def __get_concurrency_maps(

[GitHub] [airflow] uranusjr commented on pull request #30105: [minor] use repr() instead of str() for clarifying error class name on dagbag

2023-03-15 Thread via GitHub
uranusjr commented on PR #30105: URL: https://github.com/apache/airflow/pull/30105#issuecomment-1471311853 Hmm, this works for those, but may not for other exception classes that format the error message otherwise. Perhaps it is better to explicitly add the exception class to the error mess

[GitHub] [airflow] SamWheating commented on a diff in pull request #29909: Adding ContinuousTimetable and support for @continuous schedule_interval

2023-03-15 Thread via GitHub
SamWheating commented on code in PR #29909: URL: https://github.com/apache/airflow/pull/29909#discussion_r1138094579 ## airflow/models/dag.py: ## @@ -546,6 +553,9 @@ def __init__( self.last_loaded = timezone.utcnow() self.safe_dag_id = dag_id.replace(".", "__do

[GitHub] [airflow] uranusjr commented on a diff in pull request #30113: Allow setting the DagRun state in create DAGRun API

2023-03-15 Thread via GitHub
uranusjr commented on code in PR #30113: URL: https://github.com/apache/airflow/pull/30113#discussion_r1138093946 ## tests/api_connexion/endpoints/test_dag_run_endpoint.py: ## Review Comment: Should we have a test case for an invalid state value? -- This is an automated

[GitHub] [airflow] gbonazzoli opened a new issue, #30137: Airflow Helm Chart 1.8.0 With Airflow 2.5.1

2023-03-15 Thread via GitHub
gbonazzoli opened a new issue, #30137: URL: https://github.com/apache/airflow/issues/30137 ### Apache Airflow version 2.5.2 ### What happened Everything works fine, but there are the following warning: ``` airflow@airflow-crm-worker-0:/opt/airflow$ airflow versi

[GitHub] [airflow] yuqian90 commented on pull request #29971: Fix some long known Graph View UI problems

2023-03-15 Thread via GitHub
yuqian90 commented on PR #29971: URL: https://github.com/apache/airflow/pull/29971#issuecomment-1471208053 > @yuqian90 wdyt of expand/collapse like this? > > ![Mar-14-2023 23-13-36](https://user-images.githubusercontent.com/4600967/225196637-1d5cfb12-083f-42bb-842e-8ef152d25578.gif)

[airflow] branch main updated (051cd2938e -> 2842a0f30b)

2023-03-15 Thread joshfell
This is an automated email from the ASF dual-hosted git repository. joshfell pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 051cd2938e Add removal of old RCs to RC release process (#30133) add 2842a0f30b Add custom_operator_name to @tas

[GitHub] [airflow] josh-fell merged pull request #30131: Add custom_operator_name to @task.sensor tasks

2023-03-15 Thread via GitHub
josh-fell merged PR #30131: URL: https://github.com/apache/airflow/pull/30131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[GitHub] [airflow] uranusjr commented on pull request #29842: Allow for templated args to be passed to the result_processor function in the GithubSensor fixing templated tags in GithubTagSensor

2023-03-15 Thread via GitHub
uranusjr commented on PR #29842: URL: https://github.com/apache/airflow/pull/29842#issuecomment-1471184980 There’s precedence of using `inspect` to check whether a function has a specific argument, and only pass extra values if it is present. We can implement that here so `template_fields`

[GitHub] [airflow] bbovenzi opened a new pull request, #30136: Remove duplicate Dag Details code

2023-03-15 Thread via GitHub
bbovenzi opened a new pull request, #30136: URL: https://github.com/apache/airflow/pull/30136 We were listing the Dag Runs Summary twice in the Grid -> Dag Details. Looks to have been an issue when rebasing the new graph PR. --- **^ Add meaningful description above** Read th

[airflow] branch main updated (14d9e90b3a -> 051cd2938e)

2023-03-15 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 14d9e90b3a Improve creating Vault connection from the UI and add documentation for this conn (#30057) add

[GitHub] [airflow] jedcunningham merged pull request #30133: Add removal of old RCs to RC release process

2023-03-15 Thread via GitHub
jedcunningham merged PR #30133: URL: https://github.com/apache/airflow/pull/30133 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] pingzh commented on a diff in pull request #30104: Allow customized rules to check if a file has dag

2023-03-15 Thread via GitHub
pingzh commented on code in PR #30104: URL: https://github.com/apache/airflow/pull/30104#discussion_r1137952986 ## docs/apache-airflow/core-concepts/dags.rst: ## @@ -165,6 +165,14 @@ While both DAG constructors get called when the file is accessed, only ``dag_1`` You can als

[airflow] branch main updated (6c4761aa37 -> 14d9e90b3a)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 6c4761aa37 add a describe step on failure in eks tests (#30134) add 14d9e90b3a Improve creating Vault connection f

[GitHub] [airflow] potiuk merged pull request #30057: Improve creating Vault connection from the UI and add documentation for this conn

2023-03-15 Thread via GitHub
potiuk merged PR #30057: URL: https://github.com/apache/airflow/pull/30057 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on a diff in pull request #30104: Allow customized rules to check if a file has dag

2023-03-15 Thread via GitHub
potiuk commented on code in PR #30104: URL: https://github.com/apache/airflow/pull/30104#discussion_r1137913254 ## docs/apache-airflow/core-concepts/dags.rst: ## @@ -165,6 +165,14 @@ While both DAG constructors get called when the file is accessed, only ``dag_1`` You can als

[airflow] branch main updated: add a describe step on failure in eks tests (#30134)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6c4761aa37 add a describe step on failure in eks te

[GitHub] [airflow] potiuk merged pull request #30134: add a describe step on failure in eks system tests

2023-03-15 Thread via GitHub
potiuk merged PR #30134: URL: https://github.com/apache/airflow/pull/30134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] github-actions[bot] commented on issue #19627: Providing a metadata secret conflicts with the use of pgbouncer

2023-03-15 Thread via GitHub
github-actions[bot] commented on issue #19627: URL: https://github.com/apache/airflow/issues/19627#issuecomment-1471015001 This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further

[GitHub] [airflow] github-actions[bot] commented on pull request #28291: Add script to move providers to a new directory structure

2023-03-15 Thread via GitHub
github-actions[bot] commented on PR #28291: URL: https://github.com/apache/airflow/pull/28291#issuecomment-1471014934 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] closed issue #28304: expand_kwargs does not handle update of dataset correctly when "outlets" parameter is used as kwargs

2023-03-15 Thread via GitHub
github-actions[bot] closed issue #28304: expand_kwargs does not handle update of dataset correctly when "outlets" parameter is used as kwargs URL: https://github.com/apache/airflow/issues/28304 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [airflow] github-actions[bot] commented on pull request #28292: Draft POC attempt to make a better structure for providers

2023-03-15 Thread via GitHub
github-actions[bot] commented on PR #28292: URL: https://github.com/apache/airflow/pull/28292#issuecomment-1471014912 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] github-actions[bot] commented on issue #28304: expand_kwargs does not handle update of dataset correctly when "outlets" parameter is used as kwargs

2023-03-15 Thread via GitHub
github-actions[bot] commented on issue #28304: URL: https://github.com/apache/airflow/issues/28304#issuecomment-1471014896 This issue has been closed because it has not received response from the issue author. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] github-actions[bot] commented on pull request #29223: Split installation of sdist providers into parallel chunks

2023-03-15 Thread via GitHub
github-actions[bot] commented on PR #29223: URL: https://github.com/apache/airflow/pull/29223#issuecomment-1471014853 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

[GitHub] [airflow] TJaniF commented on pull request #29842: Allow for templated args to be passed to the result_processor function in the GithubSensor fixing templated tags in GithubTagSensor

2023-03-15 Thread via GitHub
TJaniF commented on PR #29842: URL: https://github.com/apache/airflow/pull/29842#issuecomment-1471013878 > > Users who are using the GitHubSensor directly and pass a `result_processor` function directly would either need to turn `allow_templates_in_result_processor` to False or add a `templ

[airflow] branch main updated (8d22828e25 -> f1e40cf799)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 8d22828e25 Fix `TriggerRuleDep` when the mapped tasks count is 0 (#30084) add f1e40cf799 Adding more information

[GitHub] [airflow] potiuk closed issue #30023: Variable with template is ambiguous, especially for new users

2023-03-15 Thread via GitHub
potiuk closed issue #30023: Variable with template is ambiguous, especially for new users URL: https://github.com/apache/airflow/issues/30023 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [airflow] potiuk merged pull request #30040: Adding more information regarding top level code

2023-03-15 Thread via GitHub
potiuk merged PR #30040: URL: https://github.com/apache/airflow/pull/30040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on pull request #29266: Add deferrable mode to GKEStartPodOperator

2023-03-15 Thread via GitHub
potiuk commented on PR #29266: URL: https://github.com/apache/airflow/pull/29266#issuecomment-1470999113 I have not followed too much the deferrable operators - I know it was somewhere in between Astronomer and Goole work :) and you worked, so I guess It would take more time for me to get f

[GitHub] [airflow] potiuk commented on a diff in pull request #30076: SLA callbacks no longer add files to the dag_processing manager queue

2023-03-15 Thread via GitHub
potiuk commented on code in PR #30076: URL: https://github.com/apache/airflow/pull/30076#discussion_r1137871955 ## airflow/dag_processing/manager.py: ## @@ -727,7 +740,8 @@ def _add_callback_to_queue(self, request: CallbackRequest): self._file_path_queue = colle

[GitHub] [airflow] potiuk commented on a diff in pull request #30076: SLA callbacks no longer add files to the dag_processing manager queue

2023-03-15 Thread via GitHub
potiuk commented on code in PR #30076: URL: https://github.com/apache/airflow/pull/30076#discussion_r1137864223 ## airflow/dag_processing/manager.py: ## @@ -1202,6 +1226,15 @@ def _kill_timed_out_processors(self): for proc in processors_to_remove: self._pro

[GitHub] [airflow] potiuk commented on pull request #29935: Fix for Windows

2023-03-15 Thread via GitHub
potiuk commented on PR #29935: URL: https://github.com/apache/airflow/pull/29935#issuecomment-1470955227 > I have read through the article but I was not able to find the extras that do not require to install anything for the setup to run properly. Could you give me some directions on what t

[airflow] branch main updated (66b5f90f45 -> 8d22828e25)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 66b5f90f45 Update workday example (#30026) add 8d22828e25 Fix `TriggerRuleDep` when the mapped tasks count is 0 (

[GitHub] [airflow] potiuk closed issue #30073: Task group expand fails on empty list at get_relevant_upstream_map_indexes

2023-03-15 Thread via GitHub
potiuk closed issue #30073: Task group expand fails on empty list at get_relevant_upstream_map_indexes URL: https://github.com/apache/airflow/issues/30073 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [airflow] potiuk merged pull request #30084: Fix `TriggerRuleDep` when the mapped tasks count is 0

2023-03-15 Thread via GitHub
potiuk merged PR #30084: URL: https://github.com/apache/airflow/pull/30084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on pull request #30026: Update workday example

2023-03-15 Thread via GitHub
potiuk commented on PR #30026: URL: https://github.com/apache/airflow/pull/30026#issuecomment-1470950100 > Sorry Jarek...I didn't realize the sample code was being used in tests as well. I've updated the corresponding test code and all checks have passed. No wories. This is normal :)

[airflow] branch main updated (f18c1111be -> 66b5f90f45)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f18cbe Explicit skipped states list for ExternalTaskSensor (#29933) add 66b5f90f45 Update workday example (#30

[GitHub] [airflow] potiuk commented on pull request #29910: add annotations to configmaps

2023-03-15 Thread via GitHub
potiuk commented on PR #29910: URL: https://github.com/apache/airflow/pull/29910#issuecomment-1470949360 > @hussein-awala I installed pre-commit to fix static checks and committed changes. There are few more suggestions from @hussein-awala -- This is an automated message from the

[GitHub] [airflow] potiuk merged pull request #30026: Update workday example

2023-03-15 Thread via GitHub
potiuk merged PR #30026: URL: https://github.com/apache/airflow/pull/30026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on issue #29963: Task logs show 404 once the pods are gone

2023-03-15 Thread via GitHub
potiuk commented on issue #29963: URL: https://github.com/apache/airflow/issues/29963#issuecomment-1470947763 > I am aware that the pod no longer exists, but the logs are in the file system. > What I am trying to say is that airflow could recover the logs even if the pod has been deleted

[GitHub] [airflow] potiuk commented on pull request #27264: Attempt to add Python 3.11 support

2023-03-15 Thread via GitHub
potiuk commented on PR #27264: URL: https://github.com/apache/airflow/pull/27264#issuecomment-1470932110 > Snowflake 3.11 wheels are out https://github.com/snowflakedb/snowflake-connector-python/pull/1349/files referenced pull request is outdated Marked it as such -- This is an au

[airflow] branch main updated (feab463757 -> f18c1111be)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from feab463757 Add a new Airflow conf to specify a SSL ca cert for Kubernetes client (#30048) add f18cbe Explicit

[GitHub] [airflow] potiuk merged pull request #29933: Explicit skipped states list for ExternalTaskSensor

2023-03-15 Thread via GitHub
potiuk merged PR #29933: URL: https://github.com/apache/airflow/pull/29933 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] hussein-awala commented on pull request #30057: Improve creating Vault connection from the UI and add documentation for this conn

2023-03-15 Thread via GitHub
hussein-awala commented on PR #30057: URL: https://github.com/apache/airflow/pull/30057#issuecomment-1470929507 It should be fine now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on pull request #28943: Add handling logic on CeleryExecutor to reschedule task stuck in queued status

2023-03-15 Thread via GitHub
potiuk commented on PR #28943: URL: https://github.com/apache/airflow/pull/28943#issuecomment-1470928814 There some tests to fix though -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[airflow] branch main updated: Add a new Airflow conf to specify a SSL ca cert for Kubernetes client (#30048)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new feab463757 Add a new Airflow conf to specify a SSL

[GitHub] [airflow] potiuk merged pull request #30048: Add a new Airflow conf to specify a SSL ca cert for Kubernetes client

2023-03-15 Thread via GitHub
potiuk merged PR #30048: URL: https://github.com/apache/airflow/pull/30048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk closed issue #8019: Custom SSL CA CERTIFICATE by Configuration for Kubernetes Executor

2023-03-15 Thread via GitHub
potiuk closed issue #8019: Custom SSL CA CERTIFICATE by Configuration for Kubernetes Executor URL: https://github.com/apache/airflow/issues/8019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[airflow] branch main updated (5a3be7256b -> 39cfc67cad)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 5a3be7256b Handling project location param on async BigQuery dts trigger (#29786) add 39cfc67cad Update scripts t

[GitHub] [airflow] potiuk merged pull request #30054: Update scripts to make our pgbouncer-related scripts multiplatform

2023-03-15 Thread via GitHub
potiuk merged PR #30054: URL: https://github.com/apache/airflow/pull/30054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk closed issue #29967: Build our supporting images for chart in multi-platform versions

2023-03-15 Thread via GitHub
potiuk closed issue #29967: Build our supporting images for chart in multi-platform versions URL: https://github.com/apache/airflow/issues/29967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [airflow] potiuk commented on pull request #30057: Improve creating Vault connection from the UI and add documentation for this conn

2023-03-15 Thread via GitHub
potiuk commented on PR #30057: URL: https://github.com/apache/airflow/pull/30057#issuecomment-1470921301 There is a conflict to reseolve though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [airflow] potiuk closed issue #19681: Can't launch Redis container on a cluster enforcing MustRunAsNonRoot policy

2023-03-15 Thread via GitHub
potiuk closed issue #19681: Can't launch Redis container on a cluster enforcing MustRunAsNonRoot policy URL: https://github.com/apache/airflow/issues/19681 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [airflow] potiuk commented on issue #19681: Can't launch Redis container on a cluster enforcing MustRunAsNonRoot policy

2023-03-15 Thread via GitHub
potiuk commented on issue #19681: URL: https://github.com/apache/airflow/issues/19681#issuecomment-1470918073 closing then. @tomasgatial please check if it fixes it, and let us know- we can always re-open. -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [airflow] VinceLegendre commented on pull request #28525: Add CloudRunExecuteJobOperator

2023-03-15 Thread via GitHub
VinceLegendre commented on PR #28525: URL: https://github.com/apache/airflow/pull/28525#issuecomment-1470915296 I'll try to fix tests in the coming days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[airflow] branch main updated: Handling project location param on async BigQuery dts trigger (#29786)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5a3be7256b Handling project location param on async

[GitHub] [airflow] potiuk merged pull request #29786: Handling project location param on async BigQuery dts trigger

2023-03-15 Thread via GitHub
potiuk merged PR #29786: URL: https://github.com/apache/airflow/pull/29786 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on a diff in pull request #30054: Update scripts to make our pgbouncer-related scripts multiplatform

2023-03-15 Thread via GitHub
potiuk commented on code in PR #30054: URL: https://github.com/apache/airflow/pull/30054#discussion_r1137798001 ## chart/newsfragments/30054.improvement.rst: ## @@ -0,0 +1 @@ +The pgbouncer and pgbouncer-images are now based on newer software and os versions. Thye also have nat

[GitHub] [airflow] potiuk commented on pull request #30133: Add removal of old RCs to RC release process

2023-03-15 Thread via GitHub
potiuk commented on PR #30133: URL: https://github.com/apache/airflow/pull/30133#issuecomment-1470826417 > Does it cover alao providers/helm RCs? Providers are deleted already as part of the process. -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] potiuk merged pull request #30002: Add capability of iterating locally on constraint files for CI image

2023-03-15 Thread via GitHub
potiuk merged PR #30002: URL: https://github.com/apache/airflow/pull/30002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] eladkal commented on pull request #30003: Move and convert all AWS example dags to system tests

2023-03-15 Thread via GitHub
eladkal commented on PR #30003: URL: https://github.com/apache/airflow/pull/30003#issuecomment-1470818675 > Yes it's a valid worry. But maybe we could make it clearer by slight modification of the pytest code so that it will raise Skip exception for those tests unless we setup some variable

[airflow] branch main updated (f5ed6ae67d -> b87cbc388b)

2023-03-15 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from f5ed6ae67d Update 2.5.2 release date (#30135) add b87cbc388b Ignore error when changing log folder permissions (#3

[GitHub] [airflow] potiuk closed issue #29112: "Operation not permitted" error when chmod on log folder

2023-03-15 Thread via GitHub
potiuk closed issue #29112: "Operation not permitted" error when chmod on log folder URL: https://github.com/apache/airflow/issues/29112 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk merged pull request #30123: Ignore error when changing log folder permissions

2023-03-15 Thread via GitHub
potiuk merged PR #30123: URL: https://github.com/apache/airflow/pull/30123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on pull request #30003: Move and convert all AWS example dags to system tests

2023-03-15 Thread via GitHub
potiuk commented on PR #30003: URL: https://github.com/apache/airflow/pull/30003#issuecomment-1470810141 > I'm with Elad on this. Having just a couple of examples left in examples folder is rather confusing for user's pov. Providing all examples / system tests in one place makes it easier t

[GitHub] [airflow] potiuk commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
potiuk commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137742117 ## airflow/configuration.py: ## Review Comment: I am ok with whatever you guys agree to :) -- This is an automated message from the Apache Git Service. To re

[airflow-site] branch gh-pages updated: Deploying to gh-pages from @ bc075d5a2049fed3ea71f27fac08712b043beb18 🚀

2023-03-15 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch gh-pages in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/gh-pages by this push: new 1ebf109cb0 Deploying to gh-pages f

[GitHub] [airflow] potiuk commented on issue #27292: Support for Python 3.11 for Google Provider (upgrading all dependencies)

2023-03-15 Thread via GitHub
potiuk commented on issue #27292: URL: https://github.com/apache/airflow/issues/27292#issuecomment-1470793624 There is a WIP from Google team to upgrade the SDKs https://github.com/apache/airflow/pull/30067 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [airflow] potiuk commented on issue #29948: Status of testing Providers that were prepared on March 07, 2023

2023-03-15 Thread via GitHub
potiuk commented on issue #29948: URL: https://github.com/apache/airflow/issues/29948#issuecomment-1470788257 > @eladkal Did this pull request got forgotten? #29694 Please let me know if I should do something about it to make it visible. Only Hashicorp ad-hoc release was released then

[airflow-site] branch main updated: Update release date for 2.5.2 (#755)

2023-03-15 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow-site.git The following commit(s) were added to refs/heads/main by this push: new bc075d5a20 Update release date for 2.5

[GitHub] [airflow-site] pierrejeambrun merged pull request #755: Update release date for 2.5.2

2023-03-15 Thread via GitHub
pierrejeambrun merged PR #755: URL: https://github.com/apache/airflow-site/pull/755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[GitHub] [airflow] amoghrajesh commented on pull request #29809: Adding configuration to control retry parameters for k8s api client

2023-03-15 Thread via GitHub
amoghrajesh commented on PR #29809: URL: https://github.com/apache/airflow/pull/29809#issuecomment-1470782793 @hussein-awala i think we should go back to throwing an exception when the type is invalid for the retry parameters. I need some help in figuring out a way to fix the other f

[GitHub] [airflow] hussein-awala commented on a diff in pull request #29929: Adding more information to kubernetes executor logs

2023-03-15 Thread via GitHub
hussein-awala commented on code in PR #29929: URL: https://github.com/apache/airflow/pull/29929#discussion_r1137720316 ## airflow/kubernetes/kubernetes_helper_functions.py: ## @@ -119,3 +120,7 @@ def annotations_to_key(annotations: dict[str, str]) -> TaskInstanceKey: t

[airflow] branch v2-5-test updated: Update 2.5.2 release date (#30135)

2023-03-15 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch v2-5-test in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/v2-5-test by this push: new cfaa9eac8a Update 2.5.2 release d

[airflow] branch main updated (76a884c552 -> f5ed6ae67d)

2023-03-15 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 76a884c552 Ensure that `dag.partial_subset` doesn't mutate task group properties (#30129) add f5ed6ae67d

[GitHub] [airflow] pierrejeambrun merged pull request #30135: Update 2.5.2 release date

2023-03-15 Thread via GitHub
pierrejeambrun merged PR #30135: URL: https://github.com/apache/airflow/pull/30135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@a

[GitHub] [airflow] ashb closed issue #26059: [Graph view] After clearing the task (and its downstream tasks) in a task group the task group becomes disconnected from the dag

2023-03-15 Thread via GitHub
ashb closed issue #26059: [Graph view] After clearing the task (and its downstream tasks) in a task group the task group becomes disconnected from the dag URL: https://github.com/apache/airflow/issues/26059 -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [airflow] ashb merged pull request #30129: Ensure that `dag.partial_subset` doesn't mutate task group properties

2023-03-15 Thread via GitHub
ashb merged PR #30129: URL: https://github.com/apache/airflow/pull/30129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apa

[airflow] branch main updated (4dde8ececf -> 76a884c552)

2023-03-15 Thread ash
This is an automated email from the ASF dual-hosted git repository. ash pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4dde8ececf Update Airflow version to 2.5.2 (#30111) add 76a884c552 Ensure that `dag.partial_subset` doesn't mutate ta

[airflow] branch main updated (c7488334cd -> 4dde8ececf)

2023-03-15 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from c7488334cd Improve install instruction for test package (#30030) add 4dde8ececf Update Airflow version to

[GitHub] [airflow] pierrejeambrun merged pull request #30111: Update Airflow version to 2.5.2

2023-03-15 Thread via GitHub
pierrejeambrun merged PR #30111: URL: https://github.com/apache/airflow/pull/30111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@a

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
jedcunningham commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137705279 ## airflow/configuration.py: ## Review Comment: I'm not in favor of moving it. I'd rather see it actually be a proper config entry `e.g. [webserver] confi

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29929: Adding more information to kubernetes executor logs

2023-03-15 Thread via GitHub
amoghrajesh commented on code in PR #29929: URL: https://github.com/apache/airflow/pull/29929#discussion_r1137703660 ## airflow/kubernetes/kubernetes_helper_functions.py: ## @@ -119,3 +120,7 @@ def annotations_to_key(annotations: dict[str, str]) -> TaskInstanceKey: try

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
amoghrajesh commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137699588 ## airflow/configuration.py: ## Review Comment: I have a proposal here. How about we do this: 1. We have a constant called AIRFLOW_WEBSERVER_CONFIG ar

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
jedcunningham commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137698124 ## airflow/configuration.py: ## Review Comment: So to summarize, I'd rather we make it actually configurable than to just move it to a dir that happens to

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
jedcunningham commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137694479 ## airflow/configuration.py: ## Review Comment: Ah, TIL about AIRFLOW_HOME/config being added to sys.path automatically 🤦‍♂️ Makes a little more sense now

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
amoghrajesh commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137688177 ## airflow/configuration.py: ## Review Comment: Thanks for the review. I am trying to make the webserver config file rather sit in the config directo

[airflow] branch main updated (b8ab594130 -> c7488334cd)

2023-03-15 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from b8ab594130 Remove "boilerplate" from all taskflow decorators (#30118) add c7488334cd Improve install instr

[GitHub] [airflow] pierrejeambrun merged pull request #30030: Improve install instruction for test package

2023-03-15 Thread via GitHub
pierrejeambrun merged PR #30030: URL: https://github.com/apache/airflow/pull/30030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@a

[GitHub] [airflow] jedcunningham commented on a diff in pull request #29926: Making webserver config customisable

2023-03-15 Thread via GitHub
jedcunningham commented on code in PR #29926: URL: https://github.com/apache/airflow/pull/29926#discussion_r1137660553 ## airflow/configuration.py: ## Review Comment: This feels a little half-baked. - This doesn't actually make the path configurable, just moves it un

[GitHub] [airflow] vandonr-amz opened a new pull request, #30134: add a describe step on failure in eks system tests

2023-03-15 Thread via GitHub
vandonr-amz opened a new pull request, #30134: URL: https://github.com/apache/airflow/pull/30134 we've seen that every once in a while, an eks system test will fail with a timeout on the pod starting. Since we delete all resources in the teardown, we're pretty clueless on what's happeni

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30129: Ensure that `dag.partial_subset` doesn't mutate task group properties

2023-03-15 Thread via GitHub
jedcunningham commented on code in PR #30129: URL: https://github.com/apache/airflow/pull/30129#discussion_r1137644676 ## airflow/models/dag.py: ## @@ -2215,29 +2215,40 @@ def _deepcopy_task(t) -> Operator: def filter_task_group(group, parent_group): """E

[GitHub] [airflow] shubham22 commented on pull request #30003: Move and convert all AWS example dags to system tests

2023-03-15 Thread via GitHub
shubham22 commented on PR #30003: URL: https://github.com/apache/airflow/pull/30003#issuecomment-1470643869 I'm with Elad on this. Having just a couple of examples left in examples folder is rather confusing for user's pov. Providing all examples / system tests in one place makes it easier

[GitHub] [airflow] jedcunningham commented on a diff in pull request #30111: Update Airflow version to 2.5.2

2023-03-15 Thread via GitHub
jedcunningham commented on code in PR #30111: URL: https://github.com/apache/airflow/pull/30111#discussion_r1137613768 ## RELEASE_NOTES.rst: ## @@ -21,6 +21,114 @@ .. towncrier release notes start +Airflow 2.5.2 (2023-03-13) Review Comment: Oh, yes, good call. -- Th

[GitHub] [airflow] eladkal commented on pull request #30003: Move and convert all AWS example dags to system tests

2023-03-15 Thread via GitHub
eladkal commented on PR #30003: URL: https://github.com/apache/airflow/pull/30003#issuecomment-1470603601 The current state where we have examples speared throughout the project is not intuitive. Which is why I raised this as an issue https://github.com/apache/airflow/issues/22438#issuecomm

  1   2   3   >