rohan472000 commented on issue #30465:
URL: https://github.com/apache/airflow/issues/30465#issuecomment-1496977059
@potiuk well i m using wsl2, but I encountered some problems in Ubuntu
distro whereas Ubuntu 22.0.4 is working fine with commands, also after any
installation or any changes, I
pankajastro commented on issue #30427:
URL: https://github.com/apache/airflow/issues/30427#issuecomment-1496974054
https://github.com/apache/airflow/pull/28850
https://github.com/apache/airflow/pull/30132
https://github.com/apache/airflow/pull/30091 looks good. thank you!
--
This is an a
ephraimbuddy commented on PR #30259:
URL: https://github.com/apache/airflow/pull/30259#issuecomment-1496971689
Airflow best practices on Variables:
https://airflow.apache.org/docs/apache-airflow/stable/best-practices.html#airflow-variables.
Didn't see that mentioned in the discussions and
potiuk commented on issue #30465:
URL: https://github.com/apache/airflow/issues/30465#issuecomment-1496959247
Fix has been merged. It *should* work now natively
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
boring-cyborg[bot] commented on issue #30480:
URL: https://github.com/apache/airflow/issues/30480#issuecomment-1496956421
Thanks for opening your first issue here! Be sure to follow the issue
template! If you are willing to raise PR to address this issue please do so, no
need to wait for ap
rahulsinha07 opened a new issue, #30480:
URL: https://github.com/apache/airflow/issues/30480
### Apache Airflow version
2.5.3
### What happened
I am trying to run a Dag with MSSQL version 19, backend and airflow version
as 2.5.0
#below is the DAG: Define the DAG w
tquazi commented on PR #30478:
URL: https://github.com/apache/airflow/pull/30478#issuecomment-1496948971
fyi @eladkal @pierrejeambrun Please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tquazi commented on PR #30478:
URL: https://github.com/apache/airflow/pull/30478#issuecomment-1496944187
Here is the screenshot of the UI Layout:
![image](https://user-images.githubusercontent.com/1306697/229990293-801a00b2-a37d-4b68-9b54-10bf58e3a85b.png)
--
This is an automated m
tquazi opened a new pull request, #30478:
URL: https://github.com/apache/airflow/pull/30478
closes: #30220
This pull request adds ability to mark task groups as success/failure and
have that propagate to the tasks within that task group. This feature is
designed to provide a more
tquazi closed pull request #30453: Mark Task Groups as Success/Failure
URL: https://github.com/apache/airflow/pull/30453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
harishkesavarao commented on PR #30477:
URL: https://github.com/apache/airflow/pull/30477#issuecomment-1496931467
@hussein-awala to avoid the UI rebase bug causing a
[problem](https://github.com/apache/airflow/pull/30428#discussion_r1157785329),
what did you do to locally clean your branch
rajaths010494 commented on code in PR #29300:
URL: https://github.com/apache/airflow/pull/29300#discussion_r1158021813
##
tests/providers/amazon/aws/deferrable/hooks/test_batch_client.py:
##
@@ -0,0 +1,213 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
tnk-ysk commented on issue #30427:
URL: https://github.com/apache/airflow/issues/30427#issuecomment-1496907781
Thank you @eladkal
I tested again using the GOOGLE_APPLICATION_CREDENTIALS environment.
#29937 look good.
--
This is an automated message from the Apache Git Service.
To re
harishkesavarao commented on PR #30477:
URL: https://github.com/apache/airflow/pull/30477#issuecomment-1496889489
@potiuk @hussein-awala @alexott @eladkal @josh-fell @bilalaslamseattle
@o-nikolas can you please review my new PR here since #30428 was almost
approved but ran into the git UI r
ferruzzi commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157996409
##
tests/providers/amazon/aws/sensors/test_dynamodb.py:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
ferruzzi commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157996021
##
tests/providers/amazon/aws/sensors/test_dynamodb.py:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
harishkesavarao opened a new pull request, #30477:
URL: https://github.com/apache/airflow/pull/30477
Databricks SQL Sensor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ferruzzi commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157995247
##
tests/providers/amazon/aws/sensors/test_dynamodb.py:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
ferruzzi commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157995247
##
tests/providers/amazon/aws/sensors/test_dynamodb.py:
##
@@ -0,0 +1,64 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lice
ferruzzi commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157994954
##
tests/providers/amazon/aws/sensors/test_dynamodb.py:
##
@@ -0,0 +1,129 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor lic
harishkesavarao closed pull request #30428: Databricks SQL Sensor
URL: https://github.com/apache/airflow/pull/30428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
boring-cyborg[bot] commented on PR #30472:
URL: https://github.com/apache/airflow/pull/30472#issuecomment-1496846735
Congratulations on your first Pull Request and welcome to the Apache Airflow
community! If you have any issues or are unsure about any anything please check
our Contribution
happilyeverafter95 opened a new pull request, #30472:
URL: https://github.com/apache/airflow/pull/30472
Similar to this PR except for a different operator:
https://github.com/apache/airflow/pull/30444
Add `s3_bucket` to the template fields for the S3 to SFTP operator
--
syedahsn commented on issue #30427:
URL: https://github.com/apache/airflow/issues/30427#issuecomment-1496812321
The `EC2CreateInstanceOperator` and `EC2TerminateInstanceOperator` are being
used in our system tests, and have been passing.
--
This is an automated message from the Apache Gi
mrichman commented on PR #28338:
URL: https://github.com/apache/airflow/pull/28338#issuecomment-1496759156
No idea what happened there! Commit
[b9cdc05](https://github.com/apache/airflow/pull/28338/commits/b9cdc05d3fc21084cb32835d4caead88ccfa633f)
should be correct.
--
This is an automat
github-actions[bot] commented on PR #28590:
URL: https://github.com/apache/airflow/pull/28590#issuecomment-1496752576
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #28946:
URL: https://github.com/apache/airflow/pull/28946#issuecomment-1496752528
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] commented on PR #29514:
URL: https://github.com/apache/airflow/pull/29514#issuecomment-1496752495
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
hussein-awala commented on issue #30334:
URL: https://github.com/apache/airflow/issues/30334#issuecomment-1496715590
I think that the two issues (this and #30333) are related, I will try to fix
them
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
o-nikolas commented on code in PR #30467:
URL: https://github.com/apache/airflow/pull/30467#discussion_r1157845180
##
docs/apache-airflow/authoring-and-scheduling/timezone.rst:
##
@@ -150,6 +150,13 @@ date will be converted to UTC using the timezone
associated with ``start_date
hussein-awala commented on issue #30427:
URL: https://github.com/apache/airflow/issues/30427#issuecomment-1496680399
I tested https://github.com/apache/airflow/pull/29772 with `S3TaskHandler`
and it works as expected.
Since it need an Airflow version >= 2.6.0, I had to create a subcla
mik-laj commented on PR #761:
URL: https://github.com/apache/airflow-site/pull/761#issuecomment-1496660277
What do you think about using a stable version in canonical links?
```
https://airflow.apache.org/docs/apache-airflow/stable/installation/index.html#using-released-sources
```
mik-laj commented on PR #761:
URL: https://github.com/apache/airflow-site/pull/761#issuecomment-1496655439
We can always use the `stable` version in canonical links.
`https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/index.html`
All old pages should have their equival
krzysztof-kwitt commented on PR #761:
URL: https://github.com/apache/airflow-site/pull/761#issuecomment-1496654349
We can always use the `stable` version in canonical links.
`https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/index.html`
All old pages should have their
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch constraints-main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/constraints-main by this push:
new 12a1b28031 Updating con
eladkal commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157801186
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
There are still leftovers of unrelated changes that needs to be cleaned
--
This i
harishkesavarao commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157800681
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
I will follow what @hussein-awala did to clean this up.
--
This is an aut
harishkesavarao commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157798523
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
Thank you for letting me know @potiuk. Is there a remediation path to
resolv
syun64 commented on PR #13265:
URL: https://github.com/apache/airflow/pull/13265#issuecomment-1496631859
Just following up on my own bug report on this PR for anyone who's facing a
similar issue: I wasn't able to find the root cause for my issue, but I was
able to resolve the issue by disab
potiuk commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157788031
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
Yeah seems liek a recurring issue last few days
https://apache-airflow.slack.com/arch
hussein-awala commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157785329
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
@potiuk I had the same problem 4 days ago (#29913), I had to clean it
locally
hussein-awala commented on code in PR #30418:
URL: https://github.com/apache/airflow/pull/30418#discussion_r1157780648
##
tests/providers/neo4j/hooks/test_neo4j.py:
##
@@ -101,3 +103,33 @@ def test_run_without_schema(self, mock_graph_database):
)
sessio
ferruzzi commented on PR #28338:
URL: https://github.com/apache/airflow/pull/28338#issuecomment-1496615763
I think you forgot to commit the unit test, it's still the same one you had
that wasn't working AFAICT. The diff for
https://github.com/apache/airflow/pull/28338/commits/face27835e457
mrichman commented on PR #28338:
URL: https://github.com/apache/airflow/pull/28338#issuecomment-1496613321
Thank you so much @ferruzzi my unit test passes now! Please let me know if I
need to do anything else before this can move upstream.
--
This is an automated message from the Apache G
mrichman commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157773700
##
airflow/providers/amazon/aws/sensors/dynamodb.py:
##
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
vincbeck commented on PR #30374:
URL: https://github.com/apache/airflow/pull/30374#issuecomment-1496600383
> BTW I assume we need `{pr_number}.significant.rst` entry for this one?
I just added it
--
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from c20f6906f8 Update MANIFEST_TEMPLATE.in.jinja2 (#30431)
add d23a3bbed8 Add mechanism to suspend providers (#30422)
potiuk merged PR #30422:
URL: https://github.com/apache/airflow/pull/30422
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on code in PR #30422:
URL: https://github.com/apache/airflow/pull/30422#discussion_r1157758351
##
airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst:
##
Review Comment:
BTW. My philosophy is that the docs for contributors, should be as close as
possib
potiuk commented on PR #761:
URL: https://github.com/apache/airflow-site/pull/761#issuecomment-1496593374
That's an interesting idea @mik-laj :) . It's not exactly why canonical was
created for, but it might do it in our case. However this is significantly more
complex to implement because
ferruzzi commented on code in PR #28338:
URL: https://github.com/apache/airflow/pull/28338#discussion_r1157750214
##
airflow/providers/amazon/aws/sensors/dynamodb.py:
##
@@ -0,0 +1,91 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
ferruzzi commented on PR #28338:
URL: https://github.com/apache/airflow/pull/28338#issuecomment-1496588815
I am neither an expert in mocking nor in Dynamo, but I leaned heavily on the
existing dynamohook tests to write this and it does pass with your Sensor.
Give it a try, use it as a base
eladkal commented on code in PR #30422:
URL: https://github.com/apache/airflow/pull/30422#discussion_r1157743660
##
airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst:
##
Review Comment:
> do you have a better proposal that fits it's (above) purpose?
I have but
vincbeck commented on PR #761:
URL: https://github.com/apache/airflow-site/pull/761#issuecomment-1496581427
Interesting. I did know that. It looks like a very good fit for our problem
indeed. The doc actually mention "Don't use the robots.txt file for
canonicalization purposes.". And by rea
potiuk commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157732058
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
I **just** (one hour ago) hit the same problem today when rebasing PR via UI:
h
mik-laj commented on PR #761:
URL: https://github.com/apache/airflow-site/pull/761#issuecomment-1496558935
What do you think about adding https://developers.google.com/search/docs/crawling-indexing/consolidate-duplicate-urls?hl=en
--
This is an automated message from the Apache Git Service
vincbeck commented on PR #28900:
URL: https://github.com/apache/airflow/pull/28900#issuecomment-1496558848
> I am (quite long) waiting for reviewing the refactor of mine, which will
make it possible to show an example.
I'll make another pass to your PRs
--
This is an automated mess
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 56ff116ab3 Fix Breeze failing with error on Windows (#30464)
add c20f6906f8 Update MANIFEST_TEMPLATE.in.jinja2 (#
eladkal merged PR #30431:
URL: https://github.com/apache/airflow/pull/30431
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
RNHTTR commented on code in PR #30375:
URL: https://github.com/apache/airflow/pull/30375#discussion_r1157712035
##
airflow/jobs/scheduler_job.py:
##
@@ -152,6 +152,43 @@ def __init__(
self._zombie_threshold_secs = conf.getint("scheduler",
"scheduler_zombie_task_thresho
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
from 112d4d663e Discovery safe mode toggle comment clarification (#30459)
add 56ff116ab3 Fix Breeze failing with error
potiuk closed issue #30465: Error running `breeze setup
regenerate-command-images`
URL: https://github.com/apache/airflow/issues/30465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
potiuk merged PR #30464:
URL: https://github.com/apache/airflow/pull/30464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
eladkal commented on issue #30195:
URL: https://github.com/apache/airflow/issues/30195#issuecomment-1496519585
is it issue in Airflow or pendulum ?
can you please check if pendulum produce the correct timestamps?
--
This is an automated message from the Apache Git Service.
To respond to
eladkal merged PR #30459:
URL: https://github.com/apache/airflow/pull/30459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.
This is an automated email from the ASF dual-hosted git repository.
eladkal pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 112d4d663e Discovery safe mode toggle comment clar
boring-cyborg[bot] commented on PR #30459:
URL: https://github.com/apache/airflow/pull/30459#issuecomment-1496516587
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
o-nikolas commented on code in PR #30466:
URL: https://github.com/apache/airflow/pull/30466#discussion_r1157698045
##
airflow/providers/amazon/aws/hooks/quicksight.py:
##
@@ -113,10 +113,17 @@ def get_status(self, aws_account_id: str, data_set_id:
str, ingestion_id: str) -
vandonr-amz commented on code in PR #30466:
URL: https://github.com/apache/airflow/pull/30466#discussion_r1157695648
##
airflow/providers/amazon/aws/hooks/quicksight.py:
##
@@ -141,12 +148,14 @@ def wait_for_state(
status = self.get_status(aws_account_id, data_set_id, i
vandonr-amz commented on code in PR #30466:
URL: https://github.com/apache/airflow/pull/30466#discussion_r1157695133
##
airflow/providers/amazon/aws/hooks/quicksight.py:
##
@@ -113,10 +113,17 @@ def get_status(self, aws_account_id: str, data_set_id:
str, ingestion_id: str) -
mikaeld commented on code in PR #24588:
URL: https://github.com/apache/airflow/pull/24588#discussion_r1157685121
##
chart/templates/webserver/webserver-deployment.yaml:
##
@@ -160,6 +163,7 @@ spec:
- name: webserver
image: {{ template "airflow_image" . }}
mikaeld commented on code in PR #24588:
URL: https://github.com/apache/airflow/pull/24588#discussion_r1157685121
##
chart/templates/webserver/webserver-deployment.yaml:
##
@@ -160,6 +163,7 @@ spec:
- name: webserver
image: {{ template "airflow_image" . }}
harishkesavarao commented on code in PR #30428:
URL: https://github.com/apache/airflow/pull/30428#discussion_r1157683035
##
airflow/providers/amazon/aws/transfers/sftp_to_s3.py:
##
Review Comment:
Thank you @potiuk, I rebased from the UI a few times and I am not sure what
potiuk opened a new pull request, #30468:
URL: https://github.com/apache/airflow/pull/30468
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more info
o-nikolas commented on code in PR #30466:
URL: https://github.com/apache/airflow/pull/30466#discussion_r1157677141
##
airflow/providers/amazon/aws/hooks/quicksight.py:
##
@@ -113,10 +113,17 @@ def get_status(self, aws_account_id: str, data_set_id:
str, ingestion_id: str) -
eladkal opened a new pull request, #30467:
URL: https://github.com/apache/airflow/pull/30467
I've heard from several users that recent time change in Mexico caused DAGs
not to run as expected.
This PR add clarification about such cases.
---
**^ Add meaningful description
potiuk commented on PR #30282:
URL: https://github.com/apache/airflow/pull/30282#issuecomment-1496487005
I assume no news is a good news and merge this one once it passes (I rebased
to apply fix to pytest collection timeout from today)., @uranusjr -> maybe alse
we could start merging the de
potiuk commented on PR #28900:
URL: https://github.com/apache/airflow/pull/28900#issuecomment-1496482454
> Although it makes sense in general, I think I'll need some help on this
one :) I am sorry, I am not very used to this codebase and more importantly to
all these new concepts. Is there
o-nikolas commented on issue #30427:
URL: https://github.com/apache/airflow/issues/30427#issuecomment-1496479832
The enum changes are low impact and the ECS system test has been passing
with the new code. Looks all clear to me :+1:
--
This is an automated message from the Apache Git Serv
potiuk commented on PR #29929:
URL: https://github.com/apache/airflow/pull/29929#issuecomment-1496477135
seems that "rebase" from UI - messed with the change (first time see smth
like that) - can yoy please rebase your local change again @amoghrajesh and
re-push it ?
--
This is an automa
rohan472000 commented on issue #30465:
URL: https://github.com/apache/airflow/issues/30465#issuecomment-1496467900
Sure @potiuk I will try that definitely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
vandonr-amz opened a new pull request, #30466:
URL: https://github.com/apache/airflow/pull/30466
in the current state, error handling was not very helpful. Adding the
exception and error info available in the response will help with debugging.
--
This is an automated message from the Apac
eldar-eln-bigabid commented on code in PR #30418:
URL: https://github.com/apache/airflow/pull/30418#discussion_r1157658167
##
airflow/providers/neo4j/hooks/neo4j.py:
##
@@ -61,12 +61,29 @@ def get_conn(self) -> Driver:
is_encrypted = self.connection.extra_dejson.get("
potiuk commented on issue #30465:
URL: https://github.com/apache/airflow/issues/30465#issuecomment-1496453974
Fiz in #30464 . BTW, there will likely be more errors like that. Windows is
our target (but not fully supported yet env, so if you can report (or maybe
even fix and make PRs) simil
potiuk commented on PR #30464:
URL: https://github.com/apache/airflow/pull/30464#issuecomment-1496450148
Whoa. We have our first Windows user of Breeze it seems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
rohan472000 opened a new issue, #30465:
URL: https://github.com/apache/airflow/issues/30465
after running `pre-commit run` , it asked me to run `breeze
setup regenerate-command-images` but while running it I got below errors
PS C:\pycharm\codes\airflow-repo-clone\air
boring-cyborg[bot] commented on issue #30465:
URL: https://github.com/apache/airflow/issues/30465#issuecomment-1496446873
Thanks for opening your first issue here! Be sure to follow the issue
template! If you are willing to raise PR to address this issue please do so, no
need to wait for ap
potiuk opened a new pull request, #30464:
URL: https://github.com/apache/airflow/pull/30464
When breeze is run on Windows it fails with FileNotFoundException when
running uname during emulation check. This is now fixed alongside fixing
TimeoutError misplacement - after moving it to local im
potiuk commented on PR #30405:
URL: https://github.com/apache/airflow/pull/30405#issuecomment-1496436533
Can you please report it as an issue - @rohan472000 (and any others you
might encounter). Seems you are one of the 0.00N% of people who attempt to use
`breeze` on windows, so I would l
RNHTTR commented on code in PR #30375:
URL: https://github.com/apache/airflow/pull/30375#discussion_r1157632498
##
airflow/jobs/scheduler_job.py:
##
@@ -152,6 +152,43 @@ def __init__(
self._zombie_threshold_secs = conf.getint("scheduler",
"scheduler_zombie_task_thresho
potiuk commented on code in PR #30422:
URL: https://github.com/apache/airflow/pull/30422#discussion_r1157630119
##
airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst:
##
Review Comment:
It's not really user facing. It won't find it's way to any user artifacts
(similar
mobuchowski commented on code in PR #29940:
URL: https://github.com/apache/airflow/pull/29940#discussion_r1157621916
##
airflow/providers/openlineage/utils/utils.py:
##
@@ -0,0 +1,482 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
rohan472000 commented on PR #30405:
URL: https://github.com/apache/airflow/pull/30405#issuecomment-1496414377
after running `pre-commit run` , it asked me to run `breeze setup
regenerate-command-images` but while running it I got below errors
PS C:\pycharm\codes\airflow-repo-clone
potiuk commented on PR #30422:
URL: https://github.com/apache/airflow/pull/30422#issuecomment-1496409822
> A lot of changes in here but LGTM
Big number of those is adding "suspended: false", for explicitness :)
BTW. The policy is merged, time for implementation :)
--
This is
mobuchowski commented on code in PR #29940:
URL: https://github.com/apache/airflow/pull/29940#discussion_r1157615110
##
airflow/providers/openlineage/provider.yaml:
##
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
mobuchowski commented on code in PR #29940:
URL: https://github.com/apache/airflow/pull/29940#discussion_r1157614375
##
airflow/providers/openlineage/extractors/manager.py:
##
@@ -0,0 +1,150 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a change to branch add-possibilty-to-suspend-providers
in repository https://gitbox.apache.org/repos/asf/airflow.git
omit 77d95bfe61 Update
airflow/providers/SUSPENDING_AND_RESUMING_PROVIDERS.rst
omit 7873
mrichman commented on PR #28338:
URL: https://github.com/apache/airflow/pull/28338#issuecomment-1496405345
I'm still having issues with mocking. From within the sensor under test,
it's expecting a string but logging shows that is the actual mock object:
```
INFO [airflow.task.oper
mobuchowski commented on code in PR #29940:
URL: https://github.com/apache/airflow/pull/29940#discussion_r1157612149
##
airflow/providers/openlineage/extractors/__init__.py:
##
@@ -0,0 +1,23 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
josh-fell commented on code in PR #30406:
URL: https://github.com/apache/airflow/pull/30406#discussion_r1157605528
##
tests/operators/test_trigger_dagrun.py:
##
@@ -458,4 +480,15 @@ def
test_trigger_dagrun_with_wait_for_completion_true_defer_true_failure_2(self)
as
1 - 100 of 206 matches
Mail list logo