[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation

potiuk commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260686817 ## airflow/executors/executor_loader.py: ## @@ -60,8 +60,9 @@ class ExecutorLoader: LOCAL_EXECUTOR: "airflow.executors.local_executor.LocalExecutor",

[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation

potiuk commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260684817 ## docs/exts/operators_and_hooks_ref.py: ## @@ -284,12 +284,32 @@ def _prepare_notifications_data(): return all_notifiers +def _prepare_executors_data(): +

[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation

potiuk commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260684490 ## airflow/providers_manager.py: ## @@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None: if _sanity_check(provider_package, auth_backe

[GitHub] [airflow] potiuk commented on a diff in pull request #32532: Add Executors discovery and documentation

potiuk commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260683972 ## airflow/providers_manager.py: ## @@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None: if _sanity_check(provider_package, auth_backe

[airflow] branch main updated: Strong-type all single-state enum values (#32537)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fd2687d0d5 Strong-type all single-state enum values

[GitHub] [airflow] itsallsame opened a new issue, #32546: When clearing a historical task in Airflow, it may incorrectly trigger other tasks with no status to change into running status.

itsallsame opened a new issue, #32546: URL: https://github.com/apache/airflow/issues/32546 ### Apache Airflow version 2.6.3 ### What happened When clearing a historical task in Airflow, it may incorrectly trigger other tasks with no status to change into running status.

[GitHub] [airflow] potiuk opened a new pull request, #32545: Fix get_blobs_list_async method to return BlobProperties

potiuk opened a new pull request, #32545: URL: https://github.com/apache/airflow/pull/32545 The get_blobs_list_async method advertised to return list of BlobProperties but returned list of blob names. This is a bug that has been detected by MyPy checks with the new Azure blob package.

[GitHub] [airflow] itsallsame opened a new issue, #32544: when manual trigger dagrun, airflow will skip scheduled runs

itsallsame opened a new issue, #32544: URL: https://github.com/apache/airflow/issues/32544 ### Apache Airflow version 2.6.3 ### What happened I'm using Airflow version 2.6.1 and facing this issue. My DAG is scheduled to run "@daily". I manually triggered the Dag run_id(

[GitHub] [airflow] syedahsn commented on a diff in pull request #32355: Deferrable mode for EKS Create/Delete Operator

syedahsn commented on code in PR #32355: URL: https://github.com/apache/airflow/pull/32355#discussion_r1260653821 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -311,6 +331,80 @@ def execute(self, context: Context): subnets=cast(List[str], self.resources_v

[GitHub] [airflow] potiuk commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

potiuk commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260638131 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/check-health.rst: ## @@ -147,12 +147,12 @@ To check if the worker running on the local host is

[GitHub] [airflow] potiuk commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

potiuk commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260636879 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/check-health.rst: ## @@ -147,12 +147,12 @@ To check if the worker running on the local host is

[GitHub] [airflow] potiuk commented on pull request #32526: Move CeleryExecutor to the celery provider

potiuk commented on PR #32526: URL: https://github.com/apache/airflow/pull/32526#issuecomment-1631896402 OK. I also **think** I properly now raise deprecation warning and inform the users who have the old ``celery_app_name`` set, to change their application name to follow the new package na

[GitHub] [airflow] amoghrajesh commented on pull request #32495: New breeze command to publish docs

amoghrajesh commented on PR #32495: URL: https://github.com/apache/airflow/pull/32495#issuecomment-1631878848 > One more fix needed. There is a static check failing with missing "jsonschema" and for a very good reason. > > Here is one special thing to fix that is not obvious. You need

[airflow] branch main updated: Refactor Sqlalchemy queries to 2.0 style (Part 5) (#32474)

This is an automated email from the ASF dual-hosted git repository. phanikumv pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 2f44ea5996 Refactor Sqlalchemy queries to 2.0 st

[GitHub] [airflow] phanikumv merged pull request #32474: Refactor Sqlalchemy queries to 2.0 style (Part 5)

phanikumv merged PR #32474: URL: https://github.com/apache/airflow/pull/32474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflo

[GitHub] [airflow] potiuk commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

potiuk commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260608559 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/check-health.rst: ## @@ -147,12 +147,12 @@ To check if the worker running on the local host is

[GitHub] [airflow] potiuk commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

potiuk commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260600525 ## airflow/executors/executor_loader.py: ## @@ -60,8 +60,9 @@ class ExecutorLoader: LOCAL_EXECUTOR: "airflow.executors.local_executor.LocalExecutor",

[GitHub] [airflow] potiuk commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

potiuk commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260595063 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/check-health.rst: ## @@ -147,12 +147,12 @@ To check if the worker running on the local host is

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260579342 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding w

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260568877 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding w

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260567257 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding w

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260562506 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding w

[GitHub] [airflow] amoghrajesh commented on pull request #32495: New breeze command to publish docs

amoghrajesh commented on PR #32495: URL: https://github.com/apache/airflow/pull/32495#issuecomment-1631832416 > > One more fix needed. There is a static check failing with missing "jsonschema" and for a very good reason. > > Here is one special thing to fix that is not

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260559655 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding w

[GitHub] [airflow] amoghrajesh commented on a diff in pull request #32495: New breeze command to publish docs

amoghrajesh commented on code in PR #32495: URL: https://github.com/apache/airflow/pull/32495#discussion_r1260556103 ## .github/workflows/ci.yml: ## @@ -631,6 +631,15 @@ jobs: docs-inventory- - name: "Build docs" run: breeze build-docs ${{ needs.bui

[GitHub] [airflow] vghar-bh opened a new issue, #32540: Variables are getting duplicated on upgrading airflow

vghar-bh opened a new issue, #32540: URL: https://github.com/apache/airflow/issues/32540 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened variables are getting duplicated on upgrading airflow to 2.5.3 from 2.4.1. after upgrade

[GitHub] [airflow] debimishra89 opened a new issue, #32539: Packaged DAGs not getting picked up by Airflow

debimishra89 opened a new issue, #32539: URL: https://github.com/apache/airflow/issues/32539 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened I am using Airflow 2.2.3 docker. I have placed a zipped folder in dags folder which

[GitHub] [airflow] o-nikolas commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

o-nikolas commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260069881 ## airflow/providers/celery/CHANGELOG.rst: ## @@ -27,6 +27,13 @@ Changelog - +3.3.0 +. + +.. note:: + This provider release is the first release th

[GitHub] [airflow] phanikumv commented on a diff in pull request #32474: Refactor Sqlalchemy queries to 2.0 style (Part 5)

phanikumv commented on code in PR #32474: URL: https://github.com/apache/airflow/pull/32474#discussion_r1260527156 ## airflow/models/renderedtifields.py: ## @@ -236,14 +232,15 @@ def _do_delete_old_records( session: Session, ) -> None: # This query might d

[GitHub] [airflow] xgao1023 commented on a diff in pull request #32520: allows users to write dag_id and task_id in their national characters, added display name for dag / task

xgao1023 commented on code in PR #32520: URL: https://github.com/apache/airflow/pull/32520#discussion_r1260510790 ## airflow/models/baseoperator.py: ## @@ -796,6 +797,9 @@ def __init__( ) validate_key(task_id) +self.task_id = task_id +self

[GitHub] [airflow] tomoemon commented on pull request #32519: Fix templates-ref.rst (replacement for execution_date is not dag_run.logical_date)

tomoemon commented on PR #32519: URL: https://github.com/apache/airflow/pull/32519#issuecomment-1631778011 @uranusjr I appreciate your approval! Reading the documentation, it is clear that Airflow developers want to use the dag_run object. However, I could not see why a logical

[GitHub] [airflow] Lee-W commented on a diff in pull request #32355: Deferrable mode for EKS Create/Delete Operator

Lee-W commented on code in PR #32355: URL: https://github.com/apache/airflow/pull/32355#discussion_r1260506318 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -311,6 +331,80 @@ def execute(self, context: Context): subnets=cast(List[str], self.resources_vpc_

[GitHub] [airflow] uranusjr commented on a diff in pull request #32474: Refactor Sqlalchemy queries to 2.0 style (Part 5)

uranusjr commented on code in PR #32474: URL: https://github.com/apache/airflow/pull/32474#discussion_r1260499377 ## airflow/models/renderedtifields.py: ## @@ -236,14 +232,15 @@ def _do_delete_old_records( session: Session, ) -> None: # This query might de

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260495220 ## airflow/providers_manager.py: ## @@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None: if _sanity_check(provider_package, auth_bac

[GitHub] [airflow] phanikumv commented on a diff in pull request #32474: Refactor Sqlalchemy queries to 2.0 style (Part 5)

phanikumv commented on code in PR #32474: URL: https://github.com/apache/airflow/pull/32474#discussion_r1260476359 ## airflow/models/renderedtifields.py: ## @@ -236,14 +232,15 @@ def _do_delete_old_records( session: Session, ) -> None: # This query might d

[GitHub] [airflow] uranusjr commented on a diff in pull request #32538: Fix short circuit operator re teardowns

uranusjr commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260472292 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding wi

[GitHub] [airflow] uranusjr commented on a diff in pull request #32538: Fix short circuit operator re teardowns

uranusjr commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260472292 ## airflow/operators/python.py: ## @@ -250,25 +251,35 @@ def execute(self, context: Context) -> Any: if condition: self.log.info("Proceeding wi

[GitHub] [airflow] ferruzzi commented on pull request #32524: Metrics - Enabled encrypted OTel Endpoint

ferruzzi commented on PR #32524: URL: https://github.com/apache/airflow/pull/32524#issuecomment-1631737201 Is it something you might be able to demonstrate in `https://github.com/apache/airflow/blob/main/scripts/ci/docker-compose/otel-collector-config.yml` perhaps? Or maybe explain the set

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260465841 ## airflow/operators/python.py: ## @@ -251,24 +252,47 @@ def execute(self, context: Context) -> Any: self.log.info("Proceeding with downstream tasks...

[GitHub] [airflow] deepchand commented on pull request #32524: Metrics - Enabled encrypted OTel Endpoint

deepchand commented on PR #32524: URL: https://github.com/apache/airflow/pull/32524#issuecomment-1631727708 > NICE! It looks like it worked out of the box now? > > @howardyoo - Check this out :) Yes it works out of the box at client side but at server side where otel collector

[GitHub] [airflow] deepchand commented on a diff in pull request #32524: Metrics - Enabled encrypted OTel Endpoint

deepchand commented on code in PR #32524: URL: https://github.com/apache/airflow/pull/32524#discussion_r1260462190 ## airflow/metrics/otel_logger.py: ## @@ -394,8 +395,11 @@ def get_otel_logger(cls) -> SafeOtelLogger: allow_list_validator = AllowListValidator(allow_list)

[GitHub] [airflow] yupbank commented on a diff in pull request #29224: add output format arg for `cli.dags.trigger`

yupbank commented on code in PR #29224: URL: https://github.com/apache/airflow/pull/29224#discussion_r1260460665 ## airflow/api/client/local_client.py: ## @@ -28,15 +28,32 @@ class Client(api_client.Client): """Local API client implementation.""" -def trigger_dag(sel

[GitHub] [airflow] uranusjr commented on a diff in pull request #32474: Refactor Sqlalchemy queries to 2.0 style (Part 5)

uranusjr commented on code in PR #32474: URL: https://github.com/apache/airflow/pull/32474#discussion_r1260458018 ## airflow/models/renderedtifields.py: ## @@ -236,14 +232,15 @@ def _do_delete_old_records( session: Session, ) -> None: # This query might de

[GitHub] [airflow] uranusjr commented on a diff in pull request #32525: Allow auth managers to override the security manager

uranusjr commented on code in PR #32525: URL: https://github.com/apache/airflow/pull/32525#discussion_r1260454586 ## airflow/www/security.py: ## @@ -56,8 +57,11 @@ "Public", } +# Fetch the security manager override from the auth manager +SecurityManagerOverride = get_au

[GitHub] [airflow] dstandish commented on a diff in pull request #32538: Fix short circuit operator re teardowns

dstandish commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260454176 ## airflow/operators/python.py: ## @@ -251,24 +252,47 @@ def execute(self, context: Context) -> Any: self.log.info("Proceeding with downstream tasks...

[GitHub] [airflow] uranusjr commented on a diff in pull request #32525: Allow auth managers to override the security manager

uranusjr commented on code in PR #32525: URL: https://github.com/apache/airflow/pull/32525#discussion_r1260452664 ## airflow/www/security.py: ## @@ -56,8 +57,11 @@ "Public", } +# Fetch the security manager override from the auth manager +SecurityManagerOverride = get_au

[GitHub] [airflow] uranusjr commented on a diff in pull request #32538: Fix short circuit operator re teardowns

uranusjr commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260440104 ## airflow/operators/python.py: ## @@ -251,24 +252,47 @@ def execute(self, context: Context) -> Any: self.log.info("Proceeding with downstream tasks..."

[GitHub] [airflow] uranusjr commented on a diff in pull request #32538: Fix short circuit operator re teardowns

uranusjr commented on code in PR #32538: URL: https://github.com/apache/airflow/pull/32538#discussion_r1260440104 ## airflow/operators/python.py: ## @@ -251,24 +252,47 @@ def execute(self, context: Context) -> Any: self.log.info("Proceeding with downstream tasks..."

[GitHub] [airflow] uranusjr commented on a diff in pull request #32536: Add deprecation info to the providers modules and classes docstring

uranusjr commented on code in PR #32536: URL: https://github.com/apache/airflow/pull/32536#discussion_r1260428219 ## airflow/providers/google/cloud/sensors/bigquery.py: ## @@ -256,6 +256,11 @@ class BigQueryTableExistenceAsyncSensor(BigQueryTableExistenceSensor): """

[GitHub] [airflow] dstandish opened a new pull request, #32538: Fix short circuit operator re teardowns

dstandish opened a new pull request, #32538: URL: https://github.com/apache/airflow/pull/32538 Short circuit operator should by default not skip teardowns for which the object task is in scope. So for example if you have `s1 >> w1 >> w2 >> t1` and t1 is teardown for s1, then if w1 is

[GitHub] [airflow] hussein-awala opened a new pull request, #32536: Add deprecation info to the providers modules and classes docstring

hussein-awala opened a new pull request, #32536: URL: https://github.com/apache/airflow/pull/32536 This PR adds missing deprecation warning and improve exiting ones in the providers modules and classes docstring. --- **^ Add meaningful description above** Rea

[airflow] branch main updated: Improve the readability of the conn view tests (#32529)

This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 46715164ca Improve the readability of the con

[GitHub] [airflow] hussein-awala merged pull request #32529: Improve the readability of the conn view tests

hussein-awala merged PR #32529: URL: https://github.com/apache/airflow/pull/32529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] hussein-awala opened a new issue, #32535: Improve classes and modules docstring

hussein-awala opened a new issue, #32535: URL: https://github.com/apache/airflow/issues/32535 ### Body I have observed that the Python API documentation on the Airflow website lacks information about deprecation and the corresponding replacement modules or classes. In many cases, use

[GitHub] [airflow] syedahsn opened a new pull request, #32534: Add Deferrable mode for EMR Serverless Start Job Operator

syedahsn opened a new pull request, #32534: URL: https://github.com/apache/airflow/pull/32534 This PR adds the deferrable mode option to `EmrServerlessStartJobOperator`. This PR requires the `EmrServerlessStartApplicationTrigger` which is introduced in #32513 , so that needs to be merged be

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260394523 ## docs/exts/operators_and_hooks_ref.py: ## @@ -284,12 +284,32 @@ def _prepare_notifications_data(): return all_notifiers +def _prepare_executors_data(): +

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260394523 ## docs/exts/operators_and_hooks_ref.py: ## @@ -284,12 +284,32 @@ def _prepare_notifications_data(): return all_notifiers +def _prepare_executors_data(): +

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260389295 ## airflow/providers_manager.py: ## @@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None: if _sanity_check(provider_package, auth_bac

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260386650 ## airflow/providers_manager.py: ## @@ -950,6 +957,14 @@ def _discover_auth_backends(self) -> None: if _sanity_check(provider_package, auth_bac

[GitHub] [airflow] vandonr-amz commented on pull request #32513: EMR serverless Create/Start/Stop/Delete Application deferrable mode

vandonr-amz commented on PR #32513: URL: https://github.com/apache/airflow/pull/32513#issuecomment-1631630969 I left some comments on the previous PR that I don't think you addressed ? Maybe you can reply where I left them ? -- This is an automated message from the Apache Git Service. To

[GitHub] [airflow] uranusjr commented on pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

uranusjr commented on PR #28900: URL: https://github.com/apache/airflow/pull/28900#issuecomment-1631630679 Would be a good idea to change many of the functions to kwarg-only (adding a `*` in front of all arguments) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260383267 ## airflow/providers/celery/executors/__init__.py: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260383267 ## airflow/providers/celery/executors/__init__.py: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [airflow] uranusjr commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

uranusjr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1260382974 ## airflow/models/dag.py: ## @@ -1394,21 +1422,30 @@ def handle_callback(self, dagrun, success=True, reason=None, session=NEW_SESSION :param reason: Comple

[GitHub] [airflow] uranusjr commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

uranusjr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1260381967 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[airflow] branch main updated: Kubernetes Executor Load Time Optimizations (#30727)

This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new f7d4d98f2b Kubernetes Executor Load Time Opt

[GitHub] [airflow] jedcunningham merged pull request #30727: Kubernetes Executor Load Time Optimizations

jedcunningham merged PR #30727: URL: https://github.com/apache/airflow/pull/30727 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] uranusjr commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

uranusjr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1260380579 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[GitHub] [airflow] uranusjr commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

uranusjr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1260380188 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260380057 ## airflow/providers/celery/executors/__init__.py: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license a

[GitHub] [airflow] uranusjr commented on a diff in pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

uranusjr commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1260378985 ## airflow/models/dag.py: ## @@ -1378,6 +1379,33 @@ def normalized_schedule_interval(self) -> ScheduleInterval: _schedule_interval = self.schedule_inte

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260378279 ## airflow/executors/executor_loader.py: ## @@ -60,8 +60,9 @@ class ExecutorLoader: LOCAL_EXECUTOR: "airflow.executors.local_executor.LocalExecutor",

[GitHub] [airflow] ferruzzi commented on a diff in pull request #32532: Add Executors discovery and documentation

ferruzzi commented on code in PR #32532: URL: https://github.com/apache/airflow/pull/32532#discussion_r1260376197 ## airflow/cli/commands/provider_command.py: ## @@ -167,3 +167,15 @@ def auth_backend_list(args): "api_auth_backand_module": x, }, ) + + +

[GitHub] [airflow] mschueler opened a new issue, #32533: Intermittent SIGTERM running on K8S

mschueler opened a new issue, #32533: URL: https://github.com/apache/airflow/issues/32533 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened We are seeing intermittent SIGTERMs on DAGs. There seems to be no rhyme or reason to the

[GitHub] [airflow] jedcunningham commented on a diff in pull request #32526: Move CeleryExecutor to the celery provider

jedcunningham commented on code in PR #32526: URL: https://github.com/apache/airflow/pull/32526#discussion_r1260368896 ## airflow/providers/celery/executors/__init__.py: ## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor lice

[airflow] branch main updated: remove ferruzzi from collaborators list (#32531)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 977b9aee2b remove ferruzzi from collaborators list

[GitHub] [airflow] potiuk merged pull request #32531: remove ferruzzi from collaborators list

potiuk merged PR #32531: URL: https://github.com/apache/airflow/pull/32531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[GitHub] [airflow] potiuk commented on pull request #32532: Add Executors discovery and documentation

potiuk commented on PR #32532: URL: https://github.com/apache/airflow/pull/32532#issuecomment-1631613546 Based on #32526, so only last commit counts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] potiuk opened a new pull request, #32532: Add executors discovery to providers

potiuk opened a new pull request, #32532: URL: https://github.com/apache/airflow/pull/32532 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for m

[GitHub] [airflow] hussein-awala opened a new pull request, #32531: remove ferruzzi from collaborators list

hussein-awala opened a new pull request, #32531: URL: https://github.com/apache/airflow/pull/32531 Remove ferruzzi from the list of collaborators because he is now a committer, to free up a place for a new collaborator (there will be two places available) --- **^ Add m

[airflow] branch main updated: Append region info to S3ToRedshitOperator if present (#32328)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 50a68c6c4e Append region info to S3ToRedshitOperato

[GitHub] [airflow] potiuk merged pull request #32328: Append region info to S3ToRedshitOperator if present

potiuk merged PR #32328: URL: https://github.com/apache/airflow/pull/32328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: More strong typed state conversion (#32521)

This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fa3be084a1 More strong typed state conversion (#325

[GitHub] [airflow] vincbeck commented on pull request #28900: Convert DagFileProcessor.execute_callbacks to Internal API

vincbeck commented on PR #28900: URL: https://github.com/apache/airflow/pull/28900#issuecomment-1631535425 Static checks are passing, only one unit test is failing now because of `TypeError: Object of type EmptyOperator is not JSON serializable`. Looking into it -- This is an automated m

[GitHub] [airflow] ephraimbuddy opened a new pull request, #32530: Validate that a setup task has a downstream that's a work task

ephraimbuddy opened a new pull request, #32530: URL: https://github.com/apache/airflow/pull/32530 I don't think it's meaningful to have a setup task without a work task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[airflow] branch main updated (410d0c0f86 -> 394cedb01a)

This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 410d0c0f86 fix google docs (#32472) add 394cedb01a Strip whitespaces from airflow connections form (#32292)

[GitHub] [airflow] hussein-awala merged pull request #32292: Strip whitespaces from airflow connections form

hussein-awala merged PR #32292: URL: https://github.com/apache/airflow/pull/32292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

[GitHub] [airflow] uranusjr commented on a diff in pull request #32529: Improve the readability of the conn view tests

uranusjr commented on code in PR #32529: URL: https://github.com/apache/airflow/pull/32529#discussion_r1260182632 ## tests/www/views/test_views_connection.py: ## @@ -350,12 +351,11 @@ def test_duplicate_connection_error(admin_client): data = {"action": "mulduplicate", "ro

[GitHub] [airflow] uranusjr commented on a diff in pull request #32529: Improve the readability of the conn view tests

uranusjr commented on code in PR #32529: URL: https://github.com/apache/airflow/pull/32529#discussion_r1260182363 ## tests/www/views/test_views_connection.py: ## @@ -314,16 +314,17 @@ def test_duplicate_connection(admin_client): data = {"action": "mulduplicate", "rowid":

[GitHub] [airflow] syedahsn commented on a diff in pull request #32355: Deferrable mode for EKS Create/Delete Operator

syedahsn commented on code in PR #32355: URL: https://github.com/apache/airflow/pull/32355#discussion_r1260180873 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -310,6 +333,82 @@ def execute(self, context: Context): subnets=cast(List[str], self.resources_v

[GitHub] [airflow] hussein-awala opened a new pull request, #32529: Improve the readability of the conn view tests

hussein-awala opened a new pull request, #32529: URL: https://github.com/apache/airflow/pull/32529 Make the conn view tests more readable by renaming some variables and access the row fields by field name instead of index. --- **^ Add meaningful description above**

[GitHub] [airflow] uranusjr commented on a diff in pull request #32000: Fix DAG test command stuck in infinite loop

uranusjr commented on code in PR #32000: URL: https://github.com/apache/airflow/pull/32000#discussion_r1260169616 ## airflow/models/dag.py: ## @@ -2763,16 +2762,20 @@ def add_logger_if_needed(ti: TaskInstance): if ti.state == TaskInstanceState.SCHEDULED:

[GitHub] [airflow] jens-scheffler-bosch commented on issue #32375: sqlalchemy.exc.ResourceClosedError when updating a task instance's executor_config from a task_instance_mutation_hook

jens-scheffler-bosch commented on issue #32375: URL: https://github.com/apache/airflow/issues/32375#issuecomment-1631376367 I was reading through the code a bit and took me a while to try to understand the "why". I don't actually see directly why the `pod_instance_mutation_hook` fails in DB

[airflow] branch main updated: fix google docs (#32472)

This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 410d0c0f86 fix google docs (#32472) 410d0c0f86 is

[GitHub] [airflow] eladkal merged pull request #32472: Fix `Prerequisite Tasks` not rendering in Google providers doc

eladkal merged PR #32472: URL: https://github.com/apache/airflow/pull/32472 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[GitHub] [airflow] eladkal commented on pull request #30727: Kubernetes Executor Load Time Optimizations

eladkal commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1631367310 > It will be easier the other way round. Great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [airflow] potiuk commented on pull request #30727: Kubernetes Executor Load Time Optimizations

potiuk commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1631352432 > I think it minimize the challanges and will be handled like any provider code change (users will also have a fallback version if we decide to yank for some reason) Nope. This co

[GitHub] [airflow] potiuk commented on pull request #30727: Kubernetes Executor Load Time Optimizations

potiuk commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1631349234 > We can also decide to extract the executor as is. Release it with provider wave then apply this optimization patch directly to the provider code. It will be easier the other way

[GitHub] [airflow] syedahsn commented on pull request #32513: EMR serverless Create/Start/Stop/Delete Application deferrable mode

syedahsn commented on PR #32513: URL: https://github.com/apache/airflow/pull/32513#issuecomment-1631337656 @uranusjr @pragnareddye @vandonr-amz Can you please have another look at this PR? This is the same PR as #32414 - I ended up closing that because there was a problem with rebasing wh

[GitHub] [airflow] eladkal commented on pull request #30727: Kubernetes Executor Load Time Optimizations

eladkal commented on PR #30727: URL: https://github.com/apache/airflow/pull/30727#issuecomment-1631332545 We can also decide to extract the executor as is. Release it with provider wave then apply this optimization patch directly to the peovider code. I think it minimize the challange

  1   2   3   >