[GitHub] [airflow] Bisk1 commented on pull request #33746: Refactor: remove unused state - SHUTDOWN

2023-09-03 Thread via GitHub
Bisk1 commented on PR #33746: URL: https://github.com/apache/airflow/pull/33746#issuecomment-1704641375 Sorry, I missed that message somehow - thanks for fixing it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [airflow] uranusjr opened a new pull request, #34063: Bring back SHUTDOWN-related constants

2023-09-03 Thread via GitHub
uranusjr opened a new pull request, #34063: URL: https://github.com/apache/airflow/pull/34063 This should restore code compatibility to 2.6 and prior. Note that the constants would not appear in documentation since they are deprecated and not use in Airflow core anyway anymore. See

[airflow] branch constraints-main updated: Updating constraints. Github run id:6068710608

2023-09-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 8bcbee54a5 Updating

[GitHub] [airflow] boring-cyborg[bot] commented on issue #34062: Inaccurate ERD Schema Diagram

2023-09-03 Thread via GitHub
boring-cyborg[bot] commented on issue #34062: URL: https://github.com/apache/airflow/issues/34062#issuecomment-1704555684 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[GitHub] [airflow] immiao opened a new issue, #34062: Inaccurate ERD Schema Diagram

2023-09-03 Thread via GitHub
immiao opened a new issue, #34062: URL: https://github.com/apache/airflow/issues/34062 ### What do you see as an issue? In latest ERD schema - https://airflow.apache.org/docs/apache-airflow/stable/database-erd-ref.html `dag_run` to `task_instance` is showing 1 to 1

[airflow] branch main updated: Add state utils to Public Airflow Interface (#34059)

2023-09-03 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c44e5b5ccc Add state utils to Public Airflow

[GitHub] [airflow] uranusjr merged pull request #34059: Add state utils to Public Airflow Interface

2023-09-03 Thread via GitHub
uranusjr merged PR #34059: URL: https://github.com/apache/airflow/pull/34059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] adam133 commented on a diff in pull request #32903: allow DatabricksSubmitRunOperator to accept a pipeline name for a pipeline_task

2023-09-03 Thread via GitHub
adam133 commented on code in PR #32903: URL: https://github.com/apache/airflow/pull/32903#discussion_r1314359427 ## airflow/providers/databricks/hooks/databricks.py: ## @@ -215,6 +216,67 @@ def find_job_id_by_name(self, job_name: str) -> int | None: else:

[GitHub] [airflow] zeotuan commented on issue #31745: Add a process_line callback to KubernetesPodOperator

2023-09-03 Thread via GitHub
zeotuan commented on issue #31745: URL: https://github.com/apache/airflow/issues/31745#issuecomment-1704459295 I would like to pick up this feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [airflow] github-actions[bot] closed issue #32824: Configuration of S3 based dags_folder

2023-09-03 Thread via GitHub
github-actions[bot] closed issue #32824: Configuration of S3 based dags_folder URL: https://github.com/apache/airflow/issues/32824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[airflow] branch main updated: Refactor unneeded 'continue' jumps in cli (#33845)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 05a0542b5a Refactor unneeded 'continue' jumps in

[GitHub] [airflow] potiuk merged pull request #33845: Refactor unneeded 'continue' jumps in cli

2023-09-03 Thread via GitHub
potiuk merged PR #33845: URL: https://github.com/apache/airflow/pull/33845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on a diff in pull request #34042: AIP44 Fix DAG serialization

2023-09-03 Thread via GitHub
kaxil commented on code in PR #34042: URL: https://github.com/apache/airflow/pull/34042#discussion_r1314334593 ## airflow/serialization/serialized_objects.py: ## @@ -438,7 +438,7 @@ def serialize( json_pod = PodGenerator.serialize_pod(var) return

[GitHub] [airflow] kaxil commented on a diff in pull request #34042: AIP44 Fix DAG serialization

2023-09-03 Thread via GitHub
kaxil commented on code in PR #34042: URL: https://github.com/apache/airflow/pull/34042#discussion_r1314334386 ## airflow/serialization/serialized_objects.py: ## @@ -438,7 +438,7 @@ def serialize( json_pod = PodGenerator.serialize_pod(var) return

[GitHub] [airflow] kaxil commented on a diff in pull request #34042: AIP44 Fix DAG serialization

2023-09-03 Thread via GitHub
kaxil commented on code in PR #34042: URL: https://github.com/apache/airflow/pull/34042#discussion_r1314333805 ## airflow/serialization/serialized_objects.py: ## @@ -438,7 +438,7 @@ def serialize( json_pod = PodGenerator.serialize_pod(var) return

[GitHub] [airflow] SbtrktCtrl commented on issue #34058: UI Grid error when DAG has been removed

2023-09-03 Thread via GitHub
SbtrktCtrl commented on issue #34058: URL: https://github.com/apache/airflow/issues/34058#issuecomment-1704434167 Legends! thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on pull request #34014: Remove [project] section from `pyproject.toml`

2023-09-03 Thread via GitHub
potiuk commented on PR #34014: URL: https://github.com/apache/airflow/pull/34014#issuecomment-1704433673 I think we should also adda `python_requires='>3.8.0'` in `setup(` in setup.py in order to replace the `requires-python` -- This is an automated message from the Apache Git Service.

[airflow] branch main updated: Add decorator for suppress optional internal methods in Amazon Provider (#34034)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new bf2d411a2a Add decorator for suppress optional

[GitHub] [airflow] potiuk merged pull request #34034: Add decorator for suppress optional internal methods in Amazon Provider

2023-09-03 Thread via GitHub
potiuk merged PR #34034: URL: https://github.com/apache/airflow/pull/34034 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #33976: Move the try outside the loop when this is possible in Google provider

2023-09-03 Thread via GitHub
potiuk merged PR #33976: URL: https://github.com/apache/airflow/pull/33976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Move the try outside the loop when this is possible in Google provider (#33976)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4f20b0f442 Move the try outside the loop when this

[airflow] branch main updated: Move the try outside the loop when this is possible in Airflow core (#33975)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8918b435be Move the try outside the loop when this

[GitHub] [airflow] potiuk merged pull request #33975: Move the try outside the loop when this is possible in Airflow core

2023-09-03 Thread via GitHub
potiuk merged PR #33975: URL: https://github.com/apache/airflow/pull/33975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on issue #34013: Task is not able to be run - k8s Celery workers with stale resources

2023-09-03 Thread via GitHub
potiuk commented on issue #34013: URL: https://github.com/apache/airflow/issues/34013#issuecomment-1704411889 For me it looks like something indeed takes a lot of memory for the workers but what it would be - hard to say. Is it possible to run your workers with memray

[GitHub] [airflow] potiuk commented on pull request #34059: Add state utils to Public Airflow Interface

2023-09-03 Thread via GitHub
potiuk commented on PR #34059: URL: https://github.com/apache/airflow/pull/34059#issuecomment-1704410218 Right :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated: Fix BigQueryValueCheckOperator deferrable mode optimisation (#34018)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d757f6a3af Fix BigQueryValueCheckOperator

[GitHub] [airflow] potiuk merged pull request #34018: Fix BigQueryValueCheckOperator deferrable mode optimisation

2023-09-03 Thread via GitHub
potiuk merged PR #34018: URL: https://github.com/apache/airflow/pull/34018 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk closed issue #34010: `BigQueryValueCheckOperator` doesn't respect `pass_value` in deferrable mode

2023-09-03 Thread via GitHub
potiuk closed issue #34010: `BigQueryValueCheckOperator` doesn't respect `pass_value` in deferrable mode URL: https://github.com/apache/airflow/issues/34010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[airflow] branch constraints-main updated: Updating constraints. Github run id:6066514013

2023-09-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 2200e749b8 Updating

[GitHub] [airflow] Taragolis commented on a diff in pull request #34002: test(providers/microsfot): add system test for AzureContainerVolumeHook and AzureContainerRegistryHook

2023-09-03 Thread via GitHub
Taragolis commented on code in PR #34002: URL: https://github.com/apache/airflow/pull/34002#discussion_r1314315301 ## tests/system/providers/microsoft/azure/example_azure_container_instances.py: ## @@ -52,7 +55,39 @@ task_id="start_container", ) +t2 =

[GitHub] [airflow] potiuk closed issue #29242: Auto-refresh task logs in UI

2023-09-03 Thread via GitHub
potiuk closed issue #29242: Auto-refresh task logs in UI URL: https://github.com/apache/airflow/issues/29242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on pull request #34002: test(providers/microsfot): add system test for AzureContainerVolumeHook and AzureContainerRegistryHook

2023-09-03 Thread via GitHub
potiuk commented on PR #34002: URL: https://github.com/apache/airflow/pull/34002#issuecomment-1704398249 > During my work on #33825 and #33822, I discovered that there are no system tests for AzureContainerVolumeHook and AzureContainerRegistryHook. Is there any setup I need to do for these

[airflow] branch main updated: Combine similar if logics in tests (#33986)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6ef80e8be1 Combine similar if logics in tests

[airflow] branch main updated: Combine similar if logics in providers (#33987)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fa5e54c4c5 Combine similar if logics in providers

[GitHub] [airflow] potiuk merged pull request #33986: Combine similar if logics in tests

2023-09-03 Thread via GitHub
potiuk merged PR #33986: URL: https://github.com/apache/airflow/pull/33986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #33987: Combine similar if logics in providers

2023-09-03 Thread via GitHub
potiuk merged PR #33987: URL: https://github.com/apache/airflow/pull/33987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #33746: Refactor: remove unused state - SHUTDOWN

2023-09-03 Thread via GitHub
potiuk commented on PR #33746: URL: https://github.com/apache/airflow/pull/33746#issuecomment-1704386688 Added PR https://github.com/apache/airflow/pull/34059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [airflow] potiuk opened a new pull request, #34059: Add state utils to Public Airflow Interface

2023-09-03 Thread via GitHub
potiuk opened a new pull request, #34059: URL: https://github.com/apache/airflow/pull/34059 The state enums are likely to be used externally and they should not be changed in backwards-incompatible way. Discussed in #33746 --- **^ Add meaningful

[GitHub] [airflow] shahar1 commented on issue #32650: GCS Sensor for matching glob

2023-09-03 Thread via GitHub
shahar1 commented on issue #32650: URL: https://github.com/apache/airflow/issues/32650#issuecomment-1704386375 @A-Costa Hey, if you're still working on it - I'd be happy to assist (disclosure: I introduced the `match_glob` to the GCS hook). As Elad suggested - I think that it makes sense

[GitHub] [airflow] pierrejeambrun opened a new issue, #34058: Grid issues when Dag has been removed

2023-09-03 Thread via GitHub
pierrejeambrun opened a new issue, #34058: URL: https://github.com/apache/airflow/issues/34058 **Reproduce on main:** - Run a DAG - Rename the DAG - Wait for dag file processor to remove the deleted DAG and add the new one. (Old Dag should not appear on the home page anymore) -

[GitHub] [airflow] eumiro opened a new pull request, #34057: Refactor attempting loops in jenkins

2023-09-03 Thread via GitHub
eumiro opened a new pull request, #34057: URL: https://github.com/apache/airflow/pull/34057 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] pierrejeambrun opened a new pull request, #34056: Clarify new_state in OpenAPI spec

2023-09-03 Thread via GitHub
pierrejeambrun opened a new pull request, #34056: URL: https://github.com/apache/airflow/pull/34056 We had questions about this in the slack, instance here: https://apache-airflow.slack.com/archives/CSS36QQS1/p1693501503281489 This is just a clarification of the spec as to why only

[GitHub] [airflow] eumiro opened a new pull request, #34055: Refactor attempting loops in tests

2023-09-03 Thread via GitHub
eumiro opened a new pull request, #34055: URL: https://github.com/apache/airflow/pull/34055 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] eumiro opened a new pull request, #34054: Refactor attempting loops in breeze

2023-09-03 Thread via GitHub
eumiro opened a new pull request, #34054: URL: https://github.com/apache/airflow/pull/34054 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] eumiro opened a new pull request, #34053: Refactor attempting loops in providers/amazons

2023-09-03 Thread via GitHub
eumiro opened a new pull request, #34053: URL: https://github.com/apache/airflow/pull/34053 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on pull request #33934: Replace sequence concatination by unpacking in Airflow core

2023-09-03 Thread via GitHub
potiuk commented on PR #33934: URL: https://github.com/apache/airflow/pull/33934#issuecomment-1704376350 LGTM. I think using itertools for those is indeed over-the-top. I am fine witth the current version :) -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated: Replace single quotes by double quotes in tests (#33864)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c82806641f Replace single quotes by double quotes

[GitHub] [airflow] potiuk merged pull request #33864: Replace single quotes by double quotes in tests

2023-09-03 Thread via GitHub
potiuk merged PR #33864: URL: https://github.com/apache/airflow/pull/33864 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch constraints-main updated: Updating constraints. Github run id:6065698035

2023-09-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 92d81199c1 Updating

[GitHub] [airflow] potiuk commented on pull request #33898: Refactor regex in providers

2023-09-03 Thread via GitHub
potiuk commented on PR #33898: URL: https://github.com/apache/airflow/pull/33898#issuecomment-1704364401 Mypy does not like optional groups() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] eumiro opened a new pull request, #34052: Refactor: Simplify loop in aws/triggers/batch.py

2023-09-03 Thread via GitHub
eumiro opened a new pull request, #34052: URL: https://github.com/apache/airflow/pull/34052 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [airflow] potiuk commented on pull request #33902: allow optional password replacement

2023-09-03 Thread via GitHub
potiuk commented on PR #33902: URL: https://github.com/apache/airflow/pull/33902#issuecomment-1704358675 Closing unless the solution that alrready exists in Airflow for that very purpose cannot be used, then we can reconsider (but it's not generic enough anyway). -- This is an automated

[GitHub] [airflow] potiuk commented on pull request #33902: allow optional password replacement

2023-09-03 Thread via GitHub
potiuk commented on PR #33902: URL: https://github.com/apache/airflow/pull/33902#issuecomment-1704358422 This is quite certainly wrong approach. You do not need to do it in such complex way. You should use `_CMD` version of the variables for that. You can have

[GitHub] [airflow] potiuk closed pull request #33902: allow optional password replacement

2023-09-03 Thread via GitHub
potiuk closed pull request #33902: allow optional password replacement URL: https://github.com/apache/airflow/pull/33902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] eumiro commented on a diff in pull request #33846: Refactor unneeded 'continue' jumps in jobs

2023-09-03 Thread via GitHub
eumiro commented on code in PR #33846: URL: https://github.com/apache/airflow/pull/33846#discussion_r1314290974 ## airflow/jobs/backfill_job_runner.py: ## @@ -656,8 +656,6 @@ def _per_task_process(key, ti: TaskInstance, session):

[GitHub] [airflow] potiuk commented on a diff in pull request #33837: Refactor unneeded 'continue' jumps in models

2023-09-03 Thread via GitHub
potiuk commented on code in PR #33837: URL: https://github.com/apache/airflow/pull/33837#discussion_r1314289102 ## airflow/models/taskinstance.py: ## @@ -2966,12 +2966,9 @@ def as_dict(self): stacklevel=2, ) new_dict = dict(self.__dict__) -

[airflow] branch constraints-2-7 updated: Updating constraints. Github run id:6065487605

2023-09-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-2-7 in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2-7 by this push: new 6dc563d776 Updating

[airflow] branch main updated: Refactor unneeded 'continue' jumps in scripts (#33834)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9ed992ac0f Refactor unneeded 'continue' jumps in

[GitHub] [airflow] potiuk merged pull request #33834: Refactor unneeded 'continue' jumps in scripts

2023-09-03 Thread via GitHub
potiuk merged PR #33834: URL: https://github.com/apache/airflow/pull/33834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk merged pull request #33848: Refactor unneeded 'continue' jumps in setup.py

2023-09-03 Thread via GitHub
potiuk merged PR #33848: URL: https://github.com/apache/airflow/pull/33848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Refactor unneeded 'continue' jumps in setup.py (#33848)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ff1a5f2a99 Refactor unneeded 'continue' jumps in

[GitHub] [airflow] potiuk commented on pull request #33848: Refactor unneeded 'continue' jumps in setup.py

2023-09-03 Thread via GitHub
potiuk commented on PR #33848: URL: https://github.com/apache/airflow/pull/33848#issuecomment-1704351067 Static checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] ephraimbuddy merged pull request #34029: Fix link for running Airflow in Docker

2023-09-03 Thread via GitHub
ephraimbuddy merged PR #34029: URL: https://github.com/apache/airflow/pull/34029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Fix link for running Airflow in Docker (#34029)

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new dd39933f62 Fix link for running Airflow

[GitHub] [airflow] ephraimbuddy commented on pull request #33903: Ensure that tasks wait for running indirect setup

2023-09-03 Thread via GitHub
ephraimbuddy commented on PR #33903: URL: https://github.com/apache/airflow/pull/33903#issuecomment-1704343282 Cherrypicked! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [airflow] potiuk commented on pull request #33848: Refactor unneeded 'continue' jumps in setup.py

2023-09-03 Thread via GitHub
potiuk commented on PR #33848: URL: https://github.com/apache/airflow/pull/33848#issuecomment-1704343100 Static checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on pull request #33867: Update taskflow.rst, fix Multiple outputs inference example

2023-09-03 Thread via GitHub
potiuk commented on PR #33867: URL: https://github.com/apache/airflow/pull/33867#issuecomment-1704342784 > Maybe we could add a note somewhere (or do we already?) explaining that from __future__ import annotations is needed for some of the examples. I don't think we have a good place

[GitHub] [airflow] potiuk closed pull request #33867: Update taskflow.rst, fix Multiple outputs inference example

2023-09-03 Thread via GitHub
potiuk closed pull request #33867: Update taskflow.rst, fix Multiple outputs inference example URL: https://github.com/apache/airflow/pull/33867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[airflow] 02/04: Fix typos (double words and it's/its) (#33623)

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 590412ba589fec20edde698057190f725770a29f Author: Miroslav Šedivý <6774676+eum...@users.noreply.github.com>

[airflow] branch v2-7-test updated (e571741629 -> 891fae5025)

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit e571741629 Limit celery by excluding 5.3.2 and 5.3.3 (#34031) omit 6cb5ef1bff Update

[airflow] 03/04: Ensure that tasks wait for running indirect setup (#33903)

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit b5dbf97317c4ea0dde6a2b006d34b694c95d2f9a Author: Daniel Standish

[airflow] 04/04: Update RELEASE_NOTES.rst

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit 891fae5025e44833afc0fc6f7a5ff34515753e26 Author: Ephraim Anierobi AuthorDate: Mon Aug 28 16:07:12 2023

[airflow] 01/04: Limit celery by excluding 5.3.2 and 5.3.3 (#34031)

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch v2-7-test in repository https://gitbox.apache.org/repos/asf/airflow.git commit d404d3f84a5f6cdc204c758f76514e2829525dd0 Author: Jarek Potiuk AuthorDate: Sat Sep 2 15:19:21 2023 +0200

[airflow] branch main updated: Refactor unneeded 'continue' jumps in dag processing (#33839)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 562357528d Refactor unneeded 'continue' jumps in

[GitHub] [airflow] potiuk commented on pull request #33865: Add TCH001 and TCH002 rules to pre-commit to detect and move type checking modules

2023-09-03 Thread via GitHub
potiuk commented on PR #33865: URL: https://github.com/apache/airflow/pull/33865#issuecomment-1704341787 > @potiuk do we cherry-pick dev and tests? is it ok to keep all these changes in the same PR or should I split them in smaller ones? We do cherry-pick dev and tests except

[GitHub] [airflow] potiuk merged pull request #33839: Refactor unneeded 'continue' jumps in dag processing

2023-09-03 Thread via GitHub
potiuk merged PR #33839: URL: https://github.com/apache/airflow/pull/33839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch main updated: Fix issue with unit tests in subprocesses on macOS (#34037)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 5833320291 Fix issue with unit tests in

[GitHub] [airflow] potiuk merged pull request #34037: Fix issue with unit tests in subprocesses on macOS

2023-09-03 Thread via GitHub
potiuk merged PR #34037: URL: https://github.com/apache/airflow/pull/34037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #34037: Fix issue with unit tests in subprocesses on macOS

2023-09-03 Thread via GitHub
potiuk commented on PR #34037: URL: https://github.com/apache/airflow/pull/34037#issuecomment-1704339899 fantastic :). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[airflow] branch main updated: Ensure that tasks wait for running indirect setup (#33903)

2023-09-03 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new e75cecab72 Ensure that tasks wait for

[GitHub] [airflow] ephraimbuddy merged pull request #33903: Ensure that tasks wait for running indirect setup

2023-09-03 Thread via GitHub
ephraimbuddy merged PR #33903: URL: https://github.com/apache/airflow/pull/33903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[airflow] branch constraints-main updated: Updating constraints. Github run id:6065088154

2023-09-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 04ae30fb86 Updating

[GitHub] [airflow] Bisk1 commented on a diff in pull request #34037: Fix issue with unit tests in subprocesses on macOS

2023-09-03 Thread via GitHub
Bisk1 commented on code in PR #34037: URL: https://github.com/apache/airflow/pull/34037#discussion_r1314275322 ## airflow/config_templates/unit_tests.cfg: ## @@ -59,6 +59,8 @@ unit_test_mode = True killed_task_cleanup_time = 5 # We only allow our own classes to be

[GitHub] [airflow] hussein-awala commented on pull request #33903: Ensure that tasks wait for running indirect setup

2023-09-03 Thread via GitHub
hussein-awala commented on PR #33903: URL: https://github.com/apache/airflow/pull/33903#issuecomment-1704326323 I understand that `+602 −236 ` is scary for a patch version, but most of the changed code is documentation and tests, and for the changes in `trigger_rule_dep`, @dstandish has

[GitHub] [airflow] patgarz opened a new pull request, #34051: AIP-56: Change FAB username identifier

2023-09-03 Thread via GitHub
patgarz opened a new pull request, #34051: URL: https://github.com/apache/airflow/pull/34051 CC: @vincbeck as owner of AIP-56 apache/airflow#32217 implemented the base and FAB user management interfaces. As a part of that PR, `get_user_name` was set to be `FirstName

[GitHub] [airflow] rajrao commented on a diff in pull request #34016: Added more example code for XCom push and pull

2023-09-03 Thread via GitHub
rajrao commented on code in PR #34016: URL: https://github.com/apache/airflow/pull/34016#discussion_r1314272113 ## docs/apache-airflow/core-concepts/xcoms.rst: ## @@ -25,9 +25,23 @@ XComs (short for "cross-communications") are a mechanism that let :doc:`tasks` t An XCom is

[GitHub] [airflow] potiuk closed issue #34044: Airflow should support different types of dataset event consumer DAGs

2023-09-03 Thread via GitHub
potiuk closed issue #34044: Airflow should support different types of dataset event consumer DAGs URL: https://github.com/apache/airflow/issues/34044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on issue #34044: Airflow should support different types of dataset event consumer DAGs

2023-09-03 Thread via GitHub
potiuk commented on issue #34044: URL: https://github.com/apache/airflow/issues/34044#issuecomment-1704324263 I think such a discussion should happen in the devlist not in GitHub issue. I believe very soon we are going to have some proposal (or few proposals) on the devlist that will be

[airflow] branch main updated: Remove azure-storage-common from microsoft azure providers (#34038)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 6f1f624f04 Remove azure-storage-common from

[GitHub] [airflow] potiuk merged pull request #34038: Remove azure-storage-common from microsoft azure providers

2023-09-03 Thread via GitHub
potiuk merged PR #34038: URL: https://github.com/apache/airflow/pull/34038 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #34038: Remove azure-storage-common from microsoft azure providers

2023-09-03 Thread via GitHub
potiuk commented on PR #34038: URL: https://github.com/apache/airflow/pull/34038#issuecomment-1704320682 Less dependencies is better :). And seems that all tests pass :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[airflow] branch main updated: Make AWS SecretsManager tests compatible with `moto>=4.2.1` (#34046)

2023-09-03 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 613ae4b78e Make AWS SecretsManager tests

[GitHub] [airflow] potiuk merged pull request #34046: Make AWS SecretsManager tests compatible with `moto>=4.2.1`

2023-09-03 Thread via GitHub
potiuk merged PR #34046: URL: https://github.com/apache/airflow/pull/34046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] pankajastro commented on pull request #34038: Remove azure-storage-common from microsoft azure providers

2023-09-03 Thread via GitHub
pankajastro commented on PR #34038: URL: https://github.com/apache/airflow/pull/34038#issuecomment-1704319936 > Why do we have it if we don't use it? > Did we remove some functionality and forgot to remove the library? yes I believe should have been removed in my previous PR. Look

[GitHub] [airflow] jaegwonseo commented on a diff in pull request #33796: Add druid ingestion connection test

2023-09-03 Thread via GitHub
jaegwonseo commented on code in PR #33796: URL: https://github.com/apache/airflow/pull/33796#discussion_r1314256500 ## airflow/providers/apache/druid/hooks/druid.py: ## @@ -149,6 +154,20 @@ def submit_indexing_job( self.log.info("Successful index") +def

[GitHub] [airflow] jaegwonseo commented on a diff in pull request #33796: Add druid ingestion connection test

2023-09-03 Thread via GitHub
jaegwonseo commented on code in PR #33796: URL: https://github.com/apache/airflow/pull/33796#discussion_r1314253423 ## airflow/providers/apache/druid/CHANGELOG.rst: ## @@ -27,6 +27,19 @@ Changelog - +4.0.0 +. + +Features + + +* ``Add druid ingestion

[GitHub] [airflow] Bisk1 commented on pull request #34027: Fix scheduler logic to plan new dag runs by ignoring manual runs

2023-09-03 Thread via GitHub
Bisk1 commented on PR #34027: URL: https://github.com/apache/airflow/pull/34027#issuecomment-1704264908 > Looks good but the renaming should be in a separate PR if it's actually needed @ephraimbuddy Ok I removed it and moved to separate PR

[GitHub] [airflow] Bisk1 opened a new pull request, #34049: Rename variables for dag runs

2023-09-03 Thread via GitHub
Bisk1 opened a new pull request, #34049: URL: https://github.com/apache/airflow/pull/34049 Follow-up to discussion in https://github.com/apache/airflow/pull/34027#pullrequestreview-1608444868 Some variables used when invoking calculate_dagrun_date_fields were renamed to make it

[GitHub] [airflow] NJ-Tokki opened a new issue, #34048: Use Kubernetes-recommended labels

2023-09-03 Thread via GitHub
NJ-Tokki opened a new issue, #34048: URL: https://github.com/apache/airflow/issues/34048 ### Description Feature Kubernetes offers a [list of recommended labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/#labels) for grouping resource

[GitHub] [airflow] potiuk commented on a diff in pull request #34037: Fix issue with unit tests in subprocesses on macOS

2023-09-03 Thread via GitHub
potiuk commented on code in PR #34037: URL: https://github.com/apache/airflow/pull/34037#discussion_r1314236718 ## airflow/config_templates/unit_tests.cfg: ## @@ -59,6 +59,8 @@ unit_test_mode = True killed_task_cleanup_time = 5 # We only allow our own classes to be

  1   2   >