[PR] docs: remove extraneous '>' in provider section name [airflow]

2023-10-06 Thread via GitHub
dead-1ine opened a new pull request, #34813: URL: https://github.com/apache/airflow/pull/34813 Removed the extraneous '>' character from the 'providers.some_provider>' section name in the documentation --- **^ Add meaningful description above** Read

Re: [PR] docs: remove extraneous '>' in provider section name [airflow]

2023-10-06 Thread via GitHub
dead-1ine closed pull request #34797: docs: remove extraneous '>' in provider section name URL: https://github.com/apache/airflow/pull/34797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Re-implement client codegen with Python [airflow]

2023-10-06 Thread via GitHub
github-actions[bot] commented on PR #33365: URL: https://github.com/apache/airflow/pull/33365#issuecomment-1751517922 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for

[PR] Update taskflow.rst [airflow]

2023-10-06 Thread via GitHub
pankajkoti opened a new pull request, #34812: URL: https://github.com/apache/airflow/pull/34812 When storing XCOM as dict and using it in subsequent tasks it needs to be unrolled so that keys of the dict are stored and can be used as in below task. Hence, using

[airflow] branch pankajkoti-patch-1 created (now 9ebd2db627)

2023-10-06 Thread pankajkoti
This is an automated email from the ASF dual-hosted git repository. pankajkoti pushed a change to branch pankajkoti-patch-1 in repository https://gitbox.apache.org/repos/asf/airflow.git at 9ebd2db627 Update taskflow.rst This branch includes the following new commits: new 9ebd2db627

[airflow] 01/01: Update taskflow.rst

2023-10-06 Thread pankajkoti
This is an automated email from the ASF dual-hosted git repository. pankajkoti pushed a commit to branch pankajkoti-patch-1 in repository https://gitbox.apache.org/repos/asf/airflow.git commit 9ebd2db6279bb62e65daf429d02f02abf370be99 Author: Pankaj Koti AuthorDate: Fri Oct 6 16:41:58 2023 -0700

Re: [PR] Check if the lower of provided values are sensitives in config endpoint [airflow]

2023-10-06 Thread via GitHub
potiuk commented on code in PR #34712: URL: https://github.com/apache/airflow/pull/34712#discussion_r1349384221 ## airflow/api_connexion/endpoints/config_endpoint.py: ## @@ -123,7 +123,7 @@ def get_value(section: str, option: str) -> Response: "Config not

Re: [PR] Use the extra_args in get_key() [airflow]

2023-10-06 Thread via GitHub
ferruzzi commented on PR #25835: URL: https://github.com/apache/airflow/pull/25835#issuecomment-1751473029 This is pretty old, but if it's still an issue, how do we feel about accepting extra_args and then checking it against

Re: [PR] Add `get_ui_field_behaviour()` method to PostgresHook [airflow]

2023-10-06 Thread via GitHub
boring-cyborg[bot] commented on PR #34811: URL: https://github.com/apache/airflow/pull/34811#issuecomment-1751472205 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Add `get_ui_field_behaviour()` method to PostgresHook [airflow]

2023-10-06 Thread via GitHub
pubudu91 opened a new pull request, #34811: URL: https://github.com/apache/airflow/pull/34811 Fixes #34799 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [I] Airflow postgres connection field schema points to database name [airflow]

2023-10-06 Thread via GitHub
pubudu91 commented on issue #34799: URL: https://github.com/apache/airflow/issues/34799#issuecomment-1751460701 @Taragolis Was playing around with Airflow a bit, so tried out the fix suggested above. Can you please see if this is ok? If so, will send in a PR.

Re: [PR] Migrate provider-specific executor docs to providers [airflow]

2023-10-06 Thread via GitHub
RNHTTR commented on PR #34809: URL: https://github.com/apache/airflow/pull/34809#issuecomment-1751443900 It's currently unclear why I'm able to reference ``:doc:`apache-airflow:` ``, but I can't seem to link, for example, ``:doc:`apache-airflow-providers-celery:celery_executor` ``

[PR] Remove unused set from `SchedulerJobRunner` [airflow]

2023-10-06 Thread via GitHub
jedcunningham opened a new pull request, #34810: URL: https://github.com/apache/airflow/pull/34810 This hasn't been used in a while, I just simply forgot to remove it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Migrate provider-specific executor docs to providers [airflow]

2023-10-06 Thread via GitHub
RNHTTR opened a new pull request, #34809: URL: https://github.com/apache/airflow/pull/34809 Closes: #33916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add debug log saying whats being run to `EventScheduler` [airflow]

2023-10-06 Thread via GitHub
jedcunningham opened a new pull request, #34808: URL: https://github.com/apache/airflow/pull/34808 It can be difficult to debug issues in things the EventScheduler runs, especially if they don't log anything meaningful themselves. A simple "Hey, I'm going to run x" debug level log is

Re: [PR] Fix broken breeze by fixing packaging version [airflow]

2023-10-06 Thread via GitHub
Joffreybvn commented on PR #34701: URL: https://github.com/apache/airflow/pull/34701#issuecomment-1751399961 Had the same issue today on a fresh Fedora system, installing pipx via `brew`. ``` (airflow) [joffreybvn@fedora airflow]$ breeze Traceback (most recent call last):

[PR] Glue DataBrew operator [airflow]

2023-10-06 Thread via GitHub
ellisms opened a new pull request, #34807: URL: https://github.com/apache/airflow/pull/34807 --- Created Glue DataBrew start job Operator. Issue https://github.com/apache/airflow/issues/22037 -- This is an automated message from the Apache Git

Re: [PR] Fix broken breeze by fixing packaging version [airflow]

2023-10-06 Thread via GitHub
potiuk commented on PR #34701: URL: https://github.com/apache/airflow/pull/34701#issuecomment-1751325319 > Some CI jobs load the scripts files from main ( @hussein-awala (and others) for the future - the way for committers to test such a PR is to make PR from "airflow" repo, not from

Re: [PR] Make core compatible with `pendulum` 3 [airflow]

2023-10-06 Thread via GitHub
notatallshaw-gts commented on code in PR #34744: URL: https://github.com/apache/airflow/pull/34744#discussion_r1349248206 ## tests/models/test_dag.py: ## @@ -94,10 +95,17 @@ from tests.test_utils.timetables import cron_timetable, delta_timetable TEST_DATE =

Re: [PR] Refactor: Simplify string generation in providers [airflow]

2023-10-06 Thread via GitHub
eladkal commented on PR #34221: URL: https://github.com/apache/airflow/pull/34221#issuecomment-1751273261 ping @eumiro can you address comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Upgrade watchtower to 3.0.1 (#25019) [airflow]

2023-10-06 Thread via GitHub
eladkal commented on PR #34747: URL: https://github.com/apache/airflow/pull/34747#issuecomment-1751245626 > P.S. Would someone be able to add the hacktoberfest-accepted label to this PR? we are not participating in hacktoberfest this year but if this helps you I'm happy to

[airflow] branch main updated: Refactor consolidate import from io in providers (#34378)

2023-10-06 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 8e26865763 Refactor consolidate import from io

Re: [PR] Refactor consolidate import from io in providers [airflow]

2023-10-06 Thread via GitHub
vincbeck merged PR #34378: URL: https://github.com/apache/airflow/pull/34378 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349194668 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349164163 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349164163 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349164163 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349153518 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349154676 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349153518 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349150046 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349148088 ## airflow/auth/managers/fab/openapi/v1.yaml: ## @@ -0,0 +1,712 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349146671 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349145799 ## airflow/auth/managers/fab/openapi/v1.yaml: ## @@ -0,0 +1,712 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349145001 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349143656 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349142189 ## airflow/www/extensions/init_views.py: ## @@ -308,5 +318,16 @@ def init_api_experimental(app): "The authenticated user has full access.",

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349140315 ## airflow/auth/managers/fab/openapi/v1.yaml: ## @@ -0,0 +1,712 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1349135821 ## airflow/api_connexion/endpoints/forward_to_fab_endpoint.py: ## @@ -0,0 +1,126 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

Re: [PR] Reset stats logger instance in daemon context to reinitialize in chil… [airflow]

2023-10-06 Thread via GitHub
pavansharma36 commented on PR #34769: URL: https://github.com/apache/airflow/pull/34769#issuecomment-1751164151 @hussein-awala Actually I am not aware of writing test with daemon context. And this issue requires statsd metrics enabled and creating connection with actual host --

[airflow] branch main updated: zoneinfo.ZoneInfo is not available on < Python 3.9 (#34804)

2023-10-06 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 25cd12d307 zoneinfo.ZoneInfo is not available on

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
vincbeck merged PR #34804: URL: https://github.com/apache/airflow/pull/34804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] WIP: Add Airflow FS [airflow]

2023-10-06 Thread via GitHub
bolkedebruin commented on PR #34729: URL: https://github.com/apache/airflow/pull/34729#issuecomment-1751148942 @uranusjr context manager included now so you can do: ```python with afs.mount("s3://warehouse") as mnt: mnt.copy(x, y) ``` and (Pure)Path interface:

Re: [PR] Remove unused argument metadata from es_read and make clearly private [airflow]

2023-10-06 Thread via GitHub
eladkal commented on code in PR #34790: URL: https://github.com/apache/airflow/pull/34790#discussion_r1348968540 ## airflow/providers/elasticsearch/CHANGELOG.rst: ## @@ -27,6 +27,17 @@ Changelog - +5.1.0 +. + +Misc + Review Comment: please remove. we

Re: [PR] Remove unused argument metadata from es_read and make clearly private [airflow]

2023-10-06 Thread via GitHub
dstandish commented on PR #34790: URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751093699 ok @eladkal i added the docs note. i also renamed it `_es_read`. if you think the method rename goes too far LMK -- This is an automated message from the Apache Git Service. To

Re: [PR] Update es read query to not use body [airflow]

2023-10-06 Thread via GitHub
dstandish commented on PR #34792: URL: https://github.com/apache/airflow/pull/34792#issuecomment-1751057934 I fixed the calls so that they work with 8.10... I have a hunch that to fix the _tests_ in this PR we'll need to bump es version to 8.10 -- This is an automated message

Re: [PR] Remove unused argument metadata from es_read [airflow]

2023-10-06 Thread via GitHub
dstandish commented on PR #34790: URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751054119 > I'm fine with it but lets at least add entry about this in the change log that explains this decision. Simply log it at the top of the provider change log I will handle the style

Re: [PR] Remove unused argument metadata from es_read [airflow]

2023-10-06 Thread via GitHub
jedcunningham commented on PR #34790: URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751050176 > well, if we're gonna do that, should we go all out and make it `_es_read` / `:meta private:`? Works for me. -- This is an automated message from the Apache Git

Re: [PR] Remove unused argument metadata from es_read [airflow]

2023-10-06 Thread via GitHub
eladkal commented on PR #34790: URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751047992 > My take is it's internal to the ES log handler, shouldn't be a problem to remove it. I'm fine with it but lets at least add entry about this in the change log that explains this

Re: [PR] Remove unused argument metadata from es_read [airflow]

2023-10-06 Thread via GitHub
dstandish commented on PR #34790: URL: https://github.com/apache/airflow/pull/34790#issuecomment-1751033093 > My take is it's internal to the ES log handler, shouldn't be a problem to remove it. well, if we're gonna do that, should we go all out and make it `_es_read` / `:meta

Re: [PR] Update es read query to not use body [airflow]

2023-10-06 Thread via GitHub
Owen-CH-Leung commented on PR #34792: URL: https://github.com/apache/airflow/pull/34792#issuecomment-1751023560 Hmm Indeed. It looks like `body` param is getting deprecated soon. I was diving into the `v8.10.0` library (the latest v8 one) here, and I believe it will print this warning

Re: [PR] Open Search Provider [airflow]

2023-10-06 Thread via GitHub
ferruzzi commented on PR #34705: URL: https://github.com/apache/airflow/pull/34705#issuecomment-1751018425 > I think would be easier to just squash all commits Yeah, given that there is no impact, I'll agree there. -- This is an automated message from the Apache Git Service. To

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
ferruzzi commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348927935 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Let auth managers provide their own API endpoints [airflow]

2023-10-06 Thread via GitHub
jedcunningham commented on code in PR #34349: URL: https://github.com/apache/airflow/pull/34349#discussion_r1348918078 ## airflow/auth/managers/base_auth_manager.py: ## @@ -50,6 +50,10 @@ def get_cli_commands() -> list[CLICommand]: """ return [] +def

Re: [PR] bump open api image to v7.0.1 [airflow]

2023-10-06 Thread via GitHub
ephraimbuddy commented on code in PR #34805: URL: https://github.com/apache/airflow/pull/34805#discussion_r1348872581 ## clients/gen/common.sh: ## @@ -17,7 +17,7 @@ # specific language governing permissions and limitations # under the License.

Re: [PR] Update es read query to not use body [airflow]

2023-10-06 Thread via GitHub
eladkal commented on PR #34792: URL: https://github.com/apache/airflow/pull/34792#issuecomment-1750875905 cc @Owen-CH-Leung you mentioned the count api in https://github.com/apache/airflow/pull/33135/files#r1285877721 -- This is an automated message from the Apache Git Service. To

Re: [PR] Add Client Version 2.6.0 [airflow-client-go]

2023-10-06 Thread via GitHub
DrFaust92 commented on PR #43: URL: https://github.com/apache/airflow-client-go/pull/43#issuecomment-1750834532 Ive opened https://github.com/apache/airflow/pull/34805 to generate project with newer go version and deps. after that ill revise the CI to build with newer go version

[PR] bump open api image to v7.0.1 [airflow]

2023-10-06 Thread via GitHub
DrFaust92 opened a new pull request, #34805: URL: https://github.com/apache/airflow/pull/34805 --- **^ Add meaningful description above** Read the **[Pull Request

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348835042 ## airflow/serialization/serializers/timezone.py: ## @@ -29,10 +30,15 @@ serializers = [ "pendulum.tz.timezone.FixedTimezone",

Re: [PR] bump go and test only recent go versions [airflow-client-go]

2023-10-06 Thread via GitHub
DrFaust92 closed pull request #44: bump go and test only recent go versions URL: https://github.com/apache/airflow-client-go/pull/44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] bump go and test only recent go versions [airflow-client-go]

2023-10-06 Thread via GitHub
DrFaust92 opened a new pull request, #44: URL: https://github.com/apache/airflow-client-go/pull/44 https://endoflife.date/go project uses very old go. bump and update CI to test only matrix of active go versions -- This is an automated message from the Apache Git Service. To

Re: [PR] Fix handling of single quotes in RedshiftToS3Operator [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on PR #32915: URL: https://github.com/apache/airflow/pull/32915#issuecomment-1750805558 Hey @ashwaq06, let's to o through your first PR :) I know it can be hard. Could you resolve first the static failures? If you go to "Files changes" in this PR, you'll see them all.

[airflow] branch main updated: Upgrade watchtower to 3.0.1 (#25019) (#34747)

2023-10-06 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new c01abd1c2e Upgrade watchtower to 3.0.1 (#25019)

Re: [PR] Upgrade watchtower to 3.0.1 (#25019) [airflow]

2023-10-06 Thread via GitHub
boring-cyborg[bot] commented on PR #34747: URL: https://github.com/apache/airflow/pull/34747#issuecomment-1750787409 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional

Re: [I] update watchtower version in amazon provider [airflow]

2023-10-06 Thread via GitHub
vincbeck closed issue #25019: update watchtower version in amazon provider URL: https://github.com/apache/airflow/issues/25019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Upgrade watchtower to 3.0.1 (#25019) [airflow]

2023-10-06 Thread via GitHub
vincbeck merged PR #34747: URL: https://github.com/apache/airflow/pull/34747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
ephraimbuddy commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348784074 ## airflow/serialization/serializers/timezone.py: ## @@ -29,10 +30,15 @@ serializers = [ "pendulum.tz.timezone.FixedTimezone",

[airflow] branch main updated: Deprecate lazy import `AirflowException` from airflow (#34541)

2023-10-06 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7764a51ac9 Deprecate lazy import

Re: [PR] Deprecate lazy import `AirflowException` from airflow [airflow]

2023-10-06 Thread via GitHub
vincbeck merged PR #34541: URL: https://github.com/apache/airflow/pull/34541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
bolkedebruin commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348795710 ## airflow/serialization/serializers/timezone.py: ## @@ -29,10 +30,15 @@ serializers = [ "pendulum.tz.timezone.FixedTimezone",

Re: [PR] WIP: Add Airflow FS [airflow]

2023-10-06 Thread via GitHub
bolkedebruin commented on PR #34729: URL: https://github.com/apache/airflow/pull/34729#issuecomment-1750772291 @uranusjr sorry I see now that I accidentally edited your comment :-P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
ephraimbuddy commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348784074 ## airflow/serialization/serializers/timezone.py: ## @@ -29,10 +30,15 @@ serializers = [ "pendulum.tz.timezone.FixedTimezone",

Re: [PR] Add back decorator `has_access` [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on PR #34786: URL: https://github.com/apache/airflow/pull/34786#issuecomment-1750735846 > > > @vincbeck @ashb Should we also update the [public interface document](https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html) to include

Re: [I] Airflow task log handling broken for non-Kubernetes executors [airflow]

2023-10-06 Thread via GitHub
taharah commented on issue #34783: URL: https://github.com/apache/airflow/issues/34783#issuecomment-1750713541 @Taragolis thank you for looking into this so quickly! Shortly after opening this issue, I was able to identify the real root cause for why our logs stopped being written to S3.

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348746923 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348746185 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [I] need to run airflow cli command "airflow dags details" for multiple DAG IDs [airflow]

2023-10-06 Thread via GitHub
erdos2n commented on issue #34765: URL: https://github.com/apache/airflow/issues/34765#issuecomment-1750705631 I'm happy to pick this up if we want to move forward with this suggestion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348730693 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[airflow] branch main updated: Do not mock `isinstance` in Amazon Tests (#34800)

2023-10-06 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7e896c513a Do not mock `isinstance` in Amazon

Re: [PR] Do not mock `isinstance` in Amazon Tests [airflow]

2023-10-06 Thread via GitHub
vincbeck merged PR #34800: URL: https://github.com/apache/airflow/pull/34800 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Do not mock `isinstance` in Amazon Tests [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on PR #34800: URL: https://github.com/apache/airflow/pull/34800#issuecomment-1750692131 Nice cleanup! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348727907 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348720686 ## airflow/providers/amazon/aws/operators/base_aws.py: ## @@ -0,0 +1,152 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348721685 ## setup.py: ## @@ -462,7 +462,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve _devel_only_tests = [ "aioresponses",

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
bolkedebruin commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348722649 ## setup.py: ## @@ -462,7 +462,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve _devel_only_tests = [

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on code in PR #34804: URL: https://github.com/apache/airflow/pull/34804#discussion_r1348718064 ## setup.py: ## @@ -462,7 +462,7 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve _devel_only_tests = [ "aioresponses",

Re: [PR] Open Search Provider [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on code in PR #34705: URL: https://github.com/apache/airflow/pull/34705#discussion_r1348704834 ## airflow/providers/opensearch/hooks/opensearch.py: ## @@ -0,0 +1,122 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

Re: [PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
bolkedebruin commented on PR #34804: URL: https://github.com/apache/airflow/pull/34804#issuecomment-1750670381 I need some help here, cause I am not sure how to fix this? Maybe @uranusjr @Taragolis ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on PR #34784: URL: https://github.com/apache/airflow/pull/34784#issuecomment-1750665063 >I assume followup PR would be to change AWS operators/hooks to inherit from the base classes? Yep > We need also doc update to explain how to set the botocore

Re: [I] Recent changes to timezone support broke some operators [airflow]

2023-10-06 Thread via GitHub
vincbeck commented on issue #34673: URL: https://github.com/apache/airflow/issues/34673#issuecomment-1750653965 I confirm. Our system test passes now. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Airflow postgres connection field schema points to database name [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on issue #34799: URL: https://github.com/apache/airflow/issues/34799#issuecomment-1750570840 I've marked as "good first issue" it should be a simple change, just need to implements `get_ui_field_behaviour` on PostgresHook Some examples in other Hooks

Re: [I] EcsRunTaskOperator [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on issue #34802: URL: https://github.com/apache/airflow/issues/34802#issuecomment-1750558710 Could you also provide information about installed providers? Did you use try to use latest AWS Provider? -- This is an automated message from the Apache Git Service. To

Re: [I] Airflow postgres connection field schema points to database name [airflow]

2023-10-06 Thread via GitHub
dinu-bilt commented on issue #34799: URL: https://github.com/apache/airflow/issues/34799#issuecomment-1750554984 Yes that'd be ideal. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]

2023-10-06 Thread via GitHub
utkarsharma2 commented on PR #34647: URL: https://github.com/apache/airflow/pull/34647#issuecomment-1750553531 @uranusjr The failure on the PR don't look related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Move cli's Connection export and Variable export command print logic to a seprate function [airflow]

2023-10-06 Thread via GitHub
utkarsharma2 commented on code in PR #34647: URL: https://github.com/apache/airflow/pull/34647#discussion_r1348646994 ## airflow/cli/utils.py: ## @@ -40,3 +40,10 @@ def is_stdout(fileio: IOBase) -> bool: .. warning:: *fileio* must be open for this check to be successful.

Re: [I] Airflow postgres connection field schema points to database name [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on issue #34799: URL: https://github.com/apache/airflow/issues/34799#issuecomment-1750547691 @dinu-bilt Are you sure that we need to close this issue? At least we could rename field in the Connection UI. -- This is an automated message from the Apache Git Service.

Re: [PR] Implements `AwsBaseOperator` and `AwsBaseSensor` [airflow]

2023-10-06 Thread via GitHub
Taragolis commented on code in PR #34784: URL: https://github.com/apache/airflow/pull/34784#discussion_r1348641033 ## tests/always/test_project_structure.py: ## @@ -403,6 +403,9 @@ class TestAmazonProviderProjectStructure(ExampleCoverageTest):

[PR] zoneinfo.ZoneInfo is not available on < Python 3.9 [airflow]

2023-10-06 Thread via GitHub
bolkedebruin opened a new pull request, #34804: URL: https://github.com/apache/airflow/pull/34804 Tests were not functioning due to checks if classes could be imported from serializers. @Taragolis @ferruzzi --- **^ Add meaningful description

Re: [I] EcsRunTaskOperator [airflow]

2023-10-06 Thread via GitHub
boring-cyborg[bot] commented on issue #34802: URL: https://github.com/apache/airflow/issues/34802#issuecomment-1750490712 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for

[I] EcsRunTaskOperator [airflow]

2023-10-06 Thread via GitHub
rotemlevibigabid opened a new issue, #34802: URL: https://github.com/apache/airflow/issues/34802 ### Apache Airflow version 2.7.1 ### What happened EcsRunTaskOperator on deferrable mode ecs task Exit code: 0 but deferrable task never ends ### What you think

  1   2   >