Re: [I] Otel timing observer overrides it's value [airflow]

2023-10-18 Thread via GitHub
YonatanKiron commented on issue #35036: URL: https://github.com/apache/airflow/issues/35036#issuecomment-1770177454 Another way to reproduce: ```python from airflow.stats import Stats Stats.timing(f"dagrun.duration.success", **{"dt":1000, "tags":{"dag_id": "bla"}}) Stats.timi

[PR] Fix for infinite recursion due to secrets_masker [airflow]

2023-10-18 Thread via GitHub
Usiel opened a new pull request, #35048: URL: https://github.com/apache/airflow/pull/35048 We can get into trouble for text types that cannot be initiated with re2's `type(obj)()` call. The `secrets_masker` thus fails, which triggers a warning log, which also fails because we pass the objec

Re: [PR] Fix: Typos inside /docs [airflow]

2023-10-18 Thread via GitHub
boring-cyborg[bot] commented on PR #35047: URL: https://github.com/apache/airflow/pull/35047#issuecomment-1770089737 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Fix: Typos inside /docs [airflow]

2023-10-18 Thread via GitHub
parikshit-adhikari opened a new pull request, #35047: URL: https://github.com/apache/airflow/pull/35047 Multiple typos inside /docs directory have been fixed. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://gith

Re: [I] Status of testing Providers that were prepared on October 18, 2023 [airflow]

2023-10-18 Thread via GitHub
cjames23 commented on issue #35030: URL: https://github.com/apache/airflow/issues/35030#issuecomment-1769843690 #34705 works as expected -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Remove legacy in pythonoperator example [airflow]

2023-10-18 Thread via GitHub
boring-cyborg[bot] commented on PR #35046: URL: https://github.com/apache/airflow/pull/35046#issuecomment-1769819998 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Update README.rst [airflow]

2023-10-18 Thread via GitHub
RNHTTR opened a new pull request, #35045: URL: https://github.com/apache/airflow/pull/35045 Make the --package-filter flag a bit more clear, and demonstrate that it can be used for multiple packages. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Feature azure synapse run pipeline operator. [airflow]

2023-10-18 Thread via GitHub
boring-cyborg[bot] commented on PR #35044: URL: https://github.com/apache/airflow/pull/35044#issuecomment-1769740117 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Feature azure synapse run pipeline operator. [airflow]

2023-10-18 Thread via GitHub
ambika-garg opened a new pull request, #35044: URL: https://github.com/apache/airflow/pull/35044 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideli

Re: [I] EcsRunTaskOperator [airflow]

2023-10-18 Thread via GitHub
shubham22 commented on issue #34802: URL: https://github.com/apache/airflow/issues/34802#issuecomment-1769670330 @rotemlevibigabid - are you still running into this issue? If so, could you please add more information as Andrey requested? Also, please confirm that you run into this issue in

Re: [PR] Deferrable sensors can timeout with no retries [airflow]

2023-10-18 Thread via GitHub
github-actions[bot] closed pull request #33718: Deferrable sensors can timeout with no retries URL: https://github.com/apache/airflow/pull/33718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Try fixing non direct upstream -- separate dep approach [airflow]

2023-10-18 Thread via GitHub
github-actions[bot] closed pull request #33820: Try fixing non direct upstream -- separate dep approach URL: https://github.com/apache/airflow/pull/33820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add druid ingestion connection test [airflow]

2023-10-18 Thread via GitHub
github-actions[bot] commented on PR #33796: URL: https://github.com/apache/airflow/pull/33796#issuecomment-1769668133 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364704230 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :pa

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364704230 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :pa

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364704230 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :pa

[airflow] branch constraints-main updated: Updating constraints. Github run id:6566921418

2023-10-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new e11cd25547 Updating con

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364694485 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :par

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364691218 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :par

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364689097 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :par

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364685496 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :pa

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364681170 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -1047,6 +1047,33 @@ def test_download_file_with_preserve_name_file_already_exists(self, tmp_path):

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364680241 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -1047,6 +1047,33 @@ def test_download_file_with_preserve_name_file_already_exists(self, tmp_path):

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364679959 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :par

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364676943 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :pa

Re: [PR] Pass extra configs to `ClientSecretCredential` and `SparkClient` in `AzureSynapseHook` [airflow]

2023-10-18 Thread via GitHub
Adaverse commented on PR #35024: URL: https://github.com/apache/airflow/pull/35024#issuecomment-1769531090 > Could you fix the static checks? Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364661974 ## airflow/providers/amazon/aws/hooks/s3.py: ## @@ -912,14 +912,27 @@ def get_key(self, key: str, bucket_name: str | None = None) -> S3ResourceObject: :par

Re: [PR] Feature: Allow description to be passed in when using variables CLI [airflow]

2023-10-18 Thread via GitHub
Zhenye-Na commented on code in PR #34791: URL: https://github.com/apache/airflow/pull/34791#discussion_r1364647707 ## tests/cli/commands/test_variable_command.py: ## @@ -49,6 +49,15 @@ def test_variables_set(self): with pytest.raises(KeyError): Variable.get

Re: [PR] Add decorators for external and venv python branching operators [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #35043: URL: https://github.com/apache/airflow/pull/35043#issuecomment-1769509822 Looks really nice. But how about adding Howtos/Examples to https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/python.html folllowing other operators? I think otherwise

Re: [PR] feat(dockerfile): Add pip caching for faster build [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #35026: URL: https://github.com/apache/airflow/pull/35026#issuecomment-1769500355 > This might be useful to someone playing with the requirements file to resolve a conflict, so if there is no potential risk from this change I would be OK with merging it. Yep I

Re: [I] Status of testing Providers that were prepared on October 18, 2023 [airflow]

2023-10-18 Thread via GitHub
hussein-awala commented on issue #35030: URL: https://github.com/apache/airflow/issues/35030#issuecomment-1769450139 #34954 works as expected! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] feat(dockerfile): Add pip caching for faster build [airflow]

2023-10-18 Thread via GitHub
hussein-awala commented on PR #35026: URL: https://github.com/apache/airflow/pull/35026#issuecomment-1769427274 > but there also you will see reinstallation only happening if you change requirements.txt. And yes - in this case it will be a bit faster when you just add one requirement, but t

[PR] Add decorators for external and venv python branching operators [airflow]

2023-10-18 Thread via GitHub
jens-scheffler-bosch opened a new pull request, #35043: URL: https://github.com/apache/airflow/pull/35043 This PR is a follow-up of PR #33356 to add also python decorators for additional branching tasks for: - external python - python virtual environments To make the feature set com

[airflow] branch main updated: Fix update-constraints command example (#35042)

2023-10-18 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 50f6483b24 Fix update-constraints command e

Re: [PR] Fix update-constraints command examples [airflow]

2023-10-18 Thread via GitHub
pierrejeambrun merged PR #35042: URL: https://github.com/apache/airflow/pull/35042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@a

[PR] Fix update-constraints command example [airflow]

2023-10-18 Thread via GitHub
pierrejeambrun opened a new pull request, #35042: URL: https://github.com/apache/airflow/pull/35042 Command is expecting `airflow-constraints-mode`. Omitting this will fail the command with `Invalid airflow-constraints-mode` -- This is an automated message from the Apache Git Service. To

[airflow] tag constraints-2.3.1 updated (487ca381e1 -> 5f51889a8f)

2023-10-18 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to tag constraints-2.3.1 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.1 was modified! *** from 487ca381e1 (tag) to 5f51889a8f (commit)

[airflow] branch constraints-2.3.1-fix updated: Update PyYaml constraints to account for CPython 3 incompatibility

2023-10-18 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch constraints-2.3.1-fix in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2.3.1-fix by this push: new 5f51889a

Re: [PR] Move `BaseOperatorLink` into the separate module [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on PR #35032: URL: https://github.com/apache/airflow/pull/35032#issuecomment-1769336661 Community providers should not raise warnings, because all of them use lazy import from airflow.models -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Move `BaseOperatorLink` into the separate module [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #35032: URL: https://github.com/apache/airflow/pull/35032#issuecomment-1769330367 The new packages should be added here: https://airflow.apache.org/docs/apache-airflow/stable/public-airflow-interface.html Also - are we going to update the providers with importin

Re: [PR] Fix spellcheck error. [airflow]

2023-10-18 Thread via GitHub
potiuk merged PR #35041: URL: https://github.com/apache/airflow/pull/35041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated: Fix spellcheck error. (#35041)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new ff25411980 Fix spellcheck error. (#35041) ff2541198

Re: [PR] Fix spellcheck error. [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #35041: URL: https://github.com/apache/airflow/pull/35041#issuecomment-1769319531 New pre-commit is more picky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix spellcheck error. [airflow]

2023-10-18 Thread via GitHub
potiuk opened a new pull request, #35041: URL: https://github.com/apache/airflow/pull/35041 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

[airflow] tag constraints-2.3.0 updated (a0293a0b13 -> 089691f009)

2023-10-18 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to tag constraints-2.3.0 in repository https://gitbox.apache.org/repos/asf/airflow.git *** WARNING: tag constraints-2.3.0 was modified! *** from a0293a0b13 (tag) to 089691f009 (commit)

[airflow] branch main updated: ADd missing dependency generate-constraints => build prod image (#35040)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 1d08e8bde9 ADd missing dependency generate-constrai

Re: [PR] Add missing dependency generate-constraints => build prod image [airflow]

2023-10-18 Thread via GitHub
potiuk merged PR #35040: URL: https://github.com/apache/airflow/pull/35040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch constraints-2.3.0-fix updated: Update PyYaml constraints to account for CPython 3 incompatibility

2023-10-18 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch constraints-2.3.0-fix in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-2.3.0-fix by this push: new 089691f0

Re: [PR] Add DagModel attributes before dumping DagDetailSchema for get_dag_details API endpoint [airflow]

2023-10-18 Thread via GitHub
RNHTTR commented on code in PR #34947: URL: https://github.com/apache/airflow/pull/34947#discussion_r1364524936 ## airflow/api_connexion/endpoints/dag_endpoint.py: ## @@ -66,6 +66,11 @@ def get_dag_details(*, dag_id: str) -> APIResponse: dag: DAG = get_airflow_app().dag_bag

Re: [PR] Add use_krb5ccache option to SparkSubmitHook [airflow]

2023-10-18 Thread via GitHub
eladkal commented on code in PR #34386: URL: https://github.com/apache/airflow/pull/34386#discussion_r1364524089 ## airflow/security/kerberos.py: ## @@ -59,10 +63,7 @@ def renew_from_kt(principal: str | None, keytab: str, exit_on_fail: bool = True) # minutes to give oursel

[airflow] branch main updated: Refactor: Extract and reuse get_kerberos_principle func from get_kerberos_principle (#34936)

2023-10-18 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 927b0bbe94 Refactor: Extract and reuse get_kerbero

Re: [PR] Refactor: Extract and reuse get_kerberos_principle func from get_kerberos_principle [airflow]

2023-10-18 Thread via GitHub
eladkal merged PR #34936: URL: https://github.com/apache/airflow/pull/34936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364522281 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -1047,6 +1047,33 @@ def test_download_file_with_preserve_name_file_already_exists(self, tmp_path):

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364522281 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -1047,6 +1047,33 @@ def test_download_file_with_preserve_name_file_already_exists(self, tmp_path):

Re: [PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on code in PR #35037: URL: https://github.com/apache/airflow/pull/35037#discussion_r1364518573 ## tests/providers/amazon/aws/hooks/test_s3.py: ## @@ -1047,6 +1047,33 @@ def test_download_file_with_preserve_name_file_already_exists(self, tmp_path):

Re: [PR] ADd missing dependency generate-constraints => build prod image [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #35040: URL: https://github.com/apache/airflow/pull/35040#issuecomment-1769258375 One more missing dependency in CI workflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] Status of testing Providers that were prepared on October 18, 2023 [airflow]

2023-10-18 Thread via GitHub
ellisms commented on issue #35030: URL: https://github.com/apache/airflow/issues/35030#issuecomment-1769258323 #34807 works fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[airflow] branch add-dependency-generate-build-prod updated (aebbb4194b -> 71dfa2bea7)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-dependency-generate-build-prod in repository https://gitbox.apache.org/repos/asf/airflow.git discard aebbb4194b ADd missing dependencu generate-constraints => build prod image add 71df

[airflow] 01/01: ADd missing dependencu generate-constraints => build prod image

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch add-dependency-generate-build-prod in repository https://gitbox.apache.org/repos/asf/airflow.git commit aebbb4194b3b3c1c1d94c9b123ff09a61bb6d5f1 Author: Jarek Potiuk AuthorDate: Wed Oct 18 22:17:

[PR] ADd missing dependencu generate-constraints => build prod image [airflow]

2023-10-18 Thread via GitHub
potiuk opened a new pull request, #35040: URL: https://github.com/apache/airflow/pull/35040 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

[airflow] branch add-dependency-generate-build-prod created (now aebbb4194b)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch add-dependency-generate-build-prod in repository https://gitbox.apache.org/repos/asf/airflow.git at aebbb4194b ADd missing dependencu generate-constraints => build prod image This branch

Re: [PR] Update datasets.rst issue with running example code [airflow]

2023-10-18 Thread via GitHub
jens-scheffler-bosch commented on code in PR #35035: URL: https://github.com/apache/airflow/pull/35035#discussion_r1364482519 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -230,8 +230,8 @@ Example: @task def print_triggering_dataset_events

[PR] Pass additional arguments from Slack's Operators/Notifiers to Hooks [airflow]

2023-10-18 Thread via GitHub
Taragolis opened a new pull request, #35039: URL: https://github.com/apache/airflow/pull/35039 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guideline

[PR] Move authentication related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck opened a new pull request, #35038: URL: https://github.com/apache/airflow/pull/35038 One of the many PR which move stuff related to FAB user management from security manager to auth manager. Code only being moved here. --- **^ Add meaning

[airflow] branch main updated: Update gcs.py Create and List comment Examples (#35028)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 63f3712d2e Update gcs.py Create and List comment Ex

Re: [PR] Update gcs.py Create and List comment Examples [airflow]

2023-10-18 Thread via GitHub
boring-cyborg[bot] commented on PR #35028: URL: https://github.com/apache/airflow/pull/35028#issuecomment-1769218466 Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.

Re: [PR] Update gcs.py Create and List comment Examples [airflow]

2023-10-18 Thread via GitHub
potiuk merged PR #35028: URL: https://github.com/apache/airflow/pull/35028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[airflow] branch main updated (a74ec408e6 -> a2060125dd)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from a74ec408e6 Fix `get_plugin_info` for class based listeners. (#35022) add a2060125dd Add Python Virtualenv Operator

Re: [PR] Add Python Virtualenv Operator Caching [airflow]

2023-10-18 Thread via GitHub
potiuk merged PR #33355: URL: https://github.com/apache/airflow/pull/33355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

[PR] Enable encryption in S3 download_files() hook. [airflow]

2023-10-18 Thread via GitHub
ferruzzi opened a new pull request, #35037: URL: https://github.com/apache/airflow/pull/35037 Hey all. I thought I'd take this one on. I think I got the code implemented but I can't seem to get the mocking in the unit test set up right. I'd love some suggestions. Closes: https://

[airflow] branch main updated: Fix `get_plugin_info` for class based listeners. (#35022)

2023-10-18 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new a74ec408e6 Fix `get_plugin_info` for class b

Re: [PR] Fix `get_plugin_info` for class based listeners. [airflow]

2023-10-18 Thread via GitHub
jedcunningham merged PR #35022: URL: https://github.com/apache/airflow/pull/35022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Update datasets.rst issue with running example code [airflow]

2023-10-18 Thread via GitHub
erik-farmer commented on code in PR #35035: URL: https://github.com/apache/airflow/pull/35035#discussion_r1364433952 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -230,8 +230,8 @@ Example: @task def print_triggering_dataset_events(triggeri

Re: [PR] Update datasets.rst issue with running example code [airflow]

2023-10-18 Thread via GitHub
erik-farmer commented on code in PR #35035: URL: https://github.com/apache/airflow/pull/35035#discussion_r1364433952 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -230,8 +230,8 @@ Example: @task def print_triggering_dataset_events(triggeri

Re: [PR] Upgrade pre-commits [airflow]

2023-10-18 Thread via GitHub
potiuk merged PR #35033: URL: https://github.com/apache/airflow/pull/35033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Update datasets.rst issue with running example code [airflow]

2023-10-18 Thread via GitHub
jens-scheffler-bosch commented on code in PR #35035: URL: https://github.com/apache/airflow/pull/35035#discussion_r1364414728 ## docs/apache-airflow/authoring-and-scheduling/datasets.rst: ## @@ -230,8 +230,8 @@ Example: @task def print_triggering_dataset_events

Re: [I] Kubernetes pod log reding [airflow]

2023-10-18 Thread via GitHub
jens-scheffler-bosch commented on issue #35010: URL: https://github.com/apache/airflow/issues/35010#issuecomment-1769157181 Can you reveal to us which K8s version you are running in your on-prem setup? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [I] Otel timing observer overrides it's value [airflow]

2023-10-18 Thread via GitHub
boring-cyborg[bot] commented on issue #35036: URL: https://github.com/apache/airflow/issues/35036#issuecomment-1769148559 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

[I] Otel timing observer overrides it's value [airflow]

2023-10-18 Thread via GitHub
YonatanKiron opened a new issue, #35036: URL: https://github.com/apache/airflow/issues/35036 ### Apache Airflow version 2.7.2 ### What happened I have two DAGs that constantly pass, one reported to otel agent while the other didn't. After looking into the logs (in

Re: [PR] AWS ECS Executor [airflow]

2023-10-18 Thread via GitHub
syedahsn commented on code in PR #34381: URL: https://github.com/apache/airflow/pull/34381#discussion_r1364375052 ## airflow/providers/amazon/aws/executors/ecs/Dockerfile: ## @@ -0,0 +1,86 @@ +# hadolint ignore=DL3007 +FROM apache/airflow:latest Review Comment: We decided to

Re: [PR] Update datasets.rst issue with running example code [airflow]

2023-10-18 Thread via GitHub
boring-cyborg[bot] commented on PR #35035: URL: https://github.com/apache/airflow/pull/35035#issuecomment-1769142109 Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution

[PR] Update datasets.rst issue with running example code [airflow]

2023-10-18 Thread via GitHub
erik-farmer opened a new pull request, #35035: URL: https://github.com/apache/airflow/pull/35035 Fixes two small issues with running code from the dataset.rst example. `dataset_list` is a list so running `print(dataset, dataset_list, dataset_list[dataset])` causes a `TypeError: list i

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769139998 > Here is the way I see it :) There is no such api_auth in auth managers. There are API auth provided by Airflow itself (session, default and deny_all) and API auth provided by auth mana

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769137290 > As far as I understand (and I might be wrong), currently the way how to configure backends in order to get the UI working is: airflow.api.auth.backend.basic_auth,airflow.api.auth.bac

[airflow] branch main updated (902b9b3210 -> 71ac41aed2)

2023-10-18 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 902b9b3210 Add opensearch to boring-cyborg.yml (#35031) add 71ac41aed2 Upgrade `pip` to 23.3 (#35029) No new revi

Re: [PR] Upgrade `pip` to 23.3 [airflow]

2023-10-18 Thread via GitHub
potiuk merged PR #35029: URL: https://github.com/apache/airflow/pull/35029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Upgrade pre-commits [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #35033: URL: https://github.com/apache/airflow/pull/35033#issuecomment-1769127493 > The new version of codespell looks much better than the previous one! Indeed. And more troublesome. And it actually detected ``PostregsSQL`` which I tried to fix three times in s

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769122593 > Nice! This way, you just need to do something similar if you want your auth manager to provider Kerberos support! Precisely -- This is an automated message from the Apache Git

Re: [I] Kubernetes doubling logs [airflow]

2023-10-18 Thread via GitHub
jens-scheffler-bosch commented on issue #35019: URL: https://github.com/apache/airflow/issues/35019#issuecomment-1769122196 Thanks for the bug report. As I don't have a local K8s cluster to reproduce, can you tell us if you are using deferred mode or "normal" execution? Assuming you use a K

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769121909 > > Another solution would be to return NotImplemented by default and try/catch this exception. If this exception is thrown, then no Kerberos > > I'd say we could just leave a ba

[I] Implement `files_upload_v2` in Slack Provider [airflow]

2023-10-18 Thread via GitHub
Taragolis opened a new issue, #35034: URL: https://github.com/apache/airflow/issues/35034 ### Body Slack API `files.upload` method might failed due to timeout errors on large files, from `slack-sdk>=3.19` there is also available method in client `files_upload_v2` which should avoid t

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
potiuk commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769118838 > Another solution would be to return NotImplemented by default and try/catch this exception. If this exception is thrown, then no Kerberos I'd say we could just leave a base

Re: [PR] Move Rest API auth related methods to FAB auth manager [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on PR #34924: URL: https://github.com/apache/airflow/pull/34924#issuecomment-1769107921 > Obviously. I missed the fact that "session_auth" remained where it was. I see that "session" will remain where it was. Clear. And expectation is that if you implement an AuthManger a

[PR] Upgrade pre-commits [airflow]

2023-10-18 Thread via GitHub
potiuk opened a new pull request, #35033: URL: https://github.com/apache/airflow/pull/35033 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)*

Re: [I] Status of testing Providers that were prepared on October 18, 2023 [airflow]

2023-10-18 Thread via GitHub
Taragolis commented on issue #35030: URL: https://github.com/apache/airflow/issues/35030#issuecomment-1769102588 https://github.com/apache/airflow/pull/34969 - check, works fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[airflow] branch main updated: Add opensearch to boring-cyborg.yml (#35031)

2023-10-18 Thread eladkal
This is an automated email from the ASF dual-hosted git repository. eladkal pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 902b9b3210 Add opensearch to boring-cyborg.yml (#3

Re: [PR] Add opensearch to boring-cyborg.yml [airflow]

2023-10-18 Thread via GitHub
eladkal merged PR #35031: URL: https://github.com/apache/airflow/pull/35031 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.

[PR] Move `BaseOperatorLink` into the separate module [airflow]

2023-10-18 Thread via GitHub
Taragolis opened a new pull request, #35032: URL: https://github.com/apache/airflow/pull/35032 Move `BaseOperatorLink` from `airflow.models.baseoperator` into the separate module this might slightly reduce import in case of creation extra. In additional remove `check-b

Re: [I] Status of testing Providers that were prepared on October 18, 2023 [airflow]

2023-10-18 Thread via GitHub
vincbeck commented on issue #35030: URL: https://github.com/apache/airflow/issues/35030#issuecomment-1769077920 AWS system tests are using #34972 and it is working fine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] Add opensearch to boring-cyborg.yml [airflow]

2023-10-18 Thread via GitHub
eladkal opened a new pull request, #35031: URL: https://github.com/apache/airflow/pull/35031 --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)

  1   2   3   >